From nobody Mon May 25 16:06:38 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA06344D031 for ; Wed, 6 May 2026 16:48:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086091; cv=none; b=BZyCKKDRwimad7Vp9uXsTi9mj2qySe2A2k1deTht8fC1wxtOhwft0gqPHc6d/Ai70C2ZUGU98QrTpCjaSAOl1mTprsznSbhu3q7TceEcmrpy4738+MpE8956lA9TkfB5680nM/DjOvF/RhBx5gb0tJOKv64UbktPe8T11mu52ZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778086091; c=relaxed/simple; bh=4dmzSbmmw+DNF+WrXmgmnHMBAYVUq60hnV8ZXwFBP/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ro42qF/oDZZlZZyfadENqNg9dm31zjn6Tpa+/ngyQ/kp86ke02t1RVtCYWrLsN6HVZAxFxwI9z004iOgUaPJnrauaHeiF85ROG+oFQ1XGB9W08vEKgwdN8bhn2AcBnu1xzxyPBgB9udDvv6o2mdhjotn3FUhBFbaX2OW1kVV2aM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FKhDdbds; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FKhDdbds" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-44c4cc7c1cfso3320908f8f.0 for ; Wed, 06 May 2026 09:48:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778086087; x=1778690887; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YVORh6JNn+0XYtaz5jTVXMpA1GomYOXbazYzcdBmqLk=; b=FKhDdbds8NupWP443qcJxO7JVg3OD7UBwQDBK2whisuy/E05DEhiItq4rSwuv0c8g9 vW68O98l9rrV0a701B7e2AmznzPR65ZQd452L9A1wHbUHWFwZ7AEy2mf8Sv0Rch3tgPy Wk8204Vh7oN1O0/BaE4IB+Y/g0Z0C9TQiauTOOVyYxKy6Nu2UPkMt8/vD7MDujSU/19T Q++vuO1bbrUpj/t9p9QHIRDXR2ulkCgB0mF+oVKnQnS6u7jnM4y9wHer9MK1R5XLthIN sEGQ1UC3byw2CeYtwxjK2apcSskuk+h/GtrMAu4yio622ADzRF85tTXyAdRtpxk85mgt yprg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778086087; x=1778690887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YVORh6JNn+0XYtaz5jTVXMpA1GomYOXbazYzcdBmqLk=; b=VDIUEkqDq0gjIhlevhtZAnnoi0KEo1upaEQM1YRT/KyV2hYGU/TgcR3yPiouEYFydz gnU3i2o34v5k5uQumUQwgg+G3HIE7x87Agmc9mOVroLJdZxBnJwPanMzWJLf48ERYNqb o8cRgQnpuZ2Xv0zMQdHrV+34EinRGku9Nkum3TmVJg7ns916jgC+vIUjAdIfy2JG53Z2 kXBLoINfvWXZ/EJJXjT/EZjpHH+lWyDdnRwTCJoE1dbuBuq7V8x9UF+8XYhD8SBwaxG7 gcxCF2c+3/hGz3hzrXSfYMKQjClcQaOC9+p+kHPw7q4gHwiF3DSMZPzNImXYHo554H1x xmgg== X-Forwarded-Encrypted: i=1; AFNElJ+jUtpFSMGGSbwWHf6xbNe7L7LFstU5rIkOtZuv+Jv5f9/P4uzcoQaolrEHGGNdWmZeAzmEi0VfeaEPC2s=@vger.kernel.org X-Gm-Message-State: AOJu0YxAFp0X8+TuARpGav2486dFJ7xjGVK3vnPhcu8gBU8rcI0iKmHv jWMK9u0DOZHGnxvEtMmLSYTGw1wQADQPiHaiuDfyTnL6ld//22E7Phtz X-Gm-Gg: AeBDietsVwJKOMBbL7hv8WLpY4ZBo5oY9Vdt0KrhWZU7kyv3HYXzl35hIU1hDaRvQVe gl7lXmV6J25UTVTRmz8LgmwIZy+XAnLnp8wxJUPf7O/uhRxUrW3eZ0OUNZSEtfVPh2Bb7ln5uHU lxN6qA2r2pz2NkkXsDq7XB0AiVT6EbImIy3DFwVCjTHgI1ugFruII9kEqKUMPn5ZXgBAOQW3B/H Yb86Z6gMnx2EF+p8qqG3rbtnNfNrVIHcrVedSgU1q8w06NljBmMFdn/oDhwUN127tG2GIw/eRON cRNfsZn69cGKQwr1ylIduRomENp85lemI7PSeOTj9xP6VOfSpQo6AmOq0nyR/8A/c4lAVa4tnlS cNoqKSNAo20RbyPmpQK6D6AcPk73dEqu1H75/xmfO8hY8nw82WQGcV/zX11fx+I16Psjrqgeag/ OjgiOC5/Vmu+Xk0NoWGL9ueOp81tjgxrRxWEddHQ90dc8DnKlScZ6QOrz4wUej3uZBEXwnhKwa3 K9pmQ== X-Received: by 2002:a05:6000:22c3:b0:43e:a70d:763c with SMTP id ffacd0b85a97d-4515df65cc1mr7559336f8f.42.1778086087016; Wed, 06 May 2026 09:48:07 -0700 (PDT) Received: from dev-linux.homserver.local ([51.154.251.79]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45054b03df9sm13269791f8f.24.2026.05.06.09.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 09:48:06 -0700 (PDT) From: Vaibhav Gupta To: Joshua Washington , Harshitha Ramamurthy , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , Ankit Garg , Tim Hostetler , Alok Tiwari , John Fraker , Matt Olson , Praveen Kaligineedi Cc: Vaibhav Gupta , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Lobakin Subject: [PATCH net-next v2] gve: Use generic power management Date: Wed, 6 May 2026 16:47:39 +0000 Message-ID: <20260506164757.641640-1-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260504182139.604925-1-vaibhavgupta40@gmail.com> References: <20260504182139.604925-1-vaibhavgupta40@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch to the generic power management and remove the usage of legacy (pci_driver) hooks. Signed-off-by: Vaibhav Gupta Reviewed-by: Harshitha Ramamurthy Reviewed-by: Alexander Lobakin --- v2: wrap "&gve_pm_ops" inside pm_sleep_ptr(), and add 'net-next' tag, as suggested by Harshitha. --- drivers/net/ethernet/google/gve/gve_main.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_main.c b/drivers/net/ether= net/google/gve/gve_main.c index 424d973c97f2..00750643e614 100644 --- a/drivers/net/ethernet/google/gve/gve_main.c +++ b/drivers/net/ethernet/google/gve/gve_main.c @@ -2967,9 +2967,9 @@ static void gve_shutdown(struct pci_dev *pdev) rtnl_unlock(); } =20 -#ifdef CONFIG_PM -static int gve_suspend(struct pci_dev *pdev, pm_message_t state) +static int gve_suspend(struct device *dev) { + struct pci_dev *pdev =3D to_pci_dev(dev); struct net_device *netdev =3D pci_get_drvdata(pdev); struct gve_priv *priv =3D netdev_priv(netdev); bool was_up =3D netif_running(priv->dev); @@ -2990,8 +2990,9 @@ static int gve_suspend(struct pci_dev *pdev, pm_messa= ge_t state) return 0; } =20 -static int gve_resume(struct pci_dev *pdev) +static int gve_resume(struct device *dev) { + struct pci_dev *pdev =3D to_pci_dev(dev); struct net_device *netdev =3D pci_get_drvdata(pdev); struct gve_priv *priv =3D netdev_priv(netdev); int err; @@ -3004,7 +3005,8 @@ static int gve_resume(struct pci_dev *pdev) rtnl_unlock(); return err; } -#endif /* CONFIG_PM */ + +static DEFINE_SIMPLE_DEV_PM_OPS(gve_pm_ops, gve_suspend, gve_resume); =20 static const struct pci_device_id gve_id_table[] =3D { { PCI_DEVICE(PCI_VENDOR_ID_GOOGLE, PCI_DEV_ID_GVNIC) }, @@ -3017,10 +3019,7 @@ static struct pci_driver gve_driver =3D { .probe =3D gve_probe, .remove =3D gve_remove, .shutdown =3D gve_shutdown, -#ifdef CONFIG_PM - .suspend =3D gve_suspend, - .resume =3D gve_resume, -#endif + .driver.pm =3D pm_sleep_ptr(&gve_pm_ops), }; =20 module_pci_driver(gve_driver); --=20 2.53.0