From nobody Sat Jun 13 17:12:17 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 784ED2F12C6; Wed, 6 May 2026 08:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056958; cv=none; b=HEga/wE9UTZnKeiwtAqAUIVz+TBRMEigj0JPJyf/6Vr+ONJWru/098aQdLhNkkFnVr6AYP7d13XVp+aV7chdDldDur6c7fuNMdllGLokBvOEoF7ohHFz6oCzBKGVm5p8uMbx7iK3z0k1wIciRVJasjyFtQpGqt1XjnCmCOh+53U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056958; c=relaxed/simple; bh=CCh604loWHxw30YhwM8wdgi9KlVRnA3U2IhY/9h7YC0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BLzBBOcJjkociC0Z0MhH6ckvGcGTkHM447/qBuz+v2lJU/1yvxe63M3ZcJoiLKXrAAlD2CKfYBaGYM7DVyx0SnGBqnYVBSnNYWR37dKTNogWedrD9qfwHOlJlQcGexrAFdrMplnsCXHYyV+nJfseQEX25ULRxdg+imaj0J6zAQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowABn9Qjn_vppWvGIDw--.2900S3; Wed, 06 May 2026 16:42:18 +0800 (CST) From: Haoxiang Li To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, hverkuil+cisco@kernel.org, laurent.pinchart@ideasonboard.com, p.zabel@pengutronix.de, benjamin.gaignard@collabora.com, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Haoxiang Li Subject: [PATCH 1/4] media: mediatek: vcodec: remove redundant return value of vdec_vp9_slice_setup_lat_buffer() Date: Wed, 6 May 2026 16:42:00 +0800 Message-Id: <20260506084203.202882-2-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABn9Qjn_vppWvGIDw--.2900S3 X-Coremail-Antispam: 1UD129KBjvJXoW7WFW8Xw4kWFy8WF15Zr15XFb_yoW8CFW3pr 45CrWUZFyjyFnFvaykXa18ua1rCrWSgryIgw4ak34Fyr98tr17Xr1Iyr9Iyr45Jr9aka48 Zr1jqr1UWF43tw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmj14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jr4l82xGYIkIc2 x26xkF7I0E14v26r4j6ryUM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84 ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AI xVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2IY04 v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j 6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7 AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE 2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcV C2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2Kfnx nUUI43ZEXa7VUjrHUDUUUUU== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBwsTE2n6yxrNyQAAsK Content-Type: text/plain; charset="utf-8" vdec_vp9_slice_setup_lat_buffer() never fails, remove the 'return 0' from vdec_vp9_slice_setup_lat_buffer() and modify its signature. Also, remove the return value check in vdec_vp9_slice_setup_lat(). Signed-off-by: Haoxiang Li --- .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_r= eq_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_= req_lat_if.c index cd1935014d76..092fd34e21d2 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c @@ -974,7 +974,7 @@ static int vdec_vp9_slice_setup_pfc(struct vdec_vp9_sli= ce_instance *instance, return 0; } =20 -static int vdec_vp9_slice_setup_lat_buffer(struct vdec_vp9_slice_instance = *instance, +static void vdec_vp9_slice_setup_lat_buffer(struct vdec_vp9_slice_instance= *instance, struct vdec_vp9_slice_vsi *vsi, struct mtk_vcodec_mem *bs, struct vdec_lat_buf *lat_buf) @@ -1011,8 +1011,6 @@ static int vdec_vp9_slice_setup_lat_buffer(struct vde= c_vp9_slice_instance *insta =20 vsi->row_info.buf =3D 0; vsi->row_info.size =3D 0; - - return 0; } =20 static int vdec_vp9_slice_setup_prob_buffer(struct vdec_vp9_slice_instance= *instance, @@ -1166,9 +1164,7 @@ static int vdec_vp9_slice_setup_lat(struct vdec_vp9_s= lice_instance *instance, if (ret) goto err; =20 - ret =3D vdec_vp9_slice_setup_lat_buffer(instance, vsi, bs, lat_buf); - if (ret) - goto err; + vdec_vp9_slice_setup_lat_buffer(instance, vsi, bs, lat_buf); =20 vdec_vp9_slice_setup_seg_buffer(instance, vsi, &instance->seg[0]); =20 --=20 2.25.1 From nobody Sat Jun 13 17:12:17 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E7EF30CDAB; Wed, 6 May 2026 08:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056957; cv=none; b=hnfrkNtrAE19X3aEtZb0BuYJkiRha6Rejd7sTdO+2FvucmFNGq4xp0zRGuNwcEsOKB2O88GMnYkmqYq4Qff5eQMGQsgnT/sRSZPcZAA3eajY/7/CxfsPVoEA56w5sme4BQMP7Zs4VQFpz7qzJF30YOkdGqpJdxz5Eqd0Zu9VbvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056957; c=relaxed/simple; bh=WDcvTOAJLpOog3e5jIvgabNP3Ik824dY+XaPH0IQsao=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uSVXAKGthTWQdrAKyQx1GR/1Ktfh/t1afD9gX+50MUkFm/8dULSC72jx5OYB3fDIdYnWgGiXPvcOnLguUAXcGUe7uA3eFEKraLL2VMBwiwRfZoaYplFN9BCGFARL8oVhi4FsBdj7eONG5BN9FoiwgbZHCEbYYqiYxapFbNas5QA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowABn9Qjn_vppWvGIDw--.2900S4; Wed, 06 May 2026 16:42:19 +0800 (CST) From: Haoxiang Li To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, hverkuil+cisco@kernel.org, laurent.pinchart@ideasonboard.com, p.zabel@pengutronix.de, benjamin.gaignard@collabora.com, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Haoxiang Li Subject: [PATCH 2/4] media: mediatek: vcodec: remove redundant return value of vdec_vp9_slice_setup_prob_buffer() Date: Wed, 6 May 2026 16:42:01 +0800 Message-Id: <20260506084203.202882-3-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABn9Qjn_vppWvGIDw--.2900S4 X-Coremail-Antispam: 1UD129KBjvJXoW7uryrWrWxGF1xArWfKr4Durg_yoW5JFyfpr 4YkrWUZFyjyFs2yaykXF48ua1rCrWSqry0gw4ak34Fyr98tr1UXr1Iyr9IyF45Grn2ka4r uw1jqry8WFW3Jw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmj14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_Jryl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84 ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UM2AI xVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20x vE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xv r2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2IY04 v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j 6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7 AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE 2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcV C2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2Kfnx nUUI43ZEXa7VUbH5lUUUUUU== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBwwTE2n6yxrNzwAAsL Content-Type: text/plain; charset="utf-8" vdec_vp9_slice_setup_prob_buffer() never fails, remove 'return 0' from vdec_vp9_slice_setup_prob_buffer() and modify its signature. Also, remove the return value check in vdec_vp9_slice_setup_single() and vdec_vp9_slice_setup_lat(). Signed-off-by: Haoxiang Li --- .../vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_r= eq_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_= req_lat_if.c index 092fd34e21d2..0f47b2671353 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c @@ -1013,7 +1013,7 @@ static void vdec_vp9_slice_setup_lat_buffer(struct vd= ec_vp9_slice_instance *inst vsi->row_info.size =3D 0; } =20 -static int vdec_vp9_slice_setup_prob_buffer(struct vdec_vp9_slice_instance= *instance, +static void vdec_vp9_slice_setup_prob_buffer(struct vdec_vp9_slice_instanc= e *instance, struct vdec_vp9_slice_vsi *vsi) { struct vdec_vp9_slice_frame_ctx *frame_ctx; @@ -1030,8 +1030,6 @@ static int vdec_vp9_slice_setup_prob_buffer(struct vd= ec_vp9_slice_instance *inst else frame_ctx =3D vdec_vp9_slice_default_frame_ctx; memcpy(instance->prob.va, frame_ctx, sizeof(*frame_ctx)); - - return 0; } =20 static void vdec_vp9_slice_setup_seg_buffer(struct vdec_vp9_slice_instance= *instance, @@ -1170,9 +1168,7 @@ static int vdec_vp9_slice_setup_lat(struct vdec_vp9_s= lice_instance *instance, =20 /* setup prob/tile buffers for LAT */ =20 - ret =3D vdec_vp9_slice_setup_prob_buffer(instance, vsi); - if (ret) - goto err; + vdec_vp9_slice_setup_prob_buffer(instance, vsi); =20 ret =3D vdec_vp9_slice_setup_tile_buffer(instance, vsi, bs); if (ret) @@ -1804,10 +1800,7 @@ static int vdec_vp9_slice_setup_single(struct vdec_v= p9_slice_instance *instance, =20 vdec_vp9_slice_setup_single_buffer(instance, pfc, vsi, bs, fb); vdec_vp9_slice_setup_seg_buffer(instance, vsi, &instance->seg[0]); - - ret =3D vdec_vp9_slice_setup_prob_buffer(instance, vsi); - if (ret) - goto err; + vdec_vp9_slice_setup_prob_buffer(instance, vsi); =20 ret =3D vdec_vp9_slice_setup_tile_buffer(instance, vsi, bs); if (ret) --=20 2.25.1 From nobody Sat Jun 13 17:12:17 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99473E3C52; Wed, 6 May 2026 08:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056959; cv=none; b=MsA4tXlKTK9h+u8++IJPZMF12hEV7/hakY8Yin4CQZUIZQfgdZ1+PhpT88Z8eKqUzgVsiOwVzhzM6bKe3zNldDyZYV0zFTvBIKgQ6JTOxCwgPsLNpwQ4u93W6lIk3lRXkp4igacjqj8VrcHshTitcQ/Xt1RKw6PTWX2uIOFAJnE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056959; c=relaxed/simple; bh=AnwSw3Ik64YiGfEoJByoATjVbPPywWay3PVZRxJCSC8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Qr4vXlBafwXrV7/MIQ9jgXdrCB5EWOdUHa1tlia6EiTeO/TsImKhwkHPCVA7DabFt40WBP0xtlOvd+HE/cvs3oAP2OPRVCTtdffA3jIqTizngQgjE2/trbrg1AATVwZ4QtZqiXTPx8uzRoeqnqLlTq73F3049NC/7QGz6RWHP6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowABn9Qjn_vppWvGIDw--.2900S5; Wed, 06 May 2026 16:42:21 +0800 (CST) From: Haoxiang Li To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, hverkuil+cisco@kernel.org, laurent.pinchart@ideasonboard.com, p.zabel@pengutronix.de, benjamin.gaignard@collabora.com, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH 3/4] media: mediatek: vcodec: free working buf on error path in vdec_vp9_slice_setup_lat() Date: Wed, 6 May 2026 16:42:02 +0800 Message-Id: <20260506084203.202882-4-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABn9Qjn_vppWvGIDw--.2900S5 X-Coremail-Antispam: 1UD129KBjvJXoWrZF4fXFykWrW8XF17WF18uFg_yoW8Jr1DpF s0krW7ZFyjy3ZFvw48Ja1xuay5C3yS9rWxWw1a9347Ar90qr47XryIya43Zr48A3Zava45 Zr1qqryUWr43ZaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUmY14x267AKxVWrJVCq3wAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2048vs2IY020E87I2jVAFwI0_JrWl82xGYIkIc2 x26xkF7I0E14v26ryj6s0DM28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0 Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UM2 8EF7xvwVC2z280aVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4j6r4UJwAS 0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2 IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0 Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628vn2kIc2 xKxwCY1x0262kKe7AKxVW8ZVWrXwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWU JVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67 kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY 6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42 IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIev Ja73UjIFyTuYvjTRM6wCDUUUU X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBwoTE2n6yxrN1wAAsV Content-Type: text/plain; charset="utf-8" Add an error path label in vdec_vp9_slice_setup_lat() and call vdec_vp9_slice_free_working_buffer() to free working buffer to prevent potential memory leak. Fixes: 5d418351ca8f ("media: mediatek: vcodec: support stateless VP9 decodi= ng") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_r= eq_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_= req_lat_if.c index 0f47b2671353..673b17d0dd8d 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c @@ -1172,10 +1172,12 @@ static int vdec_vp9_slice_setup_lat(struct vdec_vp9= _slice_instance *instance, =20 ret =3D vdec_vp9_slice_setup_tile_buffer(instance, vsi, bs); if (ret) - goto err; + goto alloc_err; =20 return 0; =20 +alloc_err: + vdec_vp9_slice_free_working_buffer(instance); err: return ret; } --=20 2.25.1 From nobody Sat Jun 13 17:12:17 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFDEC3E6389; Wed, 6 May 2026 08:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056968; cv=none; b=NDd9DCMxuAe9gzSs+Pb3DVM9hQVN1EmrKR8LB/pZkAe9kV9GiXoDWVn5X7MUp7rRlQ1ci7qSGdGueKe+3C9Xvujg1g0Xhyk2g9BQ8f6rakVoJcnO0puIojxVJYTlLYpGtuZHq9rXLVV7ToKxzKnwwqgrz0oHEtwNoW3bi6fKyxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778056968; c=relaxed/simple; bh=ANNB9BNalevyG/KghIpaTA2Slh7RAYHVpIyYVX6boh4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z4Cp/yWOIESuJ7bRyvUGMVivvYbYz9ZnSywK6gMpeoUMZGdKcT4WaqoZ4OKX6jJVfkh9za/kLwjLW0lqr5c7BpZP1RyDz79TdDxjZwHkHh8nLtUOb7ZyiPrI2Ucz6K/YRIbOryLNRGFgyFMjHtgXBNHd+7TRF3p9P+e/zaq5cQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.223]) by APP-05 (Coremail) with SMTP id zQCowABn9Qjn_vppWvGIDw--.2900S6; Wed, 06 May 2026 16:42:22 +0800 (CST) From: Haoxiang Li To: tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com, yunfei.dong@mediatek.com, mchehab@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, hverkuil+cisco@kernel.org, laurent.pinchart@ideasonboard.com, p.zabel@pengutronix.de, benjamin.gaignard@collabora.com, nicolas@ndufresne.ca Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH 4/4] media: mediatek: vcodec: free working buf in vdec_vp9_slice_setup_single() Date: Wed, 6 May 2026 16:42:03 +0800 Message-Id: <20260506084203.202882-5-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260506084203.202882-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowABn9Qjn_vppWvGIDw--.2900S6 X-Coremail-Antispam: 1UD129KBjvdXoWrKw1kGFWrtw47JF18Wr4DArb_yoWktFX_C3 s7WF13ZrnFy3ZxKr4jkF4S9ryIgFZ3WF4rtF9aqF9xX34DGF15XFsFvFy3Gr47Ja9Fvry3 Jwn8Xr1rGFy2kjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbvxFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUAVCq3wA2048vs2 IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28E F7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr 1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1U M2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjx v20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1l F7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E8cxan2 IY04v7MxkF7I0En4kS14v26r4a6rW5MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY 6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17 CEb7AF67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF 0xvE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMI IF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVF xhVjvjDU0xZFpf9x0pRQJ5wUUUUU= X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiCQ4TE2n6y7fMjgAAsq Content-Type: text/plain; charset="utf-8" Add an error path label in vdec_vp9_slice_setup_single() and call vdec_vp9_slice_free_working_buffer() to free working buffer. Fixes: b0f407c19648 ("media: mediatek: vcodec: add vp9 decoder driver for m= t8186") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- .../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_r= eq_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_= req_lat_if.c index 673b17d0dd8d..1dd0f7fd642f 100644 --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_= if.c @@ -1806,10 +1806,12 @@ static int vdec_vp9_slice_setup_single(struct vdec_= vp9_slice_instance *instance, =20 ret =3D vdec_vp9_slice_setup_tile_buffer(instance, vsi, bs); if (ret) - goto err; + goto alloc_err; =20 return 0; =20 +alloc_err: + vdec_vp9_slice_free_working_buffer(instance); err: return ret; } --=20 2.25.1