From nobody Sat Jun 13 17:05:11 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C24F136F433 for ; Wed, 6 May 2026 07:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778051500; cv=none; b=tbUcTu3MCiqXLVTPxgt61JM4brJnmWHB5DYbCCGQBAqLKzSHpHfewkhhX9ogvAKAN0huymxeFqd/5Gym1m5Ey4dolpX4bAXdF1KfOc8GrjfuNlfuxKzL7NDyqNooA8Z2smMMje+d2PSfZbw/je+XxeV3HukmxPubrX+q7ica9tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778051500; c=relaxed/simple; bh=VJ0/G5kX/zt2UIbj7wPoZMQ5eL/6GRwtTokO6gBtVGU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VMfB6qci/UsuFATOjNbEg4fuQLhRVG2huobI4mjnX51BDfNDVsm05aZQK/NRdMdPJWyMOesq9p3I8DtwSpj8eWYWDQgMXoA1DViXG9ndc4JQaicGTMSCfbV83SRK1JAKWIbD9NODgOT0lj+N0dXvoElbPpKF9XbpwYNcZNZOHRQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IQoFEHLo; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IQoFEHLo" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2adbfab4501so26423085ad.2 for ; Wed, 06 May 2026 00:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778051498; x=1778656298; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=eu5xzVyI4tSHsVw04QF7/C+6hxVsm8Im1xAJsWyScw8=; b=IQoFEHLoqlp6qA/6uPCKNVMNjL7qKEocshZksNgpwt+EZULp35dxzod3050ZAqfiCL GVbjnnonMKBQgEZPF4NqJUCwQpKWljCmZ5wdgn6DvFdrVPfcNYNn/tWQYpK+ZcLh6DE3 iO3oBVypCkf42Sc+0BXXHna9oNhjj3YDtS3mCiTzeDlMnCLxQtzjXAdCvowniPXM+W4X J5yo2f09KAdbFQyma7AQUKg4AvdmEGJ5rydY9A8WwUvoGd9Chfr88aCo05joqrzzt0Zs ZO6FCWjPJZI6byfrtrC1BArbjk6FosnymTDR+8sGAArAvHh2D9t9N9NlHaFNnRbnp8IX gppA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778051498; x=1778656298; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eu5xzVyI4tSHsVw04QF7/C+6hxVsm8Im1xAJsWyScw8=; b=CJKhkqJytP5dVz8l/fesTuwv4chLD4NuXSKZfW2V5DhNxDMf2VhPlExZnMa78ppHC4 AGyzM/f9wFg75vuOtHhfCRdIa0Gk06h5Hq0FScJLhLhs6WscpWIOzT6dVg9MJ13dx8T3 bOzpn5xfC7IISxLF8CKy0TsFaUa+PvNRuFZVLA4TNjLUaFwNVOZmDj6Mp062ENomf93/ 5D+I572BT396EI3ZmhJxYun3Kl/EL4kuSuBZYYwSGitzNnIyPYrvgWt1JGGlDbkPLXf/ 5LlY57s9rLBMm42CNN5wLBPObaUPnyfm+S5jhwzJDfAAzDIVzUdTck/NSaM+aLEi/LH2 MVng== X-Forwarded-Encrypted: i=1; AFNElJ/KEWISIhwVXQK7uZtQO7u5wBCH5TVf7fBHPoSB4nbuqzVo2tSuv46Z9qwhjZ8IYDiFch1QlmS8kY9q0RY=@vger.kernel.org X-Gm-Message-State: AOJu0YzPpqAaSPnF5i7mvMWf2Y5A4XmzX2Jw2A9SFN/N+kRk6dyk49XD Z6+y3alWr/LsEhZfNODYB2cCXgKbwt30f6ARQnA4IqqgKr+AnumyVR6r X-Gm-Gg: AeBDietSBn+iCI5VecKXm7lhIqURGbKnFhnmgixnQ7d3z2hAcJXW5SvcepXA8uAv/Uv sUN31dX2Hn1Ywp/28Qu8pIB2PbRbod0Px72OF23aPXpFgbR2y357LvjoesnS0BUQsZHLNSHN4W+ 4wf8cWDunSlVbpnkmGJDP9lfCzriSVyd7f8iEZMHXdcI/rIo972p6Dj4kqp/bznobmd+Ta73zom 9S/Uf+bt3Sp4qiATmIVX1H+E78236expddkJt1jO63K/Y/JFdm48vXzMVxzlauu0mFypHR8M+y8 STeK4vFJaHuP0cCWuwwLSbG0IgQ4MdNoWHMa9NNVjDs66+o+PcA3z3YVJXqWHJB7adF64LoBlPY TqBpJBXoSSadDV7MqF3dWkSQYfENEF6OKjFPOmSTLYPorZDLlgVo5KSvlFDM0LcRGBUveLqIa5d EPSTcSwwsLC/Qxf+NQkxgQE/3qZ/BNki0NCv9RpD2XtxBPBvWiRzI/w17NFQ== X-Received: by 2002:a17:903:3887:b0:2b9:6453:389a with SMTP id d9443c01a7336-2ba7928595bmr21932115ad.8.1778051497972; Wed, 06 May 2026 00:11:37 -0700 (PDT) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.246]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba7ca105c4sm14501145ad.60.2026.05.06.00.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 00:11:37 -0700 (PDT) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Namjae Jeon Cc: Hyunchul Lee , linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] ntfs: fix missing kstrdup() error check in ntfs_write_volume_label() Date: Wed, 6 May 2026 15:11:32 +0800 Message-ID: <20260506071132.6676-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ntfs_write_volume_label() does not check the return value of kstrdup(). If the allocation fails, vol->volume_label is set to NULL while the function returns success. A subsequent FS_IOC_GETFSLABEL then returns an empty string even though the on-disk label was updated correctly. Fix by allocating the new label before freeing the old one and propagating -ENOMEM on failure. Also move mark_inode_dirty_sync() into the success path so that it is not called when no metadata was actually modified. Fixes: 6251f0b0de7d ("ntfs: update super block operations") Signed-off-by: Zhan Xusheng --- fs/ntfs/super.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index 22dc7865eca7..629fac580f95 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c @@ -425,7 +425,7 @@ int ntfs_write_volume_label(struct ntfs_volume *vol, ch= ar *label) return uname_len; } =20 - if (uname_len > NTFS_MAX_LABEL_LEN) { + if (uname_len > NTFS_MAX_LABEL_LEN) { ntfs_error(vol->sb, "Volume label is too long (max %d characters).", NTFS_MAX_LABEL_LEN); @@ -437,7 +437,7 @@ int ntfs_write_volume_label(struct ntfs_volume *vol, ch= ar *label) ctx =3D ntfs_attr_get_search_ctx(vol_ni, NULL); if (!ctx) { ret =3D -ENOMEM; - goto out; + goto out; } =20 if (!ntfs_attr_lookup(AT_VOLUME_NAME, NULL, 0, 0, 0, NULL, 0, @@ -450,11 +450,15 @@ int ntfs_write_volume_label(struct ntfs_volume *vol, = char *label) out: mutex_unlock(&vol_ni->mrec_lock); kvfree(uname); - mark_inode_dirty_sync(vol->vol_ino); =20 if (ret >=3D 0) { + char *new_label =3D kstrdup(label, GFP_KERNEL); + + if (!new_label) + return -ENOMEM; kfree(vol->volume_label); - vol->volume_label =3D kstrdup(label, GFP_KERNEL); + vol->volume_label =3D new_label; + mark_inode_dirty_sync(vol->vol_ino); ret =3D 0; } return ret; --=20 2.43.0