From nobody Sat Jun 13 18:11:50 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A10F52DCF67 for ; Wed, 6 May 2026 04:15:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778040921; cv=none; b=fAFHlj2oG3+eLnk4+ZqIPbrFYqY0lxIKkife5PneDNbt1PvtS+Zg0ksYa2w1fwreUjoqsGNPPt5GYLM0i5HSHEkqdvuGJlZYsvaMv4stDw5Ey9JwF2oBclr80H/6H8ls7Nv2MgARh/DVy/M9jFTRMR9UMxjYet5FLyprCi9cphY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778040921; c=relaxed/simple; bh=KuZdsCFQPN+GyW/AZ6KBTLDbPs4BW4iDVr9lyjukMgI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=VF6Xpr5Zj81EQx7lvQhcFwUHI3QJ2rn9YiFvXRqiJfnMJmsRgyYS0gslLuY9Ux6WoOXKZQeEVqz4ju3Mx+GzzBrJYic2jO1QHkhLEcEjdLr0H1+wKWCV6qaN4oaOJSROr0HR7oqKqWiNFOStjgr9eq3BTYb4O/9OwwcNiYBQ0iw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost (unknown [124.16.138.129]) by APP-05 (Coremail) with SMTP id zQCowAC3TBBIwPppaImEDw--.115S2; Wed, 06 May 2026 12:15:04 +0800 (CST) From: Chen Ni To: changhuang.liang@starfivetech.com, tglx@kernel.org Cc: linux-kernel@vger.kernel.org, Chen Ni Subject: [PATCH] irqchip/starfive: Fix error check for devm_platform_ioremap_resource() Date: Wed, 6 May 2026 12:14:13 +0800 Message-Id: <20260506041413.1670799-1-nichen@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAC3TBBIwPppaImEDw--.115S2 X-Coremail-Antispam: 1UD129KBjvJXoW7JFW8tw47GFW3Gw15ZryftFb_yoW8JrW7pF 4DJFWFyr4UCF4xGws8AF18ZFyrCFn8K3y7C3y8Za4SvwnxtrWDZa15tFy5XFn3GayxGw45 Kr4ava1rZFyUuF7anT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvv14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_ JF0_Jw1lc2xSY4AK67AK6r45MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2 z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73Uj IFyTuYvjfU13kuUUUUU X-CM-SenderInfo: xqlfxv3q6l2u1dvotugofq/ Content-Type: text/plain; charset="utf-8" The devm_platform_ioremap_resource() function returns an error pointer on failure, not NULL. Fix the check to use IS_ERR() and return PTR_ERR() to correctly handle allocation failures. Fixes: 2f59ca185497 ("irqchip/starfive: Use devm_ interfaces to simplify re= source release") Signed-off-by: Chen Ni --- drivers/irqchip/irq-starfive-jhb100-intc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-starfive-jhb100-intc.c b/drivers/irqchip/i= rq-starfive-jhb100-intc.c index 0d5914813afd..838885b02f34 100644 --- a/drivers/irqchip/irq-starfive-jhb100-intc.c +++ b/drivers/irqchip/irq-starfive-jhb100-intc.c @@ -208,8 +208,8 @@ static int starfive_intc_probe(struct platform_device *= pdev, struct device_node return -ENOMEM; =20 irqc->base =3D devm_platform_ioremap_resource(pdev, 0); - if (!irqc->base) - return dev_err_probe(&pdev->dev, -ENXIO, "unable to map registers\n"); + if (IS_ERR(irqc->base)) + return dev_err_probe(&pdev->dev, PTR_ERR(irqc->base), "unable to map reg= isters\n"); =20 rst =3D devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev, = NULL); if (IS_ERR(rst)) --=20 2.25.1