From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D6647DFA6 for ; Tue, 5 May 2026 17:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003212; cv=none; b=MgCnhBwbQUOAGhmz6aU/rcdyeXkY+zPyCtH13RCOdx/Pmc/QDOISZ+r0XKHmQ+WKv0a+Gs+oNo07bnJjpV8jYHW6v6N5cKgatmvQ+ZNfKT0o66o0fiky85YgfEN8ZXJOV12dsILAaGu98VxYVxanApt93Rt29IORmj85HrBuPPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003212; c=relaxed/simple; bh=dVoROqRTarCI3ArcUvyKEvYVz3wLegfbNtBsFww7WQE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OJ+mMlSpXzy15WJqz9uLgygnvT8QJfh9KfOTvF8dtA050FEkiDiAuoJa12B5m3EuOZvT7kOwfrxlpEHlZ4N0ccwR1kM5sS+MCS9nNQy/Lukx4yEkpqp9Gg72GZ/fwPXCpIT6qX6h96VsJHTYfNFzaQgZ31Na2aphZ2Woxih3Y3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZJxniXGe; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZJxniXGe" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ab232cc803so24612125ad.3 for ; Tue, 05 May 2026 10:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003210; x=1778608010; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HZZevsa28Z0lnZm6lTUzLbhzzlq2jzJL2yxl54eCq38=; b=ZJxniXGet69UD9oYhI2u09xa03IOvvKWEJFpYrfo1mfupfxeEVaRsyWFLoJmtLjyn7 vPQxxDJl9bnUpAVHqC7D52/BlAGlHY8Uij1B0g/kpjbIi9+E1NAmUhFDMOqKn1Rb+OIR PckXHCuJIUG1OvJXZAk5qqdKblGvsusYzQNxhBF4OkVYq4AUEOxqK6diPP2tYZEgxNdw BUc9rRAu16ThFaD37Wi6FBd9vTVn0GmSiKYVBpgFqIzQ9x75P3udIkgT9ohzRt0Yi2g9 Tt/GvvwOaLAKEuPc1D3b+TiUnacLkf92ogTlJlYxRiUdmARMEnbc42M11lEVQOFclDvH T0Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003210; x=1778608010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HZZevsa28Z0lnZm6lTUzLbhzzlq2jzJL2yxl54eCq38=; b=CknabESqaurgUlVoD3zjba0zP5o8N+rAfZK0EroDm2LZY3qZ8mg2GFf20UP5oEw60U n1wFpCiDmdmI+n14mlu+szpOkY2JoqQdnoDqpvodhJHpIUaEEmHgNiAq6e0nk+2MVm62 LhO/+DPhLP5LPn2yPfLZEpPlJKwQWw5vSFfQ5zVQHie3iVWxuNWY9xaEWtIShYYC2KxL BdCByXUE0rlwzeIwZHaRmbQ4l8Ga9JmxzvOtU29kykq9jDbUeMuaX/N/ajAICpiuSCWD Sy4B3QCqnVM8uxvFd1zZsjQ+uZJXd3kpXP9oNONnbJ5wpinkwZZ/OQA0Y5DU7g/c3ADM Oalg== X-Forwarded-Encrypted: i=1; AFNElJ84EB3o4eO3CIPf3GVOUURyIfEb1cVGoeB8eCHz4EE+sas+sdLBJ0nww1z874VPknVBlUQvFAYYChAXRqM=@vger.kernel.org X-Gm-Message-State: AOJu0YxHB3PFutWZ0N3alfFdRDin0UO0CBpABmDNjc2CWvr/vwstPzdf Mta4H/lxCf6J+kiHyCIeu5gyGyWOecxdSM4CLNB4kJJ4R751DGfcFaxW X-Gm-Gg: AeBDietZnA96VSISWZBLFsYtMkA8FH8mzsbKmcagEqdr5eMu76cugpZmtrlwdGwAzDm 9DWFaRr8EKHBETX/LUjLoNcedkw0aXdXueQimSmw3/+0uKnyPbFDLe+2KvQmx6O1AFZ26LhN+EY X+uecmz6Qr8CRnLSz3I4OtSCSPejgu8XBZKqieQKQs1cFRkZ090vxz8SMjuVgFDUObhxL4DbfNV KXScaPA43Wq8kLsRileigFKgHvE2V9NPWMkNdmCFVk5sT4RHBGiuBCvJvHtg+1SlNzn52+4Mff6 QIF8SXwtjBeoLOmBmjo18r3rDYYJQdRnmLJNilk4IJX6ukXAh25Efl9EaR+EJq7xSA99q4m4+9W ngRXmPyuXe2ACjvSXq4eGHRc41aEoldtaCUghFx9TiI5xefhcupygJUCVA555BP9TzsdmAWp3Jq Uv3R/CxGgO5eqcm8FyQ08Ge7i69BNDgyaG8HL6K5FGpoJoqkkbgJwIZkX+7GE= X-Received: by 2002:a17:902:da87:b0:2ba:73c4:4a77 with SMTP id d9443c01a7336-2ba73c44b95mr8864685ad.9.1778003210567; Tue, 05 May 2026 10:46:50 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:46:50 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 01/10] iio: accel: mma8452: handle I2C read error(s) in mma8452_read() Date: Tue, 5 May 2026 23:16:31 +0530 Message-Id: <20260505174640.3998281-2-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Currently, If i2c_smbus_read_i2c_block_data() fails but mma8452_set_runtime_pm_state() succeeds, mma8452_read() returns 0. As a result, the caller mma8452_read_raw() assumes the read was successful and proceeds to use a buffer containing uninitialized stack memory. Add proper checking of the I2C read return value and propagate errors to the caller. Fixes: 96c0cb2bbfe0 ("iio: mma8452: add support for runtime power managemen= t") Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 15172ba2972c..cefc7cf4bd83 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -252,6 +252,8 @@ static int mma8452_read(struct mma8452_data *data, __be= 16 buf[3]) =20 ret =3D i2c_smbus_read_i2c_block_data(data->client, MMA8452_OUT_X, 3 * sizeof(__be16), (u8 *)buf); + if (ret < 0) + return ret; =20 ret =3D mma8452_set_runtime_pm_state(data->client, false); =20 --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347383859FA for ; Tue, 5 May 2026 17:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003216; cv=none; b=jghyvR3kVDwkNfy1Il6AxCdPG1AaAUSJ7PFcM8DJJ/PvCglx46PmtZtzcRKiDYIgjCMK+sseIAIVQcU44RjI5Xe5LHzL9MNqmAELm+15+c7hapZcnGsT/VbG7XN+SN52uYzNOnZWZIb7pjGDWEm9VHDxzX2zBMxzPFONkK5jzkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003216; c=relaxed/simple; bh=uvMuNKhl2md9ckDK0UL67dgKZyZldjsAwfjJ3rNNMZg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mK6uNVXmvw22OJ4wAP8TUf+HSRFnNVzQukRvcWo1tevajqbQdaYD+ssSTlhxzBUHISIQ9JUVeqXrUH4hQPJK9oN0wKEtsHsfbD3IoJMlP3ZmEiCyJSv7hIke3JnhOJfupuvo1NnrFSzjQxbSevPj6ib0s1P4vZGGunMVU1YnC7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BBm1PqCZ; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BBm1PqCZ" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-365313b86bfso1893569a91.3 for ; Tue, 05 May 2026 10:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003214; x=1778608014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=thuhrm8tCmZJtgI5sGLEXt+cjZuKnZXihxMoA86J9mU=; b=BBm1PqCZIgT5CYuDLLtZnZ8JIbpOuwxz1/xyiBXIT4GCNBIc1Bv+HjJcAhxJa/LdNZ 4+vSPtVWgosk6iAq4WWM/eAKVhLJgTIywRq5tfIJVQmWP1qh0LqYZWRJVcWy7aGZ+ZQq VMAZ3DWYq6vtnddD3dMe92PNv3QgxAjpf2GBBBd9CJ9T4rFK1LealL2297Q8oe2PZadu nzFRwoanX5g+wEMRtrucxrigB82kwZovDbbjbmx5tKHm1BtSjAhV35eL7FMt2vaHTgHA 7LuEzh/uCjpN5ofcVVsOcnqR1dFDusP/uxL4eLiEa1gEpgvTbJ2ehqkmvC8dh6WRcNte QMlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003214; x=1778608014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=thuhrm8tCmZJtgI5sGLEXt+cjZuKnZXihxMoA86J9mU=; b=p5tP8pc4sGC9zNQeQOCLbyA6eHzFEslEGLHRB1ByweMMaAZdMrua5LWIqY60ffhWmX LFP+trKBM5H6spArGxACKcdNs53mkJ1RRvpzNqZjtxPZLM9Ml32Z2RXvEaqcADDOJQon aZy5aPt0erde+MDclS8ipgWVvxEBhi7HcFV7JxwiocR2NVWp/7vcI9z+dhjXh3hZ2+1M x4bkRcjgLwrOqzsQMLwagRO1uBBpj99IvIJwLHPL7KvtqioEg4KtkKF/+BPiDLV3niQ9 mfXhtGTt1P5I5GKLCJoPbmbHSRBGnOFIPJqjjnE0Wmj6OIFClehCso3iInlpHeJg6Aot YwdQ== X-Forwarded-Encrypted: i=1; AFNElJ9gKrym1JVbK/2WwekZZQJQZd2lNhEXEhbjGb4myXeY8UHNMdC0YyR/pqx/9bxBrmW7lS9/EXoVHJXDL1g=@vger.kernel.org X-Gm-Message-State: AOJu0YxBoROmbNk4g4GGGXdqQC7CBGtzvUQaQdYBoPbnfWVIj6XAgh6x ujJy3D7gGfY9bpBlXNunyuQo0S3jxiCAO3B6cNECL71JQX2o6zZZVU14 X-Gm-Gg: AeBDievviL4G8qW1azfStrc3f9pgX1JPVa0MA7IuzpHMLNsFBwhdjTQYWOPxdwrvGgY naOuUASf+a5D2NxAeY3IOvzAY+FGbTk6D+hoStnEODvsC8+A/jVr3vDhoLqjXGx3h1i0+LeHGwf NOrWmbAvEkDFxpyh+CWqEPMjHoMr34qUjfAxbYkLRE4hZXeBM5+M1te6ddcus2BO+wymd0LmFgh DzFJ1pvpPLqbasMHJ7B0dnULhqDt3Q8EZCC/uWrtneXsFOjneznDilujTmgFF2uVMc1Z0lAyoFk d0Mc98V+iEh62yoXOTvwFK/6mqfeYpV1VupJcXJV/NjzfLKvEvI41jwfFEgNj1asRg2VRlo8iuH KHENRI7rpLkwTjSPXguhRO+TiB1fh1I9n3O+uOawaVzXsObcjcGO57jFXyyaQ4jTaoCuQvygNt2 DcsQGpn0SgWhqlK7uz0q+1IAJ02TgBZWBm0fHbjRdy3xLYEO0IkCMaHqvR4GZOcGKY3wPh+Q== X-Received: by 2002:a17:90b:53c6:b0:365:3154:7b1 with SMTP id 98e67ed59e1d1-36577613d3emr4259663a91.26.1778003214535; Tue, 05 May 2026 10:46:54 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:46:54 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq() Date: Tue, 5 May 2026 23:16:32 +0530 Message-Id: <20260505174640.3998281-3-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Avoid using devm_request_threaded_irq() as the driver requires explicit error-handling path(s). Using devm_* API together with goto-based unwinding breaks the expected LIFO resource release model. Add explicit IRQ cleanup in the driver teardown paths to follow kernel resource management conventions. Fixes: 28e3427824cc ("iio: mma8452: Basic support for transient events.") Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index cefc7cf4bd83..279a9b364886 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1682,18 +1682,16 @@ static int mma8452_probe(struct i2c_client *client) goto trigger_cleanup; =20 if (client->irq) { - ret =3D devm_request_threaded_irq(&client->dev, - client->irq, - NULL, mma8452_interrupt, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - client->name, indio_dev); + ret =3D request_threaded_irq(client->irq, NULL, mma8452_interrupt, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + client->name, indio_dev); if (ret) goto buffer_cleanup; } =20 ret =3D pm_runtime_set_active(&client->dev); if (ret < 0) - goto buffer_cleanup; + goto free_irq; =20 pm_runtime_enable(&client->dev); pm_runtime_set_autosuspend_delay(&client->dev, @@ -1702,7 +1700,7 @@ static int mma8452_probe(struct i2c_client *client) =20 ret =3D iio_device_register(indio_dev); if (ret < 0) - goto buffer_cleanup; + goto free_irq; =20 ret =3D mma8452_set_freefall_mode(data, false); if (ret < 0) @@ -1713,6 +1711,10 @@ static int mma8452_probe(struct i2c_client *client) unregister_device: iio_device_unregister(indio_dev); =20 +free_irq: + if (client->irq) + free_irq(client->irq, indio_dev); + buffer_cleanup: iio_triggered_buffer_cleanup(indio_dev); =20 @@ -1738,6 +1740,9 @@ static void mma8452_remove(struct i2c_client *client) pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); =20 + if (client->irq) + free_irq(client->irq, indio_dev); + iio_triggered_buffer_cleanup(indio_dev); mma8452_trigger_cleanup(indio_dev); mma8452_standby(iio_priv(indio_dev)); --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61CB939182F for ; Tue, 5 May 2026 17:46:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003220; cv=none; b=PmYk55ZFFh7oNP69rCsFD6xjFing8S+HLv9fIZPoOLnLdvQHDX6rCPyU0cZ28rKfrxzg2p/g0RzuD1blAcUY+NvgKRuk4Weu7M/WowveE7yhGKITXAIRNPFeEHfMHWdxjDPoWm8+4r7WKFvrbPitwFgI2W5Id92VTsbSaMjgpns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003220; c=relaxed/simple; bh=XI5blpbluZo6VAkfAG2ybKsH30PQQjRvdqtwzMfXfAo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ej934iywZKc95M+Gh5jpecYYx2LUWJouo97ISzvOcLECEdu1lxetXZhHfrFBxVxskIrzODEPrIJy7ws/e3vjlM/j8UPAsXu7574r+d73/sJOFYn3LwDQjkm6oalySUfXgPassfNJyN4Y3hofJZR6sArDCaD9xrHcGlblgYrrPn0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JVfkJxy+; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JVfkJxy+" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35fb16e56efso3837952a91.2 for ; Tue, 05 May 2026 10:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003219; x=1778608019; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CZSbvp8eMrVEuQD81q0rzP0AajZbs6/47uUXZzpLcJU=; b=JVfkJxy+NoY3dy8weQLXEFdUWN9mKsh15Q2BRuWqZludFXzJmfWXu+tSl975lGxIkA IXtZcTeL90fgSmtnVk4d32d/wxdp3RJAcdhy7ssvx8DlwEqLTgZiNy2JKVeS5D+LxYrn aY9QAWRpV1kwONaSbLeLTxn3Vdm/y7ZfYXf8QjLFEQ+3AlO4gG8h62W32TVllCGWgtTp 6Mo37onS2c+CbAMHssQk3/wP8XzAygg19E+mYMxMXoxv0Y55PeO9+WHjSdv2dN7RPo2W Mb3ro0/6SlSm92TTuUVNkcZsofFLf7Gl64TWSjv4e2eGuwGzDTCQSqWuZu/NoIolyjtv Yxtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003219; x=1778608019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CZSbvp8eMrVEuQD81q0rzP0AajZbs6/47uUXZzpLcJU=; b=kscTqcCzaQOFcQaLcplkWWCgxm7rWXssOiJPu2YP5AxD9QGttgyrP9Esh+nIl0TgqS d+MeXGlve79+aUiVglbXp5NMQAFKq6fkxH/UCfQ2pj1zNSit3oyV7KlKMlaI+ncPd0kt q5u2mOEh+hwSJhOF3y192rDzNM7W+JjKZAlwwrQ4CrK4Ess4r5qQvUhqeYoB5xLDxKco NVrR4lk2hXi3CeY/zvGBx5PFHiJ1OoHZSrWV6CeymCo86CgpR3uMF13YLQiFtzOG6Cpr iu+bMChTXTPoFTLcvlpak7zzWxFCGQK9mXCohqMdRZu4Wrl5Vd2NKfgfgm3GQMqvAD1K 6OgA== X-Forwarded-Encrypted: i=1; AFNElJ+z8QVbGXtTwFHx66gJNATSfC5Td+UGHFgwvs0j3QZX2uHpKwnr5pUo6Lk5RuVXwFQIfb3cCa7zcNDqy50=@vger.kernel.org X-Gm-Message-State: AOJu0YzpCnFBsHnHLsMkouhsarYpifWyd0KWK1r6cglBG3SCEjtGKRkS dVwpPEoJjnWhL8OHY6ZjJmgYI0hYatfibZv8CwrL+/ZW2eOA56P7Uq7N X-Gm-Gg: AeBDievZdRLofUJjBSSkz5/T6EPF70+5tj0mvzaaaZPVcDM+AB4umyjmZtSJW3RupSu u57tD8oBoMY8TlDA1ijkgvOCMfhN9rw5hTK8hLbhciLPcZhjo0copiszpnkP5NXaFTe3YaXW+HZ UMqBIMCDrnJSVlVS1UZkuYBLOycmjGcmSUJtFyN6Y9GtmpXhwkJ5GAorPkyPqCb3rXgnQY14syb rx2+u40UwAJN1q/hcgoHT/D6oK8nv/e6GKE7mkpu+ANioM9wi8x+fpE0qOxtR73S3pi2NQelClY v0hT0QheqZWQCH8JrbCXivPMzSw+4nYKWhww2jqrLAPFiKlGVLnl9CsD5Wrs0ZQ4i5/rxpyohsS pA51m8p64p84m6chgEwiuXkTXttoPGIkFdZuHbFwfLPD0weVnIDiBH9N/tp+IZTfzBYr5cN5zx0 6viFWFyFyP1GPwBRRu7qg7hRD3fviD3mw/WvuNpVg1IkkESQD8oS7a4h3voR4= X-Received: by 2002:a17:903:a8f:b0:2b2:b117:1e16 with SMTP id d9443c01a7336-2b9f25e609emr127202825ad.20.1778003218591; Tue, 05 May 2026 10:46:58 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:46:58 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 03/10] iio: accel: mma8452: cleanup codestyle warning Date: Tue, 5 May 2026 23:16:33 +0530 Message-Id: <20260505174640.3998281-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Reported by checkpatch: FILE: drivers/iio/accel/mma8452.c CHECK: Alignment should match open parenthesis Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 47 +++++++++++++++++++------------------ 1 file changed, 24 insertions(+), 23 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 279a9b364886..916631519d3f 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -706,8 +706,8 @@ static int mma8452_set_hp_filter_frequency(struct mma84= 52_data *data, } =20 static int __mma8452_write_raw(struct iio_dev *indio_dev, - struct iio_chan_spec const *chan, - int val, int val2, long mask) + struct iio_chan_spec const *chan, + int val, int val2, long mask) { struct mma8452_data *data =3D iio_priv(indio_dev); int i, j, ret; @@ -788,8 +788,9 @@ static int mma8452_write_raw(struct iio_dev *indio_dev, } =20 static int mma8452_get_event_regs(struct mma8452_data *data, - const struct iio_chan_spec *chan, enum iio_event_direction dir, - const struct mma8452_event_regs **ev_reg) + const struct iio_chan_spec *chan, + enum iio_event_direction dir, + const struct mma8452_event_regs **ev_reg) { if (!chan) return -EINVAL; @@ -818,11 +819,11 @@ static int mma8452_get_event_regs(struct mma8452_data= *data, } =20 static int mma8452_read_event_value(struct iio_dev *indio_dev, - const struct iio_chan_spec *chan, - enum iio_event_type type, - enum iio_event_direction dir, - enum iio_event_info info, - int *val, int *val2) + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int *val, int *val2) { struct mma8452_data *data =3D iio_priv(indio_dev); int ret, us, power_mode; @@ -881,11 +882,11 @@ static int mma8452_read_event_value(struct iio_dev *i= ndio_dev, } =20 static int mma8452_write_event_value(struct iio_dev *indio_dev, - const struct iio_chan_spec *chan, - enum iio_event_type type, - enum iio_event_direction dir, - enum iio_event_info info, - int val, int val2) + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int val, int val2) { struct mma8452_data *data =3D iio_priv(indio_dev); int ret, reg, steps; @@ -955,8 +956,7 @@ static int mma8452_read_event_config(struct iio_dev *in= dio_dev, case IIO_EV_DIR_FALLING: return mma8452_freefall_mode_enabled(data); case IIO_EV_DIR_RISING: - ret =3D i2c_smbus_read_byte_data(data->client, - ev_regs->ev_cfg); + ret =3D i2c_smbus_read_byte_data(data->client, ev_regs->ev_cfg); if (ret < 0) return ret; =20 @@ -1193,7 +1193,7 @@ static const struct attribute_group mma8452_event_att= ribute_group =3D { =20 static const struct iio_mount_matrix * mma8452_get_mount_matrix(const struct iio_dev *indio_dev, - const struct iio_chan_spec *chan) + const struct iio_chan_spec *chan) { struct mma8452_data *data =3D iio_priv(indio_dev); =20 @@ -1516,8 +1516,9 @@ static int mma8452_reset(struct i2c_client *client) * The following code will read the reset register, and check whether * this reset works. */ - i2c_smbus_write_byte_data(client, MMA8452_CTRL_REG2, - MMA8452_CTRL_REG2_RST); + i2c_smbus_write_byte_data(client, + MMA8452_CTRL_REG2, + MMA8452_CTRL_REG2_RST); =20 for (i =3D 0; i < 10; i++) { usleep_range(100, 200); @@ -1647,8 +1648,8 @@ static int mma8452_probe(struct i2c_client *client) dev_dbg(&client->dev, "using interrupt line INT2\n"); } else { ret =3D i2c_smbus_write_byte_data(client, - MMA8452_CTRL_REG5, - data->chip_info->all_events); + MMA8452_CTRL_REG5, + data->chip_info->all_events); if (ret < 0) goto disable_regulators; =20 @@ -1656,8 +1657,8 @@ static int mma8452_probe(struct i2c_client *client) } =20 ret =3D i2c_smbus_write_byte_data(client, - MMA8452_CTRL_REG4, - data->chip_info->enabled_events); + MMA8452_CTRL_REG4, + data->chip_info->enabled_events); if (ret < 0) goto disable_regulators; =20 --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E555E4A2E39 for ; Tue, 5 May 2026 17:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003226; cv=none; b=SdgRiaUGsKVMiZJFJaJjDas18LSvzdSUSZn33I/LmhupHE4YfiAv4ew+CiYxLrjyA7RWHuua25U4FBplzQhsp8L8u3Lc42MYVlMOnD5qlW5xJmCi3cY/6Y1Wws0nha2WKqU0Kh335k5YaI84PzogJtjEbz8spEEUIAgJRvDX2EQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003226; c=relaxed/simple; bh=y8SRYHQerR/XiaUYzpkFsyaswiEukmiY0smd6M2kZg4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y9+yfRshYYYUVlBPtnl30seowbjMkli5l3N9D9ROvUGblA+lpahHQcHfPzCTGtaZwi4myP/MBKU+xv1qNwOZJatYSbTWxSc58CRfRNuTVKZB8h1XaISScfa1x1nco+r6uUaVOj7BYdn+27abnBwbvIEsotrg9VlGi8Y3OewfLqU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xd6haFs3; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xd6haFs3" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ba0714574fso15439535ad.2 for ; Tue, 05 May 2026 10:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003223; x=1778608023; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2rqqPVndgRmW/1rhBFidKTKPMvulZqpEw44BSS2zn88=; b=Xd6haFs3+Sgs7GecZEY19xJThYvvOJmIxWg3Kjxh496kNYKz9kHCWbDh7lbv0KPoFV wzXPRNGYpOlL3TmRxkvnUK4qIbuQV8muaNTP4pfYhIZJEeY7BQOJbGtwrjDJx7COZHzL e/QKPJn0+RCFAa4A2ksC7d2ApCMdndEFUb9ylz15piUuu9Ue6EyOEfOpyTyUSSOg5Pqc DPHNAWgPE74id96yTg5GnmuvMYNPCou2u0DwAHyYrhvIft1D25zxRMk6X+QUtjxorApF ZOxFoyvbJ56gC6NuJvBhOIlj5hxN64vwFHRfdZ5T6Wia1JH+2vRCZYSdJz2j+4JFOsP3 dBPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003223; x=1778608023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2rqqPVndgRmW/1rhBFidKTKPMvulZqpEw44BSS2zn88=; b=Ci+KwL9aKoLCifiyrRKAlq/STBW+R1XRpe3gjxgYxSkyo6IjPQhIUrU4ELNXKlnult AVc/ya4pEK63BEOkeI8+X6aEGSrWbwjtekkqSTyoGYclxhZNt4bskHs8pRLM1nCS4ePD Z8QwBOQdIg5EISNJz0bSLCMr3WI8V53GshmsGo2l+b1qEgSU4cGSGvny7fPqyDiZ3+x+ 7RbRgGrrY3aPLt5jMuOPeu3FUC0HOcBkoYp2YwI+PWCVJp+5He/FnuAG40/Aopeo2n0J 47PAe9WyDPqazgSqPQgq5CVS3AXvDWCvnimAqLoPHBwoHojGOEorakTmP0bYeDFa4c4v QZxw== X-Forwarded-Encrypted: i=1; AFNElJ9adADnbBcy4nvMXwIlD7gNCregj87aj/1FcvCadKNRSJXfukX8DyhecrOUTI4mkieC3nsERXNeqOV4FSY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtar+6P6A61cUYk5/UID9Dx1229JiVxCp2AQgyQLiC0apNkfle Hhoivsq9Q/4htsXmrbLdXkNYfwJIcdPjNzMUidW5pBpd2tGDoSQOWafV X-Gm-Gg: AeBDieuaYkukqYAawklabjiMq1/5N0TfW6IkUhgSKhMeuLbssdfZV0ZprMeLZobSmN4 oZuvA5dad4ImzR1yKPKSvDhBa3/BsYNsQ7hpQhnI24q556RrQ5jZvKBnBdjM9B0ZEFKKwOnCTRj pz7bmPfs6plMvoCgqSXsJavLZQMlO4OM3AozPu/xHjlJvlcXsf7ogZiMiJ7bXHJN/607+3SLCuR yKS6I2Xx2MSZZWje2rxwZKNBFuhe7h+HjwzlyFrn74LllVQk+a1AESPquy63t/WWHJ3RKR3xxFG 5pzXAqEfhX/rrE+WKsovOVq7uKlnWX/oXpB9a4OhRE8+/XiHF68cvH0Kyfr0Chy7154Y6fefocq O/mgW1akSvDdFjCEBhQMHmSArlsfpkcB6hJuWGjy+Pb496F5smrWLeuWbW6n/k4tVFyHOSLZE30 qQ9Cue6BK+mCCAjldts+igkKmYQBeIw7emsPicjZiu291euzMueAweum34DfQ= X-Received: by 2002:a17:903:3c66:b0:2b2:4cd2:e16c with SMTP id d9443c01a7336-2b9f260d87bmr145993195ad.20.1778003222631; Tue, 05 May 2026 10:47:02 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:02 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 04/10] iio: accel: mma8452: sort headers alphabetically Date: Tue, 5 May 2026 23:16:34 +0530 Message-Id: <20260505174640.3998281-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Sort include headers alphabetically to improve readability. Signed-off-by: Sanjay Chitroda Reviewed-by: Joshua Crofts --- Changes in v3: - Grouped regulator header with common linux header group - Link to v2: https://lore.kernel.org/all/20260422165643.2148195-3-sanjayem= bedded@gmail.com/ --- drivers/iio/accel/mma8452.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 916631519d3f..d227ce3d5f67 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -18,21 +18,22 @@ * TODO: orientation events */ =20 -#include +#include +#include #include +#include +#include #include -#include +#include +#include + +#include +#include #include #include -#include #include #include #include -#include -#include -#include -#include -#include =20 #define MMA8452_STATUS 0x00 #define MMA8452_STATUS_DRDY (BIT(2) | BIT(1) | BIT(0)) --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F9E231714B for ; Tue, 5 May 2026 17:47:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003234; cv=none; b=t4MakaXn+CoZRLsbNmSIcMakQgyu1+u3uqtAVHrvfCNB0sttFPqZY3f8qCYUBiVItIRHilBo9ZazQlUjt3J0ANJqvO4o/RggPS6RRoBpT9o8YNpCC3kVh3h0lKPzCVdcVVrBzFi6yXfNoPgiyKLpf8jteYIflJHNwUJc5VotKlA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003234; c=relaxed/simple; bh=ngG7ZwhjbqXvArOVUnvZ+tcYvPyJZDl2+T97t7i14D0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WnXtao0HBed/fbjprmMJjMZKPImZUoRu20L79gw2unJrOvViIKXuwIzODVnZ2ElV3LvRoistlfbHjjVS73n3Fqn/UWTlOwOLkFLRW/uQoJdcMwGxSnilggeDs/BdK+Zr2I95/1a7OECmYydqQOw3XupP5aBHBH77Zr/2L08JHXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=od4723to; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="od4723to" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ab39b111b9so24242915ad.1 for ; Tue, 05 May 2026 10:47:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003227; x=1778608027; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dwTtCxRL7jVLdLm408KX/zDQEsquIagWbu04Wg8HTuc=; b=od4723toB0wlHo5Ahipn3TqECIKEcNKEs2GiqTRFE6srmByxkgt/T9C6vjb78gylUv Ux4wwBFUJrbND0h1q2JbOLpj+zfpcJw2UsrS6uaqb3MAv1tNioybapyKAH8W7AoQ+VVM l7/HZIgtyD2kR0b31hehK/ETDPNWoukybXCIFrq1EZnfuvfCldIYHDWkMDB3hZY04nLR kr0Q8qkHdQ56f/wmMa2DTQcjA1XDrPgerQD35UFUwJlUgQ+efvFE+FQCHtLkYbCAaekp uEL5ijS6iEGniaWvpyH1mGxCsLLScZwJXyLk2mFMT+RgPPsbUW0NKeJTYV1DFJtLuWvO Oosg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003227; x=1778608027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dwTtCxRL7jVLdLm408KX/zDQEsquIagWbu04Wg8HTuc=; b=ajQwGE778rhlcI26OQ9KexWADqISquUeZHBYSeo1tu1CS1e51XkfKe1Y01y4tfTVrk /px7hRjaZJoeE5Wi3YQdj0v3VC3eKRJ/rRDIZJcvkNE41SENulmHlw6kQf3A+GknfGM+ Vl5sGPaY7QjKstU3e5WHtHJ2WQdPlFZGK5I9uWle/gb5tbWV08t0RYIE8zM2inUla6ay Kz2/uDEJgKYMz6lLd1phnODZo2UfWYJifC9xv/wd2JjPoaCmmePE+EnbILyNPPp6XiZD vWcJUCfukxStm1gUfWPtU8K0KERcxYlUc9JBxQsJL9V3i0VV4Bz5LoBRKgxnKlSn4UWa a+LQ== X-Forwarded-Encrypted: i=1; AFNElJ+r0X0v/R5IR7sQ1R0OSJWuu7fIZDbu7PWSqlA7qkZ8oseJOcCvTPBiSA3Dp0vIlRneZkUk7BsOCbf3nUk=@vger.kernel.org X-Gm-Message-State: AOJu0YxngwBdWOVQ0JZ8/mz13UnXA1jsys0BhDxqkQqn1fAHTMDPLcYg egLTSTVs4VN0ewUypmHCdVqn/Hw1sNTVhVhCJmMT9jkutAIPTm8vuju+AZ3u7g== X-Gm-Gg: AeBDievyB/+TTk8NzfzBfy2ty38u8OnsfuChHe0GD0hfIalPGKsSIuflcR3xGQUMp2R 23nTUu/h0SaZXT6KX6F3W3PYmoMtaZLGms5kfuXD23sYmOd6ql82TfCLNk7Ga7LT1uvRhvNx1YK MocUP7/xWYGzgya42T0mPuWS2HR1RVclp50Pvd7u3x413R1rGFRzhkOsvtDVdkG0KuxPfs+fzit 58qdjWLWxqOtbnjZYR7OfZIv//7TrGu85kEEFuAikSQ/p56ert4r7q+MUhQYrKNmm2u5wCul3NB ne5WvOVVUss8UX2YMSew17nQzRRx6up4Hd+iRC+2XzdPSkoUlhY9Hs4cqgFks5Sgsakj+9cZPES c2dOfCr6y+/Q7xR3BLmMtBAwbWwoUWONLcdODCd2nLGPyTmQydv35dFvTjUyuJWnR/0okH/Mh4e Ja4GYuk+oshabHD9gsCXncyh+pKls2MBGiAOrLWFboCBIe+DciPdwj/GrQAEg= X-Received: by 2002:a17:902:f711:b0:2b4:61cc:37a8 with SMTP id d9443c01a7336-2ba53609907mr40685675ad.17.1778003226925; Tue, 05 May 2026 10:47:06 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:06 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 05/10] iio: accel: mma8452: Use dev_err_probe() Date: Tue, 5 May 2026 23:16:35 +0530 Message-Id: <20260505174640.3998281-6-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index d227ce3d5f67..b49949792190 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1548,6 +1548,7 @@ MODULE_DEVICE_TABLE(of, mma8452_dt_ids); =20 static int mma8452_probe(struct i2c_client *client) { + struct device *dev =3D &client->dev; struct mma8452_data *data; struct iio_dev *indio_dev; int ret; @@ -1580,14 +1581,12 @@ static int mma8452_probe(struct i2c_client *client) "failed to get VDDIO regulator!\n"); =20 ret =3D regulator_enable(data->vdd_reg); - if (ret) { - dev_err(&client->dev, "failed to enable VDD regulator!\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to enable VDD regulator!\n"); =20 ret =3D regulator_enable(data->vddio_reg); if (ret) { - dev_err(&client->dev, "failed to enable VDDIO regulator!\n"); + dev_err_probe(dev, ret, "failed to enable VDDIO regulator!\n"); goto disable_regulator_vdd; } =20 --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04E1361DD0 for ; Tue, 5 May 2026 17:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003235; cv=none; b=kEmpbu/0JPEkUAkdDHo3uS2Tbm7/p6KSrrZOES2lhtEmKVyVaO8W1CzKh2rR+hnbxZZQaEKDPl6u+29UjAts5NZVQkRA/pV2kZz4iKgcwiyupBU0ebKO2sl0Xmu1C8G8fILPkTDYcBtrUK8rjEOBOR/mjBuubvX5AqY6ctR+ZK8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003235; c=relaxed/simple; bh=74BbHk4KwopHm9jTxcu00JmtdsKxcIk2Jcrc1S6Dfek=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l8O0svkOeIIS+7qt280g5RjmsRwOwdxRow0rF2E2cIrXa18ci//eXXftMUznh5G2GbVRAHa/WoJJgTJRBla5WniGQY2Y6jFdd8ubkoiZpudJPkHYwJ6OcVvZL0L917xSNAQ/1lYYqxZyhW5147t5vrFqjQkgRTKBGP5gVA1QKbg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lEoudPHa; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lEoudPHa" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba17c8cfacso24127635ad.2 for ; Tue, 05 May 2026 10:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003231; x=1778608031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8o+TU90GRNliwuyGMLuu+yCImBRr1/AI618n8XgB2MA=; b=lEoudPHakK9NmeZfijOa9FfM3ajXZi+wY6lwKYyx/Q8ilYabro33fU2QLvNgrwOKmQ 5JEPWDvswE68ZNvhONBV9rqbd+PE9a3TA+Am4gP56z6UiANLLxKSJx8WG3e66swv/yMk hUG4BAPewy2lvFfmH5S88bl+87AMo2KHXyxlftjsg7bZ+m6awzwHynPT52ZsN/g8TD86 nyUzrEEJpEV2+9TrSaYMkY3x1uM/g/jzFK9Z4sKnxJzQcmUq0SoLmK1CZqFvGpchEckz yrRkf5QBfyKJ6jMuhXvCCpak0ZzhrckIZo8qsAmDXu0UNkGmUowtYPyLAaj1Cw5qx4KY W1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003231; x=1778608031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8o+TU90GRNliwuyGMLuu+yCImBRr1/AI618n8XgB2MA=; b=QwhgAGrYmPaHc6YWZmwUeRmLBjfr/FfaxIK6Uq+mVFEanPE/lpWp3Gxy0EViw6UJvB Gk7nKOo58YRcVbJEcBdWiUckHGrLTFrHnlKqIi8bYSAPvzRe4rcI337P+Q/OcM2XrSYk FwV9PVqIQZ0SZSuPOpMdf7o9BbUTIniFsZ1DmK+deR1ABZE/NzdmRn6Iq2dDHO5QkB2x HhrLQp8K3mMvI0FuuqZLxtZ/ygZek2zP5IZCr+OedZCuHz5LTd7DdgoWdCr+ab4Z0j6X XDVeU64Q/19ZRpJL8alUQYzveoXaRzGWA4V9XE5g82gtYDlJXAfM3UW7AEPEe+IH2whp CRbg== X-Forwarded-Encrypted: i=1; AFNElJ8txd8/nbD6W2UYd82cgHhZBz38H0uNlfzd0QtQJdl1wYmYerqdaugSe9DgSC+5IcV3pgX645tBrkpjYyo=@vger.kernel.org X-Gm-Message-State: AOJu0YzYDdr1ieRamje7hQKv//QtM8pVAr8DQ0MgrwWzlkuyxSug6PnZ omZws5iFCDZdbhMU88PN8AsN8uC7f884oUfDKa/Ce5KaXAeybuz4F70u X-Gm-Gg: AeBDiesJq661w1RBAs1PlXzelnzcHZbjatVZKw3cVSCVuNz9ytVoDoA1AtOjCsU4IRL bsk/K6txt3forPfu1o29MFOnEIN7m3vL8zBYP/1Xy37z4OQBWFnkEq5tNhniI7cFtco0xEvtJgB nYZf9VkjAhjCRhIO62XoAyuc53a4HQFMOnaYEF92aaFx40MoC8K32G8nmWbvS7QfojoxIhzuLzz CxTMuQpANJA1plO+j/dc9j8Grlyu27134qfMuCJA+5q4E3yqoP1p3i0W6j4Wz/FieikwC5wH1ho FuLEZ7KBoewzkLs/ZxVlhNBMQ5t4blxPOznJzZgxokcRAakbU84qxDIO7QJg8Thy/qZ7xmrGz0e dkzdbafRZcFbF0O/fT23dKhJuKnI5wJSAv/USJO77iPp7exfvKrg521Cuald1Bfcnu3CXrUSL2Q aW53oV1ybV3UJlJM60PkZ77og4xkTKDvAGjCdbF4VoSYLgglI23oHbVVc1U7fE6edinHIDWQ== X-Received: by 2002:a17:903:acb:b0:2b2:5503:1b8d with SMTP id d9443c01a7336-2ba535c157emr40983995ad.6.1778003231163; Tue, 05 May 2026 10:47:11 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:10 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 06/10] iio: accel: mma8452: convert to bulk regulator usage Date: Tue, 5 May 2026 23:16:36 +0530 Message-Id: <20260505174640.3998281-7-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda The "vdd" and "vddio" regulators are always controlled together. Switch to the regulator bulk API to handle setup, enable, and disable paths in a single call. No functional change intended. Suggested-by: Jonathan Cameron Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 59 ++++++++++--------------------------- 1 file changed, 15 insertions(+), 44 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index b49949792190..1c984c708ec3 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -111,8 +111,7 @@ struct mma8452_data { u8 data_cfg; const struct mma_chip_info *chip_info; int sleep_val; - struct regulator *vdd_reg; - struct regulator *vddio_reg; + struct regulator_bulk_data regs[2]; =20 /* Ensure correct alignment of time stamp when present */ struct { @@ -1570,25 +1569,15 @@ static int mma8452_probe(struct i2c_client *client) if (ret) return ret; =20 - data->vdd_reg =3D devm_regulator_get(&client->dev, "vdd"); - if (IS_ERR(data->vdd_reg)) - return dev_err_probe(&client->dev, PTR_ERR(data->vdd_reg), - "failed to get VDD regulator!\n"); - - data->vddio_reg =3D devm_regulator_get(&client->dev, "vddio"); - if (IS_ERR(data->vddio_reg)) - return dev_err_probe(&client->dev, PTR_ERR(data->vddio_reg), - "failed to get VDDIO regulator!\n"); - - ret =3D regulator_enable(data->vdd_reg); + data->regs[0].supply =3D "vdd"; + data->regs[1].supply =3D "vddio"; + ret =3D devm_regulator_bulk_get(dev, ARRAY_SIZE(data->regs), data->regs); if (ret) - return dev_err_probe(dev, ret, "failed to enable VDD regulator!\n"); + return dev_err_probe(dev, ret, "failed to get regulators\n"); =20 - ret =3D regulator_enable(data->vddio_reg); - if (ret) { - dev_err_probe(dev, ret, "failed to enable VDDIO regulator!\n"); - goto disable_regulator_vdd; - } + ret =3D regulator_bulk_enable(ARRAY_SIZE(data->regs), data->regs); + if (ret) + return dev_err_probe(dev, ret, "failed to enable regulators\n"); =20 ret =3D i2c_smbus_read_byte_data(client, MMA8452_WHO_AM_I); if (ret < 0) @@ -1723,10 +1712,7 @@ static int mma8452_probe(struct i2c_client *client) mma8452_trigger_cleanup(indio_dev); =20 disable_regulators: - regulator_disable(data->vddio_reg); - -disable_regulator_vdd: - regulator_disable(data->vdd_reg); + regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); =20 return ret; } @@ -1748,8 +1734,7 @@ static void mma8452_remove(struct i2c_client *client) mma8452_trigger_cleanup(indio_dev); mma8452_standby(iio_priv(indio_dev)); =20 - regulator_disable(data->vddio_reg); - regulator_disable(data->vdd_reg); + regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); } =20 #ifdef CONFIG_PM @@ -1767,15 +1752,9 @@ static int mma8452_runtime_suspend(struct device *de= v) return -EAGAIN; } =20 - ret =3D regulator_disable(data->vddio_reg); - if (ret) { - dev_err(dev, "failed to disable VDDIO regulator\n"); - return ret; - } - - ret =3D regulator_disable(data->vdd_reg); + ret =3D regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); if (ret) { - dev_err(dev, "failed to disable VDD regulator\n"); + dev_err(dev, "failed to disable regulators\n"); return ret; } =20 @@ -1788,16 +1767,9 @@ static int mma8452_runtime_resume(struct device *dev) struct mma8452_data *data =3D iio_priv(indio_dev); int ret, sleep_val; =20 - ret =3D regulator_enable(data->vdd_reg); - if (ret) { - dev_err(dev, "failed to enable VDD regulator\n"); - return ret; - } - - ret =3D regulator_enable(data->vddio_reg); + ret =3D regulator_bulk_enable(ARRAY_SIZE(data->regs), data->regs); if (ret) { - dev_err(dev, "failed to enable VDDIO regulator\n"); - regulator_disable(data->vdd_reg); + dev_err(dev, "failed to enable regulators\n"); return ret; } =20 @@ -1815,8 +1787,7 @@ static int mma8452_runtime_resume(struct device *dev) return 0; =20 runtime_resume_failed: - regulator_disable(data->vddio_reg); - regulator_disable(data->vdd_reg); + regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); =20 return ret; } --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 060DC4949EC for ; Tue, 5 May 2026 17:47:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003237; cv=none; b=nlYZ7mxZeu+CRP0NKqhnU+LgFkdBrCIYPRRkWpmykSUA6q20zZ5RXUBioThDSw9cHR0Tt0qJcA5IdVNGyXBPU/TeRKBr+viUfDO1ph+DMtUKPTxQPopwcxt38RoSrvUrFIpXVIfv+ZZgNa2pRTeeHXYrEpwGORGbnSRTixtinjQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003237; c=relaxed/simple; bh=Mtuja62FrHidWILVcOTdO+S6ly1ze79AOqSKRIYrB9g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KZr6tip+ryKnPG/jwTlRDud+xGhdmsA8wy0mVyL9Hn3Vj/9QiKB/apnfuFt8WCmhsSkJRtIIi7iwl9c2am5cke6g2vIS1E6sxVuUG5UDAsdG1dKilgLaWL1o96Jw4zoe5b9Fg14AgEAj95F9AZcB9iqwbkHuDeGc1zhl41qAEdc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OgPRL3UX; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OgPRL3UX" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ad9f316d68so23174015ad.2 for ; Tue, 05 May 2026 10:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003235; x=1778608035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WEPnTRoMbdigwNtehCMFnXOsqEDViLOsrmjhKQALWCM=; b=OgPRL3UX3h5w04xH6Y9sG1J8XY5hQT2yJoKzCtedL1T8jAKP8ma+S14A86OlelnIi2 nr0Wa1CQ/4UiCnaCYurWnnhnBHkeQ/e1pKqCAHKoJoiF8uQS9CVaE586IPhDTPafioHW OLfyHDiK3vYrLmTGiArtg3r/Wr+HToAWMKxA1FukFlZHPOEtmqZBdPi92KV3DcZVB2Dq QTbXgRKGk8PhFGV6vwQbZ1zdZbeEPRADmfF/9V6xkAbx63NqbtHOVNhelZCaYBV3MP9u u8qML7s8MMRccQeuOKw+lyDN6XoOdxLemFkAdHGD1oNhiXubF+NKRuNRpWs13raojelD IFiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003235; x=1778608035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WEPnTRoMbdigwNtehCMFnXOsqEDViLOsrmjhKQALWCM=; b=RBx1gjZdugjL2nJwWQGdvZ/o7MOMi7wXpYudFeKATGTs0e7RJez1RAt6fi1C5HkwNd 1jhYvNMTXutQLbImyApWMCxGEZUC78+t+OTdwE5YVk+h+MZx+SIv7OuugBWGRJlJ4oYF RFZ2xp0LLbAH6Js/qtNaHskSTKCqZhNuVO+CTgq32xzFK1W99ewbifXWlGI73DFkCsrv ZhgBTx2Jfk8Y7t5yedjmGfCvaYtMDzyKtT2641s0i7MYe7jDo88K58T+cY/i2AtQjV4x uyMIP1Y47FZNolxJXmicfHK3AnGRXuT6AmbsKW0pTZplyY9GUXVS82u35tI4/6eyNsPA JXLQ== X-Forwarded-Encrypted: i=1; AFNElJ+WbHiJazYPPyoUDIcuBGnv34x5qeolepV/IizzAUGCqJ03mMcpsRZd+7MNEXrSECoRi9GWEU171wPEpEo=@vger.kernel.org X-Gm-Message-State: AOJu0YzJA0d/cXtxaMlZLjAP1PT8b7X+kbPVCRmXcDs8y/QMwmcSiFoE qfEWFCZuHUn2sGEdPkWE2gdvMvvvZOU2g6yH+ZZlAFUTcc0YV4herPzjyd9fAw== X-Gm-Gg: AeBDiet0T8pLgtwIOV5FiorA6rxRjsj6/TvlofF0IQvaRGLIhCscpWQu4WUEYdbEPuo L12Fevs9aR5WdiCOnyV9DeZrxJcEGFLGyqLghxGsFJXmf0e/xFsRcyWXfBholqEErTZtALfCvqZ jhthW8c2Bh+6xFDwcwolmQOk6EF+lmbFJridXyDCLwyeVVdDHJTAxg0MIj/JmGplr53kyAK5Bsa 8KRSFuwj6O1vFz28cvAEkU+0T2JXfINRvhMtRCPGR2rv0pjCQ22ewthwICkb9Fj6gg64ybzdLB/ yd7UitmHusi6nV0nrtNEbDh3Xs/rL1IYJ9IbRRZ72S/mqXRU9ZixKRzQHlZdcKZ6vEMplAFyrsI V1XKRogHSWZ/sg8xUyUHlTgdqDfaxsTQFEfFCJf3myQRImudFGq86MD1Xro2Z28oTnU0xVHBdGt pl0RV4GL9Mxbmm7FRmlScJnz4VrVmFQjQZ/WD0sBfSe0reMbEuLUeajwkykqo= X-Received: by 2002:a17:903:40d1:b0:2b0:ccad:de1a with SMTP id d9443c01a7336-2b9f260b4a7mr158964595ad.30.1778003235159; Tue, 05 May 2026 10:47:15 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:14 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 07/10] iio: accel: mma8452: use local struct device Date: Tue, 5 May 2026 23:16:37 +0530 Message-Id: <20260505174640.3998281-8-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Introduce a local struct device pointer derived from &client->dev. This avoids repeated &client->dev usage and improves readability. Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 1c984c708ec3..2cd24b1543af 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -222,15 +222,15 @@ static int mma8452_drdy(struct mma8452_data *data) static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on) { #ifdef CONFIG_PM + struct device *dev =3D &client->dev; int ret; =20 if (on) - ret =3D pm_runtime_resume_and_get(&client->dev); + ret =3D pm_runtime_resume_and_get(dev); else - ret =3D pm_runtime_put_autosuspend(&client->dev); + ret =3D pm_runtime_put_autosuspend(dev); if (ret < 0) { - dev_err(&client->dev, - "failed to change power state to %d\n", on); + dev_err(dev, "failed to change power state to %d\n", on); =20 return ret; } @@ -1552,7 +1552,7 @@ static int mma8452_probe(struct i2c_client *client) struct iio_dev *indio_dev; int ret; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 @@ -1562,10 +1562,10 @@ static int mma8452_probe(struct i2c_client *client) =20 data->chip_info =3D i2c_get_match_data(client); if (!data->chip_info) - return dev_err_probe(&client->dev, -ENODEV, + return dev_err_probe(dev, -ENODEV, "unknown device model\n"); =20 - ret =3D iio_read_mount_matrix(&client->dev, &data->orientation); + ret =3D iio_read_mount_matrix(dev, &data->orientation); if (ret) return ret; =20 @@ -1598,7 +1598,7 @@ static int mma8452_probe(struct i2c_client *client) goto disable_regulators; } =20 - dev_info(&client->dev, "registering %s accelerometer; ID 0x%x\n", + dev_info(dev, "registering %s accelerometer; ID 0x%x\n", data->chip_info->name, data->chip_info->chip_id); =20 i2c_set_clientdata(client, indio_dev); @@ -1631,10 +1631,10 @@ static int mma8452_probe(struct i2c_client *client) if (client->irq) { int irq2; =20 - irq2 =3D fwnode_irq_get_byname(dev_fwnode(&client->dev), "INT2"); + irq2 =3D fwnode_irq_get_byname(dev_fwnode(dev), "INT2"); =20 if (irq2 =3D=3D client->irq) { - dev_dbg(&client->dev, "using interrupt line INT2\n"); + dev_dbg(dev, "using interrupt line INT2\n"); } else { ret =3D i2c_smbus_write_byte_data(client, MMA8452_CTRL_REG5, @@ -1642,7 +1642,7 @@ static int mma8452_probe(struct i2c_client *client) if (ret < 0) goto disable_regulators; =20 - dev_dbg(&client->dev, "using interrupt line INT1\n"); + dev_dbg(dev, "using interrupt line INT1\n"); } =20 ret =3D i2c_smbus_write_byte_data(client, @@ -1679,14 +1679,14 @@ static int mma8452_probe(struct i2c_client *client) goto buffer_cleanup; } =20 - ret =3D pm_runtime_set_active(&client->dev); + ret =3D pm_runtime_set_active(dev); if (ret < 0) goto free_irq; =20 - pm_runtime_enable(&client->dev); - pm_runtime_set_autosuspend_delay(&client->dev, + pm_runtime_enable(dev); + pm_runtime_set_autosuspend_delay(dev, MMA8452_AUTO_SUSPEND_DELAY_MS); - pm_runtime_use_autosuspend(&client->dev); + pm_runtime_use_autosuspend(dev); =20 ret =3D iio_device_register(indio_dev); if (ret < 0) @@ -1721,11 +1721,12 @@ static void mma8452_remove(struct i2c_client *clien= t) { struct iio_dev *indio_dev =3D i2c_get_clientdata(client); struct mma8452_data *data =3D iio_priv(indio_dev); + struct device *dev =3D &client->dev; =20 iio_device_unregister(indio_dev); =20 - pm_runtime_disable(&client->dev); - pm_runtime_set_suspended(&client->dev); + pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); =20 if (client->irq) free_irq(client->irq, indio_dev); @@ -1748,7 +1749,7 @@ static int mma8452_runtime_suspend(struct device *dev) ret =3D mma8452_standby(data); mutex_unlock(&data->lock); if (ret < 0) { - dev_err(&data->client->dev, "powering off device failed\n"); + dev_err(dev, "powering off device failed\n"); return -EAGAIN; } =20 --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDEB8480DCC for ; Tue, 5 May 2026 17:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003244; cv=none; b=cDPyH2rRjBE4gvE+nJeqFlwVdDRx7PXE+zPtwaetd0zUquwcQekHq4F4y4Mq2/+nWxDx/yq6s4UnAw8kFBqw3WW1oeoP/rNZUVq9uOUY8Ta1s8uje0dk4VgJMJuuDQTk5VmRCpHEBjF6Pp0QK5YZvMJ1UJ5ZNpp7aPADQYMexR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003244; c=relaxed/simple; bh=WcK2GcDqNaaiTtJknltb2zliZF2AboIM0EtKhNSkLLQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rafkS58VlVxqrvXbT9H8BCV7yNvxV8OSfrpuG8LYshtJPWyHA2dYuZQQmU9JjcEWMXtah+KrzDME8ToTHGhAySD2yE3hP1Y4OcJO2hXL6JhCLtrczzgV7XmFXp8mq8JZQ+T2rOk2W/UskpQay2IT+6PGWtq8Gx+iTciYHEpb9PI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LaFX//4O; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LaFX//4O" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35fb7c1a455so2038620a91.3 for ; Tue, 05 May 2026 10:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003239; x=1778608039; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hQvY2zanoXQzF8G6K+yMU4QmWySA5sByDgB3bL6cpQg=; b=LaFX//4OpplNy3NyVc9zH6xd9UHWAk7+ngXdAWetSjv+j/nJVXNUGW1Do+38T0Jzss UT0Ov3SzWAfw8VQbI2OK4Vyt0lRzAvSGlu7/IWMi6fT+xoUIOf4sGCLZmV63rHsvoELw kVksgUfNcxpEpM15sJ5+V77Uq75u/g44JwmSwZhZaBwJ3xsfKxnhYgPB6aL3XgiNAxwK ZWckLWIVaCRlIG45fhMrm1MDCYvmv3t+yDYmxqIaFSW+8A/6MRpPQaS1sPvwKax4IWwM RgsVAjiItOh8Z6JcwXR3fPif/PNgWGKlEQWBgmeFR7IKncVHi/F9H7IWmAEu+ti7dbo6 SGAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003239; x=1778608039; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hQvY2zanoXQzF8G6K+yMU4QmWySA5sByDgB3bL6cpQg=; b=Rq14lHXqb1a+Hcfo1ccGugWrSdMT++tlH2j/+z/rvYycXWwN4+NQDls6C3hmOvkC50 TRnvKiZFVls3yKNS69p0Uc0ABFGfdWvIOB0SdyJHVUkMYzprPyt9if6BdYKX2WMO00Vh cMbZNdlgnNAwm5yXwk2qWyFNrkBxfq5VFi+bV2QfaEC6gmua0Q9E3C1DaqKY8XyvWMcd dS/lE2rm09fS+L97BJBJ2Py3Jmfa1uWhjdlXJ8Ee7kwkcgl0YTZmXEcFn0pXXEo05Pls piJUnKH80l7Srqs5Jc+b+3zjtIe1nSP6bxudlo7l5agyxxAgUCaLBRz98zQI/Cx73oj0 Wo/Q== X-Forwarded-Encrypted: i=1; AFNElJ/ovp/I+wEtvlc39EIWLN3/NwdtU7oDnEzFb7XxrhPdeW6TgIaqJVZ/Kx/5HwxaR8gM8oS6Q2ZsTjWLGVc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4AKeoq7pXDkkte6/awWVKHWDoL4TxbqG5vy2NIpq2v98gYGuQ OkgFxZbOXdNsAP6f1YeU2E4eqG/WNqFFsotHHImXYIM9E/8noBSmjvdS X-Gm-Gg: AeBDieu5l2dZ1BWjxsInyILp/pZw6LF1BhjGFsUbXmiCy2cAnlvAVN10N8aTTLLz8h+ V+f6l62dvjj1I9Mxq/Rkuq2OoA7lSlqsjbYw/u3qzcWZKfI7CjMU2b51n60Vx0gi6T+VyJNG9sQ D2uhjE0SzHeedPTMovhxroFELKKB9/vd8j/bRCuQslX7eW+vdA2JRQoWO4hVLtrZ31D3L0tyOt0 Ey1Hv43gs9ox9wtQbTuLy8uzMFJL3pLuzUJ3S/Axh9/klOxXI4kbkZmkQeqfffqsm4i6xjnNv/F PJS+7cLwuxpyYitCppPS5yUfZ0VoWQIFIVCYGg+tTj6h64vJgIDaKnR/QUFpD0F5ZSfQbeI7dxf 4WnB5ktUCJqu9nfhmA0TZRboDsXZnUwPv+wxZ4qapYsSGiAH77AWAnrMLwRX4BaIKZ/oLCRFfL6 CNlv7Mv+LfExGDQ3LPS0aVRRH4gbeceusBt0KJIoRUjyVYyXzIYfU1yUUK1es= X-Received: by 2002:a17:90b:580f:b0:35b:e5ce:73bb with SMTP id 98e67ed59e1d1-3650ccefba1mr13939427a91.1.1778003239236; Tue, 05 May 2026 10:47:19 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:18 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 08/10] iio: accel: mma8452: use pm_ptr() and direct runtime PM calls Date: Tue, 5 May 2026 23:16:38 +0530 Message-Id: <20260505174640.3998281-9-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use pm_ptr() together with DEFINE_RUNTIME_DEV_PM_OPS() so the PM ops pointer is automatically handled when CONFIG_PM is enabled or disabled. Switch to direct PM runtime calls and drop mma8452_set_runtime_pm_state() wrapper, which is no longer needed. This follows modern kernel power-management conventions. Signed-off-by: Sanjay Chitroda --- Changes in v3: - Use direct PM runtime calls and drop redundant wrapper along with CONFIG_= PM - Link to v2: https://lore.kernel.org/all/20260422165643.2148195-6-sanjayem= bedded@gmail.com/ Changes in v2: - Use DEFINE_RUNTIME_DEV_PM_OPS to address review comment and resolve 0-day= bot warning - Link to v1: https://lore.kernel.org/all/20260414192045.3598010-1-sanjayem= bedded@gmail.com/ --- drivers/iio/accel/mma8452.c | 55 +++++++++++++------------------------ 1 file changed, 19 insertions(+), 36 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 2cd24b1543af..5ab981481599 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -219,34 +219,15 @@ static int mma8452_drdy(struct mma8452_data *data) return -EIO; } =20 -static int mma8452_set_runtime_pm_state(struct i2c_client *client, bool on) -{ -#ifdef CONFIG_PM - struct device *dev =3D &client->dev; - int ret; - - if (on) - ret =3D pm_runtime_resume_and_get(dev); - else - ret =3D pm_runtime_put_autosuspend(dev); - if (ret < 0) { - dev_err(dev, "failed to change power state to %d\n", on); - - return ret; - } -#endif - - return 0; -} - static int mma8452_read(struct mma8452_data *data, __be16 buf[3]) { + struct device *dev =3D &data->client->dev; int ret =3D mma8452_drdy(data); =20 if (ret < 0) return ret; =20 - ret =3D mma8452_set_runtime_pm_state(data->client, true); + ret =3D pm_runtime_resume_and_get(dev); if (ret) return ret; =20 @@ -255,9 +236,7 @@ static int mma8452_read(struct mma8452_data *data, __be= 16 buf[3]) if (ret < 0) return ret; =20 - ret =3D mma8452_set_runtime_pm_state(data->client, false); - - return ret; + return pm_runtime_put_autosuspend(dev); } =20 static ssize_t mma8452_show_int_plus_micros(char *buf, const int (*vals)[2= ], @@ -974,6 +953,7 @@ static int mma8452_write_event_config(struct iio_dev *i= ndio_dev, bool state) { struct mma8452_data *data =3D iio_priv(indio_dev); + struct device *dev =3D &data->client->dev; int val, ret; const struct mma8452_event_regs *ev_regs; =20 @@ -981,8 +961,11 @@ static int mma8452_write_event_config(struct iio_dev *= indio_dev, if (ret) return ret; =20 - ret =3D mma8452_set_runtime_pm_state(data->client, state); - if (ret) + if (state) + ret =3D pm_runtime_resume_and_get(dev); + else + ret =3D pm_runtime_put_autosuspend(dev); + if (ret < 0) return ret; =20 switch (dir) { @@ -1452,10 +1435,15 @@ static int mma8452_data_rdy_trigger_set_state(struc= t iio_trigger *trig, { struct iio_dev *indio_dev =3D iio_trigger_get_drvdata(trig); struct mma8452_data *data =3D iio_priv(indio_dev); + struct device *dev =3D &data->client->dev; + int reg, ret; =20 - ret =3D mma8452_set_runtime_pm_state(data->client, state); - if (ret) + if (state) + ret =3D pm_runtime_resume_and_get(dev); + else + ret =3D pm_runtime_put_autosuspend(dev); + if (ret < 0) return ret; =20 reg =3D i2c_smbus_read_byte_data(data->client, MMA8452_CTRL_REG4); @@ -1738,7 +1726,6 @@ static void mma8452_remove(struct i2c_client *client) regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); } =20 -#ifdef CONFIG_PM static int mma8452_runtime_suspend(struct device *dev) { struct iio_dev *indio_dev =3D i2c_get_clientdata(to_i2c_client(dev)); @@ -1792,13 +1779,9 @@ static int mma8452_runtime_resume(struct device *dev) =20 return ret; } -#endif =20 -static const struct dev_pm_ops mma8452_pm_ops =3D { - SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) - SET_RUNTIME_PM_OPS(mma8452_runtime_suspend, - mma8452_runtime_resume, NULL) -}; +static DEFINE_RUNTIME_DEV_PM_OPS(mma8452_pm_ops, mma8452_runtime_suspend, + mma8452_runtime_resume, NULL); =20 static const struct i2c_device_id mma8452_id[] =3D { { "fxls8471", (kernel_ulong_t)&mma_chip_info_table[fxls8471] }, @@ -1815,7 +1798,7 @@ static struct i2c_driver mma8452_driver =3D { .driver =3D { .name =3D "mma8452", .of_match_table =3D mma8452_dt_ids, - .pm =3D &mma8452_pm_ops, + .pm =3D pm_ptr(&mma8452_pm_ops), }, .probe =3D mma8452_probe, .remove =3D mma8452_remove, --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 031E44A33F2 for ; Tue, 5 May 2026 17:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003246; cv=none; b=TVGJJBvYf+I6TuSf7bOOGT2Ne8ryUbHR7Iq8L9Aq9aqlxDIC8HAZ3VHz3ugWCIZZxx33clnnaMWsRlCMAp6zZtrVm9ThnwP58vNu+yVymmlyTXCJcqke45ZqSre+mLKDG5uMWHRv9FC6qywyzEFvMG3Z030kOk+PZobrlPpxUVU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003246; c=relaxed/simple; bh=gbBWcCKF5SIdyOmHNAYksgzC+iEKG/dPVheYUVfk04M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ogPOYcMunjuXCVh5PCiRSMumGbpKpZqf2f1s6wV7Y7ohNgKxONry0lOsfQkgFJrCUEjl9hOPOkm3aj5NVOfTgZyRoe4vweP2cNn+JNXJ//iuk3hhwyMOdDke9roxeCysL8O7jUvVz8jMOm3uInpRHJD5qnIs7tq3vfMxqEdNYnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uk+CIIT1; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uk+CIIT1" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3653cb9c6f8so2409743a91.0 for ; Tue, 05 May 2026 10:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003243; x=1778608043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aM2ixPGoCvqmSBsLluGYBaizIvX/KE6p9fFw6df2t+k=; b=Uk+CIIT1B0ThtUapkbEyraDEgipm6uelvxUX49bOw5FLcuTQeAPUFtOOwx9iyx+Cna 1u1gf5NfwVyANvjbIcZr53FsEfc+fHI/pvm9RlTeOBGV5XMzfF9ydtDWwddzZWDp1+OG tbkV3KUNabgXjfFUuPYgkw+IqTJtErQDu2TxRLe4j3VaANw10aFDBq+rb18IA2sh148V WnW0qp/Ay9UnYRu/FzoDyGUWgn8Yqq+OPYbx9QNbhKAOd+hZRZ1IXdZgMERWXoIuaTf4 ebVolIxNUFgD1qtfEfp4xHKZZDaVMaZ34UMGwAoedg42ELr3HRZ+hsqfQA8IY/q9stPj E1XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003243; x=1778608043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=aM2ixPGoCvqmSBsLluGYBaizIvX/KE6p9fFw6df2t+k=; b=cl6vRJb+mRiZ4/tla4t9Anh5VjT+7sorh60C435YNT0zSE9o3FxCvEHYK0JKH7jchp D0M/7E9spHPry/oN3s13ZeNg/jZNsfeF5hpSGOqM9EtQL3ykxBgn/g+XRTFPa+aDzz3v feSK6846b2fzLiKA7gM5QHRS7Qht6h8mScYWkvlpwMSBuQdZSvWxQsi06Yymd4V7MCSg C5OnPmUOHdY9wO3bphxzYWcBzFRexEENmfysm4j8c8MWIVRLrlA/vlbALa0bAdja96/+ qEBMn2oRU9ehyrqEwVWFXoo9XNY7IKjNQ0y3xuq3KbjhoFfL41I7AOsjtcarJ3YvCgJ6 lGWw== X-Forwarded-Encrypted: i=1; AFNElJ8cFmq6vXOzSoXMZQxDAJIhfYXPMwPrSxk8aFr/JV+72eWFFnlPhcZh96/LfonSGElGktSF29Who3f2av0=@vger.kernel.org X-Gm-Message-State: AOJu0YzfRAkhwBJ1inC0EwTa6uQ8ChzugQyAbmWFvuJHI2Q5zTFmIXpP gNltrGa7Y2k/cru2tG60to8c5Zvn/D2dhnKtud+xOqV7pgnnMFPDJ53d X-Gm-Gg: AeBDieu1a4nNEVa7sN/MYzlZoxEXDq0hV5yK5FAxxzu9/OoBWtlvMY2kE4sU2ihA00r tvP0pYZRZqzq1SZ5X/HZsVeivP2jK5d6NtVMReZCM2zVYCJ7d/rB35rhQJN/pV3Pu3cIv9RzPR0 p0svOZeR93iX7nvWKKtUoLR1vBqvkrA1BCuwxLkUELdg3l47gy2PIIRjdv9BQcJvzjfCKfunu4u C6RaNYJ67++LcfKZxJ1ssYyi1hiedeLKwi1TrrHD4SuAhpwOwqjMRKJtFJZbdL+FOv/EpXwP1EX OWUkZqibfOGTrMHOQTReaCmZUDVg4/aTUM3mrYYI0umkTYCqj40mfg44vVMw7e92vWbrhk0I8pv K179RMyCCjYxBEYgcVrmSHO6p8vqwXIjp96zIg/otPfjG6C98D+8Zyl/qF8FKiX+GaVut4JuLdW fsfjwR3MlsvGnFN1xHxzpJdfQbFBKqCtjF9w/tXNUP9VKb8r4rT7kEOUGWUgoEvS7znF/tjw== X-Received: by 2002:a17:90b:4b90:b0:35e:3b08:8fc4 with SMTP id 98e67ed59e1d1-3657737bff0mr4022027a91.5.1778003243244; Tue, 05 May 2026 10:47:23 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:22 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 09/10] iio: accel: mma8452: Use IIO cleanup helpers Date: Tue, 5 May 2026 23:16:39 +0530 Message-Id: <20260505174640.3998281-10-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Use IIO_DEV_ACQUIRE_DIRECT_MODE() helper to automatically release direct mode. Suggested-by: Jonathan Cameron Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 5ab981481599..3bc53cfdac24 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -474,14 +474,14 @@ static int mma8452_read_raw(struct iio_dev *indio_dev, int i, ret; =20 switch (mask) { - case IIO_CHAN_INFO_RAW: - if (!iio_device_claim_direct(indio_dev)) + case IIO_CHAN_INFO_RAW: { + IIO_DEV_ACQUIRE_DIRECT_MODE(indio_dev, claim); + if (IIO_DEV_ACQUIRE_FAILED(claim)) return -EBUSY; =20 mutex_lock(&data->lock); ret =3D mma8452_read(data, buffer); mutex_unlock(&data->lock); - iio_device_release_direct(indio_dev); if (ret < 0) return ret; =20 @@ -490,6 +490,7 @@ static int mma8452_read_raw(struct iio_dev *indio_dev, chan->scan_type.realbits - 1); =20 return IIO_VAL_INT; + } case IIO_CHAN_INFO_SCALE: i =3D data->data_cfg & MMA8452_DATA_CFG_FS_MASK; *val =3D data->chip_info->mma_scales[i][0]; @@ -756,14 +757,11 @@ static int mma8452_write_raw(struct iio_dev *indio_de= v, struct iio_chan_spec const *chan, int val, int val2, long mask) { - int ret; - - if (!iio_device_claim_direct(indio_dev)) + IIO_DEV_ACQUIRE_DIRECT_MODE(indio_dev, claim); + if (IIO_DEV_ACQUIRE_FAILED(claim)) return -EBUSY; =20 - ret =3D __mma8452_write_raw(indio_dev, chan, val, val2, mask); - iio_device_release_direct(indio_dev); - return ret; + return __mma8452_write_raw(indio_dev, chan, val, val2, mask); } =20 static int mma8452_get_event_regs(struct mma8452_data *data, --=20 2.34.1 From nobody Sat Jun 13 20:02:57 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C62324A3406 for ; Tue, 5 May 2026 17:47:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003252; cv=none; b=k4bDCf+ED/k7EoRqOLKsdboTS9QS7LYVCkHdwtTcsbiY7a9F1fYv01gX+16n+rCZ2kiVu/KFzW+DVVjqn43FzaGt7A8d4znYfKMTWlrrYIGs/dRBnmJpgX9hN1hpAmf9xyjeNciId2fo8ACWr1nCKnzEoddqGdbSoVESCrsQymw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003252; c=relaxed/simple; bh=0aPtEt4ko/bnfbsxB34xLGU9UY4EBvpuxCJGx/Lx0KQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Gyk0mz33lkSFualF4vuLSkyISmFpnHKfa/JDDd64jO1wFPl4+NYmil/YZaN3fgbQ09rbGPv1vihmtIMFWow5fTr5WUhAkT69GU5IRMW7h06ylSC0xPdjt/qdDYdRjMjf2/qjk4nM/SzTZRDG1hGmlb0jK7R6AJZ06G1UjqnfLzQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SI7Ehag4; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SI7Ehag4" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2ba3e3c4f87so17691735ad.3 for ; Tue, 05 May 2026 10:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003247; x=1778608047; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cMfdiYOhCtE/zO7JszEiQJezv05uUDaSwuwa5j2WLnQ=; b=SI7Ehag4GqX5pouq1AhEeVZn53bj37amD39Z27GCAYqeTBF0DC6nu0zjrjt9Y1Vu5s uTLXKFS01LSu5rM4IfY4vst0xBYFIkDS5SbJ81+Ey15RRyTzfAPYBskYkcGdj+WlzgiC J7imIBNyQV9QCS8kolF3iK2Z7DvkovX9zUd8YMPdAjVRB9BTqV2FcZFHTZ0r3QoisFBY xcjWl8veUM43cqWkyRRErdGErF4FPMhzzdKMcghLe+B4iVneeXEhN4LyBiSWYU8z4ULM vHy105zDRWxtAmWczVtKjfny/xCzcVtcgLul+OL3yn+156t2aT5xoWojR0TwpK9eUI/U LOfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003247; x=1778608047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cMfdiYOhCtE/zO7JszEiQJezv05uUDaSwuwa5j2WLnQ=; b=AHQWLi9otY4k5asJWN1LZiGmSFDR564KZo2+EPLTPySBYYDcgNCx3uJJz3h+o8G6tM PUCmmFQdP378Oija2QWkWzkTfgWyFlk5Mq6ayFBp6woYB97ymQH0RHSyQfWSbQQxtxNP wRwc7NqtRAbsdwbHGjJE2W3f4AfFce8GU3d53JDYK+8fhDrmtBfxLNU8MQIw+MIm3tMz eP/f09+2a4xByrlkx1264QV/QWdGXYwwADY5u+O5KchYPOd4Rd14LWFCN9PUaRr7uSBV JuXhr8V3OzKJ/xdVQq4eV5mpnwfRI7QqQISWO4pYnAM14VWpBimxWE3y/QlmFIOaHsyb 2JWQ== X-Forwarded-Encrypted: i=1; AFNElJ+U6YVR0VLQqSXajB9mpjc6a8dWLGBjj+lLbGJxOfRQ6VQWBzV4GTEh9L+2dJHw+qlCM24g2LELUCBTAuU=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/t5eg+whqGSuyxLgFQJUDKmkxh9CdVDYWGwJbSHdBYm5v+75u TmtJNdL19g5BaamKDLBO29XPFIub6AT70au9lraOsFglWcwloJyQYOQ8 X-Gm-Gg: AeBDies1oRaRcbP7wruHgeHdBL3mZOdo1lh1yqHz9Ta2DviRMqVS/mguWAiGg77Zw8n M13+Zwc0fB7t27nA+roXFAfFyuLNzkUd8JqwhW/LXWxsOrPgfOKsdU+VO2Dt5A/Dg+fVlWKJ5JZ MDOn3u9WhM4txt4r08xrgNEEV2hKJ0o+pD8CUzdGfJutQt6c3V41bHg7hSANtvqFpIZW7xLuZc6 DOV3OfzFt1TChpM0KGydKYX0evu8BqhVyFxSoS6+0W/TZ2FqVNwhLtB/UFQZBMwIM/9P6GM96UE x9ckKzcWdN2KWMK6c+ummk3XjO6in64jKWDoailEHGDsyDK54r9gDRM6MSWKc1qBKNHaWHRybDu M0WS59XMqXcEUpmtgaxXZJC9mSJIUPrDUwVB2Mqcg17e+cMjzoruz1tjpUxC4uZ3wiD1SojhUj5 GCIrnRiHOL/KDtsUjYz24wOAXRs+PFRux346V2CH6XHRSlhq6HyARqUXdJBIU= X-Received: by 2002:a17:903:2a83:b0:2ba:36f4:5844 with SMTP id d9443c01a7336-2ba535c0e67mr35976075ad.7.1778003247494; Tue, 05 May 2026 10:47:27 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:26 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 10/10] iio: accel: mma8452: use guard() to release mutexes Date: Tue, 5 May 2026 23:16:40 +0530 Message-Id: <20260505174640.3998281-11-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Replace explicit mutex_lock() and mutex_unlock() with the guard() and scoped_guard() macro for cleaner and safer mutex handling. Signed-off-by: Sanjay Chitroda --- Changes in v3: - Following input from Jonathan extended mutex scope for IIO_CHAN_INFO_RAW case to include math operation under lock - Link to v2: https://lore.kernel.org/all/20260422165643.2148195-7-sanjayem= bedded@gmail.com/ --- drivers/iio/accel/mma8452.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 3bc53cfdac24..1370674d71c6 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -18,6 +18,7 @@ * TODO: orientation events */ =20 +#include #include #include #include @@ -478,10 +479,9 @@ static int mma8452_read_raw(struct iio_dev *indio_dev, IIO_DEV_ACQUIRE_DIRECT_MODE(indio_dev, claim); if (IIO_DEV_ACQUIRE_FAILED(claim)) return -EBUSY; + guard(mutex)(&data->lock); =20 - mutex_lock(&data->lock); ret =3D mma8452_read(data, buffer); - mutex_unlock(&data->lock); if (ret < 0) return ret; =20 @@ -579,36 +579,30 @@ static int mma8452_change_config(struct mma8452_data = *data, u8 reg, u8 val) int ret; int is_active; =20 - mutex_lock(&data->lock); + guard(mutex)(&data->lock); =20 is_active =3D mma8452_is_active(data); - if (is_active < 0) { - ret =3D is_active; - goto fail; - } + if (is_active < 0) + return is_active; =20 /* config can only be changed when in standby */ if (is_active > 0) { ret =3D mma8452_standby(data); if (ret < 0) - goto fail; + return ret; } =20 ret =3D i2c_smbus_write_byte_data(data->client, reg, val); if (ret < 0) - goto fail; + return ret; =20 if (is_active > 0) { ret =3D mma8452_active(data); if (ret < 0) - goto fail; + return ret; } =20 - ret =3D 0; -fail: - mutex_unlock(&data->lock); - - return ret; + return 0; } =20 static int mma8452_set_power_mode(struct mma8452_data *data, u8 mode) @@ -1730,9 +1724,8 @@ static int mma8452_runtime_suspend(struct device *dev) struct mma8452_data *data =3D iio_priv(indio_dev); int ret; =20 - mutex_lock(&data->lock); - ret =3D mma8452_standby(data); - mutex_unlock(&data->lock); + scoped_guard(mutex, &data->lock) + ret =3D mma8452_standby(data); if (ret < 0) { dev_err(dev, "powering off device failed\n"); return -EAGAIN; --=20 2.34.1