From nobody Sat Jun 13 20:59:00 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CA3A481221 for ; Tue, 5 May 2026 15:05:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777993527; cv=none; b=pCVumo/lbJ5b7ipv4cY01fS020mbeHsxrsyOLI1i6MQTTDFUxu8XsF6PcTusvv8+YY+PWXWnMvV62xTPiAD5P4qiTzThzikQQWFunXlYmhbust/VI3RetMFIMndhh47MLe2sYFwt7JMBajTxEp9Z/y6ez3yq5Ljd9Ib4DSIWvsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777993527; c=relaxed/simple; bh=ecGo9qip1Zr0HgOctn8PkgZvzbI3zPbirhy6qtti6R4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ri8EL8bctiAXBaK9/DIBEhdstHW0SSMnHo3UvnZg779ayo6cCwWc63VRyLyfm/iDwhu8yhz6RtCCiZnaZf7BRJkqIyH7wpG8TS2rwaZCD3sUZCh58Isx3tdMfUEEe+QvmM+CVMsmBr/fat/1mNnt6I2X+La3X21T7h7qsh9ClLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m22Sunfi; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m22Sunfi" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b9fcf7c91bso27542515ad.0 for ; Tue, 05 May 2026 08:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777993526; x=1778598326; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=tg9Dyj4SEtegvNHFtnjUZM+PQNlG8ZvENnGK+pbR6wU=; b=m22SunfiOjuo5BVy+X27M8pbUDNljimadMmuLIowQy1kGPg0+f/TEEbCQ7exZjaAOw sy5zecLT8h1VJvOZ+7DZXfjKuBDTSbcRVJe/kDLbUC/S8l59Dso1oV++iu/FczaWQ1Gn AZVBlJEEHDq2x1SGRcJaUJAX0IeABx8nVj+PiosNXARRGgtJOQi6nG/VyuGHX25dI3hW v6mPWY7r35DhGGciJMdnMN3TIDVGjSclo8jETCjmHqFuOPDxezyJgP0S3mnKrYI+a1oU 0iUpw66MKWA9QeRaYbCBDKf/puH951ZZcR47gi61rFTHqBW3w73zoax/0/RKCjDYQI3K fScA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777993526; x=1778598326; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tg9Dyj4SEtegvNHFtnjUZM+PQNlG8ZvENnGK+pbR6wU=; b=g0YxDcnplm+8JwKwMBxTiaXWL2cnXM87T4t+BJNCrWVh8/c9zHrSJZmWTAYa4wbYis z6tuq8SyRAun7HREyItqVVaC7kWll7DbxMPcfwir6DlWAPxjmh33FQPP9AiDE0CQE3eJ RPxmT2DfMAtI0TeeG3SSAuBsT7c6GdfNQZcZPMA3VmkU6vL5rHFVF4hxdPC/8NmBvU0+ iE8JN04HSVSlnvnqx+3agmWurf7s5Tp4WYyw3e2GogBKgbh/JzBKtekE96I51YqGsNSR OQeuRI52QJuSS93x1DDUX8k4sl/MqBmYPjXzXlGc+bPeWxyZoIrldcxwT7GyAbqFatmg DTdQ== X-Forwarded-Encrypted: i=1; AFNElJ8KSRYTzyT+J46Czvi5cfYNfgJe0yMH+95oEaX7Dhh1hjF3gaw//AasBFvFeBrqsfzNNWZZGTS5rkw6gWo=@vger.kernel.org X-Gm-Message-State: AOJu0YxaWVml5LoBNo8eeM1B0lRa/PhjoHP6Q6fQ6srb/1K9K4yLPBAW fasrCjo+SKFKShqDsebeOD6i+omCP4lkknJJuUi0KayOnUo2m9Eg8Xzg X-Gm-Gg: AeBDietIRNo6vEUOjTbDTXbWI7dcXPeg7lmX9abLTxEIJErEExkXbPqjNle2IsFX3L2 YxEG8b95gT90kp07Gi4EzqVTd7IuLrAdKo1SBLSBCpO1GDzgmtIKff2D+zG8yeNxoDigCqzz1JV WOCf8lci7kmINbaZTzfpMs/FHsyA8hl58R1Y6VRP3oiDVNFuHSbKzPi/cvkkK6iEM3CH4RIo9ET tKsJ5L2WDGw5HEinDs34luT9V0zBOvG0hf3IBrUm0VAe6js3/dQYhOOFRDYFylG/6Dj3lt4R89M HL3AawjounOevZTZHMZB8PiPonxhXmAlt5OuIeoZd6NFtzpJAskR4ranKB0wgCxD5/9Dj2GTpAQ FngBGMVQ6FNx9Smm4VeSY89d/8B7ao4PINA91EsADw1ZgXig+07r8rCGJt5jXcIkf1F3sN5pykX cZxkHvH2ZUangVq0kSEHKzjRaz9MkOS8G9fysHiIY= X-Received: by 2002:a17:902:eecf:b0:2b2:5840:80c5 with SMTP id d9443c01a7336-2b9f283234cmr95231925ad.37.1777993524987; Tue, 05 May 2026 08:05:24 -0700 (PDT) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae54860sm134083535ad.72.2026.05.05.08.05.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 08:05:24 -0700 (PDT) From: Cen Zhang To: shaggy@kernel.org Cc: gregkh@linuxfoundation.org, jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, Cen Zhang Subject: [PATCH] jfs: use i_size helpers in open and truncate paths Date: Tue, 5 May 2026 23:05:09 +0800 Message-Id: <20260505150509.1709161-1-zzzccc427@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" jfs_open() reads inode->i_size without holding i_rwsem and can run concurrently with xtTruncate() publishing a new inode size, for example from failed extending direct I/O cleanup. Use i_size_read() for the lockless open-time checks and publish xtTruncate()'s resulting size with i_size_write(). This follows the VFS inode size protocol, avoiding torn 64-bit accesses on 32-bit SMP and preserving the acquire/release ordering used by lockless size readers and writers. The existing JFS serialization around truncate is unchanged. Signed-off-by: Cen Zhang --- fs/jfs/file.c | 4 ++-- fs/jfs/jfs_xtree.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/jfs/file.c b/fs/jfs/file.c index 246568cb9a6e..c2eee945b339 100644 --- a/fs/jfs/file.c +++ b/fs/jfs/file.c @@ -45,7 +45,7 @@ static int jfs_open(struct inode *inode, struct file *fil= e) { int rc; =20 - if (S_ISREG(inode->i_mode) && inode->i_size < 0) + if (S_ISREG(inode->i_mode) && i_size_read(inode) < 0) return -EIO; =20 if ((rc =3D dquot_file_open(inode, file))) @@ -61,7 +61,7 @@ static int jfs_open(struct inode *inode, struct file *fil= e) * file is actually grown. */ if (S_ISREG(inode->i_mode) && file->f_mode & FMODE_WRITE && - (inode->i_size =3D=3D 0)) { + i_size_read(inode) =3D=3D 0) { struct jfs_inode_info *ji =3D JFS_IP(inode); spin_lock_irq(&ji->ag_lock); if (ji->active_ag =3D=3D -1) { diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c index 28c3cf960c6f..8658a21cbf89 100644 --- a/fs/jfs/jfs_xtree.c +++ b/fs/jfs/jfs_xtree.c @@ -2715,9 +2715,9 @@ s64 xtTruncate(tid_t tid, struct inode *ip, s64 newsi= ze, int flag) /* set size */ if (S_ISDIR(ip->i_mode) && !newsize) - ip->i_size =3D 1; /* fsck hates zero-length directories */ + i_size_write(ip, 1); /* fsck hates zero-length directories */ else - ip->i_size =3D newsize; + i_size_write(ip, newsize); =20 /* update quota allocation to reflect freed blocks */ dquot_free_block(ip, nfreed); --=20 2.43.0