From nobody Sat Jun 13 23:13:17 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6314431DDBB for ; Tue, 5 May 2026 10:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777976959; cv=none; b=DjoKkCxz3c6ggrRYWvLO1PTYm7+G3znCnLS1oFC2evgY1nEuYxG9LDb7V7jsrtNVTZNbyvhz5He/FBIDr2sbSQS1uNuO0MJR4gyn1zyV4xApy5ousgQdCGQ9FgR+iHp6b9/Ehblmm+PvYCDr/QNnW9lM6wzQcQd7leamLNW9rd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777976959; c=relaxed/simple; bh=kILhQAgY3kLM16GxFMfnMK5G+NAgnlyKR3dgRK8YfZk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=S6sKpHlLp+MnlhyzY4i50iiLTPnddU89TZaaXmO5nFCn6hQDVBopYNI8XzApTnsH2kNK7q9RQpfVFvCme0e3dUs4EKVjA6YwBsIKOuYwqIW1a/uKeQbhdUN23N0eY0ulgOQtkAH+Tzv/v/jTOVCYx16kbNtQxh2M8GuL6QLOpGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E+WBRSuH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aVP4WaC4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E+WBRSuH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aVP4WaC4" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64595Yct4028241 for ; Tue, 5 May 2026 10:29:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=HNlj60pJs02U5K85HJFOtq Zd7kl+At2FS1ldDOM8a5U=; b=E+WBRSuHgX8tuxSzKI1QFKFVkIjX265Hi2b9Rk qt2ZUpzOxrqWTxNzjWrWv5od9PCeXOFmgSOcyevZ+NDTeysIICCkOxDrmaxwRpkT q0KIdSvZ2c68X1ap6eCnC+8YVfvjp0ay4Nc9r85Hvwp5rY7EoE1XeCK4JWuUWRxp 773SCZVke0K280g13Ok02Qu2zN625zq4NYUqfg8SqmGtq5gxLMpwTeGqN6lzu4ca TZhdhJkB4keP1btznh9QYLxyLVhxRN6RvSKn0j7HG0WEyL2zhA9eSbuIB9BijW// mJIxj9+kqo7T0mEXVWW52rFcU4AdY/IJWk8laI4k0++DF56g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dydm6rb5v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 10:29:17 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5104b861649so22566181cf.1 for ; Tue, 05 May 2026 03:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777976956; x=1778581756; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HNlj60pJs02U5K85HJFOtqZd7kl+At2FS1ldDOM8a5U=; b=aVP4WaC43u0IhPpAzDzCiP5Z5zmA9U9YkLvHermgkxoMdV2cBlhlF9Gz30fLJHbxZv wdBNMdqIFUWhOFsr7wsTTT60CispfJvOI0U8TWiFKM+7aszs4DzHhAjPcRMCmN8lvL40 3jttNf1QuQv48wEvPZtGYwO5hJLpMW9T7GFOkuAe/fYw1uM1RBdiXo6qUqzVcGwS9nnt 5a/argLw9uz3fgzEn1oDu5iSQJme0G/jg+iJu3wO4nEMUU1IS1M+WTtJwKnv29sZu8Bf uWokySQeuq6rdjoIYLFD5XvRkT4ulPxlnBkfBFLbpdiIZnw2dLxAKtW+85yebKBkcMwI r9Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777976956; x=1778581756; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HNlj60pJs02U5K85HJFOtqZd7kl+At2FS1ldDOM8a5U=; b=ec7d5dpAjlML7dH8ET7qZYBPfYrSHo3peWY77/Jz9L35uQaNikTzyzIjOZYp7dATq9 fqiW+rmIH/mPUbfmFv4WLiGERVbW87oDfZ8VXODKYhE0tzlNdwvBBH0RNoV9//U48zjc rIDtCh3RrnLxyXERX6goYVUDUkA1aituFd024e5fVMk0JWoy9lUg9W0ouKVb6nMH789M VI1sQqwEZS+GhZbsq3dKSR3HcGHhnL9X/ui6vAgCL1fc2dRQ0eieOc+6ktXNGxA3KApz AI3EW8eG5dpPSKIAtCbaH/i/32AC2vULm9vb6G1jK6Cs2hMRVrPusaZ3S1CNo58BP7A2 LfjA== X-Forwarded-Encrypted: i=1; AFNElJ/fuGT4ysYcMTXWzBw1dueXEZta2y1vgP0/9xoGjEGlGN548qhoTon61iXmRCFQAZv4Aa2Zq7VmWFDU/lk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4N4lpITkUoivHjPa8HqVXMbaY5IafDevUySMn1ww/RFPrGIz0 /OUqABNZqbOmAn/9r+Q2BZb2c3EDy9U4BflXhfan60q7/rILek1nHv9JxfTHzbTXS9kw3NyRye/ eV9uP7XpcUJSySVWp8ddciimoMPcQ4/KXBWPTcX+PLJ46WGWj7q3eZyp+OoWrwRm8G+U= X-Gm-Gg: AeBDieu31MhAQfwTNSI8ev/jTbIabqOVlxXtyID0P9i20a695jVGx3hhTHG3LEcsgxi huEyZwmKslA3nB5SCsZKoMTU83xlMgsVm0+KLreT2AzFu3H39gYOjXxgjzo2aBZmpVUBOtIJ0od peyyNjOyRJbW9X5AhFglog4isRumXliMPAFDjXsz2Y9ei9Row+Xg11BbtVoVB822eqDP2N2QVPh peBZ5rOZ8sFS+luR6eTYjf7GCHrzvKzTE+b2pc1yQAUKPS2t4BLVMl5CrFR+QgraG8hnDkBywPQ VWCdGCYIps2RceMQbNXIoMjg2556O/3uekardqtQP5EinAQhkD6GLdYd6x8vcAH7gEq4d9ujF2z TLtl0z4agkaU/5o0EFxy2n6TYpoDGxUo1S5rSFZn6zKkSDkc= X-Received: by 2002:a05:622a:a12:b0:50e:5b04:810b with SMTP id d75a77b69052e-51306a53f21mr35476221cf.32.1777976939725; Tue, 05 May 2026 03:28:59 -0700 (PDT) X-Received: by 2002:a05:622a:a12:b0:50e:5b04:810b with SMTP id d75a77b69052e-51306a53f21mr35472161cf.32.1777976930638; Tue, 05 May 2026 03:28:50 -0700 (PDT) Received: from quoll ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8eba865fsm307039245e9.10.2026.05.05.03.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 03:28:49 -0700 (PDT) From: Krzysztof Kozlowski To: Lee Jones , Pavel Machek , William Zhang , Anand Gore , Kursad Oney , Florian Fainelli , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , Broadcom internal kernel review list , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Benson Leung , Guenter Roeck , linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Cc: Krzysztof Kozlowski Subject: [PATCH] leds: Move MODULE_DEVICE_TABLE next to the table itself Date: Tue, 5 May 2026 12:28:45 +0200 Message-ID: <20260505102846.186219-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2053; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=kILhQAgY3kLM16GxFMfnMK5G+NAgnlyKR3dgRK8YfZk=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBp+cZe19spmhey6vI4b/7yFmBq15pM1VGw4Lnc/ 0yugqzzGR+JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCafnGXgAKCRDBN2bmhouD 1+IREACFnSRy7ju4VscC9G9J/FnjAyyotS+ISKZWGydzAX1MOB9PooZ37Sf5UDalokelUZojWyx +WlYegVlUgcHuj/owKI0xzKKlWPvAiZvZBJF8xpz7fB//0+gOLZTmASdI7KAc5m5baDtLHlCRU3 yff/QwPa9U7qxINvtbwkiehLmw5d3kX2DBty0i0w1HsYcwsKuy3dEMamsQOyuugpFVUGg0vVnCv ElCuozk6ISPxKfqvd45OW/Tkc97bsYI5CcMMwcjJLxX4iQcJ6fKfVWC6rPEgiNlWYwflU8chPGz ZmbMxsaWTHZFcs1jiuui6sdmWSzjErhXteLFfaMg2NasVX4D6tnOpzF/Kl365cs1RBwryLXuvob WH40NocFZJsHEUelaeXcj6Ac10I2mP3CL8tet14HSRM/8SZEIhwsgvdTA2bTMEmHngqHIGhwvJZ nxnMOGPyFkORQDTKppoyrEwt4QCdexA3JMjD5q2kQSQocvIZtO5w9c2tmp0E7VOo8UneY5k16pM Iiwuc8ycvpIFz1YByD45DRaYhWEnUGX8Hy+I17MvaP5mTrutYXVLlUGo4r0LyahbdA1HnfIvrfU B0/GdY76K0MGfugaaFX6+dWIvth2w1djgET7sYBihXCBz2OC3o7iZ7PkwdhD7iIqMxppz9GjGf/ YrfAMNmEyXD8bVQ== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDA5NyBTYWx0ZWRfX1tHfYuuk92m5 TXvQrqZpAVpbA/4AF3JiUeqEF0L+KbKFFdjRFp9q9P9qSOVV+OvpSGaYt1lLTZHIqt/2s5sjIf5 Nr79eh0h4wtozmxIkGkCBEp/pRCahiQLKN1/qNvN3kE7ZR631Q0fZl1uMoPEx1Kf+5WnLQ4+Yty iMa199joKxS8rPxZ03FvPS2QRZfRJmJVFerjlzioBrDgzVeRZBeMBR8Qs2m4iVQ8298m2Q0kG1P cgAVn1j8FAEzKrIuXzoumWXWR4k26NEW+sLEXFhK32O7jLwD6RQsfOrEkF7/GuuxEYoQATMVYa/ pPDjFsNNVnBpttRH1c2f+IzMmWJWw3ePL74DzS+0CfL2mHwvFud4PiehDTMj79jtBBJGbWB4KKJ ZdPERHX8LunETjSVuLtI5G9ebtOsQnskIhxSv/PRM03U6qy0+IHUALHXGbMvLQWxwj4KBrcYGUM quOGlREidxE3RZTfsVg== X-Authority-Analysis: v=2.4 cv=K4AS2SWI c=1 sm=1 tr=0 ts=69f9c67d cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=VTue-mJiAAAA:8 a=UPwjdVLwzqKTMXskr54A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=S9YjYK_EKPFYWS37g-LV:22 X-Proofpoint-GUID: WmQaCvCCTqKERIYrXSaNVf-79V-fFWrn X-Proofpoint-ORIG-GUID: WmQaCvCCTqKERIYrXSaNVf-79V-fFWrn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-05_02,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050097 By convention MODULE_DEVICE_TABLE() immediately follows the ID table it exports, because this is easier to read and verify. It also makes more sense since #ifdef for ACPI or OF could hide both of them. Most of the privers already have this correctly placed, so adjust the missing ones. No functional impact. Signed-off-by: Krzysztof Kozlowski Acked-by: Thomas Wei=C3=9Fschuh # leds-cros_ec.c Reviewed-by: Florian Fainelli Reviewed-by: Tzung-Bi Shih --- drivers/leds/blink/leds-bcm63138.c | 2 +- drivers/leds/leds-cros_ec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/blink/leds-bcm63138.c b/drivers/leds/blink/leds-b= cm63138.c index ef2e511438cc..45c0662df933 100644 --- a/drivers/leds/blink/leds-bcm63138.c +++ b/drivers/leds/blink/leds-bcm63138.c @@ -296,6 +296,7 @@ static const struct of_device_id bcm63138_leds_of_match= _table[] =3D { { .compatible =3D "brcm,bcm63138-leds", }, { }, }; +MODULE_DEVICE_TABLE(of, bcm63138_leds_of_match_table); =20 static struct platform_driver bcm63138_leds_driver =3D { .probe =3D bcm63138_leds_probe, @@ -310,4 +311,3 @@ module_platform_driver(bcm63138_leds_driver); MODULE_AUTHOR("Rafa=C5=82 Mi=C5=82ecki"); MODULE_DESCRIPTION("Broadcom BCM63138 SoC LED driver"); MODULE_LICENSE("GPL"); -MODULE_DEVICE_TABLE(of, bcm63138_leds_of_match_table); diff --git a/drivers/leds/leds-cros_ec.c b/drivers/leds/leds-cros_ec.c index bea3cc3fbfd2..6592ceee866a 100644 --- a/drivers/leds/leds-cros_ec.c +++ b/drivers/leds/leds-cros_ec.c @@ -249,6 +249,7 @@ static const struct platform_device_id cros_ec_led_id[]= =3D { { "cros-ec-led", 0 }, {} }; +MODULE_DEVICE_TABLE(platform, cros_ec_led_id); =20 static struct platform_driver cros_ec_led_driver =3D { .driver.name =3D "cros-ec-led", @@ -257,7 +258,6 @@ static struct platform_driver cros_ec_led_driver =3D { }; module_platform_driver(cros_ec_led_driver); =20 -MODULE_DEVICE_TABLE(platform, cros_ec_led_id); MODULE_DESCRIPTION("ChromeOS EC LED Driver"); MODULE_AUTHOR("Thomas Wei=C3=9Fschuh