From nobody Sat Jun 13 23:11:42 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFE942F3C07 for ; Tue, 5 May 2026 08:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971587; cv=none; b=Sg1Yqx4FSRRjv0uIGTKXW42gJOM8i6Mc6caDSjGXFUBCm/A3gCQbIlNFqoQLwixlDxaxPlUQd697//Dpy0IMcKc5/EU9NXuW9eh5Bacpml8kNzNiDssVoAhGIYMRBJSe5aZ5l3gxmqRn/xpnSNexniVk+SuhtNdaAP8A1fbYmfU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777971587; c=relaxed/simple; bh=GtnmXgWBnlVbum8VU82XoIoP2qzEtwowPEy/lSbUNBc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=petBoSw3tu3RHt8FgJE82TYtgGW+zlSyRZKW41l5m0gcgTG0RmRBHG0cObkA2o1cqI8o7KvWtLtKkyqY9jKE1vOzqf923VI/ik3ucCa2wUEQUJxizR1R2jS12kPQnnjyMt4Hhogi0e6g5tvyAnzpJFJHrqLH/XyDDZ5o7/o9e9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dPNbfl+m; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dPNbfl+m" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-365425c98c6so1383251a91.0 for ; Tue, 05 May 2026 01:59:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777971585; x=1778576385; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=scgXwfpWRTztGmGbOBFzi2/rYTv6bkNqRVNUxAo7T3c=; b=dPNbfl+mQfuF5iFuA4h/oDLdV+N6e39r4NeGUMHjBrQ8VpddRgowN/3bUgf73Xz0UQ +EivlcGMfx2NMdJnxbGnkfZKH0oKpKd9lH1O3zEBueWHipWF2LW2vFu22kzwLD0xZXCE IjJnS6mzDEEZzDHqrJoW5Aj/3PYMRO+qtiuEO6ffgCbeyFGftbbfiZt/EcrajVgrdfoO Xp0d34QjvfonJnfdtp/ZvU6L6+bDDnUwlC+dkvCKnMlNaZ1iDDMD+53SECpP+oI8AWFH kGywZY4KHbkQRd4O6AQ9XPx8fmIQcmu0NCE3B5Z6VEw+wk0N+CXbSk8bskdQcO9Dc9Fd REnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777971585; x=1778576385; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=scgXwfpWRTztGmGbOBFzi2/rYTv6bkNqRVNUxAo7T3c=; b=XI0jqVQOLctw42ofsVCdzjf82tALtv5HxE70USmX2ptrV4th9oXXEzcw52GxUlZ32k kRw1z8wqq5fkfwuPyU9Te1y0w4qV6fgaZw6djiPRZMmjLcoj2nqNRnrAsCUDkHSfjbWq u7HUxOevtkuji17bRQ1Ooj7Ow5AfADAfBgFwLq9hD7oyDwXD/C1G42xnG370M+YLBPJv oCzZA0ZLM/JYCY/C9gUsyWE8xFPB2E1Q+Q7ipx068JkSBDb86FpPmSUj+/5StogOVvxw th5n9P+K05cBgGTNyxNTWoC6lL7SYF/WN1nitrrnVPPeDmBNDMhBKJVE0a2tEnXF28SR xEkQ== X-Forwarded-Encrypted: i=1; AFNElJ+Gh4yU33tg0I3UdwLN5BT9A3mvA/3IdIXyQGz5DReoCuhJ7bFbUuOBo8w9xsnHRFVbgzcKg8hk8OwIT9s=@vger.kernel.org X-Gm-Message-State: AOJu0YyxLN2ebi9c11nh3auqRg9a762Os0HLe8lI0PSD2f33H9/CI6VW HYJixYmW+hjpbHrm4oS/9cyeyubA5RZfX6kNSLtyp7IqQUpBqGHvwwUi X-Gm-Gg: AeBDieseCHapTNw27bD8S3mE5wrNEXjY2RMGrGjGT9UEqUEyrYAWvWjXyYd5nlEW3SU BjNUJecx2vCDSbw5YSwU5WeNDkgRamWg3TtLw/d5uuiOE0yqQPbHCqcFdLCgNp5mG2QCMTaeDxx ygnFGwBzUwpXbAyv5iN1bcvV7rasoNwUOttsjW3K4dJtLLXo/AIDY5dJoUkSxDG8fseL7/oO6u9 iPFw6x2AcodyzZuYW56L6r2vfdB628Df8E5KbJPl9m/1kKWCVIlxOifIg2PiIOV9GvCJSwSa1cO 0H1Rhe1oEa+pm4IOJKRXGaHvQEtIFGMta1sPOYHvC1Fm92Tv1jpFHG+MQhlXCz1YrJ9zoVWqFV6 Y4dh15cY4uRtXfyDZttBIhMqa4EzcAk8w41WxaK0mXibxKuYg/yHcBM2ymyL49e50Pqp4YKN2MG Xnp+1kXFtl9voO53HVslRXIqR2kYdIpYv8NLVKffEab2FkJ3/UAE5i+nc60w+mmS5YTGoGPbwd X-Received: by 2002:a17:90b:17d0:b0:35a:cf:64a6 with SMTP id 98e67ed59e1d1-3650ce552camr13753846a91.23.1777971585283; Tue, 05 May 2026 01:59:45 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364dbeb2db0sm19293267a91.10.2026.05.05.01.59.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 01:59:44 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Cc: Geert Uytterhoeven , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi Subject: [PATCH net v2] net: rtsn: fix mdio_node leak in rtsn_mdio_alloc() Date: Tue, 5 May 2026 14:28:40 +0530 Message-Id: <20260505085840.352206-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260504200356.3529873-1-shitalkumar.gandhi@cambiumnetworks.com> References: <20260504200356.3529873-1-shitalkumar.gandhi@cambiumnetworks.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_get_child_by_name() takes a reference. The rtsn_reset() and rtsn_change_mode() failure paths jump to out_free_bus and leak mdio_node. Add out_put_node to drop it before falling through. Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet= -TSN") Signed-off-by: Shitalkumar Gandhi Reviewed-by: Geert Uytterhoeven --- Changes in v2: - Restore blank line between `return 0;` and `out_put_node:` label (Geert) - Add Reviewed-by: Geert Uytterhoeven Link to v1: https://lore.kernel.org/netdev/20260504200356.3529873-1-shitalk= umar.gandhi@cambiumnetworks.com/ drivers/net/ethernet/renesas/rtsn.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/ren= esas/rtsn.c index 03a2669f0518..ee8381b60b8d 100644 --- a/drivers/net/ethernet/renesas/rtsn.c +++ b/drivers/net/ethernet/renesas/rtsn.c @@ -797,11 +797,11 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) /* Enter config mode before registering the MDIO bus */ ret =3D rtsn_reset(priv); if (ret) - goto out_free_bus; + goto out_put_node; =20 ret =3D rtsn_change_mode(priv, OCR_OPC_CONFIG); if (ret) - goto out_free_bus; + goto out_put_node; =20 rtsn_modify(priv, MPIC, MPIC_PSMCS_MASK | MPIC_PSMHT_MASK, MPIC_PSMCS_DEFAULT | MPIC_PSMHT_DEFAULT); @@ -824,6 +824,8 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) =20 return 0; =20 +out_put_node: + of_node_put(mdio_node); out_free_bus: mdiobus_free(mii); return ret; --=20 2.25.1