From nobody Sun Jun 14 00:16:49 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B9683659F9 for ; Tue, 5 May 2026 08:47:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777970881; cv=none; b=OT3NQ2BfjcL7KHVALAnElhi2zYKARpKaOhQBH00l37DQEqaY5hsNG9AZ7f/02DtxazgewJllCa2ISmi3sk4dw1NvvsWKW/TyeMCAuuzSMlXOw13scNfalOxKES3fqbSV9s3HMskzU0bCwN1qoPCqA+pI7OF5jOKnVHrfZo6jyqs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777970881; c=relaxed/simple; bh=1NVEGhQHLQ24V5uO8GejoHvvDxyflIwwSUWdcZiGgDo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=W+BnjnpHxce7ecey5R5ZrL3q//uQtxuvJhCdeLwM0IWLpQD5jEUGfaZL/vfaAta75I6sm09v8Myo6Bmnv0EYtHrBoHE6M9NlW+/E+jTkw187nj0cZkurEZeIGAytOT7+rsrwYFJQEI8wC0mYcj4xrG6MZ7PBAXZGqXDd74fHBMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=TZt+O7HY; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="TZt+O7HY" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so47832855e9.0 for ; Tue, 05 May 2026 01:47:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777970875; x=1778575675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k/HV+PJyPvR5SXo7b65roOSJJNehPyaCGIWDGwqA+Qc=; b=TZt+O7HYVZZ+1SOL+96OskdaHTnAJXlzLOUA881W4IPzwMZceuiv5ctymGRiayo1b4 EFA52PDbtclGgIrKPM/D4pi8ccxQ5Q7SvUvhpnun1vjz5jsWFh0ySGrQMIkgAsELs7is zW8pmYFdgrs9MSzHWgJ8XCwwM0F8Sr/Vamt0JVnEopbd6QOqT2qf4n5ZU5XpTILb2X9y JAAHiNhT/qH7KiBOCt/1KQ7eq0TKKYe0pK5B8r36XHd3Rv6PAE2DFmxuV2niQLoFbSAn NAOXB6710D0quqfpwUf0J7K21QkwIUyidLcSbMP7Jq4im4J+ms44fhvTwVPfyuFtcJA8 AFDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777970875; x=1778575675; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k/HV+PJyPvR5SXo7b65roOSJJNehPyaCGIWDGwqA+Qc=; b=ULUGpHKaL7LMkvhGOxCTUNnQezsM2/K3i6xaIoqFBfGRXNLTiBn3a90lF7GtbwVIFG BK9BfHshA5zocsFZWxFw539qVpk67pqoecNyIgnSeOQyv/G6/CC7A33Hv3g7yU9WjIoD Aoap46+fkiTf4AyDbogHpncajfZYEJ5OBAOGYY3wS2nr51Qz/nNzq/iyt0fBcC89XMB1 XQBnZEqMvm0+alwQRIQ3wRE/2OylaBkvNctWg2Le7YwGtj1FW4hyrS6CoMfP5McTEgOy 43mn7mzd6e1Hmv4aA43UXOu0lid3gPwVdGjwHyBQfI4My7ciMyBnipZmjweYWyahgr2h vSYw== X-Forwarded-Encrypted: i=1; AFNElJ9oObk6aVOgpjGNuGgg351gQE912G/j6IHULoTu8gDt+fwjMmfVWv60kXN04xIFRWhr+g6HwoKIzDzgVPs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2EcHRI8ax7wqF/r5616NJbvr668iUoSn0Dj5+Z2AIQk9X2rs1 xhw2jVYlcP/dZXuWhnzB9r3vnwhbz33Po8agPnYqAN71J74oUs9QvaWWjTacOVQ1nG4= X-Gm-Gg: AeBDietz7fSxgigJSZn4Bf4lRHNFIfrA+XWnrCyWUb+uzDo/HloPxVnWYELnd6Ez8XM w2YrZ8b9KIv/pdLEzmImJp4vE2b5qttDZhusKt3cN3vFYSQZqQAlCy/0biHxtSfAGDRzExDzKZP jRvENLb+iUXHsChXIm91n/AOFMybC4S4MoU/SdaguwCNCQ7pFj6Wx7vwc9O0o2simxTHWps6zyB TXLc+/xwxk0Cp+aTQCpAW6oIofMtjPZyMLH8CBjprBmQ4mfox4MiER8D06Z7kmcHGU9FdgXsRRx gw6CzNuF8/LCjOCB0qQ/ay2PzpFEmpAJz7uU0fEZqjeOyoArxol7Elb1vZTdFzbysTJK97wYW1V lDm14xaZwYGUNUCPhkUoOG6KmRDM2ml/8r3LOnkzoCVBVJ3GKUVT9pAAOYapA7Goa9Y5DTIfZtk dJQzN4omG3Gc1shs2cG4dXJ5UVMlm7GMMS1yfcqMILogduGwxzwS61UzyrQ4YOmji7ievXOhplm TUqNJlceCuOM2aaacvyAxNMDJ2L0mL+JoUC X-Received: by 2002:a05:600c:628c:b0:485:9a50:3370 with SMTP id 5b1f17b1804b1-48d187d9124mr28927915e9.8.1777970875124; Tue, 05 May 2026 01:47:55 -0700 (PDT) Received: from localhost (p200300f65f114e082236c6257eff72a1.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:2236:c625:7eff:72a1]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a81ed6b89sm382848935e9.1.2026.05.05.01.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 01:47:54 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Greg Kroah-Hartman , Jiri Slaby , Lukas Wunner , Dave Jiang , Giovanni Cabiddu , Kees Cook Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH v2] serial: jsm: Drop unused driver_data assigment and redundant zeros Date: Tue, 5 May 2026 10:47:49 +0200 Message-ID: <20260505084749.2304121-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3695; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=1NVEGhQHLQ24V5uO8GejoHvvDxyflIwwSUWdcZiGgDo=; b=owEBbAGT/pANAwAKAY+A+1h9Ev5OAcsmYgBp+a612hlhLL87K3OgO/IqaweZZlZ3Hk2A7zSly FHA9cAMKseJATIEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafmutQAKCRCPgPtYfRL+ TjvVB/jjfy9eJ8XTEGBHR9fjAInnl16glODxzFfWdnvHayDw14zfWfaIjTqmWWIwI6CuFWZRVRh cDzceZifk2MiePxS9pcmGWuKnroqkvAeqs1us7lG/2t4UzRB0VS75IB8OysCyGJ8xdukAeoj33f Zifkk28V8OGfa0RsdhB4BTxtW+/uaF5TSKxVcaNfRJhcxIcovLLBMe7TdUDfEqGyJBW/eMhW4Ls iu+leaVMArQOfCPeUtDg06CPxy3a6rfmONbLAxxkVzCR7XDS2HOihMao1wKCOg0RFrt+7MfdaS6 D/adpRhEYZqdhkbfNCQFJyGbIuXsgyns9fPONvaXZLameJg= X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The driver doesn't use the driver_data field, so drop the assigment together with the then redundant zero assigment for .class and .class_mask. Also drop the zero in the list terminator. While at it also use PCI_VDEVICE() to allow dropping "PCI_VENDOR_ID_". Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, (implicit) v1 is available at https://lore.kernel.org/linux-serial/20260505073044.2258674-2-u.kleine-koen= ig@baylibre.com =2E In the v1 discussion I mentioned that I don't spot a usage of .driver_data and Jiri confirmed these are unused. So this v2 just drops the respective assignments and thus circumvents the subjective discussion if my v1 really made the array better readable. Also the usage of PCI_VDEVICE() is new. Best regards Uwe drivers/tty/serial/jsm/jsm_driver.c | 38 ++++++++++++++--------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm_driver.c b/drivers/tty/serial/jsm/j= sm_driver.c index 4b73e51f83fb..8cd9b981bf20 100644 --- a/drivers/tty/serial/jsm/jsm_driver.c +++ b/drivers/tty/serial/jsm/jsm_driver.c @@ -296,25 +296,25 @@ static void jsm_remove_one(struct pci_dev *pdev) } =20 static const struct pci_device_id jsm_pci_tbl[] =3D { - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2DB9), 0, 0, 0 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2DB9PRI), 0, 0, 1 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2RJ45), 0, 0, 2 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2RJ45PRI), 0, 0, 3 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCIE_DEVICE_ID_NEO_4_IBM), 0, 0, 4 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_DIGI_NEO_8), 0, 0, 5 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_4), 0, 0, 6 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_1_422), 0, 0, 7 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_1_422_485), 0, 0, 8 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_NEO_2_422_485), 0, 0, 9 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCIE_DEVICE_ID_NEO_8), 0, 0, 10 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCIE_DEVICE_ID_NEO_4), 0, 0, 11 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCIE_DEVICE_ID_NEO_4RJ45), 0, 0, 12 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCIE_DEVICE_ID_NEO_8RJ45), 0, 0, 13 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_CLASSIC_4), 0, 0, 14 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_CLASSIC_4_422), 0, 0, 15 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_CLASSIC_8), 0, 0, 16 }, - { PCI_DEVICE(PCI_VENDOR_ID_DIGI, PCI_DEVICE_ID_CLASSIC_8_422), 0, 0, 17 }, - { 0, } + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_2DB9) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_2DB9PRI) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_2RJ45) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_2RJ45PRI) }, + { PCI_VDEVICE(DIGI, PCIE_DEVICE_ID_NEO_4_IBM) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_DIGI_NEO_8) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_4) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_1_422) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_1_422_485) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_NEO_2_422_485) }, + { PCI_VDEVICE(DIGI, PCIE_DEVICE_ID_NEO_8) }, + { PCI_VDEVICE(DIGI, PCIE_DEVICE_ID_NEO_4) }, + { PCI_VDEVICE(DIGI, PCIE_DEVICE_ID_NEO_4RJ45) }, + { PCI_VDEVICE(DIGI, PCIE_DEVICE_ID_NEO_8RJ45) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_CLASSIC_4) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_CLASSIC_4_422) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_CLASSIC_8) }, + { PCI_VDEVICE(DIGI, PCI_DEVICE_ID_CLASSIC_8_422) }, + { } }; MODULE_DEVICE_TABLE(pci, jsm_pci_tbl); =20 base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3