From nobody Sun Jun 14 00:14:07 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BCE63EC2DB for ; Tue, 5 May 2026 07:47:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777967264; cv=none; b=edzSq/iXkYyjDEXnf8JuwgvncnyU5Z52viH7SQ+i+g6y7kbIIIb/W+rpP8HSXtfiO3cKRoXSIhK5KMbGo2t5hPfJOVw8pDC2gPL/9VdJdUSKl/A9F7Jff0CiMtfsqsD0+jQyZ/XaExUmdIheJQupoZI7bpcmKdS5n8UvWSzGSCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777967264; c=relaxed/simple; bh=YHsc3xQ1QDh3wysRC+94d47hYC5ygS3eQHirSNAVcO0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dWp/5etzuKGYSYG653lyz3vTZjR0n8V9E2cCbFAEJINELd8b/xdF1BAT9X2GMWf1T2TLwzagRXCyakgxwmb959R1JVM26aaQ1zOt94i6wze9JLalk3otU8DYQHv4OSqdWy/rHNtBaaXD+lY/K/nUUIxkEIJJJOB2Tyd4ZzLDRjU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J+ZKe6df; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J+ZKe6df" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so1542941a12.3 for ; Tue, 05 May 2026 00:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777967262; x=1778572062; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jrXH8YnPwNKHXnbJs+WEopyj0kRSAn4kPV0vpzyDE5Y=; b=J+ZKe6df00DRPg7+sJzbUxFSwB2Xjus3t/kYkUEenRSskzf4xx1Gm1B3NRbQFH/d9/ KQ28XdacvVwygva+ZAcyE70ERBbXLoFd4udxW2+8SgLIPOvpz5Ko6DfPL6T3cBDKAhCs mveA227Mp+NHu0+XnUPdq0WGIVsUcGsWxpAyt3OS5ROvM74pJ2OngPFmXt+3EI4joOFo Z/aZgFC+xqSvuyK3AKLMwskwnmrywyNo+z0A6X0mxXgik3HaD/GRaR6cqUK/4yHuOxRJ qtibbisxXjSEZyVt6TmrqBb7QbpaIfrb1E3cjtbv6RDAT3KCd4/JKPvAX25/UYQolO9Q 6FhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777967262; x=1778572062; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jrXH8YnPwNKHXnbJs+WEopyj0kRSAn4kPV0vpzyDE5Y=; b=QIfmx30A9z+r4p0It13j6M9H46B+qoW9Zsx8u4IX4uiWsgpiI+HVQ0zedN7uI1p9kc b8jbEuABrg7YwHomVhHwvfYzEQswKVcBO611cijmFVmI72LfzzMI70CIBSiK3vEy2ijk mwiH5d+ml1ozo9PuQkHBU9hUeHpiZbF3Q4Wz9yOPKMWcDsn+vjLR5bhAbknfriSzReFo XFVE+EKyk3ON2FhcGA0IY1fkRk+l6zuJZjNf4ktSphLFMtmEo7Ol0a3plkJTS6Lkr6Z/ e5PTCxk+Lcej8P7skeYXLjQYHcODISxt5n9XjVLIjjJIuwOR2L/lLJURTvnUCY+Fk6ZP fipQ== X-Forwarded-Encrypted: i=1; AFNElJ9keWzke5NV2c8WBZsffGmZ6tW4r8HmyFgPP9M+yJkZOWdkYRLlCV1YFRkVsi6U1OTplNz2RpozE7XQaP4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy21HZAr5HfK6mH5wFw3rcfOp+9fJcLZws/kWHilobiKx3TAM3h F61jaf+CKgSkYrJcpnJbFxazgFvrqzpQQ6lOAZFKWfNIUgsimZviQWoa X-Gm-Gg: AeBDieuAilrlNhGG8loatTwfFqV3vKdDVkwEwh/KObgODceQU94o3qLnC6mTOt8ohYB uLvf43PWBuC0WftKKDw+Xb9UaQnZL967X5XbXyFQM84dd+F0B+a0reeLUlGlFmpXcmOsZWW9uub 67o0LNjQJCdst93NL2vYMWKuZ6if3UQr/XFxzlCf1GSnGaRt9SDE/lK1m9eD4WdLuQxy2tIssy2 iE1GDA0I7n5L83nDUB5mSZw0oBqzoYz6zamD8yyx1aKiG3ugxFf65zB3Wcqv+nziMs7XjM1ave3 /OBmV8V/MSveEmkuvhxoXelpbvQ5K0Xog9cPNlUQCGxvFcFp87hDHxaTCzRC4UZqpirUuG84Jys 2iFV7KFrp1LWmATHS7qXtElFn65TuUxYjE/1G1+f6HaCkDVWHjwEQM1Xv2YK+G6RBb7+iDwuQH7 PeZ46IwABTJCTOWXcVcWEacc5imdcg/qp79ZXCCHEjjEy5gs0ThSJSokkYtx2cycA+sjmoM4ebm mp4Kw0= X-Received: by 2002:a05:6a20:3944:b0:3a2:bd1d:d67c with SMTP id adf61e73a8af0-3a7f1f1faa1mr13682082637.46.1777967261529; Tue, 05 May 2026 00:47:41 -0700 (PDT) Received: from arch.lan ([2409:40e1:3007:cefc:472f:1ad7:13a6:92d7]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7ffbca2c49sm11833960a12.26.2026.05.05.00.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 00:47:40 -0700 (PDT) From: Aadarsh Chandra To: razor@blackwall.org, idosch@nvidia.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, bridge@lists.linux.dev, linux-kernel@vger.kernel.org, Aadarsh Chandra Subject: [PATCH net-next v2] net: bridge: replace simple_strtoul with kstrtoul Date: Tue, 5 May 2026 13:15:15 +0530 Message-ID: <20260505074515.636244-1-aadarsh.official.xz@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The simple_strtoul() function is deprecated. It does not handle errors or overflows correctly. Replace it with kstrtoul() in brport_store() to ensure that invalid user input is caught and returned as an error. v2: target net-next and simplify by reusing the ret variable as suggested by Nikolay Aleksandrov. Signed-off-by: Aadarsh Chandra Acked-by: Nikolay Aleksandrov --- net/bridge/br_sysfs_if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 1f57c36a7fc0..cdecc7d1260c 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -318,7 +318,6 @@ static ssize_t brport_store(struct kobject *kobj, struct net_bridge_port *p =3D kobj_to_brport(kobj); ssize_t ret =3D -EINVAL; unsigned long val; - char *endp; =20 if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN)) return -EPERM; @@ -339,8 +338,8 @@ static ssize_t brport_store(struct kobject *kobj, spin_unlock_bh(&p->br->lock); kfree(buf_copy); } else if (brport_attr->store) { - val =3D simple_strtoul(buf, &endp, 0); - if (endp =3D=3D buf) + ret =3D kstrtoul(buf, 0, &val); + if (ret) goto out_unlock; spin_lock_bh(&p->br->lock); ret =3D brport_attr->store(p, val); --=20 2.54.0