From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D16522A4E1 for ; Tue, 5 May 2026 00:25:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940716; cv=none; b=fBIvKss/yD2A3RImjFz2jfU1nXlIs7duDwlNuGORpmfYOWt2oBoDsS7jxQ8Nsg2vqf8spCMic144ydOsiEF0C+7Mi/pxq9oiWi7rWG3ZlvKWo7HN7h1uiL0VFf3QOES2CKl1I68znRU6gfrVAaKeAs7QOkA0KQXReYlEHOM+UME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940716; c=relaxed/simple; bh=dH38C2Kbg849nl4YLqXv/0VJPZa24rewDmxXYahkdsA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sCJgjywE01h47OWt1VkjjG9LyOAC49TJ3D+OuRbhOP1UV5Czzr/OQa4+r1IXsmvibuoBu4+Y9IJfXVfLEdl/qFZh+rHjYi8caCLcPBl+7FIX13qzoprtsF5BkiGal/cEFfRZpKwmc9tFSKJffblB665U6aQFzOvdjSMAm9h97xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F+YeDfkZ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VZ8Xu01z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F+YeDfkZ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VZ8Xu01z" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644IpKuh1151167 for ; Tue, 5 May 2026 00:25:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lefrgJVtEuX0KnRNQkpJGxwI16qD4hB9JXPY0Y5ZgqA=; b=F+YeDfkZWHOFpsDG QKXjzg6cxfHFinv0XRe7h11p3xF+u7RekwweaodT6oPiCxc43o2E/JloWzGY7mWF lQSHr78s9pxYtfGvQqwL4R54mLHB5iWS3ZNXdKWDprfhazR77KFU5R+lE1Pu8sbI mNpoyH1wHenN8AFoV9z4b1vwIsQUOLfrx1JFNQvx4wExcnu42tqno7G/eeTofRml rk1cMxbPy4G13s8y9niO0JnYoYc08EG0YQ4meaILo9vG7S4REnk0osqvG0Htyi4G xndOs8uJYk6LBmvMmMmabl9xfWkvpMaRYJXzVWRLpscJG2QkJiInvxhzGUFQeIev fLxNrg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxscyasf1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50fb3403e99so132400641cf.2 for ; Mon, 04 May 2026 17:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940714; x=1778545514; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lefrgJVtEuX0KnRNQkpJGxwI16qD4hB9JXPY0Y5ZgqA=; b=VZ8Xu01zXbsP1jQ4QPx0/zUg/is1deUu80+++WAp9i0wZSa4TLjUq9uAf+2KlgfC08 rik5uuNaVlamYv++myZUJke53/qdsAjQzatWT8jbvAc18g1+tLuRH1Mb92o1jo8trfui cXACuFr1J+ro7vgw7d3CuKxaHQxWkD+e097idqpyTC/wsuRKlNLv2yjk/ZTVGV1Ok72D BhVrG4NxxtF33fDgOwPi20sZtA/RMVuKbq7RtLjQ4KPza1sz9S2e4CzMW/z++3n/dWuf DEeoIqSQTmIZeoeeydUtpUhziW3XlOgB4DLq+MZGOCmXwAEoVPUwS4KUnYKABtKDeo41 HRBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940714; x=1778545514; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=lefrgJVtEuX0KnRNQkpJGxwI16qD4hB9JXPY0Y5ZgqA=; b=o4/3+K4MHRgnLR+ECRoV4f7efXlHsLk4RkQMc2IT8RDjgaVt2UVIFfluQH6MKAJ31R 7ZejyNL3gXjO5QdfB0uso3SVVr74VlhTdyz/iva5N7HZgaT8JSgu/OpHCYjla6KdgnF4 A406+mnG/pcya6QQHG/EDeimkHhuL5krGs8ARMNHdZ+wINKi8etPRZKuFECSsxL/s+Qc s9jPQVfRcSbkBTtJUSqWuv6XNmyPJBY+jO9tviRbzDOELmJrniEXJH0IZIpvT5NZgjpI 4qa9i6yA/RPKWQy4lKUJeGePoEwFBorNp80rE6mNMu0//QfMQa0tuNBOuG0ribHhAeBP jaEg== X-Forwarded-Encrypted: i=1; AFNElJ91d9Hb6qJJKDjQUDrW3V6dwv4FVbSHIORJ76ETdXF3SeB4enMnfr3JT5+9/tCPJA4R6scZ63vh+XxLDCM=@vger.kernel.org X-Gm-Message-State: AOJu0YwpDd6xoUWH2aK+p5bvbj3qCfSSo5BvxX8S5a9lzNtCLEUt1vay eIUIaHvSgj+HMul9U/ClSXdIrgqxG2MQDmU0sbh1zXUgUtexHMj7rRuWoJ5Qlie6gxAKvNkSSDa nebF2qTWPXO9i2L+ZhsUhLaikvyvDPlHsdI4JJj7sGc7N3VN0x1zaeqKHGV8/3zpYkog= X-Gm-Gg: AeBDiesEW491SNToY3WCQX1w4oUWx4lNMwWX3ikoqTz1pOIv3M9biENj7mIGHj5J+ot jpq6h9g3v/vB5a29s1HsDgkLeN13leHCw1er+cCLdc5uzYnM1H132LLHY87WRE/8wbO8mKjClqm 6HRtbZ1oe7I9COGCC6r3cCEzpU0Q5FS+wP5MJX4KTwv+/j4SV5kcCd6j1RF0sMK0ykr4kpQfQsK YENsezH4es7VaUGdKJhPMHoyFKwR5MZu08FF1Y16k3BHG18E9SfdR65ef/AXnP5QLtUuwb7wabt xBsdRoqGe6hcQWwdAtogCf5W6+yCe7pAUFKcchCGD77l/CA1pB5bqu7fjFYYNZqwG7ar3s69AYb zZsIpXMnZaZ0M8BzfDTkpF9Ckp1xgGXhGCKWRpZT7Hcpx/lY9tXn507+M5jJpmWq36jqUYx5JTX j8OX4QjpYsO/CZ4eBG7nuMOooHUa2fm6Lm0xLfRHzHZVRIcg== X-Received: by 2002:a05:622a:282:b0:50e:61c1:685f with SMTP id d75a77b69052e-51306b1844fmr14830771cf.50.1777940713699; Mon, 04 May 2026 17:25:13 -0700 (PDT) X-Received: by 2002:a05:622a:282:b0:50e:61c1:685f with SMTP id d75a77b69052e-51306b1844fmr14830191cf.50.1777940713228; Mon, 04 May 2026 17:25:13 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:09 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:24:58 +0300 Subject: [PATCH v5 1/8] drm/msm/dpu: don't mix devm and drmm functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-1-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1528; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=dH38C2Kbg849nl4YLqXv/0VJPZa24rewDmxXYahkdsA=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+ZPi9unXUNNI00Krz7+VDWt6BKz8kdLKWkRphtrvT+tO F3yoFekk9GYhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQAT8djP/t9rQ8Yu81/an5q3 rJSazL88v6Qg6rqfci+vw4F392J2OXhb6F+bXn7AUl1C48Ae0c1tbAcX+j+ZJflB8KL5/HkqJTN ye/T1bjRqM0+PfOD7Ivx9ZcRf9SRLa8/eeJmSyWEeQg7iocemipjYJE66WOLjYqdknH9QZIZhhc SFWQmania3X3p0u63XXMTwUzw04VhArOWiPNv3Gadi7q6sCPrJZ3z3Y8WlcrM0Cyev5stMi14q1 Ey0dW1ke2VoVigm05CXIVTAPu/wnl8LT7t5TSg3nf38A5NlKv/6Pe3mn+701XoFb52XvZ3V47Oz bMzx997pzGmPbn84VTR9Y1ffnBe27nwafrm3bhcXpxwDAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX7CN85OsMdQd+ oTJ3OKjhNzxcaLC2/pzAYoK7DF194uCyJ0yLmecQr8Jtxk++gnWJSQgba/nLDU0CrAsdUxAz7/h pN1NndsR3QExm9FB4O+bh6JL7TO7oZCdmsQLC/YW+pwpzUwBZNpHBLUdw8vJQMtQvHXlN9VuCli WOClAPM4CRdrIkv26HWwxOHjk50fwkGa9KCMg2i00YwrAdxUNuVxe5qZtWOv6E82sENcwSRU9WM 8KWGfDrHsHYQErNNk2aAOhMtKw5YRMsa4r5v0aM1NA08lm9bOAouPP5paiZEBGu9FpqstfZMTpt gradT2qEKrjHEU6E2Qm1Ha6hvAxV3RPjd4hx9vYyasEoe8G6jJ69BfvV5jN72UNe1htVGe50xf9 SO2iCKbaFcnerw8zfPNlLu5F3H05N5BBZgZImqjDvSsxHT8FSo4Hb1C078gh/J/gnjvUxwmA5GF aN9+nR6d6JotI0TqrnQ== X-Proofpoint-ORIG-GUID: Jw5-4JccOjUOOzfy-cCdW6l4uTdn6q7e X-Proofpoint-GUID: Jw5-4JccOjUOOzfy-cCdW6l4uTdn6q7e X-Authority-Analysis: v=2.4 cv=C47ZDwP+ c=1 sm=1 tr=0 ts=69f938ea cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=x0dpNPXvP2gp0MABG64A:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 phishscore=0 adultscore=0 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 Mixing devm and drmm functions will result in a use-after-free on msm driver teardown if userspace keeps a reference on the drm device: The WB connector data will be destroyed because of the use of devm_kzalloc()), while the usersoace still can try interacting with the WB connector (which uses drmm_ functions). Change dpu_writeback_init() to use drmm_. Fixes: 0b37ac63fc9d ("drm/msm/dpu: use drmm_writeback_connector_init()") Reported-by: Christophe JAILLET Closes: https://lore.kernel.org/r/78c764b8-44cf-4db5-88e7-807a85954518@wana= doo.fr Signed-off-by: Dmitry Baryshkov Reviewed-by: John.Harrison@Igalia.com Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index 7545c0293efb..6f2370c9dd98 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -5,6 +5,7 @@ =20 #include #include +#include =20 #include "dpu_writeback.h" =20 @@ -125,7 +126,7 @@ int dpu_writeback_init(struct drm_device *dev, struct d= rm_encoder *enc, struct dpu_wb_connector *dpu_wb_conn; int rc =3D 0; =20 - dpu_wb_conn =3D devm_kzalloc(dev->dev, sizeof(*dpu_wb_conn), GFP_KERNEL); + dpu_wb_conn =3D drmm_kzalloc(dev, sizeof(*dpu_wb_conn), GFP_KERNEL); if (!dpu_wb_conn) return -ENOMEM; =20 --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FA21275848 for ; Tue, 5 May 2026 00:25:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940723; cv=none; b=gEpNlkuZ1514HpyPwfDHdWiU7YpqTTk2yBQxkc7Ds0renc6AqG6l1bg2AutD9s408UmRXSyZF7OAzJm3Jih2nD7Tx/XS1FZEmxD5jstDxy86Tfokt7TN5XKYoe6ISChloVDR1e7vm3eHnyj+aHxYLtcQIF55WxubU38vMpwEaMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940723; c=relaxed/simple; bh=VXYhbpIFMk+a+YB6jZYpq3ZZlit2Dn3QcOteP6AnmKk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b8xNRhXAdYmIVJgaSD/mVm+mWGi1SFfw65+PhidIZpAvd76SvPTuBz3nJ4GcT5d4UWtVsNngmg1RTGjBSvbL6PVjC1wqua8Vh6BRwQwVI9FYCKgNH2+AYTGP84g7KDpJZs57h61p5zLdTk9LK0fHCw2cbz5TGnBYE81w95PaA8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a6xjJCq/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UKZwy5cQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a6xjJCq/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UKZwy5cQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644KQoEt331067 for ; Tue, 5 May 2026 00:25:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E7lYNft/WMRlNnP4xWSfKA/IuNz2ut4KJmCGdJbOpww=; b=a6xjJCq/WGW1/FEM AdOoV8K8FXhR0RZB/vBwjxGX0g2ifoQWb9yrZiO0XgSWdU1NCoiOPoFvScJr5hpF ITM67h3/DDvA2kacUeU42bEvricMPNX5rNHpf7jA6kKAIxz0yRwwgRmABn8SjP7u YdVqXttMYNs1ODYuZ+L9abxvXvE8vie99PuFh7IKpGrFfNiyYgG9ZyxdR3YV7EQV tnX1vY021ex1AcqzTIlJ/+kyJk5c5HiOZwVAUTspB5oK3kLXGndx7gKef/K9wAqO 9dIxCh6h/H5vw6Mbg59JY1rj7i0X2vFQPRfeQrK4ypYDK3jGJAVxT5rQbkQKtd/K vdI6YQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvr1a4x9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:20 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d5d1c2289so116327431cf.2 for ; Mon, 04 May 2026 17:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940719; x=1778545519; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E7lYNft/WMRlNnP4xWSfKA/IuNz2ut4KJmCGdJbOpww=; b=UKZwy5cQUrL8+6Ey1cgiMJVAvJ8JaxcS5ORjlbEKjGnhWoszIGQQ7CKUD14FYc4HEu aD2DJXNIUvv0c3eq0bpzSX+aMAZnOCQGixiIsjfRT/A1hGkaDVMqhgaYresf8RrSyirW dRa2ixhpQs0k7STCwQ4fb+JC6ZWU1rjjtG3VEIEj15+Y70f0cG4AVak39xEPA+CNqU42 eaqh5Hc5wjSRJbBnDNp1saToSeEC+9lTtUpQ2vUsPn+3R3h0DBzV+5ZheNY/hSfLzlUs oeP7BdwuCvuQxaPr8Yv9rwdESj+0LBemRlosNjKSWSzpei1ECwdZnU9370i1kt1VT3I5 ocnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940719; x=1778545519; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=E7lYNft/WMRlNnP4xWSfKA/IuNz2ut4KJmCGdJbOpww=; b=F9TX5N7nqM5U/kLPqlUJqpnpxyt69+ht85LS71g827ig2P2RWthBEAQuuK5i+HOgF4 YPO77VJ8a3s0HQBXyPi0vimcuG1dBGp6X108xJMaqM6rhZ65fgfTrVltx7KLCLoWzn/r asaUSKicTZP/rp7XKyyHSjWIK3vU1KEjz5PRHb83qP+8MncV/I33ZTVLA7y5MrovbAOm YbkUeDWYAFn4DI4/acNUdkgahsdTM9YTqkiXpyAYZkSucqghJQhqslJS8gpid06q0zqe BzYjVqzDnVL0gj9aH4oJwyUnu1EXcV0kUii6jXoPHZbab2H5cqnBC/BM+LK/Pn46g/VG BrbA== X-Forwarded-Encrypted: i=1; AFNElJ9SOIm8+RLtmBp484Ycjo30aFxf2rKl6HMReQVHsbQTPyIpwe4M2uqul6mnVjD2AC+jTyDVnfiP/Vu9ELU=@vger.kernel.org X-Gm-Message-State: AOJu0YwR2BtUdbFhWH0AvisunimUADKz73xAV47aoLue4y9od7hoQkQp rB4CB3Mgw+VfZBHs/aYZe6L5wzwBsUU6R+rPnwqowUvOU+YAEgFEVdvOxmU23acKNgAG2I/MTNU n+1HV1e1TFPAjmB32qGbUDC7Anx6/12azcp9PsDpY223dDNMjItOV7aUaLU6ESoXjzH4= X-Gm-Gg: AeBDiesSMzdYlLqI8CJ/EoA+JSRG0JzZP8yh8ZH4ZDvmFdLa5Ed09xjamhJ07ldtQX3 u/Ip/D/EWadvdjFzbsI+fsScHj2nKXMPnQcOPDUpDJyGjkpPp6MQ8NiMhsSGIW52m2GKBE8HrAv QrCDRV1ke2QfzXWXBD0P0FEsTxGVnj2/8rJySryC0m4Hh9bSNJ24hGXiYp7lIZFmFgwj8b4BZ5S E9zN8dhHQgaw82MC7eMJLUjcGYUEj9PdvIGz8VnDl8VSEF7c/h1thQz01i4UPqmoijWnKuJ4Va7 kwwIBoxOj97M30dYAAAGaZZ8TldBcCpSlOmrfDOCiqCAq2IVsUk7Oxmakc6dvxFwNwaDYAnxOnq +KYoA4xMq6xBJRLlgD8G/dKuAZagrr0rLS6HlOe2OOJCeb94qLbtRorQ5RWcjR41fpc560j3iqH C+g+nU7qqvloLN3VwdLvGpPF0rJP6UyG46y7ouSeFvJwkcWQ== X-Received: by 2002:a05:622a:418d:b0:50d:8172:714d with SMTP id d75a77b69052e-5104be0ecb3mr192101461cf.13.1777940719382; Mon, 04 May 2026 17:25:19 -0700 (PDT) X-Received: by 2002:a05:622a:418d:b0:50d:8172:714d with SMTP id d75a77b69052e-5104be0ecb3mr192101041cf.13.1777940718915; Mon, 04 May 2026 17:25:18 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:15 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:24:59 +0300 Subject: [PATCH v5 2/8] drm/amd/display: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-2-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3286; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=VXYhbpIFMk+a+YB6jZYpq3ZZlit2Dn3QcOteP6AnmKk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+TjbsYlM9JoBmtnVDGJmGqEqnq7lq33TSJtIg fTudvo5ePyJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk42wAKCRCLPIo+Aiko 1QxTB/9Aa3eYPFv5Q5FBjOoEneEfa9E7vysKWQgDGcnuDOOIME+jIw5me0iDQ1TEa/4WOWWmwPI NHwxxo/GLd7CVVbYW8Y4rWuxFvlKoiiDI2OXKKOBSQbwdPcvSzKBSlRWUQh7sPliGuqZyb7nGFN igTh5bAOSsXDN5dINbSbqKQxg+p6LAx+9RvNaftKq77283JdnlFC6mzlZLAmyLWlPyjH6Nc3vu5 6ej7HjsjMluWP5p2fqZxHuQSKKsEc3gTMKc7daHdFY3MlXj/UdzgBa19tQGge9K9imb5ta9xdp9 Owf5c4Sf2/QkVE7onaa0l/6vZ/VxAnTo7WfujqfsdQ0ofKOh X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: ESfufmBeHcR87e5zVkPpcljbk5ZOmkqm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX2TyHN+qYX7le bHWv+42AdVwi0HR1QPPSSUMXG/tuAk5NlBxvrszbRc1zAHvQpH3bguT75xTLiOptlIb2nSprG89 mDN8HEoYFeYCgVrMGXPaf5RjXiIkHjYjmtvCkaqRbbvKVP2V+1f3KES9SpLHFr1gqfNJmyWplpL YRu+tIAPhCDdWt9S46LDLBt/Bx52V1V4DzgljWZpzloG7LppQcM16A8pTbWUeTt+1LA1lWlFwkU Ecw0LfGttz+Sn+lz93akTAEavb2tvlb/i6PVAsaQci3AqEhlvKoraObjWoo37lHagae6dgTeQqH Yv/y09DQlHfK8Nbcq7dD9u33XeMMWyDLnHOe7x5jLUWsGsd3yeEhrJlf0oEdPEQyO9fujvLOCx2 Ut7dOjtv4LqfalGyPk75za4CpnENLY1hGy22tIdFdKl9FCqigprdvAyT0b6SvswPXNQ9/wsfLUc HvpWtzAzpLIO26s1Nww== X-Proofpoint-GUID: ESfufmBeHcR87e5zVkPpcljbk5ZOmkqm X-Authority-Analysis: v=2.4 cv=RvL16imK c=1 sm=1 tr=0 ts=69f938f0 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=M-qvw7r3wQx8XY5Jx90A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 18 +++++++++++++---= -- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e96a12ff2d31..2ac64495cdb7 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -10683,7 +10683,7 @@ static void dm_set_writeback(struct amdgpu_display_= manager *dm, return; } =20 - acrtc =3D to_amdgpu_crtc(wb_conn->encoder.crtc); + acrtc =3D to_amdgpu_crtc(crtc_state->base.crtc); if (!acrtc) { drm_err(adev_to_drm(adev), "no amdgpu_crtc found\n"); kfree(wb_info); diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index 110f0173eee6..fdc3da40452f 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -169,7 +169,6 @@ static const struct drm_encoder_helper_funcs amdgpu_dm_= wb_encoder_helper_funcs =3D =20 static const struct drm_connector_funcs amdgpu_dm_wb_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D amdgpu_dm_connector_funcs_reset, .atomic_duplicate_state =3D amdgpu_dm_connector_atomic_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -188,17 +187,26 @@ int amdgpu_dm_wb_connector_init(struct amdgpu_display= _manager *dm, struct dc *dc =3D dm->dc; struct dc_link *link =3D dc_get_link_at_index(dc, link_index); int res =3D 0; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&dm->adev->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &amdgpu_dm_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D amdgpu_dm_get_encoder_crtc_mask(dm->adev); =20 wbcon->link =3D link; =20 drm_connector_helper_add(&wbcon->base.base, &amdgpu_dm_wb_conn_helper_fun= cs); =20 - res =3D drm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, + res =3D drmm_writeback_connector_init(&dm->adev->ddev, &wbcon->base, &amdgpu_dm_wb_connector_funcs, - &amdgpu_dm_wb_encoder_helper_funcs, + encoder, amdgpu_dm_wb_formats, - ARRAY_SIZE(amdgpu_dm_wb_formats), - amdgpu_dm_get_encoder_crtc_mask(dm->adev)); + ARRAY_SIZE(amdgpu_dm_wb_formats)); =20 if (res) return res; --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDDB279329 for ; Tue, 5 May 2026 00:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940729; cv=none; b=hYHQJO2h8V57uCHpG8QRrjx5TpnsnMPR+RDyGyb+Rp+EU0nodIR9ziCU+VUVzBFZqwDXEVA8zEJAjnGFyNEfAZ2dN2iWL+0Ngw5a4cfIwQaLifTtxMKOb8vsMqY2H6o3F/Vj8CKgCCKpxUt32N5QCEV8xLbLLyMJZ7C4o4Ku7Qo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940729; c=relaxed/simple; bh=MhO3rZwygKwYvVhbAVjitmlBMP9oPZA7uZa37YA1WtY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HLkjY1IFjYz0oqDLQMJvlxSAVP9mJwsVmPGMBwcDdnfx8WTuJTcGJZ4VFw3genIZ0itURCdRxsZhzeYsnpD7W8X3unB7YbXbv1eHL5J4rUKe3SIeIJUsRvxj/qm2A1voR2Uy2gMQ8ijqfhcoRFVyVRdTt8lbyCHohienOCQHU4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b1dGjabG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WIummX6L; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b1dGjabG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WIummX6L" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644JUME5299982 for ; Tue, 5 May 2026 00:25:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rvUq8Kk9vuSdbxC2mnaQWgVoYwyqvsDFVMNCLtB92nE=; b=b1dGjabGKyCNTbxD yLDHiPiPeFvVWtTCkRJYDrg/dp/nU2DyCcAL/+dYSlOjmTsGeufe1sG3LJv4X6KI 6nFt9RHqTHrleZsnidTesSppQ/GDCRv8SSRtzGAmf4GtMS7jWQjAFAE5r+Cp1tUT sA9whihcJKSdWmkvHgm7/CV0GG1bEMNR0W1R7KsZIG1E2hOiz8dYEFob+dDInPzU kwVhb0roTk/XPiVKqgvrAkqFgLoZrFRwQEoIFX5MqdvevQ4CuAKOqaSTtSce1L/V cdVodcjRpMIBljUL2IuiNzYaYEuW+EcOSK67DMaakYd7jompYkuPW6Q7k+DEuZkQ 3UPZ8A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvnda6tc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:26 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50fb007bc36so119143941cf.3 for ; Mon, 04 May 2026 17:25:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940726; x=1778545526; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rvUq8Kk9vuSdbxC2mnaQWgVoYwyqvsDFVMNCLtB92nE=; b=WIummX6LxPwf1nP1vYUf2aPoa6Vg9vMyZ75ZVGpmwVDysD0KBVXPHTFMD3uZFN1tiX w3IdKN3Q834jtmy5981lErEiDrBXjC6evJGOenXkHACfhvUz+xU8uy3V09EKn+cvTbzW omsEZ7VysQbgy3CHxV2/7o35hh3HjTjG1A32uSlziEzfJATCCfs0VhDik8z6IvFRcq4T nNy2uzSEFwNwhbR/lVSJuPn+NmAlzeVfuO7RkJSHAyCVOnyZQhf2joRcfLzbwWiwFZR1 N5bxW1xVfoCh7RVKB1RStUq9+JTxxfjCuckloxQGi1rVolIygKP0wZq/L6DKTv6Xc7x1 dF1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940726; x=1778545526; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rvUq8Kk9vuSdbxC2mnaQWgVoYwyqvsDFVMNCLtB92nE=; b=Mt6AuoedmHaWRa77bFwaWpb8D7SW3G+SBBRjacVBqv/5DaZkuY6JEoCNcvIolsUO6e LWrKewjgWurxmTYcf5NVq2I6m9TyRgML3m2dseLyqMYSmJjuIV/Hq7Xd2+iKf9S/dyAy 5hE5wy9BMrrn86yh1OG6GUc9qTCQ0DaOzV5GdOIi/YYLRRoq/lZyDFoN7+3/U5KHDCj8 iUYh5HyO9iAMmV3ca4/R4lEP0JXhCX7Vxwm1/dls6DNkmv6BGlc+7D1tjtpqf47jqSFh xaV83u4BggK+bF3jYhwM07CWX1yU86K1yATIagIc7obm1PDxuePqBk0jyVKsXx2KYoGB nm8w== X-Forwarded-Encrypted: i=1; AFNElJ9AItkDtlNieGWdisAF3TlbWUgDnKGz6Mp34tm8S9CkvtHoDJWBnoUtWOUFv3HHlzV2ZCDxV4QXjyPJ/t0=@vger.kernel.org X-Gm-Message-State: AOJu0YxD/Br3KnmHxb7iIHYdsbY3IukccAJAJgOj2JbFBgDDtDiLwu7m Jt4iHRlWzp6DwS1fjmz1Zk7OtWxT5yNMnoQJA160bG4J6aqzvjma0u3SX2rClVhtWBbKhkyxfy4 Dit18dU5PmDUAXqfKUT4LsfjPxlJjACfdBbI0W8+q0PnEztofr++/jUam2JtlEo1/F30= X-Gm-Gg: AeBDies0eo+xFkXrEyanrhyObxOfwUzcwz4Sn0FW5JP9CWKJUCSmGSYmp8R8Ubo9USq Thu+JoP9KFB3SUugRaf/QXDb22fDpeDxQWl38mD4XblFek5+OM9duALUX7LwXGhgxGyETD4e6iE g/xyPh6vAjH02YqBK58/ZMwpH93R34HP6TCPOdrnfQHPIMP6jI8CLKq0hVPsaZ2S+FOhYFmqgh4 QtxPeIU7g4nDncH4FHOrGcPv0csLLVucSg/PYe9MWnKvgntVeBGEBICzghOenFzhtgUJzee/Vwu GRTBfirt3xftlrcIQCpio2dKA9sZsxnMSPd8bEPqt7vqmFRn4WVzdP04m9aqgzhF2epCZNieGfZ o2THtOKgroFujlqQwksdaDelcwzsrdm3cVfX0suOhzRpVaDuf49C9uRggCJudF9h+ExCj94+Zz+ /YH9QL8bHFsx4xuvBCkGU5aTI3zbc2X9VGU2CoCzoa0rTkaw== X-Received: by 2002:a05:622a:40d:b0:50e:defb:9dca with SMTP id d75a77b69052e-5104bfece5emr172357781cf.45.1777940726061; Mon, 04 May 2026 17:25:26 -0700 (PDT) X-Received: by 2002:a05:622a:40d:b0:50e:defb:9dca with SMTP id d75a77b69052e-5104bfece5emr172357201cf.45.1777940725522; Mon, 04 May 2026 17:25:25 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:21 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:00 +0300 Subject: [PATCH v5 3/8] drm/komeda: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-3-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3249; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=MhO3rZwygKwYvVhbAVjitmlBMP9oPZA7uZa37YA1WtY=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+ZPizsaWSG++ua3XqdZxT4V8/nV/ol/R89c0bPvy9Qf3 lvLEfS6k9GIhYGRi0FWTJHFp6Blasym5LAPO6bWwwxiZQKZwsDFKQAT0eBi/7FXLqU1JluVYXnM ek7FCO7OM2kLzANuVBVN6F3g+c0rNvzj/w9/CroPP5Qxya3MiJO1j/S7mKAp8+HIUsWTyzh5PM7 Z+GdqSh1NLF8v4TN5Uju7/TrRv3eEJzyaeanu8Zdol8sGG03WbTixIs/oTOdK+6SX+iprN62Pm3 gtZBm3l1SMrpmi3GtBXU51M/M/+XP35866ZvohUE3PJoOtoCfgn0BvkfjByEtO1ct/vDxVsn+7N 7c7Z2eNjQGTfbv1303fVcMW9m28Vx/F0Pq43vgk14Rcy1MbGhLOKGl9DpNKqjh4YmnPF8l7Rgpf WgOr+IwL71fOPSEeeUTI6hmD0KGVmncjd6t53GyrDAEA X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: eKqHbQ952lEBvBBM0d9exVqGhxqa16TI X-Authority-Analysis: v=2.4 cv=d9jFDxjE c=1 sm=1 tr=0 ts=69f938f7 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=gYs8AAvg_5cFonjPjrYA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: eKqHbQ952lEBvBBM0d9exVqGhxqa16TI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX26pB2hVj+iPY QQ4YA5JzJ5c4i2ve47K35mtg2JgvmmbzLsCLXsUe1Vl24D3LH0eoBWcCZJeBAGpxIexwr8V5Z7R BtlILDVicIjAwu2Epixo6jzaKGwfDFYQ864dB70js51vecoHmqBvScEON9htYjIQPDZt96pwFTy LOHGWuBU8V2qvYngBRGaUmteNR3xOoLx5wbh8itIG6aFrMhJM+/IvcZFaZLZhI+2kr66ivbFMJ4 N4siM7sWWbKh3TQFAKya88jTFc42m4uECzC+PQWSDRjVGN8HhQ1D0C8h+ZxaFvAOD0Ld3CPLzCd vgzBar0FxNR5vhcz0XtYQrkUmGmUC6Sr3QxiOyeBcsDZ9YLn4hBzhAaXBiKO2YgOYwsFSF1HIbH Pv9kgQmIlp/QEXR2RCvnrCh8YYYewjEQHppSnu49PagyOq9jc7BlEW93vBftpIFhqmrU+yLpkIo dehLmOAlQ0oQwUOPsoA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov Reviewed-by: Liviu Dudau Tested-by: Rodrigo Siqueira --- .../drm/arm/display/komeda/komeda_wb_connector.c | 30 ++++++++++++------= ---- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c b/dri= vers/gpu/drm/arm/display/komeda/komeda_wb_connector.c index 41cc3e080dc9..bcc53d4015f1 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_wb_connector.c @@ -5,6 +5,7 @@ * */ #include +#include #include "komeda_dev.h" #include "komeda_kms.h" =20 @@ -121,17 +122,10 @@ komeda_wb_connector_fill_modes(struct drm_connector *= connector, return 0; } =20 -static void komeda_wb_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); - kfree(to_kconn(to_wb_conn(connector))); -} - static const struct drm_connector_funcs komeda_wb_connector_funcs =3D { .reset =3D drm_atomic_helper_connector_reset, .detect =3D komeda_wb_connector_detect, .fill_modes =3D komeda_wb_connector_fill_modes, - .destroy =3D komeda_wb_connector_destroy, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -143,13 +137,15 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, struct komeda_wb_connector *kwb_conn; struct drm_writeback_connector *wb_conn; struct drm_display_info *info; + struct drm_encoder *encoder; + u32 *formats, n_formats =3D 0; int err; =20 if (!kcrtc->master->wb_layer) return 0; =20 - kwb_conn =3D kzalloc_obj(*kwb_conn); + kwb_conn =3D drmm_kzalloc(&kms->base, sizeof(*kwb_conn), GFP_KERNEL); if (!kwb_conn) return -ENOMEM; =20 @@ -165,11 +161,19 @@ static int komeda_wb_connector_add(struct komeda_kms_= dev *kms, return -ENOMEM; } =20 - err =3D drm_writeback_connector_init(&kms->base, wb_conn, - &komeda_wb_connector_funcs, - &komeda_wb_encoder_helper_funcs, - formats, n_formats, - BIT(drm_crtc_index(&kcrtc->base))); + encoder =3D drmm_plain_encoder_alloc(&kms->base, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &komeda_wb_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&kcrtc->base); + + err =3D drmm_writeback_connector_init(&kms->base, wb_conn, + &komeda_wb_connector_funcs, + encoder, + formats, n_formats); komeda_put_fourcc_list(formats); if (err) { kfree(kwb_conn); --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 993442773D3 for ; Tue, 5 May 2026 00:25:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940734; cv=none; b=qC6yhdvtzuq4ViXiDzB9mOqKe5lEMMuVKX9tQ+wc2D9rrfqenGD2bXMCUxSI5a+wkm04XMb2KiPbyVvwovmkWiJjBbEdUJ2Z9bIdrn/ueB6kOBG8BnFp4EYJS93WOI8cnzaUqHdedHmfJA6Xz0DB2NTXmTr7wOW+r0hcAkdWS20= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940734; c=relaxed/simple; bh=FuBHZIwie1er5ktaJK0YV3oa/OgU1IZweJZeXfhYARA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IbjP2FII8DSNP/zBHGl9UUs/IWsub9CNPjjpjrc/lWxJF7XDSY4DDOIjmzzwjGyfMXeUTwL4ZTFbC2NqPL4aqXVkcvluzX1L5pQco4lQ7qBlsIj234Ujy17GzSmhxGXeVKG3LCE/dJw9VkYQVrZmUae+A5pQViCIotMducVnxgo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JcLh5r+N; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IOgn8OD5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JcLh5r+N"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IOgn8OD5" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644LJLIO1960741 for ; Tue, 5 May 2026 00:25:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rWAgm8yZqkTEWO3E+Iv4QtTY54HVAbGewYLkSKrtuKw=; b=JcLh5r+NdnvDXCPH SiN8bTU7T2LYWQr3hx1QzJnaS3z5Sdwb8B+XSb0fjl/J8d9ptAouwR9lBJp6e9C8 Vhc7IGi/89P+wfGWADGvSvVAUu17Q3PyVmIf5CBtLNh4SF/tRC5eVYDcljP/5v2A L3WPQudZERv6PSruEpBQ/y8SuzyG5u5jj60ShrTOuY9fiSedc6w8lEWWCpXyGMaV vYDCG53sZ8fQzNJ7YxAfaS9qbc5pjbSvtmIk0iAKcjgUbo0ObdEekw9pq3hM/Kj7 akRnUcE6AArhWtGsTa7x/Slbpz1y/HezRXNADmQXDWvalNUTzaj/jkfwJZds1qRq 7+HpZw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxw5dt15f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50fb007bc36so119144911cf.3 for ; Mon, 04 May 2026 17:25:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940731; x=1778545531; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rWAgm8yZqkTEWO3E+Iv4QtTY54HVAbGewYLkSKrtuKw=; b=IOgn8OD5+vdGjV6GS2rrJcSke3Ry1176rZc65BY1+UgaZeG5PfboaI0Ddif5lPr4Az yUPKixpLywqehWHa0+bIJmZMKzstCPThvACACr+da0WqmpI5eAL2JoNVYPFM3xXQPPUh casCMjXbf2fJ6y8qs7y0BRfJ/WDg/wAoGIxh6avoDclmvZBRz7D9Myc3UwfdSkL5RF7L S972X23RhqFXtTTwIHuQeJfq4iLT7nmjYtW2z1tZegZFIv8AtV7yf+jyaBIUiyENhDzi I3uAUEYcSzlPZhzpKGx7kxzZlkNKTCVXP7bG43/74yz2+e9cCvpWkCO7Zdbbf5IjYQ48 vUPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940731; x=1778545531; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rWAgm8yZqkTEWO3E+Iv4QtTY54HVAbGewYLkSKrtuKw=; b=qm9m5Rrj37jfbUkx5MkLRURJhqpPvVt/gchx5tWIkSXUlzYW8dPP7P5P7+CiZ6P0Mg qxbxz7OZ4Cc4LV47PIZU5504dHvbRwyRtt2zS1Wid/mP/yXmI48KEpBF90s+hb4+cqjO ZdiI/6V8rnCcV+F4GaMI+9yhUJzKQHw4BeN5aieqw6XX05UFJkQLFhQ5MQfnn6j07lX/ C16+PjglSNZ1w7lVP72o6Yn3ajivTiSRRDkzTNOyfnSlMNz1JGxIQLRjCnedXuBmtjXt s7JCOIl+k8BIm3uRBmO8QhdSIucb5ifAgPavwvZAjKC21LvKnOfdyDUacOE+tlDQuq5z Y3mg== X-Forwarded-Encrypted: i=1; AFNElJ9MRykJAmbU73snE+GTdw9yDJh3XZHbhxyRHVnjY4Ef0Lhd+pJTCgbnq6QjXqpGWvqPJDbI91bLR/m1/zg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9Xp6DejyY1nNEk21YuN8+xXjzHMXDvfLv8YoqITD2BY849NUI OmUocEMqNrj9JVv/YgBBvmeINrdw47e7hpLTRf3Icv4bK0wTwoDj9cUm/UrAa1OfHSBe6efsOb6 vG+UaXf32S2Hcf0pa/wFPuNxfW7L07k47QRIpgsyuaOzdgMvfwYqYTekZw1sVTAOuH9k= X-Gm-Gg: AeBDiet0PTi1ef7nv9dHi3+iNeDct8ornbi/Uv9un3rK4CvbkPLjfshG28l6Lq7Bnpx P2Bls7sCuPd2E0jGRQdUvMsV4O7Q4hzFWmAWZtP72SmPQW/O/PcHOWeEP0JQf1OgbGVlZpuGnz1 fr94Rk/4Pjaj4zsNNrx8GkaqnBAFPophWBHJ6+9i5Dgf3NgfrBSmARITQTtBEcj0fhNIPZ4eySB GF41511eoKFJmQXCiNIp0M0755M1op+Yd/4P3nAYHxNuJWVSvJ+YOhmnKyqBCaGwtvyM3Njocgv DXB75A1KgYaIfIeqh48uSGryP5yTjKZWDknDcg8k8qx4alkSHD90d/2b8DvSFaqaiAYoSwjYkfO finSGKHLOoPbwXkeyhVBG/3sCMn/47Da+cjkJe0tkzBr2uATkdMNXzuHRCQq3SM8idJvX2nIHP9 q/2xsmL2rFzNnkvWLs4PqOm0/NrNj87RWHcJuiVAKmCdfPeg== X-Received: by 2002:a05:622a:90d:b0:50d:91e3:b668 with SMTP id d75a77b69052e-5104be76597mr167209221cf.20.1777940730801; Mon, 04 May 2026 17:25:30 -0700 (PDT) X-Received: by 2002:a05:622a:90d:b0:50d:91e3:b668 with SMTP id d75a77b69052e-5104be76597mr167208721cf.20.1777940730379; Mon, 04 May 2026 17:25:30 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:27 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:01 +0300 Subject: [PATCH v5 4/8] drm/mali: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-4-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2873; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=FuBHZIwie1er5ktaJK0YV3oa/OgU1IZweJZeXfhYARA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+TjcU1af0jhKXjV6ovGMeL570EFt5o7s8n1nn fsAtjt+HqWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk43AAKCRCLPIo+Aiko 1U8pB/422R8VMg8H+IB6Dm5C7Nrxv1ibTNuhkwFXdQ7AaJY61xdh0vXl6otVYKN+1y0dwFJmSxW 3JKx++z5bAUk51vcm6jV3j/y8CHLhWXNVds+KLFlMo5N0VBbdGeLV4eWQdIP/NUpLTMBjSQDEp5 AYF1h8DxpdRxGVF7t3yZKqSbGHFMUKtjFJ6YKX5VY1K/0HJzKm2ZYCB0SIxKAem3ztMYcW+rFay 4F5x2Xvmt6HGtMBSA5Xwb31d/kzJNYih3pg1QGhM5mmXUt+lzRF7UIAz/Yc/XGGklPUKnxBmQzL cqMryMtUBc/TY7M6wUO1QpRFGIa0wJ+v+nQ+Dxr+y9LreE10 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMSBTYWx0ZWRfX+DsEXImKQyfO AX57PXZd9iRbOouC1RAsBMKWVoe7SfmfyvsQe1v+mwenoINsR7W+dkH7Kgjj1le9MlVwT6AUeN+ lMWwptJ3PgmBtqXtlbeKoMPodOtJrW5mtXqFK0x441BCyCtbvN/jo0WGdD1oW2UOB7YD6tilUiT rwY4xfnGAtmEeKG3mkoom+XybEoPW3K2emqDF+3Htm1hSJ7pnN3P80h7kA6UTcW6BronD6uUhGo BNwlXIyi24GEnWqMyHreHYDnhmyeW+FzlKvRQnxnesGvI8gvVwkpXAQ3vszxKkvXCV0wBS8pyP7 d9DWms1uF3fnrWDhdjVh74/8B10W2vJWjRfW0NTfPV+bht0T0q4Iw2JBi06Oj0H1G0k1Mto5W72 4+eFbRfVakQ6mSDGgv+2Ay/lpPEjZLknEUH8uZgCgB5cSV4cSWSAdIoecFrXzd3ooK/IXjElgb2 jNKGQBUG9iQrI3Tdfjg== X-Proofpoint-GUID: cjvhp_S_GN-y7KDXmNP7W3hErgmPhjhq X-Proofpoint-ORIG-GUID: cjvhp_S_GN-y7KDXmNP7W3hErgmPhjhq X-Authority-Analysis: v=2.4 cv=HpJG3UTS c=1 sm=1 tr=0 ts=69f938fb cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050001 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov Reviewed-by: Liviu Dudau Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/arm/malidp_mw.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_mw.c b/drivers/gpu/drm/arm/malidp_m= w.c index fad343842038..6e0c78e998aa 100644 --- a/drivers/gpu/drm/arm/malidp_mw.c +++ b/drivers/gpu/drm/arm/malidp_mw.c @@ -84,11 +84,6 @@ malidp_mw_connector_detect(struct drm_connector *connect= or, bool force) return connector_status_connected; } =20 -static void malidp_mw_connector_destroy(struct drm_connector *connector) -{ - drm_connector_cleanup(connector); -} - static struct drm_connector_state * malidp_mw_connector_duplicate_state(struct drm_connector *connector) { @@ -114,7 +109,6 @@ static const struct drm_connector_funcs malidp_mw_conne= ctor_funcs =3D { .reset =3D malidp_mw_connector_reset, .detect =3D malidp_mw_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D malidp_mw_connector_destroy, .atomic_duplicate_state =3D malidp_mw_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; @@ -211,6 +205,7 @@ static u32 *get_writeback_formats(struct malidp_drm *ma= lidp, int *n_formats) int malidp_mw_connector_init(struct drm_device *drm) { struct malidp_drm *malidp =3D drm_to_malidp(drm); + struct drm_encoder *encoder; u32 *formats; int ret, n_formats; =20 @@ -224,11 +219,19 @@ int malidp_mw_connector_init(struct drm_device *drm) if (!formats) return -ENOMEM; =20 - ret =3D drm_writeback_connector_init(drm, &malidp->mw_connector, - &malidp_mw_connector_funcs, - &malidp_mw_encoder_helper_funcs, - formats, n_formats, - 1 << drm_crtc_index(&malidp->crtc)); + encoder =3D drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_VIRTUAL, + NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &malidp_mw_encoder_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&malidp->crtc); + + ret =3D drmm_writeback_connector_init(drm, &malidp->mw_connector, + &malidp_mw_connector_funcs, + encoder, + formats, n_formats); kfree(formats); if (ret) return ret; --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6536D22A4E1 for ; Tue, 5 May 2026 00:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940740; cv=none; b=ToYYR9GKef6Sgi1RLxmsn6pZ5TMD4ZPes13AHGIo238z+AXQfEWd4BpwGhuZrpTyRPGQ0qBS+CYI+TYp09/AyxTrxz87NDgBhNUncQxb8mcZeBx8+MDMW7ZDDAKt6rumfslKZpx/vw8lag1ZLhFkFApXQkLU7evPY9jA43yGUk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940740; c=relaxed/simple; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JKqXmH796ap5aMZXXMmYXeGfcWewow7uz8+9lleiVZzvSWIND7r2L7yejS+PKrGzvYeF03a3To+yvoboD/8kWFK5yJL8FMiWpTHrRRwGp5dZ5RuawqLRvjHz4y+KPGfPOWQ2PVTRMNcpnYch0+QL5uXFerjdspdhInSfc7LrvYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Csm5N2rF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=huU4+BGq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Csm5N2rF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="huU4+BGq" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644Lk0tC1960499 for ; Tue, 5 May 2026 00:25:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=Csm5N2rF2fRYIJOK b4r0Jj8d7YHdLch1vLDOsvt3jArD3z1S7R0u5KKFNK9Ny+pA56wNZL3wBuuTte4i WWDtzdH+xFsFmeXQI2IEO0vq0UmlmRN7tcnCq2f0xQ0HwqZfWJepRztKZLXK5ZP+ 1f6WnTShDociysdhStNfbv2vDV2LgQAiQAdCt1PVsjW4M79C/KWjfL8I+a8J8Qn3 uApVDlEtQ85XvIaeC9e3+RIVUzjy4S8qsdceUgbrQpgrSilaj6HUUBmv+xqAPwRQ OY7GGI0CKpC0ICYnqRIWTHn4jUt08IE8ALGTVF9kKF2LcYRofgeYRSI/qkIuCL9v h+Ikkg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxw5dt161-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:37 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d6bf346adso79692481cf.1 for ; Mon, 04 May 2026 17:25:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940736; x=1778545536; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=huU4+BGqRNgmYRTxql/J1og+JlEqBnYz32nyDjfsp/RD3+MLNODxFNy653/hRafqyZ qdlv2HXRHrGDa4Y83vzja9rEg6nTFuob593R5FnKUf4sw0xnRrh0VUnlAmmLZ1SeOuQ/ z8WW43ZweVkW6Eo+MrIdDqow+0G1mVMnu4tf9Ecws2Inq37JlB0lZSwuSgB6GReLsjQh JtEsJrp7LxZK725kzjQOojTy8vrecRYAAMhHRRG8XsFkoEjp6ZhO9enXPY4F9MJd3EG2 aY10VLG02/3BV7KQDZe3gTB/BB5a8S7hbVUodFKb9rm4EFdAPKNus/VKPL2Bea6djkoZ Fgpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940736; x=1778545536; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sTMi+rpeIeeTxwgAvd6Vb3BN+nfcxX4j3a3avZMj7+E=; b=EPbVceknKmUSjqJqYqRFJD6GAe5SOp6W9YkQ9ZaIzubCfCbgKh2q4QZ4s9EbOeoEkB 7FTcmpUhvSiiCAjIDyxJP4EkpVvXOTZr5ElablprKn/zFZLuYrHyVrSQgioxgKM3mTtt l14v3S0gOqd0hHWQ8IkMzzs/1Be4JIxZlEZybhyveyZpcip98Bf6A71tq0FoQvetrGte qWwoLEmgxztn2W1no9IP5NqpUKGGas1ZrNMddjdJf1RC0BjRITuL0RX5ongB2sWBcq3R UmQfqzn/4oZUPGMUw/gzQd3aFuWSt38qT25AkisTyhX53EJK/mdHDeFvdxAyLnNs/lJX 6+0A== X-Forwarded-Encrypted: i=1; AFNElJ/s69XOjgsfx4onnc7GmSUYKlCVywAwAUYyBpEURFIbsbWrHVYMTedUy0JZywvHAiYBBOgPMu+kc4hgMPk=@vger.kernel.org X-Gm-Message-State: AOJu0YwNdnHxbstAK24dfTVlpM3Du7GQ6Vms0h672EDFCAbQCdwzIEzm iFxuDRVDK9ceEItkBWO1u+iqTwsZB9K3+XN4l0RGWSWnrUwtPHOXisyhJU5DVUiAfGh41lHNx6L iFwlx7fT3/U9gh0JLmVk3ScLK6b1u6RGhCeuBby76tp4913j6cxEUyBOEVQ0GMd2aMyg= X-Gm-Gg: AeBDievht8UWh9/T9vX3achgOQSBsUUcsZU/EFJGlcYEIOhmXRhHjywSaoeUhBKoLMj fH3bTm0j9wcCPxF7R8nnJFxUaTIFPZVBZuvHZnz264r+bJlp/iMwL+SDxEg/eF5UW4wXFpZ3geP M2RzWx16TJwiaSGpT/mfcZXt4MF58IMbNTRkADFZVrtCDsYlnbeUZREi3JOLq/aEYGCUylGWcPF /p6VOT7S8if8rUd0iz+QgKWa3zlDIAMolu+NCdaJl4NCl6CE4FLSEKhcYxXbL+maUtZsUtfEsSd s3qlig85L5fJBN5qP3BMoFMut7XlhSYcTh+PHtO5SSYA3UdY2nRj48krUFv77zAom1brJCmnRSH DRJRTnhLvvIwvtCDWHsfjQ8mZpDYKASPzEeNuI+qTN7TKQqI9gtTMmCZYASIDpIr1LqLkhfo9Mx 07LksDHI3By7mNEVuH8w8DByaJjCY+vqgCiy2ME3d6FQZaFA== X-Received: by 2002:a05:622a:4d49:b0:50e:a1ab:114c with SMTP id d75a77b69052e-5104bef1a95mr179779401cf.32.1777940736563; Mon, 04 May 2026 17:25:36 -0700 (PDT) X-Received: by 2002:a05:622a:4d49:b0:50e:a1ab:114c with SMTP id d75a77b69052e-5104bef1a95mr179778871cf.32.1777940736112; Mon, 04 May 2026 17:25:36 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:32 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:02 +0300 Subject: [PATCH v5 5/8] drm: renesas: rcar-du: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-5-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2589; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=4Vucpdbps+yQVez32oDVtzt/iw6YyMI2r6E/Wi913Hw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+TjcsYWHgFL7YdrLbWVw7Uldjtnf9eJreeqel uySv3eVNaGJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk43AAKCRCLPIo+Aiko 1eTACACX9CkVnJY51k1n4kpTPLzSZQIBw8n72ppEnAr7Nx03zRbl3kWkZ2SLmNSxZmBWptrTJkk 2V34Y+p2v9crcEfzAHIMNeS8VirAvNf7W8vbsCnwcpwVM/tgWGvJ+2h5OUEU+aQf051uVIH3RwU Qo0u5M/OmEdDCf6HlPLdzCiX5rVxYfDY2itb9vjZyedZxwEPVVgSi9vdLWIYfQqCDrd6IMT4rwx +RoeL8xzHgeqYVMa4DoG+g09ieOLTEZS1A5GIPMSdTmPCbTOWLbecZb6QcJEtEM9EABMaVfMeRL 2xM6UMzh2Flot0Vun+McCHFK3C3Ydm1IoDmqYPZWr6V08vSn X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMiBTYWx0ZWRfX+F423iDawxTK GTGHacwN2UFc4lDZ7x018HjElzV4ZnLHNlf4fCew/KvgtqfK6feRKJr/oFdfY/9iq/aJ7NqMbeJ 8KBVsQmh034Wf6Sf6aABmmYqF2P8MsRsDk0pgC3IfnYpj5rhtduVakrSw36afUDN/g7lWxeJmc6 voNkm4zxWPcrnYBfIyXKe/aOfXo8FXC8WphJm1hiqpmxaQvX46P43P2CjUMHwIayMcSITDt6R0x Hxp3LH5WXJTecMXSJVF/gXSz2HfUNgEml8k1rRyo9nhhXtGWwz3y13ayeWY23Zwn2PaPq3LnCSh jLgRAyUNBZQ6xO+iXhW+mt3pAfQFIKNY+AC09IipuTZunTzbdP+5DutuMy+Jt9rprXkb/9ndnmp dqHiwSyNQqu54KNjyZqx652o3P88g6iK+eN/Ye1jwSdpKEZuIdcNpu3OoSax2GI15E2oKQlDnQm 731rT/0CpU/Ct80mmWg== X-Proofpoint-GUID: DYvS-R56wMArscaEnxfPeyGDMxPiQKGp X-Proofpoint-ORIG-GUID: DYvS-R56wMArscaEnxfPeyGDMxPiQKGp X-Authority-Analysis: v=2.4 cv=HpJG3UTS c=1 sm=1 tr=0 ts=69f93901 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=rEXDA0v2x0ZtafRnR6sA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 clxscore=1015 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050002 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov Tested-by: Rodrigo Siqueira --- .../gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 22 +++++++++++++++---= ---- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index e5e6e6a156aa..ecfd4fc1f210 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -134,7 +134,6 @@ static void rcar_du_wb_conn_reset(struct drm_connector = *connector) static const struct drm_connector_funcs rcar_du_wb_conn_funcs =3D { .reset =3D rcar_du_wb_conn_reset, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .atomic_duplicate_state =3D rcar_du_wb_conn_duplicate_state, .atomic_destroy_state =3D rcar_du_wb_conn_destroy_state, }; @@ -201,16 +200,25 @@ int rcar_du_writeback_init(struct rcar_du_device *rcd= u, struct rcar_du_crtc *rcrtc) { struct drm_writeback_connector *wb_conn =3D &rcrtc->writeback; + struct drm_encoder *encoder; + + encoder =3D drmm_plain_encoder_alloc(&rcdu->ddev, NULL, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (IS_ERR(encoder)) + return PTR_ERR(encoder); + + drm_encoder_helper_add(encoder, &rcar_du_wb_enc_helper_funcs); + + encoder->possible_crtcs =3D drm_crtc_mask(&rcrtc->crtc); =20 drm_connector_helper_add(&wb_conn->base, &rcar_du_wb_conn_helper_funcs); =20 - return drm_writeback_connector_init(&rcdu->ddev, wb_conn, - &rcar_du_wb_conn_funcs, - &rcar_du_wb_enc_helper_funcs, - writeback_formats, - ARRAY_SIZE(writeback_formats), - 1 << drm_crtc_index(&rcrtc->crtc)); + return drmm_writeback_connector_init(&rcdu->ddev, wb_conn, + &rcar_du_wb_conn_funcs, + encoder, + writeback_formats, + ARRAY_SIZE(writeback_formats)); } =20 void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5492773D3 for ; Tue, 5 May 2026 00:25:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940745; cv=none; b=upJ11kvi9uGcPcjZ5ngXwBRfHedZ3nJgMkdwpBk603J9cj0sRJNOZkvLF/DpdnbslrxtL2/kyFYwWokS9FaZdwR7qYREFXq5tYUU/4ZAoT4OfQCXpltAHon3ywMSPDhvgYJz3G/eYV4g4rpuZzUbXLanTVfqLWKK1UecGEZ2IFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940745; c=relaxed/simple; bh=behk6Tmd7pmo6mRIbuSh89UzpPSTMpSIp59mKcXVLLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k9ZML0k4l4y/DJyGyurF/lWzVtnKHKwIDmRVES0ijzMLf33qMoSeal3Li2gFG6PQWGX5oQWTJAdvqVjA3VqxHXFK2n927H7yBmZ4z0dchjas8SH6PnlDtf3Wtx70XZtUyKM2d9o289dyox6eA98WPUWOAB9Iuix49rMNWroCDOU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E+r1w5Fc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fH8WhMTz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E+r1w5Fc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fH8WhMTz" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644Kole83468117 for ; Tue, 5 May 2026 00:25:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IGPbsFRj9AcR1JhiLP6QveYjBGQn12/jz6nJ82TmXuY=; b=E+r1w5Fc2T0hs60s cNktpi4aZrq20ghx+ylb7uEN8/txOPRbTfbZeykzOQepXSe1dnnn71jCxqXKncyM bGyni6FW2vBRohz4rgQw4qIJOFm3F4KuyZ3KggFuWWefz6xIpTuqJcc3fZUpDLYf NJCQEXtW84cw1b3BwbseCxyIz8iU/DG0+oNjflW8+TFFZ0Cn8aesJvXR8nARQYHW Lo1YhQH3OllZipvbbz6vdQWGxt6KUtLmNDJS2A1rLpP1gYU4hdF4rZdLUsa3dvQj b8opRDVa5Uc6RP4Ftv3sEdktaPp8GTnywYb6qBl/8CnzJ17YaGA9bd9b2wu6wbHS YV3ZzA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvtjt4nm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:44 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50f13da9684so58873821cf.3 for ; Mon, 04 May 2026 17:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940742; x=1778545542; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=IGPbsFRj9AcR1JhiLP6QveYjBGQn12/jz6nJ82TmXuY=; b=fH8WhMTz3Hz1ILjDHEUPzttu2C5OYmCN86JSlT53Nie1iem23je9n28fUvw/JXVKcL 3s9QqDytHGYbbDuYCtdJTo7RN0cpr095f3hxzJLb+gMRi64/dV3APQTe00W0IoImQw8S letpXp3+1KPqEfbyKF8eobYF+lzjTItsnWeN/ychqq7JJ8M5goqssSligCArA/+Dj8Vz IomLBjJqEudVeLw2SNHh5Xz5Odgy2Vuhm0pu3fx20+CkygbpDno7IEiE0z09DRrNmstA TupkCL78GRBzxUKSZlHdf4Je4GZ+j5It5miCwgpXgClGCx2Qpb4LeV8yhzOYj3cZAXcD OKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940742; x=1778545542; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=IGPbsFRj9AcR1JhiLP6QveYjBGQn12/jz6nJ82TmXuY=; b=HyfT4gCW0MhAL5G2xruxqH8BEEmcWqCZXlXVaM7Uw+euKVG+zFJFcTVrOtVMLkD2h+ 5yFXiha+RqbxnBEw80uqjs8KFakEmLsd8lvXhdNMwrwQnGUy25g0cJteuAL4coMN0N+8 058rBX7gD9fVO5lVSfxA+loQumOR5/DbjvLwbdtJK/iI5I1yj5AGKfYI0gAQ5oujhEqA 1NKRMhcDfEPck3biTYi3ZEFvegCY5zEVgx/Mabueg9HrTlvMN+neZctQy95KFB/8IZXH kfKGCq7azDYmPzGnwCtlaK2guYq7MKzG5M4xD5d97x7rdHyL826oSb3V7figHBsF89vs n1ZQ== X-Forwarded-Encrypted: i=1; AFNElJ9A9TS1IwVURiCM9f8rTNNUH+UbA4IPebGekfpa95kximD7b9CZYwxuVNqZpkUm2pS9IOXzLUGhFpnrU40=@vger.kernel.org X-Gm-Message-State: AOJu0YzSJUG0jUA4TGYXLXAvoGAdcMB/6xmViSJ6MFP+sHf4pu/iqEx1 qKKllTwPaf5UanRhbEt5f0xraFf67KXsaHtl04X7yMLM2C3s2vRn/dlez5LWDPPQvDlgmw9EMFE vWUP/EQTgJ4wWPW3eN2BDGek8s7MGpUA2DILXRIg3n1jtdVR12OpDVwJgTHeKXvk+33Q= X-Gm-Gg: AeBDietRGeT+kryBWKdR+F2xGtSFCOz7HcYblMuWJTvncz4oeDJ8A4HiS8rczeAfjBo cAmGYPAbHuUyipykZXRMEp5PU0DuC+bVe7HomDoPCO2AcCmj/F7A3qWvmy5bYAuXz24XblZ8oCn K6g1UcxkbEGSsxNvSwBXW9zde/rJPgHT4XZ1SX904hqpedP3yydpNLHdquL/anvQbGPn6kd1V82 zVZgFs1lbUGBVV1UK2t4wOc18CkNVEtc7WPWpIjH+Jiz5PxeKh3/1BBmALRvNnUjJ3u0le+lvel 4NWcQ5KmR2S2sxNODS3POAMIODbHTr78a0ywHKQs1jfG42RjgaNvBGOXXdNMnvSeD4InOuy306l 4gqZyWLhTAqQ4/P9IW/WTCiWXmfUbE+OjRLuslWUmE1zBWxlYz453TexmHaJJiD83swt4n6Q8i0 WcR2e6xNEcEIeq5ioC5f4yzF0JxkSoBYc6ihMaDZouyrBAPA== X-Received: by 2002:a05:622a:4cc7:b0:50d:a56f:6085 with SMTP id d75a77b69052e-5104c000210mr174309711cf.43.1777940742368; Mon, 04 May 2026 17:25:42 -0700 (PDT) X-Received: by 2002:a05:622a:4cc7:b0:50d:a56f:6085 with SMTP id d75a77b69052e-5104c000210mr174309381cf.43.1777940741886; Mon, 04 May 2026 17:25:41 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:38 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:03 +0300 Subject: [PATCH v5 6/8] drm/vc4: use drmm_writeback_connector_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-6-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1991; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=behk6Tmd7pmo6mRIbuSh89UzpPSTMpSIp59mKcXVLLY=; b=owGbwMvMwMXYbdNlx6SpcZXxtFoSQ+ZPiztPJkmE97W+e+LKVL3eX/tHS8K9KXwCspM/Py2PD 3xwcff0TkZjFgZGLgZZMUUWn4KWqTGbksM+7JhaDzOIlQlkCgMXpwBMREOH/Teb8FaWgNg3Tkw7 RfgfGi1h272T4ff3+AoF322LXy7SEe7+Xr3paDRbyT32HIuj93W+Fp7ye6qwbFevRHjRkwM1mx+ sTY7iuXvpo0TSPdUpv+bUhn4WEVprKuEZoc6YUrCCKc6mn+G82yr39Yb7ipJeNSr8tD6xyVVxgl 7V1w3e6amXpe+84V162jB+8wvHSy17lHl4Lmz28ZUxt5uV5ykYfXadk+E9LWctrYoDX86+zY6Sr fm3/0SVX3wYs6+HgErvpvrcQK0t91QDn3Vc8z73XU3Hr2VXo2T7BR31zBvtOotmMct1OF233Npz besv8adfMtoT1KboFsTGZFpLl1p8Px+x/On9KGe/r+0vAA== X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: 1CO6pE7MI79cqrY5fhVEKLgHk0eLtDkR X-Authority-Analysis: v=2.4 cv=KuN9H2WN c=1 sm=1 tr=0 ts=69f93908 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=P-IC7800AAAA:8 a=QyXUC8HyAAAA:8 a=EUspDBNiAAAA:8 a=YDDQE0DzCl7hcZedIR8A:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMiBTYWx0ZWRfX58UNBgqGQYxc xTkuwPtu13CwGBnVUPiSSFURBvsvu/KweypyRcunxsB7sE4/VPqYgo2Gd6nfxV2GgVBfcB9jlqS Aigj15G3MkC8TrNDRohm+sR8HIVzeRfZ8cNqD51teqDaNjQTB1d72O//WOGz5Pd8p2W9G1oDHHl Cx11gBXzGYq/T/tocsM132ugxlKsJpFrbAGeElDhF6q2nHgK2qUq4GL+1OMKSRyFIn44GJxqNwk F44WMnKtOButoNtktQhBdpiguID+npYQCRUe0XBZw5q+w2hFd4Ak2KGaWPmmWBi17wdqZB3N8hP RBe/e4s87ZPq8GCAZ275wBJ7fPnvNTbph0VSakY3sKU4SFRjoMWMSECmkgLdkJVk6WYH8Nea0mc Y10l2wCjHrMohqfHQy3P5hF5uvN2A5ccAhcYIYAwIFohcwSh3ffsDqkkPuxq1Wa+yfPrHGtkebS 37AnKfi571tq2Cf3AYg== X-Proofpoint-ORIG-GUID: 1CO6pE7MI79cqrY5fhVEKLgHk0eLtDkR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050002 The driver uses drm_writeback_connector_init() instead of its drmm counterpart, but it doesn't perform the job queue cleanup (neither manually nor by calling drm_writeback_connector_cleanup()). On the contrary, the drmm_writeback_connector_init() function ensures the proper cleanup of the job queue. Use drmm_plain_encoder_alloc() to allocate simple encoder and drmm_writeback_connector_init() in order to initialize writeback connector instance. Reviewed-by: Louis Chauvet Reviewed-by: Suraj Kandpal Signed-off-by: Dmitry Baryshkov Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/vc4/vc4_txp.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index 9082902100e4..befdb094c173 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -378,7 +378,6 @@ vc4_txp_connector_detect(struct drm_connector *connecto= r, bool force) static const struct drm_connector_funcs vc4_txp_connector_funcs =3D { .detect =3D vc4_txp_connector_detect, .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -602,10 +601,10 @@ static int vc4_txp_bind(struct device *dev, struct de= vice *master, void *data) =20 drm_connector_helper_add(&txp->connector.base, &vc4_txp_connector_helper_funcs); - ret =3D drm_writeback_connector_init_with_encoder(drm, &txp->connector, - encoder, - &vc4_txp_connector_funcs, - drm_fmts, ARRAY_SIZE(drm_fmts)); + ret =3D drmm_writeback_connector_init(drm, &txp->connector, + &vc4_txp_connector_funcs, + encoder, + drm_fmts, ARRAY_SIZE(drm_fmts)); if (ret) return ret; =20 --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADA8928002B for ; Tue, 5 May 2026 00:25:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940752; cv=none; b=fHjXbqtme7BtV3d3rI1MQddjJ9BveweuAPFgb5qhMYtfw9lSgq179dj2STZsGWXGLy0W16sbaLpnCDOwFjL/u9xlKIcbsRAPX+dXww7GVuRF2gMtqf3A3zgasbWZpuLtj9SfgP10dfC23+w+2OLRIPCtZKMp46qFNutW0jYONYQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940752; c=relaxed/simple; bh=6KkNpyC526rgMVIeY0D11Z3gyU75WDlgdpp2dL9pdq0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ChM6g2NCIwWkXYt6EhaxPrqXtnF8GCv2ATp6nl5H5vgvS+ERjGvqXk/EWj4dNJsjVQYwjxpRBxYl4sxTX6Ke0WxJ7cl5V6ayJ4EHc0aCAWw5c5cLH2+QbW7He8ckh0q/wPDSozoTbs2SuSVaODalZPvbOOuAXY9xJ2/F71fhw6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hUtVquDF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OGZ+QNI4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hUtVquDF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OGZ+QNI4" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644JVMXn3467744 for ; Tue, 5 May 2026 00:25:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=hUtVquDFHwQK/Amy CK2IO4oqJskCVkQCdGS6GgZvVjCj7bIi6gjp2E0fxdx2PemFTnNgmEylzjFpOEaI DxKCFgm/hWvTwtTwitPF0BYdxNVpmOh+c4BDR7PCBeMl8ESSHuvkfcM/MMTY+Rm6 5rpvt7dYkSbDSFs7QLYUUS+GVLp93bUvaKETydmTFjmalxOYXJDEWZuaZsEGtRbB vuPA41+2NZp67/I7G7qID8MK5RGtt+wL22rBu1pay7UP4kjipoN07teT2WPp/Mmq uVuOdUvSs5MhkghRyGNCu8UiYQtlrNzIzItojWjjTswYcVSYb2wg9Cxx+40j3NwX CnPZxA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvtjt4p5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:50 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51306c1076dso9784461cf.3 for ; Mon, 04 May 2026 17:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940749; x=1778545549; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=OGZ+QNI4miq51Od2GInJJfly0/WbtTj5m+xZ8c77c8O5R13QyHONYvpZIzEdfGjgG+ XbT8xi3bqflw3Hxgok7r74uTGrnn+Of9s6OafVro6wVdLSHB9Rz8zkcpD1I59pJT78Ms uNyM610T/rYxLcfLd2eK0zj5F9oCW5pvE95ndjjcMG51XKhwl3WuHnAsT5E9ZGzE05Bi 3MdSgsnO1JlCR+gmGj/RXPFLwwsFjO9btpuERWcMib1ZNoYlO9oDypdC9Tmrs8A2nzqT gS9iVoKxA7yTwJYwN12F5iWXI/smJqhK8gLFiSJfFOiF0Zc5C0N7Te32joKXXBrVrvTv bcvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940749; x=1778545549; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EaIMgG/IEi5Ad5NwXbrOlQk4Ovs4qDGmtqlsgR815SE=; b=ZAs8JxOiSL0Cu5nmMxNTo8+TMphRVT/8ctbIghdfv3GnlBNP0VbTDpPMCElFllgm1M JvZ/32PEq7SCCBMqZMLOT2s84yJJAxKRnXod53lKYMIMpwvtdvFJt/FVBY+7ya6yf32g 5NuOPnSN4g4dnWCGlRoHkwUAoXurEKSS/NbmbI0PU2ybpxQmt5lTAE4QlmjhHpu3ECzj 5AadIi8hP9sI6LN2pwwoupPqHqsBZMfTPAG/2JatLXbiUIvImhOb+sSSKbX8QVw5a8P+ SeqFvgc3zYE3C1EU0rn0KmXjmVEvCZD8mcYutps7BJSt4H23OQnnhhI7xBQYue+YDrvg uUZw== X-Forwarded-Encrypted: i=1; AFNElJ9QI1O+twB8rBSCEJ95Xcclb/xgR97NIBJUMlAIfPe5EmDXVOOyLWIiLAgy2HVXcuJ6ZWvzRcb/DZDteOM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2gigUPNUm6emieIyaVA9OzKoavL3+CCAsae6Mz6IkQViEYF2w 9Jgf5LSqBEeJuHQ8tuASt3PRY96i/hJWhQQZ/u+5jI9CjGJ1LcbAl6l73lDAocxceLHNri/vkVx mKz6B0Mt7y4al/kcS1hCiSduc5raTPfCJEZC3xa9JnPWd/boPOW1QNgkOzu+/jcJl5sM= X-Gm-Gg: AeBDietKm8ldz3NMOZnlXeqcEo4k012IOuu7xZNpr+kE+XsR5SFZfgvMWkfTF64eOp6 73D6WIS6sya+cXmVOMFuoyPGaSZlIPeCn2XAQlHuoXF+7B4ga3wqI5mCu79o7LsXDWJMl4s7Z8t 8iqvjpxox0tr7nMsfK4Szv7ISp3/dZZYsZ7nAl52f6EvFTqY+WG/xV3kC/OveoqT3KtpRRefRo2 0HqfZ84V7dHTGoWQZu8/+7APQUSp4hbpKgdD7qeXbrsjsuIk6XT9eEsMcX5fhn2oIJuNmE7u+zo qjbnVN8v2eQukI94Sqh9JIUD2F1AzjduAUOFHYOF9NQVVjXnMro2qV1Axm0qDlSMXevNUqS8d3a I0IwE044KNhlqXR78/M2gUGsB6+MAQMDa+pnIFXT01WvXFWRJ1tDYuRNqtSB8qL0EoZ9w/Jvkml zv3frkIM5e/h7Vj0VBrtjrv7xmsBNDZagCIUw2pmfuh7Tpnw== X-Received: by 2002:a05:622a:580e:b0:50f:bdc1:3bbc with SMTP id d75a77b69052e-51306aac200mr14477041cf.45.1777940749082; Mon, 04 May 2026 17:25:49 -0700 (PDT) X-Received: by 2002:a05:622a:580e:b0:50f:bdc1:3bbc with SMTP id d75a77b69052e-51306aac200mr14476621cf.45.1777940748538; Mon, 04 May 2026 17:25:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:44 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:04 +0300 Subject: [PATCH v5 7/8] drm: writeback: drop excess connector initialization functions Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-7-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=4480; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=6KkNpyC526rgMVIeY0D11Z3gyU75WDlgdpp2dL9pdq0=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+Tjc4aI/E+fCVPzwdLRrDiVtx8WNLqsyYQ22J GQc9Z242b+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk43AAKCRCLPIo+Aiko 1W/DB/9RLlO/8FopwXYP5adamkOmud+2XRg16jh0MbN04hulZan4teex+3SutuTANIXHCaYmgGH g8jvk0RIuVH6PUAgayKAv9kdGe7ksmExonWNj3I4LW1MVlPG8y358RgdJmuyT4hwhh6f5G9G7du xdEI+0m79kNZ2dwnD6COJWW37eKr+/UYc66bDqq5Q6yT80/qyMnovBEaq1WKuUd7d1YOqRGZMJ3 KBUXBWSbAwCYH2NglyobPQSIpZVi/3YlXZCHl1W31w9d0ncnavvwJiJGIRrxe8gVduiKcjyh7bY +FsLb4cp5zG7JIfyUghx1RSeAeNmI1X5D309HpKtjERxyYnE X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: vPgCLybKaEgiXMwzOO7YM3-SFaVEZ9Nb X-Authority-Analysis: v=2.4 cv=KuN9H2WN c=1 sm=1 tr=0 ts=69f9390e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=3owybDqXPaZAjLikVYcA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMiBTYWx0ZWRfX4+iH+ldM1HoG T7DG89MNJfBQpw6ZOTAOwDaR8i68ib6PGytonSiAEdZDV2wt+uTrPW9h45eBuB306DUneRL86oQ 8UR3C84++UGXhFXdDc1CJmnuJbxmfdwsKJwmaqvoOqWP4evMPW8f8UtNTHOl3uciMdxzdv8OpD0 zOLmOJfCFoo9Rc5OpwPW/glI3JrPWRkM37CslzkaV4xHYPfr5f3Z7Hiud7hujv2V7zQ8AWvETSA l474N9UTC7RdOp+Ab9ujQrWGIFtlyLdwuZzKWhWjeTbTfFnPluqyMYNtpYj0Yp0QYt7x/jvRqpY lULtcp5UUCXv5bYYY1/uYP/vw4LLdFutFOO7QErC9nd4VeNTJdPMbistmkCzbLhjZHB1Cj3lruA b/oPSt8ntknij3ZAGG+v+7+zeeUsoV1qLpHiNU+sSZ49XReuVBYblSNeeyZKpRVMGB40KQMd5hn a4/Osm63RWRxB5ULUTg== X-Proofpoint-ORIG-GUID: vPgCLybKaEgiXMwzOO7YM3-SFaVEZ9Nb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050002 Now as all drivers have been converted to drmm_writeback_connector_init(), drop drm_writeback_connector_init() and drm_writeback_connector::encoder field, they are unused now. Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/drm_writeback.c | 55 -------------------------------------= ---- include/drm/drm_writeback.h | 18 -------------- 2 files changed, 73 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 4da5d6094721..9fc15168c34f 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -142,61 +142,6 @@ static int create_writeback_properties(struct drm_devi= ce *dev) return 0; } =20 -static const struct drm_encoder_funcs drm_writeback_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; - -/** - * drm_writeback_connector_init - Initialize a writeback connector and its= properties - * @dev: DRM device - * @wb_connector: Writeback connector to initialize - * @con_funcs: Connector funcs vtable - * @enc_helper_funcs: Encoder helper funcs vtable to be used by the intern= al encoder - * @formats: Array of supported pixel formats for the writeback engine - * @n_formats: Length of the formats array - * @possible_crtcs: possible crtcs for the internal writeback encoder - * - * This function creates the writeback-connector-specific properties if th= ey - * have not been already created, initializes the connector as - * type DRM_MODE_CONNECTOR_WRITEBACK, and correctly initializes the proper= ty - * values. It will also create an internal encoder associated with the - * drm_writeback_connector and set it to use the @enc_helper_funcs vtable = for - * the encoder helper. - * - * Drivers should always use this function instead of drm_connector_init()= to - * set up writeback connectors. - * - * Returns: 0 on success, or a negative error code - */ -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs) -{ - int ret =3D 0; - - drm_encoder_helper_add(&wb_connector->encoder, enc_helper_funcs); - - wb_connector->encoder.possible_crtcs =3D possible_crtcs; - - ret =3D drm_encoder_init(dev, &wb_connector->encoder, - &drm_writeback_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) - return ret; - - ret =3D drm_writeback_connector_init_with_encoder(dev, wb_connector, &wb_= connector->encoder, - con_funcs, formats, n_formats); - - if (ret) - drm_encoder_cleanup(&wb_connector->encoder); - - return ret; -} -EXPORT_SYMBOL(drm_writeback_connector_init); - static void delete_writeback_properties(struct drm_device *dev) { if (dev->mode_config.writeback_pixel_formats_property) { diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index c380a7b8f55a..879ca103320c 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -24,17 +24,6 @@ struct drm_writeback_connector { */ struct drm_connector base; =20 - /** - * @encoder: Internal encoder used by the connector to fulfill - * the DRM framework requirements. The users of the - * @drm_writeback_connector control the behaviour of the @encoder - * by passing the @enc_funcs parameter to drm_writeback_connector_init() - * function. - * For users of drm_writeback_connector_init_with_encoder(), this field - * is not valid as the encoder is managed within their drivers. - */ - struct drm_encoder encoder; - /** * @pixel_formats_blob_ptr: * @@ -148,13 +137,6 @@ drm_connector_to_writeback(struct drm_connector *conne= ctor) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - const struct drm_connector_funcs *con_funcs, - const struct drm_encoder_helper_funcs *enc_helper_funcs, - const u32 *formats, int n_formats, - u32 possible_crtcs); - int drm_writeback_connector_init_with_encoder(struct drm_device *dev, struct drm_writeback_connector *wb_connector, struct drm_encoder *enc, --=20 2.47.3 From nobody Sun Jun 14 01:35:13 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6F6275B15 for ; Tue, 5 May 2026 00:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940757; cv=none; b=RXrVmTnyKFwEzsUZHLP65aKjc5P1HAbe0RDeUUFBGl9Ypkq41gf86xxUnAyOLllnfo9hSaJKmiAhkqOKZxQKvS1tYN654xJ7Y8CwHic2HGtBGqfzWHdZi0vqoEV+7cYUDKR3Vkwd1Er3zP2Q7yANJHXCwgLwSGD5VBXe4ifgG28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777940757; c=relaxed/simple; bh=mE50BYUB/UAw+zq2VOqPPalyAMn1gAB1RtsYcBWwgx8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Uc7KFC4owDGejH3MBeZc0x9Zgj1uSqDie8XQ+FlB3HL4ObY5vLn2gbxZpwNSzc/jFNVU7l54ZqI4PYB5BA6HfuwSkmiN6VGxQc5rf3FVeu4jLcWGSURdt5Bfo3NOSMuJn/pjvrEi0l8JBpzvpFFJw7wQkgVGuBi0xvFPYsljpH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K/BMwJAm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DaobUNtt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K/BMwJAm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DaobUNtt" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 644JdtHm300008 for ; Tue, 5 May 2026 00:25:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y4rDxNdRWU+aebNlPWMdizg27R+flJppZJLNZrroSxs=; b=K/BMwJAm1EgVSC0H /UWzYKdQV25HgaWN1Q4EQV+EWf1k0+1xWKtDFu0zA4XvWIKudYzQPzuUMyMNQGAT B28V8AP0+tBOW+9QVWOsipLRjRxm3a3OOHIYdWUsjM7RrEN6icFVmBZlqz9bnUee SGuyVjqaJVXiVgWvpGkZjMOFORmoZCcOZGiulvf7/ucCdUjyDfC/SpaSFv0gl+Vw 0lAH0nDaa2wXgyieqauqp379JNwrKjNkkXtDwWZQ/Fi3W10gc6+OLGx3+qDuWywT yuvZD8xlcTTl6hhjUq5xojyHScJ96s054cF4AlSBHDlJOk0wlG0itxB5Xyq05dcv e32h3g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dxvnda6w0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 05 May 2026 00:25:55 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-5102a9671c8so112465891cf.1 for ; Mon, 04 May 2026 17:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777940754; x=1778545554; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=y4rDxNdRWU+aebNlPWMdizg27R+flJppZJLNZrroSxs=; b=DaobUNtt/u7aFeYm88NQRn0hPxGhLKLYw3Wog1CqKHuQG+Twkdy1Z1Y+Cl9oHp2MsD vpyDvBM1QnVI3m+tc4r6nVOg95V1hjqXSjp98LGUskSPpsYDDsevvTJgN0MTpDSaOxLw YfGbu+XnOIQ6UaZygVnA20bO+rZqqYaI1mRAtbl39+P9X3LH3aHAVOAModzszHM/bMe/ gpQ78aja04rK1AfZgSiR4laSSIRj/2XGOH5/PkKitVOT3CM9cyxkZmiFxN/cQlKyZAM0 6SZvxrjm7iPJ/NrhkqrcoyK+XHnK3LJ6zQc+ZtI60rjKepj8t15BYoMwecT6kvxbRzNp IkzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777940754; x=1778545554; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=y4rDxNdRWU+aebNlPWMdizg27R+flJppZJLNZrroSxs=; b=TCOyF4nSNsCdBCJAAZ/p8Dyup6ZOWuQLQiFB8dXHzqZet1zdwTtK6fPodig5bF5sri ThQsFUWjVQHNoy69YVSvNQ1Qj0rYKLL8D4GSNlRRw4k/QeAhnE6EO6txsbBpC+wy6j1D Ao/nz36UmVCfsUj5gPsTdEfzNIJs4l1xrANwbMgzSDi16HRXjv1Or064MOhs4PBbnn16 n13rAr/EWWhWL72OyYx9CkDwaA+slOYQFPA6K8rSdc2nNShQvOlDGah0Bswx7EKGmpJv pAP3FPbS97CsHmoh7luP7MgTJRVnUnUFbOu89yDL8mfbOtxBNTcI3KBRPZlZ0ums0g3D 6+zQ== X-Forwarded-Encrypted: i=1; AFNElJ+IIPkDJowRvfhmeIz96bThGvbwVYf1GSY64L0dVULrjAAYauWL1WoQoCX1biLif6EKrYeqNcOcQ2o5KMM=@vger.kernel.org X-Gm-Message-State: AOJu0YyBwgjF4Q/nJrBR97WiZAN0eySsTWAeDR9t5wuDSYxDcy6FoPgi vEBj3ammfOBtrsTwfOdxjx+Cqv0qatX8JhOyB46oKWicxBxvtk1M5O/VZ3q1jCgxTL3QPhQNwiZ U2lWHb25CI96VYTp7A2CJyvz0eRop6uU76yvqwIvIqp1sxdtUXtZdI2LuHqV1pMDY1M8= X-Gm-Gg: AeBDies5WCNDWYkfAewf6t8+/17U3ER+41O8Z0it9HW8/oZ2+CeCfOjEv9xGlONK5KS MCxye4naFaa1oimBH9ZyHAD0IvIpyhko3W2nTkQy1Ob9/B8gpe8f9vf5XSOnQ4eRV6RopJcnfhH uRC2DwjQINi2469kjPBlC6IUfUQsXkm3XzJmdpsC5apleF6OSc00sX2SrWxSreuFPHDJgQ5eSPx aaamD951m7pPU8L2n485FbU44l5G0zVxJXYwexXz2YgU2uXrtLjp3jj4z7Z3KCFsJCNqhqIYD+y aefG7Bo/bgqQK8qTO02l6atmtB3VbYoWa3VwSOwFvqNVqUCMqSAqYcSXrHi4TEmByzAO1fvgltR KRn4ivtmBHJnU9XzYMkrzowEDzSynNhk329ZHR/M4wRF1qU+kzqLT/psI5hDGpSOqFM7AfbmZNb jwa5jJ54bzS7KmqgkFWr73GJflXWA+mTlmmfW32MBS5O7bTg== X-Received: by 2002:a05:622a:4c83:b0:50f:b4c0:62ff with SMTP id d75a77b69052e-5104bfa6b9amr166830971cf.54.1777940754396; Mon, 04 May 2026 17:25:54 -0700 (PDT) X-Received: by 2002:a05:622a:4c83:b0:50f:b4c0:62ff with SMTP id d75a77b69052e-5104bfa6b9amr166830581cf.54.1777940753775; Mon, 04 May 2026 17:25:53 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393610ba09esm37132781fa.10.2026.05.04.17.25.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 17:25:50 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 05 May 2026 03:25:05 +0300 Subject: [PATCH v5 8/8] drm: writeback: rename drm_writeback_connector_init_with_encoder() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260505-wb-drop-encoder-v5-8-42567b7c7af2@oss.qualcomm.com> References: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> In-Reply-To: <20260505-wb-drop-encoder-v5-0-42567b7c7af2@oss.qualcomm.com> To: Jani Nikula , "Kandpal, Suraj" , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Simona Vetter , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Laurent Pinchart , Tomi Valkeinen , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Dave Stevenson , =?utf-8?q?Ma=C3=ADra_Canal?= , Raspberry Pi Kernel Maintenance , Christophe JAILLET , Jessica Zhang , Louis Chauvet , Jessica Zhang Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3014; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=mE50BYUB/UAw+zq2VOqPPalyAMn1gAB1RtsYcBWwgx8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp+TjcXTDEmBL/PifKO5n4u9XdLzRyirOofSZ0t R5jHaCLw4uJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafk43AAKCRCLPIo+Aiko 1fRrCACGOoHDQH4QaIwa/GwT9MrEbWmX7l37G0lci0xr/0cZZGn7Xbv1H5YVaHy6Jy26K8OsEKv S1oFOWhfiWWmPop4LiH2xFuCDz445YbGw5v9bxZiZXLtNlN205+VCu6A1bTdwk/tZAQTCwt/hxY IIExi09aX3uRiJsDHR829mUb96OKDFC+vddC2WLqFsb7j50M4INLuMHhJqKqEcywPNc7D7S/SK0 1vtK25FJGIvjReowOwc6NBiilcdlB9HAjDCzR1ne8Jkg02DObvbQ3PEIOtNJFcQDRfdCBH8J3sN s1qv0znAaU8Hh2jKuzUPWrKL35p3EJV4cPleldHBAY1yYn0z X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: Pll02IfL9fEJiM_C27y3Yz2ULEqLHpVA X-Authority-Analysis: v=2.4 cv=d9jFDxjE c=1 sm=1 tr=0 ts=69f93913 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=QyXUC8HyAAAA:8 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=By2WwYRBACVvdXAjiroA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: Pll02IfL9fEJiM_C27y3Yz2ULEqLHpVA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA1MDAwMiBTYWx0ZWRfXxNcjy+fS4RAc xYjwUOhbOyHjpam0TRC/JRsDw0odpDVSn7CnJdvdTVmd6y5MhxznId9+imaMyWfPWUglv+jcBku PCFVXNNXA5PME9io6IrHL6NRX7OlLU8fImsSJmP1R/N8qOyTC37VksFKDiYGSvEZ0Q7e7HxqMdW 5zqqjDVFMiDn+d7nqJxRfxQ/ofghvGy3LMV6z3wqynUUjseCfHgjhZwiwh8pjgo65ashOGvQtUo fKZQinzMhz/BvaFWI2sTfXzG4xyiz0zYabN3BCAs+srJOQ1TQuo0YKOxwjN1bhGjGnSm4OP7coR Bm+O8mr3Ap7y2Jk3jvM0cWOomnh0QtODh76p8o51r56qFcQJgWi4Gz/EhWzokbuD0ofywUwDbFM 9ABtLRgtkHweR53YgDhxzieRCIZU+BihgJN8f5Hfi6EC67/hKNOpVbf8CSO067+DG4YSsshQtw2 f4iT4jYzRxaJWrOK1Yg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-04_06,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 spamscore=0 clxscore=1015 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605050002 Rename drm_writeback_connector_init_with_encoder() to drm_writeback_connector_init() and adapt its interface to follow drmm_writeback_connector_init(). Reviewed-by: Suraj Kandpal Reviewed-by: Louis Chauvet Signed-off-by: Dmitry Baryshkov Tested-by: Rodrigo Siqueira --- drivers/gpu/drm/drm_writeback.c | 14 +++++++------- include/drm/drm_writeback.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 9fc15168c34f..68fdac745f42 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -235,7 +235,7 @@ static int __drm_writeback_connector_init(struct drm_de= vice *dev, } =20 /** - * drm_writeback_connector_init_with_encoder - Initialize a writeback conn= ector with + * drm_writeback_connector_init - Initialize a writeback connector with * a custom encoder * * @dev: DRM device @@ -263,11 +263,11 @@ static int __drm_writeback_connector_init(struct drm_= device *dev, * * Returns: 0 on success, or a negative error code */ -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, - const u32 *formats, int n_formats) +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats) { struct drm_connector *connector =3D &wb_connector->base; int ret; @@ -284,7 +284,7 @@ int drm_writeback_connector_init_with_encoder(struct dr= m_device *dev, =20 return ret; } -EXPORT_SYMBOL(drm_writeback_connector_init_with_encoder); +EXPORT_SYMBOL(drm_writeback_connector_init); =20 /** * drm_writeback_connector_cleanup - Cleanup the writeback connector diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index 879ca103320c..958466a05e60 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -137,11 +137,11 @@ drm_connector_to_writeback(struct drm_connector *conn= ector) return container_of(connector, struct drm_writeback_connector, base); } =20 -int drm_writeback_connector_init_with_encoder(struct drm_device *dev, - struct drm_writeback_connector *wb_connector, - struct drm_encoder *enc, - const struct drm_connector_funcs *con_funcs, const u32 *formats, - int n_formats); +int drm_writeback_connector_init(struct drm_device *dev, + struct drm_writeback_connector *wb_connector, + const struct drm_connector_funcs *con_funcs, + struct drm_encoder *enc, + const u32 *formats, int n_formats); =20 int drmm_writeback_connector_init(struct drm_device *dev, struct drm_writeback_connector *wb_connector, --=20 2.47.3