From nobody Sun Jun 14 01:37:20 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9516A28002B for ; Mon, 4 May 2026 20:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777925099; cv=none; b=IvrtdA4ntZ2FBxcWu/IPOrYaatouE48WjGReOz0TaYTpK65nA2JuWCR7y3Y/Kn2NQV/cuhna2iJc+ZwTDmod/KdB3tuZWvf33WNKrFuPkp0F6RJa9uUkeCSNe+Lzz4rcVTotO77ywADlzQOA3I4eP74XQXbh1hbw7oDgtSyphJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777925099; c=relaxed/simple; bh=9FExhyEXJ4WBPBrmzB7MamfjwiWuLla0OnVKfsSONcs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=azt9EdDwKLBB02QHsfyRlegBQNYBSZUnzATc9pLPi69tZCcw2wP0bx7N2VH2rNeThIy3Q5fh55qikb6tnSsneW5SRJXKbIvX995ITRL2yYwLPvOFUSshXCxjFT6s8H8XKSgHzPYpEy8IbGRFP+BLfC07njolmKZKkPS8sWFQpLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d2XOCKS7; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d2XOCKS7" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-365212191f6so1423257a91.3 for ; Mon, 04 May 2026 13:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777925098; x=1778529898; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x/sRxkDkVrRV3H5gNylpkzPThQXe+Qe8Y/t+6Rr0fC0=; b=d2XOCKS7dwWVlHah/Rj5orx2VjgSTfgHgi9L/6CQOyxvMSm5NkPm9S82gXhbnIZ/Ad 8yDtG3Ln3xl/3lAHMlVl7OF6V5LnkmtDrAruOIJS6hSwmGKE4LWg5hOaH7CY2zXGAIkA HQ/olcQDRb8iNI4jPMbasHvqpN80tIeLDXfkQhnclIwzKmSHnOCTogXEa6WHkKwR/Hd7 ff4uP4tFM5J/NZwFsqV+MWNBsvHEi+9HRFJ0t0AWvuPbQE3uAG0YMl5dwV2bWCs2KBn/ EqvGKhTzNqzRvqGHjXeffB0CM7bF2lGhf8uYOXhoKx2PDkGErJ5nAwG0T0er9Lx/ujvz NQUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777925098; x=1778529898; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x/sRxkDkVrRV3H5gNylpkzPThQXe+Qe8Y/t+6Rr0fC0=; b=CDmPpaStbiPSwDogx0eDNR/Ev6Osn6nqBTk9PytDSwNIpK1Br1KfKuB7dbGyv+rDbn /qGMmjfBpgChmQO00R2/8hpd0SMCXNJdSqwynaPMvU6nDByCx4Q/sWMbQqFnKp3c28PS yIdOTv3ebfh+HiB8K+AztUrDW6VA4r7maotYC8aymH6Kzn4W2KrsMgxfIYMbUW3C+R6f cwBGcO68PfBaMiEyoIZJ5prjaJEZl39OH5qHkf0r2AE9v6tpOYmHHeTnrXiBSMb4X40W C3BObI3Weuj0syhoWrEtnv5XSfYxafqUEF3p3gM5bbEHYeQRutlJylWzmdQsTWYlkmxj voTQ== X-Forwarded-Encrypted: i=1; AFNElJ/HYmjrpm9HWQxkh4hAnbbjP45Vums/dXa9RVfwkDxaYHsTIaX98M8Sme0s9/RH88qzz3Sl+MSqL6Q2xxE=@vger.kernel.org X-Gm-Message-State: AOJu0YyOKzo7b5IWW+Xzz1ADhYS3+yrdRrnmPFp2dhzLZ9rIvhUNgAJN kA03+5X7vYPByMxLKhiTzQQq+hNadzlaoRyctZyFUReoQM6tQ4ROZoFv X-Gm-Gg: AeBDieuDTEynSC/D5k5aiGgUPzJKjMOSA7rTqMZffp9VjrlbBshyCUr84p4qiCBNkeZ BcjyteXjA9BLX/j/1jcRsKaGeBVumPA6rpIzt2u/vyAb+aw9yRhnsbkMFyBI7do/73VAQtZmPe0 mFNZPE18oiXAo0jkHo11A/APuoFNonfvA1mfbMrM6EdxQjksvDU079IHz4PU9W/jJAg3sJ7NfZ3 Em56kxkFMpEWRF1tYBhGsNJOpjXULb/hVK/vbtgzpMCAgE1Z9wh073EuE452sXWQRbYJTIBEtIR jomMP4087WdCxHYLnwQRz73c7eM9Zn+0bz940y++AQNoloeLrHbt/Xxylft80dh3knz3Dcp9Xf7 ccwQAZ79AdML02thYC+jb6BBQq0PiysDV2NFzagP90YZMrOh1AcmXPAJytBVwvWRofgdTIa+OBM v8wazAq+YeTUtamLJk+3JKDm63ek4slxuDK7JBajq5Ppvn5NXN9iCLOW5ZoIPzXu+JgRtz4p/E X-Received: by 2002:a17:90b:578b:b0:35b:e51a:ec77 with SMTP id 98e67ed59e1d1-3657747c6b0mr314095a91.16.1777925097943; Mon, 04 May 2026 13:04:57 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364bdf2aa41sm20545525a91.4.2026.05.04.13.04.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 13:04:57 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Cc: Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi Subject: [PATCH net] net: rtsn: fix mdio_node leak in rtsn_mdio_alloc() Date: Tue, 5 May 2026 01:33:56 +0530 Message-Id: <20260504200356.3529873-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_get_child_by_name() takes a reference. The rtsn_reset() and rtsn_change_mode() failure paths jump to out_free_bus and leak mdio_node. Add out_put_node to drop it before falling through. Fixes: b0d3969d2b4d ("net: ethernet: rtsn: Add support for Renesas Ethernet= -TSN") Signed-off-by: Shitalkumar Gandhi Reviewed-by: Geert Uytterhoeven --- drivers/net/ethernet/renesas/rtsn.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/renesas/rtsn.c b/drivers/net/ethernet/ren= esas/rtsn.c index 03a2669f0518..c46d991cceb5 100644 --- a/drivers/net/ethernet/renesas/rtsn.c +++ b/drivers/net/ethernet/renesas/rtsn.c @@ -797,11 +797,11 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) /* Enter config mode before registering the MDIO bus */ ret =3D rtsn_reset(priv); if (ret) - goto out_free_bus; + goto out_put_node; =20 ret =3D rtsn_change_mode(priv, OCR_OPC_CONFIG); if (ret) - goto out_free_bus; + goto out_put_node; =20 rtsn_modify(priv, MPIC, MPIC_PSMCS_MASK | MPIC_PSMHT_MASK, MPIC_PSMCS_DEFAULT | MPIC_PSMHT_DEFAULT); @@ -823,7 +823,8 @@ static int rtsn_mdio_alloc(struct rtsn_private *priv) priv->mii =3D mii; =20 return 0; - +out_put_node: + of_node_put(mdio_node); out_free_bus: mdiobus_free(mii); return ret; --=20 2.25.1