From nobody Sun Jun 14 01:37:58 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D4743CFF4D for ; Mon, 4 May 2026 19:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777923597; cv=none; b=rCWCDPUX1xmjY76+vO4njByqPMmCmPL7fjLtXipDK/B0/KQPqgOTb2wdMhXwymjOdG9J7riMEsJGLF+irCBz6F0lr9s+jpO1dqKh2dDkhXBkESWgkOnmiUib4vOlsNVbcwquaWT4x0UpSphfBSjN6U7rCK7VqgajLdKZyZrAMeo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777923597; c=relaxed/simple; bh=1JOyIRRgBwbB/DhfXPbjmSn8yLF9GaFDLeyZF/pITec=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nkalCREpkOBakBUVO94vUvjrRzjc5x7Bfae6k+1/+Bd8FONf77LgZWHaiBl9nRWdLeOBxxVzhYK+lXcBYWpH8Je9q0PNerzrKgKrzQtLkH+J2I/Fgwm4wdnCY7C/VFWDcQcm/nzdZCDEcRoZnQQ0vyEGICYQbmcW7h2cHpn2+Ys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZG2+mXrk; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZG2+mXrk" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b9ec9443c2so12090855ad.1 for ; Mon, 04 May 2026 12:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777923595; x=1778528395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f0aIguRQYWYljT8AmitpZ9/B4tpFTi2ewvWnvOjrRTM=; b=ZG2+mXrkii6uMsk38ZUbJ9zpykUFGwED22CQ3eU3Qj6ggGYEAx0L2upz/DiRTmsSWj YpVCkgzNAAPnepys+I7Az52FLEcgnaCGpE87lh+XEJ/WdUE2maQmi0Dd3+05vuH5hew/ 9FHBg9foCe4gukAZr1+CrwDYe0cZzGEhE0Zx63AyG2CZnkcgTC8PENzH7BMxFv/JeIvJ 2f5emh9lqyT+q1pq1SKyrxk2EUtvGC9Jbsj1pMQWpPzpBRwciGDmdZ696zFChgseTH2u xaMgG7qdV7aufzPdX09+dQA+PUyQCFuO/JR1hnXz0i/77yCu4+vvi9WuWZxTvmbd2hHP rg9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777923595; x=1778528395; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0aIguRQYWYljT8AmitpZ9/B4tpFTi2ewvWnvOjrRTM=; b=slfOQcjG5b55nEH/YxADXHfBUyRG5eyf2XLzbBpUYVO2VfrMvZu3nCiPn80IGzrcGp z71EwAZ27h9BnOhpSZGfUHOAnzAUrKwnc1+6wvF1XK+FtXfWnFAgc2jrYm9iqUD7Mdra vVM41o7qlMWE/+me8SrkJnp3MID0BYndLgYU4S5fwrb+IQOb6ASTbU4qABiU69I742/g iWEgliwk6PRRbDCEX74SYh5XHNYMOIRO8suGzZKGawpMoJzhEjTv7U0JL4GerMvMgxy3 D94QN+vMnaM46g9BOihmLko3IKwKBMOa1EKwU+7jdRMwyUCiB0v1M+me9Dp17WjloV/0 C+TA== X-Forwarded-Encrypted: i=1; AFNElJ/GEDsgmvCth6An9MiQB4XEbfK+3BRGf+o2UIhXK0KblZbCt49NGiOxkd5BRQkdRj5P/gbh1lpDLlKg7Jc=@vger.kernel.org X-Gm-Message-State: AOJu0YwkfdXt3HfN8D9yI721YeOs7dPZRC8gN6IzK7dkbVAFJIikIbSy 3qDL3Zxwd9QXGfwBdrHN6t78JV9JXnm9+WvhCKQOaesQZLzd7WW3Qv16 X-Gm-Gg: AeBDievMJQB/AqmXNfhCfqpA6BNUv4l0OlUkwKWAtVMATezwFvNPusxP/zUXGo9fxqd JsQm8wquBVwFwhlbCBN5BOD3l2Lf92wO13uTAQYSRoE0FI3sHOuZatD2Hx0yfNv49Dv1FZh68qH RQSmsD6H7wMZWEIznl6kqKNLUB/5mcewzXw8sJZRc4IUaWiv0i/qZFzOqREI9ctyYFOHksPc+Gy iClPGTHwOvEfbCJ5tYGrelMa1GaVzEbXExX7xIas4MmN4ORC9KU/9dK2e8GvY32uqWuxS9aA3wu pzda0LYRvJ2yQy5LoTh4ol5igRCFBGDPAMrlgctq6hTxnrYIgYvQuf4C3F0w4NJURUK/sUIAQBz 47ErGTGMlwnqjQo/BvptLBwRdOiAGa847Mg4hKl4cL0r9r4xxefnTJ4Rae5lCotQpewEX3a+3M6 QuKM1J/37cV4F5URPiHXJMMJJWABCWm3h8cI+jfTceSQAII+P11d3hbzg+RCVT3A+KHooi4HVZ X-Received: by 2002:a17:902:cf4c:b0:2b2:53f5:461f with SMTP id d9443c01a7336-2ba4e4d4b4amr6067815ad.25.1777923594624; Mon, 04 May 2026 12:39:54 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae363d9sm116121755ad.57.2026.05.04.12.39.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 12:39:54 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: MD Danish Anwar , Parvathi Pudi Cc: Roger Quadros , Mohan Reddy Putluru , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Simon Horman , Dan Carpenter , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi , Felix Gu Subject: [PATCH net] i2c: sun6i-p2wi: fix of_node reference leak in probe Date: Tue, 5 May 2026 01:08:34 +0530 Message-Id: <20260504193834.3516862-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_get_next_available_child() returns a device_node pointer with an incremented reference count. The reference taken in p2wi_probe() for the optional child node was dropped on neither the early return when the "reg" property is missing/invalid nor on the success path, so a reference is leaked once on every successful probe and twice on every failed one. Use the scoped __free(device_node) cleanup helper at the point of acquisition so the reference is dropped automatically on every exit path. Suggested-by: Felix Gu Link: https://lore.kernel.org/linux-i2c/20260201-p2wi-v1-1-e0ec9cda82b3@gma= il.com/ Fixes: 3e833490fae5 ("i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) con= troller support") Signed-off-by: Shitalkumar Gandhi --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-s= un6i-p2wi.c index fb5280b8cf7f..652b37b57159 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -184,7 +184,6 @@ static int p2wi_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct device_node *np =3D dev->of_node; - struct device_node *childnp; unsigned long parent_clk_freq; u32 clk_freq =3D I2C_MAX_STANDARD_MODE_FREQ; struct p2wi *p2wi; @@ -223,7 +222,8 @@ static int p2wi_probe(struct platform_device *pdev) * In this case the target_addr is set to -1 and won't be checked when * launching a P2WI transfer. */ - childnp =3D of_get_next_available_child(np, NULL); + struct device_node *childnp __free(device_node) =3D + of_get_next_available_child(np, NULL); if (childnp) { ret =3D of_property_read_u32(childnp, "reg", &target_addr); if (ret) { --=20 2.25.1