From nobody Sun Jun 14 01:36:54 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0333D3D2FE1 for ; Mon, 4 May 2026 19:37:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777923468; cv=none; b=Y4H+Mv3CNMnBM1lA3IMk+m/8DolbQtgCwqtJJpkFd8hiuK3CAE5LeQXNLoypBYQqiiLo0m6pDDYSdub5i/I9oA8J1H9oJNHO49bjNqb5YVrsDfkfNVYOHiXAHWffwJkX3Cf8J43idV2Q5QD2Ic+iHe7CPaApT3xZOKDJ70LKvBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777923468; c=relaxed/simple; bh=1JOyIRRgBwbB/DhfXPbjmSn8yLF9GaFDLeyZF/pITec=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=po2kGCIGHV89gs4OYCQMnEEVg59d1bPyvvxdo5JvibONWgQlEWQLVPlpq1icp54ZA5oy6fh8MUeH/soRmlLkyAkYPo0kIHjoWhz6PQ+hPLZhXwxArQVRWFo1epx8ZZVw4a7TJwa1xrZBwa/4XMwLs5OXHIRAEJJckiPDseaHUvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SSCcPRq5; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SSCcPRq5" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8296d553142so3363896b3a.3 for ; Mon, 04 May 2026 12:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777923466; x=1778528266; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f0aIguRQYWYljT8AmitpZ9/B4tpFTi2ewvWnvOjrRTM=; b=SSCcPRq5Ssgo+8Kjf84DWCka94hZLFw8sTMgiVgfAdZ1DQ+yt7bu/gXG2voYqFe0g9 3lB90HgwGgAKXsshtNsxiHxB+A7gsX6qRPjdpVANMcXc71OsTg5gV8WccvI34K1sEiOm K+ZepyzbKqay8soo1WLsl7r+7H+pixbstcegEedpIW8ScTfVMVLEkl25e7nb1ELW0iFN Rw8+o9qXQ8JVCApGCZaEl5avy4g1zjo5h09naV5/Ix3d+qTorKyJmocfxvtNFYlKIOe1 4DTga03LkTI7/GwXY7eovJG222znrMkQyN4qvDGn2P/V3U0Wbadp2fQ4VCFodgK5H6Bq 7iBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777923466; x=1778528266; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f0aIguRQYWYljT8AmitpZ9/B4tpFTi2ewvWnvOjrRTM=; b=WiS3q2HVU9ADcmVl+YQZPmbVPSv44rW2yde02SXjlaBT0g4kDB9my5h4xAWrDrwOgx 3URI4OV4+Xd/f4pf/IkEdQBKiMZWVMYPAUiCrupbuwMt1/CsAVve233rChG0onrwn4jF CtGi9TKF9L7MkVRVnFHs411JhS4W8uSb9Wq/+ch6lUnx/vNllYiMqiuThxG+hzM/teu4 12icqk4Yb0gHZzyrdJWDaxkOEaMDZlcP68VlzvUjFk/LC1HtnkOKjQNM2lYsZB/fVhuT bCtZw6vmV/7S5hIJCOMs7lPqZKo4kF491ekKyrCwSoPuF+EeWWS4nfbFNUYDhAl2Ofu0 LU7g== X-Forwarded-Encrypted: i=1; AFNElJ+uMSPXBideOhLzpWVWVvn1mWMtfruQ/cIgt+6Sr0lm6cMEWBmBzsrRPUqmGbK8k8eGuYbNa8zxJntC8c4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbv/EK/YEdC1fFLLwLS+4ZcbaLK6t2kS7onMveJbgnPrefJgLe 72Rb/woVDkDLOanuRII4R4Xge3waw0XwltOrdtSXBAfR5WEb/pnqJz/N X-Gm-Gg: AeBDietKJHHsrVHakYN2m5MKbdHNu8lHjpaIoGK3uu+ylrAzA72v8sBKbgqNosEjouJ PFkWxB48+hK2pPv837p+RX1fv5pHLwHUeFUwfi+gDZzq1phU9qtT/hnfH0xsbxYFeIJAhD6emN8 SadBNoizhavcVmnUuVtmctgOf/HlghXh7vjEDylM0VdCl2M8c1SdRn3RAOXh+Or42cZ+u6WclMW 3cFmqFdfEw1KYfDzNf+mtoNffA8T2w1K70VGBut7rA82oeTXAhhmqai0h8YdFAf4c0vuWSCI9sK fNnhf8Wj3upc/hBDObCFSwwNDwnmCTRfd076sqe5VbJao6SDdELsHo5NvylcaqXsUgzwZrgHUP3 XwdZ6jmT8/DZOZWPSu61RLyo5XOtp3HqjEK5wB7W9le4AOZqR6eDqvHaGJvaYgRO2jqY6IACbmP s1lfKjAsn8NppBEpUdCmeVj8YPrHgaX+01kewy5pK2+kgS8pMR3hHE+C1sy6WerC5yB8rM4LUW X-Received: by 2002:a05:6a00:3a15:b0:82f:761:2b49 with SMTP id d2e1a72fcca58-8352d2b0b51mr9887750b3a.49.1777923466340; Mon, 04 May 2026 12:37:46 -0700 (PDT) Received: from localhost.localdomain ([115.110.225.242]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8392aeed4e2sm88980b3a.15.2026.05.04.12.37.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 12:37:45 -0700 (PDT) From: Shitalkumar Gandhi X-Google-Original-From: Shitalkumar Gandhi To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Cc: Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Simon Horman , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Shitalkumar Gandhi , Felix Gu Subject: [PATCH net] i2c: sun6i-p2wi: fix of_node reference leak in probe Date: Tue, 5 May 2026 01:06:59 +0530 Message-Id: <20260504193659.3515669-1-shitalkumar.gandhi@cambiumnetworks.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_get_next_available_child() returns a device_node pointer with an incremented reference count. The reference taken in p2wi_probe() for the optional child node was dropped on neither the early return when the "reg" property is missing/invalid nor on the success path, so a reference is leaked once on every successful probe and twice on every failed one. Use the scoped __free(device_node) cleanup helper at the point of acquisition so the reference is dropped automatically on every exit path. Suggested-by: Felix Gu Link: https://lore.kernel.org/linux-i2c/20260201-p2wi-v1-1-e0ec9cda82b3@gma= il.com/ Fixes: 3e833490fae5 ("i2c: sunxi: add P2WI (Push/Pull 2 Wire Interface) con= troller support") Signed-off-by: Shitalkumar Gandhi --- drivers/i2c/busses/i2c-sun6i-p2wi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-sun6i-p2wi.c b/drivers/i2c/busses/i2c-s= un6i-p2wi.c index fb5280b8cf7f..652b37b57159 100644 --- a/drivers/i2c/busses/i2c-sun6i-p2wi.c +++ b/drivers/i2c/busses/i2c-sun6i-p2wi.c @@ -184,7 +184,6 @@ static int p2wi_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct device_node *np =3D dev->of_node; - struct device_node *childnp; unsigned long parent_clk_freq; u32 clk_freq =3D I2C_MAX_STANDARD_MODE_FREQ; struct p2wi *p2wi; @@ -223,7 +222,8 @@ static int p2wi_probe(struct platform_device *pdev) * In this case the target_addr is set to -1 and won't be checked when * launching a P2WI transfer. */ - childnp =3D of_get_next_available_child(np, NULL); + struct device_node *childnp __free(device_node) =3D + of_get_next_available_child(np, NULL); if (childnp) { ret =3D of_property_read_u32(childnp, "reg", &target_addr); if (ret) { --=20 2.25.1