From nobody Sun Jun 14 01:34:54 2026 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010035.outbound.protection.outlook.com [52.101.46.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 275CB3E5ED6; Mon, 4 May 2026 18:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918326; cv=fail; b=aKXB/ynshY96tGB5jRX3Rho76muJLQG33nQtfWQVIptrkNb6iLrdh64rhuTIsOpMKM2iNvXFrVhTYEpPydmBZH+cnGuNrB33ZT7SNO6FoXcSXKwiyh+VMQGR3Ps9vD6IQyXUmRm119BDGq2YvczR/m996Dq3vytDvKvlaKWgAVI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918326; c=relaxed/simple; bh=c+hEJGunVRsABvIrlCVL2s5Tzn0fQ1mfCBiWT40BGvc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mL3kfXWicyGnJBTNd8JbwTi1O2gz7CsXOpCgsB0/xW6wuOZVUzN3Fvzg6PvthHOMKB+Zf0FSZxMYn9TMPvtv6mUNd3I9wrnSfkopG8CryoT3PHwYvftvyVJl1XgtOM2urCjZ0BBQ2RsBxmVLJJB/aEfmIsJxkuJHpe1bSm6zQL4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=YWnMSKMD; arc=fail smtp.client-ip=52.101.46.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="YWnMSKMD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lv+4Yyfetp9Zy6Eu9rShaE/+T/QoeI55eakTzRErh3Lqcn1EYi2gWyidtanRaZVIfVO2NWcCnmvyOe5iApNV66ibdhgW1qHGDtYuOWXDny+7J5XGN0pqnOq/dWO4LcAmeET65AwbvrI4987zup7QLcJbRz3WROxaTIQvhPeh/k2U5PSYdq2ztYSl8VWdLsqVSLaQvkVM6MP8gJnC/J/jNQWvEDJmgu3LTE8Y/Bi4qpTxPjBQCbQkImdaoxvRnVb+HKZzgNjELc/BKct1lOhRdU6tqgS3IjwoIljZlAcJyNEZiHjtLgTGIi/W4S9cIEGv8EC8NuofEUY9Zoi4Az9AbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhfCYud453JDgeegWkZI92gL7GV6VL54iLQ9OqQzXlM=; b=UiOGpxuQCgyhf5PFfbLRNr5PEFQ5q0MZp5AEmNfUN0eWDOYxgQvv5S5+/QSMrZPXBkVtHIDiPuQieW5zpfcuisbc13ncRw21CyaI2Z98Fa/NeEWQj5VTZLW75nBAqwf8UeXmM8T4v93VIXlf9K9ibDg2sUZLKYZv2TZjqP8YNo61Kb8fOUW7O3R05Gp8eBWkzwFVcHXXjJzlLEjpui03EfxmH78t485/7ZC4HcoDJ980e2jSMwZGvhgo/UWZIBGDOAlRuCPOiPJltLOfKvRdMy6EGgv2da5a9oX6QivhHROHMNHjmOaLEaDWRK/Ol31kkk50VWJsaKDGZPKHTcyrug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhfCYud453JDgeegWkZI92gL7GV6VL54iLQ9OqQzXlM=; b=YWnMSKMD6hmilhI83i6icKPpUkmlr2zpLd+ijoH+2TBUD82D7j0d9/UOnnDkajJjLwvc5tRo5R0I83nqzV4lxLUQthOF21cpSC9eogRO/AKB0e2mJDJHWOMlOSx7VGkKEna9bZEg4h/pEyRH4lplCalIcwDg+td61lScJs0a+gHOg2kjCWsvBUuokbrOJ1hELaJnmydIFDClEu98fsoeWBJYJcg79WGrLNu3deZDZZS1FypMf85cT6ckp3mgx+OEN+iRVsDMcr8gEHyGIgW/rlAi2qCM4qmdWbtrhxKcV6g8X2TnIfIta57XLjCVJ5Dj+5+FcBBcNnH+MnxXRTPyVA== Received: from PH8P221CA0017.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:2d8::13) by LV5PR12MB9753.namprd12.prod.outlook.com (2603:10b6:408:2b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Mon, 4 May 2026 18:12:01 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:2d8:cafe::d7) by PH8P221CA0017.outlook.office365.com (2603:10b6:510:2d8::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9870.25 via Frontend Transport; Mon, 4 May 2026 18:12:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.1 via Frontend Transport; Mon, 4 May 2026 18:12:00 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 4 May 2026 11:11:23 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 4 May 2026 11:11:23 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 4 May 2026 11:11:18 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , "Mark Bloch" , Daniel Zahka , "Willem de Bruijn" , Cosmin Ratiu , Raed Salem , Rahul Rameshbabu , Dragos Tatulea , Kees Cook , , , , Gal Pressman Subject: [PATCH net V3 1/3] net/mlx5e: psp: Fix invalid access on PSP dev registration fail Date: Mon, 4 May 2026 21:10:58 +0300 Message-ID: <20260504181100.269334-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260504181100.269334-1-tariqt@nvidia.com> References: <20260504181100.269334-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|LV5PR12MB9753:EE_ X-MS-Office365-Filtering-Correlation-Id: 78e97261-2776-4e24-6fe1-08deaa08a308 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|376014|36860700016|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: ghDqoGvGAAHgK3Ov+ikHw353dwOyKebTWdRPiJC3TMhHapGhXsHflJo1INlK2M+8mQSyR8SKyBmRyzW8L6fm2llA0dlKct7mbPnl6Kt+b2vV8GWxK8KmhL5YETBDV2rXcO0aWClBmyEVEWP+zo8d+7hMIGfzAogtu/znyL4DpQm5CR85WV0pvDGuWNAyK2okLP7qW0hXfu3aVVU601tZZK1RzknfwU5f8qc6mXwcNK/O0gE+apxuvXy/TLYpoIh4lHRdQy+t9urf6r2F5IBwysm87djtOkHo3B5mhsAt8l8PKHU2ZcPAzjS4FbgXCc8K6rFshgjFNGQdtccpAhwvvABDAbY1F3h7Ex7Lucx6jeZxSXYSpvyJ88E6IvNLOB3ZgqVG0jVB+P3en5ftppA0rW6W65YiOo2RDRgENw/XX0LVEqhjX9bvRUh3FtQbnzhAMayPMhZ0bkHbPDAd0knWEHzJYbMQG85DiHBmLAsloUV2xaD6E0EnjzcKiasqEd2ZsBA55dmJBiwJoXd3nHVIipkHMWkMa+s9tGAj3xkfz6Sk2LcysiCAk2ftul8IStlkeGCbfbE/ak1eNpJxsgpshfJmsMOqQkxm8Y7HvwgRIkQRGny0TTuaUuPiXVmbJCb6YAnoWgVSVstWazqe2gN7dGsqhQgvcwOqXub4yuplMAgAAx+5bH0l3OqZK6/znwjNqd8sWY6ZceDRQv8HkPp9HLGGAZ04kSSow6zVWCD+mYE= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(376014)(36860700016)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: x2lkbazpwcSOcvNJ9nOZ8deERTWTLTTjPH4KHdk0vH4rBtSy0SoDfuws9nxLDXif2NNA/s3ypbYcsvvbFZRJ2nlJqA8rImRcx4L8Bi0rZrWkFBbSvogqWeVKUrGNHBcmR4Q44TwJwSQm0/cOHoQw9fYjGjED3vAaCU6Rm19VqHu7GmC7pdaTArLNYuzSCCCeY0N7sOF7RCz3ugciWyK+OAW8uR9/X0EoWnBVkRR7nmHIFaIiy2IICuLOXAzFhQQDXDRYxx5VT7tr8nkLTwpQj8DePnkz9aAIEYIQ2aYU1AdYVqF1u03HtyPI0K6/GY8+XpMozTe2gHbkozJpza9f+tKp2cqrqKu2tO9gFdEK7XRav8DY8/LOn7hfptH1N5f/cqFuv9sHW6v55TpyEo7AmwD7nX490JNoNrNHbQn3NX/eawSSxwxf76glK6VPfsAW X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2026 18:12:00.3392 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 78e97261-2776-4e24-6fe1-08deaa08a308 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV5PR12MB9753 Content-Type: text/plain; charset="utf-8" From: Cosmin Ratiu priv->psp->psp is initialized with the PSP device as returned by psp_dev_create(). This could also return an error, in which case a future psp_dev_unregister() will result in unpleasantness. Avoid that by using a local variable and only saving the PSP device when registration succeeds. In case psp_dev_create() fails, priv->psp and steering structs are left in place, but they will be inert. The unchecked access of priv->psp in mlx5e_psp_offload_handle_rx_skb() won't happen because without a PSP device, there can be no SAs added and therefore no packets will be successfully decrypted and be handed off to the SW handler. Fixes: 89ee2d92f66c ("net/mlx5e: Support PSP offload functionality") Signed-off-by: Cosmin Ratiu Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/en_accel/psp.c | 26 ++++++++++++------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c b/drive= rs/net/ethernet/mellanox/mlx5/core/en_accel/psp.c index 6a50b6dec0fa..1ff818fb48df 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c @@ -1070,29 +1070,37 @@ static struct psp_dev_ops mlx5_psp_ops =3D { =20 void mlx5e_psp_unregister(struct mlx5e_priv *priv) { - if (!priv->psp || !priv->psp->psp) + struct mlx5e_psp *psp =3D priv->psp; + + if (!psp || !psp->psp) return; =20 - psp_dev_unregister(priv->psp->psp); + psp_dev_unregister(psp->psp); + psp->psp =3D NULL; } =20 void mlx5e_psp_register(struct mlx5e_priv *priv) { + struct mlx5e_psp *psp =3D priv->psp; + struct psp_dev *psd; + /* FW Caps missing */ if (!priv->psp) return; =20 - priv->psp->caps.assoc_drv_spc =3D sizeof(u32); - priv->psp->caps.versions =3D 1 << PSP_VERSION_HDR0_AES_GCM_128; + psp->caps.assoc_drv_spc =3D sizeof(u32); + psp->caps.versions =3D 1 << PSP_VERSION_HDR0_AES_GCM_128; if (MLX5_CAP_PSP(priv->mdev, psp_crypto_esp_aes_gcm_256_encrypt) && MLX5_CAP_PSP(priv->mdev, psp_crypto_esp_aes_gcm_256_decrypt)) - priv->psp->caps.versions |=3D 1 << PSP_VERSION_HDR0_AES_GCM_256; + psp->caps.versions |=3D 1 << PSP_VERSION_HDR0_AES_GCM_256; =20 - priv->psp->psp =3D psp_dev_create(priv->netdev, &mlx5_psp_ops, - &priv->psp->caps, NULL); - if (IS_ERR(priv->psp->psp)) + psd =3D psp_dev_create(priv->netdev, &mlx5_psp_ops, &psp->caps, NULL); + if (IS_ERR(psd)) { mlx5_core_err(priv->mdev, "PSP failed to register due to %pe\n", - priv->psp->psp); + psd); + return; + } + psp->psp =3D psd; } =20 int mlx5e_psp_init(struct mlx5e_priv *priv) --=20 2.44.0 From nobody Sun Jun 14 01:34:54 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012007.outbound.protection.outlook.com [40.107.209.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62AB612E1E9; Mon, 4 May 2026 18:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918324; cv=fail; b=gBlFxEforf2IR93vSenYq6GwQC742iAoM12WQdJnFftQ2VStbxvWdbeUdF+v87OhvtlRiNUm6BWVNYkAxGrs+on2qmUv4cjJ16MasPJHhCfFFuS+AV6rDKlbMeLo8Ec+TcYxlMv4HH/B1phL7AkTpk9xyxFIzbg0fLk2yc4MMqg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918324; c=relaxed/simple; bh=ct+s+epdz8MsXWs5nI3PDM9ZsfWKT6f9+WNtGjO3RIg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DsAJDzYALnY0dOvdj1SszR/hGvRzxT8uNKUo9UlFmoFEpF654aIbxj7aAGC2H44amWop3yfY/z0LCyZrYKxX/84qsbYjfnJ5/v84QfCc7gssy0OrWJ60yZYlLfhn+STzjI1uyIWVMQK241OlszcCHwBudsisZucHvbwqUeFijRc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Dk4+eMFh; arc=fail smtp.client-ip=40.107.209.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Dk4+eMFh" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dx+7yJkr44rswzHJKJRwSIPurhNl2f14P+ohKQXowHl0aEGTN2cPPKbGV5hzDnklnxkf8DjDnaHMbccGB0Z7gDwGR3TMg/uCPYrdPo1uD6M+39ek6uL5zNZfwApT+kAT9EbSBp4Yfxc8l8rk3ie7EarLbRDIQQkASM5ryQgCWZWWmoEE2RostTroe3l7Cm9OjyLt/wCmvFkQPn6SB9GfaTtcW3xHqpU02AexdBtSVwYDSHOHd5i/dPAPeNEj6yON0RM4paParoEJIpjWRfhHLVH6qEKMPNyPrQQMPo2bNc4lwnAcyoPY6wmpZGN10iomL6ldgvCiZ4xHoQFT9jdpDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sjC+EYtE4bIEXdUqvdXscztQIVvrSkk6JrSmDBuAcEI=; b=EdU+GP4mqmzpwWu1IEd12skYCCGs6X2VW75g8ihPEUCULOAnaLonN/ZHxIhLtzSybwcd2BNZ0m/3lv54i/SynILUpqRhmfWsPpcRf29Gw+TwFsOqLUFVqTGsSiyHRvbNG181iwrubogBQeVXcjgkqLL325mT97wUKTc9fgTYqId/lvtaHjgQJng9ZpeU/iRc4uHEHjou3fDUQidbBkXFuilShZjj9AiudSto9EzGurkaBitbaWhG11hB6+Z/o23NkF2SNptiY4+Cn261tpEGqic7yrlF82Lp2TBHzC916U/3sBvuIRjjoBSDdhlF6xDk3cE833WK+xkXS67PrT82Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sjC+EYtE4bIEXdUqvdXscztQIVvrSkk6JrSmDBuAcEI=; b=Dk4+eMFhIbjkWD7Tj9xlFAdxDsL0sIHRsrtu/14FeQFEhkwmX18GEUVoPfPsft2DT/kvlem4V5qhyKgT+1N+XWBPIDMFK+dIc/+TJrwBUtna2WPwtUOFNpfmuwToXbcYmZC6758xQUH24HRNReM9ZHnjyR+ggoOGJylOQKTR2DtwSoUw7WOe05EzUO1rmrn131n3Q/xjmdVnveRcnAddsp6OYyC7qWvWWD3j7mPH3KEZu25p1eubkisZ5QnJIX9yyJETfO7m1jRWGx8rWWsAMSIlEqyuAEFVfDeTOLj1bjJwaY0eqViiZWLgz/VRnu88Maox5a0WUiGyYGY8ZfzPqA== Received: from SJ0PR05CA0062.namprd05.prod.outlook.com (2603:10b6:a03:332::7) by DS0PR12MB7993.namprd12.prod.outlook.com (2603:10b6:8:14b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Mon, 4 May 2026 18:11:58 +0000 Received: from SJ1PEPF0000231B.namprd03.prod.outlook.com (2603:10b6:a03:332:cafe::b6) by SJ0PR05CA0062.outlook.office365.com (2603:10b6:a03:332::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9891.13 via Frontend Transport; Mon, 4 May 2026 18:11:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF0000231B.mail.protection.outlook.com (10.167.242.232) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Mon, 4 May 2026 18:11:57 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 4 May 2026 11:11:29 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 4 May 2026 11:11:28 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 4 May 2026 11:11:24 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , "Mark Bloch" , Daniel Zahka , "Willem de Bruijn" , Cosmin Ratiu , Raed Salem , Rahul Rameshbabu , Dragos Tatulea , Kees Cook , , , , Gal Pressman Subject: [PATCH net V3 2/3] net/mlx5e: psp: Expose only a fully initialized priv->psp Date: Mon, 4 May 2026 21:10:59 +0300 Message-ID: <20260504181100.269334-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260504181100.269334-1-tariqt@nvidia.com> References: <20260504181100.269334-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF0000231B:EE_|DS0PR12MB7993:EE_ X-MS-Office365-Filtering-Correlation-Id: 45769e83-01cc-4479-7c1c-08deaa08a14e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|7416014|36860700016|376014|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: EzXc1s5vXSQDhsZxDD9IiwD1OwF1QEd3yS5NxLElRf0nZmImsxCXHpd5EafOVkBzFWuexcGQifD2IysHtiSqnSXr9Z8/pZh24boR+NVrPZWFe0KDguUv3ny/I6y3yNMK6p+R9InAY0LYULl9g7oCjMO/LXZrmGjVYcjU+ngmKuSOMkci6PUYSBm7OvMT665szOFrV7n3u/QOY6fZPQg7ThdUL4q03SNhaX+4U5/sArbFaVZiKkMTyLwzjTkimUA8gNCXvh4mQtUx71+82F1Rq/JaCxC1xMIdR+mUlOHvw4kkxsoc0cgPe/ctlFXy088MU2pOwsB6MM2rAflT8NNN4R7EUNuJ2a0vxh+3t3jRUkGufScEILMQxAtho4VmSepvT05ne4uYmC8r852JJcwyspCQ7hJBRALgJs+KdICW0hnh0c0sPidnELTU9KZDPf6kAbK7GGn/nWFo92wlOxWla7JTLtz8kcxG6dr8TgKfHdV3gl8SL5thgw8hPjIRIvYhFrHLZMbUVZXe/3fWdajt6TxBZl/GL69Rw9gC0u9/T3Vv1mqiQA7Orxk0qQSZRHpLfuMVKsynLeINmY5xS13BrAvrIlIKSw0PMzTgwkpUOcxYX73xSynnK1Xe099YuTfZ0LwkjK+kyYkxdnvTBdAeAEXq2jba5CGSGcakLTKD068T93KW3y5EryqVU1TKoQAFpRw++GSHhfXsRgLn42plMVLBV1gHTVcWje+Ebs+WOvg= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(7416014)(36860700016)(376014)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1hDIMaRgOAPqOkbGUhUdDZ63zI6LAK2tE6mBCGNrM/k/V/w3alCjpl64OuWYbJ9UYuPaM6Mz5rLoFMLm/xqlCTo1JSrhbjqHZKSc7olu4Zd9iwXs46TBMbd+6u4/WAJUvXdweIlxTjYFQiujEkmci593qJRxxaOssdcvB8aH1UY3xbdMQgjPdNahUtKEHEFlycfXlx8QT//WxYMXrP6IE3YxwXY3PlN+vnXBwzvn1w78IiA081BUgx69pL1ckdSnBl36GxzKSNHNxEEMfCVeMHKwJiU9y6NR7j5PHzat+s0X63kdZAEnaAiVmVKxi4yP+pNqXtuS1qQLXgAgeqDSUFOmEUxdehhI9ZEbe6vh2htLbYvWphTO4/7+jb9deNxAd2v9EtWcqXU4bKeRY+vaa0Ltk4Gq3mnVngsZNcH0tiEc2G6VqCxccnBBU42sWuQ1 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2026 18:11:57.3164 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 45769e83-01cc-4479-7c1c-08deaa08a14e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF0000231B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7993 Content-Type: text/plain; charset="utf-8" From: Cosmin Ratiu Currently, during PSP init, priv->psp is initialized to an incompletely built psp struct. Additionally, on fs init failure priv->psp is reset to NULL. Change this so that only a fully initialized priv->psp is set, which makes the code easier to reason about in failure scenarios. Fixes: af2196f49480 ("net/mlx5e: Implement PSP operations .assoc_add and .a= ssoc_del") Signed-off-by: Cosmin Ratiu Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c b/drive= rs/net/ethernet/mellanox/mlx5/core/en_accel/psp.c index 1ff818fb48df..d9adb993e64d 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/psp.c @@ -1139,22 +1139,18 @@ int mlx5e_psp_init(struct mlx5e_priv *priv) if (!psp) return -ENOMEM; =20 - priv->psp =3D psp; fs =3D mlx5e_accel_psp_fs_init(priv); if (IS_ERR(fs)) { err =3D PTR_ERR(fs); - goto out_err; + kfree(psp); + return err; } =20 psp->fs =3D fs; + priv->psp =3D psp; =20 mlx5_core_dbg(priv->mdev, "PSP attached to netdevice\n"); return 0; - -out_err: - priv->psp =3D NULL; - kfree(psp); - return err; } =20 void mlx5e_psp_cleanup(struct mlx5e_priv *priv) --=20 2.44.0 From nobody Sun Jun 14 01:34:54 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010005.outbound.protection.outlook.com [52.101.201.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D957A3E5597; Mon, 4 May 2026 18:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918336; cv=fail; b=QOPVGJX7Sx9d0U8HqN3PGgW0Dh2QoW7BvnS26pPSnrCTNvX/sSpuntg9mm2nphKUwF5VaFwU4dDNyWVWf/Rg1zx7GJvjvIaRrLMfLZuoj3Vhh78628WvSxh+WnFQHjtAvyI+R9V70DpxJLHAiQ7fiu1iHWwJMw495bu437pyj8U= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777918336; c=relaxed/simple; bh=3byHFNC93gAfJOtDdU71buXfOsl1qA18d9jbQWI1Nr8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HLC7xY5JDfpkNapaEZYFVToxz3b/KnA+zRHBYjuOEKHNH+kWVAFrCMksip4XhFT2tPm3kLONGvKrRLk/aGSkt8NICjjRVeDLCif9MpTSEXaXkfmh+hGUyGIaN0Ru51paFY5bUGvEWV9IXRW+KOkncWg9GAfBdZx17abEtx7QnNI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=gqM7gefw; arc=fail smtp.client-ip=52.101.201.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gqM7gefw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ebnPvrZKzJViBkoDujYxa5JnroLyNRVCSMTDcact2vclBk8gSEhM1Bd31myXbThbRrqfNmA5y062ABra5Ly8gmLf5UWNUdmWA4SBpnTH2ZoiVoeeOD6Ava0S0nCHi4zjYPJhil9uEBq3RJDm2M5yAfMU08UYj433hL2WQsFaMCE6vP5sQHYS1izMjUmVMJw+mXd9rH7yXYj2cqZhlcUorZlrJsvPEmjtQpNFLhKecIqJZWdfBsxlu82shfdMJfpASGakpvmQet8w02g7hQ2YIOOB7/l1rG6YS9W5K5Pstt760mfgwVGhAfYEfpw+vV5sBgWS+jZNwKXXcMWX/Yf6Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Q/GigAVK00gM2QCf1u2hzP1KeoY3ZFSBiy+dTlMHXM=; b=RY4FQbMU1B2KYsPoO8ro2UtXkwmrKi1bChjGGxG9frj9/rEtXcu05J09T9bUTAjCyyYWtUIVrfILC5RRiSgH0kcfra0+lbZlFvM/6tH1X8UkQDPXjGLrm7bpf+Jc88wc3xabOxAPpg+nKxgpfyOqoJ3Iq4VnIqyPxbZOrD0pwMh3I4kxGFGCw6cAMHQOsoIfc9EBETYzS9VwutugX5EyYzizUcy+qhu9UEQtCtwxn8jBNm69sf2CWNE3uR5aze0+xQIpG4Gx4PTiS5eRHFw5ueZwCRm/FgOk3LUtGpahOKdXEtT2YU5pwUYuPz6uRzdNR7UjaRfsBTmxlzmIrG8PLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Q/GigAVK00gM2QCf1u2hzP1KeoY3ZFSBiy+dTlMHXM=; b=gqM7gefw6ocN/4zOQy/SFZ06VJuUoowa0ZEwjWdDUPpQz2qlalH8skMWbNqLbp4oF4xvutNYnFn3m2P4zt/sdv1ZHj4vQmxashfbMQPur3gMtZ5riJD/bFFiidwbZLwMzGjbrhxUrVwGoEg8X1KO0IfsEwXEBCe6kc/7xB3zIS9k3qLTKFKcfLoM28XlGtYjIfPvxpkhuaC5KvB5eJuL0vEQF8NJxKDL/fcwz9AQWF/OTEfSLSxqFg22UfW4lp+7BWZ04sMVqYC6a3dwdciFdsi9qvrY5n6DBvpCUJClwfLtgb+6oWjbQB2n/l7p1vSHftXL8oClWXbaafFUv7tNzg== Received: from BYAPR06CA0067.namprd06.prod.outlook.com (2603:10b6:a03:14b::44) by CYXPR12MB9337.namprd12.prod.outlook.com (2603:10b6:930:d8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.25; Mon, 4 May 2026 18:12:03 +0000 Received: from SJ1PEPF00002311.namprd03.prod.outlook.com (2603:10b6:a03:14b:cafe::ff) by BYAPR06CA0067.outlook.office365.com (2603:10b6:a03:14b::44) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9870.25 via Frontend Transport; Mon, 4 May 2026 18:12:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF00002311.mail.protection.outlook.com (10.167.242.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.9 via Frontend Transport; Mon, 4 May 2026 18:12:03 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 4 May 2026 11:11:34 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 4 May 2026 11:11:34 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 4 May 2026 11:11:29 -0700 From: Tariq Toukan To: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , "David S. Miller" CC: Boris Pismenny , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , "Mark Bloch" , Daniel Zahka , "Willem de Bruijn" , Cosmin Ratiu , Raed Salem , Rahul Rameshbabu , Dragos Tatulea , Kees Cook , , , , Gal Pressman Subject: [PATCH net V3 3/3] net/mlx5e: psp: Hook PSP dev reg/unreg to profile enable/disable Date: Mon, 4 May 2026 21:11:00 +0300 Message-ID: <20260504181100.269334-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260504181100.269334-1-tariqt@nvidia.com> References: <20260504181100.269334-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002311:EE_|CYXPR12MB9337:EE_ X-MS-Office365-Filtering-Correlation-Id: 88df928e-15e7-44fb-98d1-08deaa08a4df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|1800799024|7416014|376014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: nNvjSfCZ+fdK6zqtUZFqdeS3LcbD3NBTE2QZOr+hQSi0Ec6KGSB0NnDYjYdujDCOHVF0j3Fca1m2v9qYU8bHXx6clbZ1TJBi1T/dsO96wzEGBHmjb8gz5wOFxwdFNbRXDPUcaTaBleulZ3LjzD71kqzrOC0BBNzKP3ifvbz24osICl054NJBrjuV1ATPkPh5V0UNZE9LwRyrKtBzy2XCnA4ucdPn/e6JmZ4D8wQlro/0F84RRt7I4HeVMbeZQ6MukSCLBJc/6X0huEjbVIE+ierhQOJvVXNWZDNqkLE5nPeoKp2rk+4qQZbUBGEaMeUXkcoB7jw4ZbEwy0NjeXqNQncAliVr8S/itrnYP8I5EkRA2dJ2y9lF8L/AjjupBf0sm3wpEs0WTpoOcGyLeulG2yMLXQdYuoZSPrUHHNVwJs7DHGhK2mHVZXd5yoe8vvgfgyJX4Aglx/NfejCsp0p1/J7RuxsaUbVWfnbBY80WpivlZ+aWNHPkitjwSeBj6IPvu6+wAUufY01xxpfzooPm1tGDoT1HdJ0DmRYD2GzG7bzcP9U2Y2XG8WdsQKOeniMxj/18cwuSbQd742hrV1uTGR3heASih9OGKhiuKmRdiWqfT8npcNet8MldpFqY7LFUVoCgbeZQfN/dIesC/QfjUj75HR6nhviMHYhPP6dxlC3+R2ZPoNsTxAZM3PgaR4Rcf8QG25QFTd480ov2jMcUAD70iaQ/lbTTz/Gf3Y1f2SA= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(1800799024)(7416014)(376014)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +N1FMFvxq+9iCeJee2yiaRd69ev4/hdUsp5DnW7cRD0vIE9wxndMBxv/HJqAHc+93ZFfSLj8OL7hjycGqdL5iit4Yn86Z8D+fIYNguWOa+qdKuFViAaEVCfOiGXAzbKa/XupRXRBJYY7BSja7r0wlodjQsag1qlZ/I1B9cSyO2/gc5gQjdJ1MEVXvESCYdqvT1UmImiFI+eEdglPCYJZRkF03+wRnmf6iPFtT4GYQLxsFiAzsSROmlJxf2Llh4KGJaMgZfZYDCgtw+JVyme8Hx6RWEToDHW8wmvOWHaciLZ3QIkFhMbw7QqUKzWyMF2iM0Ly/IoKufHIQ7YQafKSPmNzCmSqLT/roDecbZ19Bk4xMDWxsHoJ3BVbrNi2REHMN208XVgE1Re5kZXq6Ln7YUK/VrEQOLPgFlFtZVG7hG7BkgdJ2fsqET2sz/sem4AN X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2026 18:12:03.3037 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88df928e-15e7-44fb-98d1-08deaa08a4df X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002311.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9337 Content-Type: text/plain; charset="utf-8" From: Cosmin Ratiu devlink reload while PSP connections are active does: mlx5_unload_one_devl_locked() -> mlx5_detach_device() -> _mlx5e_suspend() -> mlx5e_detach_netdev() -> profile->cleanup_rx -> profile->cleanup_tx -> mlx5e_destroy_mdev_resources() -> mlx5_core_dealloc_pd() fails: ... mlx5_core 0000:08:00.0: mlx5_cmd_out_err:821:(pid 19722): DEALLOC_PD(0x801) op_mod(0x0) failed, status bad resource state(0x9), syndrome (0xef0c8a), err(-22) ... The reason for failure is the existence of TX keys, which are removed by the PSP dev unregistration happening in: profile->cleanup() -> mlx5e_psp_unregister() -> mlx5e_psp_cleanup() -> psp_dev_unregister() ...but this isn't invoked in the devlink reload flow, only when changing the NIC profile (e.g. when transitioning to switchdev mode) or on dev teardown. Move PSP device registration into mlx5e_nic_enable(), and unregistration into the corresponding mlx5e_nic_disable(). These functions are called during netdev attach/detach after RX & TX are set up. This ensures that the keys will be gone by the time the PD is destroyed. Fixes: 89ee2d92f66c ("net/mlx5e: Support PSP offload functionality") Signed-off-by: Cosmin Ratiu Reviewed-by: Dragos Tatulea Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/ne= t/ethernet/mellanox/mlx5/core/en_main.c index 5a46870c4b74..8e9443caa933 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -6023,7 +6023,6 @@ static int mlx5e_nic_init(struct mlx5_core_dev *mdev, if (take_rtnl) rtnl_lock(); =20 - mlx5e_psp_register(priv); /* update XDP supported features */ mlx5e_set_xdp_feature(priv); =20 @@ -6036,7 +6035,6 @@ static int mlx5e_nic_init(struct mlx5_core_dev *mdev, static void mlx5e_nic_cleanup(struct mlx5e_priv *priv) { mlx5e_health_destroy_reporters(priv); - mlx5e_psp_unregister(priv); mlx5e_ktls_cleanup(priv); mlx5e_psp_cleanup(priv); mlx5e_fs_cleanup(priv->fs); @@ -6160,6 +6158,7 @@ static void mlx5e_nic_enable(struct mlx5e_priv *priv) =20 mlx5e_fs_init_l2_addr(priv->fs, netdev); mlx5e_ipsec_init(priv); + mlx5e_psp_register(priv); =20 err =3D mlx5e_macsec_init(priv); if (err) @@ -6230,6 +6229,7 @@ static void mlx5e_nic_disable(struct mlx5e_priv *priv) mlx5_lag_remove_netdev(mdev, priv->netdev); mlx5_vxlan_reset_to_default(mdev->vxlan); mlx5e_macsec_cleanup(priv); + mlx5e_psp_unregister(priv); mlx5e_ipsec_cleanup(priv); } =20 --=20 2.44.0