From nobody Sun Jun 14 01:35:58 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 068C43A7F4D for ; Mon, 4 May 2026 16:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777910992; cv=none; b=lf++EWXW8/Nd0LJLJGPGL7jUc8cHxeovzsOL25r5Rvee0GVprJvgSuwwrSB3R0K7i7zrrakTDb6HnJKp6gbveHk5UdSi5jhfG4CiTkCv5RoBlL68lIonlyFfVK4T/xiDK0/Mgt/Nn03PrXgySQrl+YgCb2TrbIFyw+DNGvDAV7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777910992; c=relaxed/simple; bh=CmTMxazb9aucCLhZKKjA+cLLZtaezjGo/cD+BLSKmaM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=UhSK/I2iwLUp4BHcJULaSsr5M5Bxn9jvoLc7yDHbEAMpWmwgqbCM/d+IINsqesZ95tzgQ3kNsc314xP3V89vvyHP1sSbVOWtJyKZF0VBXHKBkwDK8O4RFHg/G1rv7HuvT5tZOmXHcBzAwTIOzGU5Knzt1WlPyhJ0vbVVuHTVSIM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=Kn22vJNB; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="Kn22vJNB" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso48530445e9.1 for ; Mon, 04 May 2026 09:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777910988; x=1778515788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=r927EdXxquUzRi784TQe7IBsAleX51QDV6fOSE5krwM=; b=Kn22vJNBfl3tCHL7IJQB8uS2fnEHpW3NodYWsq5w3zDI4WW3e0k5727z+RlcweeHfk z4o5CetdCEIEzbVjIjQ/8G/t9BQTIP9yFNjm8ufRxlbDE9VxNcFGl1xfI7OiM0/xwTYM IwNdY8N6yWxl5siJHkfti1sisAoWS0nrbAlMgIIOPfUicf5yRm9qO6XFJwmvAKmVeD63 CKNMuPZGmbZ4OwU3E6yiS1yiIecyDXp0bkzUxLmeHsDuFIT+icvbyo56PWFM4c1gVbIr LyF6fg1qAfu8+GEpWb1/TLuHtrq7XzLCAe4bHNyZ41Qw1IhIwydIp7Krom3Ya4CiMYNB zVgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777910988; x=1778515788; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r927EdXxquUzRi784TQe7IBsAleX51QDV6fOSE5krwM=; b=kJJvnP+3rHJ6tWYH525/mPiZuPlE9cNGqxPiVzOKBOLPRkEpbHgi+3oTs7xJGOjLuo kNz4k/ig97lC2gnYcZ1UfcJ4Qg7STNJj9wEOrOja/yeoeZVC/7kTfNoqRFd4rlCcCzRC 47ckpkyO6FbtQSxCRjMYDga5yIdDakiZ62t97sB5lxAEVi9bXZkXfWTYMVyPqWtomti0 QFB6RQhIU2wNwC0ypveVFBTLG5T21+9+2EOgn1AN8THQFWnN4jvdKGxw2xLQNcD/HVke dk08Q33kiJ+CtqBh5rQ8vIpec4RZ3fWGR6fMQU0PoYkdV8F/amoJhT8lCbAHSxCZcWfu XMWA== X-Forwarded-Encrypted: i=1; AFNElJ/G2KklofmQvNBrGGwTGM2MUc75JQg1ClHrKWUfhVjpgmZP6XJHXDhjUkpeW1l++29Jl9G8tKiTdRsT+64=@vger.kernel.org X-Gm-Message-State: AOJu0YyCw4guvi+Y88EirK2Fk8xdenUYg3VAc3BImd0qiA27Ob4qP2F5 JHMOPe7OT+g31uSc+Ypvyz8nGx9a59+b2kKBw/OMqOiSjoCo7VgwXoW/ORQGZw721Bo= X-Gm-Gg: AeBDieu9X2vuNBc4e7CDU2Du8Q4kyG7A+blUNFw4Kt9Tdu7AXfGYaSyC7mTTpDRgqvH HF1qpZooYWTgNkuBRwtyCJI1s3N9Twh6wiz55h/ZUteOSYoRcgPW9nlmagg9OPl0FNHeEvU04yP Llf1NqyHVhgFYR0IOVXOhv3qygNHwWyB4Mh0LoyrDsNcwW0FNXk3221LVobok5BO0/cAEM2vJlx 7T8eIHj/oa2qthZNIWkasILJD6RG3Yfkv8lCsTW4eVPs0js/ykyKVasc+MTn6nCoE7rvfe/b1up Y2OxDOkMlUzcUxyNvha3opbMtVGDtJ1LJiLjPcQxyI/NwzjWaTqqAlCol4dk+IVJO6mWlh1Q2G4 3k9je7fbd8NiUfydfvmhaDwotUrO4hStVDrxT0jLNkYq7L+5oWTbFjR/1vTkMj7FqtRuli4E/ex udbHYBTHl4fZ6/4K6FS2JIMRWzksnGn4q39lAjq0byeqHk+6Okd+KMTY2dg2OBQ4ixSmpWSs2ML /rupiBIRmkraozzrv3yVbFKNA== X-Received: by 2002:a05:600c:3f06:b0:48a:761:5816 with SMTP id 5b1f17b1804b1-48d1424a351mr2853855e9.8.1777910988389; Mon, 04 May 2026 09:09:48 -0700 (PDT) Received: from localhost (p200300f65f114e08197264a4bf9e813f.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:1972:64a4:bf9e:813f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a8eb75fe8sm289596725e9.8.2026.05.04.09.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 09:09:48 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Sven Peter , Janne Grunau , Neal Gompa , Marcel Holtmann , Luiz Augusto von Dentz Cc: Markus Schneider-Pargmann , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] Bluetooth: hci_bcm4377: Use named initializers for pci_device_id array Date: Mon, 4 May 2026 18:09:40 +0200 Message-ID: <20260504160940.2168650-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2452; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=CmTMxazb9aucCLhZKKjA+cLLZtaezjGo/cD+BLSKmaM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBp+MTETAj4MRLVp6upKPuoUtwbYrRf1PX5wwFma Js/XyqYbzyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafjExAAKCRCPgPtYfRL+ Tt6hB/9GjwroVu3uHf9J5uqO7394zE0RlEuyZHf2ytSxaeZ16RG/COodYGALkZjDEOlV6COy5I1 yQB7Fg68R4mmQOYH7E4RCFHCeYeretFYKljhvo1s+2Aaaym0PmpgIoEmc6LdUNXu6NGoYb0wg20 hes/00WwxShmGb8k20rErHdNWJ4ToOjM3nMqKUbk6PJ328vLDXcIjh5FweI54NuVkibPOgUA4V9 yTF7bM59tVHMc7FFAu2eQW/mWFDOkJDKyYAua9UhUmaXYM0JWpws2CUP8ZZimqurA2t7OrU1+AY zB8QFRTyuHnXjw2lm3Ow4/KWsQhLYy01aID6U6vOHRUCfoW9 X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable Initializing a struct using list initializers is hard to read, compared to that using named initializers is more ideomatic. Convert the macro used to assign values in the driver's pci_device_id array accordingly. This change doesn't introduce any changes to the compiled array on an x86 and an arm64 build. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, this is a preparing change for making struct pci_device_id::driver_data an anonymous union (similar to https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.c= om/). This requires named initializers for .driver_data. But even without that this is a nice cleanup making the macro better readable. Gcc is happy with simplifying the assignment further using PCI_VDEVICE(BROADCOM, BCM ## id ## _DEVICE_ID), but this is a bit fishy because PCI_VDEVICE also assigns .class and .class_mask (using list initializers), so I didn't convert that. Once all pci_device_id use named initializers, the two zeros can be dropped from PCI_VDEVICE and this entry simplified accordingly. Best regards Uwe drivers/bluetooth/hci_bcm4377.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm437= 7.c index 925d0a635945..89c317561bfb 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -2525,11 +2525,12 @@ static const struct bcm4377_hw bcm4377_hw_variants[= ] =3D { }, }; =20 -#define BCM4377_DEVID_ENTRY(id) = \ - { \ - PCI_VENDOR_ID_BROADCOM, BCM##id##_DEVICE_ID, PCI_ANY_ID, \ - PCI_ANY_ID, PCI_CLASS_NETWORK_OTHER << 8, 0xffff00, \ - BCM##id \ +#define BCM4377_DEVID_ENTRY(id) = \ + { \ + PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BCM ## id ## _DEVICE_ID), \ + .class =3D PCI_CLASS_NETWORK_OTHER << 8, \ + .class_mask =3D 0xffff00, \ + .driver_data =3D BCM ## id, \ } =20 static const struct pci_device_id bcm4377_devid_table[] =3D { base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3