From nobody Sun Jun 14 02:34:26 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F583DEFEC for ; Mon, 4 May 2026 15:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777907052; cv=none; b=vCLLdvdM6QSiikioHiTdMxy3Yxfz7flMaqpTOUDJDh3xSjbe0BnKvHt78QVwMQQuKZdZubHr+0S0LBVTxasUM7DUFbCXsxV5lP9aRqqusun+YYrv2nD4E8W4RBvr3f1qw7gLalg6bR3uNFUDEhgs+ACxHebxGbZYqsDp0hlNa/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777907052; c=relaxed/simple; bh=Zt52XDDhonHJAIyeH3TKYgmGMbFia/F7uYhGZrwZ78s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ILJGVVB8WNhWqjE9Czv5HFDy5zBp/bRxz4ArFFjz0Oxtf4JtasxKaB2fYdgyrLNp/c7sGHrTJ9S3PkW1Kpy8PdhT4EyDt99o3fDr3GDTqhpISZn6J6Yx6GHU4+3vYv0xLyoQWhm4awNF7O74isGG+2GVAJBpYZ3MALBZNOGFDrA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=onULxrUM; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="onULxrUM" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-365425c98c6so813016a91.0 for ; Mon, 04 May 2026 08:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777907050; x=1778511850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wBLYio4dSORQ087NCKhszziXEykjpp/cDyPH1+d3fvI=; b=onULxrUMjhzLm5puv1d9pqEJ7vJdbSP4bXgJf7uKfun40OnaOe2HQqhP/cOXhMRoDR pwkWT8q2YT5eDx32wWdPBd7JoRTMpIhrudUF26AjFjX3S5euHFbaFx2q/+SXSKbBGY1C TaT2Gg7asdgr3hEfsg3jnMJ5JsKGArPKLtsswnlDVgintQX6j99Unh6CdU8mZX0Utfxb 52YoExea/B3xc2d3bpFtn2se4ho8WWjOiuWwrM604F/W07GmpzG09ymZqUX4maVps0iF mgP4IrGrKwdgvTh2aSmS077i0dvPJaLmcTliZmY49pkEM/O1zs+9cpdAKYBaOpjqbKW7 W4uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777907050; x=1778511850; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wBLYio4dSORQ087NCKhszziXEykjpp/cDyPH1+d3fvI=; b=Qys0+qaxja5VlPllR15WHKvWQ3FcpgkbIQzkpALWAUd/WWsVJkd3T2sGzo1PZd/Y0E zbM3xMy5vv0oMDkCh1GWZVx4Yr1AoCwswrPk4dwEriieBy4RuFQtQL7zWMuA5wfSs1BS V3JyD16CbVb+cbOXTKdnV9e9ikvE54bfpAGa1UCDrsy8lOacKTWjfmtY0cg4rLMzp7Oh 7J8Gj39+6bYq/MAq7WNN6uThJfOkgRvQH3iNIdJGYsBQr7eivMiTKeFBIGXsJxJK0nRj lip9nv4ncW9UTVVm3Xd2XNh7c1Z6lyJWbwYlxE4WX4wuZsnhwiqvGM0zSLLU33o2RFa3 xQ0Q== X-Forwarded-Encrypted: i=1; AFNElJ9rWZt9PDMu85uXhLuWn2CAYb5w4HQgP5UK2/OJzxt5sl31IurtKPLeq6yivPllTSSc9HlvULz7b0TeInc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/T5OnIUzRylgCr0+qRGNoWTiHzV8DXDArjzky7EXRQYDRnMsg /foqhLegXhm+6+ATKLGDC/GLm3CJzVLteezvtkZEHpTRpu3dPCX3+5tg X-Gm-Gg: AeBDietHnMaXlnTbg4CN1WVL89Qe7JlhnPikyMB59+JmXyJI7KuP0yXWRalEd1fjTAh GIq0YtLqj+2iP6TuC+wpboToPSoQyfCoujMZFkaX/wcO+NlSowhREC3HTpF19n0bdRpGC99mjln vWk//Gf3GZ3297EArzU+cSVgfnvYESQS5a2puVVY5JNXxyleOXAAj5tko/HFJ5BJKemYWnObIDX 1h1UKNqc0uYZcZzyW5IoOG4x7CVbt3YANzTxIz3iKQeF4r/ejku0A2areriHUD3g1j39vR7Cstv R4/hhdgctB0wOmWL7z4geov5r6jDAtpW5cgfFr7nEkTd6dTyJZY/IYcXleeO0cOyIEjo0fHQmvJ QMxIE1XoeasABsDzB4zH7H1lVPsBb3z1FrBoGOpLZOMxkNKQlvzj7zK1C9O8OpNOZe4LOKHTgaF 13WBj4Tvn8gYwe5DanzlHbrCF3CeZcVUmn1Ryaozrqvaj909Mm09WEbHb6RXkYNp1K+zKks1a3C ciUWn7KbCcPD6tVRQ== X-Received: by 2002:a17:90a:d2c7:b0:35a:189b:43db with SMTP id 98e67ed59e1d1-3650ccefbdfmr9350785a91.4.1777907049979; Mon, 04 May 2026 08:04:09 -0700 (PDT) Received: from arch.lan ([2409:40e1:3007:cefc:472f:1ad7:13a6:92d7]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-364f3c55bfasm7325410a91.0.2026.05.04.08.04.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 08:04:09 -0700 (PDT) From: Aadarsh Chandra To: razor@blackwall.org, idosch@nvidia.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, bridge@lists.linux.dev, linux-kernel@vger.kernel.org, Aadarsh Chandra Subject: [PATCH] net: bridge: replace simple_strtoul with kstrtoul Date: Mon, 4 May 2026 20:31:46 +0530 Message-ID: <20260504150146.457562-1-aadarsh.official.xz@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The simple_strtoul() function is deprecated. It does not handle errors or overflows correctly. Replace it with kstrtoul() in brport_store() to ensure that invalid user input is caught and returned as an error. Signed-off-by: Aadarsh Chandra --- net/bridge/br_sysfs_if.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 1f57c36a7fc0..3e948d781970 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -318,7 +318,7 @@ static ssize_t brport_store(struct kobject *kobj, struct net_bridge_port *p =3D kobj_to_brport(kobj); ssize_t ret =3D -EINVAL; unsigned long val; - char *endp; + int err; =20 if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN)) return -EPERM; @@ -339,9 +339,11 @@ static ssize_t brport_store(struct kobject *kobj, spin_unlock_bh(&p->br->lock); kfree(buf_copy); } else if (brport_attr->store) { - val =3D simple_strtoul(buf, &endp, 0); - if (endp =3D=3D buf) + err =3D kstrtoul(buf, 0, &val); + if (err) { + ret =3D err; goto out_unlock; + } spin_lock_bh(&p->br->lock); ret =3D brport_attr->store(p, val); spin_unlock_bh(&p->br->lock); --=20 2.54.0