From nobody Sun Jun 14 02:37:01 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32ABD17BA6 for ; Mon, 4 May 2026 14:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777905215; cv=none; b=tp3AIBOmpeSBEdE1QzTaIBqj94QRLIZGDS5+a0/w9bm0yHke4l8wtVh0uFxKE19JChWcmfQeNe7fq24PgRGj+5SgjODkeWvHFj9/ttRcsaoz6PQeMKCMf8dm1Xuwz1abSzkO7JUfCNDn5DfeAou7ekPqPyORmPNJtOgDId3KJAc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777905215; c=relaxed/simple; bh=oO8KyNjoJNSsmZeeWJ4+k0G0rXSphbl1HtxVrOiH+LA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ertNlAhxRTpxGSq36VMwvr5GwZaJsQsSQvHWMik82c009LfRSEtmPhdrImi6ZV/gYMwW8tz+969rQ1EG1lz3Nz3wCaDSMHg4WUPTs88A6c9cvfmSyA21/38k9FgmpB5rgkLr28f8uY3urvUH3Q++TGmMHBaZ1qICKJadyvYZHQU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=qoEtuc2o; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="qoEtuc2o" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso52144915e9.1 for ; Mon, 04 May 2026 07:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777905211; x=1778510011; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rq5VMlWUp2Vy7zgExgZolthYk9myyCpJYSls89tCW2g=; b=qoEtuc2oaSh3x9yUA7UVH5kMmT+dKHWKmC42ZwBVzskQPRQ92p745//J3kI7U2Evb0 cIJz21gh9nO414stbupTzBY6vipKZJNFHKnre54SYJdR96N6HBOdZkvAQkBtPBIZiWs5 OxiPPUXkcisMxgV3fjr63qM6i0ZFFCZ42IqrhuKKfOCtMuPpn0i+YScdMNaZ9lUjkRG2 Ba2qC8n/I1hi9M66NLlCG7SSzgkAKL9DTFW5/EX2HwBaPwziHMBTv194OCfEBvQ+aIEs q2o4fvTBf/ib/da8TTUXzqL4vq5i5waDCJc05fUFm/mJTr8YRg8Prn2sagnvinyAZUQ2 65eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777905211; x=1778510011; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rq5VMlWUp2Vy7zgExgZolthYk9myyCpJYSls89tCW2g=; b=NXnXVY6V4UM5p9JbpWgvXHRMquLKjxoSXbIAa6rwtM9e4WyIK3/THXJL8CnclLMV0i p/7TzV5Ydy02XtOoE8ZbfT765ZJDDWnlFG6lqaefvIz+RLRnibOaDGJdGS2xgkrgUBTZ Q7PYJf2y/DOTSj1FrL9w9YegzIMAp6g8jkfYKajtTx3ae9JpCOz7p3qTUKEYO+CmcN53 VzSMbdXJf2fMonS6iTBqjYWybHTEtPAUzTBlMxQrXmPsHOFnLaZ5BHZMtxeuiet12NcX e75oCwzSA2KZ9l2M4JXZGbW4hweuIoOIdnYjgCy8qH534NNhbGtmo0wLrUVUnZY+ouFw G27Q== X-Forwarded-Encrypted: i=1; AFNElJ8ovjD3inS+kVTdqLkF7reBv3st8gjpeioMwJaNr2l74Vv9/ulVqVVAwARSqsUxvyjyhCQpDwBYE9gydfE=@vger.kernel.org X-Gm-Message-State: AOJu0YxHS+/O32UpzJ4hYeGYs4svwBGYQPN5loV5/wC6rhEVK+F/oEeK LSgkFkPaoQBArB8/Hn3nU/CBdicWGB96pcn7D3QKDm5i6oh/rZp6FR6UHGx/F0IroIE= X-Gm-Gg: AeBDieu8RcdVMB/QKa6ebBeRYIkkZuDCh4oJtTcB+2maSPB/KS4L78J6H8rKqZuU/1W 3Mu7fI/Uoi1sal+nRlTHTl2AoR3R36QGzkYBlgYUOjGh9z2ouR8ajbe38n/gaz5xXRX0H1oQ1Om JfXl7Xoq4rFAYK3V7UuR6fxA01uLKgHghyHEaWB4XmPz7zkf63+UU2p0VOMbS0C3K+A/+riC9Z8 rEGHHBgSRfvtA3YGDg1/j1d/rcZNCAbezRUKU0tgKEvLR0seCW/pKJFC+lcxI16mOXHBoJBjE10 cweTypO1r5IEdyFIclyuXJiSItlOxhVa/01FaPrLCsAoUFi4AG9VIh/ulwMXmiVZDsAImYHhROh 0rSaxm0bQ8uUffcThYO0H2+3QFCvAniKVslS0FZ5vJTOu2lez0TS1DjXq3TXl9FBQDTc2/bdfiz 0P5bYz8u2Tb0i1NBrcUMM/ScFKiCiIMSGNigLQ6FpXIty8rwk453mePQ0x4Hv/DnpdV4pNahOMD zr9AcsNAJgQHG0IZZqovmidqg== X-Received: by 2002:a05:600c:4e8e:b0:489:6c22:e081 with SMTP id 5b1f17b1804b1-48a980fc4ffmr167408265e9.0.1777905211550; Mon, 04 May 2026 07:33:31 -0700 (PDT) Received: from localhost (p200300f65f114e08197264a4bf9e813f.dip0.t-ipconnect.de. [2003:f6:5f11:4e08:1972:64a4:bf9e:813f]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a8ebc4201sm442193545e9.15.2026.05.04.07.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 07:33:31 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Alexandre Belloni Cc: Markus Schneider-Pargmann , Frank Li , Adrian Hunter , Jarkko Nikula , linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] i3c: Consistently define pci_device_ids using named initializers Date: Mon, 4 May 2026 16:33:15 +0200 Message-ID: <20260504143324.2122737-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=3425; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=oO8KyNjoJNSsmZeeWJ4+k0G0rXSphbl1HtxVrOiH+LA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBp+K40aPILHEqBGJvvoIi6HJJgrD/xh/+qGHlOv XjiDS+JemeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCafiuNAAKCRCPgPtYfRL+ Tj9QCACmC4O8BO4Shkhf4R/Ae5118jImTWW586UZFumOBT2KbN1JiIsUd+DQzJXjw4NM3cVB/DS PczA6x5/XU5FBBn3bWlbZuB+k8raYBuX32aGWSw8IJLydhHOQLehDhAMGqVf6KVvIXQ1SQAObzA mZ7+pbEwPIQ7/pMQo0CjwLrFlSGmLae28KjFL1KMNJWjMuZdfhOlkP1027SGBZPaZyLC6LPiek3 mvNxtglYjyVP1axWOF90JRrbCe/3GO0EMQVnQ8V4pUPNBxDZXKivOuQXpBlAwM3AnQ/SOnim/It +SZ9kVSO7+V6Vm+RiIolg/O13ylRsEQ0+c6L7Jv9+42rqKMA X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable The .driver_data member of the various struct pci_device_id arrays were initialized by list expressions. This isn't easily readable if you're not into PCI. Using named initializers is more explicit and thus easier to parse. This change doesn't introduce changes to the compiled pci_device_id arrays. Tested on x86 and arm64. Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) Reviewed-by: Adrian Hunter Reviewed-by: Frank Li --- Hello, The secret plan is to make struct pci_device_id::driver_data an anonymous union (similar to https://lore.kernel.org/all/cover.1776579304.git.u.kleine-koenig@baylibre.c= om/) and that requires named initializers. But IMHO it's also a nice cleanup on its own. The anonymous union will allow changes like the following: - { PCI_VDEVICE(INTEL, 0x4d7c), .driver_data =3D (kernel_ulong_t)&intel_mi_= 1_info }, + { PCI_VDEVICE(INTEL, 0x4d7c), .driver_data_ptr =3D &intel_mi_1_info }, (together with the respective change in the code when the value is used). This gets rid of a bunch of casts and thus slightly improves type safety. Best regards Uwe .../master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 22 +++++++++---------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i= 3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c index 9468786fb853..5a9e2a43eff8 100644 --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c @@ -461,21 +461,21 @@ static const struct dev_pm_ops mipi_i3c_hci_pci_pm_op= s =3D { =20 static const struct pci_device_id mipi_i3c_hci_pci_devices[] =3D { /* Wildcat Lake-U */ - { PCI_VDEVICE(INTEL, 0x4d7c), (kernel_ulong_t)&intel_mi_1_info}, - { PCI_VDEVICE(INTEL, 0x4d6f), (kernel_ulong_t)&intel_si_2_info}, + { PCI_VDEVICE(INTEL, 0x4d7c), .driver_data =3D (kernel_ulong_t)&intel_mi_= 1_info }, + { PCI_VDEVICE(INTEL, 0x4d6f), .driver_data =3D (kernel_ulong_t)&intel_si_= 2_info }, /* Panther Lake-H */ - { PCI_VDEVICE(INTEL, 0xe37c), (kernel_ulong_t)&intel_mi_1_info}, - { PCI_VDEVICE(INTEL, 0xe36f), (kernel_ulong_t)&intel_si_2_info}, + { PCI_VDEVICE(INTEL, 0xe37c), .driver_data =3D (kernel_ulong_t)&intel_mi_= 1_info }, + { PCI_VDEVICE(INTEL, 0xe36f), .driver_data =3D (kernel_ulong_t)&intel_si_= 2_info }, /* Panther Lake-P */ - { PCI_VDEVICE(INTEL, 0xe47c), (kernel_ulong_t)&intel_mi_1_info}, - { PCI_VDEVICE(INTEL, 0xe46f), (kernel_ulong_t)&intel_si_2_info}, + { PCI_VDEVICE(INTEL, 0xe47c), .driver_data =3D (kernel_ulong_t)&intel_mi_= 1_info }, + { PCI_VDEVICE(INTEL, 0xe46f), .driver_data =3D (kernel_ulong_t)&intel_si_= 2_info }, /* Nova Lake-S */ - { PCI_VDEVICE(INTEL, 0x6e2c), (kernel_ulong_t)&intel_mi_1_info}, - { PCI_VDEVICE(INTEL, 0x6e2d), (kernel_ulong_t)&intel_mi_2_info}, + { PCI_VDEVICE(INTEL, 0x6e2c), .driver_data =3D (kernel_ulong_t)&intel_mi_= 1_info }, + { PCI_VDEVICE(INTEL, 0x6e2d), .driver_data =3D (kernel_ulong_t)&intel_mi_= 2_info }, /* Nova Lake-H */ - { PCI_VDEVICE(INTEL, 0xd37c), (kernel_ulong_t)&intel_mi_1_info}, - { PCI_VDEVICE(INTEL, 0xd36f), (kernel_ulong_t)&intel_mi_2_info}, - { }, + { PCI_VDEVICE(INTEL, 0xd37c), .driver_data =3D (kernel_ulong_t)&intel_mi_= 1_info }, + { PCI_VDEVICE(INTEL, 0xd36f), .driver_data =3D (kernel_ulong_t)&intel_mi_= 2_info }, + { } }; MODULE_DEVICE_TABLE(pci, mipi_i3c_hci_pci_devices); =20 base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3