From nobody Sun Jun 14 04:20:58 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4514D12E1E9; Mon, 4 May 2026 03:05:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777863918; cv=none; b=de2cNs1YzAMkKCJ+B3DuSBuIBuf0OyDspMm6vDU9GM8eptu/MyqDQGr8erTjTT9OXbbq8narb/Zvih2ZicnCzaTGqSkrtdhYuo15sVGLVhfYVToAvVgKYpgXFgH3YRCW7dTGyORlOuPX5H1D18M+7943GcE6kcqjUOfjgDh2gt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777863918; c=relaxed/simple; bh=9pxw8TIXiYKJi6FpQ6PR78pTXHpgZS2ftTOQekB9cZw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BZljb8BH5e8Ze64tPq6L5CPql0+O8LHWC1OC8x/DUKEg5dPbBKzs2am40EO4yTP3P5449hc2PKwp46vnemXeOLfirLm51tytThWdabkie4qGONvDDnt7gkFUlflRMyh9DUEqDHWdYvg64YO2RTcLamrKmS5wIzMAJTrPOo85HHA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ZcwuAIDm; arc=none smtp.client-ip=117.135.210.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ZcwuAIDm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=3Q 52N1mN2dv3Klgf2FaKpZ8Hywqsfi3n01dYcdM87ww=; b=ZcwuAIDmQxIUYG3K0B ktuuJs26gslYTEGz8wwG7m/oUvpRaBh0oqzaEEQdNMOvSw02WC/zrfjFBqCPWYNk xR7DB2sDi8Q/lrqWsODTN/CmuchJlFEBkrfDl58L4ofqpvjmM5nuhHWOJZA2noRl KRuhfwoliPEdf7EptbJBWKYTE= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wBntLOwDPhpacQZDQ--.45044S3; Mon, 04 May 2026 11:04:29 +0800 (CST) From: Miao Li To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, dixitparmar19@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, limiao870622@163.com, Miao Li Subject: [PATCH v4 1/3] iio: light: stk3310: Deal with the ps interrupt issue in PM Date: Mon, 4 May 2026 11:04:06 +0800 Message-Id: <20260504030408.105762-2-limiao870622@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260504030408.105762-1-limiao870622@163.com> References: <20260504030408.105762-1-limiao870622@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBntLOwDPhpacQZDQ--.45044S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxury8CF13uF45Ary7GF4Durg_yoWrAF1DpF WUCF45trW7Gws7GrZxJF1DZF90g3yxt343AayfGw1Ivr1akr98Kr1fJFWxXFnY9ryjya1U JF4vvayYkr4qqaUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zN4E_UUUUUU= X-CM-SenderInfo: 5olpxtbryxiliss6il2tof0z/xtbCzh3KmGn4DL0OnwAA3w Content-Type: text/plain; charset="utf-8" From: Miao Li On the Inspur HS326 laptop(which integrated with HiSilicon M900 processor), if the STK3311-X chip's PS interrupt is configured in "Recommended interrupt mode", the interrupt cannot be triggered normally after waking from suspend or hibernation. In this case, neither disabling and re-enabling the interrupt nor resetting the PS threshold register can restore the interrupt to normal operation. If the interrupt is disabled in suspend() then reset the PS threshold register and enable the interrupt in resume(). This resolves the issue. Signed-off-by: Miao Li --- drivers/iio/light/stk3310.c | 72 ++++++++++++++++++++++++++++++++++--- 1 file changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index a75a83594..86cc6e8ec 100644 --- a/drivers/iio/light/stk3310.c +++ b/drivers/iio/light/stk3310.c @@ -117,6 +117,9 @@ struct stk3310_data { struct mutex lock; bool als_enabled; bool ps_enabled; + bool ps_int_enabled; + uint32_t ps_thdl; + uint32_t ps_thdh; uint32_t ps_near_level; u64 timestamp; struct regmap *regmap; @@ -296,8 +299,15 @@ static int stk3310_write_event(struct iio_dev *indio_d= ev, =20 buf =3D cpu_to_be16(val); ret =3D regmap_bulk_write(data->regmap, reg, &buf, 2); - if (ret < 0) + if (ret < 0) { dev_err(&client->dev, "failed to set PS threshold!\n"); + return ret; + } + + if (reg =3D=3D STK3310_REG_THDH_PS) + data->ps_thdh =3D val; + else + data->ps_thdl =3D val; =20 return ret; } @@ -331,8 +341,14 @@ static int stk3310_write_event_config(struct iio_dev *= indio_dev, /* Set INT_PS value */ mutex_lock(&data->lock); ret =3D regmap_field_write(data->reg_int_ps, state); - if (ret < 0) + if (ret < 0) { dev_err(&client->dev, "failed to set interrupt mode\n"); + mutex_unlock(&data->lock); + return ret; + } + + data->ps_int_enabled =3D state; + mutex_unlock(&data->lock); =20 return ret; @@ -504,10 +520,15 @@ static int stk3310_init(struct iio_dev *indio_dev) =20 /* Enable PS interrupts */ ret =3D regmap_field_write(data->reg_int_ps, STK3310_PSINT_EN); - if (ret < 0) + if (ret < 0) { dev_err(&client->dev, "failed to enable interrupts!\n"); + return ret; + } =20 - return ret; + data->ps_int_enabled =3D true; + data->ps_thdh =3D STK3310_PS_MAX_VAL; + + return 0; } =20 static bool stk3310_is_volatile_reg(struct device *dev, unsigned int reg) @@ -671,9 +692,18 @@ static void stk3310_remove(struct i2c_client *client) static int stk3310_suspend(struct device *dev) { struct stk3310_data *data; + int ret; =20 data =3D iio_priv(i2c_get_clientdata(to_i2c_client(dev))); =20 + if (data->ps_int_enabled) { + ret =3D regmap_field_write(data->reg_int_ps, 0x0); + if (ret < 0) { + dev_err(dev, "failed to disable ps int at suspend.\n"); + return ret; + } + } + return stk3310_set_state(data, STK3310_STATE_STANDBY); } =20 @@ -681,6 +711,8 @@ static int stk3310_resume(struct device *dev) { u8 state =3D 0; struct stk3310_data *data; + __be16 buf; + int ret; =20 data =3D iio_priv(i2c_get_clientdata(to_i2c_client(dev))); if (data->ps_enabled) @@ -688,7 +720,37 @@ static int stk3310_resume(struct device *dev) if (data->als_enabled) state |=3D STK3310_STATE_EN_ALS; =20 - return stk3310_set_state(data, state); + ret =3D stk3310_set_state(data, state); + if (ret < 0) + return ret; + + if (data->ps_thdl !=3D 0x0) { + buf =3D cpu_to_be16(data->ps_thdl); + ret =3D regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, 2); + if (ret < 0) { + dev_err(dev, "failed to set reg THDL_PS at resume.\n"); + return ret; + } + } + + if (data->ps_thdh !=3D STK3310_PS_MAX_VAL) { + buf =3D cpu_to_be16(data->ps_thdh); + ret =3D regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, 2); + if (ret < 0) { + dev_err(dev, "failed to set reg THDH_PS at resume.\n"); + return ret; + } + } + + if (data->ps_int_enabled) { + ret =3D regmap_field_write(data->reg_int_ps, STK3310_PSINT_EN); + if (ret < 0) { + dev_err(dev, "failed to enable ps int at resume.\n"); + return ret; + } + } + + return 0; } =20 static DEFINE_SIMPLE_DEV_PM_OPS(stk3310_pm_ops, stk3310_suspend, --=20 2.25.1 From nobody Sun Jun 14 04:20:58 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6673118A6CF; Mon, 4 May 2026 03:05:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.2 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777863924; cv=none; b=VXme9KvVM7gx/erZGATVXsAaKgADpjEizxxJvL5OS1lwYQQItJznp+w0En2rH3jGf0Q3pzx2lpXK/qGfWq8vKa6o7JhkP1VmTnBryBRCugA79q7GIf4jfetvGk/FAzOb5LWs8Ob5eM0uNzpbGP970rxGA2wlaxNYJQqUJYxsQzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777863924; c=relaxed/simple; bh=4tUDiHewklMnnYJsJxoxFTvpGCB/TtqtG6K/kMknxcM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GdgkOxWMNUqeoS5xvZy9bE4Vd8+OpNX7/QlDlFHBWtmpJ2OZBMOcu0JJCJGebwvD6LCLxCJVBBWr381u8sTfQa59m9OaFu6pVMY9UkPKKFmt0Uv0MEAQf3mprN/P4HW6fTQ8MMFHAu13E2rKmUCbuSTju6JLlabDocc/Q2j3Ezg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=JpO+Qs2o; arc=none smtp.client-ip=117.135.210.2 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="JpO+Qs2o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=ma w8hV/NSqLcLCp/h6NnoRC6tg/lPAJ5qVCp8kuy+Q4=; b=JpO+Qs2oRMa4Yl+qT5 b2r7M3Rtinif233b3JHa90Hu24DyWS5kVxQFXaYHU4B9jNFNX1seNP8sYP5VYeo+ mKmdaD9u8T9ZENvd0kvcyk+2zU4StEk4WZkbFnHxp/NAMQXms4RP0twXJRhVllV3 KfMJpRPBKpfBMcnShw5pQKCAI= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wBntLOwDPhpacQZDQ--.45044S4; Mon, 04 May 2026 11:04:43 +0800 (CST) From: Miao Li To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, dixitparmar19@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, limiao870622@163.com, Miao Li , Andy Shevchenko Subject: [PATCH v4 2/3] iio: light: stk3310: Replace uint32_t with u32 and reorder members to eliminate padding Date: Mon, 4 May 2026 11:04:07 +0800 Message-Id: <20260504030408.105762-3-limiao870622@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260504030408.105762-1-limiao870622@163.com> References: <20260504030408.105762-1-limiao870622@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBntLOwDPhpacQZDQ--.45044S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cr4UXr4kCF1DAF1Dtw1xuFg_yoW8Gr18pF s8J34SyFW7WFWkWrnrJr4jvFyYq3yfJa4akFWUXw1avF4avr1qkF18JFyxCFnIgryUCa47 Jw4v9FWUCa1jk3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zMksqUUUUUU= X-CM-SenderInfo: 5olpxtbryxiliss6il2tof0z/xtbC7wzOnGn4DMwj-QAA3+ Content-Type: text/plain; charset="utf-8" From: Miao Li Replace the uint32_t type members in the stk3310_data structure with u32 to adhere to the unified kernel coding style, and reorder the member variables to eliminate memory padding holes. Suggested-by: Andy Shevchenko Signed-off-by: Miao Li Reviewed-by: Andy Shevchenko Reviewed-by: Joshua Crofts --- drivers/iio/light/stk3310.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index 86cc6e8ec..0447fbf1b 100644 --- a/drivers/iio/light/stk3310.c +++ b/drivers/iio/light/stk3310.c @@ -115,12 +115,6 @@ static const int stk3310_it_table[][2] =3D { struct stk3310_data { struct i2c_client *client; struct mutex lock; - bool als_enabled; - bool ps_enabled; - bool ps_int_enabled; - uint32_t ps_thdl; - uint32_t ps_thdh; - uint32_t ps_near_level; u64 timestamp; struct regmap *regmap; struct regmap_field *reg_state; @@ -131,6 +125,12 @@ struct stk3310_data { struct regmap_field *reg_int_ps; struct regmap_field *reg_flag_psint; struct regmap_field *reg_flag_nf; + u32 ps_thdl; + u32 ps_thdh; + u32 ps_near_level; + bool als_enabled; + bool ps_enabled; + bool ps_int_enabled; }; =20 static const struct iio_event_spec stk3310_events[] =3D { --=20 2.25.1 From nobody Sun Jun 14 04:20:58 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5641A6809; Mon, 4 May 2026 03:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777863937; cv=none; b=UsMQLU9veLQC5AGsfiJZodh5Q44Cn954eqM+ypR0Ga88SnW2whX0EzyRkV1PM+0tg30bTBnK8tZ0fLKdNAMgHHoGjawruGVRgg/MmvbHVvP+p3KNX3XIpU+LaCElNzDz+OgegK+CKpd7iMItTOePQo/CJFWtXNHQYHFUBYoPIGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777863937; c=relaxed/simple; bh=TpJXrsPeqoXcwn0q9vDCIUCH4w4ndcfIVo0mhk+excU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TsBtc1Vbx3Ah/9bXqYb1GjzUCDniVTElBPGryUv5w++oK/y6UNG/UkM4ACEiXN/xT2kpmBLf99hE8RMNAT0hfA9bvl/AoWRS44rIg+S+yapdL0OdBneB510Fc/67hL9eS9h3hoEeLk+0W9zA3Bj8v9QFOp+EAMDiui+uYSEb3xc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=EUnc4h4o; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="EUnc4h4o" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=6t UPptFaHEBspNfHSUpHFM670LP0ib23VlHZnVbovYY=; b=EUnc4h4og/juiSyeNC RpDgVRabIOYP1bKn7vjCn8PGYkyuDdDTG4LJQmx0OQLVXOwuy/nYMKt5nnMoPopz zyMPAbSJALRw6OMixonABPbjBytEAIEH7R9iAY8gqjck/n42erAFh1qAWaZbOiP2 MnwM3PZtHgssqa+43HPxugyEQ= Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wBntLOwDPhpacQZDQ--.45044S5; Mon, 04 May 2026 11:04:48 +0800 (CST) From: Miao Li To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, waqar.hameed@axis.com, dixitparmar19@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, limiao870622@163.com, Miao Li Subject: [PATCH v4 3/3] iio: light: stk3310: Use sizeof() for regmap_bulk_read/write count parameter Date: Mon, 4 May 2026 11:04:08 +0800 Message-Id: <20260504030408.105762-4-limiao870622@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260504030408.105762-1-limiao870622@163.com> References: <20260504030408.105762-1-limiao870622@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wBntLOwDPhpacQZDQ--.45044S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWxXryDXw48Aw1fKFWkCrg_yoW5JFW3pF WUAFZxCrW7Z3Z7ur1qyF4DuFyjq347K3W3A3y8G3WIvr90yr9xKFW5AFWfXF93urWxZa18 Jw4v9FWFyF4qqr7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zKsjUbUUUUU= X-CM-SenderInfo: 5olpxtbryxiliss6il2tof0z/xtbC8BPPnWn4DNMtAQAA3T Content-Type: text/plain; charset="utf-8" From: Miao Li Convert the hardcoded count parameter to sizeof(buf) for all regmap_bulk_write() and regmap_bulk_read() calls in this driver to improve code maintainability. For details, see [1]. [1] https://lore.kernel.org/all/20260428192213.7c5c80e5@jic23-huawei/ Signed-off-by: Miao Li Reviewed-by: Joshua Crofts --- drivers/iio/light/stk3310.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index 0447fbf1b..74ee75721 100644 --- a/drivers/iio/light/stk3310.c +++ b/drivers/iio/light/stk3310.c @@ -258,7 +258,7 @@ static int stk3310_read_event(struct iio_dev *indio_dev, return -EINVAL; =20 mutex_lock(&data->lock); - ret =3D regmap_bulk_read(data->regmap, reg, &buf, 2); + ret =3D regmap_bulk_read(data->regmap, reg, &buf, sizeof(buf)); mutex_unlock(&data->lock); if (ret < 0) { dev_err(&data->client->dev, "register read failed\n"); @@ -298,7 +298,7 @@ static int stk3310_write_event(struct iio_dev *indio_de= v, return -EINVAL; =20 buf =3D cpu_to_be16(val); - ret =3D regmap_bulk_write(data->regmap, reg, &buf, 2); + ret =3D regmap_bulk_write(data->regmap, reg, &buf, sizeof(buf)); if (ret < 0) { dev_err(&client->dev, "failed to set PS threshold!\n"); return ret; @@ -376,7 +376,7 @@ static int stk3310_read_raw(struct iio_dev *indio_dev, reg =3D STK3310_REG_PS_DATA_MSB; =20 mutex_lock(&data->lock); - ret =3D regmap_bulk_read(data->regmap, reg, &buf, 2); + ret =3D regmap_bulk_read(data->regmap, reg, &buf, sizeof(buf)); if (ret < 0) { dev_err(&client->dev, "register read failed\n"); mutex_unlock(&data->lock); @@ -726,7 +726,7 @@ static int stk3310_resume(struct device *dev) =20 if (data->ps_thdl !=3D 0x0) { buf =3D cpu_to_be16(data->ps_thdl); - ret =3D regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, 2); + ret =3D regmap_bulk_write(data->regmap, STK3310_REG_THDL_PS, &buf, sizeo= f(buf)); if (ret < 0) { dev_err(dev, "failed to set reg THDL_PS at resume.\n"); return ret; @@ -735,7 +735,7 @@ static int stk3310_resume(struct device *dev) =20 if (data->ps_thdh !=3D STK3310_PS_MAX_VAL) { buf =3D cpu_to_be16(data->ps_thdh); - ret =3D regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, 2); + ret =3D regmap_bulk_write(data->regmap, STK3310_REG_THDH_PS, &buf, sizeo= f(buf)); if (ret < 0) { dev_err(dev, "failed to set reg THDH_PS at resume.\n"); return ret; --=20 2.25.1