From nobody Sun Jun 14 01:35:51 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D00935F5E2 for ; Mon, 4 May 2026 22:50:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777935011; cv=none; b=C/zgP2mvJ4p7HsIj4/IL5evaidgzKehuo6jUrHjZVUB7AhfArvnfzxTeYXlF2r3RZuKvfgXanJpGX8oqXch38TtL1p/TQqIhVHH7GdjbYvAJ82gSkFiPZJ5DlHsYCdDCQmCVSFQmRFlYwHRQGY2Vparn7FExRFmUjE8zrfJlXSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777935011; c=relaxed/simple; bh=sRwm00O3EwLuFbxFFfRqGiXjTV+StXg8nAJqij88Ne0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=l+mHMFXRaDHdTtZWdrkVpoDxxOl5LD8ueJGEpxUL9326j4SuoLkrwXzIbQOu35m0TSLzyapZtHtBZGCCZ2jwopxE88+fx+m58cS0kYjR+mfpylQtK7NnKOr3lRHdem6f8//YLWlvsm7DVDJVHIeorH2jpfsOfGxtKfBW4HdKz7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pIq+CS54; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pIq+CS54" Received: by smtp.kernel.org (Postfix) with ESMTPS id 91935C2BCB8; Mon, 4 May 2026 22:50:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777935010; bh=sRwm00O3EwLuFbxFFfRqGiXjTV+StXg8nAJqij88Ne0=; h=From:Date:Subject:To:Cc:Reply-To:From; b=pIq+CS54clw/8r8oo5i1IcZ0VEkkNMpWthmNvIMspr+9pKxHnwwXxwyFueppRP/mK qSsXYq7Z5I8p0RSuExZeL53zy7BDkwdiuhtoMREgXCSox1kyIAHQocs0Ffv3qULPxd Nq1a2ydn3O3vdKgjrbhyFF5eWd9shq12WVd1tck3A1phpry0KjHeL6to2sln3pi4Aw MLbDG5mG5O33Wnhee8BRX5ftmL0IRKZhoHbwlxmJXRnjbwQWKI6KFk9JYtR4swKx+6 OUxUDFE4/Yapor0UiM6Agy8WRuZHCz6PDp1NjB+7//sdYQunyPabou6BXCYNlX295h XuwiuEapnCIhQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81F74CD3427; Mon, 4 May 2026 22:50:10 +0000 (UTC) From: Amit Sunil Dhamne via B4 Relay Date: Mon, 04 May 2026 22:49:54 +0000 Subject: [PATCH] mfd: max77759: style improvements Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260504-fix-mfd-max77759-driver-v1-1-4d4a31a1d214@google.com> X-B4-Tracking: v=1; b=H4sIAJEi+WkC/x2MSQqAMAwAvyI5G4hFrfoV8VBN1BxcSEEE8e8Wj wMz80AUU4nQZQ+YXBr12BMUeQbTGvZFUDkxOHI1VVTirDduM+MWbu991SKbXmJYjBw8kXNTw5D q0ySp/7kf3vcDeoHatmkAAAA= X-Change-ID: 20260504-fix-mfd-max77759-driver-1bda70022c8d To: =?utf-8?q?Andr=C3=A9_Draszik?= , Lee Jones Cc: linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Amit Sunil Dhamne X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777935008; l=5271; i=amitsd@google.com; s=20241031; h=from:subject:message-id; bh=aPyuzQ0035OvtZDjAvztZ+5vXLvUda5StuV95eB4tvM=; b=Pts9NkVWU4D2nTVOtS86s5Y8naHRYYW0Gc3yBlJOWUKvTZjMRUEeYTmI+n72RacqhTflU5dYA 3DP375xiXGXCEQYsRkzFdc9dXpeKFuxvNsGOV+MeZYGS8AD4rR5OOqx X-Developer-Key: i=amitsd@google.com; a=ed25519; pk=wD+XZSST4dmnNZf62/lqJpLm7fiyT8iv462zmQ3H6bI= X-Endpoint-Received: by B4 Relay for amitsd@google.com/20241031 with auth_id=262 X-Original-From: Amit Sunil Dhamne Reply-To: amitsd@google.com From: Amit Sunil Dhamne Improve code style. This includes the following: - Formatting the max77759_chgr_irqs entries to fit in a single line instead of breaking them into multiple lines to improve readability. - Refactoring comments such that they're full sentences and have punctuation marks for a couple of macro definitions to adhere to the documentation style. - Explicitly initializing `MAX77759_CHGR_MODE_OFF`. Signed-off-by: Amit Sunil Dhamne --- Context: https://lore.kernel.org/all/20260424082639.GI170138@google.com/ --- drivers/mfd/max77759.c | 48 +++++++++++++++-------------------------= ---- include/linux/mfd/max77759.h | 6 +++--- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/drivers/mfd/max77759.c b/drivers/mfd/max77759.c index 9fa6027a92c4..b50433e7b3d3 100644 --- a/drivers/mfd/max77759.c +++ b/drivers/mfd/max77759.c @@ -286,38 +286,22 @@ static const struct regmap_irq max77759_topsys_irqs[]= =3D { }; =20 static const struct regmap_irq max77759_chgr_irqs[] =3D { - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_AICL, 0, - MAX77759_CHGR_REG_CHG_INT_AICL), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_CHGIN, 0, - MAX77759_CHGR_REG_CHG_INT_CHGIN), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_WCIN, 0, - MAX77759_CHGR_REG_CHG_INT_WCIN), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_CHG, 0, - MAX77759_CHGR_REG_CHG_INT_CHG), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_BAT, 0, - MAX77759_CHGR_REG_CHG_INT_BAT), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_INLIM, 0, - MAX77759_CHGR_REG_CHG_INT_INLIM), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_THM2, 0, - MAX77759_CHGR_REG_CHG_INT_THM2), - REGMAP_IRQ_REG(MAX77759_CHGR_INT1_BYP, 0, - MAX77759_CHGR_REG_CHG_INT_BYP), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_INSEL, 1, - MAX77759_CHGR_REG_CHG_INT2_INSEL), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_SYS_UVLO1, 1, - MAX77759_CHGR_REG_CHG_INT2_SYS_UVLO1), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_SYS_UVLO2, 1, - MAX77759_CHGR_REG_CHG_INT2_SYS_UVLO2), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_BAT_OILO, 1, - MAX77759_CHGR_REG_CHG_INT2_BAT_OILO), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_CC, 1, - MAX77759_CHGR_REG_CHG_INT2_CHG_STA_CC), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_CV, 1, - MAX77759_CHGR_REG_CHG_INT2_CHG_STA_CV), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_TO, 1, - MAX77759_CHGR_REG_CHG_INT2_CHG_STA_TO), - REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_DONE, 1, - MAX77759_CHGR_REG_CHG_INT2_CHG_STA_DONE), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_AICL, 0, MAX77759_CHGR_REG_CHG_INT_AICL= ), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_CHGIN, 0, MAX77759_CHGR_REG_CHG_INT_CHG= IN), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_WCIN, 0, MAX77759_CHGR_REG_CHG_INT_WCIN= ), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_CHG, 0, MAX77759_CHGR_REG_CHG_INT_CHG), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_BAT, 0, MAX77759_CHGR_REG_CHG_INT_BAT), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_INLIM, 0, MAX77759_CHGR_REG_CHG_INT_INL= IM), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_THM2, 0, MAX77759_CHGR_REG_CHG_INT_THM2= ), + REGMAP_IRQ_REG(MAX77759_CHGR_INT1_BYP, 0, MAX77759_CHGR_REG_CHG_INT_BYP), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_INSEL, 1, MAX77759_CHGR_REG_CHG_INT2_IN= SEL), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_SYS_UVLO1, 1, MAX77759_CHGR_REG_CHG_INT= 2_SYS_UVLO1), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_SYS_UVLO2, 1, MAX77759_CHGR_REG_CHG_INT= 2_SYS_UVLO2), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_BAT_OILO, 1, MAX77759_CHGR_REG_CHG_INT2= _BAT_OILO), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_CC, 1, MAX77759_CHGR_REG_CHG_IN= T2_CHG_STA_CC), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_CV, 1, MAX77759_CHGR_REG_CHG_IN= T2_CHG_STA_CV), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_TO, 1, MAX77759_CHGR_REG_CHG_IN= T2_CHG_STA_TO), + REGMAP_IRQ_REG(MAX77759_CHGR_INT2_CHG_STA_DONE, 1, MAX77759_CHGR_REG_CHG_= INT2_CHG_STA_DONE), }; =20 static const struct regmap_irq_chip max77759_pmic_irq_chip =3D { diff --git a/include/linux/mfd/max77759.h b/include/linux/mfd/max77759.h index ec19be952877..7c0b13219d51 100644 --- a/include/linux/mfd/max77759.h +++ b/include/linux/mfd/max77759.h @@ -106,9 +106,9 @@ #define MAX77759_CHGR_REG_CHG_CNFG_10 0xc3 #define MAX77759_CHGR_REG_CHG_CNFG_11 0xc4 #define MAX77759_CHGR_REG_CHG_CNFG_12 0xc5 -/* Wireless Charging input channel select */ +/* Setting this enables the Wireless Charging input channel. */ #define MAX77759_CHGR_REG_CHG_CNFG_12_WCINSEL BIT(6) -/* CHGIN/USB input channel select */ +/* Setting this enables the CHGIN/USB input channel. */ #define MAX77759_CHGR_REG_CHG_CNFG_12_CHGINSEL BIT(5) #define MAX77759_CHGR_REG_CHG_CNFG_13 0xc6 #define MAX77759_CHGR_REG_CHG_CNFG_14 0xc7 @@ -204,7 +204,7 @@ enum max77759_chgr_chg_dtls_states { }; =20 enum max77759_chgr_mode { - MAX77759_CHGR_MODE_OFF, + MAX77759_CHGR_MODE_OFF =3D 0x0, MAX77759_CHGR_MODE_CHG_BUCK_ON =3D 0x5, MAX77759_CHGR_MODE_OTG_BOOST_ON =3D 0xA, }; --- base-commit: 57b8e2d666a31fa201432d58f5fe3469a0dd83ba change-id: 20260504-fix-mfd-max77759-driver-1bda70022c8d Best regards, --=20 Amit Sunil Dhamne