From nobody Sun Jun 14 04:20:15 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6F683A63F7 for ; Sun, 3 May 2026 21:09:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777842567; cv=none; b=Urc1yLDHZWhUMn29sIbqDaguMjCPgjELflnp5OQllbbG/LPJn6wu6RK4sUCgbtv8aMn1qkzAzMGJgWhsKCfXbhFkXatJSvj1vlWTTPL9poxIfZlwqvEn9XSOS2mAGaJX+3lOqYAQQqn60lsnClgFtRySeY2fkjHkqYI/7joh8ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777842567; c=relaxed/simple; bh=0newPD3N/3WFEW40SIqlPKlRbdyu8K9sCI4I1XiRtac=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lON2yVZGJaPAiNRljsxVHRdWT3M+YQmrXV4+mXRRfIDK4paOZJaqhZdmz/OMoav4vDalcLO5gmumJWOJQ7BzqhHy+5UQhG5ld28O0h6Qy0EWgPfu6vjQfuQ8aj3tV2oOJ9zYXoh1YTSS2XuA3b9pupzUyUn0K+oKVG9sRnuPEkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DiE3NxpS; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=XKYzwHBi; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DiE3NxpS"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="XKYzwHBi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777842564; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=kk2Au5rLiT2XVCKBKjlR9NIFRQn0TrH+r2EEhpbdibY=; b=DiE3NxpSR/4JmtxuSaIhLXP3kogUIVvRGn3mvH3nXMkF8weoWAQj3XWlxibK4iZSXJqie4 SoqLDAC3tYfwWhDlE/oqD9SE/ix+VvPlNTN2fbl4S9MhcZzEUTKcTYqWVUbo+3qJq28Mft mv1f8ih8gxSULSdSnup40n4PdfE7w2U= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-KGYzS82jMsynN77eCHchrw-1; Sun, 03 May 2026 17:09:23 -0400 X-MC-Unique: KGYzS82jMsynN77eCHchrw-1 X-Mimecast-MFC-AGG-ID: KGYzS82jMsynN77eCHchrw_1777842562 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4837b6f6b93so39828305e9.3 for ; Sun, 03 May 2026 14:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1777842562; x=1778447362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kk2Au5rLiT2XVCKBKjlR9NIFRQn0TrH+r2EEhpbdibY=; b=XKYzwHBiNFvaucI8vJy/ldiWYEFWbJaaUCXk/TjW3Vc77TT41Ln4pV78fNYRB2Sdwy BatAbiiwQI2iK5H96uM34WOCTMHFGc82o6OCvu/FlxX3BemiagZEKgomhtLdaAVTMrW7 j8DYuUKoT2MS1+doDEjhp2/XQ4I2eHUiLLVme7VTKVWxPAWusEfDPkIn120B/qua+0i4 q8/upFoX69nrxVOY4vi9An+NOOYvG0/w02zWKvMsbcjg0ZtGCskK/4IbJTncXkzj654s Os56UL3WK4HfaaOza/a0o2YVyt88IQY2J1jFKGgAfd70z029/io5cH/etGCSmeWReHf3 c+bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777842562; x=1778447362; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kk2Au5rLiT2XVCKBKjlR9NIFRQn0TrH+r2EEhpbdibY=; b=r8GwPdWfxBeUoS2516a4LclVfEkTIU9XVz3PEpzjPbiU8/2pZ9qudceTbDYdbCIhED 3omIgQh1lTvI7SAqZ6BOtSbTz3OhNIXOSlnl6RG+ciAXtO+Aw52uNyAx2vM7nVeJIgnp /h/4+5IKzRkLhdlBOjHlibJ+CA3tqYqKrchmuwiLxtfOdoP9qeF2e+bEQ3asWitPJ/o5 bxi+4jOH65F02tstxeY4NenLhry4iHABma+pDil+EZq2BVMEgKvrgECpgoEoFdEipdov c9wC9Ve4zCpkZaVnR1/Rabh8BVQYtmrXrlondvwTVXy4zbke+yO9irH2RNt5q0VxQiEv IzMg== X-Gm-Message-State: AOJu0YzDeEvL0nk/XssdWbc54PBb5i0Ffj6i8oR10St/+HV43E5TsV27 IvyKRdQN3h4fogZOyvo9jVpsxdyaj/fOEDLXi9b11jtITRF2vYppElSNumnf40RGhZM2RkL0wDc /m+52kj+F82UZIVd51yETmTL2h4nGknjX6pxTaI0+KPxJa/iw+Ur0bVCApUp01DixqFhTJ16yXs gUS8RILbcI4PkcatQnt9HPRKaJZcSFC3fAKL9/URa24DdvqyoSBQ== X-Gm-Gg: AeBDiesgjGskt0pGxghjDAUgaaZAcDDkWaguFU2oWI8kZHvl1Ok1LEoUvlxgis/7DaI MqUYGlRkYAO7puQclpwvE8boFOr0w+kxpll3M9Tpkqh9NovONkKdxRQsfzTIGBXwr2SmAghyVv1 Qra6tRIkOkhICeFzxLPR31egetg+onbI0JBTq3oKhmvLckwqFXxRjOk9PazEmUkgRUVgfmByYyw sgLp1xKc6pLAMBQ4Jvqb7mquY3PVU2mYsisJfqHmmKY4V9K2YzxXXncvm2nIRmHX7LgvSv84LBS r15gYUAFyt30/+vhCyQEdUOloQnJ6p+3tcNJNu8gh8mHIFz7WOCXTw+r9wTLkqfKO5cPWeTlgrv NVV3wkYq8HatRMdHWLEbNhcONJ4DLER0PasXyI6lVNdFuSRmyrvqJQ7GC9s2g46WuzKWLg4//S6 OtU7+lNdBSrmypnb6RjSmkzCJNwBN+xVIEkyY= X-Received: by 2002:a05:600c:a402:b0:489:a4:e555 with SMTP id 5b1f17b1804b1-48a9866064dmr90338485e9.21.1777842561970; Sun, 03 May 2026 14:09:21 -0700 (PDT) X-Received: by 2002:a05:600c:a402:b0:489:a4:e555 with SMTP id 5b1f17b1804b1-48a9866064dmr90338255e9.21.1777842561538; Sun, 03 May 2026 14:09:21 -0700 (PDT) Received: from [192.168.10.48] ([151.49.85.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fee4db3sm64634675e9.23.2026.05.03.14.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 14:09:20 -0700 (PDT) From: Paolo Bonzini To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com Subject: [PATCH] KVM: x86: use again the flush argument of __link_shadow_page() Date: Sun, 3 May 2026 23:09:17 +0200 Message-ID: <20260503210917.121840-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Except in the case of parentless nested-TDP pages, mmu_page_zap_pte() clears the SPTE but leaves the invalid_list empty. In this case, using kvm_flush_remote_tlbs() as kvm_mmu_remote_flush_or_zap() does is overkill. Avoid flushing the entirety of the remote TLBs unless the invalid_list was populated: instead, use a more efficient gfn-targeting flush (if available) and skip it altogether if the caller guarantees that a TLB flush is not necessary. Based-on: <20260503201029.106481-1-pbonzini@redhat.com> Signed-off-by: Paolo Bonzini Reviewed-by: Sean Christopherson --- arch/x86/kvm/mmu/mmu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 892246204435..85bec8eeace8 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -2541,8 +2541,10 @@ static void __link_shadow_page(struct kvm *kvm, parent_sp =3D sptep_to_sp(sptep); WARN_ON_ONCE(parent_sp->role.level =3D=3D PG_LEVEL_4K); =20 - mmu_page_zap_pte(kvm, parent_sp, sptep, &invalid_list); - kvm_mmu_remote_flush_or_zap(kvm, &invalid_list, true); + if (mmu_page_zap_pte(kvm, parent_sp, sptep, &invalid_list)) + kvm_mmu_commit_zap_page(kvm, &invalid_list); + else if (flush) + kvm_flush_remote_tlbs_sptep(kvm, sptep); } =20 spte =3D make_nonleaf_spte(sp->spt, sp_ad_disabled(sp)); --=20 2.54.0