From nobody Sun Jun 14 04:10:28 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14E7B1A681B for ; Sun, 3 May 2026 19:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777834823; cv=none; b=nc2zgtGOjn8WwDVLXozcoBhA+10LQtSwLm5MetRY/rShZ8e4rKEB0fxM80dl2FMvX3AIL9AL9Kvuc7Pr3+0NYrXdoa40D6I0HkjIXYrRhnoZElzdPJ1iyF6IIVZRATSGN10tbnLUaMspBQlnYgI+aEeakGbr9k5ilMZxkJZP9q0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777834823; c=relaxed/simple; bh=o6F3nF2O0oh1QqtBXJyM5pwHLTdevetrcOoH6c/SVrw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JTRgxN84kEAJcz1TapOHWGjzyqFoLZRF1sNv4KBeDdDQc60vgeEiHTi7xGCIOji5JJoIrnb702SJU/3JIeVIiXRu5wWyMSBV/aJfFRMax2j1Rxlcmq9X7Oj196JZ+Hv4ynxLsBoL6L8ROkl2egBcRf+dpT4GmZsK1l3a65rZnac= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DsrCCPon; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DsrCCPon" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-835399c11e0so312731b3a.0 for ; Sun, 03 May 2026 12:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777834821; x=1778439621; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KjVAUyKukJeCfmaUj1rdh/OVSGApfRD+jJDm/U7qFBo=; b=DsrCCPonOxied9ANQ4e+E3Uc8D6GjFG/28vOAWLuqCQsfdbu3tXw6Vhw3ziYle57xc R4sO1K8KtVW4F/PlG6zfbqC2jOlwzYgduws4DcdHhdLiW2cIJpOjpGBs+gkGXz0Pl0EC 55/14EK47HMj0XHaMgC0G/JUvaGGScPv6aZS0fqIyFPNk2xBmht4uyZfOIheb94ajq01 Amt5X5R6Is89X9GNM5li4sth7Fba7Km2SBv74Jq0Yl87QEe1QMAhh1NJS8ScB2A29QyV LsBOAu7n0y110kSTX/Xf698vhKGrY3HLtsQY+/yQQeeLMpH8Y4m+gtEermo+BX+hokDk +EpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777834821; x=1778439621; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KjVAUyKukJeCfmaUj1rdh/OVSGApfRD+jJDm/U7qFBo=; b=rWgsB9F8Bs2HMmVXutYWXnW53nC01CLbSWUTMBX6dcdgi81Q3QYITM7iAluwjdeXX/ zByvZSnBBh8gXVXD1fN6vXL2N7p0vSQIYGBqwjmu8VV8pKyR84QWeX/H+nYqZtTslmDe X/MMAa51PQp1C4I3+Mb+v9M1RPo8TTbLnE1VLOi24uW5fIp/FUzoLeRA5fQQrl9MkSeH ZzHzwHcgqlP1o/zYWV6K0sXMOOQ9zKPTyFr0T/Xh5Y6Jt6ykCRjyFzP2PdZIiOKYFfjY 0hsrn94Dn/5lczipWMdcnoerf3mSMvS7Fy7BxUq4N/uOnydMoVyUOj03/Gf0+hGTKVia vMYQ== X-Forwarded-Encrypted: i=1; AFNElJ9G7mxuEDV1YIqbFVuxd30uRlc9nsXfZ2oVfrq6IwBLPMSEzlVldlQJ1r1z1/1NnS53yyD2y0YhrVUTMag=@vger.kernel.org X-Gm-Message-State: AOJu0YwEXihv4/ciGdOkiQeYf/eCLpkyjJPJrxMvTY5UYjEyI+Lx8rGZ FJ1uRuFTdMogkACq6sdzcRdEIoUHm2/GteZkIOs+eIs7pqr0Plb7ahpc X-Gm-Gg: AeBDiev8CCO0Cy+kx0D3qK37z04fC82AiDiarJzsmVtrDqtmAkQ/mmMFWRvu4gLVPOg L+cSSiqZVVyRt7YPZOsW0DQV5byn7U58pQEeJfTDG9Uv5wW1xxBCPlWXVlHAxutBS4UHEJVrIGV cSgxMDcKd2exphlX70qcu9om+MBHINXJfcukcrKbShVK5MpyR35yHm/a7hkjKQARd+IUOvcYpU7 B3vQQKDnja+WrLLshPwI3ha4Mu7oGpVW9bSj6QinhwDfaGrtEVCGUgdGr2ElEf7rUVUHcBbRnx+ azH0W43aLnHQYJfIJGGDR4z9Uz+frYw+0hydgCCmSe1k9kINZmZFisiJE1QEL2H4ZGJ8lFnvRoY OSGIB18xEq6CkmKF2ZXxpLfSYjOPKAxXqzf0CTe7jjDngHsBk6it0YKeupcVmmRtor9i8wItxNf sCO6111Ni7cnv9QV5Ppv2mbYFnTk1AWapo44ws X-Received: by 2002:a05:6a00:430a:b0:81f:852b:a925 with SMTP id d2e1a72fcca58-8352d03bf06mr5948036b3a.1.1777834821160; Sun, 03 May 2026 12:00:21 -0700 (PDT) Received: from localhost ([188.253.123.154]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83515ad0183sm10229043b3a.31.2026.05.03.12.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 12:00:20 -0700 (PDT) From: Zhang Xiaolei To: linux-gpio@vger.kernel.org Cc: brgl@kernel.org, warthog618@gmail.com, linux-kernel@vger.kernel.org, Zhang Xiaolei Subject: [PATCH] tools: gpio: fix buffer overflow and add bounds check Date: Mon, 4 May 2026 03:00:16 +0800 Message-ID: <20260503190016.13439-1-zxl434815272@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace strcpy() with strncpy() to avoid potential buffer overflow in req.consumer. Also add validation for num_lines to prevent out-of-bounds access to req.offsets. Fix incorrect ioctl name in error message. Signed-off-by: Zhang Xiaolei --- tools/gpio/gpio-utils.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c index 4096bcd511d1..1afd9dff2bed 100644 --- a/tools/gpio/gpio-utils.c +++ b/tools/gpio/gpio-utils.c @@ -65,11 +65,15 @@ int gpiotools_request_line(const char *device_name, uns= igned int *lines, int i; int ret; =20 + if (!device_name || !lines || !config || !consumer || + num_lines =3D=3D 0 || num_lines > GPIO_V2_LINES_MAX) + return -EINVAL; + ret =3D asprintf(&chrdev_name, "/dev/%s", device_name); if (ret < 0) return -ENOMEM; =20 - fd =3D open(chrdev_name, 0); + fd =3D open(chrdev_name, O_RDONLY); if (fd =3D=3D -1) { ret =3D -errno; fprintf(stderr, "Failed to open %s, %s\n", @@ -78,27 +82,29 @@ int gpiotools_request_line(const char *device_name, uns= igned int *lines, } =20 memset(&req, 0, sizeof(req)); + for (i =3D 0; i < num_lines; i++) req.offsets[i] =3D lines[i]; =20 req.config =3D *config; - strcpy(req.consumer, consumer); + strncpy(req.consumer, consumer, sizeof(req.consumer) - 1); + req.consumer[sizeof(req.consumer) - 1] =3D '\0'; req.num_lines =3D num_lines; =20 ret =3D ioctl(fd, GPIO_V2_GET_LINE_IOCTL, &req); if (ret =3D=3D -1) { ret =3D -errno; fprintf(stderr, "Failed to issue %s (%d), %s\n", - "GPIO_GET_LINE_IOCTL", ret, strerror(errno)); + "GPIO_V2_GET_LINE_IOCTL", ret, strerror(errno)); } =20 if (close(fd) =3D=3D -1) perror("Failed to close GPIO character device file"); + exit_free_name: free(chrdev_name); return ret < 0 ? ret : req.fd; } - /** * gpiotools_set_values() - Set the value of gpio(s) * @fd: The fd returned by --=20 2.54.0