From nobody Sun Jun 14 04:20:28 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A738926ACC for ; Sun, 3 May 2026 16:56:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777827410; cv=none; b=URxxJ3GvQdy2OViSCavJlzlvKc9vk0mdzOaut2e3gSStjZ2+1wW2W3nq+d5XX1Yj4kAktmBR7vAhHpspvmoef0PiH9hEWC+ZbS4rNDF9EExDNA0tZ/wxf/hXv/VAkAnGvYnSPEs8qLiXcX8vC59wyg/qmyY3kOJieGHOLiP9Lc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777827410; c=relaxed/simple; bh=+gXx26kToc5Qsn+X5xpx5KaXlfJuV83OpMJgOHZcMo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aVzaixFWY/dUeXN835ASp0+fzjhvR3UcyYr3g+8nCqZts8JeEjDEzUhRheaXaOo3DPyVCOOoU6Nuq9QxUBA9NZsLmeoQAF56UNApLiIox5D+/6vD5Sbp5ppnt9Zzx0QUNjWr+Ux1D/87bI8c5S0ktYtPhHh+XpOxpLj00gOhj9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q9DgrVZm; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q9DgrVZm" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-67bce1840f1so2626102a12.3 for ; Sun, 03 May 2026 09:56:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777827407; x=1778432207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pFgTexS82Aes4S2KA8waYF2yU7gR1eiSJ6BQPR26m30=; b=q9DgrVZmybj2oRjUyU/JHYTQQmlcwp5G5MAk5cXWeS3DGHHhA1jOu5+BLMf2SVf9r0 zNNYY+Yy3nuAN9PxQQ5UF9evxs/mXO9XXInw/51MZ/JpbNsn3XIVvCQXfe172mbs1bca I1mLrhZiWMg0w0rN/n5fHa1bvuuYIxST+Z34WJy/NPZ/KovTC9mv9c92uHBQBChDcXnO chAMG1hkDobbRuyGkePHt6w2R1Y1nqY9RfAPsaIqte5z/qFZwWnrEGBrArfsh5+ExWcK CrgA8ZCX4YjhKTYirHgFbYCmOBvi8i3e1uskp8CeErvcWcIQlWIkvkoLUqd2B7W0t33I 5ShQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777827407; x=1778432207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pFgTexS82Aes4S2KA8waYF2yU7gR1eiSJ6BQPR26m30=; b=kDGf8r3for1a+5J/vHkT9O0c0l3DdlXP84Krw7upbC35prc7VrFfRHtkNBkrSY75QQ b321wl58cD9Rp0TDNJ3rV3ACpNVZrNxKsif9BBQ9fQEfQDFTBs2smDI57aGiGdXisoOd uwNMHqZuDxnxTxJIQwjP3c72ewl2whRM2CpRw8TMP4PBAWNc9aQtSWidMfdCoStAn2qX sBcQ2QoVEnJ+IKBhmIKttiGJWhBg7Abdhc0xMGD+yFUCYJOax59iLfKUkhIscOnK84dV c6enIWeKXYCHC+c7s1W0eP3wTPWSaKP7fv/bBhJVsub59zYn4ZxKQlcIQ87jYQD/Vz4O 2tYg== X-Forwarded-Encrypted: i=1; AFNElJ8MkBJiMGVohsTQO0W+jk6yaQT33L2izJJ4ne7OWNNwgAxYe5C5O5qLMAW+5Pa5pnaQMs5NW7cOkwlJtVc=@vger.kernel.org X-Gm-Message-State: AOJu0YxjnjrL9KzSLbp3y+DtnNK24jUzBkHbp58NLOzTsiBz/7ciEm7W Jn7behyx0InagT630JGQg50Lh/78YaTAltjM3J1uppPcbYgnroC7bC0y X-Gm-Gg: AeBDievLY8D2ClmCtZqElA1wmMc5vnymuzqR+VcANPnEOFhsnaSfq+ubZb1iHJCcPmN f43sKQIzcaJ4SxWbN5LC+KT1xwGMLNge6b7LVm20t3HNSKbDSyhVCRMdNPaISiw/IIjpn6yP3Wf Q+RBPAg3J2LGc9zdNf/SKXDtVhQxFDkmgmBm8x8eey4mXiOtPt4o6IYZs5YolTklYrspPOa67rW +ZfSjMpJygV/MHTIhCQF9UcEJfukPhF+0TrLONkrGmwOzjF3jSdAoV/usUnmvyaEhTd4tAMN1ZS lrYDAoG1f3qFL9IqQJZhR6zIFqUor1Smw88JdZGP2XyJQPFZbszgux/Fn2W8Tf5Q0rR4/LcYshv 45ovUpFm7TkhDLtJBKNMHhFGjHiJLMB8GHqMFOyt492poWML8WAY++Or4VDj1UgRc+YM+nNK3Ar swS+qaExuYKzPGafOVoLRgtAQ= X-Received: by 2002:a05:6402:2b98:b0:676:d8df:f8c1 with SMTP id 4fb4d7f45d1cf-67c1b2a2c9emr2670164a12.22.1777827406947; Sun, 03 May 2026 09:56:46 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67b8579891fsm2713649a12.0.2026.05.03.09.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 09:56:46 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v3 1/2] dt-bindings: embedded-controller: Document Surface RT EC Date: Sun, 3 May 2026 19:56:33 +0300 Message-ID: <20260503165636.216257-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260503165636.216257-1-clamor95@gmail.com> References: <20260503165636.216257-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Document Embedded Controller used in Microsoft Surface RT tablets for monitoring battery properties and charger status. Signed-off-by: Svyatoslav Ryhel --- .../microsoft,surface-rt-ec.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/embedded-controller/m= icrosoft,surface-rt-ec.yaml diff --git a/Documentation/devicetree/bindings/embedded-controller/microsof= t,surface-rt-ec.yaml b/Documentation/devicetree/bindings/embedded-controlle= r/microsoft,surface-rt-ec.yaml new file mode 100644 index 000000000000..0fee574a3015 --- /dev/null +++ b/Documentation/devicetree/bindings/embedded-controller/microsoft,surfa= ce-rt-ec.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/embedded-controller/microsoft,surface-r= t-ec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microsoft Surface RT fuel gauge and charger EC + +maintainers: + - Jonas Schw=C3=B6bel + - Svyatoslav Ryhel + +description: + An Embedded Controller used in Microsoft Surface RT for monitoring + battery properties and charger status. + +allOf: + - $ref: /schemas/power/supply/power-supply.yaml# + +properties: + compatible: + const: microsoft,surface-rt-ec + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + enable-gpios: + maxItems: 1 + + monitored-battery: true + +required: + - compatible + - reg + - interrupts + - enable-gpios + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@a { + compatible =3D "microsoft,surface-rt-ec"; + reg =3D <0x0a>; + + interrupt-parent =3D <&gpio>; + interrupts =3D <74 IRQ_TYPE_EDGE_RISING>; + + enable-gpios =3D <&gpio 88 GPIO_ACTIVE_HIGH>; + monitored-battery =3D <&battery>; + }; + }; +... --=20 2.51.0 From nobody Sun Jun 14 04:20:28 2026 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5F123CEBB6 for ; Sun, 3 May 2026 16:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777827412; cv=none; b=sRoKdqQa67W61zRTfvhmz18yEvfGAQ/rBjHko9Tp67nFEoac4fS4QI+ZbOYGQxfxy8nTDjtvRULwocV2C0Lm1PKRQr4lViKx+3bSTHjB/+idtiry9NHAvw7iNcGnUxBZmgGh4XEKqWV2H8GxSPPqajg0gv5GlIItQKsTqIRs4ds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777827412; c=relaxed/simple; bh=1EgF4lTgujdWo2rd/7EwXCUxfgSPSR3dwMN1MO5rQws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gNW6QuYbd3CiIacQ/iq364xqM6LtJ3KQQ2Y+d/GLZArwoJJPcBgj6ZTTN6wnZHxpO7fPBNiMomf1sXUGuW2fG/q/9Qx8xeEt/kz1pAYh6NwSO8M9gT2vYr77JWFkFjMgx9L2QQ9ZAJoiIM6VecN6ue07bUJh7twfSYy4Kc1PPoA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sMwDfOHD; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sMwDfOHD" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-67c566cb519so1009172a12.3 for ; Sun, 03 May 2026 09:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777827409; x=1778432209; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9Js9Sb4OdjXT4vTjLNzONFBOEW5yTJMmHB2WqVPjGr4=; b=sMwDfOHDgc90Wq0YG4wbH69R1N5TUrNZgzNgZXthknn4mfIwviKNfTlAUXjD/LZEEa Vpj/CBMn+wfzGpTS3bydXJFtan7KfV9Po7E3JXF8GGd/hpGtYGpowaJWbb8fPt7QwnC6 wM0SPO2JT428Kbr/TZW3RAaJb3flCMbk0EIdGFczPibdORa8DyTXZvdwIAZIzX8gxl2z tKf5jHojASgEvRRlLMn2EtPC+aN/vxpC/MAtpj2XF21Qgh8lGMLLhsXFREqT7E/IgkrG MfgbknMAaHkjGFNtZpr7pdtefC/155FniFlrJogEDWC7UhyBmiSbAAnsTCOb/adAYalM Sh6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777827409; x=1778432209; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9Js9Sb4OdjXT4vTjLNzONFBOEW5yTJMmHB2WqVPjGr4=; b=sZh3aS47QUhKeoZcN+k0croH22E6ddRVojHyQJmx+IqInR0JCMpvwus4OORsG0pfPd v7kwx7vFPkpEGNoXYANpY7JE5y/xA5Wz4f3ovMo7lJ9v4GcbeMCNqnZMO7de6XXDUE1R Y62YwOkZYZ5pQfQBYBlN32lJDap3kM+3IFKIc0+pIFSbR0UykZp6ruY8+rBzqeipx41U Cg8Rgh592ypdXWvVccQqSJzVXL7SssLD/iDOPcOFTN1HLv8+0uebc0y2TQr+n7kakJBy MunxlkjxM80CN5uBIM+vgRbbWlySBL5JRNEhaTDFMVJBb2u2KHcR2w6hsFmR5JJSiuRg gaAQ== X-Forwarded-Encrypted: i=1; AFNElJ8b6uCjzwORlNfgpqT8dqy5em/tboUdZxITQXH3ZQenn1tqv1CeWdo/+ZQPi/VZrvmWcOHjpKDwHMRJjBc=@vger.kernel.org X-Gm-Message-State: AOJu0YzXjCxgD1hPGm0QRrcZZHTQA0XuBJfY+u7p8Eeq9nF8nMwzMn9s RyPuIA9V8ZpDBWj1DEh0GvEY63I4RvPN6UCMchjxUg0ZxrYR7NN/eiLzleqyrQ== X-Gm-Gg: AeBDietNI64L10MdwugoJLd4vngV1lkSOrgtUiLnxDBxmvla2VsoiLCHd5iefI+mxon 5TbVOAdYTWQ8G/L8OJRBhiT/13rTfpJIGk9jGTzMlRXoH84ddmRl9qQeLizns6YXwzZkONqFq23 sQOV2o/kdO8WWWbq6H2wY9edqZv2tRaa1eOzH+qr58I5z/Hf/5KgS+Jv6sRvoDOVSM61a/JlOfU AABqz0w1QhaPvRsVZj0ehSC/Y04Wul2VUN+CO0IHiLOXei0sMzRKpi09APO+RNIKHfs25hQ0ZxM BvEy34hw3tcBM7QFkp8tlPZHOjUHwoiceu3eoh4oXshDb7AXRbcjdm3+xhLHJiD/qSRqIrkLAJB 2yr6h8Ww96zB7tI7ciWzSE0L/N151UZFyJTuLFyGeYIu3ynnhmr8KHRPInp13XP4ZVcchvCGj3B w3JOQQ4Rw7m4v0gf3ThystGXo= X-Received: by 2002:a05:6402:4282:b0:66b:f0b3:42a7 with SMTP id 4fb4d7f45d1cf-67c1abb49d1mr2490450a12.24.1777827408878; Sun, 03 May 2026 09:56:48 -0700 (PDT) Received: from xeon ([188.163.112.56]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67b8579891fsm2713649a12.0.2026.05.03.09.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 May 2026 09:56:47 -0700 (PDT) From: Svyatoslav Ryhel To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Jonas=20Schw=C3=B6bel?= Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v3 2/2] power: supply: Add support for Surface RT battery and charger Date: Sun, 3 May 2026 19:56:34 +0300 Message-ID: <20260503165636.216257-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260503165636.216257-1-clamor95@gmail.com> References: <20260503165636.216257-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Jonas Schw=C3=B6bel Add support for Embedded Controller found in the Microsoft Surface RT and used to monitor battery cell and charger input status and properties. Controller works both for UEFI and APX booting. [wmjb: added POWER_SUPPLY_PROP_CHARGE_NOW support] Signed-off-by: wmjb Signed-off-by: Jonas Schw=C3=B6bel Signed-off-by: Svyatoslav Ryhel --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + drivers/power/supply/surface-rt-ec.c | 389 +++++++++++++++++++++++++++ 3 files changed, 401 insertions(+) create mode 100644 drivers/power/supply/surface-rt-ec.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 4d04de6586ae..13661d3d39b4 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -1168,6 +1168,17 @@ config BATTERY_UG3105 device is off or suspended, the functionality of this driver is limited to reporting capacity only. =20 +config BATTERY_CHARGER_SURFACE_RT + tristate "Battery & Charger driver for Microsoft Surface RT" + depends on I2C && GPIOLIB + help + UEFI/APX driver for the 1st-generation Microsoft Surface RT + battery. Driver supports reading battery properties and + charger status. + + This driver can also be built as a module. If so, the module + will be called surface-rt-ec. + config CHARGER_QCOM_SMB2 tristate "Qualcomm PMI8998 PMIC charger driver" depends on MFD_SPMI_PMIC diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 3959b974ec84..ebd3beef4c84 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -129,6 +129,7 @@ obj-$(CONFIG_RN5T618_POWER) +=3D rn5t618_power.o obj-$(CONFIG_BATTERY_ACER_A500) +=3D acer_a500_battery.o obj-$(CONFIG_BATTERY_SURFACE) +=3D surface_battery.o obj-$(CONFIG_CHARGER_SURFACE) +=3D surface_charger.o +obj-$(CONFIG_BATTERY_CHARGER_SURFACE_RT) +=3D surface-rt-ec.o obj-$(CONFIG_BATTERY_UG3105) +=3D ug3105_battery.o obj-$(CONFIG_CHARGER_QCOM_SMB2) +=3D qcom_smbx.o obj-$(CONFIG_FUEL_GAUGE_MM8013) +=3D mm8013.o diff --git a/drivers/power/supply/surface-rt-ec.c b/drivers/power/supply/su= rface-rt-ec.c new file mode 100644 index 000000000000..98b736f3b05a --- /dev/null +++ b/drivers/power/supply/surface-rt-ec.c @@ -0,0 +1,389 @@ +// SPDX-License-Identifier: GPL-2.0+ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* Register Addresses (B=3Dbyte; W=3Dword; S=3Dstring) */ +#define REGB_STATUS 0x02 +#define REGW_VOLTAGE_NOW 0x20 +#define REGW_CURRENT_NOW 0x24 +#define REGW_CAPACITY 0x28 +#define REGW_CHARGE_NOW 0x2a +#define REGW_CHARGE_FULL 0x2c +#define REGW_CYCLE_COUNT 0x3a +#define REGW_CHARGE_FULL_DESIGN 0x3c +#define REGW_VOLTAGE_MAX_DESIGN 0x3e +#define REGW_SERIAL_NUMBER 0x44 +#define REGS_MANUFACTURER 0x46 +#define REGS_MODEL_NAME 0x52 +#define REGS_TECHNOLOGY 0x5a +#define REGB_ONLINE 0x67 + +struct srt_ec_device { + struct i2c_client *client; + + struct power_supply *bat; + struct power_supply *psy; + + struct gpio_desc *enable_gpiod; + struct delayed_work poll_work; + + unsigned int technology; + unsigned int capacity; + + const char *serial; + char manufacturer[13]; + char model_name[10]; +}; + +static const enum power_supply_property srt_bat_power_supply_props[] =3D { + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_CHARGE_FULL, + POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CYCLE_COUNT, + POWER_SUPPLY_PROP_MANUFACTURER, + POWER_SUPPLY_PROP_MODEL_NAME, + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_PRESENT, + POWER_SUPPLY_PROP_SERIAL_NUMBER, + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_TECHNOLOGY, + POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN, + POWER_SUPPLY_PROP_VOLTAGE_NOW, +}; + +static const enum power_supply_property srt_psy_power_supply_props[] =3D { + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_PRESENT, +}; + +static int srt_bat_get_value(struct i2c_client *client, int reg, int *val) +{ + int ret; + + switch (reg) { + case REGW_CHARGE_NOW: + case REGW_CHARGE_FULL_DESIGN: + case REGW_CHARGE_FULL: + case REGW_VOLTAGE_MAX_DESIGN: + case REGW_VOLTAGE_NOW: + ret =3D i2c_smbus_read_word_data(client, reg); + if (ret < 0) + return ret; + + *val =3D ret * 1000; + break; + + case REGW_CURRENT_NOW: + ret =3D i2c_smbus_read_word_data(client, reg); + if (ret < 0) + return ret; + + *val =3D (s16)ret * 1000; + break; + + case REGW_CAPACITY: + case REGW_CYCLE_COUNT: + ret =3D i2c_smbus_read_word_data(client, reg); + if (ret < 0) + return ret; + + *val =3D ret; + break; + + case REGB_STATUS: + ret =3D i2c_smbus_read_byte_data(client, reg); + if (ret < 0) + return ret; + + if (ret & BIT(0)) + *val =3D POWER_SUPPLY_STATUS_CHARGING; + else + *val =3D POWER_SUPPLY_STATUS_DISCHARGING; + break; + + case REGB_ONLINE: + ret =3D i2c_smbus_read_byte_data(client, reg); + if (ret < 0) + return ret; + + *val =3D (ret & BIT(1)) >> 1; + break; + + default: + return -EINVAL; + } + + return 0; +} + +static int srt_bat_power_supply_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct srt_ec_device *srt =3D power_supply_get_drvdata(psy); + struct i2c_client *client =3D srt->client; + int ret =3D 0; + + switch (psp) { + case POWER_SUPPLY_PROP_MANUFACTURER: + val->strval =3D srt->manufacturer; + break; + case POWER_SUPPLY_PROP_MODEL_NAME: + val->strval =3D srt->model_name; + break; + case POWER_SUPPLY_PROP_SERIAL_NUMBER: + val->strval =3D srt->serial; + break; + case POWER_SUPPLY_PROP_CAPACITY: + ret =3D srt_bat_get_value(client, REGW_CAPACITY, &val->intval); + break; + case POWER_SUPPLY_PROP_CHARGE_NOW: + ret =3D srt_bat_get_value(client, REGW_CHARGE_NOW, &val->intval); + break; + case POWER_SUPPLY_PROP_CHARGE_FULL: + ret =3D srt_bat_get_value(client, REGW_CHARGE_FULL, &val->intval); + break; + case POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN: + ret =3D srt_bat_get_value(client, REGW_CHARGE_FULL_DESIGN, + &val->intval); + break; + case POWER_SUPPLY_PROP_CURRENT_NOW: + ret =3D srt_bat_get_value(client, REGW_CURRENT_NOW, &val->intval); + break; + case POWER_SUPPLY_PROP_CYCLE_COUNT: + ret =3D srt_bat_get_value(client, REGW_CYCLE_COUNT, &val->intval); + break; + case POWER_SUPPLY_PROP_PRESENT: + val->intval =3D 1; + break; + case POWER_SUPPLY_PROP_ONLINE: + ret =3D srt_bat_get_value(client, REGB_ONLINE, &val->intval); + break; + case POWER_SUPPLY_PROP_STATUS: + if (srt->capacity < 100) + ret =3D srt_bat_get_value(client, REGB_STATUS, &val->intval); + else + val->intval =3D POWER_SUPPLY_STATUS_FULL; + break; + case POWER_SUPPLY_PROP_TECHNOLOGY: + val->intval =3D srt->technology; + break; + case POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN: + ret =3D srt_bat_get_value(client, REGW_VOLTAGE_MAX_DESIGN, + &val->intval); + break; + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + ret =3D srt_bat_get_value(client, REGW_VOLTAGE_NOW, &val->intval); + break; + default: + return -EINVAL; + } + + return ret; +} + +static int srt_psy_power_supply_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct srt_ec_device *srt =3D power_supply_get_drvdata(psy); + struct i2c_client *client =3D srt->client; + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_ONLINE: + case POWER_SUPPLY_PROP_PRESENT: + ret =3D i2c_smbus_read_byte_data(client, REGB_ONLINE); + if (ret < 0) + return ret; + + val->intval =3D ret & BIT(0); + break; + default: + return -EINVAL; + } + + return 0; +} + +static void srt_bat_poll_work(struct work_struct *work) +{ + struct srt_ec_device *srt =3D + container_of(work, struct srt_ec_device, poll_work.work); + int ret, capacity; + + ret =3D srt_bat_get_value(srt->client, REGW_CAPACITY, &capacity); + if (!ret && capacity !=3D srt->capacity) { + srt->capacity =3D capacity; + power_supply_changed(srt->bat); + } + + /* continuously send uevent notification */ + schedule_delayed_work(&srt->poll_work, 30 * HZ); +} + +static irqreturn_t srt_psy_detect_irq(int irq, void *dev_id) +{ + struct srt_ec_device *srt =3D dev_id; + + power_supply_changed(srt->psy); + + return IRQ_HANDLED; +} + +static const struct power_supply_desc srt_bat_power_supply_desc =3D { + .name =3D "surface-rt-battery", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D srt_bat_power_supply_props, + .num_properties =3D ARRAY_SIZE(srt_bat_power_supply_props), + .get_property =3D srt_bat_power_supply_get_property, + .external_power_changed =3D power_supply_changed, +}; + +static const struct power_supply_desc srt_psy_power_supply_desc =3D { + .name =3D "surface-rt-ac-adapter", + .type =3D POWER_SUPPLY_TYPE_MAINS, + .properties =3D srt_psy_power_supply_props, + .num_properties =3D ARRAY_SIZE(srt_psy_power_supply_props), + .get_property =3D srt_psy_power_supply_get_property, +}; + +static char *battery_supplied_to[] =3D { "surface-rt-battery" }; + +static int srt_ec_probe(struct i2c_client *client) +{ + struct power_supply_config bat_cfg =3D {}; + struct power_supply_config psy_cfg =3D {}; + struct device *dev =3D &client->dev; + struct srt_ec_device *srt; + char str_buf[4]; + int ret; + + srt =3D devm_kzalloc(dev, sizeof(*srt), GFP_KERNEL); + if (!srt) + return -ENOMEM; + + i2c_set_clientdata(client, srt); + srt->client =3D client; + + srt->enable_gpiod =3D devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); + if (IS_ERR(srt->enable_gpiod)) + return dev_err_probe(dev, PTR_ERR(srt->enable_gpiod), + "failed to get enable gpio\n"); + + /* wait till EC is ready */ + usleep_range(1000, 1500); + + ret =3D i2c_smbus_read_word_data(client, REGW_SERIAL_NUMBER); + if (ret < 0) + return ret; + + srt->serial =3D devm_kasprintf(dev, GFP_KERNEL, "%04x", ret); + if (!srt->serial) + return -ENOMEM; + + ret =3D i2c_smbus_read_i2c_block_data(client, REGS_MANUFACTURER, + sizeof(srt->manufacturer) - 1, + srt->manufacturer); + if (ret < 0) + return ret; + + ret =3D i2c_smbus_read_i2c_block_data(client, REGS_MODEL_NAME, + sizeof(srt->model_name) - 1, + srt->model_name); + if (ret < 0) + return ret; + + ret =3D i2c_smbus_read_i2c_block_data(client, REGS_TECHNOLOGY, + sizeof(str_buf) - 1, str_buf); + if (ret < 0) + return ret; + + if (!strncmp(str_buf, "LION", 4)) + srt->technology =3D POWER_SUPPLY_TECHNOLOGY_LION; + else + srt->technology =3D POWER_SUPPLY_TECHNOLOGY_UNKNOWN; + + bat_cfg.drv_data =3D srt; + bat_cfg.fwnode =3D dev_fwnode(dev); + + srt->bat =3D devm_power_supply_register(dev, &srt_bat_power_supply_desc, + &bat_cfg); + if (IS_ERR(srt->bat)) + return dev_err_probe(dev, PTR_ERR(srt->bat), + "failed to register battery power supply\n"); + + psy_cfg.drv_data =3D srt; + psy_cfg.fwnode =3D dev_fwnode(dev); + psy_cfg.supplied_to =3D battery_supplied_to; + psy_cfg.num_supplicants =3D ARRAY_SIZE(battery_supplied_to); + + srt->psy =3D devm_power_supply_register(dev, &srt_psy_power_supply_desc, + &psy_cfg); + if (IS_ERR(srt->psy)) + return dev_err_probe(dev, PTR_ERR(srt->psy), + "failed to register AC power supply\n"); + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, srt_psy_detect_= irq, + IRQF_ONESHOT, client->name, srt); + if (ret < 0) + return dev_err_probe(dev, ret, "failed to request interrupt\n"); + + ret =3D devm_delayed_work_autocancel(dev, &srt->poll_work, srt_bat_poll_w= ork); + if (ret < 0) + return ret; + + schedule_delayed_work(&srt->poll_work, HZ); + + return 0; +} + +static int srt_ec_suspend(struct device *dev) +{ + struct srt_ec_device *srt =3D dev_get_drvdata(dev); + + cancel_delayed_work_sync(&srt->poll_work); + + return 0; +} + +static int srt_ec_resume(struct device *dev) +{ + struct srt_ec_device *srt =3D dev_get_drvdata(dev); + + schedule_delayed_work(&srt->poll_work, HZ); + + return 0; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(srt_ec_pm_ops, srt_ec_suspend, srt_ec_resu= me); + +static const struct of_device_id srt_ec_of_match[] =3D { + { .compatible =3D "microsoft,surface-rt-ec" }, + { } +}; +MODULE_DEVICE_TABLE(of, srt_ec_of_match); + +static struct i2c_driver srt_ec_driver =3D { + .driver =3D { + .name =3D "surface-rt-ec", + .of_match_table =3D srt_ec_of_match, + .pm =3D &srt_ec_pm_ops, + }, + .probe =3D srt_ec_probe, +}; +module_i2c_driver(srt_ec_driver); + +MODULE_AUTHOR("Jonas Schw=C3=B6bel "); +MODULE_DESCRIPTION("Surface RT Embedded Controller driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0