From nobody Sun Jun 14 06:14:56 2026 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B97D21CC4F for ; Sun, 3 May 2026 00:57:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777769850; cv=none; b=UvHYVNESIj0UxTeVjrPv6PkzQTcosZkh6icITt1Y5z5Jw7l0tMbXxJ0xWJ/BjDLDbFqBuAe0y0neMa5UPIvyIGP7c7/UQOJiPZBmy65Q+0rQvuZfJ3zLeJA9Yc6V+hco7EzGfemTPJ/IquczsLfHqQromxMSgdpybT8x/G4fgaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777769850; c=relaxed/simple; bh=sTSNS+Bmc0XI6U2GGUpvQ9hogp4BaeZ44gBXwmtu9cA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YRJSlEaIWNGFpTsoHZWzSDpFspndyWtuOE13dGhlMyFQkqTvPIM7lPwyKuOhPkpsgjGq3h/T3ypV90wwll9kyB7i9WoARXM5dqiuPsr2QZHD374JSPuRSmoudNmT9xO3kw+weBKOZHo6tosWl18XDckFFoqZR2WBVjHciOm1QB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=maestretorreblanca.com; spf=pass smtp.mailfrom=maestretorreblanca.com; dkim=pass (2048-bit key) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com header.b=nCvcqkwK; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=maestretorreblanca.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=maestretorreblanca.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=maestretorreblanca.com header.i=@maestretorreblanca.com header.b="nCvcqkwK" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-575212eb419so94239e0c.1 for ; Sat, 02 May 2026 17:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maestretorreblanca.com; s=google; t=1777769847; x=1778374647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jAbutDuOdCLlr5MjEhNwBJAD8Xktp0AiK9lNlrbs3WE=; b=nCvcqkwK5ICI+c6cGh6D34rz8ohRGtnfUW4LoJGI0bALOaKMj6/to2feJKK2OS4h9d vb3uQmGlMGMY+88U4vs2v46+GbLtiqDlyMqYxu3oGC/fJaj7Ev53mwaLrXorlP0vr9vM F3jo2RzI4TF+UqlMnn0baqUYblR43xo63Sfqr0Ef+nJrZHLMz3Jnui46t0J9ZpC3tbA5 BwlSepQv2ipWulzhXp1Ewq5kAq/psIHltHM3vQ8cR3Qz7B6xY1LgQ7S6FVnoi5+hhMQw IfmxtmbykQAwQJwyG2XulAaf2+DWfV+3vMBdvcxDk3alAgCWmME/iy7Wb4Bqnai+1fDY pPiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777769847; x=1778374647; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jAbutDuOdCLlr5MjEhNwBJAD8Xktp0AiK9lNlrbs3WE=; b=Xm80gFli/JJLsETIjLtvsSyayzD2578wKfGDuTWAmmkXN5I7XuABQvN//PnUGDDiJ2 lxR7QYkg7+D5T+LTDEQU9O9uCl/be2BYq5JO/xlwsN94C+38W5QBuQ2y32BuzJLLU7nA oojXpsehTA0y3xVMEYhDMmPxHTy6CQNkCxA8RzwlBYbOLHnBFKGWAsiQRgRUZPv+tQvM smQFepq7+/HwKHLAyGmoY7j7iyVixtTr83qW6edl0ABdX3Xasztdqb+kG+JOGIuKp7JS JaX4Tim7EqpPzu1gr6Fbe46qCmkkFF4cNr6HVgyoDj5yau/HMGz4OaOjMrDdl9EdOAiR k8Bg== X-Gm-Message-State: AOJu0YyPlkdS4voyOmQbOTslY5iNKc9jUV1l0APTZ6onWL4TdsTTplMZ xqCf5dZTPNSna+kphrYSUuuo5zpbvQfk6aYAqEgehMAxZdHJ912o3rs7g7InAC/yrKkP/E61Yx3 Wnuo2MAmueg== X-Gm-Gg: AeBDietEXpzHQOWTrkdPe68Kn3EQAxOa1GYqPI0ZNI2WqtQe8Z4fkOoruXdPm0v9d16 Z8UgVDE18okehfuW2csA0p4X5ukZK1ciISrpJ3bZCzjPRrPoXXngb/QCtVq3WxVRASiqrO0tGyj jET+narw4LzU0CfowRBi4nEaqlxM6nsaxJ9szWm+CExe4CZmoo9K+N7HUNg1l/CHXy+AmtKmS0J vb4JHReF72V41yJdVCxoLZzuTerRADMZYClCSd1DSMh1NChSQ0684TrQoONq25SFtc2oQRWEIQj Ot2tWRRpgaqJ7sybYkU8lrJXx+MCZedkWMjcK3QsHbYHVmXKSdF3VCt4DVGuAIc0omBTL0K1v3C 1Qeu/69BScP4fxKVHPzf53ThTLYNdfOYAEWM2pd/4BglzBlAC1XO4iR1icD8LGZfMGrsoe1vo9f owqjx95SJpZ6bjfRWIOGI8lwvkgBA9u4494KFyUBduSuS20pKVsFBts9d+tn8GO8sO6vKWeJJ+P 5FQZzIeW9C1aLxUupLo5Xo6lhqaK1LDTZuIQw== X-Received: by 2002:a05:6122:328e:b0:56f:7e8a:a395 with SMTP id 71dfb90a1353d-5750c011345mr1658926e0c.1.1777769847071; Sat, 02 May 2026 17:57:27 -0700 (PDT) Received: from localhost.localdomain ([95.214.114.12]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-574a6c6c582sm4009660e0c.9.2026.05.02.17.57.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 02 May 2026 17:57:26 -0700 (PDT) From: Francisco Maestre To: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, Francisco Maestre Subject: [PATCH v2] macintosh: windfarm_ad7417: fix coding style issues Date: Sat, 2 May 2026 19:57:23 -0500 Message-ID: <20260503005723.68888-1-francisco@maestretorreblanca.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix several coding style issues detected by checkpatch.pl: - Add missing space before open parenthesis in switch statement - Fix duplicated word 'a' in two comments ('a a' -> 'a') - Replace bare -1 return values with proper -EIO error code - Fix alignment of dev_dbg() argument continuation line - Use !ptr instead of ptr =3D=3D NULL for NULL pointer check Signed-off-by: Francisco Maestre --- v2: Resend as individual patch, not part of an unrelated series. drivers/macintosh/windfarm_ad7417_sensor.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/macintosh/windfarm_ad7417_sensor.c b/drivers/macintosh= /windfarm_ad7417_sensor.c index 4bae07ca6669..733dc711cdc7 100644 --- a/drivers/macintosh/windfarm_ad7417_sensor.c +++ b/drivers/macintosh/windfarm_ad7417_sensor.c @@ -52,7 +52,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *= value) if (rc < 0) goto error; =20 - /* Read a a 16-bit signed value */ + /* Read a 16-bit signed value */ raw =3D be16_to_cpup((__le16 *)buf); =20 /* Convert 8.8-bit to 16.16 fixed point */ @@ -63,7 +63,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *= value) =20 error: mutex_unlock(&pv->lock); - return -1; + return -EIO; } =20 /* @@ -79,7 +79,7 @@ static int wf_ad7417_temp_get(struct wf_sensor *sr, s32 *= value) static void wf_ad7417_adc_convert(struct wf_ad7417_priv *pv, int chan, s32 raw, s32 *value) { - switch(chan) { + switch (chan) { case 1: /* Diode */ *value =3D (raw * (s32)pv->mpu->mdiode + ((s32)pv->mpu->bdiode << 12)) >> 2; @@ -128,7 +128,7 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s32 = *value) if (rc < 0) goto error; =20 - /* Read a a 16-bit signed value */ + /* Read a 16-bit signed value */ raw =3D be16_to_cpup((__le16 *)buf) >> 6; wf_ad7417_adc_convert(pv, chan, raw, value); =20 @@ -141,12 +141,12 @@ static int wf_ad7417_adc_get(struct wf_sensor *sr, s3= 2 *value) =20 error: dev_dbg(&pv->i2c->dev, - "Error reading ADC, try %d...\n", i); + "Error reading ADC, try %d...\n", i); if (i < 9) msleep(10); } mutex_unlock(&pv->lock); - return -1; + return -EIO; } =20 static void wf_ad7417_release(struct kref *ref) @@ -261,7 +261,7 @@ static int wf_ad7417_probe(struct i2c_client *client) } =20 pv =3D kzalloc_obj(struct wf_ad7417_priv); - if (pv =3D=3D NULL) + if (!pv) return -ENODEV; =20 kref_init(&pv->ref); --=20 2.50.1 (Apple Git-155)