From nobody Sun Jun 14 04:20:14 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD1743A785E; Sun, 3 May 2026 21:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; cv=none; b=p8KWyjemtfjPjn7Fy1+jUCJQu3u0O8QTG33LsQY9uXruTJZdzUuCvDB7tGRwerz5up68/KnfqQV3vZ577rrQYCtyu4Q6E8CyV45frr/2FkDwBeyZO5VKIw6azWtrpmX8KdBIp7znQey/BR6G7E5V/zFUhWM+tOc5ewZ10Ll20tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; c=relaxed/simple; bh=cWFq0UmsChy1UMKhJ3jNAc6iyXXgrydkyp2h6htMuew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=autUzPk4CCb1gUCbQAPiMmWoQg0PCQNlsz07UwjBAyq8+os5uyJlc3k132tZpencSqEaqPisoXh45RIJz9EdEtGkSR5awUqBCzyydcItYKBzVBU8vgK38Mx1DYmq8LEl9cmnkWAVLHpEcS5N5/LuGrl9Vf+Ze7+Ovu7ZV0/2/+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s/Abf71z; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s/Abf71z" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6BE6DC2BCB4; Sun, 3 May 2026 21:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777844596; bh=cWFq0UmsChy1UMKhJ3jNAc6iyXXgrydkyp2h6htMuew=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=s/Abf71zdPGK2EH6TIc1GQX8Gg5oaMLMS9QIm6i3WcLbROvc+rJSGW2HnMgw86Twa bvs4ra6r7pivhFfegB/jcxRYuJrPNfbLW2XFwPKweWvwOm+bwL2oz1CrYfuQgEeMTb YtJRz+w2wXJjO9twWN08VUPQo8+KrOnH7To9jrFCNA5mDs2jzXcvz3rkqU+jB8kxvz C7kZjLNpDTkcADnbu0+eOu2RL53fvmnS9N0n/85fWIEbhjAjC9bHa8p/nUFNryyAF/ A6JJ/YBpKTBoAuRHKHwzK4M9zMbFgv2ud7kIMuWpiK1ALyMQzlZZs14VP9RgYAy6Fl C8iYRLCJbq9Qg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63012CD3424; Sun, 3 May 2026 21:43:16 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sun, 03 May 2026 14:43:15 -0700 Subject: [PATCH v5 1/3] dt-bindings: leds: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260503-expressatt_camera_flash-v5-1-95524506a799@gmail.com> References: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> In-Reply-To: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , Conor Dooley X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777844595; l=2722; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=zVrQqx9DX85PpInFmz437RLTadxI5BhJ9KjSu1CJI9w=; b=D34jREdsOmnrUJrEqDaIoKNsVbWPR6FSlZ+YLIU9a5KCB6+P96K7j5lAZrbwwVf3VBNfYsHep KYe3PPgiY4nBYV94MtPA/rEVS7keiM0iaKvmF2+a3dI3VKcT6UIAqau X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Some flash ICs use the same one-wire pulse-count protocol as the RT8515 but have only a single enable line for both flash and torch modes, plus an optional input voltage supply (e.g. a GPIO-controlled fixed regulator) that gates power to the chip. Make ent-gpios optional and add a vin-supply property to support these variants. Add a oneOf constraint requiring exactly one of ent-gpios or vin-supply. Add a binding example showing the single-GPIO configuration with an input supply. Assisted-by: Claude:claude-opus-4.6 Acked-by: Conor Dooley Reviewed-by: Linus Walleij Signed-off-by: Rudraksha Gupta --- .../devicetree/bindings/leds/richtek,rt8515.yaml | 34 ++++++++++++++++++= +++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml b/D= ocumentation/devicetree/bindings/leds/richtek,rt8515.yaml index 0356371a6b01..ab3c5139132c 100644 --- a/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml +++ b/Documentation/devicetree/bindings/leds/richtek,rt8515.yaml @@ -15,6 +15,10 @@ description: | current for each mode is defined in hardware using two resistors RFS and RTS. =20 + Some flash ICs use the same one-wire pulse-count protocol but have + only a single enable line for both flash and torch modes. For these + single-channel variants, only enf-gpios is needed. + properties: compatible: const: richtek,rt8515 @@ -26,6 +30,11 @@ properties: ent-gpios: maxItems: 1 description: A connection to the 'ENT' (enable torch) pin. + Not present on single-channel flash ICs that use only one enable + line for both flash and torch modes. + + vin-supply: + description: Optional input supply for the flash IC. =20 richtek,rfs-ohms: minimum: 7680 @@ -81,10 +90,15 @@ properties: =20 required: - compatible - - ent-gpios - enf-gpios - led =20 +oneOf: + - required: + - ent-gpios + - required: + - vin-supply + additionalProperties: false =20 examples: @@ -108,4 +122,22 @@ examples: }; }; =20 + - | + /* Single-channel flash IC with input supply */ + #include + #include + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&flash_reg>; + richtek,rfs-ohms =3D <16000>; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + ... --=20 2.54.0 From nobody Sun Jun 14 04:20:14 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2243A7F4C; Sun, 3 May 2026 21:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; cv=none; b=q6D8usqaflsew6iUQaYamjVKwPXsGz3qGNCwaPLBg0CKDjm3c2i54MR2VXwYGL2++Ej8tto6ZusSHWQHKcVfZAp+9Ny1Dbjgo67cpmW1JYWz2kXrgVpy0InkPvd81qy/GHJq5ddCieDEHz//VEJ75hcZyHdmEe+cwqkurMksPAQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; c=relaxed/simple; bh=UNIInnizweh+PYPWAANIlkfMe5JtcEqTCQJHCmxP9Bw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ld4T0Dzf2a/c6wYexar6H8amtQZvV+/pfW73CNWEkhSAMo9EjHfbwjemWxZ35dBzKnPTeIUCml2sefrLsCitFXyvscV+aUlRkihVTscufqWHd/erQTqdi0EDZJk6TKL/CrQSSfjHp2a07vqQBOkJ95ZXkFUuJtew0QKGZHfb+2Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aDdtPOox; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aDdtPOox" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7AB73C2BCC9; Sun, 3 May 2026 21:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777844596; bh=UNIInnizweh+PYPWAANIlkfMe5JtcEqTCQJHCmxP9Bw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=aDdtPOoxCIEMQSohrv98or0CSCa4znOQEV6VpIt+/0lJyTE54P9PpKMLsu8z9j2Kb IYzzzawDbnQlZkh8rTiAuFCeOYOP/4NLQNrKQes7xGNW75VZUoYu9oMn7XEOSH6oe5 0RRCjh/bd6I4gd6OCpQrD9rDPZRVTDyMYrshXecf563Auf8rvGijA4RD2L+dbyaMQv hNtVa2qx1emhCROHdFrBtVv/tJu9IgZTiNUZ453q7fa6RDAZFsTbVp/uF2vPsX7vur rJDf4xtvIX8oo/Dd7bGMAB2nrKOtNYyeFQF2KeNNKvf/zd8v7+ZJGZ92uH+GhKom0j kPXLKHJU1jgVQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 737EECD342C; Sun, 3 May 2026 21:43:16 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sun, 03 May 2026 14:43:16 -0700 Subject: [PATCH v5 2/3] leds: flash: rt8515: Support single-GPIO flash ICs with vin supply Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260503-expressatt_camera_flash-v5-2-95524506a799@gmail.com> References: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> In-Reply-To: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777844595; l=8332; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=ID7JLReDGTmzJX9PKpm0HrliqPo0rE9plki/J7Mr/bQ=; b=U+RAsZCnxJFGPqcVdoNRq/I1dBLtrhmN5fncz5R1IeCxwfwi4b+kLWSlYgrHYmAUD+TpE+fYp p6KLFUeGX24CyQTfimJ72YGbXiJy4gC3QPqGlDR9Z1mkBRbM0LTVaqM X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Extend the RT8515 driver to support flash ICs that use only a single GPIO for both flash and torch modes (no separate ENT pin), with an optional vin regulator that gates power to the flash IC. When vin-supply is provided, the driver enables the regulator before activating the LED and disables it when turning off. Make ent-gpios optional. When ent-gpios is absent, the driver uses enf-gpios for both flash and torch brightness control. Assisted-by: Claude:claude-opus-4.6 Reviewed-by: Linus Walleij Signed-off-by: Rudraksha Gupta --- drivers/leds/flash/leds-rt8515.c | 130 +++++++++++++++++++++++++++++++----= ---- 1 file changed, 105 insertions(+), 25 deletions(-) diff --git a/drivers/leds/flash/leds-rt8515.c b/drivers/leds/flash/leds-rt8= 515.c index f6b439674c03..4459874e6a6c 100644 --- a/drivers/leds/flash/leds-rt8515.c +++ b/drivers/leds/flash/leds-rt8515.c @@ -31,6 +31,7 @@ #include #include #include +#include =20 #include =20 @@ -52,7 +53,7 @@ struct rt8515 { struct regulator *reg; struct gpio_desc *enable_torch; struct gpio_desc *enable_flash; - struct timer_list powerdown_timer; + struct delayed_work powerdown_work; u32 max_timeout; /* Flash max timeout */ int flash_max_intensity; int torch_max_intensity; @@ -63,16 +64,50 @@ static struct rt8515 *to_rt8515(struct led_classdev_fla= sh *fled) return container_of(fled, struct rt8515, fled); } =20 -static void rt8515_gpio_led_off(struct rt8515 *rt) +static int rt8515_gpio_led_off(struct rt8515 *rt) { + int ret; + gpiod_set_value(rt->enable_flash, 0); gpiod_set_value(rt->enable_torch, 0); + + if (!rt->reg) + return 0; + + /* Disable regulator */ + ret =3D regulator_is_enabled(rt->reg); + if (ret < 0) + return ret; + if (ret > 0) + return regulator_disable(rt->reg); + + return 0; } =20 -static void rt8515_gpio_brightness_commit(struct gpio_desc *gpiod, - int brightness) +static int rt8515_gpio_brightness_commit(struct rt8515 *rt, + struct gpio_desc *gpiod, + int brightness) { int i; + int ret; + + /* + * Reset the IC to start brightness from zero, + * then re-enable and pulse to the desired level. + */ + ret =3D rt8515_gpio_led_off(rt); + if (ret) + return ret; + + /* IC needs time to reset its brightness counter */ + usleep_range(100, 200); + + /* Enable regulator */ + if (rt->reg) { + ret =3D regulator_enable(rt->reg); + if (ret) + return ret; + } =20 /* * Toggling a GPIO line with a small delay increases the @@ -84,6 +119,8 @@ static void rt8515_gpio_brightness_commit(struct gpio_de= sc *gpiod, gpiod_set_value(gpiod, 1); udelay(1); } + + return 0; } =20 /* This is setting the torch light level */ @@ -92,23 +129,38 @@ static int rt8515_led_brightness_set(struct led_classd= ev *led, { struct led_classdev_flash *fled =3D lcdev_to_flcdev(led); struct rt8515 *rt =3D to_rt8515(fled); + int ret =3D 0; =20 mutex_lock(&rt->lock); =20 if (brightness =3D=3D LED_OFF) { /* Off */ - rt8515_gpio_led_off(rt); + ret =3D rt8515_gpio_led_off(rt); + if (ret) + goto out; } else if (brightness < RT8515_TORCH_MAX) { - /* Step it up to movie mode brightness using the flash pin */ - rt8515_gpio_brightness_commit(rt->enable_torch, brightness); + /* + * Step it up to movie mode brightness. + * If there is no separate torch pin, use the flash pin + * for torch as well. + */ + ret =3D rt8515_gpio_brightness_commit(rt, + rt->enable_torch ?: rt->enable_flash, brightness); + if (ret) + goto out; } else { - /* Max torch brightness requested */ - gpiod_set_value(rt->enable_torch, 1); + /* + * Max torch brightness requested. + * If there is no separate torch pin, use the flash pin + * for torch as well. + */ + gpiod_set_value(rt->enable_torch ?: rt->enable_flash, 1); } =20 +out: mutex_unlock(&rt->lock); =20 - return 0; + return ret; } =20 static int rt8515_led_flash_strobe_set(struct led_classdev_flash *fled, @@ -117,27 +169,34 @@ static int rt8515_led_flash_strobe_set(struct led_cla= ssdev_flash *fled, struct rt8515 *rt =3D to_rt8515(fled); struct led_flash_setting *timeout =3D &fled->timeout; int brightness =3D rt->flash_max_intensity; + int ret =3D 0; =20 mutex_lock(&rt->lock); =20 if (state) { /* Enable LED flash mode and set brightness */ - rt8515_gpio_brightness_commit(rt->enable_flash, brightness); + ret =3D rt8515_gpio_brightness_commit(rt, rt->enable_flash, brightness); + if (ret) + goto out; + /* Set timeout */ - mod_timer(&rt->powerdown_timer, - jiffies + usecs_to_jiffies(timeout->val)); + schedule_delayed_work(&rt->powerdown_work, + usecs_to_jiffies(timeout->val)); } else { - timer_delete_sync(&rt->powerdown_timer); + cancel_delayed_work(&rt->powerdown_work); /* Turn the LED off */ - rt8515_gpio_led_off(rt); + ret =3D rt8515_gpio_led_off(rt); + if (ret) + goto out; } =20 fled->led_cdev.brightness =3D LED_OFF; /* After this the torch LED will be disabled */ =20 +out: mutex_unlock(&rt->lock); =20 - return 0; + return ret; } =20 static int rt8515_led_flash_strobe_get(struct led_classdev_flash *fled, @@ -145,7 +204,7 @@ static int rt8515_led_flash_strobe_get(struct led_class= dev_flash *fled, { struct rt8515 *rt =3D to_rt8515(fled); =20 - *state =3D timer_pending(&rt->powerdown_timer); + *state =3D delayed_work_pending(&rt->powerdown_work); =20 return 0; } @@ -163,12 +222,18 @@ static const struct led_flash_ops rt8515_flash_ops = =3D { .timeout_set =3D rt8515_led_flash_timeout_set, }; =20 -static void rt8515_powerdown_timer(struct timer_list *t) +static void rt8515_powerdown_work(struct work_struct *work) { - struct rt8515 *rt =3D timer_container_of(rt, t, powerdown_timer); + struct rt8515 *rt =3D container_of(work, struct rt8515, powerdown_work.wo= rk); + int ret; =20 /* Turn the LED off */ - rt8515_gpio_led_off(rt); + mutex_lock(&rt->lock); + ret =3D rt8515_gpio_led_off(rt); + mutex_unlock(&rt->lock); + + if (ret) + dev_err(rt->dev, "failed to turn off LED (%d)\n", ret); } =20 static void rt8515_init_flash_timeout(struct rt8515 *rt) @@ -298,12 +363,22 @@ static int rt8515_probe(struct platform_device *pdev) return dev_err_probe(dev, PTR_ERR(rt->enable_flash), "cannot get ENF (enable flash) GPIO\n"); =20 - /* ENT - Enable Torch line */ - rt->enable_torch =3D devm_gpiod_get(dev, "ent", GPIOD_OUT_LOW); + /* ENT - Enable Torch line (optional for single-GPIO flash ICs) */ + rt->enable_torch =3D devm_gpiod_get_optional(dev, "ent", GPIOD_OUT_LOW); if (IS_ERR(rt->enable_torch)) return dev_err_probe(dev, PTR_ERR(rt->enable_torch), "cannot get ENT (enable torch) GPIO\n"); =20 + /* Optional VIN supply */ + rt->reg =3D devm_regulator_get_optional(dev, "vin"); + if (IS_ERR(rt->reg)) { + ret =3D PTR_ERR(rt->reg); + if (ret !=3D -ENODEV) + return dev_err_probe(dev, ret, + "failed to get vin supply\n"); + rt->reg =3D NULL; + } + child =3D device_get_next_child_node(dev, NULL); if (!child) { dev_err(dev, @@ -328,12 +403,17 @@ static int rt8515_probe(struct platform_device *pdev) dev_warn(dev, "flash-max-timeout-us property missing\n"); } - timer_setup(&rt->powerdown_timer, rt8515_powerdown_timer, 0); + INIT_DELAYED_WORK(&rt->powerdown_work, rt8515_powerdown_work); rt8515_init_flash_timeout(rt); =20 fled->ops =3D &rt8515_flash_ops; =20 - led->max_brightness =3D rt->torch_max_intensity; + /* + * If there is no separate torch pin, use the flash max intensity + * as the max brightness instead. + */ + led->max_brightness =3D rt->enable_torch ? + rt->torch_max_intensity : rt->flash_max_intensity; led->brightness_set_blocking =3D rt8515_led_brightness_set; led->flags |=3D LED_CORE_SUSPENDRESUME | LED_DEV_CAP_FLASH; =20 @@ -372,7 +452,7 @@ static void rt8515_remove(struct platform_device *pdev) struct rt8515 *rt =3D platform_get_drvdata(pdev); =20 rt8515_v4l2_flash_release(rt); - timer_delete_sync(&rt->powerdown_timer); + cancel_delayed_work_sync(&rt->powerdown_work); mutex_destroy(&rt->lock); } =20 --=20 2.54.0 From nobody Sun Jun 14 04:20:14 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD29A3A7F4E; Sun, 3 May 2026 21:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; cv=none; b=EXHwE4BsMVgKNBvAVJhRNhaZoYYKh0WrEZC15hUuRZ2UBEKwBXuP7hjMEKsKaU+UFiSlizRS1NNtnIFI10B1T2yAzgBZm5gHuWrr+AtPX+Dgal/rwj1fcioYZ3ijjDSSQ/xa33zlrqvELGT52GPlVuO9XIx31Cx05NkoHfvD0tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777844596; c=relaxed/simple; bh=USYQkKC8Cv0A2pYqgRyY+WhGkg5fTpj7dbhEJlN6nQQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bdeTIAMGQshklkRYSVukSdqx4WpxNtVi3Halj2/OCYhmsKOYEgfLWlehXbajoGU0fKk2wD9AUEtx0g1UmcRAb8+lo1jW/tlNEzRfvnMWAmztmqbMrNRN0G0vJs+w+Kq4Zbx+eHYATZU3Wqf2NARS2TjotCujVlHSxMtHrMY3wtU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mgHqYeub; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mgHqYeub" Received: by smtp.kernel.org (Postfix) with ESMTPS id 89C8EC2BCC4; Sun, 3 May 2026 21:43:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777844596; bh=USYQkKC8Cv0A2pYqgRyY+WhGkg5fTpj7dbhEJlN6nQQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mgHqYeubITJQkyCdHP96549Y6tCv9LpRtPfNKUXcLcTtFqaZs0jI4d9iiNjks5Jpl QihYUycUU6ahSDahaKMh159ma6atW+1rgM+P0NTbKecIyjciNzQ6LEFUf0wWbUWefT C2zdoLMM0gFaUHPUsnT8NOP4xijfZP5CWXSiEePUeaQYLG8qv+fQpfM9NcREBL0mBN j/Ay4MlMeFQsyRKm9ZaNzz/sXuSDo+q5A36KyjFNswbUnLTlOZGY2eH6FSTWgbItb4 StqNZDxNic4x3K8FD71czJQDKhsR7Jn/EriWLABLzmPDJczfqjGIM4++TxWxY9ZvSd ijx1gqJyLPT2Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 825B9CD3427; Sun, 3 May 2026 21:43:16 +0000 (UTC) From: Rudraksha Gupta via B4 Relay Date: Sun, 03 May 2026 14:43:17 -0700 Subject: [PATCH v5 3/3] ARM: dts: qcom: msm8960: expressatt: Add camera flash Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260503-expressatt_camera_flash-v5-3-95524506a799@gmail.com> References: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> In-Reply-To: <20260503-expressatt_camera_flash-v5-0-95524506a799@gmail.com> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bjorn Andersson , Konrad Dybcio , Liam Girdwood , Mark Brown Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org, Rudraksha Gupta , David Heidelberg , Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777844595; l=2830; i=guptarud@gmail.com; s=20240916; h=from:subject:message-id; bh=4TPb3tv60VTi1jGXTAHafiOXo9LAWJdtsHID/kn3FOw=; b=dH83lHvmBOCbnxL6ArmC15m16VNwHrcRUDHAo7SQ7PDfnyvg2Ok6Jwv3Aef853LTfYGeL6Oer d+3uC5MokMqDjGuXtqFPLa7gwxK32J3dlqUxCyDAFA9E1q9LBjF09c8 X-Developer-Key: i=guptarud@gmail.com; a=ed25519; pk=ETrudRugWAtOpr0OhRiheQ1lXM4Kk4KGFnBySlKDi2I= X-Endpoint-Received: by B4 Relay for guptarud@gmail.com/20240916 with auth_id=211 X-Original-From: Rudraksha Gupta Reply-To: guptarud@gmail.com From: Rudraksha Gupta Add camera flash support for the Samsung Galaxy Express (expressatt). The flash IC uses a one-wire pulse-count protocol on GPIO 3, powered by a GPIO-controlled fixed regulator on PMIC MPP 4. The regulator is modeled as a regulator-fixed node and supplied to the flash IC via vin-supply. Downstream references: Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/drivers/leds/Makefile#L51 Link: https://github.com/LineageOS/android_kernel_samsung_d2/blob/stable/cm= -12.0-YNG4N/arch/arm/mach-msm/board-apexq-camera.c#L591 Assisted-by: Claude:claude-opus-4.6 Reviewed-by: David Heidelberg Reviewed-by: Konrad Dybcio Signed-off-by: Rudraksha Gupta --- .../dts/qcom/qcom-msm8960-samsung-expressatt.dts | 43 ++++++++++++++++++= ++++ 1 file changed, 43 insertions(+) diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts b/a= rch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts index c4b98af6955d..35514fd53e3d 100644 --- a/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8960-samsung-expressatt.dts @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 #include +#include #include =20 #include "qcom-msm8960.dtsi" @@ -61,6 +62,32 @@ touchkey_enable: touchkey-enable { regulator-boot-on; }; =20 + vreg_flash: regulator-flash { + compatible =3D "regulator-fixed"; + regulator-name =3D "VREG_FLASH_3P3"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + gpio =3D <&pm8921_mpps 4 GPIO_ACTIVE_HIGH>; + enable-active-high; + pinctrl-0 =3D <&flash_led_unlock>; + pinctrl-names =3D "default"; + }; + + led-controller { + compatible =3D "richtek,rt8515"; + enf-gpios =3D <&tlmm 3 GPIO_ACTIVE_HIGH>; + vin-supply =3D <&vreg_flash>; + richtek,rfs-ohms =3D <16000>; + pinctrl-0 =3D <&cam_flash_en>; + pinctrl-names =3D "default"; + + led { + function =3D LED_FUNCTION_FLASH; + color =3D ; + flash-max-timeout-us =3D <250000>; + }; + }; + i2c-gpio-touchkey { compatible =3D "i2c-gpio"; #address-cells =3D <1>; @@ -172,6 +199,13 @@ touchscreen@4a { }; =20 &tlmm { + cam_flash_en: cam-flash-en-state { + pins =3D "gpio3"; + function =3D "gpio"; + drive-strength =3D <16>; + bias-pull-down; + }; + spi1_default: spi1-default-state { mosi-pins { pins =3D "gpio6"; @@ -572,3 +606,12 @@ magnetometer@2e { /* TODO: Figure out Mount Matrix */ }; }; + +&pm8921_mpps { + flash_led_unlock: flash-led-unlock-state { + pins =3D "mpp4"; + function =3D "digital"; + output-low; + power-source =3D ; + }; +}; --=20 2.54.0