From nobody Sun Jun 14 06:08:24 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D758A1DD525 for ; Sat, 2 May 2026 03:10:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777691457; cv=none; b=NYGyauUgDy+WeJVtyCTbWxTC3VjqkUXwWV4wBN8f+ZbQ8koRCtSVEHlTrznR5IvNWGjJ3j0gcd8qWJWmYraugqpCj2cUATWhdHQ88J4IUY3EY5vFWjBjoJS4/aYxS/qgv4a4OV62nFslkIzp6TH7/EqMKahgifZdPJPmQf/wGYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777691457; c=relaxed/simple; bh=er/lmVT+I9xlhlJe/xfcwqXwUuxdcMaR6yHjDE4r0jw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fyaTWjKvBXBO+ZKwlMZBJTbfeyhwoyrr8yrZLH3m4HwxVv5vNH0pI3vrwwqkGPgPE/OENRZ02+N6TqWsWhcGtpBe0Rfq+B32WXFEm6t9gGk3sSKg9uWUZrcEfgVrN5ZPLJKuqhOPJcdfCU2U29ZMyxywEJr4pf1EFvpdyTXgaNQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aiAssfWs; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aiAssfWs" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-44509921fbcso1277216f8f.3 for ; Fri, 01 May 2026 20:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777691454; x=1778296254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=x14cL5TrSHKQAUyN3i9iLjKrG5uGps374ukvFEBMnzY=; b=aiAssfWsTBr/A748ZZ/FTszJhSYuulsyBnP8nZ5EBvdjJPwZWao2TXMuk/pUMYWoJl IYm0bZYThmVuFhfSqK0GFtYODtVR/cKf8Hktt7COiqSrgGryFdj5Y+KcGAp+4qHrOiXk ry+Kf73AFtZAdab1JIuTgvLqEESuNZnXDamabthGhzrO860AW5uKA8zuz4MCmTN7/VFl Nt65nRYKFhk/RbKaVe2UOhdjVV09lfvFLFOqcaiXbeTLsXxPhRblT+AwClaoyrdEwRnL dd6OVnDKu8o/Yjps9ZONe8vecFQU55UkPQJYJLPDoSz0HS1RkMMuiPqxxs54AXwVlNPW 4+dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777691454; x=1778296254; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=x14cL5TrSHKQAUyN3i9iLjKrG5uGps374ukvFEBMnzY=; b=MHFlnoXsR/BdVbrrAP03OOAAm/nHfbJXVbs8C+XgKUhR2DEoSEgekpXUJMKgOeol2w /8wwUEVYdT5P/LS4r4Szw3H6W4Nbh/V9K8C7QO56NucpkZ98zcdbGUQ+yDLPKT6d6Dk+ 2osF308LQtAbSmyue6/QUYfAYfwTDjoVxbdDyqANr75B6gJKfxItGVqcOuOkaqBjHOdD znIe6cJ17uiH2tG1029zJjrb1LL5bq3dZ6DsjzishfIfedpikawZlrNVOggoJebdAVsm qhLGtx13CR1d2ps9TtQFu8CLTfll1d4y8MUGScbVpy2UMyN4bWc2TWDYJANfGsSehSLJ vkIQ== X-Forwarded-Encrypted: i=1; AFNElJ8WpK/eJkC6PNFVLUI51zwSZjiujyKK9rJxfW8MsMp4xcfuMDJWMHpO+hZq8ixpTfP+NdIa/m9tH+5B4qk=@vger.kernel.org X-Gm-Message-State: AOJu0YxLjBP4DLDI5YK5ef6c56Qs7zG4q2MfvTv00cFAj4hF9sMEJ6gy pwW0ijukPRF6WPQi6dQKV/zGS+YTndicEyL5JEmV6VYPhRlyez9zhiB0 X-Gm-Gg: AeBDievu/FQpoDfFfGcAnJ6XMWSNynBmfEx645uUrq9voixg/oXAeaGjIsH3EldsUOF Tbv+4ADVbL6X+ihnG2QFbih5acy4RPLOqxB/FiyRizXm+XMw0P2nEj9PTMk9CUOVe9IYZC5Q+QX b45D1q6tLG3/uKAa7ERfmGPqa22Wn0j4S1tJsTNiu0xG9SMRFDCIyqZPwHKFnefsHsiJHJpL6Eu LVSaU6+Y1AMX+CeLcCFr4tYzq43mNDvDDuJY8SNe7/Xct8IutUojXPKH1gGkKNQ2YyybcmcidjT RP+bz41qK5nLLhE/2x62ZSsr8vmxiCXkg3tj8ykHPobQAd2Zxwx+t5IYI86ucv08RRB2kJdxe7s jcj+wy1qUEyDPx/o13BQbnQ57Ti8XqNKUFTdafSUiqCqc8cce5BUASjqD9Efhoeb4Q0NIi1gc+/ FhLwR6XIbZ8ImgHl0P8ZayHw/Lgb7WYQh3Zunzjm/rUKPeeine/qzU X-Received: by 2002:a05:6000:1acb:b0:43d:71f4:7ed4 with SMTP id ffacd0b85a97d-44bb3d8a1ecmr2721223f8f.15.1777691454258; Fri, 01 May 2026 20:10:54 -0700 (PDT) Received: from archlinux ([2a02:6b60:60:a500::100f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44acad8f974sm7111137f8f.23.2026.05.01.20.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 20:10:53 -0700 (PDT) From: Hussain Qadri To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Hussain Qadri Subject: [PATCH v2] drm/bridge: tc358762: Use mipi_dsi_generic_write_multi() Date: Sat, 2 May 2026 04:10:08 +0100 Message-ID: <20260502031008.45873-1-hussain.bqadri@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the driver-local error accumulation around mipi_dsi_generic_write() with mipi_dsi_generic_write_multi() and struct mipi_dsi_multi_context. Signed-off-by: Hussain Qadri --- Changes in v2: - Remove extra blank line in tc358762_write(). - Rebase onto current master. drivers/gpu/drm/bridge/tc358762.c | 47 +++++++++++-------------------- 1 file changed, 16 insertions(+), 31 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc3= 58762.c index 98df3e667d4a..739283fc51db 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -76,26 +76,12 @@ struct tc358762 { struct gpio_desc *reset_gpio; struct drm_display_mode mode; bool pre_enabled; - int error; }; =20 -static int tc358762_clear_error(struct tc358762 *ctx) +static void tc358762_write(struct mipi_dsi_multi_context *dsi_ctx, u16 add= r, u32 val) { - int ret =3D ctx->error; - - ctx->error =3D 0; - return ret; -} - -static void tc358762_write(struct tc358762 *ctx, u16 addr, u32 val) -{ - struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev); - ssize_t ret; u8 data[6]; =20 - if (ctx->error) - return; - data[0] =3D addr; data[1] =3D addr >> 8; data[2] =3D val; @@ -103,9 +89,7 @@ static void tc358762_write(struct tc358762 *ctx, u16 add= r, u32 val) data[4] =3D val >> 16; data[5] =3D val >> 24; =20 - ret =3D mipi_dsi_generic_write(dsi, data, sizeof(data)); - if (ret < 0) - ctx->error =3D ret; + mipi_dsi_generic_write_multi(dsi_ctx, data, sizeof(data)); } =20 static inline struct tc358762 *bridge_to_tc358762(struct drm_bridge *bridg= e) @@ -115,17 +99,19 @@ static inline struct tc358762 *bridge_to_tc358762(stru= ct drm_bridge *bridge) =20 static int tc358762_init(struct tc358762 *ctx) { + struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D dsi }; u32 lcdctrl; =20 - tc358762_write(ctx, DSI_LANEENABLE, + tc358762_write(&dsi_ctx, DSI_LANEENABLE, LANEENABLE_L0EN | LANEENABLE_CLEN); - tc358762_write(ctx, PPI_D0S_CLRSIPOCOUNT, 5); - tc358762_write(ctx, PPI_D1S_CLRSIPOCOUNT, 5); - tc358762_write(ctx, PPI_D0S_ATMR, 0); - tc358762_write(ctx, PPI_D1S_ATMR, 0); - tc358762_write(ctx, PPI_LPTXTIMECNT, LPX_PERIOD); + tc358762_write(&dsi_ctx, PPI_D0S_CLRSIPOCOUNT, 5); + tc358762_write(&dsi_ctx, PPI_D1S_CLRSIPOCOUNT, 5); + tc358762_write(&dsi_ctx, PPI_D0S_ATMR, 0); + tc358762_write(&dsi_ctx, PPI_D1S_ATMR, 0); + tc358762_write(&dsi_ctx, PPI_LPTXTIMECNT, LPX_PERIOD); =20 - tc358762_write(ctx, SPICMR, 0x00); + tc358762_write(&dsi_ctx, SPICMR, 0x00); =20 lcdctrl =3D LCDCTRL_VSDELAY(1) | LCDCTRL_RGB888 | LCDCTRL_UNK6 | LCDCTRL_VTGEN; @@ -136,17 +122,16 @@ static int tc358762_init(struct tc358762 *ctx) if (ctx->mode.flags & DRM_MODE_FLAG_NVSYNC) lcdctrl |=3D LCDCTRL_VSPOL; =20 - tc358762_write(ctx, LCDCTRL, lcdctrl); + tc358762_write(&dsi_ctx, LCDCTRL, lcdctrl); =20 - tc358762_write(ctx, SYSCTRL, 0x040f); + tc358762_write(&dsi_ctx, SYSCTRL, 0x040f); msleep(100); =20 - tc358762_write(ctx, PPI_STARTPPI, PPI_START_FUNCTION); - tc358762_write(ctx, DSI_STARTDSI, DSI_RX_START); + tc358762_write(&dsi_ctx, PPI_STARTPPI, PPI_START_FUNCTION); + tc358762_write(&dsi_ctx, DSI_STARTDSI, DSI_RX_START); =20 msleep(100); - - return tc358762_clear_error(ctx); + return dsi_ctx.accum_err; } =20 static void tc358762_post_disable(struct drm_bridge *bridge, --=20 2.54.0