From nobody Sun Jun 14 07:39:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931D63F076C; Fri, 1 May 2026 16:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651863; cv=none; b=h2TPwMNc6gFwa8UL3G6tv67f2224ahydwDLrUP/wHPkJy2zX6/08mQecZsXzROgBfpIQ8llQLJsDS+t2MK90WeeErNlA5XdkQn30MebPrCLM46hwXM7B4Q64WglBRUNwAhJktWmx2ENbVTITj9FXpita1WOM8aEiVDg7W8dfNo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651863; c=relaxed/simple; bh=8k+27dFEfk9gvTOLyx3sRRHfGTcjySdSAWkUG6LSWcs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fj26HAYurbyk5UFlwqdYl3QM9QpXyuOlC6N6caJDXpFyax2buootoWZhtIqiyc1s7xHTgpMhgin+rGV1re+gATQhknev9L7Wto8QqiM5ENm2isF7Kn2FYCAiiHjOjvES9BPJVHC5gOaRbHlrrASK3S9G17F1sT/rUGZJQ45fuNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=UHqoEiuE; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="UHqoEiuE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=iO UEMne7+s7Kfd5u4r0P7fMHEsYx2/gNI7ikiiDLoOg=; b=UHqoEiuEwLA5zVenqU pz+9iRF3g6EDDW+L0LS4e74nIEvuG0zhYDjn24w1m//6Ej8sz5B0xWH3XcR+nG0z ztv+nIhTsZ2ADyk3x3nIcqtEOxaT785ZNtHgayyRpO1+37Xtrjh/XU4Drj5iXJQg +QJ1pQHbGcha23ULZrxQbv6pM= Received: from zhb.. (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDnj5Fk0PRprTQgCw--.53438S3; Sat, 02 May 2026 00:10:14 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, mani@kernel.org, vigneshr@ti.com Cc: xrobh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 1/4] PCI: dra7xx: Use common mode field in struct dw_pcie Date: Sat, 2 May 2026 00:10:07 +0800 Message-Id: <20260501161010.71688-2-18255117159@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260501161010.71688-1-18255117159@163.com> References: <20260501161010.71688-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnj5Fk0PRprTQgCw--.53438S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur15Ar15AF15XFW7Cw1xZrb_yoW8tr1Dpw 43AFWayF4rX3W5uF1fAF1qg3WSqF9ava48JrsrCw4xtasxCrn8JF4rA34j93yfKFW8uryU t3Wrtr4xX3WaqFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0z_Ma0DUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbC7AfkiGn00GeBEQAA39 Content-Type: text/plain; charset="utf-8" Remove the redundant mode field from struct dra7xx_pcie and use the existing mode field in struct dw_pcie instead. This avoids duplication and prevents potential inconsistencies between the two mode fields. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Bjorn Helgaas --- drivers/pci/controller/dwc/pci-dra7xx.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controll= er/dwc/pci-dra7xx.c index cd904659c321..88b4c486ea66 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -92,7 +92,6 @@ struct dra7xx_pcie { struct phy **phy; struct irq_domain *irq_domain; struct clk *clk; - enum dw_pcie_device_mode mode; }; =20 struct dra7xx_pcie_of_data { @@ -328,7 +327,7 @@ static irqreturn_t dra7xx_pcie_irq_handler(int irq, voi= d *arg) dev_dbg(dev, "Link Request Reset\n"); =20 if (reg & LINK_UP_EVT) { - if (dra7xx->mode =3D=3D DW_PCIE_EP_TYPE) + if (dra7xx->pci->mode =3D=3D DW_PCIE_EP_TYPE) dw_pcie_ep_linkup(ep); dev_dbg(dev, "Link-up state change\n"); } @@ -828,7 +827,7 @@ static int dra7xx_pcie_probe(struct platform_device *pd= ev) default: dev_err(dev, "INVALID device type %d\n", mode); } - dra7xx->mode =3D mode; + dra7xx->pci->mode =3D mode; =20 ret =3D devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler, IRQF_SHARED | IRQF_ONESHOT, @@ -841,7 +840,7 @@ static int dra7xx_pcie_probe(struct platform_device *pd= ev) return 0; =20 err_deinit: - if (dra7xx->mode =3D=3D DW_PCIE_RC_TYPE) + if (dra7xx->pci->mode =3D=3D DW_PCIE_RC_TYPE) dw_pcie_host_deinit(&dra7xx->pci->pp); else dw_pcie_ep_deinit(&dra7xx->pci->ep); @@ -865,7 +864,7 @@ static int dra7xx_pcie_suspend(struct device *dev) struct dw_pcie *pci =3D dra7xx->pci; u32 val; =20 - if (dra7xx->mode !=3D DW_PCIE_RC_TYPE) + if (pci->mode !=3D DW_PCIE_RC_TYPE) return 0; =20 /* clear MSE */ @@ -882,7 +881,7 @@ static int dra7xx_pcie_resume(struct device *dev) struct dw_pcie *pci =3D dra7xx->pci; u32 val; =20 - if (dra7xx->mode !=3D DW_PCIE_RC_TYPE) + if (pci->mode !=3D DW_PCIE_RC_TYPE) return 0; =20 /* set MSE */ --=20 2.34.1 From nobody Sun Jun 14 07:39:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE313DEFFF; Fri, 1 May 2026 16:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651868; cv=none; b=NR9ICU9+WUh7xDjsjgZah8XLItMSYr0voxX/X61lEGBYzebr6VCcpPcD1FvBrwWsIFS0w0t7ObUCj/Xw957THzG5BsBgfTAuRcRgzQPxWUg4XyBQbQqPuowvKObVrFnW5YSkKwPcbygkSlQD5NzsKDYu5ObUvEwIDD7RVunNGyM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651868; c=relaxed/simple; bh=qCZ7+FTUS/Hn//6ThtgbDIk0bVz7oxOVsARIacdR1e4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FjsMyQS4DoLVvtJVRPrb+MhXHf109U4Qq6+VQa43bQTzcCBQXxtVLY5ONviRSTFr/5ap3R+NvLr3L7P7Wok/KanVBap+QRhZkKZ9OSV5aCx1wty5HJ4AXv8MnE2R8+kh+P67UuehsgsmmR647pwmJUAcVmuVmPFBIV6yvYiwNJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=VH3tuX9G; arc=none smtp.client-ip=220.197.31.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="VH3tuX9G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=dg kPg52SHjT92fZN3GmRatnnw8IkUdithEYIjhUqkSk=; b=VH3tuX9GiChBrryzX+ Ogmg3ll6UEhLuWyz9H+7fca2L+Cwgpjs11ynbugXlN7Q2idJcD2T6iEiWyy0ESA0 iHlqbUOAmYnEBLhz108QFxVgJtQISIMhtk+YTXNtCAWHoHUkNPikPtJVHt3MreNU 9GzYbW4NbrUwhchj5FGtzH4l4= Received: from zhb.. (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDnj5Fk0PRprTQgCw--.53438S4; Sat, 02 May 2026 00:10:15 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, mani@kernel.org, vigneshr@ti.com Cc: xrobh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 2/4] PCI: artpec6: Use common mode field in struct dw_pcie Date: Sat, 2 May 2026 00:10:08 +0800 Message-Id: <20260501161010.71688-3-18255117159@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260501161010.71688-1-18255117159@163.com> References: <20260501161010.71688-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnj5Fk0PRprTQgCw--.53438S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur1UZFy5Xr1fGw43tw4ktFb_yoW8uryxpa 95JayFkr18JF43ua1fAFn8ur1ayrnIvry8J39xW34SgFy5urWDGr1UKFWxtFyS9FWktF1j y3WIyFyfAa13ZrUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zMksqUUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbCwwfkiGn00GeC8AAA3w Content-Type: text/plain; charset="utf-8" Remove the redundant mode field from struct artpec6_pcie and use the existing mode field in struct dw_pcie instead. This avoids duplication and prevents potential inconsistencies between the two mode fields. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Bjorn Helgaas --- drivers/pci/controller/dwc/pcie-artpec6.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-artpec6.c b/drivers/pci/contro= ller/dwc/pcie-artpec6.c index 55cb957ae1f3..5cd227dda9a1 100644 --- a/drivers/pci/controller/dwc/pcie-artpec6.c +++ b/drivers/pci/controller/dwc/pcie-artpec6.c @@ -34,7 +34,6 @@ struct artpec6_pcie { struct regmap *regmap; /* DT axis,syscon-pcie */ void __iomem *phy_base; /* DT phy */ enum artpec_pcie_variants variant; - enum dw_pcie_device_mode mode; }; =20 struct artpec_pcie_of_data { @@ -100,7 +99,7 @@ static u64 artpec6_pcie_cpu_addr_fixup(struct dw_pcie *p= ci, u64 cpu_addr) struct dw_pcie_rp *pp =3D &pci->pp; struct dw_pcie_ep *ep =3D &pci->ep; =20 - switch (artpec6_pcie->mode) { + switch (artpec6_pcie->pci->mode) { case DW_PCIE_RC_TYPE: return cpu_addr - pp->cfg0_base; case DW_PCIE_EP_TYPE: @@ -413,7 +412,7 @@ static int artpec6_pcie_probe(struct platform_device *p= dev) =20 artpec6_pcie->pci =3D pci; artpec6_pcie->variant =3D variant; - artpec6_pcie->mode =3D mode; + artpec6_pcie->pci->mode =3D mode; =20 artpec6_pcie->phy_base =3D devm_platform_ioremap_resource_byname(pdev, "phy"); @@ -428,7 +427,7 @@ static int artpec6_pcie_probe(struct platform_device *p= dev) =20 platform_set_drvdata(pdev, artpec6_pcie); =20 - switch (artpec6_pcie->mode) { + switch (artpec6_pcie->pci->mode) { case DW_PCIE_RC_TYPE: if (!IS_ENABLED(CONFIG_PCIE_ARTPEC6_HOST)) return -ENODEV; @@ -464,7 +463,7 @@ static int artpec6_pcie_probe(struct platform_device *p= dev) =20 break; default: - dev_err(dev, "INVALID device type %d\n", artpec6_pcie->mode); + dev_err(dev, "INVALID device type %d\n", artpec6_pcie->pci->mode); } =20 return 0; --=20 2.34.1 From nobody Sun Jun 14 07:39:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1CED3E276B; Fri, 1 May 2026 16:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651861; cv=none; b=Iu3SuwFudHDlb9ynz+LKG1M5ry9yYe7XT6dQLGhCH42Jq6HKlCOkxunWWZwvMwiAlbjA+Hm0a8kX//FFWHf5PZubgR3UvyhdLHPvs818CPpF5NLemlp1OOMxfV/Fh8xUMhPLjfPDAXllOCNZGdjRCQHxh3FWqG4YoPDYp1uaGoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651861; c=relaxed/simple; bh=mPb2+HAJItCNx8S0AqjRV/VyHIQ6FcKWpG90RQfhWn0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O5bTnY62r/16eDAjdAyolst6eOL1atWjbCGbJx4Wt5H2X/T+SHWe6ncokXUk2LdM5TFfEOzJfgfbk3SRQ4YAZ+apOLaFi0mB7Nm0JzmC+owd3XF4+YUccl9ZQzDAmCRmyYtjxhwqHNkkZgIjNZAbeQgytI+fMZBTHJ23UsKpqGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=ImopmSxZ; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="ImopmSxZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=KG fyutr9NVoGvTUlIXOXiA28E7UEWjuoT1/s044+Usw=; b=ImopmSxZK7V+KlVwJg 8Y5z3MJkwC9cw4OycE3vEaOzPxNzCVjC/8wV3mKK2e1pVU79qzH8BgJDcSk5p/qS tcv0CDqOWuUUfUAcgrAemv6Y/JgorVJqYO11WLe6AV4fx/WpW1eX9ntx2DNDeKH2 iu+frgGq+F2/tdF6Qc3EdqSqg= Received: from zhb.. (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDnj5Fk0PRprTQgCw--.53438S5; Sat, 02 May 2026 00:10:16 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, mani@kernel.org, vigneshr@ti.com Cc: xrobh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 3/4] PCI: dwc: Use common mode field in struct dw_pcie Date: Sat, 2 May 2026 00:10:09 +0800 Message-Id: <20260501161010.71688-4-18255117159@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260501161010.71688-1-18255117159@163.com> References: <20260501161010.71688-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnj5Fk0PRprTQgCw--.53438S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur18Jr13JFy5Cw15tw43ZFb_yoW8XF4kpa 1UXayfAa18uayF9as3Z3Z8ur4akF98A3yUGFsxWw17KFy2grWDGr18Kry2qryfKrWxJw1U tw17tFZruF45X3JanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRYXdbUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbCxAjliWn00GiLhAAA3K Content-Type: text/plain; charset="utf-8" Remove the redundant mode field from struct dw_plat_pcie and use the existing mode field in struct dw_pcie instead. This avoids duplication and prevents potential inconsistencies between the two mode fields. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Bjorn Helgaas --- drivers/pci/controller/dwc/pcie-designware-plat.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware-plat.c b/drivers/pc= i/controller/dwc/pcie-designware-plat.c index d103ab759c4e..d02286678a0a 100644 --- a/drivers/pci/controller/dwc/pcie-designware-plat.c +++ b/drivers/pci/controller/dwc/pcie-designware-plat.c @@ -22,7 +22,6 @@ =20 struct dw_plat_pcie { struct dw_pcie *pci; - enum dw_pcie_device_mode mode; }; =20 struct dw_plat_pcie_of_data { @@ -118,11 +117,11 @@ static int dw_plat_pcie_probe(struct platform_device = *pdev) pci->dev =3D dev; =20 dw_plat_pcie->pci =3D pci; - dw_plat_pcie->mode =3D mode; + dw_plat_pcie->pci->mode =3D mode; =20 platform_set_drvdata(pdev, dw_plat_pcie); =20 - switch (dw_plat_pcie->mode) { + switch (dw_plat_pcie->pci->mode) { case DW_PCIE_RC_TYPE: if (!IS_ENABLED(CONFIG_PCIE_DW_PLAT_HOST)) return -ENODEV; @@ -148,7 +147,7 @@ static int dw_plat_pcie_probe(struct platform_device *p= dev) =20 break; default: - dev_err(dev, "INVALID device type %d\n", dw_plat_pcie->mode); + dev_err(dev, "INVALID device type %d\n", dw_plat_pcie->pci->mode); ret =3D -EINVAL; break; } --=20 2.34.1 From nobody Sun Jun 14 07:39:55 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B8D3F7892; Fri, 1 May 2026 16:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651859; cv=none; b=NfUDtLWZwLtPrEg29YuIiHxbNkC1b0FtO77UmlgM/rHY5jUw345OGVV5nijAvaHaGJUkY6VK0JIGPchzM78lIVLCX++4ddM7Q63xtP76vw43iy47hjKJj/aGBzANe5InapUlMzgQTNABD4XA7o/mKQX/ntGHve14+kxF+5XOfg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777651859; c=relaxed/simple; bh=rAsj4u2tfgRsmxLm9NtQ/qWrh9K4qsQPxZFdIUeP/Lo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hMMUI3CY3OWbahMn0lyq/jbLZpGadlCzvc/GieHDjcAN5vk6a4ovQpzBmdQV97JolyF1pgjmoke0L1agpMUD4IDJrGwX6FTZvRY+kdNthbPKOw2yXTR7TRkOzDVr7KpZ/MpABfRnDWZIRQDInxbC9kbhWpOozJXS/NHANboCWYU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=f18Eybwg; arc=none smtp.client-ip=117.135.210.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="f18Eybwg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=8u iX4L3xeKeeisliCglYutoH5NPUyLqLrb+hkDqZi3E=; b=f18EybwgPy0o82TzKL C/26IAmCRrjPORQJk2Xb3oNwjNiPT8PiZEt1ytZFc+VXT6V53X9c9KVQDYpme6lK 5phe4bYML3lOX4Oyr5sia4DPfU+wjm7+ly5Upjs7KekBQNsArIhKFhkg7Qf87SJd r3r8pl4WqeWsljwnAkuhjsIiI= Received: from zhb.. (unknown []) by gzga-smtp-mtada-g1-4 (Coremail) with SMTP id _____wDnj5Fk0PRprTQgCw--.53438S6; Sat, 02 May 2026 00:10:16 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: lpieralisi@kernel.org, kwilczynski@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, mani@kernel.org, vigneshr@ti.com Cc: xrobh@kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 4/4] PCI: keembay: Use common mode field in struct dw_pcie Date: Sat, 2 May 2026 00:10:10 +0800 Message-Id: <20260501161010.71688-5-18255117159@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260501161010.71688-1-18255117159@163.com> References: <20260501161010.71688-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDnj5Fk0PRprTQgCw--.53438S6 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur1UZFy5Xr1fGw4fur1Dtrb_yoW8CF1xpa y5WayFk3WrJa4ru3WfA3Z8Zr1avFs0va4jkrsruwn2qa4agry7GF18KFyUtas3KrW8tw17 tw1ayFWxua13tFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pE_-PUUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbCxAjliWn00GiLjwAA3B Content-Type: text/plain; charset="utf-8" Remove the redundant mode field from struct keembay_pcie and use the existing mode field in struct dw_pcie instead. This avoids duplication and prevents potential inconsistencies between the two mode fields. Signed-off-by: Hans Zhang <18255117159@163.com> Reviewed-by: Bjorn Helgaas --- drivers/pci/controller/dwc/pcie-keembay.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-keembay.c b/drivers/pci/contro= ller/dwc/pcie-keembay.c index 7cf2c312ecec..2459c4d66b88 100644 --- a/drivers/pci/controller/dwc/pcie-keembay.c +++ b/drivers/pci/controller/dwc/pcie-keembay.c @@ -58,7 +58,6 @@ struct keembay_pcie { struct dw_pcie pci; void __iomem *apb_base; - enum dw_pcie_device_mode mode; =20 struct clk *clk_master; struct clk *clk_aux; @@ -117,7 +116,7 @@ static int keembay_pcie_start_link(struct dw_pcie *pci) u32 val; int ret; =20 - if (pcie->mode =3D=3D DW_PCIE_EP_TYPE) + if (pcie->pci.mode =3D=3D DW_PCIE_EP_TYPE) return 0; =20 keembay_pcie_ltssm_set(pcie, false); @@ -409,7 +408,7 @@ static int keembay_pcie_probe(struct platform_device *p= dev) pci->dev =3D dev; pci->ops =3D &keembay_pcie_ops; =20 - pcie->mode =3D mode; + pcie->pci.mode =3D mode; =20 pcie->apb_base =3D devm_platform_ioremap_resource_byname(pdev, "apb"); if (IS_ERR(pcie->apb_base)) @@ -417,7 +416,7 @@ static int keembay_pcie_probe(struct platform_device *p= dev) =20 platform_set_drvdata(pdev, pcie); =20 - switch (pcie->mode) { + switch (pcie->pci.mode) { case DW_PCIE_RC_TYPE: if (!IS_ENABLED(CONFIG_PCIE_KEEMBAY_HOST)) return -ENODEV; @@ -443,7 +442,7 @@ static int keembay_pcie_probe(struct platform_device *p= dev) =20 break; default: - dev_err(dev, "Invalid device type %d\n", pcie->mode); + dev_err(dev, "Invalid device type %d\n", pcie->pci.mode); return -ENODEV; } =20 --=20 2.34.1