From nobody Sun Jun 14 07:37:07 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 031853C13F0 for ; Fri, 1 May 2026 14:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777646584; cv=none; b=C0G6rOAEtJUR9OMt1hUAd89/+x6C9IxMBonufo9qCbHCNgyMlVpPSQnYpmbVRAVim5MUmP+/q53cEwprJ8lHthKYAK/uNVoO6obGrZq8bt0gpk9LYPk+KJQ4qofBOrYKSrZ0sC2EhNUW1FklXfZvpQszddIcXDziwt+N2rDUlR8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777646584; c=relaxed/simple; bh=OI4NP/H5Tu98kAYcNthFp1AzOnt//uoeLqCrWwLp4CM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Qf+oRtqaSb0ofmOfJVWzy1P0DCm1OAQZIXTeMkGeQdMJiNnNY3gTTTO36ZXTcOhP38dIdd3RHtOACA5/QhMPespFQ8AL5I6PWaQQvFqysgFviD1lkD2JRGWSjKoRw3Xh/9rMZxD6GSIXmD/EzKSfoTaFOM3aKG3EHsQe5nhX0hI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sYsnktrW; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sYsnktrW" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82f8892d4d6so928017b3a.0 for ; Fri, 01 May 2026 07:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777646582; x=1778251382; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lO72bdGdZwejIJb7TOURovIvs6tmJN/3DIyI5HlYHnk=; b=sYsnktrWTbdDwHPNQe886NpP4UpJnq1ODG+e7A0PLcvHgcGbJrKSfGi4oW1znFJ47o nsrFwArtKjeXcU1Rxl9NSwDhfrmQ1jZYBFxPU4ANqYlS+Y4Ie2wnl++Xb2tGiaqMzEmh YS9Wod7c2N4ESwusCR1yBvnWx/8YWfvl8lCt05fNgGFnGwY5BEOLpi0nYXYthjwSZ6bx W7QVjJMJPdXEZapkvqrvI+QvD9+78jKj6fWg9va+Q2cOt3z/77qfb163n5QZsoFWBp7P 3nouSb+WHM+4oR3InvF5TRO9YpoB+5ioN1NWFjoSFC7ldsFL0ONaapGqgs8HoOiCGy/K emNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777646582; x=1778251382; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lO72bdGdZwejIJb7TOURovIvs6tmJN/3DIyI5HlYHnk=; b=rhup408neWeJtr42DWmNpbYiLLAWgpFZQLIUTOgFTVF0A0OlGm3WgCEhD2ABC27eks Oa4PDjeo4Gbv9OJZWVM5J0LuGGYJa3qHjJT76BX2v9m1ya55iLQxiIQ+Ny169tkb4QzC YOFT30rf31yiXxjJo8bq5IGr4lTYflpMMmxsoOZpTmYjowxjbzIjp2Cn6AEOFaoEShRv hyJpjeoEXBc2Syfu5SqVQELKN2tqL9p22FDixD1wl/bPmImg5boZBbWvuBcIr/kxs1OK JRQAyf+M+NtJhmW3/G7fNGaN3S/Grd2DFN3dKXcCtI84W3Dcenn/mgfWv0i0QCF7ZVAe Mm2Q== X-Forwarded-Encrypted: i=1; AFNElJ/iiRTWvke3UKtzmyrcQF5lqtpiDMzeXWF1TwHMdt2MG9MWCDnRc9e1EQsv9MPuzUKXHVgFJ1pjqz6z4IE=@vger.kernel.org X-Gm-Message-State: AOJu0Yzl9zvWBIb/7tIDkwejNrp/dyuqOSjUNMm5ZrDoDNVAuozko7gI x8p2T/gxcUjLSxD+WXeUOBRpGVkZHT15oN6LpiSSA4EDprF/LqRCZy4Y X-Gm-Gg: AeBDievtLNrQXE+DrFI5w0Zi0y5wgiSkV5v8ZZ3CV40h3+LEQp62+i9W3Og7PxVt8SU 0gzhu783Yy8uQa58VtToQz891P9+bFfrbUo5IRRsFVk0DLPQwPhbavaRo8XZApjtpa344X6f7Qk +OXnVwG0N7f754mQWVcgz4tvTbjKxIrE7RfONy8iB34KFmECORE0nTKa9+XwqWzG25sC5YD/por wEQy0aHosfdohNds37sPMHKSOP1j7/yfjy46h5RuKd4vtjkWHLelwLhhPjPd/rjfGAtgPPT+Qv/ lddI7pNSpIq/xmBxVWCZCiSvZEcgAxJnoa9B4ne/puV2EqcVBhY2V29/oszpG1YegIm88Ng6NrM K+PdIOoLjxkvbZQAA7xtEnGFFIK4GevxXWVMr2OO0JxJq3p+pzQ0Mi0jVLhiWAOsHcIvqSBHNT+ 6tJHmeb7ptUs2ji3gXhzkYwe11OjYb1XYcTW5HXB0V1hW33NyKEghcTi4DHqxOlCz9ee8q8CWnt xmYtjOuuGGpM7YHqITZ0ATX89lAjNHMFKxOZIIOlcoY X-Received: by 2002:a05:6a00:391c:b0:82a:6461:6d1e with SMTP id d2e1a72fcca58-834fdcc4b03mr8472519b3a.46.1777646582202; Fri, 01 May 2026 07:43:02 -0700 (PDT) Received: from shyam-VMware-Virtual-Platform.localdomain ([223.181.115.140]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83515b5b921sm3498062b3a.54.2026.05.01.07.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 07:43:01 -0700 (PDT) From: Shyam Sunder Reddy Padira To: vaibhav.sr@gmail.com, mgreer@animalcreek.com, johan@kernel.org, elder@kernel.org, gregkh@linuxfoundation.org Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Shyam Sunder Reddy Padira Subject: [PATCH v2] staging: greybus:add missing newline in sysfs show() output Date: Fri, 1 May 2026 20:12:08 +0530 Message-ID: <20260501144207.25211-2-shyamsunderreddypadira@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sysfs show() functions should return newline-terminated strings.Add missing newline to sysfs_emit() format string. Signed-off-by: Shyam Sunder Reddy Padira ---- v2: -Remove "no functional changes" from the description as per Greg's feedback. --- drivers/staging/greybus/audio_manager_module.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/stagi= ng/greybus/audio_manager_module.c index dc90cc2d2308..5737f2a32f5a 100644 --- a/drivers/staging/greybus/audio_manager_module.c +++ b/drivers/staging/greybus/audio_manager_module.c @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj) static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *m= odule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%s", module->desc.name); + return sysfs_emit(buf, "%s\n", module->desc.name); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_name_attri= bute =3D @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_name_attribute =3D static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.vid); + return sysfs_emit(buf, "%d\n", module->desc.vid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attrib= ute =3D @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_= module_vid_attribute =3D static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *mo= dule, struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.pid); + return sysfs_emit(buf, "%d\n", module->desc.pid); } =20 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attrib= ute =3D @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_a= udio_manager_module *modu struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "%d", module->desc.intf_id); + return sysfs_emit(buf, "%d\n", module->desc.intf_id); } =20 static struct gb_audio_manager_module_attribute @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.ip_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices); } =20 static struct gb_audio_manager_module_attribute @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct g= b_audio_manager_module *m struct gb_audio_manager_module_attribute *attr, char *buf) { - return sysfs_emit(buf, "0x%X", module->desc.op_devices); + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices); } =20 static struct gb_audio_manager_module_attribute --=20 2.43.0