From nobody Sun Jun 14 07:48:40 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC961DE8BB for ; Fri, 1 May 2026 07:11:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777619472; cv=none; b=MX0WBATnmuaa1rXcw/lylQpjSSGX9MoNRb2cuL1yAhAJUbaG8UJc2QN2f7KUNJX0KwTL9IwpxPvIWdmt4yj4tOlcXn1VyrCyT5oDnmD231Jy/Op6bHorLJBMFnb6a1WNX0H7O11tEOzEYC65knyp/e2FE4QHeaaqLdfyrXt69jU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777619472; c=relaxed/simple; bh=qqVUv7Vtrk0KCtuyR4oVlM85/SaLXy9Twir6cBezLt8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=WYbLnWFDDsbMTAPCOZP7D0BRlfuIoi+WYeKW64eeF1AZ6YSzMKZgHda8ZdFWJBno1kD7mHSm+Duj8LPpr1KMU0Sgh/T/A3MIGkEx+Qka8oUEn9/2WRINzOeCD0Xc+LvuNe+GxaI9hR2iI3I5+O66UlY6iqvJmkmBYpJQe4c23uQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: ea36cd02452c11f1aa26b74ffac11d73-20260501 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:57fbce40-2fc3-497d-a7e8-9245e9a4a0d0,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:47b0f265292cc354347195d513e60c1a,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:- 3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,A V:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: ea36cd02452c11f1aa26b74ffac11d73-20260501 X-User: zenghongling@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1428246412; Fri, 01 May 2026 15:11:03 +0800 From: Hongling Zeng To: shaggy@kernel.org, hubcap@omnibond.com, martin@omnibond.com, jkoolstra@xs4all.nl, viro@zeniv.linux.org.uk, richard@nod.at, jlayton@kernel.org, jack@suse.cz, brauner@kernel.org, neil@brown.name Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, zhongling0719@126.com, Hongling Zeng Subject: [PATCH] fs: Fix return in jfs_mkdir and orangefs_mkdir Date: Fri, 1 May 2026 15:10:58 +0800 Message-Id: <20260501071058.1243245-1-zenghongling@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Return NULL instead of passing to ERR_PTR while err is zero Fixes these smatch warnings: - fs/jfs/namei.c:311 jfs_mkdir() warn: passing zero to 'ERR_PTR' - fs/orangefs/namei.c:369 orangefs_mkdir() warn: passing zero to 'ERR_PTR' Fixes: 88d5baf69082 ("Change inode_operations.mkdir to return struct dentry= *") Signed-off-by: Hongling Zeng Reviewed-by: Jori Koolstra --- fs/jfs/namei.c | 2 +- fs/orangefs/namei.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index 60c4a0e0fca5..442d62679262 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c @@ -309,7 +309,7 @@ static struct dentry *jfs_mkdir(struct mnt_idmap *idmap= , struct inode *dip, out1: =20 jfs_info("jfs_mkdir: rc:%d", rc); - return ERR_PTR(rc); + return rc ? ERR_PTR(rc) : NULL; } =20 /* diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c index bec5475de094..75e65e72c2d6 100644 --- a/fs/orangefs/namei.c +++ b/fs/orangefs/namei.c @@ -362,7 +362,7 @@ static struct dentry *orangefs_mkdir(struct mnt_idmap *= idmap, struct inode *dir, __orangefs_setattr(dir, &iattr); out: op_release(new_op); - return ERR_PTR(ret); + return ret ? ERR_PTR(ret) : NULL; } =20 static int orangefs_rename(struct mnt_idmap *idmap, --=20 2.25.1