From nobody Tue Jun 16 14:50:18 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E104C2147E5 for ; Fri, 1 May 2026 02:35:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602944; cv=none; b=f9elyfyV04x8a0vc/C3HveaSHy8IAoHQlXYn88OEcZ84jVVXu4CDYq65hbVjacGE0QO6VReg/gqMZaSoTco06irdwk5uf+dTiOghan1DvK3bhG/43yiW+QlehSOxbyJmxJyobUEyQZS32cO86PU0vi2xwQwK2WhtKs9rOUzq1dA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602944; c=relaxed/simple; bh=Aocggj3/ePT4e+jesYw7vvuMFmGQ27GviwPBpJeA378=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XdS/tTd/LMskY+F8r2t0mHxgdci/E88i1QFy8SJflVxIpt6p+fvbNeYriOviM+tggeUl6vTPvN3nbgG7kuZu3ir5Bryk/DzfIsf2zo/miTrSw9pfB1wVWhlFM8oJ9bQ2C3ndoBow2+9BVp6dZHbbGQhD1aCBBJeXWnrDXlUIzm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rAn1fXZH; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rAn1fXZH" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2b23fcf90b2so13717425ad.3 for ; Thu, 30 Apr 2026 19:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777602942; x=1778207742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BSfAJ6VemJUOPmI4zNJhVr/AZDIzWGdUsU6uHQklRW0=; b=rAn1fXZHJD+cUUsNuJppNI0jtcY1SFSTZVyVBdvAFMZTgojUvRKFZXlBPLUNgOHGue yWgWeRPoXaAVzjyb37PHmz7AItj9wTOS/6ufQ64UmuiPrsKSJGwXyDyuJKRkqUc2tDEK OJdBX5PThwYjzCZnEduTwOOw9M/fr0xYv1DakaL0ixSTN0OwZyJV/quHTqlkpHsD8ZA6 gPIUCp3BDXPl0jYB6E5DiYPWtUrcVaP/xSdvOzlWnlgaUnYIueNVdN4M9Mvpas2+rdmA 8iQn/G8cdTFOWmEDGqECbOeoo5rscT1G3DrtQ3rkzzSMv7xZZ5UONycKyTBNmWpBiOIx efZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777602942; x=1778207742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BSfAJ6VemJUOPmI4zNJhVr/AZDIzWGdUsU6uHQklRW0=; b=YaYTOcNpUer76boN2D2Sygz45sM17d12gZGKSk0O8mxRrDWQ27GcbOJqYBGAJ75Pja JIn9jjqRFiOKId9qw2bhtHf8pQ9ikpQ3M7uPFgp9iviZyIJHLl4dGwc/GFDx0ZUPdUW5 1OfrHmOa28nuNZ4Ati5M5qGjmerlSSmTPWuUPGozlZ/rDb+Y7tWEe2Esx1KI10IGtEM6 jMieiQXXekmhjNOMOUwYVhWPhNwecJ8wN95AlhnhliCGeoKPqVnoWyWoSW+08H/ujzIM tTaOHnNhc/2fjmagPYjBfdCNEl+xWFe9CanwCuPbvQH496o+QsHgXhlrL3zGz8P+RtsK /L4g== X-Forwarded-Encrypted: i=1; AFNElJ/rfW/F76vjoA7IkaXNMv+dcnRLaQsZ8zsaGKW1kes/QbXgvsKhRMOX+U/V6EUnaD96Dup5r0NnMF4GL/g=@vger.kernel.org X-Gm-Message-State: AOJu0YwcoKrqqOVAh/qLBbDgvnPAxHVvPdrDVChknzVeJjlmwMwLY1TC YRWMWcVcvbfATfwoNMEB3aK7jsafzj/ClRvxBgtqb3SAd+xcJL7I2qa9jx9FTUkHgMU= X-Gm-Gg: AeBDieucEib6Pdqmj7TAmDLd1HfTB40CgaDPpUpWYFN0t83dwiY7Vh0/H3Wa1+9aiZF VIKlegfRP7t/oD+tntBtWkTEQ5nLuoFoTi4SPHKkl4R0dDUZOG6mhGE2t/VkPkO6cmIHLnrWu1J BT5BlTGNrypLYVfX2D3TTqtNpgg3LFeoJb1/mQwj7MggvW+sFFPnIHbwwrU9SFFmW5vJTYPT3E6 s0e4hmcdw+3Kex6SOpYJE/aoKt2Rs9G5FhZdtSfEQoq5tC6HUn22S+aezhHz41fOlLz3ab3rnlZ U52gAN6YFJxRemBN1DD5pQugtqgCmZiuo9eFlm/m4gPm1C+82B1iOe7hAs4nbxNv0maIvd5Wvb5 pgnso5iY3QuG82vffnWk3UVdNC7ikV8J9zGn0pyqFy2CB0TpuYcgzk5h1T2wG2LDjhi1s16JDuo O66LJHHkZIodK60TiEu9b6cjql03M6nS/sE/ripewAd2hT3xjpiIiSlzCJL76kC3RMcumHAtyqz Fwl4Tl93WeON4B8 X-Received: by 2002:a17:903:2ed0:b0:2b2:4a9a:b168 with SMTP id d9443c01a7336-2b9a23175c0mr57603095ad.11.1777602942231; Thu, 30 Apr 2026 19:35:42 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([116.72.73.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caa7e791sm9341385ad.7.2026.04.30.19.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 19:35:41 -0700 (PDT) From: Tabrez Ahmed To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed , Sashiko Subject: [PATCH v5 1/3] hwmon: (ads7871) Fix endianness bug in 16-bit register reads Date: Fri, 1 May 2026 08:05:28 +0530 Message-ID: <20260501023530.31160-2-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260501023530.31160-1-tabreztalks@gmail.com> References: <20260501023530.31160-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ads7871_read_reg16() function relies on spi_w8r16() to read the 16-bit sensor output. The ADS7871 device transmits the Least Significant Byte (LSB) first. On Little-Endian architectures, spi_w8r16() correctly reconstructs the 16-bit value. However, on Big-Endian architectures, the byte swapping causes the first received byte (LSB) to be placed in the most significant byte of the u16, resulting in corrupted voltage readings. Replace spi_w8r16() with a manual spi_write_then_read() into a byte array, and safely reconstruct the integer using get_unaligned_le16() to ensure correct behavior across all architectures. Additionally, use a u8 variable for the command byte to ensure the correct instruction is transmitted on Big-Endian systems. Reported-by: Sashiko Closes: https://sashiko.dev/#/patchset/20260418034601.90226-1-tabreztalks@g= mail.com Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 9bfdf9e6bcd77..d77eff430935b 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -59,9 +59,9 @@ #include #include #include +#include =20 #define DEVICE_NAME "ads7871" - struct ads7871_data { struct spi_device *spi; }; @@ -77,9 +77,17 @@ static int ads7871_read_reg8(struct spi_device *spi, int= reg) static int ads7871_read_reg16(struct spi_device *spi, int reg) { int ret; + u8 tx_cmd; + u8 rx_buf[2]; + reg =3D reg | INST_READ_BM | INST_16BIT_BM; - ret =3D spi_w8r16(spi, reg); - return ret; + tx_cmd =3D reg; + + ret =3D spi_write_then_read(spi, &tx_cmd, 1, rx_buf, 2); + if (ret < 0) + return ret; + + return get_unaligned_le16(rx_buf); } =20 static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) --=20 2.43.0 From nobody Tue Jun 16 14:50:18 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465312E542C for ; Fri, 1 May 2026 02:35:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602948; cv=none; b=Ivo/ITy7WFWMOwL0Kpsg2RDK6J+9tWWJ8wQ4bMDmopOYOSMpoCCM90eClxoDzzEa3rMKif9IF/Maop6E/diMSyyxxT69urUsw89CmQZ+KWwGlcljW650aVpbFaqKfOTyWLSeobGthBkMumeLhVPYwiyZrojZSQzFlLvzphce25I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602948; c=relaxed/simple; bh=9AD+sWVcHYNPoIFmmk3/5rOSx+pg8pD2UCVgRe/R8aI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nomccErnIJJpD6xEwEPvHQOwH0M4Smek3hGpEr0nfMUvoaplTvFJqVaoqM4Nzi0clkEzA6AFxJi9lLdaDZJByIz8BIMB0bE7BIr8o+Bs5bEtdObuL3ass8OJiNN/0c2vw1xdK0rjTEiBU1Szw+2OCHDBYs8KqFg1NqsSQZut0Aw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ds91pBir; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ds91pBir" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2aaed195901so6452055ad.0 for ; Thu, 30 Apr 2026 19:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777602946; x=1778207746; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ysAHD8xZwiZRKow0zKqhNf3kHU5xNvNRM3EOuIQkgs=; b=Ds91pBir/odF9e1+IoTbtgLnFQrdEyjo4C6doexHQgg3emmWsZnv9RHjErtJzQTmtO sV4b1WwtUq6BpHDFXr2PmelP8/cF0Eqlh2L5BYTfExxPKgSBfaI5gIYLB61QGMBTo30b hQWTEqUp+SHX5Fs9llG5Q2oau7SKGBrKQN2Syi27wGO8R/t08Qwye2sWUjAjk5mhaVdz UQdFeYnXzBVQnSx7UwowVikZ7muAQWNFqrwoZWtYHEXipVHipxdVt1YB27oPqgEJlCG3 eQWm1biPAUvNWoNlWx8FRYv9H6NIvzatHAm+O0cDn+Rjg7JUxSAIIAabPa1c5QX16reZ PwJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777602946; x=1778207746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6ysAHD8xZwiZRKow0zKqhNf3kHU5xNvNRM3EOuIQkgs=; b=aX1gG3728qVr2WBSskSveWxEIaiA/We1/tXTKHpq+2cNV5VnO7gG2VNZQAg0fpQWZs Abi8iXvBia9sC6udezOdykpZAtNcliNDifqV9873N9/zrQo8/hv8jZDPsw8Ig409813T 02h+NjFRMiycdGEPaO7TgF1zEJ9i0Loem0k7XmcGYd4wlsC8Z05rBmJ6yuk2ZclThOHR sDO/MK5KFx1Q4C+sRNjv1AlmXxz5rrBnxZbLCZHZBNE01GWHssqI9d3RUo8xGeVM5XzM Znh4pi/vM6dC9f7CE0ovLzku2IZzG8JEKMnlkvG88rcwlH2nIOEWqfrlmXdHoJ7izUfp NTGg== X-Forwarded-Encrypted: i=1; AFNElJ979uHbU/TzByx4mjNNCN3vGxG0XDJ9aJ/RYuKf1wgDsR9zkjzQ2v+U+5CL9s/B1dHXp6kLz1zgfVKP67U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc50OMxij6MxxviheQaKOBBy028WNnL3GHmAvtWhXDC6DXvwel /TwTRhx25/nLPETWvBadJHQVPlicAYQZZwpcrUGmsEg9ymKUycnKAy2U X-Gm-Gg: AeBDievQkCgbD2Ox0b3wo/SMv709TXRuIHbR7u6sduyIdirBgqgqEvkvIVl0F7j1SLB SnOpJOixhvldlLxkyshvvjtamKG/dnA4cttJ8A3Th5YmoYuYK8J6EZQwPySNHPhiTckpm2QLv7m G7l1YXeEZ+eudbNilufkWLIbG7+51whlaupi0TnZbaswnXoDuNv07Bsv+juiKYzhtrKNM1FXHHf bluD0TvXNsYBGrYYuVt8YmUvkMhIxPqPvuRMlJKWPTLLwDU99XWEicrGoFEWC7zT/rXtBDwnpr+ bafjzjXloWFi7AzlWi7KD/vwgyod2eE0fUXVEdjPVY7s9vvUGK4+muCSqmMifRxw1mo2ssWFMNe +ihXta1fqTopK6tdIDQwQpIRVUcr4OyXQnkNyQjrrW5iBpkjDOFXzwN0Q30FykwuppUyV/+/M36 J97gxm956qXYONFKV0YBjq19uOTJGBDHlYfoiG7z5zu8mrdYVgt7uTPgnZTm82vU+Bi2NBaVzBM VYYog== X-Received: by 2002:a17:903:8cc:b0:2b4:689a:e420 with SMTP id d9443c01a7336-2b9d3bab7bamr9899725ad.8.1777602945589; Thu, 30 Apr 2026 19:35:45 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([116.72.73.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caa7e791sm9341385ad.7.2026.04.30.19.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 19:35:45 -0700 (PDT) From: Tabrez Ahmed To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed Subject: [PATCH v5 2/3] hwmon: (ads7871) Convert to hwmon_device_register_with_info Date: Fri, 1 May 2026 08:05:29 +0530 Message-ID: <20260501023530.31160-3-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260501023530.31160-1-tabreztalks@gmail.com> References: <20260501023530.31160-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the ads7871 driver from the legacy hwmon_device_register() to the modern hwmon_device_register_with_info() API. This migration simplifies the driver by using the structured hwmon_channel_info approach and prepares the codebase for the transition to a shared DMA-safe buffer. While at it, fix checkpatch violations. Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 75 ++++++++++++++++++++++------------------- 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index d77eff430935b..75485a2c16b0b 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -56,7 +56,6 @@ #include #include #include -#include #include #include #include @@ -66,6 +65,16 @@ struct ads7871_data { struct spi_device *spi; }; =20 +static umode_t ads7871_is_visible(const void *data, + enum hwmon_sensor_types type, + u32 attr, int channel) +{ + if (type =3D=3D hwmon_in && attr =3D=3D hwmon_in_input) + return 0444; + + return 0; +} + static int ads7871_read_reg8(struct spi_device *spi, int reg) { int ret; @@ -93,19 +102,20 @@ static int ads7871_read_reg16(struct spi_device *spi, = int reg) static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) { u8 tmp[2] =3D {reg, val}; + return spi_write(spi, tmp, sizeof(tmp)); } =20 -static ssize_t voltage_show(struct device *dev, struct device_attribute *d= a, - char *buf) +static int ads7871_read(struct device *dev, enum hwmon_sensor_types type, + u32 attr, int channel, long *val) { struct ads7871_data *pdata =3D dev_get_drvdata(dev); struct spi_device *spi =3D pdata->spi; - struct sensor_device_attribute *attr =3D to_sensor_dev_attr(da); - int ret, val, i =3D 0; - uint8_t channel, mux_cnv; + int ret, raw_val, i =3D 0; + u8 mux_cnv; =20 - channel =3D attr->index; + if (type !=3D hwmon_in || attr !=3D hwmon_in_input) + return -EOPNOTSUPP; /* * TODO: add support for conversions * other than single ended with a gain of 1 @@ -135,39 +145,34 @@ static ssize_t voltage_show(struct device *dev, struc= t device_attribute *da, } =20 if (mux_cnv =3D=3D 0) { - val =3D ads7871_read_reg16(spi, REG_LS_BYTE); - if (val < 0) - return val; + raw_val =3D ads7871_read_reg16(spi, REG_LS_BYTE); + if (raw_val < 0) + return raw_val; + /*result in volts*10000 =3D (val/8192)*2.5*10000*/ - val =3D ((val >> 2) * 25000) / 8192; - return sysfs_emit(buf, "%d\n", val); + *val =3D ((raw_val >> 2) * 25000) / 8192; + return 0; } =20 return -ETIMEDOUT; } =20 -static SENSOR_DEVICE_ATTR_RO(in0_input, voltage, 0); -static SENSOR_DEVICE_ATTR_RO(in1_input, voltage, 1); -static SENSOR_DEVICE_ATTR_RO(in2_input, voltage, 2); -static SENSOR_DEVICE_ATTR_RO(in3_input, voltage, 3); -static SENSOR_DEVICE_ATTR_RO(in4_input, voltage, 4); -static SENSOR_DEVICE_ATTR_RO(in5_input, voltage, 5); -static SENSOR_DEVICE_ATTR_RO(in6_input, voltage, 6); -static SENSOR_DEVICE_ATTR_RO(in7_input, voltage, 7); - -static struct attribute *ads7871_attrs[] =3D { - &sensor_dev_attr_in0_input.dev_attr.attr, - &sensor_dev_attr_in1_input.dev_attr.attr, - &sensor_dev_attr_in2_input.dev_attr.attr, - &sensor_dev_attr_in3_input.dev_attr.attr, - &sensor_dev_attr_in4_input.dev_attr.attr, - &sensor_dev_attr_in5_input.dev_attr.attr, - &sensor_dev_attr_in6_input.dev_attr.attr, - &sensor_dev_attr_in7_input.dev_attr.attr, +static const struct hwmon_channel_info * const ads7871_info[] =3D { + HWMON_CHANNEL_INFO(in, + HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT, + HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT, HWMON_I_INPUT), NULL }; =20 -ATTRIBUTE_GROUPS(ads7871); +static const struct hwmon_ops ads7871_hwmon_ops =3D { + .is_visible =3D ads7871_is_visible, + .read =3D ads7871_read, +}; + +static const struct hwmon_chip_info ads7871_chip_info =3D { + .ops =3D &ads7871_hwmon_ops, + .info =3D ads7871_info, +}; =20 static int ads7871_probe(struct spi_device *spi) { @@ -202,10 +207,10 @@ static int ads7871_probe(struct spi_device *spi) return -ENOMEM; =20 pdata->spi =3D spi; - - hwmon_dev =3D devm_hwmon_device_register_with_groups(dev, spi->modalias, - pdata, - ads7871_groups); + hwmon_dev =3D devm_hwmon_device_register_with_info(dev, spi->modalias, + pdata, + &ads7871_chip_info, + NULL); return PTR_ERR_OR_ZERO(hwmon_dev); } =20 --=20 2.43.0 From nobody Tue Jun 16 14:50:18 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2904A231835 for ; Fri, 1 May 2026 02:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602950; cv=none; b=UrhbAewhZtSMDVAXDs4hQo6HvpKUQ3JIt8KX1CxdIdFDWSlnUzTKFZQmZM4cITb/9wqjSARR9hNkCKtOg0qIs+gxHJUSosP07YarqqnK/VXVaCUumU6+d0vRRErNTiN6aeocxARCWtgzvFBSc+iLy9lkp+U0AEuWBmKwg+Ido0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777602950; c=relaxed/simple; bh=nI7jEuFl5Wx1BRcYnNc+rTGFK7F6A8M4xO6oyFoLWrk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LQyweRdbolMtCyBeeNw9S/O+qOi2sSD4OUQOw8btzk1PR8uMMSpPAMhzJN3IAGqY8t15iFjzPy53leAjo7DrIe+Pk/pj2LQnvVSnhFp8olrnBsf1zHy8JI2vRYPb4SRgoLpC9otwjAev5puHZXZtJurr9BjkxWbWTvKLIYIcMp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Kf9ClMGu; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Kf9ClMGu" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2b941cd869cso9673615ad.1 for ; Thu, 30 Apr 2026 19:35:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777602948; x=1778207748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kSnHTefyeA+2hwX9yr/+mpxR4GkNtCtvVO+4GeW9P5U=; b=Kf9ClMGuYeuHvyKoEwrVB2k92lRLV1k31k1WmBJWnLobS56JvKzlHmy2CQ8j5E3ElT L/arynh51/Fhcs/pOA6HgMl2P2wUjTE2o/Pnz4RL+vpPGCKjvhAMN/4ePvMpiHw0WWfG gjHva2//BQrIXi7s4PCEJ5n+boDcQw8RiJzapYWqWi1hyDsf01BmOhM1O1ad8FSXYWKc PkKT/vQwRJDUsbR3IJFaYuzv4aFqEblejo8Ax8aTqxbc1XZ+y6R8kFCAmJO48sw8LpS/ QvFxNcgODDtpICYGWlrRgg9ppqAFDDNWH3sDCYAghrHY6c/9ooGZIdtHiKAtVxO3t+F9 zPOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777602948; x=1778207748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kSnHTefyeA+2hwX9yr/+mpxR4GkNtCtvVO+4GeW9P5U=; b=arw6ImGI/SVolNEjhw16Ba4E/ffvdM7/nuxc1RE9LFrSWd2jAy5to0wt3yxbr4pQJi l7O1+VXUhXLP8APmfftvhZS9yRfpbJjLoNEs3b4vBaPJ9570ffbLmcE/m83qucKXBbYG ushC1MGKTs6u6h/Sn0YLMNLsdUjcO9Zl1JSuQ8mkjTjP/xL3YhYnPSTkg7iLWQlHbyYU ASRuMQLytTnx6+Lwx/UWfJHXyh/vPlnGgs6w6BrwfhxEx5jo+zQBQWUqSR3lmMb9Yn7+ NbzVhWduQSm3HE2yqBlIDbKmXAHbHhGY0jS5Cr+j10XoHtWVOM2aWmT7n9FowT2DOSD0 fkmw== X-Forwarded-Encrypted: i=1; AFNElJ/fdLm9GIVsJUxvkuXNUV6UroE9c9mqvDvqpXYJJwttpFGV+mLBI7Y/BGCot3BETZVhdHuAog60e4GI1SU=@vger.kernel.org X-Gm-Message-State: AOJu0YzDJnG6d1cObDpW19KTUd7t/YKZ1LRHeJtfxNieHYsD63GvhGnJ yCc0qRhuPTLPmCz6s7UissEfTbQEYdrnAveYJI5cB+Y5sw2Vx5xOchvy X-Gm-Gg: AeBDievpE+QRQvRlljn+engJf1XUm29GgDfx66Vr+8DFEpN9a225PwVHGJDS4F5W7Ud hTjieXy7rSwLv+ul6/iF1LTFX96DyqOcH8hVjCk1Mq63GztxJeXRBKHyPEq/y7VMRfcJGCCLJUQ bPzYtP4va5qlW04Q3pU5/qnllXrNsXuNRE+fp7P2UIC4TojDI9hOUAJjbhR5bGawFUmgazWzZ2+ auyzMunJgVkUqGXnBDOQwvabEVG8khs8TDeixr304Yj2kYR801x4IZ2W8B8402Ewtm0Tq7fTo/Z PsBZefP7wOQiHmtutM1m8+gT+h4E+ri1e0ON3mkuzuYkQK2OvmG2rtP66WkIr0qq+dlQ9WS/RQy Atk8sf5606VGzr6FkGx+roc8sprHM2GhxpRXsYZqL1TG0250vfOVjVBCrexuEQsmPLcHjLFCLNB s+MCYDdMoC4fHpgGaWKXRe6Mfz2ZnSoo1AH5AIHaLPGvZrfxWQdZWq1cm49nQ4JJE+y5acRT2+M K0o3DinhBMBuALi X-Received: by 2002:a17:902:b186:b0:2b2:4fe3:7b89 with SMTP id d9443c01a7336-2b9a2546e2dmr41331905ad.38.1777602948495; Thu, 30 Apr 2026 19:35:48 -0700 (PDT) Received: from tabrez-VivoBook-ASUSLaptop-X513UA-KM513UA.. ([116.72.73.183]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9caa7e791sm9341385ad.7.2026.04.30.19.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 19:35:48 -0700 (PDT) From: Tabrez Ahmed To: Guenter Roeck Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, shuah@kernel.org, me@brighamcampbell.com, Tabrez Ahmed Subject: [PATCH v5 3/3] hwmon: (ads7871) Use DMA-safe buffer for SPI writes Date: Fri, 1 May 2026 08:05:30 +0530 Message-ID: <20260501023530.31160-4-tabreztalks@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260501023530.31160-1-tabreztalks@gmail.com> References: <20260501023530.31160-1-tabreztalks@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently passes a stack-allocated buffer to spi_write(), which is incompatible with DMA on systems with CONFIG_VMAP_STACK enabled. Move the transfer buffer into the driver's private data structure to ensure it is DMA-safe. Since this shared buffer now requires serialization, this change depends on the previous commit which migrated the driver to the hwmon 'with_info' API. While moving the logic, also: - Corrected the sign extension for 14-bit data by casting to s16. - Scaled the output to millivolts (2500mV full scale ) to comply with the hwmon ABI. Signed-off-by: Tabrez Ahmed --- drivers/hwmon/ads7871.c | 35 +++++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 75485a2c16b0b..cbb9a88229c50 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c @@ -63,6 +63,7 @@ #define DEVICE_NAME "ads7871" struct ads7871_data { struct spi_device *spi; + u8 tx_buf[2] ____cacheline_aligned; }; =20 static umode_t ads7871_is_visible(const void *data, @@ -99,11 +100,12 @@ static int ads7871_read_reg16(struct spi_device *spi, = int reg) return get_unaligned_le16(rx_buf); } =20 -static int ads7871_write_reg8(struct spi_device *spi, int reg, u8 val) +static int ads7871_write_reg8(struct ads7871_data *pdata, int reg, u8 val) { - u8 tmp[2] =3D {reg, val}; + pdata->tx_buf[0] =3D reg; + pdata->tx_buf[1] =3D val; =20 - return spi_write(spi, tmp, sizeof(tmp)); + return spi_write(pdata->spi, pdata->tx_buf, 2); } =20 static int ads7871_read(struct device *dev, enum hwmon_sensor_types type, @@ -122,7 +124,7 @@ static int ads7871_read(struct device *dev, enum hwmon_= sensor_types type, */ /*MUX_M3_BM forces single ended*/ /*This is also where the gain of the PGA would be set*/ - ret =3D ads7871_write_reg8(spi, REG_GAIN_MUX, + ret =3D ads7871_write_reg8(pdata, REG_GAIN_MUX, (MUX_CNV_BM | MUX_M3_BM | channel)); if (ret < 0) return ret; @@ -130,6 +132,7 @@ static int ads7871_read(struct device *dev, enum hwmon_= sensor_types type, ret =3D ads7871_read_reg8(spi, REG_GAIN_MUX); if (ret < 0) return ret; + mux_cnv =3D ((ret & MUX_CNV_BM) >> MUX_CNV_BV); /* * on 400MHz arm9 platform the conversion @@ -149,8 +152,11 @@ static int ads7871_read(struct device *dev, enum hwmon= _sensor_types type, if (raw_val < 0) return raw_val; =20 - /*result in volts*10000 =3D (val/8192)*2.5*10000*/ - *val =3D ((raw_val >> 2) * 25000) / 8192; + /* + * Use (s16) to ensure the sign bit is preserved during the shift. + * Report millivolts (2.5V =3D 2500mV). + */ + *val =3D ((s16)raw_val >> 2) * 2500 / 8192; return 0; } =20 @@ -187,11 +193,17 @@ static int ads7871_probe(struct spi_device *spi) spi->bits_per_word =3D 8; spi_setup(spi); =20 - ads7871_write_reg8(spi, REG_SER_CONTROL, 0); - ads7871_write_reg8(spi, REG_AD_CONTROL, 0); + pdata =3D devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL); + if (!pdata) + return -ENOMEM; + + pdata->spi =3D spi; + + ads7871_write_reg8(pdata, REG_SER_CONTROL, 0); + ads7871_write_reg8(pdata, REG_AD_CONTROL, 0); =20 val =3D (OSC_OSCR_BM | OSC_OSCE_BM | OSC_REFE_BM | OSC_BUFE_BM); - ads7871_write_reg8(spi, REG_OSC_CONTROL, val); + ads7871_write_reg8(pdata, REG_OSC_CONTROL, val); ret =3D ads7871_read_reg8(spi, REG_OSC_CONTROL); =20 dev_dbg(dev, "REG_OSC_CONTROL write:%x, read:%x\n", val, ret); @@ -202,11 +214,6 @@ static int ads7871_probe(struct spi_device *spi) if (val !=3D ret) return -ENODEV; =20 - pdata =3D devm_kzalloc(dev, sizeof(struct ads7871_data), GFP_KERNEL); - if (!pdata) - return -ENOMEM; - - pdata->spi =3D spi; hwmon_dev =3D devm_hwmon_device_register_with_info(dev, spi->modalias, pdata, &ads7871_chip_info, --=20 2.43.0