From nobody Sun Jun 14 07:48:41 2026 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D80303806A1 for ; Fri, 1 May 2026 09:18:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627119; cv=none; b=Gijk6tRnb5MpQ2RliVHBrPBO7pgV7I7tgvIr2ddOqi2eBswSXvmV+PvkwpTyUnOvneb+ecSuiPuhqpSw0DSoNOBVTRWgfEhgFr3b5frIqBEqURMY3YMnAN6XllcC6rtkfbhCwEGlbn+vlO8tAqjiJ63cln+30o208Lw5ccPlJRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627119; c=relaxed/simple; bh=h6Sc8ib7tRtd6w/326yX/61ibb/uDm234KS+EP440os=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hY4uHC6pet3Wy4tnoHy4Wz8j2ixiHTBjkFkSLN9+VIslLqZ3m/XnnzdH0fmytu95sb+godo47kG5SYMTmFtbqJE8oagFJwLbP61RCRlMg8+LDF1j0aM3mrQJW0QsgSB7j+XfTmMz3tIMVXw5mVIZy2gk80xE8O/oEU++sgl7Jx4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=RHYd+TXz; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="RHYd+TXz" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-483487335c2so19013405e9.2 for ; Fri, 01 May 2026 02:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777627116; x=1778231916; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fSd831WLWoomwvW5VsvsxASYGj8v1cMtz1VOawQMGgc=; b=RHYd+TXzjCAeXC0lyBCO0gGa/ei7QEV1J/8RsPZ9b1x/4iQMQgMhkvyHoL+4r84TSv /Xl43Yb0J2dMVW/1XdGwLv5EX07Hyt+H2fGBbLTy+W3PLB9+j/NP5DEKKEzgrOrkVcMF mbQ0sn1jOJZwAZS/9dtca/6JgUctm51LrhxxC50qTfTheU3CcIjW94bJ5dPU7W1PJ/N4 ybAfBYh3iNN6nj38GAcQKvCFQedWDDyY+vmbHQc8rjBretjZQ5UVbjvHzHRpP9TD5ZYf 8fDXaZYxtWORnihFV7WKicOVM89V7ZxG5lm0b6RnLgTZ0qhorSBgzjFBdDpJSIclj63S Rugg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777627116; x=1778231916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fSd831WLWoomwvW5VsvsxASYGj8v1cMtz1VOawQMGgc=; b=DMhUvJ/lCn5DJBdqhYqlaitlIoIYV0LCuBd43IHKhAHQ+VGaTf8V9mZ954JgSRGtba i6Df3PE70aHJ4LmSSHIyW6pUnQwVzX/bDVjhPBaCdJfwHI7NVUdMtKBK4rqQigoZtVcY /fGqf1q4uuuhRreqNm/dk9etAxNDkGQljepvQYZlwm3lqDtYF3IN3MPKoxNJl0Q9uW6Q c+NLok0Pk1TmgWnVua2ywmZPxidxAe8O4A07G5nULSw/MT9vhuylp/YS2Heur+F+m4NA kzeZnYyQu5xPRYzGuCtEwQ7aQP55Hcw99w+9Y9JgGfK0rpa/94iKEx8Q0KiDeAYWBQgd aekA== X-Forwarded-Encrypted: i=1; AFNElJ9lf7JA9/uIQHWo9KbaZ6hyPRu9u9DrUVvWYRM3gInszrilgc5LnisaccARij7QLS+C02A0oymYEPqXW7M=@vger.kernel.org X-Gm-Message-State: AOJu0YyhkSEwRDMT2QydGbEPOf8Ll8IAhF9tvskBBrp08e3n2/1OcCyU DGq2yvFiNlb1iEFVX1GyVyTY/vfykfLlRHjh1l2cO8Y1Sy+81UqzwO7zV2V2srhRtUA= X-Gm-Gg: AeBDiev3kamTzO5fGjhWzFHwLjZM4f4dXqqdPzBvS6qBudqIZOzrRvxXSHc3EysQbGA cIyRyDwVsldWNwqXrv7L2S2Nk5jPjvoaWtUS+D/SW+XFbEiz2H6lLjgB9xHtFEAeaIlb9vKa0JR CAAIYFvnFZAqhbaF9n6FvaKHn2Bm9RJ+f9lGA8yhNrxX/MKSY5+N4iL4X4pKCOr4KOBgTlWxUqG 8olTrUVIyF3uSCh99E29kiXDKOiS21HnBG6GDY0R9w9gaB8P7xkwVajnIO4ExdtOa8ggjthLU9W GCdPCQ7PY93+MqTKZRN2FZ3ZA2skxlzuOVzchxBjHQaJCpnVFLYPDrSOaPnOcoKWkU8KM4ftEVf 4g3NeAcpBLIKpz9bsL2FdXDhpun0jYP1oH0GYbFU5y0hWdNLzdkO9bjk42fOuf8xQ/lMlWVetLn KlpSPhMClazfkFRiiAqHKg8cHivRVAM5fBM+0Z7aH5eX8AxFyrXCNmmkAwhEykQ3ODvnl5QvMB4 GibpTn0 X-Received: by 2002:a05:600c:6994:b0:488:a916:14a8 with SMTP id 5b1f17b1804b1-48a844ebae7mr99326285e9.10.1777627116383; Fri, 01 May 2026 02:18:36 -0700 (PDT) Received: from [192.168.178.36] (046124199213.public.t-mobile.at. [46.124.199.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a98b76fd0sm3820787f8f.35.2026.05.01.02.18.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:18:36 -0700 (PDT) From: Luca Weiss Date: Fri, 01 May 2026 11:18:29 +0200 Subject: [PATCH v2 1/5] interconnect: Add devm_of_icc_get_by_index() as exported API for users Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-milos-camcc-icc-v2-1-bb83c1256cc3@fairphone.com> References: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> In-Reply-To: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Mike Tipton , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss , Konrad Dybcio , Dmitry Baryshkov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777627112; l=2340; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=h6Sc8ib7tRtd6w/326yX/61ibb/uDm234KS+EP440os=; b=EkStrO4AgPi/QOnRLNXv0FW3BxXmJs0IsGB/Ss3Vm8o1Bu7DHupW/HkJYypIrV4+9V/F3WscB BHOpdj2kPn+D+jrj3Khz4feDFEWrY4W1mc/sEASIxpRrmw4vgb44cSl X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Users can use devm version of of_icc_get_by_index() to benefit from automatic resource release. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss Acked-by: Georgi Djakov --- drivers/interconnect/core.c | 20 ++++++++++++++++++++ include/linux/interconnect.h | 6 ++++++ 2 files changed, 26 insertions(+) diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 8569b78a1851..bc2e416dbcb2 100644 --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -443,6 +443,26 @@ struct icc_path *devm_of_icc_get(struct device *dev, c= onst char *name) } EXPORT_SYMBOL_GPL(devm_of_icc_get); =20 +struct icc_path *devm_of_icc_get_by_index(struct device *dev, int idx) +{ + struct icc_path **ptr, *path; + + ptr =3D devres_alloc(devm_icc_release, sizeof(*ptr), GFP_KERNEL); + if (!ptr) + return ERR_PTR(-ENOMEM); + + path =3D of_icc_get_by_index(dev, idx); + if (!IS_ERR(path)) { + *ptr =3D path; + devres_add(dev, ptr); + } else { + devres_free(ptr); + } + + return path; +} +EXPORT_SYMBOL_GPL(devm_of_icc_get_by_index); + /** * of_icc_get_by_index() - get a path handle from a DT node based on index * @dev: device pointer for the consumer device diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h index 4b12821528a6..75a32ad0482e 100644 --- a/include/linux/interconnect.h +++ b/include/linux/interconnect.h @@ -47,6 +47,7 @@ struct icc_path *of_icc_get(struct device *dev, const cha= r *name); struct icc_path *devm_of_icc_get(struct device *dev, const char *name); int devm_of_icc_bulk_get(struct device *dev, int num_paths, struct icc_bul= k_data *paths); struct icc_path *of_icc_get_by_index(struct device *dev, int idx); +struct icc_path *devm_of_icc_get_by_index(struct device *dev, int idx); void icc_put(struct icc_path *path); int icc_enable(struct icc_path *path); int icc_disable(struct icc_path *path); @@ -79,6 +80,11 @@ static inline struct icc_path *of_icc_get_by_index(struc= t device *dev, int idx) return NULL; } =20 +static inline struct icc_path *devm_of_icc_get_by_index(struct device *dev= , int idx) +{ + return NULL; +} + static inline void icc_put(struct icc_path *path) { } --=20 2.54.0 From nobody Sun Jun 14 07:48:41 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786BC3815F5 for ; Fri, 1 May 2026 09:18:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627121; cv=none; b=g4pxPZubI+YlOyKsSXGAlFU97EbqTqfHm4o3z1d1ZaWivPXgJN7Ry/7VSHDDTeaEG33RvHwnTrs0faTzIm7tIiuwJLeN//rrEKXJhEZ2jhIunXId0mM33/CE7VjObL2rB00TJFrZPtfxTRrFeJjSH19nUgsaAkd6exsr0CSMjDg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627121; c=relaxed/simple; bh=YmwJZh9JOI6WzIBDXZoUlM82ToEJjTRJKA1/rBWV68o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uODpBr6SO4UZTULILE04W5bbrS3FIfiWRQHOEBAF+HDSJnyh/ca4v8QM/Ahhhq/osB7TrS48XUEu8Vmh094OTmRMnC+FO4Y1TzAuN0Eio6dUy+gGQRVhrTYQumeiXOe7FvxivD3dYkYNiJFSJIWdXEAjplOtFoRgriY57hswzNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=Owb5HHBa; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="Owb5HHBa" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48909558b3aso18410855e9.0 for ; Fri, 01 May 2026 02:18:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777627118; x=1778231918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3vg2B5QYgg71nEreyYDVlmpHAn8rPoh5lm0nWaDaj3E=; b=Owb5HHBaJ6Ent4NRFarh3IMFOcz7ExYc2HKLgWJAu6nts7VYl/xhyt1cAm15+tKHOR tkb5G6XmNDFYvp3qFzBPcsQhadAgv3Ka8RFxnJ9p+AXEg4PkBwTgD5loyft/8tGDAtCW wDmmFCezZCIIkZhj8Z34NboLXQpvhRWI18ZhYvsyVDFuE6+/bOdeqMZGaUTF5H/YCCfT 9921MZQjU8mirMDauvOUHu23qzwWrJYQzSenoRaPIaTJYG7voR/EkKmxtFy68dFJdqZa Tm2hwnMnvDdDGqt9JkDYHt/XCHX+cRFBVaGiJtfHG8qc2SV47JN0dKKf5u2aNLNozjG4 cwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777627118; x=1778231918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3vg2B5QYgg71nEreyYDVlmpHAn8rPoh5lm0nWaDaj3E=; b=f5YmjW59icL+JMZTQz3gEgGRIDVMDr7XoVT0zIhNGMEebP/GmzwcFstdVnFt4lhZSc 1SWvKjjC76mHlDtmd66EauH/SDC1fIddFlJYiQhwZyYpnI8edvkDMuhtHYhPppkbIFJU BDF2/k6t1iq+QtNuqfE+LTmXwYI+BWNQVxrA3arp5DZjeBfzjPBN1cnVCjqeqb7sQjGy kono5HF9lFV6yfJnr6GtYcZAa5h2LjLpj3DaXEY8FlbIicOwO6+hplVStgJU9aash287 /uiTNYX4TuM0dsh9/o6vW3wbuZQCqmBSNHWM7gEcrzWKeZvQFGO4ZhG6NCBvGNuR+q87 xLMg== X-Forwarded-Encrypted: i=1; AFNElJ+o0pFE99jspVV21sml8Il3TpTkKIRPPsuE05er3RXwHqifOFXl8BVWmmHGON5kmmK2HbmvuOYrmMpLvUU=@vger.kernel.org X-Gm-Message-State: AOJu0Yyds5tEMQARfYgiZHl70iJWcsEJufOnSpqSEfebnfBd6vRbcOWc mvKBOSQGxuCRQ+UccgvY2rJOOPo70natkpn+4kRnmhAKiGw0lKqAjRA2gIPBmgLuv0g= X-Gm-Gg: AeBDievlPwVuCzWPixqZxyNkrQ6icVKSEfxSu8iEMu4q4ez2XaRzFFqp5jUmcjC24KT vEiGRepBIhT8iw9XPVf9fcycQpvm8+uNRMh179fOR/ossZQnkBNFn2HOE0wt0XndZBIENVC8NeO ysir5koe3WioOckyyr0XMLAa4GIarSensicCVxtQ+p9xUPNGAtYKmv9w/FYCNHyNdsdRrZY/1NF KELUI5dQdnq2cE8jLZSL5TK3X/DOvTnlHxIjXj+NA/IiExkSzFy7d82sGeuExU1Q6DS+XXnbQti 17v/L/F+kic1wbz9FL+H6CJtWoCnrgPALXlkaFhF+aK7p578HxfMuYvE+JGVHVnbLKTH/DNKh+F hqJC5UhbL+IPYupfpdK3airbNmKEmjdY3h5R5dytDTXqMI/M6YdDiAyFMBAA0Kg2sA+mdDR4uUe ZpIW27jlZupfQVkl19U8U8iiofxnAsNpeRzJrIhrcnIccX4uAjGm5DFThnh9Lq8ouuOF/SwBFJ5 ytBpdO2YlEESpNvyRw= X-Received: by 2002:a05:600c:4e0c:b0:487:5c0:671f with SMTP id 5b1f17b1804b1-48a8444a520mr106471165e9.9.1777627118033; Fri, 01 May 2026 02:18:38 -0700 (PDT) Received: from [192.168.178.36] (046124199213.public.t-mobile.at. [46.124.199.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a98b76fd0sm3820787f8f.35.2026.05.01.02.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:18:37 -0700 (PDT) From: Luca Weiss Date: Fri, 01 May 2026 11:18:30 +0200 Subject: [PATCH v2 2/5] dt-bindings: clock: qcom,milos-camcc: Document interconnect path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-milos-camcc-icc-v2-2-bb83c1256cc3@fairphone.com> References: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> In-Reply-To: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Mike Tipton , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777627112; l=1631; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=YmwJZh9JOI6WzIBDXZoUlM82ToEJjTRJKA1/rBWV68o=; b=g5Waz95YiXeLxPaliX00ixcxlQN9A2bYYjj5iIh3hpW01/05nrkK4yEIk0joIYOpy/N+7sWdY 42tZiGQUEXLCi3azpu7zmtrWAclrnKX/jTmH3tbZOYbMDOWfVi3lQGE X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Document an interconnect path for camcc which needs to be enabled so that the CAMSS_TOP_GDSC power domain can turn on successfully. Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml = b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml index f63149ecf3e1..707b25d2c11e 100644 --- a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml @@ -25,6 +25,10 @@ properties: - description: Sleep clock source - description: Camera AHB clock from GCC =20 + interconnects: + items: + - description: Interconnect path to enable the MultiMedia NoC + required: - compatible - clocks @@ -37,12 +41,16 @@ unevaluatedProperties: false examples: - | #include + #include + #include clock-controller@adb0000 { compatible =3D "qcom,milos-camcc"; reg =3D <0x0adb0000 0x40000>; clocks =3D <&bi_tcxo_div2>, <&sleep_clk>, <&gcc GCC_CAMERA_AHB_CLK>; + interconnects =3D <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mmss_noc SLAVE_MNOC_HF_MEM_NOC QCOM_ICC_TAG_ALWA= YS>; #clock-cells =3D <1>; #reset-cells =3D <1>; #power-domain-cells =3D <1>; --=20 2.54.0 From nobody Sun Jun 14 07:48:41 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4525F3822A8 for ; Fri, 1 May 2026 09:18:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627123; cv=none; b=MysTnfSsy5SbbB7Wa1hSm5oYDBRiMs+WkfBdNsdJy9HS/u1zxHqJgACUF1wq0GMZAZPw7L+ZYI90qvoVSPsPrP3lyaYA0IBcOZsh+C/kAVGEfQDGiwMUHFZhLQ11WWxpnJbJKmnyWotZRhGNy+OA48LxzWyyCmHL33kfjMgcyVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627123; c=relaxed/simple; bh=vBFY+SmJjtC4cED2P3MAEeeRdb2vcanu7b6d3HDV3KQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZyGz8/ltz/Zza0d71E+JbgoUiXQ222VN3ugMwAemZh9J9WcQip84az06mw70/p6diwieADsYuIWtSxEI9dQKuRRPPQBovuSJDS3jGOx41ZAWIHakERdy6yeqBt4dyUktKVYQ+shtLvnu3FefXQjIxFeIs0iNpDKziTCOTrrGSJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=OkGJbttg; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="OkGJbttg" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43cfce3a195so919837f8f.2 for ; Fri, 01 May 2026 02:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777627120; x=1778231920; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+NWZu4H8hGDWhTzeuuLpxUjYIGK3vSOADuGQvxmMAgI=; b=OkGJbttg64JsfHR29FtQGErbF+buYxGQi7RjA49TSFM7+P9Z0qlFUUZb6utpBdRjDX yevRR/39ff9IiWQz+fw2IRfQ9a94GBOSCoFYjqUfPn0RoiD65JMV1Hu66vv6jdWg0FTW 9RGYnG/mdHC/I8tDla22xCkw6oMisSNvqcOIz9yXCMBTeWR4Vv1lnmnTW8A3nNMSyofU ye3HnJmSKzCK9LDWZ+hm/2uQ3mciJkWF29kF/DyN8WsFPYiEE0nTlioZYvzOFZVaRi3y HXaWnvsBKiWpnDNqx6nG6wl/TH2KCFfbaI/8wyis43sBJKqeh2lZrjs+FOgqYhjnffjO siTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777627120; x=1778231920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+NWZu4H8hGDWhTzeuuLpxUjYIGK3vSOADuGQvxmMAgI=; b=bz3ziXs+wzxYJ0gKoPceIok+D3ZDYDmB3IdT7oTLVbcLlmbIgia3eTBoi85kWLZwhr oQX0W81vqLE2a+iXh5Sa4NXfj7hhp6lv+T2Iijow+aC/eqngh9b7zC8fOkg6hJCsvwEP WH9v8cBEj2sEiHg4+dlDNC+iV7rG6d1/D5eUpXpPdZ/IxMN9IxQLv1Rk4IqdvNauifOI Mc/2Jykf36vyVtWhBhIa7we6TqJvj2M22a9W+9uxTRfiIePZaCNhgd2+yPBJy03fnwRY S0nyLrrT52uq4izyOE6DISxWkAhWYj7Cj9O6fFKXdJ9/zcw6ZYcvuAeZTGMem2daSzSW iazA== X-Forwarded-Encrypted: i=1; AFNElJ9kjp+2+L/k7IH+LR2Kafyq/cRYHkIkaxsE3dOJfSxA+leH5YDdttejfgimiIIxKdNwNT77F02QQsKXuC8=@vger.kernel.org X-Gm-Message-State: AOJu0YyQiXNe4H0R4IlvmYK7RJXCFO1KmbRyv5h4saG8HSj/17zy5A1j A6qgylLfAM36ukuXajEC6tG7ZxhI+MR4XcvCJikdGLFyC0cqnWkvQwMP9cfooORneZY= X-Gm-Gg: AeBDiesjFaUMOSTpjHs09QFMHnHv7z+MTIdY8IcwWE7xpkex2kmhAI3hbxMaHDAtQ18 fxoDbGj6SBbritBebHCt4cavB6BDrzezfKYczI3XtzKdJd3E6zON7voA8lGszIQ8AXcgcKIlmci HW0kE/1XE2VMaaYgvsG1kZkTr/5SX4RGT2HNjO4tLXVhDaFj0GHjdvqbq+Wf4RFw+raoZXfe+ec asNdrB2bWW9hk+r4TJyo/fB8XpmODPf4zH9B6USoLJ/d4JVVRGgwCEllOenF3hRikwB+vklcLST gdT0lKSkAPOSS935SMxIicMs1hSXEr52IODd3Ihma2HXzpGtXRWKNXz2Oj7ou8+ZWBa22eoHbbR W+mVQ5UkbjWs9u63RJnTDy6rLOoF4dBl8rW2Z9aUeADC/hixF27UDDro2oBV775t4k0skQoFiV5 Nmbj3VEN5yV/VL/3x5WjrJG8mpMCFbhMw2nUCD22FvZrjtWJc57ng95BiPs1Qmw5eAl/fojD4St SGyRvT66NgQI7xi10s= X-Received: by 2002:a05:6000:26c8:b0:43f:e22f:606 with SMTP id ffacd0b85a97d-4493dbdb55dmr9921190f8f.2.1777627119767; Fri, 01 May 2026 02:18:39 -0700 (PDT) Received: from [192.168.178.36] (046124199213.public.t-mobile.at. [46.124.199.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a98b76fd0sm3820787f8f.35.2026.05.01.02.18.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:18:39 -0700 (PDT) From: Luca Weiss Date: Fri, 01 May 2026 11:18:31 +0200 Subject: [PATCH v2 3/5] clk: qcom: gdsc: Support enabling interconnect path for power domain Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-milos-camcc-icc-v2-3-bb83c1256cc3@fairphone.com> References: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> In-Reply-To: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Mike Tipton , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777627112; l=3296; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=vBFY+SmJjtC4cED2P3MAEeeRdb2vcanu7b6d3HDV3KQ=; b=CuTWQZHPEoyAXshMVDX/yFOliGYdtzkkaIyHmaARqIg+fK+dPGUD9DrAF/BygWOYwuNS1kwTD pY2qmH0nSh6AoW3Hgdksd32nIiZDTh6dxuesD52F6aclCMmxBm7fxhc X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= On newer SoCs like Milos the CAMSS_TOP_GDSC power domains requires the enablement of the multimedia NoC, otherwise the GDSC will be stuck on 'off'. Add support for getting an interconnect path as specified in the SoC clock driver, and enabling/disabling that interconnect path when the GDSC is being enabled/disabled. Signed-off-by: Luca Weiss --- icc_enable()/icc_disable() seems like a nice API but doesn't work without setting the bandwidth first, so it's not very useful for this driver, at least I couldn't figure out how to use it correctly. --- drivers/clk/qcom/gdsc.c | 33 +++++++++++++++++++++++++++++++++ drivers/clk/qcom/gdsc.h | 5 +++++ 2 files changed, 38 insertions(+) diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index 95aa07120245..ee5f86ca50cb 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -147,6 +148,12 @@ static int gdsc_toggle_logic(struct gdsc *sc, enum gds= c_status status, return ret; } =20 + if (status =3D=3D GDSC_ON) { + ret =3D icc_set_bw(sc->icc_path, 1, 1); + if (ret) + goto err_disable_supply; + } + ret =3D gdsc_update_collapse_bit(sc, status =3D=3D GDSC_OFF); =20 /* If disabling votable gdscs, don't poll on status */ @@ -177,6 +184,12 @@ static int gdsc_toggle_logic(struct gdsc *sc, enum gds= c_status status, ret =3D gdsc_poll_status(sc, status); WARN(ret, "%s status stuck at 'o%s'", sc->pd.name, status ? "ff" : "n"); =20 + if (!ret && status =3D=3D GDSC_OFF) { + ret =3D icc_set_bw(sc->icc_path, 0, 0); + if (ret) + return ret; + } + if (!ret && status =3D=3D GDSC_OFF && sc->rsupply) { ret =3D regulator_disable(sc->rsupply); if (ret < 0) @@ -184,6 +197,12 @@ static int gdsc_toggle_logic(struct gdsc *sc, enum gds= c_status status, } =20 return ret; + +err_disable_supply: + if (status =3D=3D GDSC_ON && sc->rsupply) + regulator_disable(sc->rsupply); + + return ret; } =20 static inline int gdsc_deassert_reset(struct gdsc *sc) @@ -584,6 +603,20 @@ int gdsc_register(struct gdsc_desc *desc, if (!data->domains) return -ENOMEM; =20 + for (i =3D 0; i < num; i++) { + if (!scs[i] || !scs[i]->needs_icc) + continue; + + scs[i]->icc_path =3D devm_of_icc_get_by_index(dev, scs[i]->icc_path_inde= x); + if (IS_ERR(scs[i]->icc_path)) { + ret =3D PTR_ERR(scs[i]->icc_path); + if (ret !=3D -ENODEV) + return ret; + + scs[i]->icc_path =3D NULL; + } + } + for (i =3D 0; i < num; i++) { if (!scs[i] || !scs[i]->supply) continue; diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h index dd843e86c05b..92ff6bcce7b1 100644 --- a/drivers/clk/qcom/gdsc.h +++ b/drivers/clk/qcom/gdsc.h @@ -9,6 +9,7 @@ #include #include =20 +struct icc_path; struct regmap; struct regulator; struct reset_controller_dev; @@ -74,6 +75,10 @@ struct gdsc { =20 const char *supply; struct regulator *rsupply; + + bool needs_icc; + unsigned int icc_path_index; + struct icc_path *icc_path; }; =20 struct gdsc_desc { --=20 2.54.0 From nobody Sun Jun 14 07:48:41 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B572DEA61 for ; Fri, 1 May 2026 09:18:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627126; cv=none; b=LXayuacAM3LZ+4Wc3vuhjfSiOfO1+aQNbzNVYPVOEWtw7OaUUp5fumiWaLMxZ1cZixk77iEGnCLF/4YPb1fnR2HQ1wdmCQUe06/pWsIVUnk1ybQm71lx540/j6AeMTR34ccCJGYVMbBh7qBvVFp3PRrGjOkeBoZg89duXDgGUZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627126; c=relaxed/simple; bh=2GM8iILc+e+kkT8uuqti/v0hmU/nmTpy3cu5qfGbOaA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NR89+jf4DR7IvdIFpCsf8cZX67vXPmUYr1+AxjGarxJ7tqWW+y08+918rB85cxwnpDRWCdpwgDc4PytL3A4vUQCC697qG/Z+iGWJXjU98KvaHPHk/CmNtQAJCDTg4EogkOeY1VAu8lzwyP/5TmY3ein7lRkbiTBIjr+qC11QhkI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=YmrYNVfn; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="YmrYNVfn" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-488ad135063so14774655e9.0 for ; Fri, 01 May 2026 02:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777627121; x=1778231921; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=wXg42DnzNUk3hE0wclWkHErZDdBr7JTlVE52L0ztars=; b=YmrYNVfnw72jZIt2c0uqKrT+3+lXkMOlS2HMnVNKR91b8Ng0mp5vU6j8g8AuAdioC+ v1GpGBXJ+5yYUH+d/wjTAaffPs8nAL70XNS4HB2RA/E4efeS3OOmdL/4xyjQndHVBr6a mXMAnWmr8pxhsO8Lll2KKtOjrOEMbT28VR96RsjH991FRNKtIDTNgBmW8KUiP0+bzZQs ITumXlWirX8x0sH6Wm6zOVxOK3b6HqQ+iYVrkJLskuGZ15VtaPJSanYNGWCjwpZWYYTC k7i/SrWL9jzWEeuINfEEyKGgTqWV99ZkHf0scLxIdFcmlHr37aqwg8EShaAxFvDeTW+p X+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777627121; x=1778231921; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wXg42DnzNUk3hE0wclWkHErZDdBr7JTlVE52L0ztars=; b=pO/O9ZU/rDaEGmol1WLSXs5ekivxhODSuB8xHRL9vTHFchrtx6c9q4tu6KNk+oWiGj pNFySgxSK4rOMt0oI5+cmvgdLEQfdQWFcvaRqROcY+77DRuGo5Y2zPz7lKuVa3EJZSx5 4nv0n7++FQw5D3umvnAa0geOMBZ5IDD6p9ywFX4BrUeZTIhSecbHjMhf7WjaCIEAOZsL zQyLFPzcuWAnYUcXzipqQQt7aZAQHvj4haf/AhtEP0kD2ZfK2RN7RUtGg7aV/PJcBadm itRdSCpGVsyTqMYshTYqJherwbR3IRJq23lx54LCrW2Z8SNB2vib4UREbUqa7ayk+PI8 yjuw== X-Forwarded-Encrypted: i=1; AFNElJ8P/wSof6PtBHQ/pZsB2JYVeV+FBxjcdlnDMPNSMcpOTHCAwWcigqSytlDyJpybnoxSH5K9E6z4upn0uKs=@vger.kernel.org X-Gm-Message-State: AOJu0YyuLGnJc/8ypqBjJOFzVUzZslShk84L8xyOHDxrCeTQo+t56G33 jfIcL0S2Od4zavsGyoKAhj9vtgh3fXaj5xN6g8zT9PvCHuevVI7rJrGiv/uRIoWrWoc= X-Gm-Gg: AeBDietgTNWzbyHN+zkjlYphRAZJyRC/tT/pMo8p4ID4r0A0fTXsIH5k9XnRCNlLMYV NuXtYi5x+TWXr1N3SMH/ET+GVVpod3EXkkZhfuEyL4CjAUtuuSy/fyHq8PNSbeQeTmCRcgrM4KS 5ZdGUdktFA2kCdzIaN9NJd95uEdac+ucGBJsIc/qqchkgp6bWeNAk2FKopH//MMLn6fMBrvYLv9 ajHeQUx8yDuMngA3AU0WE0aEEl5e8bmOGEZ1X0zy6oKh4UWB6RSA6lOzTGbT0iXixZe/k1P06C+ PW/PeiZ0I0EKEmma7W3rS7orvzuiG4T0AlREIYz6V7zYfZAjDWDHSbLSaLI5dZ9xxobDJ8pegsg s+WY2YmKDmdtvAPaatWBKdARzTTbyG5336t4iq4hB94LptmPab0azGx369PH3aw7ZqJP7PS5rn9 mWlVj0VqSlCYOUNanDWu/fY7svrmaQ7mgqdQVflR61AqEnPGC6hFTUHZF4pldVd+f6JoOGmlwNo x/ALqX3 X-Received: by 2002:a05:600c:1387:b0:485:3f30:6250 with SMTP id 5b1f17b1804b1-48a84459c6bmr106593135e9.20.1777627121640; Fri, 01 May 2026 02:18:41 -0700 (PDT) Received: from [192.168.178.36] (046124199213.public.t-mobile.at. [46.124.199.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a98b76fd0sm3820787f8f.35.2026.05.01.02.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:18:41 -0700 (PDT) From: Luca Weiss Date: Fri, 01 May 2026 11:18:32 +0200 Subject: [PATCH v2 4/5] clk: qcom: camcc-milos: Declare icc path dependency for CAMSS_TOP_GDSC Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-milos-camcc-icc-v2-4-bb83c1256cc3@fairphone.com> References: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> In-Reply-To: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Mike Tipton , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss , Konrad Dybcio , Dmitry Baryshkov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777627112; l=1070; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=2GM8iILc+e+kkT8uuqti/v0hmU/nmTpy3cu5qfGbOaA=; b=ss53KXLsizSBDZefj9m8ibIfFPWlpBeseS1W+oUtlxEk5L8svzteRZ/WbyCg0wJBSBBFKL2do 0c2CAgCXk+GA7HnF39rz7yQBell0BW+k4rUJuacCUZNB6/7gJ1B8s+l X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= This GDSC requires an interconnect path to be enabled, otherwise the GDSC will be stuck on 'off' and can't be enabled. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss --- drivers/clk/qcom/camcc-milos.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/clk/qcom/camcc-milos.c b/drivers/clk/qcom/camcc-milos.c index 409d47098c10..579b71e0e089 100644 --- a/drivers/clk/qcom/camcc-milos.c +++ b/drivers/clk/qcom/camcc-milos.c @@ -30,6 +30,11 @@ enum { DT_IFACE, }; =20 +/* Need to match the order of interconnects in DT binding */ +enum { + DT_ICC_TOP_GDSC, +}; + enum { P_BI_TCXO, P_CAM_CC_PLL0_OUT_EVEN, @@ -1971,6 +1976,8 @@ static struct gdsc cam_cc_camss_top_gdsc =3D { }, .pwrsts =3D PWRSTS_OFF_ON, .flags =3D POLL_CFG_GDSCR | RETAIN_FF_ENABLE, + .needs_icc =3D true, + .icc_path_index =3D DT_ICC_TOP_GDSC, }; =20 static struct clk_regmap *cam_cc_milos_clocks[] =3D { --=20 2.54.0 From nobody Sun Jun 14 07:48:41 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15D2638229E for ; Fri, 1 May 2026 09:18:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627130; cv=none; b=RkqzAhqUHOsL0cFGLXwSd1O0w3yI5898K10cpeCnmB0lNLQwXXtMXLX7OYwBjZXu7egfJtU+OoQ2bGxK0Lf3hmEfigi23aaGPKJiRVwy6GMojr3VrswAiEp2Nn5eNwU6o3sNN7b+bJZTGmbWjsesoenHnZjJUvfBd0OcowmBzE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777627130; c=relaxed/simple; bh=XcfJhcCYTkjzBCvg/Cxuww7QqKifGaagi9xIyyI67cY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EzCLlJ6dclpeYQuLXlrzIxgO2Tm9yW9gSRuwKTImyeJJ7vyN87ytD7xuS0zW29nSqPp3LYutQQmMQ01zbdA4e/eYfPLSB8Ro3LWY8O+AjHNhRptdC5149pKGxBnQYw94Q9p45D3Pw95MofGsS6tM5km13fjQus6oOd9Ejpw8GuA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=UmFMgQ38; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="UmFMgQ38" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43d73352cf2so1588312f8f.1 for ; Fri, 01 May 2026 02:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1777627123; x=1778231923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ZnuErBRIZTrfkelR+38i2qfJhgtaQ07JLYCEdmx/1ig=; b=UmFMgQ38nVJ/7i+khKEJsxD3GRutbNe3PNGcY5YY/XzZs/AE2Hp9KL50iJ9hPe0S1W NlwTiiQ7eYOMW/uRpxKHacoOu8xkBe1f0bur6yjdfIuCUTvEAMcMBXZi2zVathZbyIjc qW0GdJPpqhGq5dAGfL5gEh9D5hKTBantio369Yh2ThDrwHpFEzQgLXHfw9nBUKxyu0mD cmuNxQVO5CRhaKrxOcjyK8rVzAE2JIowROne/CiskazjT8W9iGu+cP/+rEPBAdsInZkn TFfWO8PHzgRYjqxFiLQzYUBw225rZrDdcRu5bR9OOS/tHShTVQhokAkAVzdHNLuAKLv+ Q6yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777627123; x=1778231923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZnuErBRIZTrfkelR+38i2qfJhgtaQ07JLYCEdmx/1ig=; b=K4BZCPJvFJdzLM4hEYfrrbT8zE83hdLslo6JXTOv9a08hUdvE3oSPSQez+ApApJCMG uzd8Xlpx8yR+YBNP/5OhOdFfGvDcwA5qDJpJGBjnzEXqsspNNsRj/zfO2Zdp5Ap7DlQU rln5paggepMPr+yiHk0G4pVEQuuaydT07mdyD2d9/O/b1aFgcMguQmPr9xgGIktk6HGc IIN4fIGhoR8Ksjm1deji2WVkICxYY7PQQs/eRYYCbtAG7A8w5xe/bTrkDZYVoxyfXL9N J/wyCwhUG90zLin6tS/kRUvqf7HSGHvGDayydTsRncxOl2UqPlgnAQIcCQWCvHSvPhER wYug== X-Forwarded-Encrypted: i=1; AFNElJ+AkCC4ylfR2f+T9glOUstO/PFoNV3N0YlJVEuD7WlIDs6+Mq8k4hiUrcecMVgPvYcaarQ/vQNjkcO4PQg=@vger.kernel.org X-Gm-Message-State: AOJu0YzKR1g7Yk4ucOYM77Y1P64Z1wyy3tSZKY1AudBjQ/MKmvrD245P CR5tJFvwv5kJ0jK8UMZg3QxDbCpaxgVi+MsY3OnWzjmKz53EShWGIg236IlDlXvPYZk= X-Gm-Gg: AeBDiesXKVI4KiMXnQLj2Jei71rKsdF440NmsGQCYmQH4+n/FSvIYtIQqlMCIXcmvRL 7IqU7PEXW1GB3gE7j1cgfm5/XmUitolv+xJT4CzrJkjDwaSNyeKTeTjOK7ort1ax0x5amRSAAab AjPpUFEjKmvQ5AlyQC7w9nb52ho3Sc8Rl7Kd0uNovfJlj7zMQpdofCpFDGRZiPnw1AbS/9Sxij2 dG2kpLbPOx/lMif2CsJMDazaXxTEI/+WgQGBy0SICnJJm1mmgJdKMOjPeN7GYJtnt3ZXrCegMgP ii0k6UFx4RceEifmN2VdUjeDNRp0laqEBQI+ASW5K0X4/aB2XVeyOYmW3FxzASmRz+/OlPsHCJt 4rxnGnmrfbQWLaOTbrQjcBAYx38MCTwPY4KDNpqYIp/pVvYHf+3lSqyygqONSIzPlHirizDj9Bb yXXBTMhK++RcZ/L2Kb7zWPUy13DrcmTwPIq7uLtNnYK44T/59JuItRgt7ESSzLsWoDChNZTOoM2 Tdp0taP X-Received: by 2002:a05:6000:22c2:b0:43c:ef4f:79dc with SMTP id ffacd0b85a97d-44a857c070emr3502853f8f.8.1777627123520; Fri, 01 May 2026 02:18:43 -0700 (PDT) Received: from [192.168.178.36] (046124199213.public.t-mobile.at. [46.124.199.213]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a98b76fd0sm3820787f8f.35.2026.05.01.02.18.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2026 02:18:43 -0700 (PDT) From: Luca Weiss Date: Fri, 01 May 2026 11:18:33 +0200 Subject: [PATCH v2 5/5] arm64: dts: qcom: milos: Add interconnects to camcc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260501-milos-camcc-icc-v2-5-bb83c1256cc3@fairphone.com> References: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> In-Reply-To: <20260501-milos-camcc-icc-v2-0-bb83c1256cc3@fairphone.com> To: Georgi Djakov , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Mike Tipton , Taniya Das Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss , Dmitry Baryshkov X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777627112; l=1001; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=XcfJhcCYTkjzBCvg/Cxuww7QqKifGaagi9xIyyI67cY=; b=RVgZP6zl4igJW2UZF4EhCIuRsywJ8TJPAYhxRoM9TMx2tC4OgST/C3rBNwMdp80Ll37kF/tYZ MYGuDVYg64VBfwf+ZTJzwnsyd0MuFm5A68MD5NmQcV2KBVshRvgGaqL X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= The CAMSS_TOP_GDSC inside camcc requires an interconnect path to be enabled, otherwise the GDSC will be stuck on 'off' and can't be enabled. Add the interconnect path so that this requirement can be satisfied by the kernel. Reviewed-by: Dmitry Baryshkov Signed-off-by: Luca Weiss Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/milos.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi b/arch/arm64/boot/dts/qcom= /milos.dtsi index 4a64a98a434b..80208bc33730 100644 --- a/arch/arm64/boot/dts/qcom/milos.dtsi +++ b/arch/arm64/boot/dts/qcom/milos.dtsi @@ -1923,6 +1923,9 @@ camcc: clock-controller@adb0000 { <&sleep_clk>, <&gcc GCC_CAMERA_AHB_CLK>; =20 + interconnects =3D <&mmss_noc MASTER_CAMNOC_HF QCOM_ICC_TAG_ALWAYS + &mmss_noc SLAVE_MNOC_HF_MEM_NOC QCOM_ICC_TAG_ALWAYS>; + #clock-cells =3D <1>; #reset-cells =3D <1>; #power-domain-cells =3D <1>; --=20 2.54.0