From nobody Sat Jun 20 14:14:05 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2398E329C66; Thu, 30 Apr 2026 16:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777567604; cv=none; b=sd671zPgHCfK1mRsJRUxXhi9Q6Gp0K6/klvdCUTOBknDby7E98xlHNv5/pjcZFooHj3Jeb0vOj9yd4tVeqXWLpIqzloljs0WJ+qz/0nThErAiYzanC+00xm5/uYfMvdY9JpG3+zmPM4s1xtsUev80E3fz0RVfMeOBAiX1xDftyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777567604; c=relaxed/simple; bh=vBZRA2uGIChcs+ndx9gspjN3QNgcLBXYaCL4wYQ6tSw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hC2uaHWQEaonYnBGz/XeE+StewRe0yJYe7iQkqWJ9nlGojMnLfUfuJJZblQ/QnIwcIK5ycSwHmuckOtPPBebdkJXCFw7kZlInMfkwOtlw/zLJPajjtBNzLxioHbKww6o7AZAibGFDQWMzo1maz6KMLvn7zUqdpBH8TrewmjEtH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=TSQ3z0/Z; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="TSQ3z0/Z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=5X ywz8beiXKigdPY0dCWJdyNA0g5/M/vRfZ/rmu5OqQ=; b=TSQ3z0/ZEnuWWFf/4c 0XiCngqtAQjhzo/tqnl6h5Fzow9rZB016nU+D9QOe5+0U17a9KxktgeKkFD66N0Z KChJ5SVC1l2pNaFFNqqayyZDHtL5gy4OQbkOhECezS6yKNjjVEg6kY5vICxW7rpU Br095kZa5cQomfXvXoU3XBhPM= Received: from zhb.. (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wDHWJ46h_NpWWQZCg--.13259S3; Fri, 01 May 2026 00:45:47 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 1/2] iommu/arm-smmu-qcom: Use FIELD_MODIFY() Date: Fri, 1 May 2026 00:45:44 +0800 Message-Id: <20260430164545.49637-2-18255117159@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260430164545.49637-1-18255117159@163.com> References: <20260430164545.49637-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDHWJ46h_NpWWQZCg--.13259S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrur17Kr1UAw15uF1UZF13Arb_yoWkJFXEy3 W8A3Z7J3Wjy342vry0vrs3Zr90vaykurykWw4SgFyrAr15K395uws5ZF1kGw4xAF40kFyI g3sxWr1rZFy7ujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRKiiSPUUUUU== X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbCxBtH6mnzhzsbHwAA3Q Content-Type: text/plain; charset="utf-8" Use FIELD_MODIFY() to remove open-coded bit manipulation. No functional change intended. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c b/drivers/iom= mu/arm/arm-smmu/arm-smmu-qcom-debug.c index 65e0ef6539fe..99469c4ebac2 100644 --- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c +++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom-debug.c @@ -208,8 +208,7 @@ static phys_addr_t qcom_tbu_trigger_atos(struct arm_smm= u_domain *smmu_domain, =20 /* Set address and stream-id */ val =3D readq_relaxed(tbu->base + DEBUG_SID_HALT_REG); - val &=3D ~DEBUG_SID_HALT_SID; - val |=3D FIELD_PREP(DEBUG_SID_HALT_SID, sid); + FIELD_MODIFY(DEBUG_SID_HALT_SID, &val, sid); writeq_relaxed(val, tbu->base + DEBUG_SID_HALT_REG); writeq_relaxed(iova, tbu->base + DEBUG_VA_ADDR_REG); val =3D FIELD_PREP(DEBUG_AXUSER_CDMID, DEBUG_AXUSER_CDMID_VAL); --=20 2.34.1 From nobody Sat Jun 20 14:14:05 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36C1F3019D6; Thu, 30 Apr 2026 16:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777567594; cv=none; b=Bs7bqUixHxsB797EFkyETXmJH98y6qre9tBSU5QSmnVDVwRwR84kM7tYiwMvh8+0KMpIJV7GpBZN+IAkbXNS5P2mIDHqmgLga5XSuQaNpHAmhI0BXomyDqd9gmHwjc/yxwzqTjsWjE5Dtf4f2DtCC2ER050oLnJO6MEp34wpfgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777567594; c=relaxed/simple; bh=KkFAJcN56DdQ7LkM/e3q+BhecPH3iZWC64JcXBWs4MU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cfitndV7cIQg30OKazW5BqoRizDd+HltEByRO5PiBBJx/LZd0TOY0rwHETY/Vk29FisD4J1ZL9GLIwt8VkTEnzOYOUVgdpCKiDkM5LMi48jC2/40ypFi8xOF2gV0TdHhYLA7RHpM0NuWUqVwIBaSEJGv9iSkYHYwZvIRVvMkXZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=mxSKAux+; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="mxSKAux+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=tY VXjXirmIZR6ZQ1E8Pp2rDSwH80Wsd508YTDXQA1gI=; b=mxSKAux+VowD81jPvF oC/9AUlsMcakNJ7xs19RLjcAQ/f7AqLKohf/7DnQRph+7/J7jfjydJTA0Gu3quXE QTJODTzgH+C25SZV/h6o5AhpMjMdQaoP2XDwTkXQE0AtoI8NAu2jU2Q5E4h8czxt gj9L4nyZeJePP8IR/d6R/ikLU= Received: from zhb.. (unknown []) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wDHWJ46h_NpWWQZCg--.13259S4; Fri, 01 May 2026 00:45:48 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans Zhang <18255117159@163.com> Subject: [PATCH 2/2] iommu/arm-smmu-v3: Use FIELD_MODIFY() Date: Fri, 1 May 2026 00:45:45 +0800 Message-Id: <20260430164545.49637-3-18255117159@163.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260430164545.49637-1-18255117159@163.com> References: <20260430164545.49637-1-18255117159@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDHWJ46h_NpWWQZCg--.13259S4 X-Coremail-Antispam: 1Uf129KBjvJXoW7urW7uFyUWw4kXF45WryrtFb_yoW8Gr18pa yUGryY9rnrJ3Z3Ca9rXF47Z3s0g3Z5Ka48Kr45W39Yqr10k34UWrs3Kwn5Krs7CryxGF17 uws2q3y5GF1UCrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pi3fHbUUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbC6xxI62nzhzwEWwAA3q Content-Type: text/plain; charset="utf-8" Use FIELD_MODIFY() to remove open-coded bit manipulation. No functional change intended. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c b/drivers/= iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c index ddae0b07c76b..b62e91e4781d 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c @@ -330,8 +330,7 @@ static int arm_vsmmu_convert_user_cmd(struct arm_vsmmu = *vsmmu, case CMDQ_OP_TLBI_NH_VAA: case CMDQ_OP_TLBI_NH_ALL: case CMDQ_OP_TLBI_NH_ASID: - cmd->cmd[0] &=3D ~CMDQ_TLBI_0_VMID; - cmd->cmd[0] |=3D FIELD_PREP(CMDQ_TLBI_0_VMID, vsmmu->vmid); + FIELD_MODIFY(CMDQ_TLBI_0_VMID, &cmd->cmd[0], vsmmu->vmid); break; case CMDQ_OP_ATC_INV: case CMDQ_OP_CFGI_CD: @@ -340,8 +339,7 @@ static int arm_vsmmu_convert_user_cmd(struct arm_vsmmu = *vsmmu, =20 if (arm_vsmmu_vsid_to_sid(vsmmu, vsid, &sid)) return -EIO; - cmd->cmd[0] &=3D ~CMDQ_CFGI_0_SID; - cmd->cmd[0] |=3D FIELD_PREP(CMDQ_CFGI_0_SID, sid); + FIELD_MODIFY(CMDQ_CFGI_0_SID, &cmd->cmd[0], sid); break; } default: --=20 2.34.1