From nobody Sat Jun 20 14:14:36 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 358B7428488 for ; Thu, 30 Apr 2026 16:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777566634; cv=none; b=WvcdcTYZeM7YfM0It+gKdbIZ1vp7aRNDwXNaXy310mnSXIpPeUuFMgv4Dfe7ydF/rEPZxEtBxkmBPJ789UxQQAb4kPbToUwnit+Yu0gZOa4pdwCo+zrwVws8COQ4OTYhsRqbYhhG21U9V7aTZ5V3wZIvOKW7dMbUviJ9kckyva4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777566634; c=relaxed/simple; bh=vXhAHjuD3Q3vYIgx2n3RQLtQmPCIy9+5nTTxFOPrXM0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=iUxnS88pYpGNZN1FwCuXTVFmeSK0tgGO8rOnxTBCw2psAkDnHL/p3IEg/sDe/H+53hEz0P5Ql54reTzBORlkC7qUH2lNHU21DP3EHgfFYy41UQ/rdRYAQ2c3XWOG7i/Pwo14Blo4uyetTMLMl1xOGBfTPY2yTLXn8fXNAcdIoO0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=cyMuGCii; arc=none smtp.client-ip=117.135.210.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="cyMuGCii" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=0S yc2AhxUW6Zx9jl/D9s3rfupPcLOawoGrGFwJ+jOe0=; b=cyMuGCiifNl5ImNjvx 7uxKZWCh7CCDGxlDTy408JzcTjSXPACWk1Eb3INfit1OWR1VGgtMvX8Kiw8wBizc ev/8sdhM8LZu6NvVlN5pbxkLGRxBUy7Ua08jKXZG8kWomVie5/7KW+fX3f6aN/Ew 6WfiVvi9w9bnv2vyI1ivxNJpI= Received: from zhb.. (unknown []) by gzsmtp5 (Coremail) with SMTP id QCgvCgA3LKiDg_NpvQYdCA--.8419S2; Fri, 01 May 2026 00:29:58 +0800 (CST) From: Hans Zhang <18255117159@163.com> To: maz@kernel.org, tglx@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hans Zhang <18255117159@163.com> Subject: [PATCH] irqchip/gic-v3-its: Use FIELD_MODIFY() Date: Fri, 1 May 2026 00:29:54 +0800 Message-Id: <20260430162954.44156-1-18255117159@163.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: QCgvCgA3LKiDg_NpvQYdCA--.8419S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7urW7uF4fKF43Xr47WF4rKrg_yoW8CFW5pr WfKFWIvF4xWa47Xa1fKF1kuF1rtr4DKa4xKFW7Ww1v9w1UJ3yktr48tryagr1Sqry7JrWj 9rWrtryruw45AF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRgtx7UUUUU= X-CM-SenderInfo: rpryjkyvrrlimvzbiqqrwthudrp/xtbC7AZZ-Gnzg4aCzgAA3c Content-Type: text/plain; charset="utf-8" Use FIELD_MODIFY() to remove open-coded bit manipulation. No functional change intended. Signed-off-by: Hans Zhang <18255117159@163.com> --- drivers/irqchip/irq-gic-v3-its.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-= its.c index 291d7668cc8d..e78795b7acfd 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -4784,8 +4784,7 @@ static bool __maybe_unused its_enable_quirk_cavium_22= 375(void *data) struct its_node *its =3D data; =20 /* erratum 22375: only alloc 8MB table size (20 bits) */ - its->typer &=3D ~GITS_TYPER_DEVBITS; - its->typer |=3D FIELD_PREP(GITS_TYPER_DEVBITS, 20 - 1); + FIELD_MODIFY(GITS_TYPER_DEVBITS, &its->typer, 20 - 1); its->flags |=3D ITS_FLAGS_WORKAROUND_CAVIUM_22375; =20 return true; @@ -4805,8 +4804,7 @@ static bool __maybe_unused its_enable_quirk_qdf2400_e= 0065(void *data) struct its_node *its =3D data; =20 /* On QDF2400, the size of the ITE is 16Bytes */ - its->typer &=3D ~GITS_TYPER_ITT_ENTRY_SIZE; - its->typer |=3D FIELD_PREP(GITS_TYPER_ITT_ENTRY_SIZE, 16 - 1); + FIELD_MODIFY(GITS_TYPER_ITT_ENTRY_SIZE, &its->typer, 16 - 1); =20 return true; } @@ -4840,10 +4838,8 @@ static bool __maybe_unused its_enable_quirk_socionex= t_synquacer(void *data) its->get_msi_base =3D its_irq_get_msi_base_pre_its; =20 ids =3D ilog2(pre_its_window[1]) - 2; - if (device_ids(its) > ids) { - its->typer &=3D ~GITS_TYPER_DEVBITS; - its->typer |=3D FIELD_PREP(GITS_TYPER_DEVBITS, ids - 1); - } + if (device_ids(its) > ids) + FIELD_MODIFY(GITS_TYPER_DEVBITS, &its->typer, ids - 1); =20 /* the pre-ITS breaks isolation, so disable MSI remapping */ its->msi_domain_flags &=3D ~IRQ_DOMAIN_FLAG_ISOLATED_MSI; base-commit: 3b3bea6d4b9c162f9e555905d96b8c1da67ecd5b --=20 2.34.1