From nobody Tue Jun 16 15:56:22 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78A371C84A2 for ; Thu, 30 Apr 2026 12:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777550435; cv=none; b=i84Tf7qpt/gLv0te1gSjdZlbAu2DX+8qWqp7koaMzIFmm5RJiOZ0yTZG3nUplF2vmEVwYCC+Nn9Iwesq5rIt73hqBCsTEbW8dLRO/6HrlPaOAccVrgtKwIpQRr3GcZUh/Yp3lPgO3vnz/s9Oipuv0jCPOCKn5pF+KCDeVgssMro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777550435; c=relaxed/simple; bh=fPrpOKXJr9nruDDTsn+7uGXjfrkxJtzLxS8K00lZO4I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vEOxyti5ktMRFZGbYdCQhdW2xMA/HYTo/qiWduvUNRM8KXxL/nKxXG9UJfftTXmS0PSkT6lJgAeyC2LkHEsVcg94GRop1V3umqd2YBfSqbApGkBQRLLB7jqIJN7dH8I2dp1jmmblFevVxivDVFc7lqzLtk/ezVRzv4h8FSzGwGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y6sNL7eV; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y6sNL7eV" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2b941cd869cso4975565ad.1 for ; Thu, 30 Apr 2026 05:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777550434; x=1778155234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qJ8Z+a0emIBhKGFU70tK/Y6xfc8pLkgntdZpPCo3x24=; b=Y6sNL7eVd8xddGO3Vz3zYbEm0Fd8cFKAEaNdnKygmOr0+mFlxBuZlJHwJWEI7Yy4yt ELWHO2zIEFfYIsihz4BYk8XO+kXYnwneRrhsDBWeVc8yx8D0/8LI2GmjAOeZxeMNQ0Zx vadSsc7oyPzmsgRjqBPENlOOdyxBC8DaZcHNHzXaeLQvztFd58HFhEMBPAe5RMoDQ2lJ XgXw9Ajcl+idvrIeHBYu2SpJ//OabYRA1kotTFbodp2/xAPcqBUQ/7eropQCMUW8n0My tQx7uHGOSltJvuOS3KosDbBNHMmewLpnny4kNPlwb0/XuihtD/ZvBbOCCLEkQVwArJR4 Cmjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777550434; x=1778155234; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qJ8Z+a0emIBhKGFU70tK/Y6xfc8pLkgntdZpPCo3x24=; b=q5ODhROHL8sV/msWj6bjPl8yLUwa2ori1dG7As+CRN1UYFSImhWZrGYJF9AVQBrNuj bew07Qp0LLhlxtTCtKrjsKGILN7egKF5tZCoBbDroO7l0iXydpPXDD49/rOpD6tyfpKL F1lQ180CKHDPWGF6/5DnQh7d68jrvu5EwQn06pHDedZCepwznUU4IgnfCv32UmB25F3O lCPd5EU4oHLD4XEFtQnyXxWZJrwmFmg5vNND4WFi18JoMdxd1O/karAo66hHkH5JEO9T o5QY6lJUROjEaP5B6o0lFnq3rXhNXzrHInZCuhraOok5xJ9ruUDOwuge7hWN2NHO3QTU VVgw== X-Forwarded-Encrypted: i=1; AFNElJ/G1OQ12ikASnFXFVWTscpSDstzGGoUC6iyh+85MpXINJfV/wIfaMEyVVbsdf0aS5tBqY6SlbNZowviRIU=@vger.kernel.org X-Gm-Message-State: AOJu0YwnzPf2LEPvG7BMqUpQ5jatQDKIkcYCRvERySA+c6whE6swKfDy HYlsRZMMmrgu2xsWJXrze4BQfi56Na7ji9VkmDa/16uGGtvxaaouYC3u X-Gm-Gg: AeBDievRYlSQyTTYlNrGcVYnhkgk+ZkwWajb9u+0Uv+5H3t0rKQ5uOSXR8JaDSRF+qw rxuth3tqAa17oBy3aZ5XW3An3evbJUXp60yNTQBI7fBzkZdsJ2/92PZMkS2vK4D+Pa2j3bWku2z WPvBEU5yTeYg30emCw5MWmunglYcfraIfPuyWsMlEMLGWyuKnTj548Ur9bDzGsprlxELMBDPbJr bN9hwHtBHWD4v21uo6BYnuWIbgfdNuD0UVIE3lcqMBhCDK2Nm6sDHIz1dp9qFlaHWl36MmAYHbu gekLFp+dGiJzt1T1E/9GyW3A4uwoyG3p5n9XQqyC06FDB86190sAPlMpuEnHCfQL5IhsyPu1GIx NTYlJ+5Ex0Z8oCNplaS5kEwo5TfmMwauSmn/Ql8lGJdgQxzwAqOw33X20cJ+aBzc2cJ4zVML16B KBmcQGnNrgDxJSaUA6LzcxZ7M= X-Received: by 2002:a17:903:264f:b0:2b2:65db:8c51 with SMTP id d9443c01a7336-2b9a231ababmr18912845ad.8.1777550433452; Thu, 30 Apr 2026 05:00:33 -0700 (PDT) Received: from lgs.. ([118.193.39.24]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b98893f317sm53983175ad.53.2026.04.30.05.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 05:00:32 -0700 (PDT) From: Guangshuo Li To: Borislav Petkov , Tony Luck , Doug Thompson , Greg Kroah-Hartman , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Guangshuo Li Subject: [PATCH] EDAC/sysfs: Fix error handling in edac_device_create_instance() Date: Thu, 30 Apr 2026 20:00:19 +0800 Message-ID: <20260430120019.464049-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Once kobject_init_and_add() failed, we should call kobject_put() to decrement the reference count of the initialized kobject. Or it could cause a reference count leak. The release callback of the instance kobject drops the reference of the main kobject, so replace kobject_put(main_kobj) with kobject_put(&instance->kobj). As comment of kobject_init_and_add() says, if this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. This issue was found by a static analysis tool I am developing. Fixes: b2ed215a3338 ("Kobject: change drivers/edac to use kobject_init_and_= add") Signed-off-by: Guangshuo Li --- drivers/edac/edac_device_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/edac_device_sysfs.c b/drivers/edac/edac_device_sy= sfs.c index 32460c6dfb7c..0f5bc2f1fa5e 100644 --- a/drivers/edac/edac_device_sysfs.c +++ b/drivers/edac/edac_device_sysfs.c @@ -626,7 +626,7 @@ static int edac_device_create_instance(struct edac_devi= ce_ctl_info *edac_dev, if (err !=3D 0) { edac_dbg(2, "Failed to register instance '%s'\n", instance->name); - kobject_put(main_kobj); + kobject_put(&instance->kobj); goto err_out; } =20 --=20 2.43.0