From nobody Tue Jun 16 16:41:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 235D13FD15E; Thu, 30 Apr 2026 08:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; cv=none; b=t2dCx0i/wHdbAbN0IYlswzawryAIharV7x36jmP9snyO52BrLV9qYo33NzYVHgEluepmfRzAVwwHNC8TkSHDsKMGy/2/KkQ7AkfyhjcGNwCr7iRJGcTOEzPCLMQKNoPUQ2HGR7Hb+wLIplPrDWwP/u/GNuTd8hF2evXohzebRIM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; c=relaxed/simple; bh=w4MvbuUnVFxrRLrqGcz+OIFkZ2X2qfkCXwh910utgqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KDbLHvXqo0P2Z+t50H0+9U4CCV0OwO1dOZlFKppFFC+XNApBOQEMQMKAhlKtz1EAmnVB7IRxG54cU36gMT/5qTipoRM/hdBtvri1KYo+JC/oQ1VRS/0cWzVpXhewYYLuMPc7qg7Y2747FTMr6jbwJVMy7JUTiA9paU/l+SL5rTg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J36Uxyl5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J36Uxyl5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9D18C4AF09; Thu, 30 Apr 2026 08:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777538033; bh=w4MvbuUnVFxrRLrqGcz+OIFkZ2X2qfkCXwh910utgqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=J36Uxyl51qV1TMtO70TlIuevJnP9WfqcH1nq4Id7hz8F22pgNl7X2vSNo0EF/nH0W owqKo+aGWcWhnEEE4GcT0A4IAN6/tgwt2qeyzmtPXuhdWcQ77x5HUGqf/h9AoYXYQF NBwUoTtIFo91TZvnzS7CFqlUBVXCMwWlXDniVAbV80/6nBer0wJLnsAc4aLauha2TF U7iWmD5uKLAjBlQTxCTLAmFtLYVBTxgr2BdxoB8KhBxItd1WgVdyq/MMUWMnPI5PHN ewF2+V+Zg5QFxoKI4vzusP7+05MPFfbtWWV/pLYxw0/HQ9x63MgYV5rwnBvcneeRIh PwVH+uPPf597Q== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wIMqF-00000000u0A-1lNw; Thu, 30 Apr 2026 10:33:51 +0200 From: Johan Hovold To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Jakub Kicinski Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 1/5] wifi: mt76: drop redundant device reference Date: Thu, 30 Apr 2026 10:33:31 +0200 Message-ID: <20260430083335.215239-2-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430083335.215239-1-johan@kernel.org> References: <20260430083335.215239-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt7615/usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7615/usb.c index d91feffadda9..bab7b91f14be 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7615/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb.c @@ -151,7 +151,6 @@ static int mt7663u_probe(struct usb_interface *usb_intf, return -ENOMEM; =20 dev =3D container_of(mdev, struct mt7615_dev, mt76); - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(usb_intf, dev); @@ -193,7 +192,6 @@ static int mt7663u_probe(struct usb_interface *usb_intf, error: mt76u_queues_deinit(&dev->mt76); usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); =20 @@ -211,7 +209,6 @@ static void mt7663u_disconnect(struct usb_interface *us= b_intf) mt7663u_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); } --=20 2.53.0 From nobody Tue Jun 16 16:41:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 234353FA5E4; Thu, 30 Apr 2026 08:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; cv=none; b=M2zGhlGJyL4vkpW6zj6rHsPskgpDSU6Qko3svgerf0jjU77rVxEcvNmiZ9rjMzn4FdLBpijz0IBhs5cdQwAA+hI7vU15w3L8f6JjceQfXFwL46AHNVfpnNxCfHlF9sSpJqdN5b5iXdWbpyNGoZLzMtioozTqaftTrf2jNuwRntY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; c=relaxed/simple; bh=YO7Gtjp7Rhq78Vi+kItsnH71DQJHJ1pnJYYDbxGMe+8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t1j7MMQ/cl12nbfCNh2I4OMj23SuURovIrP/tqaPtJFROq6sstk70WiwzAOEYnRGXc19yW9VTa4xFJmII7llpDfiNiJaGB8xXD+ztECYN0VRhs+bDlXffRjFgkCgiFGH0NVqgz4v0ykHbf8T+GwOh9tibjMrHt7VivuSG7htLHw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IDOXNcIS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IDOXNcIS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C5C1DC2BCB3; Thu, 30 Apr 2026 08:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777538033; bh=YO7Gtjp7Rhq78Vi+kItsnH71DQJHJ1pnJYYDbxGMe+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IDOXNcISNwOHmdvjlAuVgXfVejMPGwgZhctG7cnr1733J9TkluzPNLKuOiol1A+nK 9Lcb4TnpLjLGPlV+F6i8TPap6JNINJUd1VeTGDSZYGqB1W1QZFl80KHyQZoOQL4SsP A6rtTtfIr13/i4EqUF4T+IIuplgXc+mqk3FJZRcn7MzoDSjMidJd0fTO2WzhSK9lM5 2NFutflm4mgYKNZgBf2TwAIfGwWpF9lbvNi+rB5ntnUJ26hjwbWfR5lHQxTLVsQ49U Z0Rl1FU1aT62b1B+H4jUqFh2AFe6/fRs6LrtB90TNLMx4GF5DsDYcFCUA4dptTI6Xa adGmtl/Qk28MQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wIMqF-00000000u0C-1oJe; Thu, 30 Apr 2026 10:33:51 +0200 From: Johan Hovold To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Jakub Kicinski Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 2/5] wifi: mt76x0u: drop redundant device reference Date: Thu, 30 Apr 2026 10:33:32 +0200 Message-ID: <20260430083335.215239-3-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430083335.215239-1-johan@kernel.org> References: <20260430083335.215239-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt76x0/usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c b/drivers/net/= wireless/mediatek/mt76/mt76x0/usb.c index 90e5666c0857..2acce121fb14 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/usb.c @@ -245,7 +245,6 @@ static int mt76x0u_probe(struct usb_interface *usb_intf, if (id->driver_info) dev->no_2ghz =3D true; =20 - usb_dev =3D usb_get_dev(usb_dev); usb_reset_device(usb_dev); =20 usb_set_intfdata(usb_intf, dev); @@ -284,7 +283,6 @@ static int mt76x0u_probe(struct usb_interface *usb_intf, =20 err: usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); mt76u_queues_deinit(&dev->mt76); mt76_free_device(&dev->mt76); =20 @@ -303,7 +301,6 @@ static void mt76x0_disconnect(struct usb_interface *usb= _intf) mt76x0u_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); } --=20 2.53.0 From nobody Tue Jun 16 16:41:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 477973FE354; Thu, 30 Apr 2026 08:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; cv=none; b=poD459k8mnEu+YgiF/qN8s6I6sIlImUYqheWtsz6EGnC8pfwSufl5eyVfd7BvzAGJHJPSliOOvsKW47Xdl8+xHrhuHGue+U9guflXZ5dSye355ylPSnx9LNyY0Qc7Rx7vxjhbEWqVBbxOUDtsB0sCRtKmD6s0oZpgfJXd2ADO+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; c=relaxed/simple; bh=JCt6tWeOBXoxgLUmoQyal2hT8O3E6cJwSDW9MnTpiqk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XrCrdTyUrUHrhwvIEfKzBC8SsjH8rzpf322NqYqy/FdgGdxLagGVorBi448oKav+cRS6VATKUQ2ktwfqNMsDJtn050RBANm/SIkFmG1wDgQ9/l0PpUXybGpzuP8n5i2fwDIJWxVOeSretoccO7UWGwhwIqiXuLNszTMRsvr5jCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EubHyBUC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EubHyBUC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0E42C2BCC7; Thu, 30 Apr 2026 08:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777538033; bh=JCt6tWeOBXoxgLUmoQyal2hT8O3E6cJwSDW9MnTpiqk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EubHyBUCQggaxhwStKQb2aj2yoDp5sa+R3y63rWzbrbiZGRLjFSFn6u44Vzfqyulz 71jthDqzU6zIECne1eoG9VPFAW6dzKHdYO90CbocmjGvduXF+szcd5saqxapKX7v47 k5SCPP6dyvtrQ6+laqCByU/jOklpx+OjmH/oQxxcdQjjaZd9gN3qrS2JlEBcLfcSDA eZSvMIANbZ3mx9xDaiUlMJTc+E5N2Ml6/PUCRlNsZ28H4MLqGANOA0xDbMf55ABaKV SIwWQB0PLjMvFy7gu8RO4zLs15rvVC4+yJf4lSaPdObSpFkKslhLlynOenccsasUig 9otq6D9SBEWlQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wIMqF-00000000u0E-1qgX; Thu, 30 Apr 2026 10:33:51 +0200 From: Johan Hovold To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Jakub Kicinski Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 3/5] wifi: mt76x2u: drop redundant device reference Date: Thu, 30 Apr 2026 10:33:33 +0200 Message-ID: <20260430083335.215239-4-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430083335.215239-1-johan@kernel.org> References: <20260430083335.215239-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt76x2/usb.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c b/drivers/net/= wireless/mediatek/mt76/mt76x2/usb.c index 01cb3b2830f3..8af360bca643 100644 --- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c @@ -57,7 +57,6 @@ static int mt76x2u_probe(struct usb_interface *intf, =20 dev =3D container_of(mdev, struct mt76x02_dev, mt76); =20 - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(intf, dev); @@ -84,14 +83,12 @@ static int mt76x2u_probe(struct usb_interface *intf, mt76u_queues_deinit(&dev->mt76); mt76_free_device(&dev->mt76); usb_set_intfdata(intf, NULL); - usb_put_dev(udev); =20 return err; } =20 static void mt76x2u_disconnect(struct usb_interface *intf) { - struct usb_device *udev =3D interface_to_usbdev(intf); struct mt76x02_dev *dev =3D usb_get_intfdata(intf); struct ieee80211_hw *hw =3D mt76_hw(dev); =20 @@ -100,7 +97,6 @@ static void mt76x2u_disconnect(struct usb_interface *int= f) mt76x2u_cleanup(dev); mt76_free_device(&dev->mt76); usb_set_intfdata(intf, NULL); - usb_put_dev(udev); } =20 static int __maybe_unused mt76x2u_suspend(struct usb_interface *intf, --=20 2.53.0 From nobody Tue Jun 16 16:41:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233B03E0C59; Thu, 30 Apr 2026 08:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; cv=none; b=oe+UZ6um+VWdB2Y0BrPcl0X2Zc0cg2x8coq4WNBpLh7HQZuRLvBgOtDv8SCiv7GzQ4BDq1FQV4j4IAzKAiX43ayb1wYPE5qHSmCpAbWuMDWSUFUX7IsYvfsiwxEpv8D8j2lWL4nyJ7Mt3rb0RgWbpu4br9px6tMeWWjv8AfNuzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; c=relaxed/simple; bh=NJWCpHLArg8paeKRmtaOO1YhmVDyGXFRGMJt49dMrn0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bwpbwlT8hrWK2vnzmxQEX7Fe7bq49NosiFDtLTTFsXoTz3wUgCfobxuBe8g95eYjaLdlQiH7/AFOeBEqlVJ2v1rTl5azJSDW4fAdDTl8/45/Ls/JIZu/qaFtLzo5la5s2AGjT5qYdV808HnPXDtqPL9vo3MhF+xV5q/2SEH/IOk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nmKG4Hp9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nmKG4Hp9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC4D5C4AF0C; Thu, 30 Apr 2026 08:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777538033; bh=NJWCpHLArg8paeKRmtaOO1YhmVDyGXFRGMJt49dMrn0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nmKG4Hp9dU0q4m/RWs3MC1wIAb5vHhuqs8CZA5vxsTrYdeUirCJdRAjA3KNzFPepP X/gPufSQDrrqdLFjYnGWqkzJYmRy9QmxRju94gSCW2z0OMokR9VJY/49l32A14fc/q /TJdwwuFqDNoQGUqmio6Bm+T70qs9fAc6bo3nrYhMth9SyvUmkYx3uh2mgNT5CwRUG cud2iVj5v/5D9Y5txej0uJ1C2dh1aUlMTn4yGUEzXPdZqxAfeqDJ8goQ0fHNPIOCxH le9yMThMsNyuHig7rHkrtTOtpqZTZrsMMyFPQsbQHPJ0yVxO8/Twa8dvZ9cMQpYxPO PaaKJDQ5TIdTQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wIMqF-00000000u0G-1tDe; Thu, 30 Apr 2026 10:33:51 +0200 From: Johan Hovold To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Jakub Kicinski Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 4/5] wifi: mt76: mt792xu: drop redundant device reference Date: Thu, 30 Apr 2026 10:33:34 +0200 Message-ID: <20260430083335.215239-5-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430083335.215239-1-johan@kernel.org> References: <20260430083335.215239-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt76/mt7921/usb.c | 2 -- drivers/net/wireless/mediatek/mt76/mt7925/usb.c | 2 -- drivers/net/wireless/mediatek/mt76/mt792x_usb.c | 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7921/usb.c index 17057e68bf21..9bfc234f306f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/usb.c @@ -197,7 +197,6 @@ static int mt7921u_probe(struct usb_interface *usb_intf, dev->fw_features =3D features; dev->hif_ops =3D &hif_ops; =20 - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(usb_intf, dev); @@ -246,7 +245,6 @@ static int mt7921u_probe(struct usb_interface *usb_intf, mt76u_queues_deinit(&dev->mt76); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); =20 diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/usb.c b/drivers/net/= wireless/mediatek/mt76/mt7925/usb.c index d9968f03856d..84bcebbf009a 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/usb.c @@ -185,7 +185,6 @@ static int mt7925u_probe(struct usb_interface *usb_intf, dev->fw_features =3D features; dev->hif_ops =3D &hif_ops; =20 - udev =3D usb_get_dev(udev); usb_reset_device(udev); =20 usb_set_intfdata(usb_intf, dev); @@ -234,7 +233,6 @@ static int mt7925u_probe(struct usb_interface *usb_intf, mt76u_queues_deinit(&dev->mt76); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); =20 diff --git a/drivers/net/wireless/mediatek/mt76/mt792x_usb.c b/drivers/net/= wireless/mediatek/mt76/mt792x_usb.c index 47827d1c5ccb..0d9dbd0aaf9e 100644 --- a/drivers/net/wireless/mediatek/mt76/mt792x_usb.c +++ b/drivers/net/wireless/mediatek/mt76/mt792x_usb.c @@ -341,7 +341,6 @@ void mt792xu_disconnect(struct usb_interface *usb_intf) mt792xu_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 mt76_free_device(&dev->mt76); } --=20 2.53.0 From nobody Tue Jun 16 16:41:49 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 233182C029D; Thu, 30 Apr 2026 08:33:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; cv=none; b=tat913byvOBc9lYrz5f5YUy+qFMM0nPoBNUe/pNFvitnIQEcEqoxU0D37LC1BkRwOkZ1K+eWI7nKXouTyQhfvlMjXnGyRUycSTIQgNzMTcUJ4PrFW+Rf9V/3P1V96bCXnVgOFAVU43dbRaXdTtUVeX6zE3G8y2y3/AanktGwrSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777538034; c=relaxed/simple; bh=vxD9xO6E6gxI2jN1+uuURcxBVAKWmSKLybdcQnknBu0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Hh/QrOopC//r6wz+7CXaXowiCyCvAwRx4iSaLQTTLHGKXzKdUhLO/oQUB3dZ7SxejufYjo0ROsURZddAqGdBk8iy4ab675AxjMgtYofV45QjlhklCs7+W+PFeeFc91rq1fY7AxBPRKMYwKlujthS4CisuxabMEHqQSLFmVV9jLs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Udrd04/G; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Udrd04/G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE90FC2BCC6; Thu, 30 Apr 2026 08:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777538033; bh=vxD9xO6E6gxI2jN1+uuURcxBVAKWmSKLybdcQnknBu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Udrd04/GFekpcWkAbRf/DTZeYGDjPZ10LeYx0lyl78iRMOLH2LjsubMJ2JZv+gfBo jpd3fDuzxLGgZSJIEo68r4DVjkRPbrVhTQLfmYv3cN3s11ZgrbFGC/gg8rKaoZQyXc hBDlXSWV9ZR830TT0mtp1blKFrvymmUEFBFMcTQyuwyfrwP/inHW4V+fsMimDFv96T e/W+WUh7aCP5QMmM73UtB5Hm21Dl5XK0hhhkVTt87hpJIR4GO3B2X7s7RQx8Ui1w/B HSKILqEZ+gZPcJ+y/agypuJ1MceBh2iKgdXiMCWHH2jjTz9nNyZvPGYpzA+XFXI7i2 6wBLY21Lo87NQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1wIMqF-00000000u0I-1vYF; Thu, 30 Apr 2026 10:33:51 +0200 From: Johan Hovold To: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Jakub Kicinski Cc: Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 5/5] wifi: mt7601u: drop redundant device reference Date: Thu, 30 Apr 2026 10:33:35 +0200 Message-ID: <20260430083335.215239-6-johan@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260430083335.215239-1-johan@kernel.org> References: <20260430083335.215239-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold --- drivers/net/wireless/mediatek/mt7601u/usb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/usb.c b/drivers/net/wire= less/mediatek/mt7601u/usb.c index c41ae251cb95..9306870cbc91 100644 --- a/drivers/net/wireless/mediatek/mt7601u/usb.c +++ b/drivers/net/wireless/mediatek/mt7601u/usb.c @@ -274,7 +274,6 @@ static int mt7601u_probe(struct usb_interface *usb_intf, if (!dev) return -ENOMEM; =20 - usb_dev =3D usb_get_dev(usb_dev); usb_reset_device(usb_dev); =20 usb_set_intfdata(usb_intf, dev); @@ -319,7 +318,6 @@ static int mt7601u_probe(struct usb_interface *usb_intf, mt7601u_cleanup(dev); err: usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 destroy_workqueue(dev->stat_wq); ieee80211_free_hw(dev->hw); @@ -334,7 +332,6 @@ static void mt7601u_disconnect(struct usb_interface *us= b_intf) mt7601u_cleanup(dev); =20 usb_set_intfdata(usb_intf, NULL); - usb_put_dev(interface_to_usbdev(usb_intf)); =20 destroy_workqueue(dev->stat_wq); ieee80211_free_hw(dev->hw); --=20 2.53.0