From nobody Tue Jun 16 17:02:08 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6BFD9443 for ; Thu, 30 Apr 2026 06:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777531473; cv=none; b=RZBfd4fO/ypNn+/MXzvAgjNmMur7+vBezmQ3o9TwqWEhVP9sPqWBNm1MOvuKPF+xWD5iE8kEov9B84l8AtZ6SYCmn7MQC2gqThPnEymgCsQENDXEBLRKkz40H7bFO3PFWk5qgRP7FtDUmXE4Ulc6hmVsegoddrA89ZHd/URVNrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777531473; c=relaxed/simple; bh=IUbqoLux3BphYMKlxh2jIHWQ6JA0E3Ujt9MElEw3xmA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N1AXDt/L2QWvbSHRZvSTbJrRkc5AWRYw4qKXMXKYmJeZpadc21kXm8pJuzKqnxDEERskjq+MgMpKSLJtZ8UkcvTLPJx8FzFl2DvoyQvehlxmlfwlJyVBK5RIhgJCN3bw12UZ07cI33NXtfFvOhPctsPRdAe0DHFSMZX/pBghwSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kaakVRea; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kaakVRea" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82f69a286dbso423794b3a.2 for ; Wed, 29 Apr 2026 23:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777531471; x=1778136271; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wFcc6j/YFOiNlxL8XiWp8rI8AJ5pkKge/fjMPVwoW4U=; b=kaakVReaXWNW7uUMLKWOeXr/CbBqvXX+lvAtWcR4d020PEUBQImZTRihfKzw5jBxj8 6hGQSZxExamS+xaI1MB467hMjMsJszV0LNE0yFnvi4q3C7VQdEVzQn64Ks/r7VtaCMiD zl3rhORKsOkwCM12vh7n0hGpGXpuvI550ZJGzSbzmCM7KUVau2Wm9GwiuBLlWx0S2doQ 0ZPT19eiMiwQiCh4w6OR53byU3EGV8So5LX9aZeMEY7TPm5RFQSuCwdYKgLt5vm6xH3C HTozS33p1yBm/dNlsttciFXgMKpiaIQ0jnoNRL06/lmwb+grNfeQkU7/rwzsao8z+nnP KQ9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777531471; x=1778136271; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wFcc6j/YFOiNlxL8XiWp8rI8AJ5pkKge/fjMPVwoW4U=; b=Ovmzo8fKEW8v6Owdxup5uZxx82VGtldvVFBjJu/rkBvTjNkYSorAgPyALmN2+/94az WuzGSnEgEQ0mjqQzCUKlDAqOkx+wPYPXocu+RXaweaJs4Vo3QQlmgeH3rBjumdtPZnZZ C7WbiCJKPNFDkjRPd0mXM1ailzDBpiBOip+Ra8WHIgLGf6hqBYzmpCVsMhs3tg09XQBp w31f5EvyKb594VXM8iq/J2+ZJ4khsY/nFEN29wSH1M2VRMti3yhWjzsGRH1lVnwdh9OS QQRA8IfqyVrY2IAEvSPsGZfXtCNiKK4LBoJV6hxA0+EwSLNxt9XWsKiEPx94q5zUXmzn 0Ozw== X-Forwarded-Encrypted: i=1; AFNElJ++aW0lXfYAjQgrdYOOTpio5t8dFTPXNsCyUmAqbJjhr1gTO3bMBjYu2O5niLXRmuOE+vpTvu570PaExhM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+P5P1iQWdPkBoEJaSWPGSr4HMh55axiPzsr30xu2/nmM84+zR ydoBoFgp4PXgjuSoe1a0Gh1EujpvjK3M/WZpB1qIOCeBHpsrig0WjnL7 X-Gm-Gg: AeBDiet3cQCQKmbMoXxkkOUqwHpXEUk1sLnwh7nQiXes1yJpuufMpgOUwMEvphtO0wu PLDHouzJge4lNLa2pwjeDGfmBKI2jyVpBlxsgGB4pBmsiMIs+Ct3U6zEqJF+lXV8iFq1Pshaj3R PE7KegZXOmkg1obWh7JzCdWOvg4Nul/AUJmlMYnkeS/jT21JEGk7GbmTFlyxjpe1nQB3RixuVmg jbPc47Z9ioSXue5ds3Gfyq4OFGYZsj5N5JdRyi1ITvWJI4GG4NPjCqx39HXvQFEVltzskL3o++r F9CN/PyrgK0C+gyqwGuwfkB8lMYbDTY0Y5t9jCqHv2puOyfjEp9rrcVHKqVfY3o1A+P74WGozmB saz/Z+gvdFX2XHybbhEEUmIMKqR7rVyFSzVM+btE5QGOm4d6KQ+tdovCjKrm7Rf1qJv0eMwVEr+ QhgnndGKPSxpLfeDmq X-Received: by 2002:a05:6a00:9504:b0:82a:7aa3:a2fb with SMTP id d2e1a72fcca58-834fdc321a7mr2210468b3a.37.1777531471224; Wed, 29 Apr 2026 23:44:31 -0700 (PDT) Received: from lgs.. ([2001:250:5800:1000::5a26]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834ed7eb691sm4140314b3a.48.2026.04.29.23.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 23:44:30 -0700 (PDT) From: Guangshuo Li To: Johannes Berg , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org, driver-core@lists.linux.dev Cc: Guangshuo Li Subject: [PATCH] devcoredump: Fix double free on device_add() failure Date: Thu, 30 Apr 2026 14:42:14 +0800 Message-ID: <20260430064214.450099-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If device_add() fails after device_initialize(), the error path calls put_device(&devcd->devcd_dev). This may drop the last reference to the device and invoke devcd_dev_release(), which frees the coredump data, drops the module reference and frees the devcd entry. The error path then falls through to put_module and free, causing the module reference and the coredump data to be released a second time. Return after put_device() in this path since the device release callback has already taken care of the resources owned by the devcd entry. This issue was found by a static analysis tool I am developing. Fixes: 833c95456a70 ("device coredump: add new device coredump class") Signed-off-by: Guangshuo Li --- drivers/base/devcoredump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c index 7e4a491bf15e..cdefdc8e83eb 100644 --- a/drivers/base/devcoredump.c +++ b/drivers/base/devcoredump.c @@ -437,6 +437,7 @@ void dev_coredumpm_timeout(struct device *dev, struct m= odule *owner, mutex_unlock(&devcd->mutex); cancel_delayed_work_sync(&devcd->del_wk); put_device(&devcd->devcd_dev); + return; =20 put_module: module_put(owner); --=20 2.43.0