From nobody Tue Jun 16 18:08:52 2026 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C882D376BCA for ; Thu, 30 Apr 2026 06:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777529604; cv=none; b=HTvtCZljbAwCWndd5ilUfpQ6rwCGxd6Z4YXgpZLy8fMKDvBFt9PdHpHqiNIZiIQUftNE6oAithE2x1e1cl1LkrEHsKsKCkYG1kUx/WoPMoN9FPdI8UiR4KpCvqIgaDphz/MgauehZuAJcH9tZuw3icuwxrC+Mu95+biThGtEpA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777529604; c=relaxed/simple; bh=zxlZItO5hWJEoU/1S6/G5B05ZPLQAn5yxa9+wPWC0hk=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=J+dL2b2s1sgxL1t3dMyCRcu26Dp+6v7QAP3nqZb4T3g/E1IKXYlj5go8zRWcVu8W37rx0UPmXJ0PtCEeBbvzPy0p0p1HfezH1W66gfWu8Y1zRw6AKDpoprTTCBus0n6GMLL5UmLzs2Bvo3qF3POPNmaVGIuFmc5FxAyb8Fd3le0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn; spf=pass smtp.mailfrom=realsil.com.cn; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b=VyG+KrwQ; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b="VyG+KrwQ" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 63U6DHyxC1728237, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realsil.com.cn; s=dkim; t=1777529598; bh=rRwb1pV09tAnYqDEA4pRTz2HwsofGD7J2b8RpNSI7jU=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:Content-Type; b=VyG+KrwQaKwjjdha0leLLfohYeqN7uJ8dK6fHJxQf65oKnzNM5WJumTQJIJYWnZTb pVZkkf0oXw9VBMvKS0sld0UkRewVoIrWTI32HWHpjCNOvVfVm6bjOTD29BMxKuKnqc ZdeP8ant5ujRsDoKZKyy9tpEgokg9UcEfNgdvvKxF7/yRftej+HHPEXgOpUvb3IHsB ImOZBxUjac1LoBfLgzuwKRGO+uaOrK4Oa1Aaq+tviGvMKa5hpDBZ2gwUTZLOFsW4kx Q7UrPecWLwr+tphfvPz7dHt1CsHpiFsEFL1SMMmDBz07P/Sngx9W9ASHuMUZ64rHd5 OdwGXWdSNaf6A== Received: from RS-EX-MBS4.realsil.com.cn ([172.29.17.104]) by rtits2.realtek.com.tw (8.15.2/3.27/5.94) with ESMTPS id 63U6DHyxC1728237 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 30 Apr 2026 14:13:18 +0800 Received: from RS-EX-MBS1.realsil.com.cn (172.29.17.101) by RS-EX-MBS4.realsil.com.cn (172.29.17.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 30 Apr 2026 14:13:17 +0800 Received: from 172.29.37.154 (172.29.37.152) by RS-EX-MBS1.realsil.com.cn (172.29.17.101) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 30 Apr 2026 14:13:17 +0800 From: javen To: CC: Javen Xu Subject: [RFC Patch] r8169: fix RTL8116af cant enter s0idle Date: Thu, 30 Apr 2026 14:13:16 +0800 Message-ID: <20260430061316.718-1-javen_xu@realsil.com.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Javen Xu RTL8116af is a multi function card, if system want to enter s0idle state, all of the functions should enable aspm. As function 2 to 7 are not exposed to pci system, we must set aspm by csi channel. Email just for test. Signed-off-by: Javen Xu --- drivers/net/ethernet/realtek/r8169_main.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethern= et/realtek/r8169_main.c index 1173a305735a..c0feb1929057 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -1200,6 +1200,24 @@ static void rtl8168_other_fun_dev_pci_setting(struct= rtl8169_private *tp, } } =20 +static void +rtl8168_set_dash_other_fun_dev_aspm_clkreq(struct rtl8169_private *tp, + u8 aspm_val, + u8 clkreq_en, + u8 multi_fun_sel_bit) +{ + u32 clearmask; + u32 setmask; + + aspm_val &=3D (BIT(0) | BIT(1)); + clearmask =3D (BIT(0) | BIT(1) | BIT(8)); + setmask =3D aspm_val; + if (clkreq_en) + setmask |=3D BIT(8); + + rtl8168_other_fun_dev_pci_setting(tp, 0x80, clearmask, setmask, mu= lti_fun_sel_bit); +} + static void rtl8168_set_dash_other_fun_dev_state_change(struct rtl8169_pri= vate *tp, u8 dev_state, u8 multi_fun_sel_bit) @@ -3895,6 +3913,7 @@ static void rtl_hw_start_8117(struct rtl8169_private = *tp) r8168_mac_ocp_write(tp, 0xc094, 0x0000); r8168_mac_ocp_write(tp, 0xc09e, 0x0000); =20 + rtl8168_set_dash_other_fun_dev_aspm_clkreq(tp, 3, 1, 0xfc); rtl8168_set_dash_other_fun_dev_state_change(tp, 3, 0xfc); /* firmware is for MAC only */ r8169_apply_firmware(tp); --=20 2.43.0