From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9AEF2D5C83; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=XsB/XN5bLZLW8pJ2uI+sDDwssr0U/XAjGhcyEoGmW1UoVNDpvtAn1kKi8gZkHozcLBY/Co2bkR3NCjGf7e9qVhp85nBEv0rjG8IZNjNV4xAJwVsgsd/3E/Y4ZSFMdrzI/HhaFttS1HYI/iYArT5Fk0ruckUawI2WArZ6pqwA0Y8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=w+gBC9LzLfUEZ39E2NnGtPODhMvwLIgz7oHW/1UC2ec=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HvF3KeLmUE2J08yOxBQESpX5nIhhXUWH1RQ74vOMffg2x1W/WWyvIgyidmomAK+SxxcOlHMLvO96VpoIATmSDqpykaMXgi0KHaRLbcK0hKXCbhEgH/cCifVGnlXWIY+Nhh2K7oZ1e0oL3iUCfIdrJjcluJr0pC/xM3V+5Ls+hVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uZC4NGEO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uZC4NGEO" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6D7FEC2BCB9; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=w+gBC9LzLfUEZ39E2NnGtPODhMvwLIgz7oHW/1UC2ec=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=uZC4NGEO9mqvOetpW8FBkVKASpDRoWOcT5RqXsrIZ2uvHrheuAxUqpXkOhOCWcyvH 9fDM0UfFT2oEKYGT5A36KWhXPPnIWLfYqpF/titAX5TB8W5IgZ+VEw2yBr+d9PeZ2O VfLHPvFLaN17hA4/f0jdg6ib8oUpeYLdk7ZzDqZltGNHDlNHLzTUYBLP9/AQFo/EDF J3rSRMPnBrXd8d2cWNQ+1v/XKxrKsmUdnPGnlUeZWAPzlUfv2g8q95kzqKK8+Lw1// weFeJXssgWUJNWhiflXgM1b0+I4Blz6791RW171RTaQwm8SdOO/Fm9Yq61vX9cCFCG lGhw7tou3qexQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6023EFF8875; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:21 +0200 Subject: [PATCH v4 1/8] iio: light: si1133: reset counter to prevent race condition Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-1-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , sashiko-bot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=1385; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=rNb20PuoCqb49JFiqKumgMP6bKNErm8C2bsZ39xzPjA=; b=Su2w9Mjz7BWOnS0XQymPOWGGGoFG3J36nfcxqOFmVXZVlsEgdOC2S0ts+E+HkJpGsbXOnkRfr 1EfnPsSgehrBJdpRQc8i12fOBEJsJ4NMWcGSFS9kDUJIyqzNr5hidOJ X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Sashiko reported a potential race condition happening when the driver returns an errno after a timeout in the si1133_command() function. The premature exit causes the hardware and software counters to become out of sync by not updating data->rsp_seq, therefore the internal hardware counter keeps incrementing. Fix this by adding a call to si1133_cmd_reset_counter() before returning from timeout. Fixes: e01e7eaf37d8 ("iio: light: introduce si1133") Reported-by: sashiko-bot Closes: https://sashiko.dev/#/message/20260428-si1133-checkup-v2-5-70ad14bf= efe2%40gmail.com Assisted-by: gemini:gemini-3.1-pro-preview Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 44fa152dbd24c26c97cc778cbe641d92ecd56afa..c88c79202be2e21abb72067426e= 31b6bf97c61cf 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -427,6 +427,11 @@ static int si1133_command(struct si1133_data *data, u8= cmd) dev_warn(dev, "Failed to read command 0x%02x, ret=3D%d\n", cmd, err); + /* + * Reset counter on err to prevent software and hardware + * counters being out of sync. + */ + si1133_cmd_reset_counter(data); goto out; } } --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC12E2C21EE; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561516; cv=none; b=HjOGJy/wJuOfs6iIaQ9cwrmfXJgmH+A139liescw24M13vik9i1U6TNCqi+/ElHmkV7wU3+HV9XE1RRXiTqcGC7KjIkX8K7KOLSTT8zFRnz5GRY4SjtHuQWrGVbY/gMmHc1JBv7OZ3v3r6uhfVeZmwS1b2M0XfO6JO+6peyNPsc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561516; c=relaxed/simple; bh=wqz0bKGlNUuLDdzAuyBaUgHWch1GriKqzUUO2K+OxAk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M4iyt0mremOhwhAldnaUXeyA8v0xY/nsnVhYsFvUoBh5fYOXL636v6DIrvABlc2ePCYlAYYB4UfquiU6+rDEJBiO+Wm3MShlSDxPFjD+sBZg/83Z0XfKuJ5tWXz0Wg2mU+iUapLdtBoPHibrEzfZ+4pxeqD2ooUHIToJd8GpIEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nstX3A4n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nstX3A4n" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7D7F9C2BCC7; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=wqz0bKGlNUuLDdzAuyBaUgHWch1GriKqzUUO2K+OxAk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=nstX3A4n7UwgyA8BJyG2xHjs3HrVUAUcTPmOv4UIv6/bUtfgCTPDLWreqJ2ADBGtt HBuKseEYg7B1GNHvBJakyJXXbz2p5fFJ/4Yt/2dS/GuJqm6q5X7WYcoTpyA5j6L8Fa 2xp23OIE3nX/4B32m9r99hArsVJ3saIqCipEBnxKKDokRsGkGUzBgosT5Rt0q7oUV8 KH8oPav/izCWHTvm4IyYakVC08uUymha/20ZLN9VUPPYK+U5kReFYNpK/N4EYsCZvD APVWaftj58QK7YRHd4Gc/IeChvEx79MAHIVtae/8LiwYpMv3KvwySX3ZOfZMOaXIle ELT8HSBdg55+g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E94FFF8873; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:22 +0200 Subject: [PATCH v4 2/8] iio: light: si1133: prevent race condition on timeout Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-2-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , sashiko-bot X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=2070; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=oL3iK2flDthV/Ohs5rDoVs2xKZo+kx/muq+vmqyUtqM=; b=Toc4toPVX2TP6iBlB/JtrvzfsFIwpHPceZ7/WUrwS6mCB/4Yu3H9e+d1m4uZ2PxsE3HkH0xId vCKida0dVk1ApVBQ51cuzIoplN4hAajFHnajONMbD+mslbvkFpS49sx X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Sashiko reported a bug where the si1133_command exits on timeout without halting the sensor or masking the interrupt. If the sensor completes the command later, any subsequent command to the sensor will cause the IRQ handler to complete immediately, returning stale data to the driver all while the command hasn't finished yet, shifting all potential reads in the future. Fix this by masking the IRQ if wait_for_completion_timeout() fails. When initiating a new command, do a dummy read of the IRQ_STATUS register and turn the IRQ back on. Fixes: e01e7eaf37d8 ("iio: light: introduce si1133") Reported-by: sashiko-bot Closes: https://sashiko.dev/#/message/20260428-si1133-checkup-v2-5-70ad14bf= efe2%40gmail.com Assisted-by: gemini:gemini-3.1-pro-preview Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index c88c79202be2e21abb72067426e31b6bf97c61cf..bf7bf0f1631d49a1d04b89f1726= 46e4afaf46438 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -395,8 +395,14 @@ static int si1133_command(struct si1133_data *data, u8= cmd) =20 expected_seq =3D (data->rsp_seq + 1) & SI1133_MAX_CMD_CTR; =20 - if (cmd =3D=3D SI1133_CMD_FORCE) + if (cmd =3D=3D SI1133_CMD_FORCE) { + /* Flush pending IRQs from a previous timeout. */ + regmap_read(data->regmap, SI1133_REG_IRQ_STATUS, &resp); + regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, + SI1133_IRQ_CHANNEL_ENABLE); + reinit_completion(&data->completion); + } =20 err =3D regmap_write(data->regmap, SI1133_REG_COMMAND, cmd); if (err) { @@ -409,6 +415,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) /* wait for irq */ if (!wait_for_completion_timeout(&data->completion, msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) { + regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, 0); err =3D -ETIMEDOUT; goto out; } --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D99E42D5C68; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=VK61qv7uc5leRxp0mBzp64oJ4XSfEnn6vSXRI/QWQjNkppjuaas0z1331jtpv4Myyvpb1QSqopnjn/3Z0Ci56LY2+MClz/pwhDPy9x/+RaUJzCblYog3jtzFJ4TcNXkpKPTnCTiBeXuYsBHg1V6WefECFM/RVBzB2QwddrDG6eY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=diZe+qoz2LFdYgLV/qNHK+XefMfyZ8tKUWW54qfvSCs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hUBZyDspMVojCNuykuptFH1hdkoJfeOXmMcxOV+AsPUgRLMsiFG8mDg+dyLLalM/Qzxokqrm+R+TATR1HcLf+hX5IH56wNORSaRX54/lA41xvm1PsQgBc5gRXntzIKq2ZRbyagqgBe7QOO/MnrbMDKjt6k9nvZPFXkcXeZbc8lg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jkxcGQUa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jkxcGQUa" Received: by smtp.kernel.org (Postfix) with ESMTPS id 8B8A6C2BCC9; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=diZe+qoz2LFdYgLV/qNHK+XefMfyZ8tKUWW54qfvSCs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=jkxcGQUaa+p/uV1SIUVXIQQ+MQcQkr0DtFtsWny1F3EjZRGNZpP0lXpH7Z6fjoJ96 7UIDd7VVNmERwf8ZjCbBNTscDPCYEm5IPi2DD9GbWv9Zb6IJdLtEBEtDvwq4bCwgRO 47EOG8irL8RdfFI9c4pdifCV1+pV8NIusJgmduWC+YHoXVnMT5R9fvEAe3Ha4u+T2y clJDYOrp+b1HH6dmw5z8TLs3YtgGZ8P6yofHp+QJsZx+h9CVMMlDOAg8TFyfwdkSCC AJxiJ75YQM42BCjFm7quTFqJUDAqliZkbPDg0DBv47/X76gvKrHQgdFKeZur3FItw+ DABYxPoiQnqag== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE67CD13DA; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:23 +0200 Subject: [PATCH v4 3/8] iio: light: si1133: remove unused macros Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-3-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=1046; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=7K9lqxMczl9Rl1iwkxbifs2o+8+pT5IUZAPJUPkp9dE=; b=RGBqxLa2//dYpN21QvMHjOUEJCtWMfCZ6+bysFAEKKbNizFuvdmLGd3wNluu51lvaSZ8xTX1k gAaI/DWlOTOCbSO/gQcce0xL/uIhpl7NmyvpQuPh/TU8CF1KE3/Igab X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Remove unused macros unrelated to hardware definition. No functional change. Suggested-by: Andy Shevchenko Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index bf7bf0f1631d49a1d04b89f172646e4afaf46438..ed9b3e0a12d66d749f09f570de1= ccdda2174b6ba 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -86,13 +86,9 @@ #define SI1133_CMD_MINSLEEP_US_LOW 5000 #define SI1133_CMD_MINSLEEP_US_HIGH 7500 #define SI1133_CMD_TIMEOUT_MS 25 -#define SI1133_CMD_LUX_TIMEOUT_MS 5000 -#define SI1133_CMD_TIMEOUT_US SI1133_CMD_TIMEOUT_MS * 1000 =20 #define SI1133_REG_HOSTOUT(x) (x) + 0x13 =20 -#define SI1133_MEASUREMENT_FREQUENCY 1250 - #define SI1133_X_ORDER_MASK 0x0070 #define SI1133_Y_ORDER_MASK 0x0007 #define si1133_get_x_order(m) ((m) & SI1133_X_ORDER_MASK) >> 4 --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D97F12C326C; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=nlJh53cOk8c9b5uCPdl38o4Q4SEYFOMA16Y9XQ1Cu3Bz4051+xEVPOF2a1dXxpVH3sLDQjFjB/uFEzPULLehI72RE2Rqeiwic5xS1xFII2UkZC3p+5kBIDy736Vc7i1RbiW0A8JtLxZQHJ2ZDRo9gIBqza5VZOTgnudJg9geSlQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=fGMqRAXYgyJdDBq2SYVWRgzcZFN2wRoLV+QRZsxYyag=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wz8Xft+28ukXlzGSN3ogOqnsaZFcDSqY8nh/eeWfLmCt9A/rmRfuh5vbHqKhl+D1iFc6NGl8cC/cR4nEKCz49duKDUWb6IshF/YyvX8tK0xDp2YoEdb/K9HXiP3L7+t7NjsnvsvisEMgcHZ0JCKovtkBDpI8R6+uTlKVrumnKcE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WZ/C7UTv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WZ/C7UTv" Received: by smtp.kernel.org (Postfix) with ESMTPS id 96C8CC2BCF7; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=fGMqRAXYgyJdDBq2SYVWRgzcZFN2wRoLV+QRZsxYyag=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WZ/C7UTvO3WiK5takOMuNiEdklYtXTd4+P3WTuH0fAl4/ZtEmPuKA28GgWQVZclAE h9fasI7CxMCDw/qbLWuILKx4nko1xWbYYaTP/eSXkH7QA7zPP8p7Q0RGG1G9ufzxBB ZAieoudIZM/gQgbwEzAOwaPZX6eaaU1VEItMxUT6TyNmncNLu3l2xsq0RqtDBGML/N 4/IwjLx1obyjoaHtnySwhudAbyHXxI2WO5i6uM4VpBYJu8Zy9KHI1OPPOYRr/mKwGt V/DLnwATmbS9myR6WzI9mKvlGWeBXWJrKCwW6F9r3nknDnoPALnMUUa0iTFwa5k5/B musvttT5S6s1A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9B3CD13DE; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:24 +0200 Subject: [PATCH v4 4/8] iio: light: si1133: prefer complex macros enclosed in parenthesis Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-4-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=2245; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=OzZMU15zTcx9sEaqcKvYydwvAmEqmo6kqt5pLe1FX08=; b=J4c8vlAtjvydqXUFQbrRV46xKf82utdbK1AS8pJjwAfg4jCPSqT/Jz7qZjWktLdEAJk6FehCb xzQujZkShqWD4OxMvnu8S3qbVBC6Ve/Uqo6l1q1HeKmNm0R2zSSI5Gf X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Enclose complex macros in parenthesis per checkpatch.pl error to improve code style. Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index ed9b3e0a12d66d749f09f570de1ccdda2174b6ba..9abc0a7e2ecf0d2fb1bd3af88eb= 675e9f1be4665 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -50,23 +50,23 @@ #define SI1133_MAX_CMD_CTR 0xF =20 #define SI1133_PARAM_REG_CHAN_LIST 0x01 -#define SI1133_PARAM_REG_ADCCONFIG(x) ((x) * 4) + 2 -#define SI1133_PARAM_REG_ADCSENS(x) ((x) * 4) + 3 -#define SI1133_PARAM_REG_ADCPOST(x) ((x) * 4) + 4 +#define SI1133_PARAM_REG_ADCCONFIG(x) (((x) * 4) + 2) +#define SI1133_PARAM_REG_ADCSENS(x) (((x) * 4) + 3) +#define SI1133_PARAM_REG_ADCPOST(x) (((x) * 4) + 4) =20 #define SI1133_ADCMUX_MASK 0x1F =20 -#define SI1133_ADCCONFIG_DECIM_RATE(x) (x) << 5 +#define SI1133_ADCCONFIG_DECIM_RATE(x) ((x) << 5) =20 #define SI1133_ADCSENS_SCALE_MASK 0x70 #define SI1133_ADCSENS_SCALE_SHIFT 4 #define SI1133_ADCSENS_HSIG_MASK BIT(7) #define SI1133_ADCSENS_HSIG_SHIFT 7 #define SI1133_ADCSENS_HW_GAIN_MASK 0xF -#define SI1133_ADCSENS_NB_MEAS(x) fls(x) << SI1133_ADCSENS_SCALE_SHIFT +#define SI1133_ADCSENS_NB_MEAS(x) (fls(x) << SI1133_ADCSENS_SCALE_SHIFT) =20 #define SI1133_ADCPOST_24BIT_EN BIT(6) -#define SI1133_ADCPOST_POSTSHIFT_BITQTY(x) (x & GENMASK(2, 0)) << 3 +#define SI1133_ADCPOST_POSTSHIFT_BITQTY(x) (((x) & GENMASK(2, 0)) << 3) =20 #define SI1133_PARAM_ADCMUX_SMALL_IR 0x0 #define SI1133_PARAM_ADCMUX_MED_IR 0x1 @@ -87,11 +87,11 @@ #define SI1133_CMD_MINSLEEP_US_HIGH 7500 #define SI1133_CMD_TIMEOUT_MS 25 =20 -#define SI1133_REG_HOSTOUT(x) (x) + 0x13 +#define SI1133_REG_HOSTOUT(x) ((x) + 0x13) =20 #define SI1133_X_ORDER_MASK 0x0070 #define SI1133_Y_ORDER_MASK 0x0007 -#define si1133_get_x_order(m) ((m) & SI1133_X_ORDER_MASK) >> 4 +#define si1133_get_x_order(m) (((m) & SI1133_X_ORDER_MASK) >> 4) #define si1133_get_y_order(m) ((m) & SI1133_Y_ORDER_MASK) =20 #define SI1133_LUX_ADC_MASK 0xE --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 047A02C11DE; Thu, 30 Apr 2026 15:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=OLxQ3x2eFKTAbmLt+V8H1jfPdEnMKRA5LrR1FmSCFr+KYfFnR6QIJcs2E2uu/yKQ/Lbpw8nxTG1qvPekSaWM1QjpqleuOIKGhoKdOEqP3Ma3qhoaRY0k6yJWmUVuvGP6LCQDFm9U6ufUUySAi9qOVeKs7s9D/w9K7WhpXH1bWw0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=fQlarxgXxDJC/844KAcpEmpUlzcx0f6w63+RHa2rEZk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Cnuz83kGKjR+LqRzxe/lbrN8u62DDIAA4C0CeorFxL/ybVONHjoiNnLJeelYEl6Y7Yj5v2Z4FXV1sJSGa4kOsJG2nyL2StBKt1v557VYJ96NrfIhEiT+mt/rSLd0v4vNfkecHLOtYVvFQi8+RaWUKh9jm8abeKrsDqgTgw+uk6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mWVOcguY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mWVOcguY" Received: by smtp.kernel.org (Postfix) with ESMTPS id A10ECC2BCFB; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=fQlarxgXxDJC/844KAcpEmpUlzcx0f6w63+RHa2rEZk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mWVOcguYEIIgnIp4P2GjA68oBxb48Th0CgN3zS2NLRlGvf0WcenXpl4cy2/3iE/qO Z0x+/d/z6OKnNuVe/ilKoRdF3WguPCmxDNYJEzghHo1d51GOYFAQPDHeYrnMYQzjPx XCbv7sV4PKLJE2IQl1gtcFalVw4AD6Wbh5V7OifyPcV9vz6zEswH4UGYuNSaxBo0sy MntG/LDotnt0ISVXsoh/seexa/wxcMOhUfSp+zymlWzi39x1INAM/exJUcKbbecuiR r7Ia6H5Os1SRKSgqgvfFj13mkGDKEXkgg12djLzon+K3Whj5jSz7MK9MUflO0U/2Tg 3evVNzyPrY6sg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B6B8CD13D3; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:25 +0200 Subject: [PATCH v4 5/8] iio: light: si1133: add missing include headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-5-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=1199; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=62tqivdanwU9bEEYOUM+cBHwVivEihI2W+qJmLI5wfU=; b=sfYT1TwUhCwjnHHGpn/6qT2nVJ+rQlJIsU2HqlAf0ijPObiKk3/DqssZiKpW+d/UNrXGsMIf9 6MBKNaKCgDtCx2uJP2MMCAvc1LPHCtKh+Diui8q9udaIuQvOKkGCVDB X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Add missing include headers to prevent compilation relying on transient dependencies (array_size.h, bitops.h, completion.h, dev_printk.h, err.h, irqreturn.h, jiffies.h, math.h, mutex.h, types.h). Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 9abc0a7e2ecf0d2fb1bd3af88eb675e9f1be4665..ab66a5a9ffb4a89bbba7474b6e9= 84ddb61cfeebe 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -6,11 +6,21 @@ * Copyright 2018 Maxime Roussin-Belanger */ =20 +#include +#include +#include #include +#include +#include #include #include +#include +#include +#include #include +#include #include +#include =20 #include #include --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 124242D3733; Thu, 30 Apr 2026 15:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=eYPHfCIVxo2tNOu/CVsobMh2FJL5KvltpYENu/BEtm9NTR/UR4TOjafIisFNo/vuVuD5UbT62xHRWyFY14MVhBKF/BsSIxQW6ItVmb+vjRZ9wo2m7XQu3VqA6jSDuCUOQMQwe27MDwuyhjWzJSytam/M6zLHh0Y2hXgLD/aQXPU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=CBh93jUwqVx1FmHtn3QU1AlavWYn0QlB7aV3IfarJZ4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pwdIIIbHrj1m/DxfNcw+l2Yks4u771+7V5R5wusczkFqLSEy1W2lhcQFolEwD8IUVuB7PnkCCLQQZa5lzzpv4+Yjs/SCk9uu7A5PpAAOHis1Gov7iJA8LdFFpLkZzQb2evS8QCqCCVWe97nDzqFg7+EJxncGEkD0eB65LRtS9sM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HPtdk5zs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HPtdk5zs" Received: by smtp.kernel.org (Postfix) with ESMTPS id B618AC2BCF5; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=CBh93jUwqVx1FmHtn3QU1AlavWYn0QlB7aV3IfarJZ4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=HPtdk5zsgUBzQeZqXAvX0Nfto0oKVO6aC6j6kvErJ83z77Ioay5LvB/yqN8iKbjeX VWdgUzfQ83+99Mc6qOrbSn8G5aCaE/ofPju/nbiydHiNVU16Kb7SWTC6hfHJQrdCr7 /oON0IQKZ2gUtPXulh57LrVxNYD8OtVAVgsnsEPzffM1EL9NqlO4uQWh4TyQ24lJQZ p/NlNZbYn8snNY9eUCT31J0CKFMaSGbVweqnMx8bfnpCPk2JH8fgUmOawhEuY6VsGV GSqjNo2Vt38D+ZNcPsTaxuEp/cqpxLFUIGdzHLK0Nc+1hjk/p0/KG8nSNZgfatwcQE +PlSBwhvyT/1g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADCA5CD13DA; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:26 +0200 Subject: [PATCH v4 6/8] iio: light: si1133: group generic headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-6-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=901; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=ONajTyOwYWFLpIXERWtWPSYo2OZuZwtQVCrvlP4IvVA=; b=zFQ9q4yHzYzchaZOHJ0HpqICQ+p88AI00TjJdoTLw5icaEP6DfGiKfK1hsrfjbDjdi6MGht+C mq1U5aXqqi/Bm0uAKHMXplGuaj7r1J60acP1QUw4qmX2izffuaf0pMm X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Group generic include headers to improve code style. No functional change. Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index ab66a5a9ffb4a89bbba7474b6e984ddb61cfeebe..fdffdee16e493277d95c369ec2f= 6c0678cf9f61c 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -21,14 +21,12 @@ #include #include #include +#include +#include =20 #include #include =20 -#include - -#include - #define SI1133_REG_PART_ID 0x00 #define SI1133_REG_REV_ID 0x01 #define SI1133_REG_MFR_ID 0x02 --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D5222D7DC8; Thu, 30 Apr 2026 15:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=KXJ2QqFcrcur8Cg+SQUVjLgXKfGpNhba0rG0U/HTh3MVMnDdwNJzICLaTF2CehT8/Jb2fzQG1FQoqiCoBPYi5csNrh2k4+xnxlE5wGso51GLLqTwGy2Mci1uda1Sd8sTRtsSC7uNsH2l8gO2svYOVgQMXr1hMS5a635K9DHHvyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=pmpyJeIflePapL/RApE/hkgCQoa1DmdL+rEhiYpEbeg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UrXFo1ZtLh4inOU5QQ0LlxNPMrlKr5KBx39/MeJdkDPk/A8TB7hKW67Jeq2omdu1YQD5b2dsKA2T9IQp3Hbc/hm1Im4iiEZhQikLxlABL3n+8HxkDfFntan+uJ1IF2XDj2Swc3i9UgNuA5EE/jBzyQXAvk0b2CBPE3mz4uFqK9M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iaAVMUkf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iaAVMUkf" Received: by smtp.kernel.org (Postfix) with ESMTPS id C5079C2BCC6; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=pmpyJeIflePapL/RApE/hkgCQoa1DmdL+rEhiYpEbeg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=iaAVMUkfdpt+j5fnTmC3y6JHlPYMS753eHIahlAp3P75XbwgURDROB5UC22KQpuZ6 2qngCNfq7O6sy/cKs3GHTFcYBWwxFEss7q3SW67DP9bs6A+OXI1PAyYCE6pxwiTzmc 7G0Qr/8ra03xi7/34VXn92owxsMq1m6BckRH9dPi/ZTBTLHOGGKrhYyf+U2vtiPhir z7+XKuUgVfeuiQFN03HSe7m3x62mPnu+Hx8XP5UHW6ZkJsS0Ht+oA0R5p+UIS8kepj hNGhHAbO6lb7Lv+5ad/of6lt8P2kAPlAEmTKQbY5pVPxYQ72UWfvb9WJn6rFXdLBvC q/C0JLGJQ75qg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF685FF8873; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:27 +0200 Subject: [PATCH v4 7/8] iio: light: si1133: add local variable for timeout Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-7-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=1250; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=/XJFGcdvil+2we7+TC+ip157GN0rAXA5yY6shTe6uEY=; b=qc7vESqAYJ7OClprO/OxaEbdS0t5aHvvJREc+18PKy6wypT0amXWx4S6T1d/jSO1UG7RzBItS In9YBRYYvUwBnP8kJ49618ejEuu+3fTaCgB/xu7FkF8vZpyDpjdF4AS X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Add local variable for timeout to improve readability. No functional change. Suggested-by: Jonathan Cameron Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index fdffdee16e493277d95c369ec2f6c0678cf9f61c..a3e4ab25acdc105d3800994f439= 1a7e4291e1c74 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -390,6 +390,7 @@ static int si1133_cmd_reset_counter(struct si1133_data = *data) =20 static int si1133_command(struct si1133_data *data, u8 cmd) { + unsigned long timeout =3D msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS); struct device *dev =3D &data->client->dev; u32 resp; int err; @@ -417,8 +418,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) =20 if (cmd =3D=3D SI1133_CMD_FORCE) { /* wait for irq */ - if (!wait_for_completion_timeout(&data->completion, - msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) { + if (!wait_for_completion_timeout(&data->completion, timeout)) { regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, 0); err =3D -ETIMEDOUT; goto out; --=20 2.47.3 From nobody Tue Jun 16 17:01:46 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CDDF2D7D2E; Thu, 30 Apr 2026 15:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; cv=none; b=RGMqms6LiCgIrf9OOJ1VGD3C6AmbYZ0hwHuvPr0OKO+JRl0jrzaB/J676BdC75cjHhe1X5qgZomoA+BKMgePzMYJXDSB4x0TZ/6Rtkr629ghxtzPoaBZdR5k420K95e1a7Jv5G/oSKBYTS5jXpsZhqZvPNfxjrFHyk9dDglOvq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777561517; c=relaxed/simple; bh=v2fcODw29MsB1Lp4repod1a+CCrIfcImlu/1vQqn97w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h9Lzds+mWJD67fuHhyj1P551g83I5o/x8HJZut9oBN3kdxrBaG7fIADxlsDDCgzs+6FLcoTK9rhvlnPGF6Ti/uaHV3t36adG2hxDUmtn4wEqmA9/e52zacz3IZJsJlRU6n8WNMN4ne++Vg0n8iIf9y77x+g8Jmt/FrXLGiBJ5S8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MbjTlXw6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MbjTlXw6" Received: by smtp.kernel.org (Postfix) with ESMTPS id D66E2C2BCFA; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777561516; bh=v2fcODw29MsB1Lp4repod1a+CCrIfcImlu/1vQqn97w=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=MbjTlXw6lOFOJqtlmWjT808VEnEnbfRzbq4K39JKZbSoB98v80r4UCWIZ+Eq/vDSx CgWr4TiHpi7aCNz0bFq+NH4ULHUjU2jKMs7HipRRKEIWYZoA4gzr8zhZfvJZryKqLt 89ASzXCuC1GMOZrBsnn8TYJ/HYTpdVJ+I3+Y+IE0W2RZBzomIttnVjwFfmnciOVeoq o2XiNKFN1Ug/PH5d3hLecwM8rtEepOJoEhtaq52qsZD1TjTlSG8EAuFsqZj6/P6DyF lGyUnVXlP6NHjeVy4DwVfCz3V4eoMoQoSwQQd0fgAc5gJc4//s9eC2yol54jUJvCM9 e7NnxMnNuydQw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0496CD13DE; Thu, 30 Apr 2026 15:05:16 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Thu, 30 Apr 2026 17:04:28 +0200 Subject: [PATCH v4 8/8] iio: light: si1133: use guard(mutex)() macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-si1133-checkup-v4-8-fb3e9dce41bf@gmail.com> References: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> In-Reply-To: <20260430-si1133-checkup-v4-0-fb3e9dce41bf@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777561514; l=2067; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=hBsegK4uny44/3ElandWq2RObKs2rVS7S5iCG8OtnzI=; b=BhO2lyHy83TTyuEIn31CvhLukmjqDyGJ1qQZfhg46gSeO7xuZ5ZweiIpyTNtbJHrFN+uNAJsP gj6wHpBDhfdCZSPcIholerVQltO7Tx168IbLTI/MDmnGB3E0ujVjvwU X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Remove mutex_lock()/mutex_unlock() and goto instances and add guard(mutex)() macro to modernize driver and improve mutex handling. Signed-off-by: Joshua Crofts Reviewed-by: Andy Shevchenko --- drivers/iio/light/si1133.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index a3e4ab25acdc105d3800994f4391a7e4291e1c74..55660dccfc7956e77b1d8105b72= 61221176c1736 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -8,6 +8,7 @@ =20 #include #include +#include #include #include #include @@ -396,7 +397,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) int err; int expected_seq; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 expected_seq =3D (data->rsp_seq + 1) & SI1133_MAX_CMD_CTR; =20 @@ -413,19 +414,18 @@ static int si1133_command(struct si1133_data *data, u= 8 cmd) if (err) { dev_warn(dev, "Failed to write command 0x%02x, ret=3D%d\n", cmd, err); - goto out; + return err; } =20 if (cmd =3D=3D SI1133_CMD_FORCE) { /* wait for irq */ if (!wait_for_completion_timeout(&data->completion, timeout)) { regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, 0); - err =3D -ETIMEDOUT; - goto out; + return -ETIMEDOUT; } err =3D regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp); if (err) - goto out; + return err; } else { err =3D regmap_read_poll_timeout(data->regmap, SI1133_REG_RESPONSE0, resp, @@ -443,7 +443,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) * counters being out of sync. */ si1133_cmd_reset_counter(data); - goto out; + return err; } } =20 @@ -454,9 +454,6 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) data->rsp_seq =3D expected_seq; } =20 -out: - mutex_unlock(&data->mutex); - return err; } =20 --=20 2.47.3