From nobody Tue Jun 16 16:00:39 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 013C62C3259 for ; Thu, 30 Apr 2026 11:53:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777550015; cv=none; b=mRV3LWYv616cg8//dbEmlMou3Frf4HCeLT8Bm0Ye8LpBVtXqD9+/comcyuDWvOuLSAe5CPxHiOntGI0ELBhSLxiMu1ZHcz9C0RwNrP9l91z/KhuR6W+LbHqNkCkttjOHiT+fBS7QfgvzRKcJMFRjhfjZW+2ZHyhdUXUWq5+re2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777550015; c=relaxed/simple; bh=f8+OQO/DhVnwaHYN8tReceYFnWeQTCE+B4hgCfi/GOU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=XNyoHbRNqk4/SnbdMtMcdX2qVwoLZXN+zALRUb45qX8CxnyjGDLLWFujyMtDOMcgFvsbX2QL6Hh2UTft0U3BQniOfBpoNJCgIsWuMuijG/WL4PqKtBdMV11J3rA1OdTi7so+Jf7f/qUSBOE9H+CXtJea9UUgtzFpDG+RkHv4LZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ij0fc6ZH; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ij0fc6ZH" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso5912035e9.0 for ; Thu, 30 Apr 2026 04:53:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777550010; x=1778154810; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=HmgXHjLeIkbk+Rv0NJChDX5ZVnbAwfmHTE3lyoBocNY=; b=ij0fc6ZHYcAICy5HRaSwNqbImSM4GpCfJlnKR34xk8OA3kI/1LINViqDo7FfQ07pAt SVaOO8nbQIkHeDe/F9X4XYabeFsHl2aCWvgTSaUTD/EwKQbSoO0+LyGmHIQIzSt1O9y5 SeCd8ZTmaY79tbZDXvaHaN+7xy0AooHI4vG379BeMvrkoRGg/dYrSAEydqS6RPKCxds3 izq/8UgsaEiGZfuTuzU9d5bHZKA3Z/8D8CXNeqtbMu8JzZgSP0PhdoMd7jbN8tQqMeEj xV45N3p9SBgoXJqyQbqDLBOApCr8h1ZqN9LjiPObP7HRpMSQlFA4tUYia88ocWXk8B3i T2SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777550010; x=1778154810; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HmgXHjLeIkbk+Rv0NJChDX5ZVnbAwfmHTE3lyoBocNY=; b=jw1HLLmgMAKnZWfy5xrJvsXxdrIo5MZ/kzTGot4cvyINddMlFKwbofsb73aeLULRyA bhEmveFDx5N3bcFC4CEgjxrWnILqmbgNd+nVWfjeZfIILN+0Shj5w4eqIwjExZm4Wsrt CNIpvmX0mY4VcINfSsd2ukBIVeAzTuFDnzoYfFadjSieHPit4GspVeQY4SiD2iMT1aC6 VHEXKqc0QRJOW08nEkOg+lD6Zg9IuzTbq1Cs80NgcRl/J4hYgCRjC7euYDucoKtdGd4e 35GH+uVZizicitZe840lKvKYdIBORDcxkXeVFc0YnasBR0FM1zR+mnVECPDQaoYhUGx2 Q2Zg== X-Forwarded-Encrypted: i=1; AFNElJ99iu4ear5R4xjCRpcxhDyrtpyWCpFIOYnFdFn8Y4UtEQ0X3n1VmXgGgpRl44WM+4MwovrD6jIitPQ6UxM=@vger.kernel.org X-Gm-Message-State: AOJu0YwehDSuLwdCZOA8Ez5Ukw7xmp9mEBQAOHuQ3QaOWWWhDMVE8V++ r+DDmW9OmyERoTxGQ5lhMoKah2BR3EtaXSWVbcP2ANIch+AvaWRb4y49MXybY4Oxsyg= X-Gm-Gg: AeBDievmAYtpI5pCGRb9yf45s6b+BPZApc0h8Npm1EcNPszGsBp34ZtR+CTHXAF8pDC zGk9vFEb3jZZHGKtw2FRhrEj23DHiK0m8tlex4zWt823N4RPcI9ReTGwUZRy5dAs73Akylr+Mp/ l8PCE4v9DCofaAiN4PTCbRBfmCop6r4s6qthJL2qPTcg6TvqFadxrkaTTRnQP93aUBhFPmo7hMN V1hv/I1jsJINrl0HHQbVMQgVF9eOG6ApPHmMUmJ8rHyCwGuMcWBChMY8OzTFxRknQ/6CErHBOqR NHk/StlsYOOuZmhaBmJ70oQsaa8757zJbrZIe9K5ucNf3QtKafmUuxBbHT5G9hchw0YjdSe6vKz lBfKmE7yWih/lUnyaFgb77tcAPNXK37S6NBqjF0bdJmlSFq4yQitw7rfMs+wP7l8Kig4V//tuYn gTHv9kggFxc3bGY5JyiFphMqr+ZGWh0KZFdTYNP8z27ORiJfrJ9ZLp19YIcFJLwBHPxWdgmESsy qrCDeuoJeETkYb/oAApSxlTSa8Olic= X-Received: by 2002:a05:600c:c117:b0:48a:6798:52e9 with SMTP id 5b1f17b1804b1-48a844a1528mr30995585e9.0.1777550009764; Thu, 30 Apr 2026 04:53:29 -0700 (PDT) Received: from ltux.linaro ([2a00:2381:fd67:101:9e61:b264:2b8d:1e57]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7c3058e5sm40886905e9.16.2026.04.30.04.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 04:53:29 -0700 (PDT) From: Alexey Klimov Date: Thu, 30 Apr 2026 12:53:27 +0100 Subject: [PATCH] clk: samsung: exynos850: mark APM I3C clocks as critical Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260430-exynos850-i3c-criticalclocks-v1-1-6e1fd8dfa21b@linaro.org> X-B4-Tracking: v=1; b=H4sIALZC82kC/x3MSwqDMBAA0KvIrB2In1TpVaSLZBztoCQlI8Uiu XuDy7d5FygnYYVndUHir6jEUNDUFdDbhZVR5mJoTfswfWeQz1+IOlqD0hFSkkPI7bRH2hRnct4 Po18a20MpPokXOe9+euX8BwC6cFluAAAA X-Change-ID: 20260430-exynos850-i3c-criticalclocks-dcabb78bf154 To: Sam Protsenko , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd Cc: Tudor Ambarus , Brian Masney , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 The Exynos850 APM co-processor relies on the I3C bus to communicate with the PMIC. Currently, there is no dedicated PMIC consumer driver managing these clocks, so the clock subsystem automatically gates them during the initialisation. Once gated, any subsequent ACPM communication with APM results in timeouts. As a temporary workaround (and let's hope it doesn't become permanent), mark both `gout_i3c_pclk` and `gout_i3c_sclk` as CLK_IS_CRITICAL ones to prevent the clock subsystem from disabling them. This makes the ACPM communication functional. This workaround should be reverted once a proper ACPM PMIC driver is implemented to manage these clocks. Cc: Sam Protsenko Cc: Tudor Ambarus Signed-off-by: Alexey Klimov Reviewed-by: Sam Protsenko Reviewed-by: Tudor Ambarus --- drivers/clk/samsung/clk-exynos850.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos850.c b/drivers/clk/samsung/clk-= exynos850.c index eb9c80b60225efa33d85f5f3c284eb8a63a48015..b143a42293f5a154f53a86d4e97= e17a3e61164f3 100644 --- a/drivers/clk/samsung/clk-exynos850.c +++ b/drivers/clk/samsung/clk-exynos850.c @@ -686,10 +686,11 @@ static const struct samsung_gate_clock apm_gate_clks[= ] __initconst =3D { CLK_CON_GAT_GOUT_APM_APBIF_RTC_PCLK, 21, 0, 0), GATE(CLK_GOUT_TOP_RTC_PCLK, "gout_top_rtc_pclk", "dout_apm_bus", CLK_CON_GAT_GOUT_APM_APBIF_TOP_RTC_PCLK, 21, 0, 0), + /* TODO: Should be dealt with or enabled in PMIC ACPM driver */ GATE(CLK_GOUT_I3C_PCLK, "gout_i3c_pclk", "dout_apm_bus", - CLK_CON_GAT_GOUT_APM_I3C_APM_PMIC_I_PCLK, 21, 0, 0), + CLK_CON_GAT_GOUT_APM_I3C_APM_PMIC_I_PCLK, 21, CLK_IS_CRITICAL, 0), GATE(CLK_GOUT_I3C_SCLK, "gout_i3c_sclk", "mout_apm_i3c", - CLK_CON_GAT_GOUT_APM_I3C_APM_PMIC_I_SCLK, 21, 0, 0), + CLK_CON_GAT_GOUT_APM_I3C_APM_PMIC_I_SCLK, 21, CLK_IS_CRITICAL, 0), GATE(CLK_GOUT_SPEEDY_PCLK, "gout_speedy_pclk", "dout_apm_bus", CLK_CON_GAT_GOUT_APM_SPEEDY_APM_PCLK, 21, 0, 0), /* TODO: Should be enabled in GPIO driver (or made CLK_IS_CRITICAL) */ --- base-commit: 0787c45ea08a13b5482e701fabc741877cf681f6 change-id: 20260430-exynos850-i3c-criticalclocks-dcabb78bf154 Best regards, --=20 Alexey Klimov