From nobody Tue Jun 16 18:00:13 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FCB13AE6FB for ; Wed, 29 Apr 2026 21:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497749; cv=none; b=pSeEq3yNSRWRbNwYhT5+SiR3Urp6tMwgKu2STuobPvcLYRMVAw98NQnGRen5lXTV5N34wj8ISEjJ/wbqzrhsdHiiOklet2Gc+GgmyfHLk5YsCbDjHTBCZU6wk9mxcwUCiwrtN7l2r1ukd0cHv2QYDgHB0W6zcwwPjLNbTsUY/Rw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497749; c=relaxed/simple; bh=zBgK5lAHHmNxsjZxkT8f6JwiAcb8h6UPnxmKjQ0s8rA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bD5BKaWwfwU5WoYHzhkkOpSKRVLYD4wqllivBQBhpYbrfNAf14nJcILJ6AId9wV/U04aA81fAaOPoWWL+8ydIc9ZbZtp9uNOWfU4Goqd7qdELrfbRhT86VV8Pg90tBGKBoleOqueJnlBLeOTKvlxuZ1SfVI74yT2d4tMaSu+Rv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FZtcKP18; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FZtcKP18" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488b8bc6bc9so1261295e9.3 for ; Wed, 29 Apr 2026 14:22:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777497747; x=1778102547; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pxqYhYsj7HU7oN1/TsDhDPzLzeP41V18doSZqNDu2iE=; b=FZtcKP18Fi0qhyPOJoyUblOMa/0lQHOMVwUc0GP15Wdc0WMXkKcrEomtdmjzqdiVQc 6XVKFTbO7XpRFn93CTQsES9bItrQ0Qb9NYIIEPgQt2U5Ox7fmU/MCQFck6BSLO2yQliv PEiwC831qRFuSWUE0ZCY5O/Ybi6VAs7XHpTFetONLwkK3EjR4FezA2TpiqDoggCB8vni +frNN4UnM/Y0984lNapm6A88olDdMMrfvamTOZdxOi5o0iZyoklWI/NbxdYCMDsyUOS5 np1WxYtjr9WcAVJ66hG/Kh2JL/vTi3F+737MSHHnFF/gG/MaU7Ro0jQh5zgw7+44RJ/y w46Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777497747; x=1778102547; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pxqYhYsj7HU7oN1/TsDhDPzLzeP41V18doSZqNDu2iE=; b=W3NRc3VsozU+5RXUS9iPHsAf6vNW4D7SzBxi/5crDfm2QTUoVz4qONA8VPMNlQuLJk RxhvuW1I/6FybM065EBPukqYGhawZkbxxmztIidLMmW/KBXkNEdF6QmD5Q/Yik7Ph4z4 UCzNOpSY7wFnoOXqervQAgmzVPtdRNdyfoDPTXy17OdPmsX1aGt8d/E5eTCLELodGkhh 1iYn2jj+4F5cUGbhC39rhDIv2UisQs6Dh5U095Ul66wUBNtqHyncPAEBudOR07Mrfl2n on3yDL6nrFbHRDxLu7KfOeWLxDP6Rgy6wdbKg4geJ2eJUPncpzD6cUSNB0NxziBHbD+a 04cw== X-Forwarded-Encrypted: i=1; AFNElJ+aqekAS5lRPNkICdr/UnIgUze1OfoksTyz7yD6GReEdTCL+8Qxdw+k6PeKrXy7ZxEenjTl6dlUkIdNeAE=@vger.kernel.org X-Gm-Message-State: AOJu0YwozZ9b3hmqRWd5S3PkWn4thjZWHr9ujF1hvRWnyd9P10bwduQu VMIvn2TXVQgQf7DYzVqpCi0yaRyZEeeoWlWGeIPT/tybe/otJF9IiqQ7 X-Gm-Gg: AeBDieuDfymFRH3eTCl92gC1Odd/JR8LQNX/r3DioPisGopbEZHEUdnfOtudaARqzbk QvG6ir6OmUXedBccngt/1ZCTZ1od6M+MYhqhZ57CxNCUdmGjTt4Q4sWZwdEcsDPzH6JBihS7DEn BePYQn/W4E2ZKnPgDOHCtSRlfrX44wpK/jb2Q5eWj3HGyAY1fLcqdvAXURD3PQ8fqUWrSD9CBZ3 qadvJPe2G+v6eOfPRtg5pCxuOMP/EcnjCYCFSY01kmn5VVHXMXADSX76Q2aIQ/GMf8adhxGO/0r rFz+9nWwWN2BALBRgn4xNWDLxxnsyIzGnX72GM5QkIuTXhYszZaR+rzCA1rkdF9/QgHVgKJAoik gOWVl4bHtJD+rENO8vfBHb40sc9oV00jF2Q8eEBiJRJpBUiHxYYzn6dZYJEHf7e2FPEXqLn/0jb 17sy6DinQcDr/vn8J8UrCk4qe/0trssOM7+RTqpiU= X-Received: by 2002:a05:600c:1f8e:b0:488:a824:fe04 with SMTP id 5b1f17b1804b1-48a8447f466mr3197815e9.26.1777497746519; Wed, 29 Apr 2026 14:22:26 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:8fc7:44bf:8aca:ebae]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a822d4b57sm45356905e9.15.2026.04.29.14.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 14:22:26 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi , stable@vger.kernel.org Subject: [PATCH v11 1/4] liveupdate: reject LIVEUPDATE_IOCTL_CREATE_SESSION with invalid name length Date: Wed, 29 Apr 2026 22:21:14 +0100 Message-ID: <20260429212221.814107-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260429212221.814107-1-luca.boccassi@gmail.com> References: <20260429212221.814107-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luca Boccassi A session name must not be an empty string, and must not exceed the maximum size define in the uapi header, including null termination. Fixes: 0153094d03df ("liveupdate: luo_session: add sessions support") Cc: stable@vger.kernel.org Signed-off-by: Luca Boccassi Reviewed-by: Pasha Tatashin Reviewed-by: Pratyush Yadav --- kernel/liveupdate/luo_session.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_sessio= n.c index a3327a28fc1f..24b4f381d3c8 100644 --- a/kernel/liveupdate/luo_session.c +++ b/kernel/liveupdate/luo_session.c @@ -382,9 +382,13 @@ static int luo_session_getfile(struct luo_session *ses= sion, struct file **filep) =20 int luo_session_create(const char *name, struct file **filep) { + size_t len =3D strnlen(name, LIVEUPDATE_SESSION_NAME_LENGTH); struct luo_session *session; int err; =20 + if (len =3D=3D 0 || len > LIVEUPDATE_SESSION_NAME_LENGTH - 1) + return -EINVAL; + session =3D luo_session_alloc(name); if (IS_ERR(session)) return PTR_ERR(session); --=20 2.47.3 From nobody Tue Jun 16 18:00:13 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8AD93B38A1 for ; Wed, 29 Apr 2026 21:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497752; cv=none; b=YlZaId5F9SdumGnUU07nxxf5qRvDV1Sl8XP5G+aGY8E6tkn0xZtqPczETs9tWdvCOUM/tRO6R9yj+/RhlkeYFBECHBzHvyYKMVZXiW6eEcQywBsaJN9vC25JK75+tZRQsstEVClvTO2t6WfL6Vuldz7x4ybJv0icOSvai5OO5u0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497752; c=relaxed/simple; bh=MVF/NUnwt4T8A9Ip9OQGyCJsA+8dvd+yvSjTW5P6IKw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=awhFs8RC7G60TnkUKEgFrSfxtWnn+zI/mtAkXzEEd0cQxOup7bwlkkVNNBUzOwfl9hDP9izCDdrl/ew29ONdYumu1FI9QU+cZGT7QNJqDGUc7PYYtwJRAaNKsXcxak810F7sdC+R+2+XgC6ZzBiTg5C/V5nfxyen4Txv0JKbBGo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UIFWi2ab; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UIFWi2ab" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso2597185e9.3 for ; Wed, 29 Apr 2026 14:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777497749; x=1778102549; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ykJFzTkCkC0C2lj+ZZ4uY5vhivTKu7ETItTHYfKS1Gw=; b=UIFWi2ab7YFhQ2LV+a156gUoBxfpDHXG7ZOYnc09jLifryHqjSZOaxgLbBioeDQl2e OR4YaoEE14sx6InmcPwiK1/MPuX6rBEgyj7kYqbYWh779kRx56eXfLgydHG+G/WgEqlp V4MK6Klj9UZyDfcPicwZmLM0lrQqaCs6X+dtQriNh/7c/MUvWsQuUu/fioopNiQ2WkqL 789zFK6kgPPzJkKFKMz8UfKO1Xe4VIpvEe20LzP4af08MjqciXZKF4jo8xM6ICm+HsY8 JhXCGGiAkzMlNhLlk+ThUwOKieO+eXMyq/c17oo6cjeXBMuktJQhDB0lZuD9y2dvuRRb 2HUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777497749; x=1778102549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ykJFzTkCkC0C2lj+ZZ4uY5vhivTKu7ETItTHYfKS1Gw=; b=RgbM6gmjd3Lf0C1L1bbThLrKU9mXErq816IxKfq3tiXhfe+HEiqMDmMoAFFqzRcGGi JvDsD+G91HgvQvzoFDjl6MMZsAAjPqlsxm14QB7rsHkLgPuTWoJOUMshHIvCbsESWOCz ZEgNXXx+TvN4XmRIkU2OO0Gk4QuYQ2DrBXuXFhDa6i7iMJnAGycLzyw6mY0W/XP7T4Q6 82pXkHdCrvvNqhwEMa1t8Zn4ShFmtTAerk21d35yQi/RDpacYvM4lJ77H8rWhJT9GB9I IbNeJN6iBTx+e/tkEmC2plQWtvy+l0eYStWWBshvIaqpGfMlsYfqIM1e0BD624SWIijI 9KqA== X-Forwarded-Encrypted: i=1; AFNElJ+LeMojoSfYSeV8w6GCSzsDwU56O9JQpmrZt0u3kgKEPsF+EI0JOOF0RIe11mQzAFlrxFqf6kJFSLN6bEc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb7Z0svWNeWwzXtAM4ZdFmsFZ29QgZhOcm8p+ny+3981Ns4165 F94xsQ8Bw+LoYzCibqtaZL3F4Dpgco89NSIyeY477OpBe+0Jc/fzbOUs X-Gm-Gg: AeBDieuuGrwLMCmERLyvlNCDBi9gqX/w82d7ZufVyUtmGiGPgUVjkgmO5FGXvz83HOc 9waMiolQ4/yjPQ9UuBYl4zWkA4PBtmVjof1GBtWlg2pROUo7UqRIz1M6fBFeblXWYtbChgCL36G c80TIbgY9+HSJ0qfm1NQL49MsgvBcND6F59MoYrDYzoqpA9KOJdm0+eEFq6GOkwN1oa45F6CyTI g41lqsp//umvIlwgfAkhlkCzafRKu5ow5Xhtvi8zZ2xTxLaZCxJsKMVwl3yexN4lux7J7pyebTS uR1Lwi3+mR06IF7RLDqcpHwa+5hmHclo2C4DfKbIkfnlhJnnN4g3MaZ2zGLPoqgkiolCNydj07H CHjruCD89A0VgD6J4QcBtXHDaVYcxKYtMkk2ixDIlEopBkEh67fVUcxRNLvKqNWTyuKmTuPs1EJ q26o5RMj/eZY0WUNBy52+ckNblVWZlziTfX6JkUuU= X-Received: by 2002:a05:600c:8b22:b0:485:3a03:ceca with SMTP id 5b1f17b1804b1-48a844582c3mr4663845e9.23.1777497749079; Wed, 29 Apr 2026 14:22:29 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:8fc7:44bf:8aca:ebae]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a7c3057f8sm26200425e9.14.2026.04.29.14.22.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 14:22:27 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi , stable@vger.kernel.org Subject: [PATCH v11 2/4] selftests/liveupdate: add test cases for LIVEUPDATE_IOCTL_CREATE_SESSION calls with invalid length Date: Wed, 29 Apr 2026 22:21:15 +0100 Message-ID: <20260429212221.814107-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260429212221.814107-1-luca.boccassi@gmail.com> References: <20260429212221.814107-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luca Boccassi Verify that LIVEUPDATE_IOCTL_CREATE_SESSION ioctl which provide a name that is an empty string or too long are not allowed. Cc: stable@vger.kernel.org Signed-off-by: Luca Boccassi Reviewed-by: Pasha Tatashin Reviewed-by: Pratyush Yadav --- .../testing/selftests/liveupdate/liveupdate.c | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testin= g/selftests/liveupdate/liveupdate.c index 37c808fbe1e9..90268d86684f 100644 --- a/tools/testing/selftests/liveupdate/liveupdate.c +++ b/tools/testing/selftests/liveupdate/liveupdate.c @@ -386,4 +386,46 @@ TEST_F(liveupdate_device, prevent_double_preservation) ASSERT_EQ(close(session_fd2), 0); } =20 +/* + * Test Case: Create Session with No Null Termination + * + * Verifies that filling the entire 64-byte name field with non-null chara= cters + * (no '\0' terminator) is rejected by the kernel with EINVAL. + */ +TEST_F(liveupdate_device, create_session_no_null_termination) +{ + struct liveupdate_ioctl_create_session args =3D {}; + + self->fd1 =3D open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno =3D=3D ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + /* Fill entire name field with 'X', no null terminator */ + args.size =3D sizeof(args); + memset(args.name, 'X', sizeof(args.name)); + + EXPECT_LT(ioctl(self->fd1, LIVEUPDATE_IOCTL_CREATE_SESSION, &args), 0); + EXPECT_EQ(errno, EINVAL); +} + +/* + * Test Case: Create Session with Empty Name + * + * Verifies that creating a session with an empty string name fails + * with EINVAL. + */ +TEST_F(liveupdate_device, create_session_empty_name) +{ + int session_fd; + + self->fd1 =3D open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno =3D=3D ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd =3D create_session(self->fd1, ""); + EXPECT_EQ(session_fd, -EINVAL); +} + TEST_HARNESS_MAIN --=20 2.47.3 From nobody Tue Jun 16 18:00:13 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0764A3B47D2 for ; Wed, 29 Apr 2026 21:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497753; cv=none; b=BMS2P6LKFTB+3aikbEz8gnz+9JSHljkYwfLshFcORmgiAqgCNLlW4TkeZvKNfeiSicNMODXBeCz0wN+obie3fkSGrG86ocIQBMa9wBW+uQ/g83oLkx7036iTvzyqY3WOm0TPhaaoLZLp3f/t8ZIEmmaSYKZVA+FLNhwI9i8wCMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497753; c=relaxed/simple; bh=Rf4dN8sazCWYOCcQUVj2ZL8YR18IuaGIuAR2l/M81co=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=brzqnHQFUqJZ0w34T30+SDgzAUtTo0AU8ubqzm50vieOkZi8hC9l5Jpa1EOPZldWm8I68qM2LpUPH5TIa04TcDwRXmT6d7zSzFH/K+D1n9E2zbeND9n309WdgPelCWAhkz2k5lSrWzZZxsOZGroDqKDFCz9y2eIr4+YBy1dooGU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Auq0N8AS; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Auq0N8AS" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-48896199cbaso1836955e9.1 for ; Wed, 29 Apr 2026 14:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777497750; x=1778102550; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xc2oiP7pp0P8+LSVJw9z98TCpWpEve1jI7g9J2HlvNI=; b=Auq0N8ASOm0fZemlwgbD16aPu5ysR8zn9uHiz8Ba1qJa1ifVlhAFpPKxQWStC2QBCC vSu0R5BlfK3qHaNxnWpmkSqe6a8w4NtGe+7LmAWA+7CpLtuNW2kJocBC4YhpDW7A/3Qa 7VK6/A1W5rI17kG+RCMO+TJLo8NP2S6X7cyLMxHL/RQNfmv5qSchuPGCxARHqJYCCGso uUFUM4abeplEQyO+yc4c/eI2r5PNcU3Q0yAAP5td+wZhwH4jupKfL54/y1k9toE16rfU 7Jy1WgmQ/yudpRSQitkYoeqgnPUAJYz8M9ijy/15QypjNN2rNUJDZd2jeToXEtn4wXEf twyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777497750; x=1778102550; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Xc2oiP7pp0P8+LSVJw9z98TCpWpEve1jI7g9J2HlvNI=; b=CjB5SKxP04xI9WH9LHdKEJ5OgixDl5ZgFSAVsTYckC4GS+QhSeCYKR/3p5IEZc0rb2 PIJGqnLTi0/1+mAg/Xs6EI1leJynWHMUQOLUTOL1FTf/FGghmMRy4vRiXK8uQNO+z47b sVlrz4FZwyUMj0W7s2s7MiTAK9SDmN5+EEc2eMZXsg4zW6BzAko7zjwCUSH1PByNSyTf vYi7dyapetx0b8BV1CVb3k1iEIOYuaQLbExhtwqDxxK9X6gWQy9e40RA0p7woxNge+wC F9jelITWmcTuEwogu8VkwPkU3TErTC57EOEvaku2huu02rBuPCneaJAaF1GDnV4S4HxH ODzQ== X-Forwarded-Encrypted: i=1; AFNElJ/IgFPS6Ugt7V/QJZzU3svsuZ5IVhuyOLBds9Bu4R8sPuckZUJ9esqisbyUHijycI3YYqsxRahhSihnY38=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg5Lrl7iMk+i4B9v5njdhHxLd4XPYWgm0ZfYwjOO23AHIz82Q6 MhrNA8Hru+5TZUJ43D4zORjwHKPZ2PlXQJ8CvICYkidXQui7XKPJnihX X-Gm-Gg: AeBDieuNMw4u1wLNjg40w6auMEQse+EPupYEQ+yvZxbYwsXCvoPYxX/Pm7xcLHn1A4p XhHTckuFckwLMw9yBJ+fejkY5PbE//RKpsTvB/a0gawUo3qWymsNfx4n6+QN3JvijMKP3afGlpb FU83lkcHzlRfw1lJPjC95ovH9WetYr9zBapzLZC/OVOFZPDHYPhG4V65M8OFV/RMgHyBdaBSdcr boi/34lBOHEg2AgEA/NSLPZOpujXMNQJbjjkW1tBlCjz5lT7vMYREtuKMnJJLCAHXF20pHZiinI T7UZBjRE7J6fYzVUfov9SvlYZ0NP7dvI/7sttS8tpqIh09KYnW1xp8HgYk8WVhgte/vVUGT/i14 +GyaOgQRs2zlmI0ClOMYkTvjuzZ4EomSaChFdIpI1Q5derJQqvI9I78iydjMA097tMZAF9fnX27 6Yy28baTjJpKd3DmpV7I090W0D12G6bW9H6ObmFkM= X-Received: by 2002:a05:600c:19c9:b0:48a:7a10:4f17 with SMTP id 5b1f17b1804b1-48a83d66b9emr4530045e9.6.1777497750288; Wed, 29 Apr 2026 14:22:30 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:8fc7:44bf:8aca:ebae]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48a822d4b57sm45365325e9.15.2026.04.29.14.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 14:22:29 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi Subject: [PATCH v11 3/4] liveupdate: add LIVEUPDATE_SESSION_GET_NAME ioctl Date: Wed, 29 Apr 2026 22:21:16 +0100 Message-ID: <20260429212221.814107-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260429212221.814107-1-luca.boccassi@gmail.com> References: <20260429212221.814107-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luca Boccassi Userspace when requesting a session via the ioctl specifies a name and gets a FD, but then there is no ioctl to go back the other way and get the name given a LUO session FD. This is problematic especially when there is a userspace orchestrator that wants to check what FDs it is handling for clients without having to do manual string scraping of procfs, or without procfs at all. Add a ioctl to simply get the name from an FD. Signed-off-by: Luca Boccassi Reviewed-by: Pasha Tatashin Reviewed-by: Pratyush Yadav --- include/uapi/linux/liveupdate.h | 21 +++++++++++++++++++++ kernel/liveupdate/luo_session.c | 16 ++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdat= e.h index 30bc66ee9436..3a9ff53b02e0 100644 --- a/include/uapi/linux/liveupdate.h +++ b/include/uapi/linux/liveupdate.h @@ -59,6 +59,7 @@ enum { LIVEUPDATE_CMD_SESSION_PRESERVE_FD =3D LIVEUPDATE_CMD_SESSION_BASE, LIVEUPDATE_CMD_SESSION_RETRIEVE_FD =3D 0x41, LIVEUPDATE_CMD_SESSION_FINISH =3D 0x42, + LIVEUPDATE_CMD_SESSION_GET_NAME =3D 0x43, }; =20 /** @@ -213,4 +214,24 @@ struct liveupdate_session_finish { #define LIVEUPDATE_SESSION_FINISH \ _IO(LIVEUPDATE_IOCTL_TYPE, LIVEUPDATE_CMD_SESSION_FINISH) =20 +/** + * struct liveupdate_session_get_name - ioctl(LIVEUPDATE_SESSION_GET_NAME) + * @size: Input; sizeof(struct liveupdate_session_get_name) + * @reserved: Input; Must be zero. Reserved for future use. + * @name: Output; A null-terminated string with the full session name. + * + * Retrieves the full name of the session associated with this file descri= ptor. + * This is useful because the kernel may truncate the name shown in /proc. + * + * Return: 0 on success, negative error code on failure. + */ +struct liveupdate_session_get_name { + __u32 size; + __u32 reserved; + __u8 name[LIVEUPDATE_SESSION_NAME_LENGTH]; +}; + +#define LIVEUPDATE_SESSION_GET_NAME \ + _IO(LIVEUPDATE_IOCTL_TYPE, LIVEUPDATE_CMD_SESSION_GET_NAME) + #endif /* _UAPI_LIVEUPDATE_H */ diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_sessio= n.c index 24b4f381d3c8..1caaa7886ec6 100644 --- a/kernel/liveupdate/luo_session.c +++ b/kernel/liveupdate/luo_session.c @@ -289,10 +289,24 @@ static int luo_session_finish(struct luo_session *ses= sion, return luo_ucmd_respond(ucmd, sizeof(*argp)); } =20 +static int luo_session_get_name(struct luo_session *session, + struct luo_ucmd *ucmd) +{ + struct liveupdate_session_get_name *argp =3D ucmd->cmd; + + if (argp->reserved !=3D 0) + return -EINVAL; + + strscpy((char *)argp->name, session->name, sizeof(argp->name)); + + return luo_ucmd_respond(ucmd, sizeof(*argp)); +} + union ucmd_buffer { struct liveupdate_session_finish finish; struct liveupdate_session_preserve_fd preserve; struct liveupdate_session_retrieve_fd retrieve; + struct liveupdate_session_get_name get_name; }; =20 struct luo_ioctl_op { @@ -319,6 +333,8 @@ static const struct luo_ioctl_op luo_session_ioctl_ops[= ] =3D { struct liveupdate_session_preserve_fd, token), IOCTL_OP(LIVEUPDATE_SESSION_RETRIEVE_FD, luo_session_retrieve_fd, struct liveupdate_session_retrieve_fd, token), + IOCTL_OP(LIVEUPDATE_SESSION_GET_NAME, luo_session_get_name, + struct liveupdate_session_get_name, name), }; =20 static long luo_session_ioctl(struct file *filep, unsigned int cmd, --=20 2.47.3 From nobody Tue Jun 16 18:00:13 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F7233B52E7 for ; Wed, 29 Apr 2026 21:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497754; cv=none; b=JgZRr99SF3aKQGc1+KfvCyE1XY3tTrAmGJI6Fr50FjbkP8Vn5yf0d0bmK+GB6TikE4thbrn2FKXUTcigGP30l/4t6rsSqih/gLZeCeGH45MDfBMBMZhATY6RbgAxRkJrdz30YiyWOYGSapPMOEXG9Gb55IXuO8wG7gnuMon5rLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777497754; c=relaxed/simple; bh=dYd3mv0qvySX88xTDgqPG/NBFnUP/+1fx3PqGdEuKIk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g+YeN9bahMekHiZBP84xnHcKjH0hWFVBk/cpS2NfB4TVp3ChB4C02LWr0Y5hrqTS9bEakS85sy0MIywCxpgEgWKPKj36s9n5j+tTG2lFmJ2rHA/C6nvRD3HSoTKdVAFs7LYwbyCJthmxJFodme6ZrJup/BY4bacttmgpkUOyxsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q9Bwig36; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q9Bwig36" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-44261378651so885641f8f.0 for ; Wed, 29 Apr 2026 14:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777497752; x=1778102552; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gtld5SUkIp01JJT6a8E7AwwCws3CqpUZMHCHkcwnTLU=; b=Q9Bwig36rYvbpjRusaGHP3yrOg05v8LQqc1Z6rfUu1l+QH9qVmq7tUBoEbPP0YClFe YJmBGaE+uBwCEYksW2nYkjZZOk2uE/f9d6+HdZUX37WdHBEyFssam85af8vrA0aqEc0P IWQegrQy3D3sS4171b9T2qTMBm3d9ThQokhZn00XzbMkL5BQlvBz2B0P/YS+rW48pn4P jQsCiSbYxIE0RlIbEaLDV13lE0SAL3kIngX3gTs1dpfAjjp4gd2L9inlvJ5/XlHWjHfg /q33dafJlNOzU9g0STLdUgcX/Et2dVeSr9UFF83kDTvyyD3x6c1Vv2WFvOa2VAOIAXKN fHQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777497752; x=1778102552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gtld5SUkIp01JJT6a8E7AwwCws3CqpUZMHCHkcwnTLU=; b=hp9b+xOEtFZnXN3lT016+CL56Zqr95asFJ9XsP/yHjm4dQ7mk2fmOPpeXdKRyPXaaN f44gjoEbCCP17K7Wv1LsuV46vSMP+i0x5V2DM9ikXgzW5aDNUJ/G3FMIhkioYqnQcEPV mbnXTd6ehvKbBXRydGxAkqFXu+jFz6Op+MaLIJrhtAR8D+mJxXvvP1TqyVoqJzoKlV0s oqmN0r08OAlinS7K5tXAJvcbXBO7pHPI7JOMnwkT1eKjLhGBtKbb1Yp0udHloi6qntMs mwQG7y9Oc/MDXBtpV9g7cNkkrkpd+WHqeZ27xVIx4vYiUq6zjXL/HxurYUNQo4a7tI/K 7cJg== X-Forwarded-Encrypted: i=1; AFNElJ/YHAjMn9PWzOIXdR9h/xua1gzWs6W3sbpSu70nSMXIOtVe3LODARFvMk910zxMAbQQNzAUMGyRQSui04o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+ruGbWKxBQ2Js5AXfrxp1pWk8tUF2p+sUhjrWBG3YIskfJjfL J2FS6NWVnZaEc8KdtWurxELaFUPKA9xj92ZbwPDcNT+1u2ePsVHPxgZ9 X-Gm-Gg: AeBDieuhCN06LunwRjFW0zf4hVm/pGelLzSDF0wST1CM7JFzvg4xyPJjpGVNn1gqQKs /uJsqL3ZUwYLd6mp7houpPQvzq9QFfSOue8z8fQ1AQtnEuOJlt22z9QPssfRWoxCqUlSXnYGX5H 3gKCiBx5/084CuUvpiZ8uBwfDkBppKv+FVtlkQKgeBKZrJKIWmYbbS03Gk9kqay2TCAZyTT9S3c OYCN65/KZ67JS0enPRK4qF0PpDDkqBYuYcZRH+OPhXrA/3Y9ljeP0b9RuPWGEnvOaHiT6nc3Cgh asaPIRJDTFD9LMk6gC80/nSnWmi0bfIjw/5/VxbgmSV0mhYyGTdMiVCFgydfs7kgogRSx/EYMDN gd46QMypQ9Kv6elmyeAdupmis/odXVIBvYPnaEDuNG2SMvAPzpYE6FkNEJbAkst9pLjoOwqBsQ4 eu4uPN1l+iM8kqm6XOIHr8abs0h6AxeW14F8ILuP0= X-Received: by 2002:a05:6000:2892:b0:43d:2d34:8963 with SMTP id ffacd0b85a97d-447aab56f7cmr8979841f8f.17.1777497751434; Wed, 29 Apr 2026 14:22:31 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:8fc7:44bf:8aca:ebae]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-447b76e5afesm7092080f8f.30.2026.04.29.14.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 14:22:30 -0700 (PDT) From: luca.boccassi@gmail.com To: kexec@lists.infradead.org Cc: linux-mm@kvack.org, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, linux-kernel@vger.kernel.org, Luca Boccassi Subject: [PATCH v11 4/4] selftests/liveupdate: add test cases for LIVEUPDATE_SESSION_GET_NAME Date: Wed, 29 Apr 2026 22:21:17 +0100 Message-ID: <20260429212221.814107-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260429212221.814107-1-luca.boccassi@gmail.com> References: <20260429212221.814107-1-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Luca Boccassi Verify that the new LIVEUPDATE_SESSION_GET_NAME ioctl works as expected via new test cases in the existing liveupdate selftest. Signed-off-by: Luca Boccassi Reviewed-by: Pasha Tatashin Reviewed-by: Pratyush Yadav --- .../testing/selftests/liveupdate/liveupdate.c | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testin= g/selftests/liveupdate/liveupdate.c index 90268d86684f..c7d94b9181e1 100644 --- a/tools/testing/selftests/liveupdate/liveupdate.c +++ b/tools/testing/selftests/liveupdate/liveupdate.c @@ -102,6 +102,22 @@ static int create_session(int lu_fd, const char *name) return args.fd; } =20 +/* Helper function to get a session name via ioctl. */ +static int get_session_name(int session_fd, char *name, size_t name_len) +{ + struct liveupdate_session_get_name args =3D {}; + + args.size =3D sizeof(args); + + if (ioctl(session_fd, LIVEUPDATE_SESSION_GET_NAME, &args)) + return -errno; + + strncpy(name, (char *)args.name, name_len - 1); + name[name_len - 1] =3D '\0'; + + return 0; +} + /* * Test Case: Create Duplicate Session * @@ -428,4 +444,59 @@ TEST_F(liveupdate_device, create_session_empty_name) EXPECT_EQ(session_fd, -EINVAL); } =20 +/* + * Test Case: Get Session Name + * + * Verifies that the full session name can be retrieved from a session file + * descriptor via ioctl. + */ +TEST_F(liveupdate_device, get_session_name) +{ + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] =3D {}; + const char *session_name =3D "get-name-test-session"; + int session_fd; + + self->fd1 =3D open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno =3D=3D ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd =3D create_session(self->fd1, session_name); + ASSERT_GE(session_fd, 0); + + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); + ASSERT_STREQ(name_buf, session_name); + + ASSERT_EQ(close(session_fd), 0); +} + +/* + * Test Case: Get Session Name at Maximum Length + * + * Verifies that a session name using the full LIVEUPDATE_SESSION_NAME_LEN= GTH + * (minus the null terminator) can be correctly retrieved. + */ +TEST_F(liveupdate_device, get_session_name_max_length) +{ + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] =3D {}; + char long_name[LIVEUPDATE_SESSION_NAME_LENGTH]; + int session_fd; + + memset(long_name, 'A', sizeof(long_name) - 1); + long_name[sizeof(long_name) - 1] =3D '\0'; + + self->fd1 =3D open(LIVEUPDATE_DEV, O_RDWR); + if (self->fd1 < 0 && errno =3D=3D ENOENT) + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); + ASSERT_GE(self->fd1, 0); + + session_fd =3D create_session(self->fd1, long_name); + ASSERT_GE(session_fd, 0); + + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); + ASSERT_STREQ(name_buf, long_name); + + ASSERT_EQ(close(session_fd), 0); +} + TEST_HARNESS_MAIN --=20 2.47.3