From nobody Tue Jun 16 17:59:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8E01332608 for ; Wed, 29 Apr 2026 20:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777493691; cv=none; b=Bl7zQ1quikbI8OlLOoL9lMikg9QTgnN46d/SFC1yTZ6zbQMpBKd+zmUsHu/asbwqt/h+bcWQyxdT4eRhQPWz4UNCtdZ6q/Z3if2laR1iJ9m3X511JADJ7aSVihg4tRg3SXgXleXDlDMQdzDuglT6TACaZkarFnAWE5uufYAiG5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777493691; c=relaxed/simple; bh=JcAbi55XZmwwzMWUCvzjcBCJ4uFIk2EewuWEV1pzCRU=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=J/kCq1uVTr+vGSWkZnFaEJ2zTaWu26Sr+BvMH5kik0tgo8EIpZX9thjulp8jozgvxmI1dyOwzbew+NpQdXif2SzbclfnLCDgrUFqk/ImZiodTHTMkVdP18G3UoBKP7buGfVnTM6iC9ZjRCemJkdUvBrCM17AYK/ITohBmHrAKvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=phEwiMFm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="phEwiMFm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2422C2BCC6; Wed, 29 Apr 2026 20:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777493691; bh=JcAbi55XZmwwzMWUCvzjcBCJ4uFIk2EewuWEV1pzCRU=; h=Date:From:To:Cc:Subject:References:From; b=phEwiMFmGLIxAYbyCuB7VbYCkcKXT3rJE+JxhrufKYWzt63B4Yqe/RTsbTkSMMbUm ay46ld2UlHIfv+2mwLksI/5sKt88zBAWR2+6G3v1JPZPGSSq6oFKlGoVdO9C/lR9BO RNbgj9WUY9vgr7IZcVKxs33BPhYZIhgyUypdS2W7ZAzMw7uJcu4T/Nq2IDFeCn/KwM s8Q2niAbAr1/7DfcQ6WX7FqPp9LgIQSxN4O1sFsHY/C3egpC5Kd3UgP8P+NmzZFs3p DjeDL/2z+zelRQa3gYqt3ZadVXTrvZLHM6u6InRjFm8GwcJNd3bAgHUfeKAXmelnEJ pwy23VL24vGuA== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1wIBJN-00000003m5J-1OwZ; Wed, 29 Apr 2026 16:15:09 -0400 Message-ID: <20260429201509.194600092@kernel.org> User-Agent: quilt/0.69 Date: Wed, 29 Apr 2026 16:14:54 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Ingo Molnar , Frederic Weisbecker , Breno Leitao Subject: [for-linus][PATCH 1/3] tracing: branch: Fix inverted check on stat tracer registration References: <20260429201453.449214720@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Breno Leitao init_annotated_branch_stats() and all_annotated_branch_stats() check the return value of register_stat_tracer() with "if (!ret)", but register_stat_tracer() returns 0 on success and a negative errno on failure. The inverted check causes the warning to be printed on every successful registration, e.g.: Warning: could not register annotated branches stats while leaving real failures silent. The initcall also returned a hard-coded 1 instead of the actual error. Invert the check and propagate ret so that the warning fires on real errors and the initcall reports the correct status. Cc: Mathieu Desnoyers Cc: Ingo Molnar Cc: Frederic Weisbecker Link: https://patch.msgid.link/20260420-tracing-v1-1-d8f4cd0d6af1@debian.org Fixes: 002bb86d8d42 ("tracing/ftrace: separate events tracing and stats tra= cing engine") Signed-off-by: Breno Leitao Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt --- kernel/trace/trace_branch.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/trace/trace_branch.c b/kernel/trace/trace_branch.c index 6809b370e991..d1564db95a8f 100644 --- a/kernel/trace/trace_branch.c +++ b/kernel/trace/trace_branch.c @@ -373,10 +373,10 @@ __init static int init_annotated_branch_stats(void) int ret; =20 ret =3D register_stat_tracer(&annotated_branch_stats); - if (!ret) { + if (ret) { printk(KERN_WARNING "Warning: could not register " "annotated branches stats\n"); - return 1; + return ret; } return 0; } @@ -438,10 +438,10 @@ __init static int all_annotated_branch_stats(void) int ret; =20 ret =3D register_stat_tracer(&all_branch_stats); - if (!ret) { + if (ret) { printk(KERN_WARNING "Warning: could not register " "all branches stats\n"); - return 1; + return ret; } return 0; } --=20 2.53.0 From nobody Tue Jun 16 17:59:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2134382F0C for ; Wed, 29 Apr 2026 20:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777493692; cv=none; b=KO4GVB3FmcnnpOd1Sl/BQJ2wNOe3B2Rd3vFJHAilUDKIdy+AYw6reAEsY5Xzq0/od32uH1dSaxi3xaT2ZL+nBG8gAWi7WuMWTQ5tmI5r9w9WjN8LqijtEBmpX+g75rwDeLi7FWgJY+b+gzBBtQ7JmxLR5ObicuTC9h34nbzbho8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777493692; c=relaxed/simple; bh=ektY9Uw9p4HMDd9WgVZzivhV/BjMmzJFAQjjKsi4a/g=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=rmSAbdrn/eZApEGqZjYMXTiEWN9wQYdKXtEHoEvgCPLMsKvTIAtKpW59A/XWXWhZGwFqdH/reJfb+3LL/neJLcKu0AWlHX+ckbU3jp/tmaCZICf8fd/jLq7nUgdrxFnZIs6ic9Hd+CZtASxE3B+aykoUi89/4a4wMa/V0VgCo2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NJRfkHCz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NJRfkHCz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAD48C2BCB4; Wed, 29 Apr 2026 20:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777493691; bh=ektY9Uw9p4HMDd9WgVZzivhV/BjMmzJFAQjjKsi4a/g=; h=Date:From:To:Cc:Subject:References:From; b=NJRfkHCzFUDPtB583QOCQYYCvnxZM3gYx6dPNB3YJjndAMkcB0WRwP1USaS7iJBxo DmW2Diq0+7CAGcJGwf5MOnxl/tAGpquLADUMzTTYfvStD/FJAS8BvWkpTNGSI570vD yVlyu0a56pdpBqa3felpJbR9VSUS5D0wvyF9eRE876351fQCLdSdJsWDkl440Ugmag 7qHpU6CTwsoCKsLOReLWhD7xsj7WKqCDoeKgmFtZsxOuOjMHRQh60a8IIZPsSbBjN8 2W/QphkB4NFa2TGn9ZkvAKos3WhGjWXrX36LtW0hTmYIjRUropEgQeP9ZC9lrUCHKn O//QQulhwd0vQ== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1wIBJN-00000003m5o-245r; Wed, 29 Apr 2026 16:15:09 -0400 Message-ID: <20260429201509.351525734@kernel.org> User-Agent: quilt/0.69 Date: Wed, 29 Apr 2026 16:14:55 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Sheng Che Peng Subject: [for-linus][PATCH 2/3] tracepoint: Fix typo in tracepoint.h comment References: <20260429201453.449214720@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sheng Che Peng Change "my" to "may" in the description of subsystem configurations. Link: https://patch.msgid.link/20260422021819.1788091-1-synte4028@gmail.com Signed-off-by: Sheng Che Peng Signed-off-by: Steven Rostedt --- include/linux/tracepoint.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 578e520b6ee6..763eea4d80d8 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -202,7 +202,7 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) #define TP_CONDITION(args...) args =20 /* - * Individual subsystem my have a separate configuration to + * Individual subsystem may have a separate configuration to * enable their tracepoints. By default, this file will create * the tracepoints if CONFIG_TRACEPOINTS is defined. If a subsystem * wants to be able to disable its tracepoints from being created --=20 2.53.0 From nobody Tue Jun 16 17:59:00 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F199B38837C; Wed, 29 Apr 2026 20:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777493692; cv=none; b=gBY3m48FA8xYvL/0qjUuvA4C2r5q6TL6Zw8PaDq9wOfYIp710LAn1FqQFY8IHZ2efMlln/kvZyO5ks+Gb50PHn7h3f1y1csnT2R8//BHq/tml3rvtbsmMs8uoY2DtLkhyiKgw2mCjcuN6xtF9uesRQu10PiD7vIyOlNv/qWRwS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777493692; c=relaxed/simple; bh=T0lhqDY2oFOIHQJjCyF6NbTeUGPfvrf6TV86DHkLx8w=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=X+08LmvBrAMH0L1kpPzXXmGlk9NHRn58ASb7nqBq0JIZYo1Uh79ebwvBE85h6pc1DtA55WsLuphznBbW336OQuMAsVPcLU+m+0AjF41sW5P0KGeYCCgfJGELsLuzA2TtqSYcT6PSMEhkq7NHZeVJGlMtPWUuLyoWH9gTVzzn2qI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QHjvP4AO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QHjvP4AO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3F36C2BCC7; Wed, 29 Apr 2026 20:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777493691; bh=T0lhqDY2oFOIHQJjCyF6NbTeUGPfvrf6TV86DHkLx8w=; h=Date:From:To:Cc:Subject:References:From; b=QHjvP4AOH4ini0PNhWx+AzvlcKer6GmdK2gf8GtUCXOWAP8S0ROO/8tJm+OmpIfUF Qh7zj4HBddw6DjzuZyYk5VfQMQ/KL1NMIyXMad4rJo1m0uc+gfvf/hzH/rShj0ZjJP gnwWATZuS7N5Wo+kD3rqly39rXBadjly+8Gtrx61QNNIwxq5JiFbNWFMk3O0qk29/2 IN/CRQeZ1dv4U4s9LLSul9dvxncMpbWlAuItp9+Nd7ejyVsDluE1Ww53REvH1pZcJm UCWfAfFRkbC3AyR8QPC5Hkvu5TMRvTu7b0jU8O/azvj0Dw+ohtucTf7FmRDSqiga1U R109KRMyeMMdw== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1wIBJN-00000003m6I-2kQN; Wed, 29 Apr 2026 16:15:09 -0400 Message-ID: <20260429201509.513685251@kernel.org> User-Agent: quilt/0.69 Date: Wed, 29 Apr 2026 16:14:56 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , stable@vger.kernel.org Subject: [for-linus][PATCH 3/3] tracing/probes: Limit size of event probe to 3K References: <20260429201453.449214720@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt There currently isn't a max limit an event probe can be. One could make an event greater than PAGE_SIZE, which makes the event useless because if it's bigger than the max event that can be recorded into the ring buffer, then it will never be recorded. A event probe should never need to be greater than 3K, so make that the max size. As long as the max is less than the max that can be recorded onto the ring buffer, it should be fine. Cc: stable@vger.kernel.org Cc: Mathieu Desnoyers Acked-by: Masami Hiramatsu (Google) Fixes: 93ccae7a22274 ("tracing/kprobes: Support basic types on dynamic even= ts") Link: https://patch.msgid.link/20260428122302.706610ba@gandalf.local.home Signed-off-by: Steven Rostedt --- kernel/trace/trace_probe.c | 6 ++++++ kernel/trace/trace_probe.h | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c index e1c73065dae5..e0d3a0da26af 100644 --- a/kernel/trace/trace_probe.c +++ b/kernel/trace/trace_probe.c @@ -1523,6 +1523,12 @@ static int traceprobe_parse_probe_arg_body(const cha= r *argv, ssize_t *size, parg->offset =3D *size; *size +=3D parg->type->size * (parg->count ?: 1); =20 + if (*size > MAX_PROBE_EVENT_SIZE) { + ret =3D -E2BIG; + trace_probe_log_err(ctx->offset, EVENT_TOO_BIG); + goto fail; + } + if (parg->count) { len =3D strlen(parg->type->fmttype) + 6; parg->fmt =3D kmalloc(len, GFP_KERNEL); diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h index 9fc56c937130..262d8707a3df 100644 --- a/kernel/trace/trace_probe.h +++ b/kernel/trace/trace_probe.h @@ -38,6 +38,7 @@ #define MAX_BTF_ARGS_LEN 128 #define MAX_DENTRY_ARGS_LEN 256 #define MAX_STRING_SIZE PATH_MAX +#define MAX_PROBE_EVENT_SIZE 3072 =20 /* Reserved field names */ #define FIELD_STRING_IP "__probe_ip" @@ -561,7 +562,8 @@ extern int traceprobe_define_arg_fields(struct trace_ev= ent_call *event_call, C(BAD_TYPE4STR, "This type does not fit for string."),\ C(NEED_STRING_TYPE, "$comm and immediate-string only accepts string type"= ),\ C(TOO_MANY_ARGS, "Too many arguments are specified"), \ - C(TOO_MANY_EARGS, "Too many entry arguments specified"), + C(TOO_MANY_EARGS, "Too many entry arguments specified"), \ + C(EVENT_TOO_BIG, "Event too big (too many fields?)"), =20 #undef C #define C(a, b) TP_ERR_##a --=20 2.53.0