From nobody Tue Jun 16 20:35:00 2026 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83C4F39D6E0 for ; Wed, 29 Apr 2026 07:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777446861; cv=none; b=QAB0HASR5GVZi5Y67bhqsMCQ2Erfl0Cv5Hm/GZEU5OAz3NmnEevY7FBDck6fAZgx0jvQmPWHUqflkNGoQXPw//3zpCAgtVlgvG9xWCG2B8+EtqU6ajqE588A+S4sIx/TP/5n0bIQ5P7a68Mk0DZJGa5uQ7NvTbYQ98wqQPyMjKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777446861; c=relaxed/simple; bh=BzL2dzaDkxeqGllHqj3NV6tg03FX4+dG8gU9GpWFTqc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n6TYKq0pCoe6unblsQMQF44EaGfvD1wFaR6kxhxYMUSMQ978DDal1M94IxnVxUz+KM+ckrLscvBkoqjZTtj0EMzDc4azwDP1iTS3d2C1GIU4GODV7DlSi+yDANiLg3wKVck+4orhF3EW2Uyq3yDB86oXZMluo/EMNDgsgI2EjnI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f4xIbUUh; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f4xIbUUh" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-3922b35e69cso32050621fa.0 for ; Wed, 29 Apr 2026 00:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777446859; x=1778051659; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YEfFwVoPkTu57X++6jUaIy2CgDN8Kgokv8XI4v/O6v8=; b=f4xIbUUhbaKClwpI7QDtMYfSpbLGolNibAaasNUoHuJv5HrL30gbSVR9bPRlOG2dCA GsI5s8mI7nXxnWZZVXr4YS9eET+3o8OkwVhNkScVdax0FBVCaJ1FM+Ko2CCCB0Nhg1cE 3SO7/sxkJKC8RxT7AEiUpvh2xdW90j59ZsgGRYt5hyRADqkBRzRmPvXGCzRh5ZTlzBA8 JVW3N5z8GxsoeF/7+FzxzojgbdncshthlmW967ZoXYkClth9Z6G/A3Gy/Ru5j4MSr1g2 HsSRk3vxysbNAkAyM7FOBqXjzrq7plCyfUw5TEJuuy0TsoFlKrxr0x+lEtgEP0CPKvIl Ignw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777446859; x=1778051659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YEfFwVoPkTu57X++6jUaIy2CgDN8Kgokv8XI4v/O6v8=; b=iMn5fWosx/Eof8IW3U9FC1rMKXuzhO/W5VoUEEjN7iBfzYqEhmV5bpRK9aElhojFbM WnFMPxr8IYOOuJjhOooloPJoNbPeMlzlawaBHxIKxAVE+hwS1tbSYLC5OhNR86lMQbk/ lQX0l1fAEqqf4yZjXBM1Of1kJxZgeCLn5ZnnjvZb2zXeJKozy9T9ciP4kpd5mvoEZZim SpgxA4IpvKq8BrlZYvQjSIufIS2EA/VTNGWuB6wwg8MVdKJgNIyzQY9HpNBlnwhIAaMc wipKXPBOsYJrZQzK0xT0Nj74rv/aunr62Q326DZ9geQuXuma2Z2zQGC/OmAhrOnmIt66 5CcA== X-Gm-Message-State: AOJu0YzmyF3fUwL/FQfpCDko4+QLQ+kSqKeRmR3jFWYLNahDwa8hPx0J r/R3vTgXn8zgwOA9n3QIbUZVnm9xq598RdtQQJ/hwxBamufx4ZXvZ7J9Ec5ljaM1 X-Gm-Gg: AeBDiesEwlYiC3maaIGgBjI4cGKCICpp6tyOYi21mEP15R00DFta3Zy/UiAWbGdVEEV Q0mcvc5zLBJeuKDu2o9E55ktmPyNmmkH44wlMyqlvVvlGhoCODuBY8QC34clARZf/1zc+v7PJMa 2Xffi7OMAYE3f7nrBXXvNrEoTb+nXRJXqYsmTag2uiBWDCQMpmYaISs+V2u46vfrrL01GaLwOkm V5vP2oGq0apDTdTzUHtTPiizKK6P/W/nCfcAE9JQyo8InNLNHVahmf3Ucz0kbqHsL/SMcvZ7u7W K7c0i0rYH4iijtlIzHpC3SfJ0r7umqQu29BwXdzksNTT26xg4EK5jrO08GouL4oG9KY6f2WZCg1 kL6Ed4Jo3MSmy0LVzrBrBZi9Q37R5eE3mk+D2hjS9AkIzV7ErljGpVjnhCWmJoi3mDQbEYW+VT4 3DX8mb3WFpk+/e635nKmjtpl22/TlbBKk= X-Received: by 2002:a2e:a994:0:b0:38c:c253:2999 with SMTP id 38308e7fff4ca-3924100a4d7mr21713741fa.31.1777446858332; Wed, 29 Apr 2026 00:14:18 -0700 (PDT) Received: from thinkpad ([188.225.109.225]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3924fa7c93bsm2861151fa.23.2026.04.29.00.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 00:14:18 -0700 (PDT) From: Matthew Bystrin To: Lee Jones , Richard Cochran , Min Li Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 1/2] mfd: rsmu: fix page register setup Date: Wed, 29 Apr 2026 10:20:46 +0300 Message-ID: <20260429072047.1111427-2-dev.mbstr@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260429072047.1111427-1-dev.mbstr@gmail.com> References: <20260429072047.1111427-1-dev.mbstr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix writes to page register in 8A3400x family (Clock Matrix). All calls to rsmu_write_page_register() (both in i2c and spi) have resulted in early return, becase all addresses in include/linux/mfd/idt8a340_reg.h are less than RSMU_CM_SCSR_BASE. There were 2 separate patch series which have to be merged in one time: mfd and ptp. The latter have been merged, the former[1] have not. Link: https://lore.kernel.org/netdev/LV3P220MB1202F8E2FCCFBA2519B4966EA0192= @LV3P220MB1202.NAMP220.PROD.OUTLOOK.COM/ Fixes: 67d6c76fc815 ("mfd: rsmu: Support 32-bit address space") Signed-off-by: Matthew Bystrin --- drivers/mfd/rsmu_i2c.c | 6 +----- drivers/mfd/rsmu_spi.c | 5 +---- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/mfd/rsmu_i2c.c b/drivers/mfd/rsmu_i2c.c index cba64f107a2f..9e5fc8259eec 100644 --- a/drivers/mfd/rsmu_i2c.c +++ b/drivers/mfd/rsmu_i2c.c @@ -134,14 +134,10 @@ static int rsmu_i2c_write_device(struct rsmu_ddata *r= smu, u8 reg, u8 *buf, u8 by static int rsmu_write_page_register(struct rsmu_ddata *rsmu, u32 reg, rsmu_rw_device rsmu_write_device) { - u32 page =3D reg & RSMU_CM_PAGE_MASK; + u32 page =3D (reg | RSMU_CM_SCSR_BASE) & RSMU_CM_PAGE_MASK; u8 buf[4]; int err; =20 - /* Do not modify offset register for none-scsr registers */ - if (reg < RSMU_CM_SCSR_BASE) - return 0; - /* Simply return if we are on the same page */ if (rsmu->page =3D=3D page) return 0; diff --git a/drivers/mfd/rsmu_spi.c b/drivers/mfd/rsmu_spi.c index 39d9be1e141f..c931d8cea0a1 100644 --- a/drivers/mfd/rsmu_spi.c +++ b/drivers/mfd/rsmu_spi.c @@ -101,11 +101,8 @@ static int rsmu_write_page_register(struct rsmu_ddata = *rsmu, u32 reg) =20 switch (rsmu->type) { case RSMU_CM: - /* Do not modify page register for none-scsr registers */ - if (reg < RSMU_CM_SCSR_BASE) - return 0; page_reg =3D RSMU_CM_PAGE_ADDR; - page =3D reg & RSMU_PAGE_MASK; + page =3D (reg | RSMU_CM_SCSR_BASE) & RSMU_PAGE_MASK; buf[0] =3D (u8)(page & 0xFF); buf[1] =3D (u8)((page >> 8) & 0xFF); buf[2] =3D (u8)((page >> 16) & 0xFF); --=20 2.53.0 From nobody Tue Jun 16 20:35:00 2026 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEF33A1A4C for ; Wed, 29 Apr 2026 07:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777446862; cv=none; b=nAjOvTyaNEy/V2GnGsdJkg5Lhi/x58jelHBFXW10/VLJ+WY9113SeMOMx27g/czTCpLPi3YoF7MgVJcMW1kQqxW2xjdWNSIJkmS/XPZEMnuchWUdfjQipdhDXYNiTyi3BYw5am0asbBTjk8xuRlTdimi/bKee4YcBZ1t8P+u/ds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777446862; c=relaxed/simple; bh=dW+ME8+T/cZdaRp0hgNE+NKFQ20WpKrwiMvExM21R9g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qb5IT4PUWxWzb6SONHn0ZsPYShXfqgzY1tckkzq+8weU/1cZQCYBhWzDB2+MCLAzGV2ICyfGxk1mObO8yxBEXyHGkeW8AhfgKWWsjHMez+m8qDjhveNNJUHY1akebWah1SZZzkbY6D3tzMv2iR/0WtMhjHogGgmBv978MgeTTgU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mHr5PftI; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mHr5PftI" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a3fcb2c718so10638369e87.0 for ; Wed, 29 Apr 2026 00:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777446859; x=1778051659; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ayWJ8sM71wXdRAfLJ35+sbAWmIRBbaKRHeFJfEPXpOA=; b=mHr5PftIpRMib/QWarsk3ZlG/xbsPbk/64khaS7nvo6jGZYU9XDJL/uiBqUEnbR7J7 JB8OdVreCnhMXOG2lufXPUL8Y7aA2iNgO3bAQCJZpzpGmhtaoIPktwTUFTDjuc5AooNQ 7W6XTEVa6j0SR/OVX/aZNCBZTrx+znhim5adbx7h14v06sgFI1B5EudOmNg861Cf5A/O Kl5Jdv/c/4H0TFMBXW7XvrVVI++Yj7XGGSuY/tARpZjPqTVj+qXXYBPYBZSo+UntPfmP VL4IsHn6WMAzzOM44pGPiIp5wJ8pnuj1tA4J4kJCBV3ro4oIIyH0tH1uF85vfj2eCN4d h+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777446859; x=1778051659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ayWJ8sM71wXdRAfLJ35+sbAWmIRBbaKRHeFJfEPXpOA=; b=eFZranu6V2uOHPi0R3Iny2/kKs+dUw7OIJEWyCOnwgL9V3XxCMv0jElyHYuPA1/JQo mKLSk4ccN0AA8AEbQerAUr2w08zzDASe/YyCjMKQLvNhF3iEHsx/2Hgk94NBWBbrjuKa bLW6iSCK3BntFU6+UBYzUCb3MeiQMR0fQ2OJgEslA/BVT80q5COtk175wxxj+aRitvM3 zsdT1DHTpQRgbCYQAKkjMGX5kg5NN8OLCIqVn/mVr+w00OHRQ8x0cVtELy6vxTf9ah1D rCwt5gW8/aJXVMQXmvU3zIHa5Qzdvv/oW3WKniq/A5NwHCeWIwyUdEWK3hgT2S2KfqYf sV5A== X-Gm-Message-State: AOJu0Yy/NFDRpVs/+opIlsVVR9BedeIrSWdc9axUfSboya8J32I9FNaw DbWdW4KRDkLblzTWTPDnZN37I1Gffc1c1w0+Zy/bkPcV/pDpV01+2UIw X-Gm-Gg: AeBDieuEyAUugHC9fKCe7lnWLTWyyh753TQ/2IDUqokbcOqw99o6VAm2yARiIL2NYXY RxpQpSgZ0BLpF0SD7d4lJdU+V3BOC+KzN1a5bH+n2pb9mHwSPczWioQ21HYfToN93y+ImWAgZVe y9sGiL98PqpfxQPVOhAUj23yT3WeMw1OtZfO52WmpU4SVJWCKr1Zhlq/lX2A3gLWN0Wh6eY4cEQ Sx35CjG6EYgmRo6Rx4xPm9Uc3QcTKxJlwNYEy9U+F9SkM2I5TQeP2hZ0/mFG9cP1Pozuy9Xf59/ KPb47mei2529ctX/XJsTFmU5/Nr9Qm3q9FP7uxMsgI04z/OlUK5/Fo/geNIFvT9e9XY1R+yjS+t lRppNyVMm/x5taJ/HcaJfkiwGTOk/C+39xkJkGOm8PuuDiZeSKeF+CcgrdGOQHpjmGQZPpSp13O 4XyYwWOxn5Sx9foASUkt10JpIGPmqjxtw= X-Received: by 2002:a05:6512:3a83:b0:5a4:19de:eb70 with SMTP id 2adb3069b0e04-5a749d21fabmr879609e87.28.1777446858957; Wed, 29 Apr 2026 00:14:18 -0700 (PDT) Received: from thinkpad ([188.225.109.225]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3924fa7c93bsm2861151fa.23.2026.04.29.00.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 00:14:18 -0700 (PDT) From: Matthew Bystrin To: Lee Jones , Richard Cochran , Min Li Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 2/2] mfd: rsmu: add 8a34002 support Date: Wed, 29 Apr 2026 10:20:47 +0300 Message-ID: <20260429072047.1111427-3-dev.mbstr@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260429072047.1111427-1-dev.mbstr@gmail.com> References: <20260429072047.1111427-1-dev.mbstr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add compatible string, i2c_devcie_id and spi_devcie_id to support 8a34002. Signed-off-by: Matthew Bystrin --- drivers/mfd/rsmu_i2c.c | 2 ++ drivers/mfd/rsmu_spi.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/mfd/rsmu_i2c.c b/drivers/mfd/rsmu_i2c.c index 9e5fc8259eec..c57795ed20f4 100644 --- a/drivers/mfd/rsmu_i2c.c +++ b/drivers/mfd/rsmu_i2c.c @@ -330,6 +330,7 @@ static void rsmu_i2c_remove(struct i2c_client *client) static const struct i2c_device_id rsmu_i2c_id[] =3D { { "8a34000", RSMU_CM }, { "8a34001", RSMU_CM }, + { "8a34002", RSMU_CM }, { "82p33810", RSMU_SABRE }, { "82p33811", RSMU_SABRE }, { "8v19n850", RSMU_SL }, @@ -341,6 +342,7 @@ MODULE_DEVICE_TABLE(i2c, rsmu_i2c_id); static const struct of_device_id rsmu_i2c_of_match[] =3D { { .compatible =3D "idt,8a34000", .data =3D (void *)RSMU_CM }, { .compatible =3D "idt,8a34001", .data =3D (void *)RSMU_CM }, + { .compatible =3D "idt,8a34002", .data =3D (void *)RSMU_CM }, { .compatible =3D "idt,82p33810", .data =3D (void *)RSMU_SABRE }, { .compatible =3D "idt,82p33811", .data =3D (void *)RSMU_SABRE }, { .compatible =3D "idt,8v19n850", .data =3D (void *)RSMU_SL }, diff --git a/drivers/mfd/rsmu_spi.c b/drivers/mfd/rsmu_spi.c index c931d8cea0a1..e07f21482439 100644 --- a/drivers/mfd/rsmu_spi.c +++ b/drivers/mfd/rsmu_spi.c @@ -241,6 +241,7 @@ static void rsmu_spi_remove(struct spi_device *client) static const struct spi_device_id rsmu_spi_id[] =3D { { "8a34000", RSMU_CM }, { "8a34001", RSMU_CM }, + { "8a34002", RSMU_CM }, { "82p33810", RSMU_SABRE }, { "82p33811", RSMU_SABRE }, {} @@ -250,6 +251,7 @@ MODULE_DEVICE_TABLE(spi, rsmu_spi_id); static const struct of_device_id rsmu_spi_of_match[] =3D { { .compatible =3D "idt,8a34000", .data =3D (void *)RSMU_CM }, { .compatible =3D "idt,8a34001", .data =3D (void *)RSMU_CM }, + { .compatible =3D "idt,8a34002", .data =3D (void *)RSMU_CM }, { .compatible =3D "idt,82p33810", .data =3D (void *)RSMU_SABRE }, { .compatible =3D "idt,82p33811", .data =3D (void *)RSMU_SABRE }, {} --=20 2.53.0