From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A0E4372B59; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=BIkOYYqRPlrqx5VnHVMttK1/E9JMVqFQh7v9Xe9oCvonLQ+ubY1XVR7Xev3HNmgeJ6CC4XhDKkB7EwSSb8rnCS3HndTJMCCe+ba8II99NhsftN8N7qyJqxGrxFggEdzOh1RDsWvM9QObtVvQz6tFMaQz1TSFIP9K0gXz/gHE64E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=7peLhzJvJ3a6wBH0sLXzb2tyKdVDBqWlJJt0IOsxTBA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hjq0bNWwGPGBaUu17MVexyEuRRtzXtNeis7AmFnnxP+NYs3QyKSvfTMimD7fC3rh9FDNyL00kwMq3hX/AIfSZNPf81tIYYQD0WMZxHi8y4k7H3hznv7+dbYbRB+SaemY/nx0Z2vSSnKlUu94w0ms+zFTbgqFFtYdtM/98m0yDhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l51DEZxC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l51DEZxC" Received: by smtp.kernel.org (Postfix) with ESMTPS id E12A7C2BCC4; Wed, 29 Apr 2026 15:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=7peLhzJvJ3a6wBH0sLXzb2tyKdVDBqWlJJt0IOsxTBA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=l51DEZxC6gkhyyml4uSpscdPiMW8Xc6S31D3shVe5bfM/laM0yZiOk+607SZWl6DG GxGH8GVdFIOL/UDKjUJGneD0dCI4vIwxoE4crTmR1k7b+D7Undrk84tgCVs7aF/olR WNkCgzxPagxVyObYvWzaL8LoqPV2a86JjWxubTNuM6wppFmHaAJhjXaAsTrfVamBuR tG+ynWW3HQ5qPeQ7X0MRoDeyUkZNEmEjCyVIBuNoYEyMOPnKpGm6GFbHwPXQGm83u6 RzVEXGcmUtyWYYfw9leVXC+DrObkMbhxrDEL/YaftoYZca8LKP9txloxwG5GfHIPbh RR0qJCP7d+leA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95EDFF8867; Wed, 29 Apr 2026 15:05:49 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:49 +0200 Subject: [PATCH v3 1/8] iio: light: si1133: remove unused macros Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-1-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=969; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=Ecef6Lis4KUDy5wkginYFApj5UHLvf6O9wthv94jeNY=; b=VOfiDrlq/09SWdsT4tH+FwToLIP84cp1zHZoWoN1tklDogUu705H3koPJEFE1QiG7nuhOzDv5 cMoZM4DNrlZD9bjZVO80h2qUfB+C+2nbEbN/Ry1vfS3HYYFp1QAkWMy X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Remove unused macros to improve readability. No functional change. Signed-off-by: Joshua Crofts Suggested-by? (I am fine without that tag, up to you.) --- drivers/iio/light/si1133.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 44fa152dbd24c26c97cc778cbe641d92ecd56afa..73b0ce21e017cd4ab6c6b280229= f417763866502 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -86,13 +86,9 @@ #define SI1133_CMD_MINSLEEP_US_LOW 5000 #define SI1133_CMD_MINSLEEP_US_HIGH 7500 #define SI1133_CMD_TIMEOUT_MS 25 -#define SI1133_CMD_LUX_TIMEOUT_MS 5000 -#define SI1133_CMD_TIMEOUT_US SI1133_CMD_TIMEOUT_MS * 1000 =20 #define SI1133_REG_HOSTOUT(x) (x) + 0x13 =20 -#define SI1133_MEASUREMENT_FREQUENCY 1250 - #define SI1133_X_ORDER_MASK 0x0070 #define SI1133_Y_ORDER_MASK 0x0007 #define si1133_get_x_order(m) ((m) & SI1133_X_ORDER_MASK) >> 4 --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F50935F605; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=Lp1GCHeTNxuSbr4GrXVgkhc4qzwXlkZiHhIufe+CpbxGMSLD+H5X5Ci56DTXYJkam0v3frc4P2CreVNtWuZ6Fmb4C4XJM3o+IAtJXjMH3hFHjrmcsHw1SFtHpbGkBYrbcYqtpmlyr7gHYP6BMyRVK7jv9xb65BChXczfNMbELjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=E2Cs9WNPHooVbreDTbVYPhFi7CYJLKCIehDwlmW/qVQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=siFAOLhji516Bc9s859QG4qS8jODKZo5AlkU7P0myiBARoPxyous90jPHLtY9M5lXXgCyfrDz+uQ/l+3VUgNv4WvHWxUl+0OIDbV+7V/MGN2l/+vj6s6AT2Q7JALT/N0HmDZVyjxsQzoTMo47l7EXr5EglXGr9BzBZmN9sRns4c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qEQO8P/R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qEQO8P/R" Received: by smtp.kernel.org (Postfix) with ESMTPS id ECB0AC4AF09; Wed, 29 Apr 2026 15:05:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=E2Cs9WNPHooVbreDTbVYPhFi7CYJLKCIehDwlmW/qVQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=qEQO8P/Ryu2oD7oC6dFMaRPz1xgwtEdnj7UGOF2N2GGVrqG1ixgS0lp9oIAt2HD72 SN/iLnJVKHIceRVM7PeOec+I93UEKvKMyEPYWiXG4beIOpYskrz9ZzVefRA9N+sulu IRJlPqrjzqL/6Uaa6l/51e8jcr1xoy/V323twuEb+UHe9H0yHb9vTL8yGeDBYGxU7m 315NUahdfumy+aVqVXIyRsnfFjAknQwX5sCMMPxT44pZ82ZJEb/wt+N0AoOmlAA612 3giNaOdKhoBD6CTVXqx7zUC0yN9HZPiKSrAEYZQNUmljvYeyWhf3WMDscbQu7218hY 8H5PET6zOBwBg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC92CCFA13; Wed, 29 Apr 2026 15:05:49 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:50 +0200 Subject: [PATCH v3 2/8] iio: light: si1133: prefer complex macros enclosed in parenthesis Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-2-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=2245; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=C5i/c58hyZEyHBbZkt7Seo1G34DfU10pUdqQTYkoeCA=; b=EufXNHGRlax2ZHJHlv8WL4aa4BV5hlrrwB6Enq6d85WsOFkeSk6LZh8l3tszAHGdaWqEtTvlD YNKbPCIsB2gCWiwHvK5gPicEmn5jRctgd58d6yL2gZ3Vj2lsYTlI+5e X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Enclose complex macros in parenthesis per checkpatch.pl error to improve code style. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 73b0ce21e017cd4ab6c6b280229f417763866502..136436c0379aa732a2c93d40b08= 734ae4fc2a45f 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -50,23 +50,23 @@ #define SI1133_MAX_CMD_CTR 0xF =20 #define SI1133_PARAM_REG_CHAN_LIST 0x01 -#define SI1133_PARAM_REG_ADCCONFIG(x) ((x) * 4) + 2 -#define SI1133_PARAM_REG_ADCSENS(x) ((x) * 4) + 3 -#define SI1133_PARAM_REG_ADCPOST(x) ((x) * 4) + 4 +#define SI1133_PARAM_REG_ADCCONFIG(x) (((x) * 4) + 2) +#define SI1133_PARAM_REG_ADCSENS(x) (((x) * 4) + 3) +#define SI1133_PARAM_REG_ADCPOST(x) (((x) * 4) + 4) =20 #define SI1133_ADCMUX_MASK 0x1F =20 -#define SI1133_ADCCONFIG_DECIM_RATE(x) (x) << 5 +#define SI1133_ADCCONFIG_DECIM_RATE(x) ((x) << 5) =20 #define SI1133_ADCSENS_SCALE_MASK 0x70 #define SI1133_ADCSENS_SCALE_SHIFT 4 #define SI1133_ADCSENS_HSIG_MASK BIT(7) #define SI1133_ADCSENS_HSIG_SHIFT 7 #define SI1133_ADCSENS_HW_GAIN_MASK 0xF -#define SI1133_ADCSENS_NB_MEAS(x) fls(x) << SI1133_ADCSENS_SCALE_SHIFT +#define SI1133_ADCSENS_NB_MEAS(x) (fls(x) << SI1133_ADCSENS_SCALE_SHIFT) =20 #define SI1133_ADCPOST_24BIT_EN BIT(6) -#define SI1133_ADCPOST_POSTSHIFT_BITQTY(x) (x & GENMASK(2, 0)) << 3 +#define SI1133_ADCPOST_POSTSHIFT_BITQTY(x) (((x) & GENMASK(2, 0)) << 3) =20 #define SI1133_PARAM_ADCMUX_SMALL_IR 0x0 #define SI1133_PARAM_ADCMUX_MED_IR 0x1 @@ -87,11 +87,11 @@ #define SI1133_CMD_MINSLEEP_US_HIGH 7500 #define SI1133_CMD_TIMEOUT_MS 25 =20 -#define SI1133_REG_HOSTOUT(x) (x) + 0x13 +#define SI1133_REG_HOSTOUT(x) ((x) + 0x13) =20 #define SI1133_X_ORDER_MASK 0x0070 #define SI1133_Y_ORDER_MASK 0x0007 -#define si1133_get_x_order(m) ((m) & SI1133_X_ORDER_MASK) >> 4 +#define si1133_get_x_order(m) (((m) & SI1133_X_ORDER_MASK) >> 4) #define si1133_get_y_order(m) ((m) & SI1133_Y_ORDER_MASK) =20 #define SI1133_LUX_ADC_MASK 0xE --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3447C374E76; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=r7Dqcat2yrpc1xLWfzSVUZnx4Q9ZDfg+dI86vbWsPEBUYKbQha6V15B9oTdTuA2r3Hy4+Tmu/njaZZ6AUQLyTGjhzyWekeN6EVQVUWyCAPwMGOJPY6MqonbXvL58biaizBSs4lZQGvTTN3uOpaMVfSd6NawiroUnI0JsWASiPzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=sguCKgxNu8HtHe6LCiRY2bkftduteXjABj29u6GhgFw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AkUQTi7HGAtzf8YMnCO3H9Tg+4CZa2xjJJBJ9H6dTo69cV2PFtly+lRIa2jDhJcpa9F6HacEBuCi6Z2yMjivD714/xnj6ui2aREeoJbldBPJW3hT1VrqDUd/IVuN9iIWYVYi6wRft8WNS3ENPKloifBTFoyVws1nVM+FuYtRNNs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IQd3Ozej; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IQd3Ozej" Received: by smtp.kernel.org (Postfix) with ESMTPS id 0FE9DC2BCC9; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=sguCKgxNu8HtHe6LCiRY2bkftduteXjABj29u6GhgFw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IQd3Ozeje+yWTdyKzH7iowUn59u2s/e2pQNixWidueZVePNpwJ6a/rhiokhL7rzc7 rFYl+sxsSakDkrRii/czf3iKq/dZ97CgK5mXbSl7C9QjchLt51aio7fE3pgMy2hY9m Ys/5cMSiTlrFhMRbuM9ixM4nuSZEGqednDBhxJJXQVyFl/pyXYutVgisE+ESyQwRsl hBiXHLkz0Md7fXZDloLum79GG/r7nr5hM/NSnCMrkEvOwm4BOS/gLsgyCSWpwJK3g+ yKTXlmYqQ2rKhAPUbhWrYbTbHzBKQNpkpqPlNEuJe6XXfLNfldkj0tWL9nAQBXFbMq gm9sfjM1B+u7g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00D84FF887E; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:51 +0200 Subject: [PATCH v3 3/8] iio: light: si1133: add missing include headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-3-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=1193; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=OWle6DMZJq2w2RARzbyed/7OgweWtx5OkO036pgenT0=; b=1nk+G3fThs90hmUvMW0haSI5r1UjL8V18mpb30LWGYtqSMrSBuIQKRzJfKBP2vCidOmOYBnSu H+ZLOm564PGD3dIyMdrQI63Sv+ecomBQyKV5ul0qjg94HJP9M3xIhPf X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Add missing include headers to prevent compilation relying on transient dependencies (array_size.h, bitops.h, completion.h, dev_printk.h, err.h, irqreturn.h, jiffies.h, math.h, mutex.h, types.h). Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 136436c0379aa732a2c93d40b08734ae4fc2a45f..dabb1aae05535313e77441b7d06= 6bce931de79f9 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -6,11 +6,21 @@ * Copyright 2018 Maxime Roussin-Belanger */ =20 +#include +#include +#include #include +#include +#include #include #include +#include +#include +#include #include +#include #include +#include =20 #include #include --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33176374E74; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=XHc9hs97ApM2v1gC63WA0NkyfpcXC/hFzU5Tp+2FnBISKAl+MO+JlYC+yobC3CjkebKTnAZKGVI/H8ZGYPuMKyOIK3NWckTq5b8jl7PQGummnNXZMR70ywVDLQmrhVBI8rob8fFMVNgkbd6XrQEm8S+t5NGKJhkvKs42AZn9+60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=AH8AeEQaXLtKRQyFjBldeZydo3TjoBIHFqCuIF4x9eU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ovreIywltNqOKZYUZ57UMEiTJAN/ueCt/P/uNUBAWs4zVhfCaU883pFHe9p1tyf2rADDgM9KSqaHwEcBIQ3GOKoVxe40lxFXUSp7RxxWfye3gE62z9gp30IXhu+Pi3zXHdwaQLnorBSlCDXxWhFeRgygAhnZ0JAlbU3pFJrS19w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bo3knrem; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bo3knrem" Received: by smtp.kernel.org (Postfix) with ESMTPS id 18118C2BCF5; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=AH8AeEQaXLtKRQyFjBldeZydo3TjoBIHFqCuIF4x9eU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=Bo3knremdkuTpLNTinyloswU1FwK8hFH9HR18h5+2+ffCzkBJFvRdaiS0MwaKXlUs qQ9TI5o+lmv09dCfTfuqRfMn6HtR6lhPvKbntWRtW9VQ2FN+VR1S+2NfvxhVblG2St BYYy14JSLMvNPpbAcd3rJ/8xIT2NE2yvsxYQ6iU8SoDqdwNwwDFjP5HGnDCjlzJfBz MnxBRM3yZU54Cgkw2paSYksOh7pGn0sRe2Qd9frgw3v+8BDYsaukAHQlv/YSSu5FE4 w9g2NL5Ac/SRV3DrQSl5ho+s4IKcC+I6Jz2d4NMl4eZ0x/DkZgDoseySZibKXqcB4Y EwkQhX4EqlIqg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 102AECD13D2; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:52 +0200 Subject: [PATCH v3 4/8] iio: light: si1133: group generic headers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-4-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=901; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=GteppT24iSohKJCdd+nKyoBWeY2ILBL0xKsDtQzzxF4=; b=A/pF8NeozoIdLXWf6X20ZMSVQUkjWr8Bc2xiNSeE5W1tkHpcpAif1rIgtHHC/OtNlnsoa+QVx HHGRZQ3jddMCO1ycnlx3rjbfNxY0XOczlDPrpsWMRErJOyaQbMDVcDi X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Group generic include headers to improve code style. No functional change. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index dabb1aae05535313e77441b7d066bce931de79f9..f46485304877a89eff3616c62d5= d2a4459bd0c5f 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -21,14 +21,12 @@ #include #include #include +#include +#include =20 #include #include =20 -#include - -#include - #define SI1133_REG_PART_ID 0x00 #define SI1133_REG_REV_ID 0x01 #define SI1133_REG_MFR_ID 0x02 --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 465BC3750DB; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=o4/vmtDkY6rrQTm+wjaJJ9TWUCh3pCZBkip3Dp5qfNroW1mPq2ZXDkPu7gr/dAMExIOTFYUb+/xpOWCnVwNd+cVe/q3JypgXbwIs+hyswsBYj8FADoQPP7DSSmDNfkmfxz8fDnifZ2JAv50Tkaz+KwmKK2PtXKqXcFkqSKnqDXs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=DaRxNVHmK0ihBUzE86Hvs7kynsgkJi/LTdtP2UDKHac=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fOqOzzXMez0UmS3dofLYnpNct8WbU5faEXNU9XJGZzSVfXm7A95pNHVM7Wtq/924eAisL/WnPvnm7kwXEbgc3H7vxyzstS/YrXhWDMdueSBmekXraTuYO0dGBowhrT8qkmLEZQuy+DdfmtRKbtj7ugapNrtPP5xSCBWBWA4JmSk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jptzpIXe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jptzpIXe" Received: by smtp.kernel.org (Postfix) with ESMTPS id 24AE0C2BCFA; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=DaRxNVHmK0ihBUzE86Hvs7kynsgkJi/LTdtP2UDKHac=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=jptzpIXeYVimrnPQTXhxOWy70o5h6gY29KT3EmDT9PNBxTHY/6whOxMQQd+PPzTMw QU9bozeOJtll0tDCQwDPmqW5obNLVVIF87xLAGckentH+rcSVWd8UK/MiO28zVHnZs zx4rrMNWK+oQqJ46kT+Ds/zStR/lQMwvaDa5coZ3L0Jzmow4bw6MXtKnpLHGJ3KvF8 QRMEDQTk5R/gK1iYJCqw1FxzpoBpKvAmC8z95aRurbZvl5MmewTVYjKs++fOh2Ucq8 rCfh/eQKEoR8/zfIaB7ou15BDtgZO49jy6eTd13BO3pcYekWcqEwDrEJSuA9KyfNPK Wb2kosggfCsVg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E482FF8875; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:53 +0200 Subject: [PATCH v3 5/8] iio: light: si1133: use guard(mutex)() macro Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-5-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=2115; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=E69eUronemB3l0JbXsHYCddkenZNL8ZsjA84TtbMePo=; b=lGhGn3IlE+PPDM9OtJMTLULyr6D1Ke4pNMiJa4EXBJh0mnrqJJA5iwvNkbVjhL85GxEyX4k3U 7PikWelQvhtCEGKAg6oU5Xy87jSOLKLWd8EEXsLgklDV9E3rEl+Fny+ X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Remove mutex_lock()/mutex_unlock() and goto instances and add guard(mutex)() macro to modernize driver and improve mutex handling. Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index f46485304877a89eff3616c62d5d2a4459bd0c5f..939189d8c18a85ad64d8c05dfb8= 3b5989f524791 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -8,6 +8,7 @@ =20 #include #include +#include #include #include #include @@ -395,7 +396,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) int err; int expected_seq; =20 - mutex_lock(&data->mutex); + guard(mutex)(&data->mutex); =20 expected_seq =3D (data->rsp_seq + 1) & SI1133_MAX_CMD_CTR; =20 @@ -406,19 +407,17 @@ static int si1133_command(struct si1133_data *data, u= 8 cmd) if (err) { dev_warn(dev, "Failed to write command 0x%02x, ret=3D%d\n", cmd, err); - goto out; + return err; } =20 if (cmd =3D=3D SI1133_CMD_FORCE) { /* wait for irq */ if (!wait_for_completion_timeout(&data->completion, - msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) { - err =3D -ETIMEDOUT; - goto out; - } + msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) + return -ETIMEDOUT; err =3D regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp); if (err) - goto out; + return err; } else { err =3D regmap_read_poll_timeout(data->regmap, SI1133_REG_RESPONSE0, resp, @@ -431,7 +430,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) dev_warn(dev, "Failed to read command 0x%02x, ret=3D%d\n", cmd, err); - goto out; + return err; } } =20 @@ -442,9 +441,6 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) data->rsp_seq =3D expected_seq; } =20 -out: - mutex_unlock(&data->mutex); - return err; } =20 --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67CF1376BF1; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=taECChuvo/ErNHOXELVh0hJyGqVh8vh69RDrcbIlvt+dQNtntIwn24rPgRVPUZH5BgFwDCqi5W5rnDHKilif5mPAJMNzR3Yq//Urk24haD9HrnVhaTSAMpt95cz4Uh24dHiRfWdzhWQDAzONDo8KncStLXzErp0VgspIhFWeF4A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=J8mC8/qrjkHpf4CkN0JrZVGuozI8+Rsvir9tTe1ky/o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZcPgLkiBtJFC4Qu7EFCObppFnXH8o7EGowdmG38RtnrBPwYQjRNeHqR28Ez3Y7/uzULvQ6aax+qcHrLDtb2QGj43oZKBq2ok/0G5lziNIG31MHl8Mrzoi7tfOHsaOXjO/9ejvmcFcxGLZI8ammK3NQ+3MJ1hN6M7bCiDrst4/Y8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WNwn/w3q; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WNwn/w3q" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3523DC2BCFB; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=J8mC8/qrjkHpf4CkN0JrZVGuozI8+Rsvir9tTe1ky/o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WNwn/w3qpVc7vRm7q6+3D2YWRzT2MCUuGj6uXp1YgKNeG5h2imBWaM9MqyWCWC++m MKWLKQIfKlCOUtsQ39H27BMAL39CQRIlOpfCwFwhnBMRyC0acrdxeCyk95Pvb6JPEP qYToC9m+ElppYxaSFSjWLS1krz0CJmcfZvvroEmn2yNELB9DyTLCsLfYPy2Odey355 wGx4cZwiIbgS2dGxIPpa+bUwM5DgRBMSr6rlwCy4V5Gw1oKFR0Drf7kzKcliSlHyUb zci7IE4FTN5AQNDyf+RHXkg5lq0g/0CTJ2jyCOt5exQdJ+P647MrpX0CbtlmsNL4Lh ukZDfrAEVvyPg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E224FF887E; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:54 +0200 Subject: [PATCH v3 6/8] iio: light: si1133: add local variable for timeout Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-6-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=1252; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=iQP88I6gwVGTwRDphxjIwdJr1kTAAQWffLw4TQszN6k=; b=zTiBost0YlvK3XbHuAiNx79dFexGpDB9KWK63Qka+PcE6GQD6XhW+PKHMM6eyCNfLjgXJ7BHP 06HM54tKl7hC6sfSpF2FP3FsXH5J2ckEQCBn8mfnqgvksU3dwbNz7eE X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Add local variable for timeout to improve readability. No functional change. Suggested-by: Jonathan Cameron Signed-off-by: Joshua Crofts --- drivers/iio/light/si1133.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 939189d8c18a85ad64d8c05dfb83b5989f524791..471692057b0f16c82946507bf7d= 23a0004f80bf0 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -391,6 +391,7 @@ static int si1133_cmd_reset_counter(struct si1133_data = *data) =20 static int si1133_command(struct si1133_data *data, u8 cmd) { + unsigned long timeout =3D msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS); struct device *dev =3D &data->client->dev; u32 resp; int err; @@ -412,8 +413,7 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) =20 if (cmd =3D=3D SI1133_CMD_FORCE) { /* wait for irq */ - if (!wait_for_completion_timeout(&data->completion, - msecs_to_jiffies(SI1133_COMPLETION_TIMEOUT_MS))) + if (!wait_for_completion_timeout(&data->completion, timeout)) return -ETIMEDOUT; err =3D regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp); if (err) --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68E14376BF7; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=jDTZoVFsmuLzWarsBggfciZfwbzqKnxyMmtsJzjT8cLM2pqqMKgevYCNJGWsqv00FIEgw0qnt7kPSIAczQpWmg/7LVJtqAtlq4kCafILozBJO7FPwufd2X4E6UfprsOauqX0JyoXf4T5ZrvnUCWK0cmCuQ5uDBA/7O17AqEx5dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=yvZqNvHhQMwxj7xF0MXrcn2P9izjkp6fBgoEoqbizpw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b8h8496eo0AJAHpfgqEIiJKiz/MRDIwGCPWPe/vEU/QrwRSkM+5lTJL1qPiS+UPbTmrBsv9j7wsa0m8jr9pxe2eth+ZMekKQH0K5+cXbSotJ1YicF6H+FmrGFmaMRJtAC+A9fRNY3T8qX2ZY6VRlzxiz9gY5J6WyNpQkkpFovA8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OeISPOSy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OeISPOSy" Received: by smtp.kernel.org (Postfix) with ESMTPS id 4477CC2BCFD; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=yvZqNvHhQMwxj7xF0MXrcn2P9izjkp6fBgoEoqbizpw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OeISPOSyONm4d7iPgRHsQCbRt3hfxIxcIggtTY0kU//I/GPRqqNhrCwmYaDYd+IMZ tc0jhUBORjsKXNH10WTfx5WaeGxWf19ATdFby0HRGgUXW49dwpYN9WewIm8HBzgVc1 RfS+hNADEodL0JIyB4Vn84xXsnr34iCSjrjgLK0+LB2dE3XrcxUuMsjyZuwAqzNB/l /gYKWDii0HUfEJPqWwur8ewfBNNML3E+WEofTYUhh7B2q9gI/K8JEIoD3pI5M5flnS tfnFzzdE8+V7cwU4Fu68l+GwEYlvprglTes9HyF14ROPVN4/Bogwl/4MJkM7HIReeW W2AH6H/dvJHnQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB91CD13D3; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:55 +0200 Subject: [PATCH v3 7/8] iio: light: si1133: reset counter to prevent race condition Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-7-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=1283; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=w5+8yh3xuGpn+X2XqfBM/QUEQDOv+CuyHlSCRq32RGk=; b=N+thik5dCDitv8Y5v6yQadfTjYzWgatWrVGaWSgs2/ysj5GlhS4q7jKx+4dTZnTnDWjM4sZMJ S2W/3fMGeNfBJMBqmLPcdlfUE8yno3ogfTBbX1yg4mYkWqr7M+tc8oK X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Sashiko reported a potential race condition happening when the driver returns an errno after a timeout in the si1133_command() function. The premature exit causes the hardware and software counters to become out of sync by not updating data->rsp_seq, therefore the internal hardware counter keeps incrementing. Fix this by adding a call to si1133_cmd_reset_counter() before returing from timeout. Closes: https://sashiko.dev/#/message/20260428-si1133-checkup-v2-5-70ad14bf= efe2%40gmail.com Assisted-by: gemini:gemini-3.1-pro-preview Signed-off-by: Joshua Crofts Reported-by: sashiko-bot@... // there is an email mentioned in some thread = in --- drivers/iio/light/si1133.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 471692057b0f16c82946507bf7d23a0004f80bf0..842a59bc68c20b3206e0c826f86= c913f6c66bd7c 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -430,6 +430,12 @@ static int si1133_command(struct si1133_data *data, u8= cmd) dev_warn(dev, "Failed to read command 0x%02x, ret=3D%d\n", cmd, err); + /* + * reset counter on err to prevent sofware and hardware + * counters being out of sync + */ + si1133_cmd_reset_counter(data); + return err; } } --=20 2.47.3 From nobody Tue Jun 16 19:33:45 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78900377558; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; cv=none; b=QB3SO1/p4NiPs8plo7szDleBpOk7Bwelm3B75EKFLcpMdxgPHvcjXDX5ZM1wH032z/U9svDUv8LWdljkHfMEg8+1Nb4wH+zuWkn2XcISzKuoWlEEVELJWX7iTaSFmT+UQmFvA6TpO9Ig6+GFvQjVlT1ZP+Q+NISjO0gskY++lr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777475150; c=relaxed/simple; bh=1q2GA3CyxnnITMccp7VHbuyA4+x6gy/UvThi0EKBPeA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VtYjkjefoJ68Itke3VLvjasRe0yeI8hEMaYNp5oKnqRdXVIjte+TfKqwL8YId8QUSptjqZ3smREVQyho3aFLANX4Rj07vlN2PllVtxICrTpBP5Xakj8fvogTIETJczwCLbJsAxWZ0kYd3t5mO6SUi+TL5+MX3fgQOALfu8uwpao= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NppycUrq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NppycUrq" Received: by smtp.kernel.org (Postfix) with ESMTPS id 52DA8C2BCB8; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777475150; bh=1q2GA3CyxnnITMccp7VHbuyA4+x6gy/UvThi0EKBPeA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=NppycUrq3xzPTDVKIvgR3HYKPVZchMSBY6QE1fdXy69Vhz8ulIU6VQJjeEDc6jEXU 7OTWch4DdOJGhUfqgAVUYf8YdTz1sDa2Ehuv4/3v9P7lDxIEzg4SAbk7Xz0s1eZCPS A40YgK6sF7HkUOW6vTsooN4uBvGUkkAhAthzs2TATNcda+tTzIllaPoHnUF1ubw8sq RCo1PN9Oujart+rmGlWC5gUb+A/E11KSJypZCdiE99+G9dugmy+xc+6ezuwE/WWJEq bGwMpdWwuBS6b3CTHPte4m9V4xY9QyYiIYxx1ulvykPqOXJHbO642KnNBgPh5AN7L4 Dxv02t/JQ4C8w== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C513CD13D2; Wed, 29 Apr 2026 15:05:50 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Wed, 29 Apr 2026 17:04:56 +0200 Subject: [PATCH v3 8/8] iio: light: si1133: prevent race condition on timeout Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-si1133-checkup-v3-8-469f21d960eb@gmail.com> References: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> In-Reply-To: <20260429-si1133-checkup-v3-0-469f21d960eb@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1777475147; l=2620; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=wWxVBIcT+WefqGjm1JhnOezGW/VoQWaUnsiRF0Pw7XM=; b=1cs2SN0Jy9iDy6Ems50kETdSDCMgC3jQHCvmQfMN8cRZM1xUNCm7U60Dlp65Wi8zQ6T2B4BGg wds1Zv3R366CxQQJy9U/RP5Ub6jOGHwX43Apk9Eta1eMZc+fu9V4ZEP X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Joshua Crofts Sashiko reported a bug where the si1133_command exits on timeout without halting the sensor or masking the interrupt. If the sensor completes the command later, any subsequent command to the sensor will cause the IRQ handler to complete immediately, returning stale data to the driver all while the command hasn't finished yet, shifting all potential reads in the future. Fix this by masking the IRQ if wait_for_completion_timeout() fails. When initiating a new command, do a dummy read of the IRQ_STATUS register and turn the IRQ back on. Closes: https://sashiko.dev/#/message/20260428-si1133-checkup-v2-5-70ad14bf= efe2%40gmail.com Assisted-by: gemini:gemini-3.1-pro-preview Signed-off-by: Joshua Crofts Reported-by? --- drivers/iio/light/si1133.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c index 842a59bc68c20b3206e0c826f86c913f6c66bd7c..91c90f2873ae053eb7cbc8c9c79= ce6d91a1ec9dc 100644 --- a/drivers/iio/light/si1133.c +++ b/drivers/iio/light/si1133.c @@ -401,8 +401,14 @@ static int si1133_command(struct si1133_data *data, u8= cmd) =20 expected_seq =3D (data->rsp_seq + 1) & SI1133_MAX_CMD_CTR; =20 - if (cmd =3D=3D SI1133_CMD_FORCE) + if (cmd =3D=3D SI1133_CMD_FORCE) { + /* Flush pending IRQs from a previous timeout. */ + regmap_read(data->regmap, SI1133_REG_IRQ_STATUS, &resp); + regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, + SI1133_IRQ_CHANNEL_ENABLE); + reinit_completion(&data->completion); + } =20 err =3D regmap_write(data->regmap, SI1133_REG_COMMAND, cmd); if (err) { @@ -413,8 +419,13 @@ static int si1133_command(struct si1133_data *data, u8= cmd) =20 if (cmd =3D=3D SI1133_CMD_FORCE) { /* wait for irq */ - if (!wait_for_completion_timeout(&data->completion, timeout)) + if (!wait_for_completion_timeout(&data->completion, timeout)) { + /* Mask the IRQ to prevent delayed interrupt waking up + * any subsequent command. + */ + regmap_write(data->regmap, SI1133_REG_IRQ_ENABLE, 0); return -ETIMEDOUT; + } err =3D regmap_read(data->regmap, SI1133_REG_RESPONSE0, &resp); if (err) return err; @@ -431,8 +442,8 @@ static int si1133_command(struct si1133_data *data, u8 = cmd) "Failed to read command 0x%02x, ret=3D%d\n", cmd, err); /* - * reset counter on err to prevent sofware and hardware - * counters being out of sync + * Reset counter on err to prevent sofware and hardware + * counters being out of sync. */ si1133_cmd_reset_counter(data); =20 --=20 2.47.3