From nobody Tue Jun 16 19:37:18 2026 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 120DF1A6836 for ; Wed, 29 Apr 2026 12:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777464343; cv=none; b=f+MiM3iSpu+VJlk1OR1Z5hinDBDi2nz8Tw/0cN/EhAQpvvHA/bGeGdSqsDc0CkJJBDABpEIxBYBt92UMxgpaFg6w5Z/4oqyEdk/cOHjX2nN/s4/IUJXKue13YAOXHva6N5bkQVf8+J51JRmin/7n11ssBTmSlKkXwS9mhiSS2no= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777464343; c=relaxed/simple; bh=WNKveLwe2SxGX/tGhHqa5ppakcUcqAV/toIgMdutTw4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FPaw116YZ42gZPP5lKg8hkmll7irNKHzx43koMK/6KwcI1vDveh79cg8zvTu/0HpdU02Ag1VS4pxSabfRku/wM24/aesWReU1VFKFVugfurVZiK6k9xek4ormWtJGGIXDGFS8yllfadEhlJvYDy1nc7BU9FTW3SU2l+52NFvcag= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bpisHQ3u; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bpisHQ3u" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-2d8fa0fadfeso519420eec.1 for ; Wed, 29 Apr 2026 05:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777464341; x=1778069141; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=08a4NydfoQFXH4xmQj1qYBdax1uuuMmZbP5EuXBnZfQ=; b=bpisHQ3undGzZYf8AEs3wxEhsA3KyD7YEk5NzcbOVtZVbPG8YnUE+jw7835kPXpl6b aMDdGJkpvJbIPFbTXlTp17w3sEKZbwZCh5hdMMBobZFNaYWpGW2mb9p5kCAV6hhvernQ lVyK/PZHh+LFtOB5qaDByneL2r6nC1yGNZAPQ+SkLcAdzvA6D7FW7TpKV0Ce34Kw+RZF 4X1TyoKbQj3ibVT4f73ZafrKXKi9gWL8m7JXTB9fIhVomVs0sLHqO9StH+QzXQRWy6NS SFUINmBUj+v+yYy4h8s72kpuBWFt8a+eb78g/PwDYzHc288RvfOQTEU0QOzgfDjVY7w8 Q8XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777464341; x=1778069141; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=08a4NydfoQFXH4xmQj1qYBdax1uuuMmZbP5EuXBnZfQ=; b=SFLTT2MPDGWcYPmrdqYFr7ZYj3PGYu4K/q0A7FYXmQA6Q1d6a5nNLoWxog9PsWHQAL qVaSWXblFqRBTCpdAK2nFhX09g6/QVxZT9g6ASkK/TmTS0MXKS+lDEIrjjdevXA2eiIE yQmVR0ldOLf50Es89AOtGap+jpxyYhBHep1dHG7W2dbihN0wWYELnbu9R97H9AB2JtCo carlvJyZZ8AXQy9IDsUqbbUG2OeklEUgp+lTzPdUkgNainC0T0mJqJdEjgaH+SoCpJzd aKXKAyaMGlHRTzjC5JNrH/7P3GaLzydk6fn+kj2WeVonUKU7k7j4MN4Yhu6eggmsc7IQ lPdA== X-Forwarded-Encrypted: i=1; AFNElJ8ck5BrlkDoL7AMuGVPnMCBaH/UIvLilHPfjnbBwLQNIZ/aljBKBsH1Uz5G2FbCXSATPl+ZYw0DsHNa50o=@vger.kernel.org X-Gm-Message-State: AOJu0YwMpJvrTpwgU+WNduieMVZv8/rvKuvC6x/UGr7fUcDTyjaCp0Wd Nh9+S7T4XaGCjqlU1HxKEbnlNTojta47h4+jkqPeYYPTqheUeqRi1hHG X-Gm-Gg: AeBDiesQQp0sIgAzRef60rE/rnY8sHgkwzmeSRF3K5EpkPgbmhbpM96C9ZKWYTUlLDA eiiVaY/9KtDF+xifQzFTOk4ZzW8/F1M51oAss/TJ27DeiUBcn6LJMqLDipZOUkBQ0hXRH82OZnP +hgSUeVV6nVOLT9Qr+lFd5ys+V1VndSXH2z2ZaeA8jJTUxRkaPtLtRnm4s9ZtBOn2ZV5QujUGm8 49cVPWqqRmCqytezO5//D50V2oLqjXEzO7EU1dm4UyiHSoZNPh2Ga0/Ei/hwnOEsDDXx8rjuxjO SONOu5JSQiaENSRplZzl/c0mUfNQmNV0xqCIdGeMuoCpfP4wESLm5y3GKiOK7GC1KgnPm/jHDG+ 1T/awHp2Yy7snFYIKi0/xcxP7wiEtADwUZW0bvdSWnrxy8oPKIteBXIuCgHxheAkBFvSL8E7taL kRlDcoJS0SJRskpGRoEXknrczZL+l8oRgfUCicpaKwdPXfiuvRHstmxi1TkR2Eo4V9trM+AY3qL rt1DJXTF98y X-Received: by 2002:a05:7300:cd86:b0:2ea:d969:25e0 with SMTP id 5a478bee46e88-2ed1b3e92c1mr1060041eec.5.1777464341053; Wed, 29 Apr 2026 05:05:41 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-87.user3p.v-tal.net.br. [177.4.161.87]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ed1bf6d524sm1908745eec.3.2026.04.29.05.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2026 05:05:40 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Wed, 29 Apr 2026 09:05:31 -0300 Subject: [PATCH] ALSA: ac97: drop stale CMI9738 PCM-volume quirk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260429-ac97-cmi9738-pcm-volume-v1-1-d3f90cc00604@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQ6CMBBA0auQWTsJVgIdr2JYlOmgYyiQVogJ4 e4WXL7F/xskiSoJ7sUGUVZNOo0Z10sB/HLjU1B9NpjS1GVlCB1TgxyUmpvFmQOu07AEQUu26yv ryHgPuZ6j9Po9z4/277R0b+HPsYN9/wHwV/B7ewAAAA== X-Change-ID: 20260429-ac97-cmi9738-pcm-volume-898bf48a92dd To: Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1479; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=WNKveLwe2SxGX/tGhHqa5ppakcUcqAV/toIgMdutTw4=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJkfvwitXvVtgdISJcUMToVr3rvl12k/+llX7vDoSOeqK 3tfp7Me7ShlYRDjYpAVU2RZnbTIck/Xg6v1cSs8YOawMoEMYeDiFICJuG1kZDg8qfHCpsW+u45x 7Ze6XOv6K7s6t1rp6pHm1oqkeFZuRxFGho6Fi3tl/No9uD7vf8A99dntyOw//bIvr3FvPDGDc75 VHQsA X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 patch_cm9738() still carries an old comment claiming that CMI9738 has no PCM volume although AC97_PCM reacts, and then forces AC97_HAS_NO_PCM_VOL. The CMI9738 datasheet documents register 0x18 as "PCM Out Vol" with mute and left/right volume fields, so that old assumption is not justified. Remove the comment together with the no-PCM-volume override and let the generic AC97 mixer code probe AC97_PCM normally. It already checks the mute bit and the register's volume resolution before exposing controls. This change is intentionally limited to CMI9738. Signed-off-by: C=C3=A1ssio Gabriel --- sound/pci/ac97/ac97_patch.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c index 64cc39dd2008..5e9f70c47ed5 100644 --- a/sound/pci/ac97/ac97_patch.c +++ b/sound/pci/ac97/ac97_patch.c @@ -3002,9 +3002,6 @@ static const struct snd_ac97_build_ops patch_cm9738_o= ps =3D { static int patch_cm9738(struct snd_ac97 * ac97) { ac97->build_ops =3D &patch_cm9738_ops; - /* FIXME: can anyone confirm below? */ - /* CM9738 has no PCM volume although the register reacts */ - ac97->flags |=3D AC97_HAS_NO_PCM_VOL; snd_ac97_write_cache(ac97, AC97_PCM, 0x8000); =20 return 0; --- base-commit: 116ed8afab5e3217561a6a8bc4ca1c3d5d97830c change-id: 20260429-ac97-cmi9738-pcm-volume-898bf48a92dd Best regards, -- =20 C=C3=A1ssio Gabriel