From nobody Wed Jun 17 01:32:57 2026 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 044312D7DC8 for ; Tue, 28 Apr 2026 22:31:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777415479; cv=none; b=cQVLGCF5uX1kJtSFAoUQS4DLVNsfjUHhbRsWzRe5YxNH/GahSGl79yAgmfMH5272AWgMnoMU1g4ylMkF4qUPU2EQogoXqPWmRgZJOxsBcKGUefq1juabCDVsEjrj9TFJ8pJiSWWyz0zyql2u9bV4DAKnklFof9ZrigiPMeX8jEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777415479; c=relaxed/simple; bh=Afdookp9zil2VtHeQbBPiJ6JrqKRSbgNe+scVywFeJQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uvfrHmf9fLOd2InPqXH+3JbiJSC/JCGuw0cyh/dd+qu5REsqnIEf0daRMgIlrJWPIbmy5EfvpabFaFt/gJ74e/kTnR3tDbqk1oHkiZ4NkhbLoe5BNOC1Y+fD9t9yYt1hmuY/QcZhN0ftP630gnAFEkVlqdYSG2BIubBDUh9uAyw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rZNjp57y; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rZNjp57y" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-899a5db525cso91504036d6.3 for ; Tue, 28 Apr 2026 15:31:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777415477; x=1778020277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YY6FTulJBSPvlfGVmGfJuioC6VTkKeDBKn6rrD6zw1I=; b=rZNjp57yscktkgFUy8xNu/U7g1meWA8gFU8DzFfaVrNEh/UFhCeaCV8AeP/8O4DT2A HK61ZAij8FWUGANsd2LGZNd/sOzH5dGmlP+QxkwDzFCsvkzGpj3pUTrckAZis4ZBLVD/ e7jjwctama7txqzIU/eKIwr+xGSxR7VDbdGVap25H64Gnh/v1p0OndP0yjp3B7EwN+8g WTf6+U7vWD65Er5ps3pBzA8aLcgqr+FZdpTl+abemAjcoMAASNSKjk9Fjyi/R1yYR8Ii bSbI5IJU1eXz9T3p8JjYf65jSNTK/l5KCjZ0Aw/hXjVs3WpSiugkzQyabNEbd7IE7a4o zeUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777415477; x=1778020277; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YY6FTulJBSPvlfGVmGfJuioC6VTkKeDBKn6rrD6zw1I=; b=oyqfQikymDdxxHWQloIWlOQftcz8fc3I2sUFuGX2Ow0LfxaaH1ZWSxHE+Ej9EAcjz/ HhmAlA893+oCpOpPcrOykwApwhcckCrfTrurNEkrpSIapFPOuzpE4RFQR9lpj23HZkuH RNNsGSacIz3YIuSxC/6SOoCb6ThNIODNl1Qan/0srtr1a08sfvZCZBitEJT+DORUmRRq MN/c8Tsr9P4OijliW3x0IV2k9HmDR29yXka4f++MEI4qYDlQIlXdc7MR6BIeMsrDt/ai P5SujdzdhGxCRpGEUrQ5p/LwOavWT0SNPwzRqpoYNvvVnR6izXfpFqA8urUKOe153ZpF KqZA== X-Forwarded-Encrypted: i=1; AFNElJ+B2X0M19RPGhVtEvkMDdnk1xmw7R8AKwRP+Ed/GuYgbxgg2AwNo2hj/HEtwDKVx3Lrj4THGolulnjoJsU=@vger.kernel.org X-Gm-Message-State: AOJu0YwLHWJbjVk/BbV/Xr4TrxtPPm3oZDjixDQZejRNbVc7kjrKWQVl pB24mlqPHEA61z/rzwebieCRaFwJl7gS5FYh46l31UXkM/bdLd0S2LZL X-Gm-Gg: AeBDietfF/eB4gfbOISEo8+ep/B7t4F+onczFIN449NeqNfWR31AW+WgBgg1CHE1c14 QgCfQ++5ezaujCIytWv0ewoKvHPYOoSW4fXoYka2Czxp4n6OD00r4p5+AumD2K1mK6VqOPoogmX SfoV7UEFJdlQbxjDyk3zL7e/Pt1F5Pnyxsc90uHrI28BlHrX2LnOT66MShtHShjqszDVco6LBzv SGtC4MJYTifoAQ7/Rvl2KJNgOyUz7tVcrCgWjHMMjx2nBimvrGC+9FyIWVUWYcf6MRaK2MjfByn jGcvc2U6oKpLxCbmmBaDBCibVfZcAP/aNrsR2LPKIAiB5Mxe3+TPSIiYoEoI4NNPjFmBoUDTVxJ V649fDY1oxjDamy8As1TkAyVbElA/N6NMXKxIX5zCuaz9WRpHbnQK6DZcDQwa4N60Blehk3IqW7 mw25xFQuFclGr8y9vhcaqf4l8YPDaN8FM+HXCrnfHvlnz6aSl2DGNFmrWMqAFSdL6+k40iiKF+y LceZa6FFMknSqHU5ZCGp0ck3tEUMoy/TJmZ X-Received: by 2002:a05:6214:8119:b0:89f:97cc:b8d2 with SMTP id 6a1803df08f44-8b3edd30efcmr21727386d6.17.1777415476801; Tue, 28 Apr 2026 15:31:16 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d::8bd]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b3ef81f156sm2874916d6.37.2026.04.28.15.31.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 15:31:16 -0700 (PDT) From: Rosen Penev To: netdev@vger.kernel.org Cc: Claudiu Manoil , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next] net: gianfar: use alloc_ethdev_mqs Date: Tue, 28 Apr 2026 15:30:58 -0700 Message-ID: <20260428223058.113013-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From looking at git history, mqs was introduced after mq and after this code was written. Having said that, mqs can be used as there is already an RX queue variable in place. Not only that, mqs already sets the num_xx_queues members. No need to open code this. Signed-off-by: Rosen Penev --- drivers/net/ethernet/freescale/gianfar.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/etherne= t/freescale/gianfar.c index 3271de5844f8..7b47c7c49c08 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -669,7 +669,7 @@ static int gfar_of_init(struct platform_device *ofdev, = struct net_device **pdev) return -EINVAL; } =20 - *pdev =3D alloc_etherdev_mq(sizeof(*priv), num_tx_qs); + *pdev =3D alloc_etherdev_mqs(sizeof(*priv), num_tx_qs, num_rx_qs); dev =3D *pdev; if (NULL =3D=3D dev) return -ENOMEM; @@ -679,10 +679,6 @@ static int gfar_of_init(struct platform_device *ofdev,= struct net_device **pdev) =20 priv->mode =3D mode; =20 - priv->num_tx_queues =3D num_tx_qs; - netif_set_real_num_rx_queues(dev, num_rx_qs); - priv->num_rx_queues =3D num_rx_qs; - err =3D gfar_alloc_tx_queues(priv); if (err) goto tx_alloc_failed; --=20 2.54.0