From nobody Wed Jun 17 01:42:10 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75902609E3 for ; Tue, 28 Apr 2026 19:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777404190; cv=none; b=ssfTTRken1mfCDdrytYot4qxngCPfUGq1+MOA5rLCUi55BQ28P9jgZg+QljT3axfh28aF1rVDnwCzKyxYBmkO8eESrAm6PUFCGqVxAi15mzSDRjCVuO9h0XCUzpI98M5c5eKPAsuxLmDKjGjuHghSw1vFnstsN+P6CWXXm3kUaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777404190; c=relaxed/simple; bh=3ZbE5hn1FKWp4uyDf/VqWOhsipf2DuR3eyZUn9plDbk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=EC7liC47wVdakgc5Po/AZoB3EEw2etOlUfalCoGugWGgfI4DjTzKFp/UfYkJkbw1ODNGJn/3RGdcThSV/SlMtjC2vuOQrXMC9qF6Sofejs/39rikcLVn5BIaewbIDQ0k248kSGmTDYrh/xLkExRynb8IYpxaWsNGPa7udw63QgQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=xe4hSwEK; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="xe4hSwEK" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4891b0786beso85316125e9.1 for ; Tue, 28 Apr 2026 12:23:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1777404186; x=1778008986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=buwfV7nzrBAN1kj2Pp8gFNe2wiVV0p+sFgaZu6iecRY=; b=xe4hSwEKRAqQ1+jdFqMwfDSQ2ndSTcxIen2DXXERZqjq7uBh78oDB1j1ASw8b6fEl4 jbNBGjBcoZpyKO2N6wce/JFgMWETVENi1y/RdeWeDaP4CsRW69QlyvF231Ph3dINipd9 FOufVmc/UiS3bH8radOPXL2LaoLDsF4UvO+V0oMxFD64n2CrsHYjTmc2yfRKbHuPTfWq YrAHvAW9wjS7tWl8hLF1785U/0TuTNXgsfctNsllx6DVArQmcGBia2jfj8pC0dHJ4Rw8 5FBqlZXFLJ+3N9H22sukdIGTdY2DXktV4tH5MeomqXu9a+J/EbJ5rx6QM4FNk2Ngi9cx /BPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777404186; x=1778008986; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=buwfV7nzrBAN1kj2Pp8gFNe2wiVV0p+sFgaZu6iecRY=; b=Gf8fv5SvyS0pfso9qvjThAhS72OF9GBEGQbt2VlEcOZB/KI89DsOddDAcuOvJu/oOy lFr6h+wXsEWtac9ykf1HTyqfVLgTQLV80iuLKTLtXHaJ1ojDgT/wb/1LSMUbVDxZlFPX Nu16Q8BDTTkdyiQrOOhW7ekfCDpV7HHP4ZoO8QOj9lC8A72tUIuwG0dJmTH11Zd8sem0 5CIzC8n611WqHKBuXZQc9K7gYEcI25yzZ2sqCVHU+mo/391au7Vo0qYRxalqm56nrULp nNxokbpzdhUX3KQIboDGO4nFx9aqGKPgdE0igvWp2KILps2LuHWdAZWEBfGQYEuNxI3J gT5w== X-Forwarded-Encrypted: i=1; AFNElJ927Q0Xk08HUR6/WQKeVAxG4UXfe6/7YAYZdW9utf8JmD9oJFoE8LZUnQP8qkfj8I0BUP3L9+pX3A9ee8w=@vger.kernel.org X-Gm-Message-State: AOJu0YznPRc9e6gzLC1EXAfK3c0xkHg2h+Z7PGOHvlZ4lkbBRTScxjcw uOyWoTO/hHtQvK26mcKqqVKfgxZAIZ2sqWolqyslny06S0txGwjfajP5OfkE6aEXmgc= X-Gm-Gg: AeBDievPRJ7Y21R6yvLRxQoTH0XsbvGfQWcdMfQ0f8S00968VvPSh7yioDkPUrU9J2R gInfiVAtLpkGcfk2AKWFR+g95Ya6pqDubDoS1ck6/z1NjOleZGERJzCQlzRXXU3F1dF6bq+sG0h hOKyTaycaPfeeFjSMJfPxuE9B4NdH+s8CA4xAvZB6LY/9fXSYEgECFHO3kBSzpqXiLsMmbY0L7k APj/oO4zauY39qz80bGGxVwfSbgg4mJltkOiuEjTPyo6fSixu/+wilBA2q4KX6mmsYJt+BKe51P UfibF47xP2P2fA9eC4CgaXqcWIPXOtYYBRU2nh9SIieGvpA8Qgv0ltEsvOmfzPyZHqcIhGMS82w V/bj4gohcwSTeKFTiJ1sK39pa0dHiMskcnRS9AUriju0m+96KnieB25NqiXbdqx3hB1BUbS1q1X t+I4fpcuzF5NoC9jfr4uudl0j7kHCdqI5T5d4DbDlE0Khkj2GiYA== X-Received: by 2002:a05:6000:2311:b0:43f:e791:a347 with SMTP id ffacd0b85a97d-44790191cfamr987888f8f.26.1777404186059; Tue, 28 Apr 2026 12:23:06 -0700 (PDT) Received: from localhost ([2a02:8071:b783:6940:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-447b7ca64ffsm8837f8f.37.2026.04.28.12.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 12:23:05 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: Liam Girdwood , Mark Brown , Kuninori Morimoto , Charles Keepax , Ola Lilja Cc: "Christian A. Ehrhardt" , "Christian A. Ehrhardt" , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: codecs: ab8500: Fix casting of private data Date: Tue, 28 Apr 2026 21:22:49 +0200 Message-ID: <20260428192255.2294705-2-u.kleine-koenig@baylibre.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2019; i=u.kleine-koenig@baylibre.com; h=from:subject; bh=4IHduTTlrzqZxMDlbKfFyIRuKuk5kBrb2i3V9qd7Lhk=; b=owGbwMvMwMXY3/A7olbonx/jabUkhsyPnPxf9f4W9Tax2ls477Q/aHnTweJnzQcOk107uwr7M vc9LLvUyWjMwsDIxSArpshi37gm06pKLrJz7b/LMINYmUCmMHBxCsBFnNn/1yaEi19TrLbkPHPZ xCkj3dymZW3B4tmWPxVM/wsVWh5e4/vo4Nxe46NH+ZfcF5d8ecmIz2fmpWtPixuyvwTk+XAYbPE Xu/as3eSdSbq7uVfcH2a9MH3WlvyjNblBUeapqqmfwzQW6/4zLfRQ2X3TeMd2nRtHqky/5gYpfF xQs3W1vqQvq7L7JYFbcaEfbWLrbF9ZFpveOH1lq+dGBb/rR9rtbFX615vwqYeWFW9tUL+15Mo85 p+idaEpGfumcr4yX3op6+1LXUmPEMEQdcaovBdb1pysDmhPmO9suUSZMfogk1j5z8/ZfCGPF315 M1Hjf9nv7tD5XvbloaWtnwzf2a4N0Juv/qeZ95xCLAA= X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable From: "Christian A. Ehrhardt" ab8500_filter_controls[i].private_value is initialized using .private_value =3D (unsigned long)&(struct filter_control) {.count =3D xcount, .min =3D xmin, .max =3D xmax} thus it's a pointer to a struct filter_control casted to unsigned long. So to get back that pointer .private_data must be cast back, not its address. Fixes: 679d7abdc754 ("ASoC: codecs: Add AB8500 codec-driver") Signed-off-by: Christian A. Ehrhardt Signed-off-by: Uwe Kleine-K=C3=B6nig (The Capable Hub) --- Hello, note this is untested on actual hardware and was found by Christian using clang-tidy and code inspection. I'm a bit irritated how/if that driver was = used since it was introduced into v3.6-rc1 in 2012. Maybe this is a hint that the driver is unused? Best regards Uwe sound/soc/codecs/ab8500-codec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/ab8500-codec.c b/sound/soc/codecs/ab8500-code= c.c index fdda1b747bf7..8ab2e60f80b4 100644 --- a/sound/soc/codecs/ab8500-codec.c +++ b/sound/soc/codecs/ab8500-codec.c @@ -2496,13 +2496,13 @@ static int ab8500_codec_probe(struct snd_soc_compon= ent *component) return status; } fc =3D (struct filter_control *) - &ab8500_filter_controls[AB8500_FILTER_ANC_FIR].private_value; + ab8500_filter_controls[AB8500_FILTER_ANC_FIR].private_value; drvdata->anc_fir_values =3D (long *)fc->value; fc =3D (struct filter_control *) - &ab8500_filter_controls[AB8500_FILTER_ANC_IIR].private_value; + ab8500_filter_controls[AB8500_FILTER_ANC_IIR].private_value; drvdata->anc_iir_values =3D (long *)fc->value; fc =3D (struct filter_control *) - &ab8500_filter_controls[AB8500_FILTER_SID_FIR].private_value; + ab8500_filter_controls[AB8500_FILTER_SID_FIR].private_value; drvdata->sid_fir_values =3D (long *)fc->value; =20 snd_soc_dapm_disable_pin(dapm, "ANC Configure Input"); base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 --=20 2.47.3