From nobody Wed Jun 17 02:50:55 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010060.outbound.protection.outlook.com [52.101.85.60]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E165A428472 for ; Tue, 28 Apr 2026 14:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.60 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387460; cv=fail; b=iPiWN1kgOQRvWmc0DDwNj3DZdO5LNrZIIl34ezYpCuWShIme6zycNVeLOo5imawzWHZfFUEX7qRwnhqk0yFejndTuwgPcft0yAI2NNMhFU1qw7Tw1DhhP9dQyzDYiazz6pcYZTnhV/4E0O+MMrtqsgcuAtTV2XWkrHnTR8DCwZg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387460; c=relaxed/simple; bh=vAL/9tHqlGcCc08nIKCvrpJuU9vrbKPHGXAXawVAxZI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=UgIOaWirf1dark5gJnyIJ0zOxtKUQF624/IuEJdJ5erB6gYwCYu2nYY/4sWL70MXxmYovVYjuAMzL+JGZ3PSxWQhH0clxd5mPRuxSpP3QQylaTnQPc6jLnPOQI8Gv8Z/woKIRTPeuAEP/MqoNJj9aRhiZu1TVgwztrFIawrT2fo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dmMNEKj7; arc=fail smtp.client-ip=52.101.85.60 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dmMNEKj7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=erQagVifQ5HRmRh6pyGz3qVKBzBr7nuhTGyw1sK/yGn8qJlg12GkyGn3jFb31QPu7oeNw4LNkfbqU/HcmHAL5QaxQZurjos35ZXzlo6I4EWPXRKaFOmPy5xg1D3f3CDbUMe9Ogs3HImNj42PGlgNq913E0S98FZjehUEXF0VYAXjYCWWPcWW9MEvlSfg4GmWC6lnACcYv+Pv8Co4dVpDdN/drnJuT6fwPlH9fOUJpRMR2A8pozsTk8pTeiroy4GtsMrGlZAuhGURp2pmayAmOuBEs4rorQDGZVKw4MN7iTHrBt/9Gg75qf3rZpAHtKb3fEelOfXZUORUUOJVUAZbIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wDyRiWwcDjm9YcG5z2ke52Q7YNSpc/mlVRVL6rJOD7M=; b=LmsFJNtbqAMxFmXySL0lzVo5Iv6HOcF9TBKqS2hWnajobm+WlOVDSrx0TyfBUsxTZEMkG7XfncGYvjYhiHoNkfjHK8YrbN264hLSjNS++zo3XSk59ICxEWx88drJm1ErSlfX9fFsGLhNievytG2jKWTSHgOkINgMfP+x2nDy0RhT3Z5iWyadkH3Sg2WSm20yqoiA34u3MKJh1gZ3V8gHtlEsea+VadToT+APw7UoOHoR4mQa+qhdmbNW/uabztyoklZ6bhbBKO6EVpKMhj+fJqqV0clBAJwWniSlxh+A8hWvUs63zyo/TW8dkzzTcw2GgA9s8zrqz+m3k39u+OtWeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wDyRiWwcDjm9YcG5z2ke52Q7YNSpc/mlVRVL6rJOD7M=; b=dmMNEKj7vEWnPT6NUYzSCpBCxv8MK4AiBskXzyn5MdaIBZkCZo02etN76U5bG4mkUThhjnHfeVKr61Aoc8lo63/zL5Rw/miUK+Y8Q9enjRaOqMyNmyAMPNxjkNHY6wjxg6UeHhcuJZBbVO1J+FFMlmkzr3YwXtiYUqENxwWeKZyM9KybSuIRz71lHR1zA5pX5JqJT50J8AzE6ZteQpqbbzl8ze2E3iPBEflPjTyEd0JhvCT4jXoW7t0CeA2odQK9soiiTOM9id7EVJNeGnwiJURd7ZfVx5bfnkBKId7gn4tyhTcz+Q66fxWODFlQJfdEOmgNHVq5FQ2BiVm8OdOlrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by IA1PR12MB6211.namprd12.prod.outlook.com (2603:10b6:208:3e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr 2026 14:44:09 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026 14:44:09 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: [PATCH 1/5] sched/fair: Drop redundant RCU read lock in NOHZ kick path Date: Tue, 28 Apr 2026 16:41:07 +0200 Message-ID: <20260428144352.3575863-2-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428144352.3575863-1-arighi@nvidia.com> References: <20260428144352.3575863-1-arighi@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BYAPR11CA0081.namprd11.prod.outlook.com (2603:10b6:a03:f4::22) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|IA1PR12MB6211:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a5cba2b-963c-4693-620a-08dea5349b05 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: qcWFXyfG03fQC9v/Vcsft3eceLqNMnjbKsRfbw3va9gjj2g7WEczUDXDODKlp/pneWhEyQqeUap85z+D0XK1RCm0VkqhiLbc6caFKVu/cMiiMpZ5DNIdSwtmEuHkbqJ46NY2Ly2Kj9VKDiW/u3is2otoNjR/iS2mnvUN+G+1nfjWvhjdYYzgQOF16kj44vqXdkYsBKYAe0/Pxp0UkOmNC8OlUNqRz3JQ5rAjZcsh3OsGI3YabG/XgfwXJoEOiMPYBMjWy6LNn7eYZfew3GQC4a86rojRgDKJVLAYgoPsgAdxQhLfSzMPL7dLafS7VlAiBd/A9MoMDt0JVp6Wc+AodEQYMJj0oJiVFBc+L3hy7thSsw7R9bmFjd7UiT+odkr5myvwL3Xlb80akF0/OF+ZTsgU2CNHBtBI3cLF0BNv6uBtAR/cXHPTLtpr+iZQPnVuJrYdrc8JawAM0iKOrnTtnE+zzqEkNM4vETctUsjWcSyH67EqQKUF6lSaL6YQVRuxXRqMKGA+BAbzRgbzQ5hgr9Ayu7eSbBKKiWUXZfl/AM6ACfI6VwBqeCBvIlgzk7dG3eZdoSU128dL6B1MSBAsrBHn/DzzeQq8NqNIKW1wBvaQfYNX/DvvYkEMGicQ+lm2BXInHEgNT9Nw2rF+b/92+7NAYnV5jpOOLGtqzWr97mIb8W5/nDeqkgVyEYfEXU9cCh1m2K3fWf01DkihBun+RBfKdGqHeezWRx/QzlSQzIE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eeXxhrip5h0kLtP5lcyr2iSAzddxgFMA0keofo20VcTY9uKHpoc6A8X/fh5T?= =?us-ascii?Q?0b2rlV11c/uhcK9onN81BOUjfu71DUfyLG0hqWP1m/IyG8LpZOUdVNubJ1GY?= =?us-ascii?Q?fB/S2vLcHnHAe98CdwGWygJWkzlgoAwz7eYRsxbGVN9KlDMflP/dmuESGcDv?= =?us-ascii?Q?2v1zwQnusrWvfhVfNCi4nrElAUj3QCLjC6Q4uI1BO1kUdXypyOCWZaCOJm1j?= =?us-ascii?Q?u/oXBuk8vq9Xlo7Ge4DgMU3Zk8p8L6UyV+NRt4EebNwG5mjcpAYMbF4e32Hr?= =?us-ascii?Q?1LnXGQiTHcVe/vWbq4RaE3AotSpBm2D7m4kSsdCuh7cL2q1Lh2bV4olyCJMt?= =?us-ascii?Q?BM/3LMRnanPmGAgf0em0WndJwGHW1n0OVaJw/cX2Nj/YG4aN7e297/HJTwtP?= =?us-ascii?Q?qKTLm3CAwo2mfiGWGuUuwhr/6/5T+DUm21vnFXFcsI0ISn1A1vt536oowMd5?= =?us-ascii?Q?JiJQ5JUbXk393b7lK1CxTzIuyPLYD+tVxIXYYNIdoJj/U/w4PIj90ZnCkPnD?= =?us-ascii?Q?v4I0w6/tW78sTBBkgq9/TX6OkZghWZGmTzJFwGPcpWLIGt1ieIY/ELFZLKR/?= =?us-ascii?Q?IxGB30YI4eukYTFPyE7eglzo80V0+uu7aPSx+oKWqSP9lRMuxc+zSe8P4J57?= =?us-ascii?Q?k8jp+w2+nvIlppIKU0pIET+DWyX7Td6DKBAMJTL/hnT9O3QJyrfIDmhZJVyo?= =?us-ascii?Q?UWzMEWqgM1M0W9gldahROw0VG3emrOnM00tZJm9A5bDvJnxOjTtslkCAmOD+?= =?us-ascii?Q?lgdgAcsrLQKe8E2NYtvK712QRx5VJ45P3eM/S+5cjwxc19mnelkKqhuVV+fP?= =?us-ascii?Q?6I9v3qKCXOBimJs/NTSSQJpWBd/L4hWy6xzYBNOO/RzJPOWIRpUwW64RHin2?= =?us-ascii?Q?lb2H/VbcDOjaC881xN8G/m8kW+tRkNbGup9FCVk5AeNxLaC9p3amle2D/PlL?= =?us-ascii?Q?wOcktPRsB13Dba6ttN1whDxXlrJdptFNfi5yxIno89XT8herhfo8cer6Neqc?= =?us-ascii?Q?KsfaehJUT0l7ys9SVVKp0mg1oFtEk/hsJCvM25PcNguoOJ8KPnZrl3miDXCu?= =?us-ascii?Q?2FryjwFrMO6nUtub2BYJxtBCtZqefO++1rxLHFfT7NU9VMyMydfm0HG59v88?= =?us-ascii?Q?CLe64zG4EA0cMOe7Vtcn5gI1OHO14Ld7JtKGRUnIVIbZ1VZgjkpDhUjN3sGz?= =?us-ascii?Q?i6H8SUYTqptCMa6f0gLGWzMJ3zkh4Ubr5L5eh6Ax8UD0/PH+MAPyWAnvGQcu?= =?us-ascii?Q?sipeHh1pStHAdrp8W6Gxo+ZNSVtUGv1BN+IFS0LBQkUNb6oMY6iKNYEB8lxN?= =?us-ascii?Q?Jd2XmoHYjQlQ749SsjS8ZI7UzBz8E2ZyfsmHR6JDv16DnYJ0FZQj4Cls9eTn?= =?us-ascii?Q?GvSM8l3tfFZedLoCTgsHF9HUKF0TXwD2r+p8/31tzJJUI2xIU/zsxjLwYuJj?= =?us-ascii?Q?ks0TwBgHjZF8YMptMe5sqyYJXTY0PelgBdStZAz3gpoCMXgDej0tX/zWHcaL?= =?us-ascii?Q?v6XDPjtPHwe2YE1iyLy2kNR2mSGMBEDYZwnQAVxT4zrX03uUOxwMmpEHCZWo?= =?us-ascii?Q?6KY0klKWbLHsx3Yt7VfBIYMdoeueEFLezWZ1qzjGR1NNCLTZj95HA0FokbfI?= =?us-ascii?Q?YI8NHthHFdrRp10gCI5ofMIb2A99b0KZpmwbrZ6aNunpZwh6cDnKqfrAopqv?= =?us-ascii?Q?8XdQaaHGnFbEx6y4abhqROgsUvUbU9yO0yYwWxmbbE2FvB/6KyDTsxQ+V8HL?= =?us-ascii?Q?4GETkMHZ9A=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5cba2b-963c-4693-620a-08dea5349b05 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 14:44:09.2763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jaP33jBWaW6KTJDtW8psSQdHEoeM+L6+qcs/1b9Np+Jvi9ZqZTRGBjKzq9ZQLSYoEY9muL4gOynmVuB9/aEexw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6211 Content-Type: text/plain; charset="utf-8" nohz_balancer_kick() is reached from sched_balance_trigger(), which is called from sched_tick(). sched_tick() runs with IRQs disabled, so the additional rcu_read_lock/unlock() used around sched_domain accesses in this path is redundant. Rely on the existing IRQ-disabled context (and the rcu_dereference_all() checking) instead. No functional change intended. Suggested-by: K Prateek Nayak Signed-off-by: Andrea Righi Reviewed-by: K Prateek Nayak --- kernel/sched/fair.c | 40 ++++++++++++---------------------------- 1 file changed, 12 insertions(+), 28 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 69361c63353ad..e0f75dedc8456 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -12749,8 +12749,6 @@ static void nohz_balancer_kick(struct rq *rq) goto out; } =20 - rcu_read_lock(); - sd =3D rcu_dereference_all(rq->sd); if (sd) { /* @@ -12758,8 +12756,8 @@ static void nohz_balancer_kick(struct rq *rq) * capacity, kick the ILB to see if there's a better CPU to run on: */ if (rq->cfs.h_nr_runnable >=3D 1 && check_cpu_capacity(rq, sd)) { - flags =3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; - goto unlock; + flags |=3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; + goto out; } } =20 @@ -12775,8 +12773,8 @@ static void nohz_balancer_kick(struct rq *rq) */ for_each_cpu_and(i, sched_domain_span(sd), nohz.idle_cpus_mask) { if (sched_asym(sd, i, cpu)) { - flags =3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; - goto unlock; + flags |=3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; + goto out; } } } @@ -12787,10 +12785,8 @@ static void nohz_balancer_kick(struct rq *rq) * When ASYM_CPUCAPACITY; see if there's a higher capacity CPU * to run the misfit task on. */ - if (check_misfit_status(rq)) { - flags =3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; - goto unlock; - } + if (check_misfit_status(rq)) + flags |=3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; =20 /* * For asymmetric systems, we do not want to nicely balance @@ -12799,10 +12795,10 @@ static void nohz_balancer_kick(struct rq *rq) * * Skip the LLC logic because it's not relevant in that case. */ - goto unlock; + goto out; } =20 - sds =3D rcu_dereference_all(per_cpu(sd_llc_shared, cpu)); + sds =3D rcu_dereference_all(per_cpu(sd_balance_shared, cpu)); if (sds) { /* * If there is an imbalance between LLC domains (IOW we could @@ -12814,13 +12810,9 @@ static void nohz_balancer_kick(struct rq *rq) * like this LLC domain has tasks we could move. */ nr_busy =3D atomic_read(&sds->nr_busy_cpus); - if (nr_busy > 1) { - flags =3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; - goto unlock; - } + if (nr_busy > 1) + flags |=3D NOHZ_STATS_KICK | NOHZ_BALANCE_KICK; } -unlock: - rcu_read_unlock(); out: if (READ_ONCE(nohz.needs_update)) flags |=3D NOHZ_NEXT_KICK; @@ -12832,17 +12824,13 @@ static void nohz_balancer_kick(struct rq *rq) static void set_cpu_sd_state_busy(int cpu) { struct sched_domain *sd; - - rcu_read_lock(); sd =3D rcu_dereference_all(per_cpu(sd_llc, cpu)); =20 if (!sd || !sd->nohz_idle) - goto unlock; + return; sd->nohz_idle =3D 0; =20 atomic_inc(&sd->shared->nr_busy_cpus); -unlock: - rcu_read_unlock(); } =20 void nohz_balance_exit_idle(struct rq *rq) @@ -12861,17 +12849,13 @@ void nohz_balance_exit_idle(struct rq *rq) static void set_cpu_sd_state_idle(int cpu) { struct sched_domain *sd; - - rcu_read_lock(); sd =3D rcu_dereference_all(per_cpu(sd_llc, cpu)); =20 if (!sd || sd->nohz_idle) - goto unlock; + return; sd->nohz_idle =3D 1; =20 atomic_dec(&sd->shared->nr_busy_cpus); -unlock: - rcu_read_unlock(); } =20 /* --=20 2.54.0 From nobody Wed Jun 17 02:50:55 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010031.outbound.protection.outlook.com [52.101.56.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5628D38F638 for ; Tue, 28 Apr 2026 14:44:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387470; cv=fail; b=qBMih/T64wVEmRmtnOFx1ZVUSCKCFlVUGH60ZOvzadiRnepfG7+uJaX7S63dYWweMK40EFq5odpThYN2Fq+9eKok6KcWes6nX/mIpiMEAV9L4IvD4eYNjbO2k7/Lm+aE3G+wR+/0L+4ZCuHjF+OO9yj5AQugY7UU94tPBmDk/As= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387470; c=relaxed/simple; bh=WKnNhqSNEdXkfx5f0KL0VsFtBYQCHaNWCBZAuMjmB1M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=BDZi8EUYFkzrBG8NrE8VqP0Tmzoye9xoUyON27k/t7tZNUHLY8MuLNbnafxrLfW9zb52XbPFo1SC6H4+Qxn0CsjuwpY4v9Uad9chYR3V7O0lJlp0OFY0WlRV2vRTBlPFXcIVq5Vci2rfwWdzI9bh/TNa6WX3zigDJaovsLOmPig= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=G4v/Jkim; arc=fail smtp.client-ip=52.101.56.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="G4v/Jkim" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Jb7nc9JF1CqjIWP11hFad2jnifCTe6kqtGi1C3e2aFeRGCXJYbIUJzW8trnyLfRlK6Tei6vMhW06ZzAvvO/U4FLpTJ8Sc9NxQSbr2vPefxDp2P2IeXoejegizrUBEOhsFnLIDdxQOACJ6CoaNfRnKJmA3hlASRFrjdLwonqxsN2m3jaOVfVzYFyUQGUoqdeIp61ZhlT0WXeCONOmpez8o+Xl6BLvWaLGOmvl0VTwLbh0l/qJiDgGE1gbmle9PnGtrVUL4FCF7Ba7kHxd/cVNuVh/c7GmtNQHghlP72zKIqZqFQ+OCwHzyjXtNuZ9+ebffWAMFPneVH44PBVpJwFjHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TZ3mPHBb7EEa3Svg04LKeZlqIzLx+WMAH30C7/HvALA=; b=WHwPI3AdxLAIL/6W03ZGevi7k7f8ZhTrA1O6lv1GGgKhaVh3zVQMe66Sk+6umVv2Jc3ff5Ltueb3hDQ83tP1uCpa2/yWGHHPUomFjXgJgVr19l7kQJ8LSUOVCpWeCYPOfxhNkmyHuywx8O42G2dSl7iD388xvuHvmRIVzGyPwvxv0ijPjcknT4zjm2QQ/TcOJu9TQSO9FNGF714Kp4vmN6GTESrvDqu/60sWDKnCWE2xyRCc5gMXCFUMXqN+3tlvvghkZ7Ut1rl3EwJzO3yhvxQFTqNQFZPxOL1okjbYvcFOXT5dmHoptVW3sHvv9mPVvELlrcl70q4P3ggJGi8Nxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TZ3mPHBb7EEa3Svg04LKeZlqIzLx+WMAH30C7/HvALA=; b=G4v/JkimiMX7VXNFGIBiCfzX1G2ws711uuKeKJIs8mW9eoeQDGN8QtabDdaJShN4mIPiCLV6dHtXfl35ulk9lS1T7baBuRvKKggpgHFPtNJfPZI/Rp9JxP9f/UVacfsks0RwsPdhzS7sBIZdz7Jef9+EJUA1lGjArRnXlerdN8CJv35VzsMz/YdWuvBKGKEgmOcuKR2MUD39vNievD/WBiG2kN8ONCndHgW+G9azXPWiVUXjQLHMvDWMMNlhCmgbVWArtORyC4GLopd8cOmVW6IWpe/CwFFJq7+IW21Our25Si8Jq3FlnYmkKJIhokh4pnmIRGYZQv4rPB3D7TlMSQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by IA1PR12MB6211.namprd12.prod.outlook.com (2603:10b6:208:3e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr 2026 14:44:18 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026 14:44:18 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: [PATCH 2/5] sched/fair: Attach sched_domain_shared to sd_asym_cpucapacity Date: Tue, 28 Apr 2026 16:41:08 +0200 Message-ID: <20260428144352.3575863-3-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428144352.3575863-1-arighi@nvidia.com> References: <20260428144352.3575863-1-arighi@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MI1P293CA0022.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::19) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|IA1PR12MB6211:EE_ X-MS-Office365-Filtering-Correlation-Id: 169f5767-303f-4f10-25cd-08dea534a083 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: 8tHH3iB0kqPWFHj5JBNZ9X2GvJp/YAKeyTcw4Ew/w+xfooiRG1SUsJDFbpxcfxjorkih6zSJ+m61wTqXF1Oh5wIbVThjXGfhdRTcdZdvRYcCa1MNPw5tWk/IZnNWdSsDgKXh2yv0655EJbNZbKmca6+wbB31BThz56c3d5LGPTNl3gQehpRW1CVSHi2W6wu5HjqGwK+fJooYTBbQA8uTZAsR+jFGX/wfdMsKNxUm920kc1QIY3vMBpqh7GAzr77sFXYxaPllwcjw0JzhQ+59DIJqFQyldL6eazABG93tzVESRPyQLv4qElRaT0IX/N5/er3MDxvsvBTQj7mBJb1ZxXLZVgtfkQlmQUYivAhec9j2mLZL+nKfmSwLANg6e7o+7O8BKgFUFfPwZ02U28EFtNzTqlcyAzcn/lTI21scZEqVye5Su+M6HYupCcP4cm0kCY30OXG0x6lB1kZWjwg3WC4FabHpx5oj2gRUs/nZy4Iu8qwlSDKioP3VTto45TmAT1rnOp5b8eKK+eWuDnel49uju3xKzrP9PuIPugeBI2xFy4KD2V7DEovnOPTXE9wn+3lBqDstokZklmQGGS9dmuC3GrW3z5GlnGncLG+DPDuPBY61ufvRfB70ItTQECDrXxzWxNpoQF65voOhVgmvsN3+776ZiPkt0qbi4Zofss+4mkPjCOO8GV7tQlHfG+xn7bKyKp5DGbjP9zVWhEiV/BzfJUSXle+yLXB5uPS8gUE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e2bXpXiriFqysC4dkwzy6iunUkmun98fB4EUIIUbsJ9hl1TwL6dHgV18Uckn?= =?us-ascii?Q?6/6QtVThssrQ3/rUmEhBDIxJP47ajvrHAaz1AO5zjG1d5Z515eMO1+VOgUXI?= =?us-ascii?Q?tT4eWxIkKmKvowxmgGtWbXowAEYnHY7QYI2XgG/H7E9HHtrH0U0lN3iFMnMS?= =?us-ascii?Q?J3Lp5gEKP7yURE2JqvAYm07bpRu6d4w2cVYkPyv3K/DIjEejJ1Pj4UIz3/Is?= =?us-ascii?Q?UxjviGEXg2dK5qgIFGhQjDiP9MgFrL0h9inXhE8lEc0YWhULkAPyVjDaFGR5?= =?us-ascii?Q?wRUgBfP7Sm7o6Hxbk4eovG1w8uf+sMRcBI8VDgCX4tx6ynFrqpSIy3YwdTDb?= =?us-ascii?Q?W7Uq2yaZ8UtYBnjmvfj32jHxA11oEpc/WDumHQd8bnpuefnPbieHPAaXIpYP?= =?us-ascii?Q?2GBZJ8KHrP1ZnM1bqyxNIkPnmc0wfOQBPDkR09ZizPpBSKOw3YgVUmBMu7TT?= =?us-ascii?Q?WttuPkAJOOZVEaaV2YC8+PmaTbMSw1zhHDEkkyMbCz4OJRNy3nvaZ7eyOP6b?= =?us-ascii?Q?345oipWc2ArGMaZ4CZofi6BeCRXd0XSoX8Ka0M1gSpq6tJ4YxG6L91QO1Lfn?= =?us-ascii?Q?e5xsQEKFsbozwrscLWsXcunfl0xNS8zYnFcSPwquCdUHUOIu/In17439FV4J?= =?us-ascii?Q?KVKYZF2QLdP1w4xM0HdyXb/b85WRx7H5v9ZbjwccHBCjJvfZSu4HrGW5gq+T?= =?us-ascii?Q?w141w7G0TH9gBI7MtZ0fBNGrzzFuUzVbty888EO/JKJOiTQ2rlRryrwGSprJ?= =?us-ascii?Q?rHMzJos/3tMWe3oVYqEpGyukUJ2cJlaQNY9gSwlj009kqFEOURux9uyy3ECx?= =?us-ascii?Q?+Dmvd9g9DXRUBFamR5FsWOwYPRZp4VLdcIXz5AQapzLvGNnAm1Zwu+Vh5dRQ?= =?us-ascii?Q?XyDkxY7lkQWs8eZ+UINrcOiQrpOyqhuS4i+/oituLa7eGvfy3/nei0a5G7Xv?= =?us-ascii?Q?x3nEa+LyhBgfjYcrM5Cs5N+LhasbVGAdn+vW2CDAP+XIs+7tQlpYWKvfYAnN?= =?us-ascii?Q?TpD7FV6kcJZUKgthYZQyd8bsKPeZx5yJb3rCMrxeJJylPIUU5cwM1gr9XDGX?= =?us-ascii?Q?A8cpgrZNfHhHAQWuh4gOKV0wDgLvA9iweLG99XbaNABIMC2P+dfeyKdLpepU?= =?us-ascii?Q?GKuo8pYnun0l2Ukc/Uh6rQefLPfbt6+MHWzymHYezM5QsQIS6kApA50+YXvt?= =?us-ascii?Q?kYLXp3EyiuRv1Ay5XsgZPhZocS2JCYGNUDW+YexLf79PCsVm/v/s5QuYW/Gy?= =?us-ascii?Q?LbXMFG1fA6XPjwsqhUNQ+Qswgq4vMutmQj4Xw0AC7WF79ERcpZeUO6P6ohVC?= =?us-ascii?Q?46jXrpEYKt6uFEMyENAwEBIJ7wIqD4Cu3XSjBELG0NTdDVDyvP+Ao967BsAR?= =?us-ascii?Q?n3cCF3tyBlyMxnMXWAmtmyr9U/dQkiqoQdMmQRO9kUjSogx9f61PZfMnJ9wW?= =?us-ascii?Q?vGHOdot5Ey9EbJTZcgXel/zQPv3L9p67SWbnUWFLObf6lw+UnY3tff/TNQYE?= =?us-ascii?Q?MvSpdm/837DVw3w6+1k107LVUk7WDXk3VnkCxIj5lbuxZVw8Bc8oJ7TEmPK8?= =?us-ascii?Q?gMDv96arVXqFuJSFPNRnMqOpBTbd2aml/xF2AA+5fxKWawW4Wk4Qc5uJCPjq?= =?us-ascii?Q?SC0XbV/8zqFX8GMGz3jOIBZlVtHcYiiBrXllZ3vNndXsUTg1IMqzmglD6irt?= =?us-ascii?Q?2oj6TU7jYuWrD3DNE7doIVRg+TMqSrQCyMTtVZ3m97x8D1LKVv5IWq3GwdMQ?= =?us-ascii?Q?mWb534T1Kw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 169f5767-303f-4f10-25cd-08dea534a083 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 14:44:18.6446 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1/za11UvvMbk9Ee4op4cNTbv220/JtXmhiE/XjZjxey9lX5PCuxVanzgu2XrNzG/PNTr6R5TW7HA15b9frsnYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6211 Content-Type: text/plain; charset="utf-8" From: K Prateek Nayak On asymmetric CPU capacity systems, the wakeup path uses select_idle_capacity(), which scans the span of sd_asym_cpucapacity rather than sd_llc. The has_idle_cores hint however lives on sd_llc->shared, so the wakeup-time read of has_idle_cores operates on an LLC-scoped blob while the actual scan/decision spans the asym domain; nr_busy_cpus also lives in the same shared sched_domain data, but it's never used in the asym CPU capacity scenario. Therefore, move the sched_domain_shared object to sd_asym_cpucapacity whenever the CPU has a SD_ASYM_CPUCAPACITY_FULL ancestor and that ancestor is non-overlapping (i.e., not built from SD_NUMA). In that case the scope of has_idle_cores matches the scope of the wakeup scan. Fall back to attaching the shared object to sd_llc in three cases: 1) plain symmetric systems (no SD_ASYM_CPUCAPACITY_FULL anywhere); 2) CPUs in an exclusive cpuset that carves out a symmetric capacity island: has_asym is system-wide but those CPUs have no SD_ASYM_CPUCAPACITY_FULL ancestor in their hierarchy and follow the symmetric LLC path in select_idle_sibling(); 3) exotic topologies where SD_ASYM_CPUCAPACITY_FULL lands on an SD_NUMA-built domain. init_sched_domain_shared() keys the shared blob off cpumask_first(span), which on overlapping NUMA domains would alias unrelated spans onto the same blob. Keep the shared object on the LLC there; select_idle_capacity() gracefully skips the has_idle_cores preference when sd->shared is NULL. While at it, also rename the per-CPU sd_llc_shared to sd_balance_shared, as it is no longer strictly tied to the LLC. Co-developed-by: Andrea Righi Signed-off-by: Andrea Righi Signed-off-by: K Prateek Nayak --- kernel/sched/fair.c | 17 +++++--- kernel/sched/sched.h | 2 +- kernel/sched/topology.c | 90 +++++++++++++++++++++++++++++++++++------ 3 files changed, 89 insertions(+), 20 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index e0f75dedc8456..bbdf537f61154 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7790,7 +7790,7 @@ static inline void set_idle_cores(int cpu, int val) { struct sched_domain_shared *sds; =20 - sds =3D rcu_dereference_all(per_cpu(sd_llc_shared, cpu)); + sds =3D rcu_dereference_all(per_cpu(sd_balance_shared, cpu)); if (sds) WRITE_ONCE(sds->has_idle_cores, val); } @@ -7799,7 +7799,7 @@ static inline bool test_idle_cores(int cpu) { struct sched_domain_shared *sds; =20 - sds =3D rcu_dereference_all(per_cpu(sd_llc_shared, cpu)); + sds =3D rcu_dereference_all(per_cpu(sd_balance_shared, cpu)); if (sds) return READ_ONCE(sds->has_idle_cores); =20 @@ -7808,7 +7808,7 @@ static inline bool test_idle_cores(int cpu) =20 /* * Scans the local SMT mask to see if the entire core is idle, and records= this - * information in sd_llc_shared->has_idle_cores. + * information in sd_balance_shared->has_idle_cores. * * Since SMT siblings share all cache levels, inspecting this limited remo= te * state should be fairly cheap. @@ -7925,7 +7925,7 @@ static int select_idle_cpu(struct task_struct *p, str= uct sched_domain *sd, bool struct cpumask *cpus =3D this_cpu_cpumask_var_ptr(select_rq_mask); int i, cpu, idle_cpu =3D -1, nr =3D INT_MAX; =20 - if (sched_feat(SIS_UTIL)) { + if (sched_feat(SIS_UTIL) && sd->shared) { /* * Increment because !--nr is the condition to stop scan. * @@ -12826,7 +12826,11 @@ static void set_cpu_sd_state_busy(int cpu) struct sched_domain *sd; sd =3D rcu_dereference_all(per_cpu(sd_llc, cpu)); =20 - if (!sd || !sd->nohz_idle) + /* + * sd->nohz_idle only pairs with nr_busy_cpus on sd->shared; if this + * domain has no shared object there is nothing to clear or account. + */ + if (!sd || !sd->shared || !sd->nohz_idle) return; sd->nohz_idle =3D 0; =20 @@ -12851,7 +12855,8 @@ static void set_cpu_sd_state_idle(int cpu) struct sched_domain *sd; sd =3D rcu_dereference_all(per_cpu(sd_llc, cpu)); =20 - if (!sd || sd->nohz_idle) + /* See set_cpu_sd_state_busy(): nohz_idle is only used with sd->shared. */ + if (!sd || !sd->shared || sd->nohz_idle) return; sd->nohz_idle =3D 1; =20 diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 9f63b15d309d1..330f5893c4561 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2170,7 +2170,7 @@ DECLARE_PER_CPU(struct sched_domain __rcu *, sd_llc); DECLARE_PER_CPU(int, sd_llc_size); DECLARE_PER_CPU(int, sd_llc_id); DECLARE_PER_CPU(int, sd_share_id); -DECLARE_PER_CPU(struct sched_domain_shared __rcu *, sd_llc_shared); +DECLARE_PER_CPU(struct sched_domain_shared __rcu *, sd_balance_shared); DECLARE_PER_CPU(struct sched_domain __rcu *, sd_numa); DECLARE_PER_CPU(struct sched_domain __rcu *, sd_asym_packing); DECLARE_PER_CPU(struct sched_domain __rcu *, sd_asym_cpucapacity); diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 5847b83d9d552..69d465cc93ab4 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -665,7 +665,7 @@ DEFINE_PER_CPU(struct sched_domain __rcu *, sd_llc); DEFINE_PER_CPU(int, sd_llc_size); DEFINE_PER_CPU(int, sd_llc_id); DEFINE_PER_CPU(int, sd_share_id); -DEFINE_PER_CPU(struct sched_domain_shared __rcu *, sd_llc_shared); +DEFINE_PER_CPU(struct sched_domain_shared __rcu *, sd_balance_shared); DEFINE_PER_CPU(struct sched_domain __rcu *, sd_numa); DEFINE_PER_CPU(struct sched_domain __rcu *, sd_asym_packing); DEFINE_PER_CPU(struct sched_domain __rcu *, sd_asym_cpucapacity); @@ -680,20 +680,38 @@ static void update_top_cache_domain(int cpu) int id =3D cpu; int size =3D 1; =20 + sd =3D lowest_flag_domain(cpu, SD_ASYM_CPUCAPACITY_FULL); + /* + * The shared object is attached to sd_asym_cpucapacity only when the + * asym domain is non-overlapping (i.e., not built from SD_NUMA). + * On overlapping (NUMA) asym domains we fall back to letting the + * SD_SHARE_LLC path own the shared object, so sd->shared may be NULL + * here. + */ + if (sd && sd->shared) + sds =3D sd->shared; + + rcu_assign_pointer(per_cpu(sd_asym_cpucapacity, cpu), sd); + sd =3D highest_flag_domain(cpu, SD_SHARE_LLC); if (sd) { id =3D cpumask_first(sched_domain_span(sd)); size =3D cpumask_weight(sched_domain_span(sd)); =20 - /* If sd_llc exists, sd_llc_shared should exist too. */ - WARN_ON_ONCE(!sd->shared); - sds =3D sd->shared; + /* + * If sd_asym_cpucapacity didn't claim the shared object, + * sd_llc must have one linked. + */ + if (!sds) { + WARN_ON_ONCE(!sd->shared); + sds =3D sd->shared; + } } =20 rcu_assign_pointer(per_cpu(sd_llc, cpu), sd); per_cpu(sd_llc_size, cpu) =3D size; per_cpu(sd_llc_id, cpu) =3D id; - rcu_assign_pointer(per_cpu(sd_llc_shared, cpu), sds); + rcu_assign_pointer(per_cpu(sd_balance_shared, cpu), sds); =20 sd =3D lowest_flag_domain(cpu, SD_CLUSTER); if (sd) @@ -711,9 +729,6 @@ static void update_top_cache_domain(int cpu) =20 sd =3D highest_flag_domain(cpu, SD_ASYM_PACKING); rcu_assign_pointer(per_cpu(sd_asym_packing, cpu), sd); - - sd =3D lowest_flag_domain(cpu, SD_ASYM_CPUCAPACITY_FULL); - rcu_assign_pointer(per_cpu(sd_asym_cpucapacity, cpu), sd); } =20 /* @@ -2650,6 +2665,49 @@ static void adjust_numa_imbalance(struct sched_domai= n *sd_llc) } } =20 +static void init_sched_domain_shared(struct s_data *d, struct sched_domain= *sd) +{ + int sd_id =3D cpumask_first(sched_domain_span(sd)); + + sd->shared =3D *per_cpu_ptr(d->sds, sd_id); + atomic_set(&sd->shared->nr_busy_cpus, sd->span_weight); + atomic_inc(&sd->shared->ref); +} + +/* + * For asymmetric CPU capacity, attach sched_domain_shared on the innermost + * SD_ASYM_CPUCAPACITY_FULL ancestor of @cpu's base domain when that ances= tor is + * not an overlapping NUMA-built domain (then LLC should claim shared). + * + * A CPU may lack any FULL ancestor (e.g., exclusive cpuset symmetric isla= nd), + * then LLC must claim shared instead. + * + * Note: SD_ASYM_CPUCAPACITY_FULL is only set when multiple distinct capac= ities + * exist in the domain span, so the asym domain we attach to cannot degene= rate + * into a single-capacity group. The relevant edge cases are instead cover= ed by + * the caveats above. + * + * Return true if this CPU's asym path claimed sd->shared, false otherwise. + */ +static bool claim_asym_sched_domain_shared(struct s_data *d, int cpu) +{ + struct sched_domain *sd =3D *per_cpu_ptr(d->sd, cpu); + struct sched_domain *sd_asym; + + if (!sd) + return false; + + sd_asym =3D sd; + while (sd_asym && !(sd_asym->flags & SD_ASYM_CPUCAPACITY_FULL)) + sd_asym =3D sd_asym->parent; + + if (!sd_asym || (sd_asym->flags & SD_NUMA)) + return false; + + init_sched_domain_shared(d, sd_asym); + return true; +} + /* * Build sched domains for a given set of CPUs and attach the sched domains * to the individual CPUs @@ -2708,20 +2766,26 @@ build_sched_domains(const struct cpumask *cpu_map, = struct sched_domain_attr *att } =20 for_each_cpu(i, cpu_map) { + bool asym_claimed =3D false; + sd =3D *per_cpu_ptr(d.sd, i); if (!sd) continue; =20 + if (has_asym) + asym_claimed =3D claim_asym_sched_domain_shared(&d, i); + /* First, find the topmost SD_SHARE_LLC domain */ while (sd->parent && (sd->parent->flags & SD_SHARE_LLC)) sd =3D sd->parent; =20 if (sd->flags & SD_SHARE_LLC) { - int sd_id =3D cpumask_first(sched_domain_span(sd)); - - sd->shared =3D *per_cpu_ptr(d.sds, sd_id); - atomic_set(&sd->shared->nr_busy_cpus, sd->span_weight); - atomic_inc(&sd->shared->ref); + /* + * Initialize the sd->shared for SD_SHARE_LLC unless + * the asym path above already claimed it. + */ + if (!asym_claimed) + init_sched_domain_shared(&d, sd); =20 /* * In presence of higher domains, adjust the --=20 2.54.0 From nobody Wed Jun 17 02:50:55 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010031.outbound.protection.outlook.com [52.101.56.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B339B429813 for ; Tue, 28 Apr 2026 14:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387475; cv=fail; b=Z8mUqr87+ahkvl1i6TWr659B2lRYDB19wOEAK/2rf2kSy+GyC/XXSRz6cY4NzXo64Sv9gRLO8EUePhj7GGkEvvdnahRmfz306HIEZGgLRfcwoOGukZG0WHt+isrfZaj5YL+yl0wVChoGtHL8sVN/x9c+Pwu2FlHvFhIQlcrVeik= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387475; c=relaxed/simple; bh=yvWgrlQVyKhrRl8iQ1xi9cY2xCWHgh+IyXmh8Y4CPmc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ruNDCef9NMdF4DoyeWcwy6G77ABVXxEmudoYjnMLIz/NnNyEBS0080jmxecwTS2GuJ6Ow5mb4vQYzw9lBgQ+lxkE8r0NRtWI8yhhLOObId229k+gm7qHIISHIAHU1XWYTE1rTehue5mSh4TIL1X2fQ/ZTwSaq2+4PUrmF4liEJk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=CbRPi/X8; arc=fail smtp.client-ip=52.101.56.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="CbRPi/X8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mq1l1DKEYDj3VScQJgdTU8PP1R7LXfM3kD1DtSEmXqdXlqp+9SEDYTP1AIt7GQZZZ9r520/dcfLV3yXlFKt/Q9epjHf0SlUtPTEofZGGLYT5PIee+ibbE4t/MtyNPwrTzM9M6OqpAnp+FK0S8g7Bn55WiBltAnSWmpU96MOJP6DVFaHJRXlhHmAjINUAk7s5XrsbQ4eWBsfdql5xMNOi9jUVImgz++/guWxcUmd8pYLBJbjH4E2jrRIB/lpW1Hr7bOrWq50ZfMXc0NSALdfzssry6HXLyK6FhkOViaNQiK1bn24gEud6RVS9Q0EgnOS6T2rcHSeShmI6UOsDZss0lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jcwVjI1k39DqCy+S3uKGE2jAi9UQYvQaR8gKqZ2cH4A=; b=rxVshoVYa932818mQuY1JeYUQuXmIxdGRYU/Pt8gwhcEj8rDsWy1dbV5F49saljBiGDd3ED7TNkl3meIsMpDOsom8UVLDbSQRlDwEiUjPat96HD5WWXHweY/VFBnJiE7KYUbThhk6q3BfTbYMRLAPyMBp4oP1NN8zgxTcmFaX3ZSiTzSchULBSJoePKLNQEddeBlbKp/4e8+cBTsS4v0vciyz3FAn21uVNeq5xP7TCTrK8XdCMSq9JcKAqZxyuaHdr0A+tqRDHxx8C6/160CTVSnsX+z4nD8lZmrBMDWCLYFJw5f+NK5djZ9DR9YhNSWrbbepCzla9JxiCh4OwWopg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jcwVjI1k39DqCy+S3uKGE2jAi9UQYvQaR8gKqZ2cH4A=; b=CbRPi/X8zHU4+gS6QS+AiBC/iO1E6ZgfzxGaq93CZ+u9VmEyH3lCLUHjGRuW5+NvSp0Jp2x6HbWRBYE6rrtPDHWACwd1uelG6yyXZlnVclt8pbHxtflKi0tCBEKi+SqgIcY163B1ROs9U3dGufG/9MPV3RX8oo47gl7Q5SdEuW5j3StNz6bWSa9Ls1JJb04H76hX6y+KSmfethAXg2i5Bx//XOu0FAhnSVtKDSVAyOSugQNX3jPufLww2LO0MhpmWRsT4UHLL8HFcXvG9XCU1x5E8bHse/SvbgqiPn/J9R6Zrc8mmJAZ3DGtYM1paRBlikSbpFZNc0yruYMQXyvu/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by IA1PR12MB6211.namprd12.prod.outlook.com (2603:10b6:208:3e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr 2026 14:44:27 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026 14:44:27 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: [PATCH 3/5] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Date: Tue, 28 Apr 2026 16:41:09 +0200 Message-ID: <20260428144352.3575863-4-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428144352.3575863-1-arighi@nvidia.com> References: <20260428144352.3575863-1-arighi@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: ZR0P278CA0198.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::12) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|IA1PR12MB6211:EE_ X-MS-Office365-Filtering-Correlation-Id: 4f781f1c-230e-497b-50c3-08dea534a5c5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: tQaWww0TPiGnlbHzYFL7IuO+3vLoG0xUzZN4nZ1OHiuw8XRs2fGtibrAtvB4lOGXz1Rb9kXIzML/6dRPZZCmnTqFqc2A1jy5Pvn5dy8u7LB2R5uFUf+En8btEYnvafRSFUmlWNTtroQPRvEh6IDCVFom19AyHHNb18+M9XaXF/tn2g+8x8v9Wve5GQGdIZYRERJe0nhuE/E73llTYoVIw/J+P+rtFOCZbhjL0ToVwpPHr6Zl6uM+XvMUgiRZQ3u18h3N9oSgz2MPkSJbMRE8375mejwOWDwAF+a/Aja70bLZ4WGswwsRBKrFieIedF8reTOu6VZq7ty9XiQGMK5zV/f94iDXp1jBAc3c+HsuWHX7xuEj4s/6MEORHKtSVe8YBYJJ9cuLxMhDdJGnz7TYxR4fghFEsb4tMoFzVLGqQgAn2iurTKogtxHL/oGgD2JYWj6JhRUSYd/BDLT9zgF8/s7U0qmdPByUhkaTrxEKC7u7AWpRcjDOw9LZiXXpHOcLZ9y3SyfYdqFHGT1G2UvRMpWh7VXYkxfoIPpNHAlF0fZVIpJ5PMm33QEoYUVU6ZEA8aZwqL9dB42yM3LHJfDeKk8Yk2BxwDBSqagY2gYJl+idFOC8z3lwrriJqqFUCPz6mwUgqqfocXpyzh1GJJ0Hg5PhmBonYH/ncDzSn9j+uLZt2w/8fMLyftdrwmQOAMwM58oEaPyFIFG9QuCxrfOodsOC3wUZRD2nVTDZWXMqNWo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0CvaYzqWb9+pew7uhz8AwOmWwMnMufxQMLyUBdF+4xLMsRKfA5NKJhqo/H3T?= =?us-ascii?Q?O9RTC6rajWvTDM3g/TzC3tXvOugTTHL7n70YKkIw1tbFpnqtpdb3ph/pmHtY?= =?us-ascii?Q?rsk013Z9WDxrZzishmMw3rtjbd1fzUd6nyW0p8FIqHyMpmNqSaBY/HIBW2nI?= =?us-ascii?Q?4Wzx48bEv3RZt5yB7GteMcp6/mXpZclHEMHtGHSvKMGYA0uVBXqEd9TO8swW?= =?us-ascii?Q?fND38++Jg3UIWz3ZERu1oGyGPY7lqxjRCwwLa+HUMm4zL+aoLoKwBmoVye8I?= =?us-ascii?Q?3pBqAYb/75oqSh6srJOQq55LwHkPkXEARb64qtep5xa2q86BecQxhQp+SBr2?= =?us-ascii?Q?QUYayDvYM7221uvMj6m9bmyHutZj4PVmQCJZ84s7bE46BsWt6ARZ5TodK23M?= =?us-ascii?Q?5o1DVKD417bmKmV/gH5gcyYxKH0nWJbjFOWBMNyv1dBVUn3hhiQ4VlH581/m?= =?us-ascii?Q?lIDtTFVK9T8TjVi4V4UDEcx0rZBYsfwTIRDh8o+tyApLVsP1bpbPBU/l+fQb?= =?us-ascii?Q?i8JPPdRecbSaHS4P31ncJHKDMhB69a/dTc2tQRsj5g4HJK9KYdWi2LVc6iWF?= =?us-ascii?Q?JGwc/X+4KDMnGADMNaF5egZTJRl3boAi/0owfGgLb8EebL7H790T6mASO9xn?= =?us-ascii?Q?MCncOqHGuXxlOncNGIF17rQ2XTNBJoWHl7mkZ7DP3t8LwO6I+dhuzD54dkpN?= =?us-ascii?Q?7bnvpzui3Ga9bfjYfUmO4WMIGodKSk8BJj+KkyixJz37LKQq3WdDyRJvhUHG?= =?us-ascii?Q?U2j8IiJGnUykaGgC9Hf/oVIz3/7nnJvuT/0KtHsvIpTAUcOT1MfJi/S8Ooxx?= =?us-ascii?Q?Z9NH6g/QNM8tFMvBEAVWAqAiaOwrVuGTDf5LLahBaxLUi27ZXcMJ7w/9JRun?= =?us-ascii?Q?4Yop0SREuziHGcsvLEckTFEV8nhNhllOuB1sKaO1Z4Lu5+QOY9HPrsHswR/u?= =?us-ascii?Q?zspZOVaRhtcOhsTvMtZC7YrLXKWJ19+XOKUi6VC+lULOCXWWSs5V5A93JXd3?= =?us-ascii?Q?4S74hTYiUsn8HBAOjly2/ffnasMOx4MIb7Pe7Cat8XElwyjvRxwR1AXRRou+?= =?us-ascii?Q?MXeZIxge9EgBNGrEIctoem7itctShT9TfXNDjKeNpUTHGxY7SeW3zV+eTjY5?= =?us-ascii?Q?sAR84hvIJDwb49DfzcKlvXaiuHqY80muUIL9NrcW0T9U/GizUGF1zX239mOw?= =?us-ascii?Q?4jGers5IYN5IAJPCR/u9ELvt+N6od8NvRcEggJxj7+jygCbZoc4EsR1QehBf?= =?us-ascii?Q?jH1hDlX6l9W9rwnoXHRhrVv79Xt7tRkzNmHzSjzyO5r4Lro2ow1h3/tNLjnK?= =?us-ascii?Q?FvNJACl1qhphm2kZV9cwv/hpKWcxwT6LcG3ncdYNXxbo7d3ReNf3/5fNDDy3?= =?us-ascii?Q?uF4wf2UtMwLKqWGZv8FJPyu3C0WofeGcVF/nUkRJfmJwXuqLxRMxBw5JVuJX?= =?us-ascii?Q?ziZzK8/fHXR5nMMeghth9q82pA7L6+PG1iobuBjYj/ozIarW02h2Z4LBtlBH?= =?us-ascii?Q?bObeMy6dZzLjFzoYTWVV+in3uhXErINJyM9x3tYEG9V4s1a2CnLuyxdEQyJg?= =?us-ascii?Q?CB+Mo70ElgiM5Pa5uOjTPybJW64+N5kGCOF1TujdB2oVKOsgqqY7RTN+rDvR?= =?us-ascii?Q?xxtwTOrtvQGWCzk5mAST64H9BPtnCViEMReDOojhnkSwNmTowKEXIf2m6Tgt?= =?us-ascii?Q?toAOVuNExdZ9zQCIiSvB2dpOwuji6jVvpONL9Kmj3T4mRwr5hMazF3j+mJ+X?= =?us-ascii?Q?8EI+P0qgMA=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f781f1c-230e-497b-50c3-08dea534a5c5 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 14:44:27.3593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ukk+2g61hWnnoA/7JnPzY5WjziutvRHKbqlkZrbmmlOgQQT67mjtpZr7uB/Lb94QmVEQ73jsENexQroepLT47g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6211 Content-Type: text/plain; charset="utf-8" On systems with asymmetric CPU capacity (e.g., ACPI/CPPC reporting different per-core frequencies), the wakeup path uses select_idle_capacity() and prioritizes idle CPUs with higher capacity for better task placement. However, when those CPUs belong to SMT cores, their effective capacity can be much lower than the nominal capacity when the sibling thread is busy: SMT siblings compete for shared resources, so a "high capacity" CPU that is idle but whose sibling is busy does not deliver its full capacity. This effective capacity reduction cannot be modeled by the static capacity value alone. Introduce SMT awareness in the asym-capacity idle selection policy: when SMT is active, always prefer fully-idle SMT cores over partially-idle ones. Prioritizing fully-idle SMT cores yields better task placement because the effective capacity of partially-idle SMT cores is reduced; always preferring them when available leads to more accurate capacity usage on task wakeup. On an SMT system with asymmetric CPU capacities, SMT-aware idle selection has been shown to improve throughput by around 15-18% for CPU-bound workloads, running an amount of tasks equal to the amount of SMT cores. Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Christian Loehle Cc: Koba Ko Reviewed-by: K Prateek Nayak Reported-by: Felix Abecassis Signed-off-by: Andrea Righi --- kernel/sched/fair.c | 70 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 65 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index bbdf537f61154..6a7e4943804b5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -7989,6 +7989,22 @@ static int select_idle_cpu(struct task_struct *p, st= ruct sched_domain *sd, bool return idle_cpu; } =20 +/* + * Idle-capacity scan ranks transformed util_fits_cpu() outcomes; lower va= lues + * are more preferred (see select_idle_capacity()). + */ +enum asym_fits_state { + /* In descending order of preference */ + ASYM_IDLE_CORE_UCLAMP_MISFIT =3D -4, + ASYM_IDLE_CORE_COMPLETE_MISFIT, + ASYM_IDLE_THREAD_FITS, + ASYM_IDLE_THREAD_UCLAMP_MISFIT, + ASYM_IDLE_COMPLETE_MISFIT, + + /* util_fits_cpu() bias for an idle core. */ + ASYM_IDLE_CORE_BIAS =3D -3, +}; + /* * Scan the asym_capacity domain for idle CPUs; pick the first idle one on= which * the task fits. If no CPU is big enough, but there are idle ones, try to @@ -7997,8 +8013,9 @@ static int select_idle_cpu(struct task_struct *p, str= uct sched_domain *sd, bool static int select_idle_capacity(struct task_struct *p, struct sched_domain *sd, int t= arget) { + bool prefers_idle_core =3D sched_smt_active() && test_idle_cores(target); unsigned long task_util, util_min, util_max, best_cap =3D 0; - int fits, best_fits =3D 0; + int fits, best_fits =3D ASYM_IDLE_COMPLETE_MISFIT; int cpu, best_cpu =3D -1; struct cpumask *cpus; =20 @@ -8010,6 +8027,7 @@ select_idle_capacity(struct task_struct *p, struct sc= hed_domain *sd, int target) util_max =3D uclamp_eff_value(p, UCLAMP_MAX); =20 for_each_cpu_wrap(cpu, cpus, target) { + bool preferred_core =3D !prefers_idle_core || is_core_idle(cpu); unsigned long cpu_cap =3D capacity_of(cpu); =20 if (!choose_idle_cpu(cpu, p)) @@ -8018,7 +8036,7 @@ select_idle_capacity(struct task_struct *p, struct sc= hed_domain *sd, int target) fits =3D util_fits_cpu(task_util, util_min, util_max, cpu); =20 /* This CPU fits with all requirements */ - if (fits > 0) + if (fits > 0 && preferred_core) return cpu; /* * Only the min performance hint (i.e. uclamp_min) doesn't fit. @@ -8026,9 +8044,33 @@ select_idle_capacity(struct task_struct *p, struct s= ched_domain *sd, int target) */ else if (fits < 0) cpu_cap =3D get_actual_cpu_capacity(cpu); + /* + * fits > 0 implies we are not on a preferred core + * but the util fits CPU capacity. Set fits to ASYM_IDLE_THREAD_FITS + * so the effective range becomes + * [ASYM_IDLE_THREAD_FITS, ASYM_IDLE_COMPLETE_MISFIT], where: + * ASYM_IDLE_COMPLETE_MISFIT - does not fit + * ASYM_IDLE_THREAD_UCLAMP_MISFIT - fits with the exception of UCLAMP= _MIN + * ASYM_IDLE_THREAD_FITS - fits with the exception of preferred_core + */ + else if (fits > 0) + fits =3D ASYM_IDLE_THREAD_FITS; + + /* + * If we are on a preferred core, translate the range of fits + * of [ASYM_IDLE_THREAD_UCLAMP_MISFIT, ASYM_IDLE_COMPLETE_MISFIT] to + * [ASYM_IDLE_CORE_UCLAMP_MISFIT, ASYM_IDLE_CORE_COMPLETE_MISFIT]. + * This ensures that an idle core is always given priority over + * (partially) busy core. + * + * A fully fitting idle core would have returned early and hence + * fits > 0 for preferred_core need not be dealt with. + */ + if (preferred_core) + fits +=3D ASYM_IDLE_CORE_BIAS; =20 /* - * First, select CPU which fits better (-1 being better than 0). + * First, select CPU which fits better (lower is more preferred). * Then, select the one with best capacity at same level. */ if ((fits < best_fits) || @@ -8039,6 +8081,19 @@ select_idle_capacity(struct task_struct *p, struct s= ched_domain *sd, int target) } } =20 + /* + * A value in the [ASYM_IDLE_CORE_UCLAMP_MISFIT, ASYM_IDLE_CORE_BIAS] + * range means the chosen CPU is in a fully idle SMT core. Values above + * ASYM_IDLE_CORE_BIAS mean we never ranked such a CPU best. + * + * The asym-capacity wakeup path returns from select_idle_sibling() + * after this function and never runs select_idle_cpu(), so the usual + * select_idle_cpu() tail that clears idle cores must live here when the + * idle-core preference did not win. + */ + if (prefers_idle_core && best_fits > ASYM_IDLE_CORE_BIAS) + set_idle_cores(target, false); + return best_cpu; } =20 @@ -8047,12 +8102,17 @@ static inline bool asym_fits_cpu(unsigned long util, unsigned long util_max, int cpu) { - if (sched_asym_cpucap_active()) + if (sched_asym_cpucap_active()) { /* * Return true only if the cpu fully fits the task requirements * which include the utilization and the performance hints. + * + * When SMT is active, also require that the core has no busy + * siblings. */ - return (util_fits_cpu(util, util_min, util_max, cpu) > 0); + return (!sched_smt_active() || is_core_idle(cpu)) && + (util_fits_cpu(util, util_min, util_max, cpu) > 0); + } =20 return true; } --=20 2.54.0 From nobody Wed Jun 17 02:50:55 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012006.outbound.protection.outlook.com [52.101.43.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077C0306486 for ; Tue, 28 Apr 2026 14:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387489; cv=fail; b=PNNF5t8UurEmBY4SPzlZbdJZFHkBMq8GdKWQhzOD1XQCJ1O6dXe8i79Tbk4qqpgWzzRGNuaStfeaTlnnFfojiH2GSiFvJF7ZE17ZY5KhHZOW7sedrGC/nJV1UOPyEH+IvlcE2VFIegfSEmWrRmQSIy5vaUaJEWtRgA5YAL4wWkc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387489; c=relaxed/simple; bh=LPPfpvSnoa2jO81IOfBOEv1BmmoWeZ6P2/s5dKbLubw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=Lej6LbNsebssgrSiSsjvhvJsweimJtR64HCUdwC86d5xtwCxWqakeJn9SkaArx0GA3T6nB8sphmOQZGW8yJVbv0d1uwYnfApN7DddlTG2O1iIr4dM3BE4+5/stCZ1sav/r8VPS3I3Yz/EjQ2YZlo92q4y3n1erCaT8Ju0H0a6a8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XcqlEstp; arc=fail smtp.client-ip=52.101.43.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XcqlEstp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ztbk8ujaTOpNPWrX8rYXYjMChTD17zOurShZlzvizn6f5KK0D1tx+3gR910fbDPJzpDrMEwkB28e1AISWwtX8OxsQkwg+UGj24f1PAfwBPLQaqzOALgGv9+8wTrAxGK0NC3u1K5G+BeSqQRgBe0r0ydnK68FT5ogz67NYTCHv8K/Umj6SKHo8OUiZXHft5pTjMlSIPqrsjb+TPdP7jiDHZqAy3fb4bjPGX36NfcbloO9aRfEGwzR2u5YzgbCPuyN7UQf3P8xUfw466r4TnJ8kQr9Y0gr0St/+rUL0HZYxx0nrEEnOWQQp1/lMZZa/YUp/HOXZ3J7B+DSh9IzJeIKcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7+DfBndH/QkQEO9PMqNTZ0ZWeZpaOseoJYt9MhaDO2I=; b=INp6qEorgBTV68f7BTTGWZPEjgiYEtqbsWheBBIpRwxoCQD6NZ4/3AIFefliHkcQ7klJJYNZnncifTXvvQGWPx+GYmDbdhDiNB93iNQXW+NbhhSWlgUGC6BkH18ICOQu31RitjM4A0UUlHQb46MZxx6cndFmDkRTW6Y0kcZ9n2hnbGe9uMGv6YvFfp7Vu7Gkk/Xq1ke2ED8XDsJgeePtkdI714Zd8ur4GGLKWcFS7G5xzvJCr2l312RuhAA5/15hIz5gGmE8b+G/rNRWCqLIxcXU03whEtNg8wa6dnPxTi2VYXlTq0gvbK4Shk0E5cPxR0BsAuEZXs0Zh6Ko4hHvmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7+DfBndH/QkQEO9PMqNTZ0ZWeZpaOseoJYt9MhaDO2I=; b=XcqlEstpDaLKb/KvrWHi06GuI5SW9SU1no7bgn/9wTuG738TdK0hHcjRKlE7m7MIJ7LyCdOlABG5h55P9QrjSBSC5Vq0ToDO82hJwXUeu1un8YXwhIARprUvyZGXSCfsPLRb/L14CqA4P8Btl0h2p25oX74aN+Cfp93xDyVC8sCRodIiybuLwMwaxQt82wndF7TNqdjdIBCw1kZ+3GEJf2JybE93cUWJUU0uNozlrU2u5hVOYgvP9r52rDFZFFVNvPxxJ8EEkm9JrpfyElz/pvScGxpVeZPL6RiDjzicGS06GIX5y34Ca9D/CJvHH28nBo5DNes3Y1F2SUD7J1ekVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by IA1PR12MB6211.namprd12.prod.outlook.com (2603:10b6:208:3e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr 2026 14:44:37 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026 14:44:36 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] sched/fair: Reject misfit pulls onto busy SMT siblings on asym-capacity Date: Tue, 28 Apr 2026 16:41:10 +0200 Message-ID: <20260428144352.3575863-5-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428144352.3575863-1-arighi@nvidia.com> References: <20260428144352.3575863-1-arighi@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: ZR0P278CA0180.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:45::7) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|IA1PR12MB6211:EE_ X-MS-Office365-Filtering-Correlation-Id: 767a984e-8808-4bd7-991d-08dea534ab30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: xKLWmoC9O917sW3IFJLmubtnDao7FNA8ryX3nOA/ymvlfk80agS+HtMJjxfIND6vO3QRBkP1CN/DxjCzneAqVul2k6mdFzj0j+cBA1h/yvHbt7otp5XxuxQ8+FvGHyWJ32ATkuIYoQuS6JD5I0VTGbwBen++fPTH12idSlg2/mFWq9Eam5Komr2xUxyTS8f0InLv3amaIBn5mcxgobkdoFgGrF/5UitnCJds0tR7KbukYdNZco3Bckx6zY8eLzVO10tX6hJuoTp6zvq6wi3/7KSVnFAhor5RIqZCl+5r41Yzst93Nr5YT4NFGPoy0jiYXWvKXBsFVyg7gINA6ZTLeWX1a5raeX7ZazTm9r20k6KnbPlTXRjBB70F8c+uCXXR/wXzMAzAWiyHWCNt2R4MJpUofAXgWOOcua3XW05XWXOJtLAy9eMlkmLY1XDKZlu6SF73GFdCQ5YP/vAN6qq4nRDE4eTDchks/vUW0/zty1BuACrVVlojOPw2J+/R2JslBDzC+EQ6R3BDeB+M1bKhIYKgiVltOIxfHx/tRDDpX3GFxt26QUXXXfnm9AJybGMj/uh8lQP+s/7VgqUzSYHGCgoovNSdmyXdYNynixK1O01i5UeBSS/wENUfTj2cjRF4dmg+VH4v/ogOD1UdZGkqOyF9iFQoIMW44J1JBQgQau5lcR0u+Ai657hlXsxhiOsbbo04axDEa2v2ixO895ADLAW58B0pQRd0+vCrh6As5s0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bfjIT15PCJ3iGJMfKE7aa1NUUtiDhChgGywCniWXdDxNF3Lk1WiDz/S5VniZ?= =?us-ascii?Q?cHAPaWvuxC8bm9f3iDwT/TrDX2aqViyL5dSqISgPpZ1o1KjCKpJh+gnNnSCO?= =?us-ascii?Q?amQuM+ID+uOPUKF3+RN8wshV6taHkY32EAcYrpzSYT0PUUpjO0QjoPxE9YiU?= =?us-ascii?Q?7aY3NjQ633mR6tWbs8WsKC8lbPkhXLAoOaz6dL7rNIQywSkqZeJT99iVNRse?= =?us-ascii?Q?V/xEMf/yA+fPmFhqynRQ/Ry70tQeazrjSjKLkCyQEkNSI2m5NxdyGGR8upTI?= =?us-ascii?Q?HvX7roEWbFdonBdpNFnYq/py0NAu6LHlzOgSO8GcPSgCapBqryoiuXt6ol1J?= =?us-ascii?Q?aeetXf3cTij8WXyie+h3L+XFNyJSbZysP7DwpLGzWncoyDyNME+yfq7uQq7U?= =?us-ascii?Q?97i8kPRWf1fwSwC8lDbkOnnJWupkSxSRJVrcUN2/jEHxL/Lsmp6dQyYVpcvb?= =?us-ascii?Q?l92Mqan0vUMPOJg8O8S74dRR/zSjTH/YiJyG7pZNumSoZw5ZLMvX9RxDRlBa?= =?us-ascii?Q?lJAmU1UdIIOfjFOPCPMbWpCtHSfeogAxHRK0Z/eLM2/ifRHMbUULhDxYo6pW?= =?us-ascii?Q?t5inwCz8OcnFgm95j3evBDFKeKrpPWNlRkX+V3DgR7YMl3Hz6aD9/nzS54Gj?= =?us-ascii?Q?qRXILQz1LF+MT+ds9SHjGTv7ClJo5RONIoi8az+iGU6voA+MGyeV44o9D8oU?= =?us-ascii?Q?SiEJ8J2itdeIxpxspIJTIqhNxPAwsi/aeS+bVkR5JHBYrMJHyVS7IZ4HxIKE?= =?us-ascii?Q?0PTAcuQ0g433iqZ8F+m7EwK2Bxqv7uVQgOUqnR7Rlv/oTheDu7XKS5bifwud?= =?us-ascii?Q?0IQJdLLBV406HO994Kdh3ab++c2kA+40ilMHLMkuXSJg40VLLwt4GCUMVbJc?= =?us-ascii?Q?SSIsonolObqaO/nQYBEbC5px2DXfCVdR1uHi1/g/fs1/ARc8OIwJWfLZhCFP?= =?us-ascii?Q?ZgFrwnXK7Wf4sZjg6/ZlCVvVcKXZSj3E1KcgX10Q3WUHmuwVhDhMLvLo37cz?= =?us-ascii?Q?jdsph9mi/arOq9Rb4R+TK6prraogIStJq+p3y1iV8NymAkJar0PcBU6Rz2b4?= =?us-ascii?Q?tWDo4P8zAe8QzlJ/s3fdLNRF0zKdz3t4i5Ko3y3rZUcSYc1HumUM+FlNMAQx?= =?us-ascii?Q?mKXucHz4Dl+jREMnD9LOtKTC70I0uboXbCCzXcvjQ5qm15Tx0kD15becaBx7?= =?us-ascii?Q?fZyCjUAsnXDLXp8xNFQ9tH9tC4AkNIfvz9wY5dyv56ZjoUan6zCVlyWfNN5F?= =?us-ascii?Q?dcy1IhNX45Jd3WMVFTdWAYGdq4JYvdvh6trD1uL0D6HUdTC5hX7+0FWlht2R?= =?us-ascii?Q?gPMFFtvpRl2iZjbGZUzCAcaSDmfLMVscKyxCSpEy1TXLgLmtYVYy3Ay9tOYG?= =?us-ascii?Q?YxSSIujqkaca9rA8mkD1qygJZc0o/TYcPCOKyCX4ha7MKQlbDgzqTgVJ/5v2?= =?us-ascii?Q?9Lg64FleGDKVH3vsAnlPeoLgmcaBzb5fFx9Pq+2lQ7MCxM+OfoktDEtPVNhg?= =?us-ascii?Q?wWUXnbXRmeQSjDp26nERhuz+LG9QbpKQSIxQsm9jRgfvl5pTfMtlOSYB55Bp?= =?us-ascii?Q?nWSWYhYKXPVOGNBA7bUCAu9S4DyB1tPAO81YXB0tPa7cDfS8y7izgrALUGvW?= =?us-ascii?Q?jIYeIYIXG3oFbnQ35EZxUGimv3z7ov/UfrjVi3ChWN5LsMZL1VtR+NzmiFaz?= =?us-ascii?Q?tzfnCdPiHDiXl+QjYvV5rNyQzMVh/qFL6HrXAVgK9ImLFqUmw6BK1ivaHNWl?= =?us-ascii?Q?M1wuKdUweg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 767a984e-8808-4bd7-991d-08dea534ab30 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 14:44:36.4172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QEd75KltDHHHfaXQbdY4ZrISHPeOyB4xEiXFiVhKrt3hMt5xhMH7XCNHPWi/NyGTLwaTFc1LlnZDW3lJN2wNDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6211 Content-Type: text/plain; charset="utf-8" When SD_ASYM_CPUCAPACITY load balancing considers pulling a misfit task, capacity_of(dst_cpu) can overstate available compute if the SMT sibling is busy: the core does not deliver its full nominal capacity. If SMT is active and dst_cpu is not on a fully idle core, skip this destination so we do not migrate a misfit expecting a capacity upgrade we cannot actually provide. Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Christian Loehle Cc: Koba Ko Cc: K Prateek Nayak Reported-by: Felix Abecassis Signed-off-by: Andrea Righi --- kernel/sched/fair.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6a7e4943804b5..a1f4d70f6b3d9 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9610,6 +9610,7 @@ struct lb_env { =20 int dst_cpu; struct rq *dst_rq; + bool dst_core_idle; =20 struct cpumask *dst_grpmask; int new_dst_cpu; @@ -10835,10 +10836,16 @@ static bool update_sd_pick_busiest(struct lb_env = *env, * We can use max_capacity here as reduction in capacity on some * CPUs in the group should either be possible to resolve * internally or be covered by avg_load imbalance (eventually). + * + * When SMT is active, only pull a misfit to dst_cpu if it is on a + * fully idle core; otherwise the effective capacity of the core is + * reduced and we may not actually provide more capacity than the + * source. */ if ((env->sd->flags & SD_ASYM_CPUCAPACITY) && (sgs->group_type =3D=3D group_misfit_task) && - (!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) = || + (!env->dst_core_idle || + !capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) = || sds->local_stat.group_type !=3D group_has_spare)) return false; =20 @@ -11402,6 +11409,8 @@ static inline void update_sd_lb_stats(struct lb_env= *env, struct sd_lb_stats *sd unsigned long sum_util =3D 0; bool sg_overloaded =3D 0, sg_overutilized =3D 0; =20 + env->dst_core_idle =3D !sched_smt_active() || is_core_idle(env->dst_cpu); + do { struct sg_lb_stats *sgs =3D &tmp_sgs; int local_group; --=20 2.54.0 From nobody Wed Jun 17 02:50:55 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012006.outbound.protection.outlook.com [52.101.43.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EBB73B388D for ; Tue, 28 Apr 2026 14:44:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387491; cv=fail; b=T0iWi4iE8l81sEBMTWjeaeduSuSoKX7Zr7FJyJVIUF9bDCNbfE2dnZWi35Cg/sAP7kzF0G6nIYqhVSgg1sc/5Mlhc/+/qFWTna+3mTWrFSf6/vgJGDd/d8hCKHeSRdU2+C6I9O8vlZg0v/FVj8c2nwKTvq6NeUdCc8q5TmuySnc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777387491; c=relaxed/simple; bh=OeNLhQtE7q4t1bnC52/oooHeurXM01B3SiwXssEUHPY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=tFUgxuOmrcpBd3ecvAETf9y34XkepLwd0vCs/bX4jd9nHtf/OMfFQ59IMdvrb9GRdpG8IrNQ5IEoAzA1L9hnM9ga2gB4DI5FjINt609oNahtBCdBPZdBsaAvWB/3ZYn1W+V1jfUEAUoUok6GO47OB1OxVXHPrz974Y+yF8ACbHY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cZ9K5EIw; arc=fail smtp.client-ip=52.101.43.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cZ9K5EIw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WJ4SPT/uxo/QOIWLgcwCtKfiFfAXXp3a5rcIvKapvkd7m32Y94VP8yZlFmD/9oKpGBeEw7ILd91iZivbVgD7Y5c1blzy4eJ3tyTUBrip6vUsTxvkZMAumxP/+pqS+8HxFwvuAh6Otv04As+MRsL57jPTpbfzefEhu9Dp9ZO1PG97ghgDqCUljz1F3WtO1EkpoOtVQSqy3Vc00sELPN1fJdbnID7JLPKDQpBLDcBuUC3+6rMZpt9coNWzRlekulx7IMgio7/786f8i4BWq9Sux/yHnBt8hZ+KGVAfIVS2v7gOW93Ei8BHxaQo0juLMr4ibnt5CDubsPHfuVbz7zytRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LjG0kGXDNZU9aUuqlELgT0df1tEDSfPaVJuM3cygVUE=; b=kO4CN88jmJJ2o3T43yefR57uzh/MLxzGUoiMAzIVxTlIumOpPCGq9UrkKhDYvxm3pQUhbTcsAX7DG2I1glj3GpGgT+gl7n0GzM+ttDo3UlbNDBE0ZymPTkqw3dMsTpp8E3PhK4q/+R2/Pqmqy3Edlt/UzOaSli82KqV6wO3F5HHyjav6HLBoEGusgKkI9+JoEEity2Vdti3236xtTrKutyq29g4GoWcLDDEo3+XQubilCOHYaGilnqRskUTdtsWdPj6maxF2cTgirRH6if6Da77jWHoPolnjd6r35UDoXLaztZW5Vk8/XgLxCvVjgqBCYve3dlo0XG1UbUbq9iWDgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LjG0kGXDNZU9aUuqlELgT0df1tEDSfPaVJuM3cygVUE=; b=cZ9K5EIwICZBLRYEUi9dqe3Ox3CCkEy4V9fI5P8IGShERytGc5ujMDzs8Qs4I4qQ64rJthqH+Fw7zNs0C379HUhFxfG6+7DdU1Z/GKETmhNGM0JAIaakxXV/78iL8IbPKUvn2zInAhGk+o7Lx99+xicnylH/M/ce3XE34U/YnKZ09F4MVxkMraAtDmOGulix0/SGHx/miGjTeBZpjj/IaDqshBOWvbXAQAk2Y5QqKDdpDjQGuIkk5W/rMHp9qAaZ30O2WXAIOUq4BB1QHW789db6MVSVU8aEuiE9qnzSpgGJvwTivBR9dOwC0ufuHtIOdwxtvteEas1w1EGi4v8MKg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by IA1PR12MB6211.namprd12.prod.outlook.com (2603:10b6:208:3e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.15; Tue, 28 Apr 2026 14:44:42 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026 14:44:41 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: [PATCH 5/5] sched/fair: Add SIS_UTIL support to select_idle_capacity() Date: Tue, 28 Apr 2026 16:41:11 +0200 Message-ID: <20260428144352.3575863-6-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428144352.3575863-1-arighi@nvidia.com> References: <20260428144352.3575863-1-arighi@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR03CA0348.namprd03.prod.outlook.com (2603:10b6:a03:39c::23) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|IA1PR12MB6211:EE_ X-MS-Office365-Filtering-Correlation-Id: 6744eef6-e35d-4a99-376a-08dea534ae61 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: Z18ghE6+sgR6DaX4CkFHi7bA6F8URNu3y2K18lnP+7VaeAxCDZJch2iyxSvb2puFJObBO60TMsL9oeZLcNsqfgOjNRHXBIJHUWMsoGIvK0KtXiHcUbVx8peLEQKgf1gRhXHZBh2p5ZUuA+uTc+5P5kwdO76ji8VaA+gMLhZWHOf2UJx2x26oOR9CTlS8MLa1ysiasl/eg4OA4Ut/SecMnwlBwrTQrxCyCrqx18/9jag4BVfHsfwsap1q4i7Foq18ANNsoGz7fnAE88XEYJWrweSkkzpODF7XaLQNgRY6eDdhrElqGpWdE9b07hYSdog4DzH+k4V1rC6wyegRWvd9g1xHdQeCsmazY/fn++RjaRnZmwwYteI8SfO+fBtdOSuBoH7LIvz6gcX3plRH+k46vjgytgGFF6O6YzfgHewwipsyuh3EAfl8HxEiZwO/ggOMUnoEJ0YhvV7HiXspfucdWIKuePdLsAo9z9VwgRVWgyZQINHkPJgi7uS0dJjmASdOKglK512BqXJGk6VhYlUVYizKm26sW5Pm0G/uytCRbo3I1G0kYMIOkGz/OnOHHP3Gz8PLG7PrIifBVyHsjDqFBt6FG2oYiezg6pgaK34Xp1FVTC2mCfojMsQcXWgEnd6/x428I9cnAQ4fp5EcceRSKhh5KqlSMVHys7DG4l1xYJptrg9dc6OKNiQHhcHDnhmjkOzyC6SCe8iP7Cb6OMyRBvVhBfcK8SA2fohniau7zTM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PwHJIKtrcXTv3dEddLqGPMKcF/2sXGfDCX77tR8nZSFayj8aQ9+IYRx+hEPb?= =?us-ascii?Q?LX8SOfJNQqE3MEHdZSLQ03vQs6BIAPhP7XuPptUbP72InkzMLvJqCY+cgYvm?= =?us-ascii?Q?cCV9B8Tc1d2l1riPTtwzrE6XVNkwsfwL8mJP+HqAxZdOleigMzoQtJfbnvyn?= =?us-ascii?Q?/xSukV+tlsvMObwjL0Ngp5UGIXi48eLs/bIQsCZiGLobgQ93ZO38OtJKBaCr?= =?us-ascii?Q?SCru3ystlyhjQv1CgDfKCS+MVcYa2gPPvS6I7Tkd+5gvdBOjJKQvqTWT4J64?= =?us-ascii?Q?qv4Cl0DmzeQ9aT6dYpCt3KL20v7thjOmOdjH8jtW7GcXHYal5DbfbMb44KUo?= =?us-ascii?Q?GXCZ7zMUbJ48wtvFgKauD+TORDaMueF7y6FHr7i0RPOxtKYw2K4znE8HWLPz?= =?us-ascii?Q?5ah/UchgPQybY3nRVWIas5qoO89yDqIdNmFI3H1ZWnb5pzQyWJNI19xEErIs?= =?us-ascii?Q?ziV/4kVI/lBLa1Qqrg1CtYaxnIBeAGL9M3pjUk/SaMEpXabRT4dyQdftcT+m?= =?us-ascii?Q?2bGCETHIHKM4p3bjJBlGkNqtFawgvf0sB9ETyow96Bc0fHD9l4csWqTtZpbD?= =?us-ascii?Q?wxmDMNxyz0OaiCuDPym9n8NxZCUIoInVYV/JZGUehqdCKWge026hlZTX3pj4?= =?us-ascii?Q?/7YfNlM+ohpBNB6xaOb8/4w2iXoSReTOl/vKU39U9lIo/LllqJ24GBTUUKDo?= =?us-ascii?Q?mhFA4mveK3gJ19nBQhdh5zAngbqM2ET+Mtg3Ng89Lu9HhLSmHRys2WfSbhO2?= =?us-ascii?Q?FBDpHcj7pdjsfPa28ZKDWMrNq+VGARFZ501fpb6XSyeZ/+R9HbnyNDNtrtHE?= =?us-ascii?Q?FQmuY5qu/1DUwQ3584PVQxPFR4rNgPtfVA8a/mqZoaeD5I87JoYDuuN1Tf2A?= =?us-ascii?Q?RyKhJAQ8RgmlvKeu4rh/hgGr/p1n5ESnQ1nIxpzWbbBUV/0NUalyVPSXctxQ?= =?us-ascii?Q?EHO9Sky4kHK6tZN6Dj9UlZBur11AGEjKnPBr2n/+P2tCvK9rM96CsGYrDurE?= =?us-ascii?Q?3y6M5HNBPVkKh4qbpTF7N00eA/rLbv5337ye0JcmUiEnezdtCf7Vi4zPh+c5?= =?us-ascii?Q?NdZjo4HyA/UIVY5neX/zaRE9lBMpCVesIIfXZbxWWYZVnmWiPNiGpf9I724n?= =?us-ascii?Q?NKUrmsxbBIj/FwB/QFM4UblggRwCimjT8mbdOK1uWrj5DmZimBWA+QTsBQHe?= =?us-ascii?Q?iwIp6B1iODy+l63wDBJ85PljE1WSEy0Z3HqnMHchAdA86TE1fuFGTDLdOlkn?= =?us-ascii?Q?UEUPvOqk4fuCdL38kR8Z/pBKwgse0TAdQH4DTsbUdCKc4N2BaF8MlFsml7iH?= =?us-ascii?Q?+PXBZOv0w1HmDnKTbYj4jBiw/BFSZz+kuEP8dM9g8+PjAbmRCDo6/jlVIk62?= =?us-ascii?Q?wWy5RNWBl4+Kmk9Ls1FkEdxrmOypW0XSQ0nP9xwWQQYnVn0+9TOjI/sZ1LTl?= =?us-ascii?Q?4bly/yxo73QpMd+UyrM7KIN7QwvQI/ZvJjxj8nDDF/gcmg+y+MBUnHhiKoLw?= =?us-ascii?Q?9Thx5ZOQYP3y3so8JzACC5d0Sr8xwPNGtsKuBbPiV1tVlNi8rX2N/O375Xcc?= =?us-ascii?Q?GCrGWzYuyYW2lI3t5nUUS8QYmliCkiQBeDR0m0Nwc490C4fWTStJidkd1bOV?= =?us-ascii?Q?eLiMnF08Nlely8fIBxlSvb4EHk3gdJZ1Sj2RZltBhaOAhiGRwX7nGD05Pvw9?= =?us-ascii?Q?EkzVTO+TwGqEJdIdQQgHdBojMjOY/W8HsUkeKJItitxa01rimdLXoR4ozu/d?= =?us-ascii?Q?IGEH3kIyLg=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6744eef6-e35d-4a99-376a-08dea534ae61 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 14:44:41.7173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +brYXtgOVR44ufelqgq1HXKvn7iNfMZBd7y6SBbrmV3Ljq3Yb4MMUdVYjaARdGO0XnUnA8PCFph0kVf0HMW6BA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6211 Content-Type: text/plain; charset="utf-8" From: K Prateek Nayak Add to select_idle_capacity() the same SIS_UTIL-controlled idle-scan mechanism, already used by select_idle_cpu(): when sched_feat(SIS_UTIL) is enabled and the LLC domain has sched_domain_shared data, derive the per-attempt scan limit from sd->shared->nr_idle_scan. That bounds the walk on large LLCs and allows an early return once the scan limit is reached, if we already picked a sufficiently strong idle-core candidate (best_fits =3D=3D ASYM_IDLE_CORE_UCLAMP_MISFIT). Co-developed-by: Andrea Righi Signed-off-by: Andrea Righi Signed-off-by: K Prateek Nayak --- kernel/sched/fair.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index a1f4d70f6b3d9..1cde3a9b1e0f5 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8018,6 +8018,7 @@ select_idle_capacity(struct task_struct *p, struct sc= hed_domain *sd, int target) int fits, best_fits =3D ASYM_IDLE_COMPLETE_MISFIT; int cpu, best_cpu =3D -1; struct cpumask *cpus; + int nr =3D INT_MAX; =20 cpus =3D this_cpu_cpumask_var_ptr(select_rq_mask); cpumask_and(cpus, sched_domain_span(sd), p->cpus_ptr); @@ -8026,10 +8027,28 @@ select_idle_capacity(struct task_struct *p, struct = sched_domain *sd, int target) util_min =3D uclamp_eff_value(p, UCLAMP_MIN); util_max =3D uclamp_eff_value(p, UCLAMP_MAX); =20 + if (sched_feat(SIS_UTIL) && sd->shared) { + /* + * Same nr_idle_scan hint as select_idle_cpu(), nr only limits + * the scan when not preferring an idle core. + */ + nr =3D READ_ONCE(sd->shared->nr_idle_scan) + 1; + /* overloaded domain is unlikely to have idle cpu/core */ + if (nr =3D=3D 1) + return -1; + } + for_each_cpu_wrap(cpu, cpus, target) { bool preferred_core =3D !prefers_idle_core || is_core_idle(cpu); unsigned long cpu_cap =3D capacity_of(cpu); =20 + /* + * Good-enough early exit (mirrors select_idle_cpu() logic). + */ + if (!prefers_idle_core && + --nr <=3D 0 && best_fits =3D=3D ASYM_IDLE_CORE_UCLAMP_MISFIT) + return best_cpu; + if (!choose_idle_cpu(cpu, p)) continue; =20 --=20 2.54.0