From nobody Wed Jun 17 02:51:55 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BD8940148E for ; Tue, 28 Apr 2026 12:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777379365; cv=none; b=J2CpYBvc8DgzxOQWiw/uovQ2MBMmk3NZcUaZ48o3S6o13ymQ1K6baBdiGXEG5LFQfv0Ybiepw+kffy4XBpTCQ+9kn2Ol7ZlZp+8Ww++ndjbV6mOHPQhXHnDpXiivx9c42bRCm6vNFpCgP7oEbQkQzPHS/pYT4373AHV3jgpUmqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777379365; c=relaxed/simple; bh=48hLkLcuqglnw2BgHRdVCcu2MVzzLFSBoZev3z+q95c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IqNvtF41R+GXXsSotjLASa4iGgBauC+L95pENNNfVg/8BQRhx8rO30+l2+rQRqlEfWoeU96DoyewHJGdY4RUA4N8e6L2BOKnYwaD1dxpoqe4koeGztawmkJrgPeMwcwW3LbNe5a+jvC+9tYEueoqwXIHpZJCYyPcYkZlPoenEYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QYQOpq5u; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QYQOpq5u" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48374014a77so146798055e9.3 for ; Tue, 28 Apr 2026 05:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777379356; x=1777984156; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=pxy6ZGKNTBMlQ919OQUf8LPjYtJBrijDPBcvlSgOSGs=; b=QYQOpq5u8mbDeIidc69BEDGbE2PrXb9o2oHGjkOadDtnSvP/Bdy2uUPRSLFriLagPf ubXyrFfq+YlIPvKKFoCDzPqz54Vt6k0+9bA/T87O+QaFPdHhY7SA/xrWiukRH8pSAvvM nEarAFLyptzByVkTxVSeae9Q28XVxnQ2NRSVuQc94RuGdxU+1pHfllaVQ3F0ijvoY0Vz Rlb5Fy2b/H9R7iopb5nE65mDHDQKnZVIoFJX5MV1OcEPuYmk6Y36jlyvKrx4pLByKX1f dE7FDbroGWK9VAwjXn7e+hOmdorrVGpt3xWnJS0oTF+TdQuIvJvfwQzVbvPWnam3Wolf VoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777379356; x=1777984156; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pxy6ZGKNTBMlQ919OQUf8LPjYtJBrijDPBcvlSgOSGs=; b=j1TfWB4Z3oDyjZixlNdK+G3NBNVAMSXALRxHgG/uNNqpFb7fBzeUF5hFPakRTn/Q58 ofZVQW8O85eqY+sQgA1yqmkG4eau8r22ol8GBiMguK3kZesnA63Pb3UnMV8Cm5+q/WMt Y5NHtm8ZNUImqvMYYQbyqQckh0wioVZk3DwwVvTqkwCM//RBUCtZuNdaInD1mj45MYQ9 43EinE7ixKPNDUMOH/eek2HccdEUwZsW5jcJ3LEegLR6TmVuIL5P2UwIN9Rg4b7AhgpO RWoff1pyb/xUrHcXrekEduq4VaKQX+A7TjD23qNUedam9K2FIA0HSzI0doo7Ft4MqF6+ dToA== X-Forwarded-Encrypted: i=1; AFNElJ+EkZmFhX77KXaLTPqb9IbjO+iM15mRWFbUGMFm0VZzOvD6mGubO1GuimQ1GE6KM7PPjqznuRDkekwYnbo=@vger.kernel.org X-Gm-Message-State: AOJu0YzNCl9oGetlKs7BXQZ6v/gjccMMNekqPRHLrI5xHljFrOAOxXKB VHsHCZd1hkm4rXQazW6xbsLfn3p0OU7mFHITDjsoU1p4Aka+/KGsTQO/ X-Gm-Gg: AeBDieuUcNVpSuvnF6Eh5ajh11Nh1hhPb8e4VUQ1eGmSR04BW3SR+PIfXC9Km7Si3Kr adMJe9x1bcPs4H+RTbsMJG/PUC7HABVhVOL93Q8TYumOvRCJk9MC9v7kswDJiSQItTgnrVad9uE Xlx+EvN7B58e+3P7PzzBUAnYwdPB6bzr4BJT95giMsu+R6Wgfpc4gI9slWODeKgkAr+QR2zu51W IpEj/QWlBiHR2icv6MI/Rm/ZtbEt/zNx0vuLfrdKzoor1rD7bfPhyQMHoi6utu9hUYzWDKQqfQX EfhOOYPuHPyDnzM2GoGILgMuhbqHtU5UlB12dLQ1IeAk4oAGXBoqAmdWd1PzDwK8d4uEXyELwxC gmSNOB0vKWKnj6vX3ofr2mA1VgkMR6aWvmyVWXjVOufGlaDQb4keEUFYCitR/rl42hNqa7yv3L+ HVxRuCiuWLtXISVYfHzNt0hR5RcrPZxYEtNS5+U2sYiiIW6BJSsyfYXHCAhAlXi4EBtPtSx08Rz g== X-Received: by 2002:a05:600c:1e8b:b0:489:1ff1:74d3 with SMTP id 5b1f17b1804b1-48a77b146e0mr45595125e9.20.1777379355653; Tue, 28 Apr 2026 05:29:15 -0700 (PDT) Received: from localhost.localdomain (90-181-198-146.rco.o2.cz. [90.181.198.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a77af1b86sm47479045e9.5.2026.04.28.05.29.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 05:29:15 -0700 (PDT) Sender: Alban Crequy From: Alban Crequy To: Andrew Morton , David Hildenbrand , Christian Brauner Cc: Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alban Crequy , Alban Crequy , Peter Xu , Willy Tarreau , linux-kselftest@vger.kernel.org, shuah@kernel.org, Usama Arif , David Laight Subject: [PATCH v3 1/2] mm/process_vm_access: pidfd and nowait support for process_vm_readv/writev Date: Tue, 28 Apr 2026 14:28:25 +0200 Message-ID: <20260428122826.339550-2-alban.crequy@gmail.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20260428122826.339550-1-alban.crequy@gmail.com> References: <20260428122826.339550-1-alban.crequy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Alban Crequy There are two categories of users for process_vm_readv: 1. Debuggers like GDB or strace. When a debugger attempts to read the target memory and triggers a page fault, the page fault needs to be resolved so that the debugger can accurately interpret the memory. A debugger is typically attached to a single process. 2. Profilers like OpenTelemetry eBPF Profiler. The profiler uses a perf event to get stack traces from all processes at 20Hz (20 stack traces to resolve per second). For interpreted languages (Ruby, Python, etc.), the profiler uses process_vm_readv to get the correct symbols. In this case, performance is the most important. It is fine if some stack traces cannot be resolved as long as it is not statistically significant. The current behaviour of process_vm_readv is to resolve page faults in the target VM. This is as desired for debuggers, but unwelcome for profilers because the page fault resolution could take a lot of time depending on the backing filesystem. Additionally, since profilers monitor all processes, we don't want a slow page fault resolution for one target process slowing down the monitoring for all other target processes. This patch adds the flag PROCESS_VM_NOWAIT, so the caller can choose to not block on IO if the memory access causes a page fault. Additionally, this patch adds the flag PROCESS_VM_PIDFD to refer to the remote process via PID file descriptor instead of PID. Such a file descriptor can be obtained with pidfd_open(2). This is useful to avoid the pid number being reused. It is unlikely to happen for debuggers because they can monitor the target process termination in other ways (ptrace), but can be helpful in some profiling scenarios. If a given flag is unsupported, the syscall returns the error EINVAL without checking the buffers. This gives a way to userspace to detect whether the current kernel supports a specific flag: process_vm_readv(pid, NULL, 1, NULL, 1, PROCESS_VM_PIDFD) -> EINVAL if the kernel does not support the flag PROCESS_VM_PIDFD (before this patch) -> EFAULT if the kernel supports the flag (after this patch) Signed-off-by: Alban Crequy --- v3: - Fix ERR_PTR handling for pidfd_get_task(): use IS_ERR()/PTR_ERR() for the pidfd path, matching process_madvise() (Usama Arif, Sashiko) v2: - Expand commit message with use-case motivation (David Hildenbrand) - Use unsigned long consistently for pvm_flags parameter (David Hildenbrand) - Add PROCESS_VM_SUPPORTED_FLAGS kernel-internal define (David Hildenbrand) - Keep (1UL << N) in UAPI header: BIT() is defined in vdso/bits.h which is not exported to userspace, so UAPI headers using BIT() would break when included from userspace programs (David Hildenbrand) MAINTAINERS | 1 + include/uapi/linux/process_vm.h | 9 +++++++++ mm/process_vm_access.c | 34 ++++++++++++++++++++++++--------- 3 files changed, 35 insertions(+), 9 deletions(-) create mode 100644 include/uapi/linux/process_vm.h diff --git a/MAINTAINERS b/MAINTAINERS index 2fb1c75afd16..0f6ce21d6235 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -16786,6 +16786,7 @@ F: include/linux/ptdump.h F: include/linux/vmpressure.h F: include/linux/vmstat.h F: fs/proc/meminfo.c +F: include/uapi/linux/process_vm.h F: kernel/fork.c F: mm/Kconfig F: mm/debug.c diff --git a/include/uapi/linux/process_vm.h b/include/uapi/linux/process_v= m.h new file mode 100644 index 000000000000..4168e09f3f4e --- /dev/null +++ b/include/uapi/linux/process_vm.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +#ifndef _UAPI_LINUX_PROCESS_VM_H +#define _UAPI_LINUX_PROCESS_VM_H + +/* Flags for process_vm_readv/process_vm_writev */ +#define PROCESS_VM_PIDFD (1UL << 0) +#define PROCESS_VM_NOWAIT (1UL << 1) + +#endif /* _UAPI_LINUX_PROCESS_VM_H */ diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index 656d3e88755b..dacef50be0be 100644 --- a/mm/process_vm_access.c +++ b/mm/process_vm_access.c @@ -14,6 +14,9 @@ #include #include #include +#include + +#define PROCESS_VM_SUPPORTED_FLAGS (PROCESS_VM_PIDFD | PROCESS_VM_NOWAIT) =20 /** * process_vm_rw_pages - read/write pages from task specified @@ -68,6 +71,7 @@ static int process_vm_rw_pages(struct page **pages, * @mm: mm for task * @task: task to read/write from * @vm_write: 0 means copy from, 1 means copy to + * @pvm_flags: PROCESS_VM_* flags * Returns 0 on success or on failure error code */ static int process_vm_rw_single_vec(unsigned long addr, @@ -76,7 +80,8 @@ static int process_vm_rw_single_vec(unsigned long addr, struct page **process_pages, struct mm_struct *mm, struct task_struct *task, - int vm_write) + int vm_write, + unsigned long pvm_flags) { unsigned long pa =3D addr & PAGE_MASK; unsigned long start_offset =3D addr - pa; @@ -91,6 +96,8 @@ static int process_vm_rw_single_vec(unsigned long addr, =20 if (vm_write) flags |=3D FOLL_WRITE; + if (pvm_flags & PROCESS_VM_NOWAIT) + flags |=3D FOLL_NOWAIT; =20 while (!rc && nr_pages && iov_iter_count(iter)) { int pinned_pages =3D min_t(unsigned long, nr_pages, PVM_MAX_USER_PAGES); @@ -141,7 +148,7 @@ static int process_vm_rw_single_vec(unsigned long addr, * @iter: where to copy to/from locally * @rvec: iovec array specifying where to copy to/from in the other process * @riovcnt: size of rvec array - * @flags: currently unused + * @flags: process_vm_readv/writev flags * @vm_write: 0 if reading from other process, 1 if writing to other proce= ss * * Returns the number of bytes read/written or error code. May @@ -163,6 +170,7 @@ static ssize_t process_vm_rw_core(pid_t pid, struct iov= _iter *iter, unsigned long nr_pages_iov; ssize_t iov_len; size_t total_len =3D iov_iter_count(iter); + unsigned int f_flags; =20 /* * Work out how many pages of struct pages we're going to need @@ -194,10 +202,18 @@ static ssize_t process_vm_rw_core(pid_t pid, struct i= ov_iter *iter, } =20 /* Get process information */ - task =3D find_get_task_by_vpid(pid); - if (!task) { - rc =3D -ESRCH; - goto free_proc_pages; + if (flags & PROCESS_VM_PIDFD) { + task =3D pidfd_get_task(pid, &f_flags); + if (IS_ERR(task)) { + rc =3D PTR_ERR(task); + goto free_proc_pages; + } + } else { + task =3D find_get_task_by_vpid(pid); + if (!task) { + rc =3D -ESRCH; + goto free_proc_pages; + } } =20 mm =3D mm_access(task, PTRACE_MODE_ATTACH_REALCREDS); @@ -215,7 +231,7 @@ static ssize_t process_vm_rw_core(pid_t pid, struct iov= _iter *iter, for (i =3D 0; i < riovcnt && iov_iter_count(iter) && !rc; i++) rc =3D process_vm_rw_single_vec( (unsigned long)rvec[i].iov_base, rvec[i].iov_len, - iter, process_pages, mm, task, vm_write); + iter, process_pages, mm, task, vm_write, flags); =20 /* copied =3D space before - space after */ total_len -=3D iov_iter_count(iter); @@ -244,7 +260,7 @@ static ssize_t process_vm_rw_core(pid_t pid, struct iov= _iter *iter, * @liovcnt: size of lvec array * @rvec: iovec array specifying where to copy to/from in the other process * @riovcnt: size of rvec array - * @flags: currently unused + * @flags: process_vm_readv/writev flags * @vm_write: 0 if reading from other process, 1 if writing to other proce= ss * * Returns the number of bytes read/written or error code. May @@ -266,7 +282,7 @@ static ssize_t process_vm_rw(pid_t pid, ssize_t rc; int dir =3D vm_write ? ITER_SOURCE : ITER_DEST; =20 - if (flags !=3D 0) + if (flags & ~PROCESS_VM_SUPPORTED_FLAGS) return -EINVAL; =20 /* Check iovecs */ --=20 2.45.0 From nobody Wed Jun 17 02:51:55 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71B1C421F1D for ; Tue, 28 Apr 2026 12:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777379373; cv=none; b=Qfsedea4EetNgqn9PqvhfAi4/nwlmEl6bz5QI/EIFRNU8rAAAG3f9DbpQ3rNFK3N5AnlPwCMTSlnVEqucdghBJC4jm8hATL6MNOH6N5eaB7/rROtwEens739gah6Fedw4n1thOCMfescINQY4KifkvBGEmtXlUB0g2t2rtKE8ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777379373; c=relaxed/simple; bh=ihAtwJPUcbxqQIsZHe6vUCQXbalmIqVwe2eaWbnHNz8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CmOStyeA48uBlbkobFA11QNcKpLsms1ssCdA2G7nRNqJxRwtwU7ci8hQ95lSQ3FptOLG12Ye0Ho7+MY4z71OWpy9MOpkqupnXwLgKn1DdqFETesuEa6jPInmWiy9ZcRiLU/TkUnU2cGVeMLk9R3xymIzOEQ4z8jr5IZ5r89F9zc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFzOWGrJ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFzOWGrJ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-483487335c2so110437405e9.2 for ; Tue, 28 Apr 2026 05:29:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777379364; x=1777984164; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=mIZKdDhTnPDWJkdLmdF0ct42LRqQxNma8jQA8xXSthI=; b=LFzOWGrJY1CFw+a7721nTtgl1Ptm0imH0EixYPI+VxvbBoVt1XhZmtwn8qRYrQQypH Df1iifVOTJjpn1ChRE/DUKzqunGT1PMjOMrLmAsxh7Zinn0cRW8xNiA9McV88AJHjTQe YtV69PKxE0uV7B1iQ/fZQStQa4+Ox+EJSXtxxhUlRO559HewClGIvz3thU9LKsy6fRBe u5/VLrMnwt103nDT2y+AUFcZqecD6s3Lm2YR6/2CFz1RA2Pj9vOYZ9g1v/a17/3slF0n WlaX0OiklSHXrz97VDI+Vg+tLF7yLXt+2swV6MiIjOuA+Biqd6aYhwUbhXtxErEeWadK PzCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777379364; x=1777984164; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mIZKdDhTnPDWJkdLmdF0ct42LRqQxNma8jQA8xXSthI=; b=rtAe9ScmMXlV42/niEZk2HzuUMr1UCy22MjiCf3I7ATUW3oq4Lxc/dh5cl8MGGVdRv +JtBZ7ka0jcyjIVxUl3bcxkT3sNh0Ox7zA2BRnQPg/WZCe8t1G1OyHd6FzIbLoG6tQsd TYOlK3O0qQHWkC4PiQ8g2y5ZQngeDe4ZqOodH6c0m9hP7X58UcPaYkbe7mWh3OwpK4Z7 JBusPVBcGkHoEaLZE3WNwJV/TU4tzvWOXTduGcGABB7j2odwyZ/bzIcP99S78Pb91+k8 MjPy5RlAs9XSDha2V4RQO+WmBeLPsd8bsEyNaRoCadfDaHaUiJscp2hNyIHf106s8aH0 fJxg== X-Forwarded-Encrypted: i=1; AFNElJ9L3dBbQJwazoDgHFStg/jw38jEAe3SdIH3rPemc+AWhWgYE0wi6rAUh8SnPPvCql67d+G9PKJtGPD8bcM=@vger.kernel.org X-Gm-Message-State: AOJu0YxPu1jP59R8m6vpWpK4AYPQv5ZdAds6kD98jZGMoHQYcoafkm6l zIxfJbffKUKJZweTiv4Kf8fJBRGYTalFRBOZm0hJp/xteEc5MFJJpg7z X-Gm-Gg: AeBDietf9gkpBtydQZGKwXy311ayT2j06GYbtVJ8IzJQJqfrLaGBHQHg/BuhAxhIR/R MxCs4EUWmS2nOHsY/DEwPkbAvI7VkjtekIFVY8BK+o3AuJdTMrZbph+hFgSZm9gm212sPnDXYBq 73zVTuiI3mbrEztnZmi9KFncN/hvvxa2xRFs5m9m1v2Qd05l702EUC2XrwfkgHJcyiQeGxSP5V4 oCnQqwQFubFIH+IupP5wr2k5U1XkwFMQygUQ/KbmgXYX/iEjQ34sGre1L3qsK1zulRhExxdyTCP skEtkPrGyI6EW4Wtl+NE6UXrnKJt6/8nLL+h7J+BXW6WDQ4nwMcQfyTlIbBvUMTZM1KfCdCTnDA Gq7Afzxt1raoevFYvNxFb6K0NYP6phd11zvbn+P/ZtSj4tlzaRsPmJqRTy3CzmT0Hn1ay/h/h21 4Wr8vLGbM5Jpyskf2NtptMLleg4xHMpnGHLk3zbz5ejffxJDt9t2ngj3UmAjvBx7bQXWd9Smfsz A== X-Received: by 2002:a05:600c:c048:b0:489:1ae1:4eb9 with SMTP id 5b1f17b1804b1-48a77b233e4mr28855135e9.28.1777379363615; Tue, 28 Apr 2026 05:29:23 -0700 (PDT) Received: from localhost.localdomain (90-181-198-146.rco.o2.cz. [90.181.198.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a77af1b86sm47479045e9.5.2026.04.28.05.29.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 05:29:23 -0700 (PDT) Sender: Alban Crequy From: Alban Crequy To: Andrew Morton , David Hildenbrand , Christian Brauner Cc: Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alban Crequy , Alban Crequy , Peter Xu , Willy Tarreau , linux-kselftest@vger.kernel.org, shuah@kernel.org, Usama Arif , David Laight Subject: [PATCH v3 2/2] selftests/mm: add tests for process_vm_readv flags Date: Tue, 28 Apr 2026 14:28:26 +0200 Message-ID: <20260428122826.339550-3-alban.crequy@gmail.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20260428122826.339550-1-alban.crequy@gmail.com> References: <20260428122826.339550-1-alban.crequy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Alban Crequy Add selftests for the PROCESS_VM_PIDFD and PROCESS_VM_NOWAIT flags introduced in process_vm_readv/writev. Tests cover: - basic read with no flags - invalid flags (EINVAL) - invalid address (EFAULT) - flag validation precedence over address validation - invalid pidfd (EBADF) - invalid pid (ESRCH) - PROCESS_VM_PIDFD: read via pidfd - PROCESS_VM_NOWAIT: read from resident memory - PROCESS_VM_PIDFD | PROCESS_VM_NOWAIT combined - userfaultfd blocking read (no flags) - PROCESS_VM_NOWAIT with userfaultfd (non-blocking, returns EFAULT) Signed-off-by: Alban Crequy --- v3: - Add selftest for invalid pidfd (David Hildenbrand) - Add selftest for invalid pid - SKIP on kernels without PROCESS_VM_PIDFD support - Remove hardcoded __NR_pidfd_open fallback, use (Sashiko) - SKIP pidfd tests on kernels without pidfd_open (ENOSYS) (Sashiko) - SKIP userfaultfd tests when unprivileged userfaultfd is disabled (EPERM) = (Sashiko) - Fault in test_data before NOWAIT tests to ensure page is resident (Sashik= o) - Add ksft_process_vm_readv.sh wrapper and run_vmtests.sh entry v2: - New patch. tools/testing/selftests/mm/Makefile | 2 + .../selftests/mm/ksft_process_vm_readv.sh | 4 + tools/testing/selftests/mm/process_vm_readv.c | 421 ++++++++++++++++++ tools/testing/selftests/mm/run_vmtests.sh | 4 + 4 files changed, 431 insertions(+) create mode 100755 tools/testing/selftests/mm/ksft_process_vm_readv.sh create mode 100644 tools/testing/selftests/mm/process_vm_readv.c diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/= mm/Makefile index cd24596cdd27..feb3a0b9a57e 100644 --- a/tools/testing/selftests/mm/Makefile +++ b/tools/testing/selftests/mm/Makefile @@ -106,6 +106,7 @@ TEST_GEN_FILES +=3D guard-regions TEST_GEN_FILES +=3D merge TEST_GEN_FILES +=3D rmap TEST_GEN_FILES +=3D folio_split_race_test +TEST_GEN_FILES +=3D process_vm_readv =20 ifneq ($(ARCH),arm64) TEST_GEN_FILES +=3D soft-dirty @@ -167,6 +168,7 @@ TEST_PROGS +=3D ksft_pfnmap.sh TEST_PROGS +=3D ksft_pkey.sh TEST_PROGS +=3D ksft_process_madv.sh TEST_PROGS +=3D ksft_process_mrelease.sh +TEST_PROGS +=3D ksft_process_vm_readv.sh TEST_PROGS +=3D ksft_rmap.sh TEST_PROGS +=3D ksft_soft_dirty.sh TEST_PROGS +=3D ksft_thp.sh diff --git a/tools/testing/selftests/mm/ksft_process_vm_readv.sh b/tools/te= sting/selftests/mm/ksft_process_vm_readv.sh new file mode 100755 index 000000000000..09d0fcc9a35d --- /dev/null +++ b/tools/testing/selftests/mm/ksft_process_vm_readv.sh @@ -0,0 +1,4 @@ +#!/bin/sh -e +# SPDX-License-Identifier: GPL-2.0 + +./run_vmtests.sh -t process_vm_readv diff --git a/tools/testing/selftests/mm/process_vm_readv.c b/tools/testing/= selftests/mm/process_vm_readv.c new file mode 100644 index 000000000000..0479ae424c78 --- /dev/null +++ b/tools/testing/selftests/mm/process_vm_readv.c @@ -0,0 +1,421 @@ +// SPDX-License-Identifier: GPL-2.0-only +#define _GNU_SOURCE +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "kselftest_harness.h" + +#ifndef PROCESS_VM_PIDFD +#define PROCESS_VM_PIDFD (1UL << 0) +#endif + +#ifndef PROCESS_VM_NOWAIT +#define PROCESS_VM_NOWAIT (1UL << 1) +#endif + +static int sys_pidfd_open(pid_t pid, unsigned int flags) +{ + return syscall(__NR_pidfd_open, pid, flags); +} + +static const uint8_t test_data[] =3D { 0x01, 0x02, 0x03, 0x04, + 0x05, 0x06, 0x07, 0x08 }; +#define POISON_BYTE 0xCC + +/* + * Test: basic process_vm_readv with no flags + */ +TEST(read_basic) +{ + uint8_t buf[sizeof(test_data)]; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + + memset(buf, POISON_BYTE, sizeof(buf)); + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, 0); + ASSERT_EQ(sizeof(test_data), n); + ASSERT_EQ(0, memcmp(buf, test_data, sizeof(test_data))); +} + +/* + * Test: invalid flags should return EINVAL + */ +TEST(read_invalid_flags) +{ + uint8_t buf[8] =3D { 0 }; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, 255); + ASSERT_EQ(-1, n); + ASSERT_EQ(EINVAL, errno); +} + +/* + * Test: invalid address should return EFAULT + */ +TEST(read_invalid_address) +{ + uint8_t buf[8] =3D { 0 }; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { .iov_base =3D NULL, .iov_len =3D 8 }; + ssize_t n; + + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, 0); + ASSERT_EQ(-1, n); + ASSERT_EQ(EFAULT, errno); +} + +/* + * Test: invalid address with invalid flags should return EINVAL + * (flag check happens before address validation) + */ +TEST(read_invalid_address_invalid_flags) +{ + uint8_t buf[8] =3D { 0 }; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { .iov_base =3D NULL, .iov_len =3D 8 }; + ssize_t n; + + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, 255); + ASSERT_EQ(-1, n); + ASSERT_EQ(EINVAL, errno); +} + +/* + * Test: invalid address with all valid flags should return EFAULT + * (flags are valid so we get past the flag check to the address check) + */ +TEST(read_invalid_address_all_valid_flags) +{ + int pidfd; + struct iovec local_iov =3D { .iov_base =3D NULL, .iov_len =3D 8 }; + struct iovec remote_iov =3D { .iov_base =3D NULL, .iov_len =3D 8 }; + ssize_t n; + + pidfd =3D sys_pidfd_open(getpid(), 0); + if (pidfd < 0 && errno =3D=3D ENOSYS) + SKIP(return, "pidfd_open not supported"); + ASSERT_GE(pidfd, 0); + + n =3D process_vm_readv(pidfd, &local_iov, 1, &remote_iov, 1, + PROCESS_VM_PIDFD | PROCESS_VM_NOWAIT); + ASSERT_EQ(-1, n); + ASSERT_EQ(EFAULT, errno); + + close(pidfd); +} + +/* + * Test: read with an invalid pidfd should return an error, not crash + */ +TEST(read_invalid_pidfd) +{ + uint8_t buf[sizeof(test_data)] =3D { 0 }; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + + /* fd 9999 is almost certainly not a valid pidfd */ + n =3D process_vm_readv(9999, &local_iov, 1, &remote_iov, 1, + PROCESS_VM_PIDFD); + ASSERT_EQ(-1, n); + if (errno =3D=3D EINVAL) + SKIP(return, "PROCESS_VM_PIDFD not supported"); + ASSERT_EQ(EBADF, errno); +} + +/* + * Test: read with an invalid pid should return ESRCH + */ +TEST(read_invalid_pid) +{ + uint8_t buf[sizeof(test_data)] =3D { 0 }; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + + /* pid 999999 is almost certainly not a valid process */ + n =3D process_vm_readv(999999, &local_iov, 1, &remote_iov, 1, 0); + ASSERT_EQ(-1, n); + ASSERT_EQ(ESRCH, errno); +} + +/* + * Test: read with PIDFD flag + */ +TEST(read_pidfd) +{ + uint8_t buf[sizeof(test_data)]; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + int pidfd; + + memset(buf, POISON_BYTE, sizeof(buf)); + pidfd =3D sys_pidfd_open(getpid(), 0); + if (pidfd < 0 && errno =3D=3D ENOSYS) + SKIP(return, "pidfd_open not supported"); + ASSERT_GE(pidfd, 0); + + n =3D process_vm_readv(pidfd, &local_iov, 1, &remote_iov, 1, + PROCESS_VM_PIDFD); + ASSERT_EQ(sizeof(test_data), n); + ASSERT_EQ(0, memcmp(buf, test_data, sizeof(test_data))); + + close(pidfd); +} + +/* + * Test: read with NOWAIT from resident memory (should succeed) + */ +TEST(read_nowait_resident) +{ + uint8_t buf[sizeof(test_data)]; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + + *(volatile uint64_t *)test_data; /* fault in page for NOWAIT */ + memset(buf, POISON_BYTE, sizeof(buf)); + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, + PROCESS_VM_NOWAIT); + ASSERT_EQ(sizeof(test_data), n); + ASSERT_EQ(0, memcmp(buf, test_data, sizeof(test_data))); +} + +/* + * Test: read with PIDFD + NOWAIT from resident memory + */ +TEST(read_pidfd_nowait_resident) +{ + uint8_t buf[sizeof(test_data)]; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov =3D { + .iov_base =3D (void *)test_data, + .iov_len =3D sizeof(test_data) + }; + ssize_t n; + int pidfd; + + *(volatile uint64_t *)test_data; /* fault in page for NOWAIT */ + memset(buf, POISON_BYTE, sizeof(buf)); + pidfd =3D sys_pidfd_open(getpid(), 0); + if (pidfd < 0 && errno =3D=3D ENOSYS) + SKIP(return, "pidfd_open not supported"); + ASSERT_GE(pidfd, 0); + + n =3D process_vm_readv(pidfd, &local_iov, 1, &remote_iov, 1, + PROCESS_VM_PIDFD | PROCESS_VM_NOWAIT); + ASSERT_EQ(sizeof(test_data), n); + ASSERT_EQ(0, memcmp(buf, test_data, sizeof(test_data))); + + close(pidfd); +} + +/* + * Userfaultfd helpers for NOWAIT tests + */ +static int setup_userfaultfd(void) +{ + struct uffdio_api api =3D { .api =3D UFFD_API }; + int uffd; + + uffd =3D syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK); + if (uffd < 0) + return -errno; + + if (ioctl(uffd, UFFDIO_API, &api)) { + close(uffd); + return -errno; + } + + return uffd; +} + +static void *register_uffd_region(int uffd, size_t size) +{ + struct uffdio_register reg; + void *mem; + + mem =3D mmap(NULL, size, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (mem =3D=3D MAP_FAILED) + return NULL; + + reg.range.start =3D (unsigned long)mem; + reg.range.len =3D size; + reg.mode =3D UFFDIO_REGISTER_MODE_MISSING; + if (ioctl(uffd, UFFDIO_REGISTER, ®)) { + munmap(mem, size); + return NULL; + } + + return mem; +} + +struct uffd_handler_args { + int uffd; + const void *content; + size_t content_len; +}; + +static void *uffd_handler_thread(void *arg) +{ + struct uffd_handler_args *ha =3D arg; + struct uffd_msg msg; + struct uffdio_copy uffd_copy; + struct pollfd pfd =3D { + .fd =3D ha->uffd, + .events =3D POLLIN + }; + void *page; + long page_size =3D sysconf(_SC_PAGESIZE); + int ret; + + page =3D mmap(NULL, page_size, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (page =3D=3D MAP_FAILED) + return (void *)(long)-ENOMEM; + + memcpy(page, ha->content, ha->content_len); + + ret =3D poll(&pfd, 1, 5000); + if (ret <=3D 0) + goto out; + + if (read(ha->uffd, &msg, sizeof(msg)) !=3D sizeof(msg)) + goto out; + + if (msg.event !=3D UFFD_EVENT_PAGEFAULT) + goto out; + + uffd_copy.dst =3D msg.arg.pagefault.address & ~(page_size - 1); + uffd_copy.src =3D (unsigned long)page; + uffd_copy.len =3D page_size; + uffd_copy.mode =3D 0; + ioctl(ha->uffd, UFFDIO_COPY, &uffd_copy); + +out: + munmap(page, page_size); + return NULL; +} + +/* + * Test: read from userfaultfd-registered memory (no flags, should block + * until page fault is resolved by handler thread) + */ +TEST(read_userfaultfd_blocking) +{ + int uffd; + void *mem; + long page_size =3D sysconf(_SC_PAGESIZE); + uint8_t buf[sizeof(test_data)]; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov; + struct uffd_handler_args ha; + pthread_t handler; + ssize_t n; + + memset(buf, POISON_BYTE, sizeof(buf)); + + uffd =3D setup_userfaultfd(); + if (uffd =3D=3D -EPERM) + SKIP(return, "userfaultfd requires privileges (vm.unprivileged_userfault= fd=3D0)"); + if (uffd =3D=3D -ENOSYS) + SKIP(return, "userfaultfd not supported"); + ASSERT_GE(uffd, 0); + + mem =3D register_uffd_region(uffd, page_size); + ASSERT_NE(NULL, mem); + + ha.uffd =3D uffd; + ha.content =3D test_data; + ha.content_len =3D sizeof(test_data); + ASSERT_EQ(0, pthread_create(&handler, NULL, uffd_handler_thread, &ha)); + + remote_iov.iov_base =3D mem; + remote_iov.iov_len =3D sizeof(test_data); + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, 0); + ASSERT_EQ(sizeof(test_data), n); + ASSERT_EQ(0, memcmp(buf, test_data, sizeof(test_data))); + + pthread_join(handler, NULL); + munmap(mem, page_size); + close(uffd); +} + +/* + * Test: read with NOWAIT from userfaultfd-registered memory that has + * not been faulted in yet. Should return EFAULT (not block). + */ +TEST(read_nowait_userfaultfd) +{ + int uffd; + void *mem; + long page_size =3D sysconf(_SC_PAGESIZE); + uint8_t buf[sizeof(test_data)] =3D { 0 }; + struct iovec local_iov =3D { .iov_base =3D buf, .iov_len =3D sizeof(buf) = }; + struct iovec remote_iov; + ssize_t n; + + uffd =3D setup_userfaultfd(); + if (uffd =3D=3D -EPERM) + SKIP(return, "userfaultfd requires privileges (vm.unprivileged_userfault= fd=3D0)"); + if (uffd =3D=3D -ENOSYS) + SKIP(return, "userfaultfd not supported"); + ASSERT_GE(uffd, 0); + + mem =3D register_uffd_region(uffd, page_size); + ASSERT_NE(NULL, mem); + + /* Ensure the page is not present */ + madvise(mem, page_size, MADV_DONTNEED); + + remote_iov.iov_base =3D mem; + remote_iov.iov_len =3D sizeof(test_data); + n =3D process_vm_readv(getpid(), &local_iov, 1, &remote_iov, 1, + PROCESS_VM_NOWAIT); + ASSERT_EQ(-1, n); + ASSERT_EQ(EFAULT, errno); + + munmap(mem, page_size); + close(uffd); +} + +TEST_HARNESS_MAIN diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/self= tests/mm/run_vmtests.sh index d8468451b3a3..7d30f6101088 100755 --- a/tools/testing/selftests/mm/run_vmtests.sh +++ b/tools/testing/selftests/mm/run_vmtests.sh @@ -91,6 +91,8 @@ separated by spaces: test VMA merge cases behave as expected - rmap test rmap behaves as expected +- process_vm_readv + test process_vm_readv flags (pidfd, nowait) - memory-failure test memory-failure behaves as expected =20 @@ -531,6 +533,8 @@ CATEGORY=3D"page_frag" run_test ./test_page_frag.sh non= aligned =20 CATEGORY=3D"rmap" run_test ./rmap =20 +CATEGORY=3D"process_vm_readv" run_test ./process_vm_readv + # Try to load hwpoison_inject if not present. HWPOISON_DIR=3D/sys/kernel/debug/hwpoison/ if [ ! -d "$HWPOISON_DIR" ]; then --=20 2.45.0