From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FF65402455; Tue, 28 Apr 2026 12:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378716; cv=none; b=OaUlyNYKmX9uDBzuRIDWD2odwPI0FFYGmC3NUWhKoVT+yQH2iawx+YwfyWovM8mPgsl/7kUVnPe5dlGzJZtcwUBFAjw0XCCejjCLOmdUPFw2Y7dUK6Co04bQK35OpBKrupgN4kuSX9EgKnqdpuwKQ9V3SPr58SAhH9KeizK6XiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378716; c=relaxed/simple; bh=rZHYkXggah79PkVFN+6E/RKD6b6tAyfkViysUFDb8oc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lb9r71HIMV41XDkQxyygK0vMa85NBfhdhqZFNZFwtIHr9xBRXz7CsdsvLt/x4QBPe+ZIQa/j4PLESTQyfLILyxizEinAhIEUijTIIqNCrw5f6OJbzcaCsr1NWB/ZrJnETwgP5GJ5IEHxfYQ7Bz4A2ZYd3c46bo/jmVqBc5itgZI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=HvG95tv2; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="HvG95tv2" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id ED6A484F92; Tue, 28 Apr 2026 15:18:25 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378706; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=9UgJASqxAWAeh3eiXQ4y7gcX7HLK+OapSPbuxmiLW5Y=; b=HvG95tv2dxC0qdZMP+gSK3gZtQLlN62WmAagFsSks60XheDsHRyCFZjKIlXw8tpelsN4sM G+48OG2DErpQfSzUJsdv+ym5lTH53Fm0CX7A0ajSbJupxUVSkAljVWNw1fZFRAQftAqO78 QZwTms7EE63pfuptis/F20Kza2bTRBJg0mD7jtIsO/dBuO8u4mOEm4jL3D+D5FHHuhb/rm gbA/GKrrtvcnX52CfATNgdsiVHU+c5Ve5v3xfHMUHkYBvl3tI0IDYLFH7sPAHbxMDukT4L 33huh62UMYn0YCrKPrJ0r3xZ+t2pUgUCokXN9NbAquxOA3GHfvYZ/uHrtmUfO6NoJkCI10 8TiNglUWE6nxPwgUzG2CIHCC8/peB3RL1OVp1fxT8aexZ9I8A9BspuqmJ76re6QXOm78hN 7qOchDGCLaK+Ewa75INBIQO5qpV4/VjV77EabdnMP6b3lavDy6jOAgskxuDjDbsv8HmFxE LDRGg6Lu2HJAGLXcspBQAAyR+lXR3ZYUWW3rWJISdYL4KpJwLJkEOrhlOVMlHNAkE1xQcj LtAXIc6c/WMH36go3cbfy0zuq9fvyyUmXIqxFOXbleR7UFryR/5+25sKIDQ3IXQmHooQ4U PBeaPocWm8oFCOao6gFVJdo9THBrm6yh+4C0m1zv2ZjJ7zVKZ3xe8= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v5 1/8] staging: rtl8723bs: fix buffer over-read in rtw_update_protection Date: Tue, 28 Apr 2026 15:15:44 +0300 Message-ID: <20260428121737.435248-2-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" rtw_update_protection() is called with a pointer offset into the ies buffer but the full ie_length is passed, causing a potential buffer over-read. Fixes: e945c43df60b ("Staging: rtl8723bs: Delete dead code from update_curr= ent_network()") Fixes: d3fcee1b78a5 ("staging: rtl8723bs: fix camel case in struct wlan_bss= id_ex") Reported-by: Luka Gejak Closes: https://lore.kernel.org/linux-staging/DI2H39EAAFBZ.3KI5NWN02AQ2S@li= nux.dev Cc: stable@vger.kernel.org Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index ddfc56f0253d..268f294528e6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -464,8 +464,11 @@ static void update_current_network(struct adapter *ada= pter, struct wlan_bssid_ex =20 if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->= cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); + if (pmlmepriv->cur_network.network.ie_length < sizeof(struct ndis_802_11= _fix_ie)) + return; + rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length); + pmlmepriv->cur_network.network.ie_length - sizeof(struct ndis_802_= 11_fix_ie)); } } =20 @@ -1072,8 +1075,11 @@ static void rtw_joinbss_update_network(struct adapte= r *padapter, struct wlan_net break; } =20 + if (cur_network->network.ie_length < sizeof(struct ndis_802_11_fix_ie)) + return; + rtw_update_protection(padapter, (cur_network->network.ies) + sizeof(struc= t ndis_802_11_fix_ie), - (cur_network->network.ie_length)); + (cur_network->network.ie_length - sizeof(struct ndis_802_11_fix_i= e))); =20 rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8) cur_network->network.configuration.ds_config); } --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F879413229 for ; Tue, 28 Apr 2026 12:18:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378718; cv=none; b=BFXh6zeETWmHYxbnuPAn0AnRAsr4idwjyUF16PKF8QL/DABvM1WnbOJXZjpgGn7oMa498kafd8J+aSHXGIOKYxynNjFjMrUty3nq6sj2YIVs8oNooJtQ/yT6/uMctlRhaFgHta9l4XrJR1DchK+I5DtskcEmRFsL7yIOo5XdNC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378718; c=relaxed/simple; bh=ogfnSpVkWhJjYE4H76H+8fnS1yys5WSfk3yGwfOQqio=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IVdhxCJhNTRDS1oYO/2E68GH+Slhugio1lt3lGFL1xcd5eVQoygDOuwN9sdCI6OLYVqSjw30Xg1gBbtGPK+kpep/BXuMGCvXsjRuXxoty6fgknW3UMQb2zNuvetRUggsKHix6ZzFu2iaGJyVZbE+7Fm1hN97KjozwiYTsozqWSs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=JFtKPfwC; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="JFtKPfwC" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 0C20F84F93; Tue, 28 Apr 2026 15:18:27 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378708; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=Ds0s6x/IEdSEFe5Ej/ZAy7XvpQEIA8Z6370zk4udx44=; b=JFtKPfwCcMh2T+1y9xofCURKMNpljz0Ymf55uo358NQf1Xf7Oz3ISUBN/p0Iv33Z7RQMn2 AQNwNnp6oDpK+lv7Go4VCozdimeXIrnOfPiV5myE8tlgvr1LIrEUniS3PEU4PzrNd/94vZ K/IoDxbfO+gDBQjhJDlp4RgUgAPNLWNzwgXYOqywJXx4Gq6YMwjhR4XUYpDaGi8Fxiy6RE MhDMxnpGZ4X3l4xPCOfBOqujtsAV2k3hT3NxdBsKAbyaK/G9CjPK+R+ABpUVsQjkFdVFMO 8/TgvJnaom7mfqgtctYHaJMILZyY5JrPn+KojjLJLotf0KuuT5kPu0gxYn5w9D15AgwaaB 0YEBTpxn7g3MfnQIHlqRjywM2tEGZWuF3KnyqVh94kouHLs+Y4BpYo/hUc8AMjijsNDH8N g13zpz/zbhxHy/231IapHBvxqM4uxzp+RCEOrwbg2HyJ4ypRNmIMjeEfYidmPt9r7a7236 0yrX/yG1Odhcqp2g1jGjjE6HeAbMjKZH3tCL4civk+21CwejzOxnF1r6c6Om5l28hTswNJ IAhazdHp4TagiaaH9uSxYrgrqH8yw9kKRkj7w838WCqzaBrAFRWrjdpH6cAKJjUHaI+Z7z s0tZdu39SPhWh8KzqtMJwxOcu5gUVLzXpakRI9Cx4VWnMYvf+mTPU= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/8] staging: rtl8723bs: rtw_mlme: add bounds checks before ie_length subtraction Date: Tue, 28 Apr 2026 15:15:45 +0300 Message-ID: <20260428121737.435248-3-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Add guards to ensure ie_length is large enough before subtracting fixed IE offsets to prevent unsigned integer underflow. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 268f294528e6..9f21a2226dbd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -604,6 +604,8 @@ static bool rtw_is_desired_network(struct adapter *adap= ter, struct wlan_network privacy =3D pnetwork->network.privacy; =20 if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) { + if (pnetwork->network.ie_length < _FIXED_IE_LENGTH_) + return false; if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->= network.ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen)) return true; else @@ -617,11 +619,15 @@ static bool rtw_is_desired_network(struct adapter *ad= apter, struct wlan_network bselected =3D false; =20 if (psecuritypriv->ndisauthtype =3D=3D Ndis802_11AuthModeWPA2PSK) { - p =3D rtw_get_ie(pnetwork->network.ies + _BEACON_IE_OFFSET_, WLAN_EID_R= SN, &ie_len, (pnetwork->network.ie_length - _BEACON_IE_OFFSET_)); - if (p && ie_len > 0) - bselected =3D true; - else + if (pnetwork->network.ie_length < _BEACON_IE_OFFSET_) { bselected =3D false; + } else { + p =3D rtw_get_ie(pnetwork->network.ies + _BEACON_IE_OFFSET_, WLAN_EID_= RSN, &ie_len, (pnetwork->network.ie_length - _BEACON_IE_OFFSET_)); + if (p && ie_len > 0) + bselected =3D true; + else + bselected =3D false; + } } } =20 --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D728B3AEF43 for ; Tue, 28 Apr 2026 12:18:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378724; cv=none; b=HLTyluvRCsnddsL124mqt3j/YJGYKGw7t8uIzjZBlALZfq3Gkg6QBoMkIBmayTekDNF3pTMl6yus6vGVER9J1BviwF62Ux/Ay/7GK0boeLU0vk0T1gMadPLyZFrp0RhYqQJIzg68TdezEyuunwEO79wejORC/yB8O59Evme3tAo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378724; c=relaxed/simple; bh=wv1wAz5G5jTk9iKfTQXieVLbuRkIyBCE8b6i9HhVL3g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NQCzY7z2k81fTtssQ2oW451F7CA1vpEHTa+rCDw+S53mzYlolEWAi8TiH3z3PKM4BDgDDx3kqAygBluiJKJxURaV5DCq33BfPD3agapJy4U2eMDe8TyQLIAPSMosOX9tZXV/dlIHeEWaYW4T6ueZ3VO8E72tMnOj3sd7ATaNQnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=l+59km4F; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="l+59km4F" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B8A4784F94; Tue, 28 Apr 2026 15:18:29 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378710; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=Ys2ruBN+FMlbNaJuod+QMjGTvoSg6mzg3rPSjZ68TBE=; b=l+59km4FINzW+zZTbnpLXNj3ZI7C/YuF5HBjpNSdVn41HltkgfId3+DI7vvigio1hee1JO 1/SOrLNacv4zxPdsS7g8BlSIuQs/gv4zfnJA/scsFMPJqmLjBxUvks+chK/tmO/5PTEunR 4tUUS3W6/kAcr6pkZRVoyZEYMfXWUgtgwJ9Y9VsOB/R+e8y7db1EFxT42CpJ3akKC5ICb3 T9lJpeNy+bgLKexwBfri625HZjLUUOFDeA/Vug410Z2mTR8BJW+nNXET3OEctcwUh1H30j 0MP6HqTgRxcDSozYUzgM04v0oty59JtLdExpc3qd9Ipti720IDm63XNMTe2yrDKSX2zlms D7n+PEl8ZSm+lISKLMqPXJp7kQj/hu4aR5nn7SFEVX1oXQNEZkZtYhpYtgbaoR5DCnYBsm 8bsaquTwxb1Hx4xNa9qPES0BQoj/1P5k9/q+WnDgMJaNc7cdAkZyEAL44/gJgvWQ1lJFOD qwALqQS231+AkFpQJ1AtdWas0Ee6V9sm+Y7OrVOG//HkGDbWNaBQchklHpOk/kkaE5GGM4 iBhj63KGQNeTBtQ4I+9LLpE+yVBQBwnUSDg850lUUAojwjy0uzKRt3PuFxaoqwcJDXzNO5 HW7ufQQsyHM8bMlmULHWCu5N7bHhCSiH78lws9opf5D0jdNubRiNc= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 3/8] staging: rtl8723bs: rtw_mlme: wrap lines exceeding 100 columns Date: Tue, 28 Apr 2026 15:15:46 +0300 Message-ID: <20260428121737.435248-4-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Wrap long lines to bring them within the 100 column limit. No functional changes. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 205 +++++++++++++++------- 1 file changed, 142 insertions(+), 63 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 9f21a2226dbd..a35d726b803c 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -52,7 +52,10 @@ int rtw_init_mlme_priv(struct adapter *padapter) pmlmepriv->pscanned =3D NULL; pmlmepriv->fw_state =3D WIFI_STATION_STATE; /* Must sync with rtw_wdev_a= lloc() */ pmlmepriv->cur_network.network.infrastructure_mode =3D Ndis802_11AutoUnkn= own; - pmlmepriv->scan_mode =3D SCAN_ACTIVE;/* 1: active, 0: passive. Maybe som= eday we should rename this varable to "active_mode" (Jeff) */ + /* 1: active, 0: passive. Maybe someday we should rename this variable + * to "active_mode" (Jeff) + */ + pmlmepriv->scan_mode =3D SCAN_ACTIVE; =20 spin_lock_init(&pmlmepriv->lock); INIT_LIST_HEAD(&pmlmepriv->free_bss_pool.queue); @@ -125,7 +128,8 @@ void rtw_free_mlme_priv_ie_data(struct mlme_priv *pmlme= priv) rtw_free_mlme_ie_data(&pmlmepriv->p2p_beacon_ie, &pmlmepriv->p2p_beacon_i= e_len); rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_req_ie, &pmlmepriv->p2p_probe= _req_ie_len); rtw_free_mlme_ie_data(&pmlmepriv->p2p_probe_resp_ie, &pmlmepriv->p2p_prob= e_resp_ie_len); - rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, &pmlmepriv->p2p_g= o_probe_resp_ie_len); + rtw_free_mlme_ie_data(&pmlmepriv->p2p_go_probe_resp_ie, + &pmlmepriv->p2p_go_probe_resp_ie_len); rtw_free_mlme_ie_data(&pmlmepriv->p2p_assoc_req_ie, &pmlmepriv->p2p_assoc= _req_ie_len); } =20 @@ -369,7 +373,8 @@ int is_same_network(struct wlan_bssid_ex *src, struct w= lan_bssid_ex *dst, u8 fea (d_cap & WLAN_CAPABILITY_ESS)); } =20 -struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue,= struct wlan_network *network) +struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, + struct wlan_network *network) { struct list_head *phead, *plist; struct wlan_network *found =3D NULL; @@ -420,7 +425,8 @@ void update_network(struct wlan_bssid_ex *dst, struct w= lan_bssid_ex *src, long rssi_final; =20 /* The rule below is 1/5 for sample value, 4/5 for history value */ - if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && is_same_network(&pa= dapter->mlmepriv.cur_network.network, src, 0)) { + if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && + is_same_network(&padapter->mlmepriv.cur_network.network, src, 0)) { /* Take the recvpriv's value for the connected AP*/ ss_final =3D padapter->recvpriv.signal_strength; sq_final =3D padapter->recvpriv.signal_qual; @@ -431,11 +437,15 @@ void update_network(struct wlan_bssid_ex *dst, struct= wlan_bssid_ex *src, rssi_final =3D rssi_ori; } else { if (sq_smp !=3D 101) { /* from the right channel */ - ss_final =3D ((u32)(src->phy_info.signal_strength) + (u32)(dst->phy_inf= o.signal_strength) * 4) / 5; - sq_final =3D ((u32)(src->phy_info.signal_quality) + (u32)(dst->phy_info= .signal_quality) * 4) / 5; + ss_final =3D ((u32)(src->phy_info.signal_strength) + + (u32)(dst->phy_info.signal_strength) * 4) / 5; + sq_final =3D ((u32)(src->phy_info.signal_quality) + + (u32)(dst->phy_info.signal_quality) * 4) / 5; rssi_final =3D (src->rssi + dst->rssi * 4) / 5; } else { - /* bss info not receiving from the right channel, use the original RX s= ignal infos */ + /* bss info not receiving from the right channel, + * use the original RX signal infos + */ ss_final =3D dst->phy_info.signal_strength; sq_final =3D dst->phy_info.signal_quality; rssi_final =3D dst->rssi; @@ -462,7 +472,8 @@ static void update_current_network(struct adapter *adap= ter, struct wlan_bssid_ex &pmlmepriv->cur_network.network, &pmlmepriv->cur_network.network); =20 - if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->= cur_network.network, pnetwork, 0))) { + if (check_fwstate(pmlmepriv, _FW_LINKED) && + (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); if (pmlmepriv->cur_network.network.ie_length < sizeof(struct ndis_802_11= _fix_ie)) return; @@ -606,7 +617,9 @@ static bool rtw_is_desired_network(struct adapter *adap= ter, struct wlan_network if (check_fwstate(pmlmepriv, WIFI_UNDER_WPS)) { if (pnetwork->network.ie_length < _FIXED_IE_LENGTH_) return false; - if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, pnetwork->= network.ie_length - _FIXED_IE_LENGTH_, NULL, &wps_ielen)) + if (rtw_get_wps_ie(pnetwork->network.ies + _FIXED_IE_LENGTH_, + pnetwork->network.ie_length - _FIXED_IE_LENGTH_, + NULL, &wps_ielen)) return true; else return false; @@ -622,7 +635,9 @@ static bool rtw_is_desired_network(struct adapter *adap= ter, struct wlan_network if (pnetwork->network.ie_length < _BEACON_IE_OFFSET_) { bselected =3D false; } else { - p =3D rtw_get_ie(pnetwork->network.ies + _BEACON_IE_OFFSET_, WLAN_EID_= RSN, &ie_len, (pnetwork->network.ie_length - _BEACON_IE_OFFSET_)); + p =3D rtw_get_ie(pnetwork->network.ies + _BEACON_IE_OFFSET_, + WLAN_EID_RSN, &ie_len, + (pnetwork->network.ie_length - _BEACON_IE_OFFSET_)); if (p && ie_len > 0) bselected =3D true; else @@ -663,12 +678,14 @@ void rtw_survey_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 /* update IBSS_network 's timestamp */ if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) { - if (!memcmp(&pmlmepriv->cur_network.network.mac_address, pnetwork->mac_a= ddress, ETH_ALEN)) { + if (!memcmp(&pmlmepriv->cur_network.network.mac_address, + pnetwork->mac_address, ETH_ALEN)) { struct wlan_network *ibss_wlan =3D NULL; =20 memcpy(pmlmepriv->cur_network.network.ies, pnetwork->ies, 8); spin_lock_bh(&pmlmepriv->scanned_queue.lock); - ibss_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork->ma= c_address); + ibss_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + pnetwork->mac_address); if (ibss_wlan) { memcpy(ibss_wlan->network.ies, pnetwork->ies, 8); spin_unlock_bh(&pmlmepriv->scanned_queue.lock); @@ -722,10 +739,13 @@ void rtw_surveydone_event_callback(struct adapter *ad= apter, u8 *pbuf) struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_= network; u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; =20 - /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ + /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY; + * because don't set assoc_timer + */ _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); =20 - memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndi= s_802_11_ssid)); + memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, + sizeof(struct ndis_802_11_ssid)); =20 rtw_update_registrypriv_dev_network(adapter); rtw_generate_random_ibss(pibss); @@ -957,7 +977,8 @@ void rtw_scan_abort(struct adapter *adapter) pmlmeext->scan_abort =3D false; } =20 -static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapte= r, struct wlan_network *pnetwork) +static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapte= r, + struct wlan_network *pnetwork) { int i; struct sta_info *bmc_sta, *psta =3D NULL; @@ -1014,7 +1035,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str } =20 /* for A-MPDU Rx reordering buffer control for bmc_sta & sta_info */ - /* if A-MPDU Rx is enabled, resetting rx_ordering_ctrl wstart_b(indicat= e_seq) to default value =3D 0xffff */ + /* if A-MPDU Rx is enabled, resetting rx_ordering_ctrl + * wstart_b(indicate_seq) to default value =3D 0xffff + */ /* todo: check if AP can send A-MPDU packets */ for (i =3D 0; i < 16 ; i++) { preorder_ctrl =3D &psta->recvreorder_ctrl[i]; @@ -1031,7 +1054,8 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str preorder_ctrl->enable =3D false; preorder_ctrl->indicate_seq =3D 0xffff; preorder_ctrl->wend_b =3D 0xffff; - preorder_ctrl->wsize_b =3D 64;/* max_ampdu_sz;ex. 32(kbytes) -> wsize_= b =3D32 */ + /* max_ampdu_sz;ex. 32(kbytes) -> wsize_b =3D32 */ + preorder_ctrl->wsize_b =3D 64; } } } @@ -1041,7 +1065,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str =20 /* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, struct wlan_network *pnetwork) +static void rtw_joinbss_update_network(struct adapter *padapter, + struct wlan_network *ptarget_wlan, + struct wlan_network *pnetwork) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; struct wlan_network *cur_network =3D &pmlmepriv->cur_network; @@ -1058,7 +1084,9 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_net =20 padapter->recvpriv.signal_strength =3D ptarget_wlan->network.phy_info.sig= nal_strength; padapter->recvpriv.signal_qual =3D ptarget_wlan->network.phy_info.signal_= quality; - /* the ptarget_wlan->network.rssi is raw data, we use ptarget_wlan->netwo= rk.phy_info.signal_strength instead (has scaled) */ + /* the ptarget_wlan->network.rssi is raw data, we use + * ptarget_wlan->network.phy_info.signal_strength instead (has scaled) + */ padapter->recvpriv.rssi =3D translate_percentage_to_dbm(ptarget_wlan->net= work.phy_info.signal_strength); =20 rtw_set_signal_stat_timer(&padapter->recvpriv); @@ -1084,10 +1112,12 @@ static void rtw_joinbss_update_network(struct adapt= er *padapter, struct wlan_net if (cur_network->network.ie_length < sizeof(struct ndis_802_11_fix_ie)) return; =20 - rtw_update_protection(padapter, (cur_network->network.ies) + sizeof(struc= t ndis_802_11_fix_ie), - (cur_network->network.ie_length - sizeof(struct ndis_802_11_fix_i= e))); + rtw_update_protection(padapter, + (cur_network->network.ies) + sizeof(struct ndis_802_11_fix_ie), + (cur_network->network.ie_length - sizeof(struct ndis_802_11_fix_i= e))); =20 - rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, (u8) cur_network->network.configuration.ds_config); + rtw_update_ht_cap(padapter, cur_network->network.ies, cur_network->networ= k.ie_length, + (u8)cur_network->network.configuration.ds_config); } =20 static struct rt_pmkid_list backupPMKIDList[NUM_PMKID_CACHE]; @@ -1107,9 +1137,12 @@ void rtw_reset_securitypriv(struct adapter *adapter) /* We have to backup the PMK information for WiFi PMK Caching test item= . */ /* */ /* Backup the btkip_countermeasure information. */ - /* When the countermeasure is trigger, the driver have to disconnect wi= th AP for 60 seconds. */ + /* When the countermeasure is trigger, the driver have + * to disconnect with AP for 60 seconds. + */ =20 - memcpy(&backupPMKIDList[0], &adapter->securitypriv.PMKIDList[0], sizeof(= struct rt_pmkid_list) * NUM_PMKID_CACHE); + memcpy(&backupPMKIDList[0], &adapter->securitypriv.PMKIDList[0], + sizeof(struct rt_pmkid_list) * NUM_PMKID_CACHE); backupPMKIDIndex =3D adapter->securitypriv.PMKIDIndex; backupTKIPCountermeasure =3D adapter->securitypriv.btkip_countermeasure; backupTKIPcountermeasure_time =3D adapter->securitypriv.btkip_countermea= sure_time; @@ -1120,8 +1153,11 @@ void rtw_reset_securitypriv(struct adapter *adapter) memset((unsigned char *)&adapter->securitypriv, 0, sizeof(struct securit= y_priv)); =20 /* Added by Albert 2009/02/18 */ - /* Restore the PMK information to securitypriv structure for the follow= ing connection. */ - memcpy(&adapter->securitypriv.PMKIDList[0], &backupPMKIDList[0], sizeof(= struct rt_pmkid_list) * NUM_PMKID_CACHE); + /* Restore the PMK information to securitypriv structure + * for the following connection. + */ + memcpy(&adapter->securitypriv.PMKIDList[0], &backupPMKIDList[0], + sizeof(struct rt_pmkid_list) * NUM_PMKID_CACHE); adapter->securitypriv.PMKIDIndex =3D backupPMKIDIndex; adapter->securitypriv.btkip_countermeasure =3D backupTKIPCountermeasure; adapter->securitypriv.btkip_countermeasure_time =3D backupTKIPcountermea= sure_time; @@ -1153,9 +1189,13 @@ void rtw_reset_securitypriv(struct adapter *adapter) /* Notes: the function could be > passive_level (the same context as Rx ta= sklet) */ /* pnetwork : returns from rtw_joinbss_event_callback */ /* ptarget_wlan: found from scanned_queue */ -/* if join_res > 0, for (fw_state =3D=3DWIFI_STATION_STATE), we check if = "ptarget_sta" & "ptarget_wlan" exist. */ +/* if join_res > 0, for (fw_state =3D=3DWIFI_STATION_STATE), we check + * if "ptarget_sta" & "ptarget_wlan" exist. + */ /* if join_res > 0, for (fw_state =3D=3DWIFI_ADHOC_STATE), we only check i= f "ptarget_wlan" exist. */ -/* if join_res > 0, update "cur_network->network" from "pnetwork->network"= if (ptarget_wlan !=3D NULL). */ +/* if join_res > 0, update "cur_network->network" from + * "pnetwork->network" if (ptarget_wlan !=3D NULL). + */ /* */ void rtw_joinbss_event_prehandle(struct adapter *adapter, u8 *pbuf) { @@ -1167,7 +1207,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) struct wlan_network *pcur_wlan =3D NULL, *ptarget_wlan =3D NULL; unsigned int the_same_macaddr =3D false; =20 - the_same_macaddr =3D !memcmp(pnetwork->network.mac_address, cur_network->= network.mac_address, ETH_ALEN); + the_same_macaddr =3D !memcmp(pnetwork->network.mac_address, + cur_network->network.mac_address, ETH_ALEN); =20 pnetwork->network.length =3D get_wlan_bssid_ex_sz(&pnetwork->network); if (pnetwork->network.length > sizeof(struct wlan_bssid_ex)) @@ -1207,9 +1248,11 @@ void rtw_joinbss_event_prehandle(struct adapter *ada= pter, u8 *pbuf) /* s1. find ptarget_wlan */ if (check_fwstate(pmlmepriv, _FW_LINKED)) { if (the_same_macaddr) { - ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, cur_networ= k->network.mac_address); + ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + cur_network->network.mac_address); } else { - pcur_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, cur_network->= network.mac_address); + pcur_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + cur_network->network.mac_address); if (pcur_wlan) pcur_wlan->fixed =3D false; =20 @@ -1217,7 +1260,8 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) if (pcur_sta) rtw_free_stainfo(adapter, pcur_sta); =20 - ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork->= network.mac_address); + ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + pnetwork->network.mac_address); if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { if (ptarget_wlan) ptarget_wlan->fixed =3D true; @@ -1242,7 +1286,9 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) =20 rtw_joinbss_update_network(adapter, ptarget_wlan, pnetwork); =20 - /* s3. find ptarget_sta & update ptarget_sta after update cur_network onl= y for station mode */ + /* s3. find ptarget_sta & update ptarget_sta after update + * cur_network only for station mode + */ if (check_fwstate(pmlmepriv, WIFI_STATION_STATE)) { ptarget_sta =3D rtw_joinbss_update_stainfo(adapter, pnetwork); if (!ptarget_sta) { @@ -1310,7 +1356,8 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) /* report to upper layer */ spin_lock_bh(&psta->lock); if (psta->passoc_req && psta->assoc_req_len > 0) { - passoc_req =3D kmemdup(psta->passoc_req, psta->assoc_req_len, GFP_ATOM= IC); + passoc_req =3D kmemdup(psta->passoc_req, + psta->assoc_req_len, GFP_ATOMIC); if (passoc_req) { assoc_req_len =3D psta->assoc_req_len; =20 @@ -1335,7 +1382,10 @@ void rtw_stassoc_event_callback(struct adapter *adap= ter, u8 *pbuf) if (psta) { /* the sta have been in sta_info_queue =3D> do nothing */ =20 - return; /* between drv has received this event before and fw have not y= et to set key to CAM_ENTRY) */ + /* between drv has received this event before and + * fw have not yet to set key to CAM_ENTRY) + */ + return; } =20 psta =3D rtw_alloc_stainfo(&adapter->stapriv, pstassoc->macaddr); @@ -1362,7 +1412,8 @@ void rtw_stassoc_event_callback(struct adapter *adapt= er, u8 *pbuf) check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { if (adapter->stapriv.asoc_sta_count =3D=3D 2) { spin_lock_bh(&pmlmepriv->scanned_queue.lock); - ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, cur_networ= k->network.mac_address); + ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + cur_network->network.mac_address); pmlmepriv->cur_network_scanned =3D ptarget_wlan; if (ptarget_wlan) ptarget_wlan->fixed =3D true; @@ -1419,16 +1470,19 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) =20 if (adapter->registrypriv.wifi_spec =3D=3D 1) { roam =3D false; - } else if (reason =3D=3D WLAN_REASON_EXPIRATION_CHK && rtw_chk_roam_flag= s(adapter, RTW_ROAM_ON_EXPIRED)) { + } else if (reason =3D=3D WLAN_REASON_EXPIRATION_CHK && + rtw_chk_roam_flags(adapter, RTW_ROAM_ON_EXPIRED)) { roam =3D true; - } else if (reason =3D=3D WLAN_REASON_ACTIVE_ROAM && rtw_chk_roam_flags(a= dapter, RTW_ROAM_ACTIVE)) { + } else if (reason =3D=3D WLAN_REASON_ACTIVE_ROAM && + rtw_chk_roam_flags(adapter, RTW_ROAM_ACTIVE)) { roam =3D true; roam_target =3D pmlmepriv->roam_network; } =20 if (roam) { if (rtw_to_roam(adapter) > 0) - rtw_dec_to_roam(adapter); /* this stadel_event is caused by roaming, d= ecrease to_roam */ + /* this stadel_event is caused by roaming, decrease to_roam */ + rtw_dec_to_roam(adapter); else if (rtw_to_roam(adapter) =3D=3D 0) rtw_set_to_roam(adapter, adapter->registrypriv.max_roaming_times); } else { @@ -1442,7 +1496,8 @@ void rtw_stadel_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* remove the network entry in scanned_queue */ - pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netwo= rk.mac_address); + pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + tgt_network->network.mac_address); if (pwlan) { pwlan->fixed =3D false; rtw_free_network_nolock(adapter, pwlan); @@ -1456,12 +1511,14 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { rtw_free_stainfo(adapter, psta); =20 - if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ + /* a sta + bc/mc_stainfo (not Ibss_stainfo) */ + if (adapter->stapriv.asoc_sta_count =3D=3D 1) { u8 ret =3D _SUCCESS; =20 spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* free old ibss network */ - pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netw= ork.mac_address); + pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, + tgt_network->network.mac_address); if (pwlan) { pwlan->fixed =3D false; rtw_free_network_nolock(adapter, pwlan); @@ -1471,9 +1528,11 @@ void rtw_stadel_event_callback(struct adapter *adapt= er, u8 *pbuf) pdev_network =3D &adapter->registrypriv.dev_network; pibss =3D adapter->registrypriv.dev_network.mac_address; =20 - memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_n= etwork->network)); + memcpy(pdev_network, &tgt_network->network, + get_wlan_bssid_ex_sz(&tgt_network->network)); =20 - memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, sizeof(struct ndis_= 802_11_ssid)); + memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, + sizeof(struct ndis_802_11_ssid)); =20 rtw_update_registrypriv_dev_network(adapter); =20 @@ -1544,7 +1603,9 @@ void _rtw_join_timeout_handler(struct timer_list *t) rtw_indicate_disconnect(adapter); free_scanqueue(pmlmepriv);/* */ =20 - /* indicate disconnect for the case that join_timeout and check_fwstate = !=3D FW_LINKED */ + /* indicate disconnect for the case that join_timeout + * and check_fwstate !=3D FW_LINKED + */ rtw_cfg80211_indicate_disconnect(adapter); } =20 @@ -1593,8 +1654,8 @@ static void rtw_auto_scan_handler(struct adapter *pad= apter) =20 rtw_mlme_reset_auto_scan_int(padapter); =20 - if (pmlmepriv->auto_scan_int_ms !=3D 0 - && jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { + if (pmlmepriv->auto_scan_int_ms !=3D 0 && + jiffies_to_msecs(jiffies - pmlmepriv->scan_start_time) > pmlmepriv->a= uto_scan_int_ms) { if (!padapter->registrypriv.wifi_spec) { if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING)) goto exit; @@ -1636,7 +1697,9 @@ void rtw_dynamic_check_timer_handler(struct adapter *= adapter) /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */ rtw_hal_dm_watchdog_in_lps(adapter); } else { - /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1) in traffic_sta= tus_watchdog() */ + /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1) + * in traffic_status_watchdog() + */ } =20 } else { @@ -1769,8 +1832,9 @@ static int rtw_check_join_candidate(struct mlme_priv = *mlme =20 /* check ssid, if needed */ if (mlme->assoc_ssid.ssid[0] && mlme->assoc_ssid.ssid_length) { - if (competitor->network.ssid.ssid_length !=3D mlme->assoc_ssid.ssid_leng= th - || memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, mlme->a= ssoc_ssid.ssid_length) + if (competitor->network.ssid.ssid_length !=3D mlme->assoc_ssid.ssid_leng= th || + memcmp(competitor->network.ssid.ssid, mlme->assoc_ssid.ssid, + mlme->assoc_ssid.ssid_length) ) goto exit; } @@ -1888,7 +1952,8 @@ signed int rtw_set_auth(struct adapter *adapter, stru= ct security_priv *psecurity return res; } =20 -signed int rtw_set_key(struct adapter *adapter, struct security_priv *psec= uritypriv, signed int keyid, u8 set_tx, bool enqueue) +signed int rtw_set_key(struct adapter *adapter, struct security_priv *psec= uritypriv, + signed int keyid, u8 set_tx, bool enqueue) { u8 keylen; struct cmd_obj *pcmd; @@ -1963,7 +2028,8 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp } =20 /* adjust ies for rtw_joinbss_cmd in WMM */ -int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, ui= nt in_len, uint initial_out_len) +int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, + uint in_len, uint initial_out_len) { unsigned int ielength =3D 0; unsigned int i, j; @@ -2097,7 +2163,8 @@ signed int rtw_restruct_sec_ie(struct adapter *adapte= r, u8 *in_ie, u8 *out_ie, u ielength +=3D psecuritypriv->wps_ie_len; } else if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) || (authmode =3D=3D= WLAN_EID_RSN)) { /* copy RSN or SSN */ - memcpy(&out_ie[ielength], &psecuritypriv->supplicant_ie[0], psecuritypri= v->supplicant_ie[1] + 2); + memcpy(&out_ie[ielength], &psecuritypriv->supplicant_ie[0], + psecuritypriv->supplicant_ie[1] + 2); ielength +=3D psecuritypriv->supplicant_ie[1] + 2; rtw_report_sec_ie(adapter, authmode, psecuritypriv->supplicant_ie); } @@ -2135,7 +2202,8 @@ void rtw_update_registrypriv_dev_network(struct adapt= er *adapter) struct security_priv *psecuritypriv =3D &adapter->securitypriv; struct wlan_network *cur_network =3D &adapter->mlmepriv.cur_network; =20 - pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ) ; /* adhoc no 802.1x */ + /* adhoc no 802.1x */ + pdev_network->privacy =3D (psecuritypriv->dot11PrivacyAlgrthm > 0 ? 1 : 0= ); =20 pdev_network->rssi =3D 0; =20 @@ -2165,14 +2233,18 @@ void rtw_update_registrypriv_dev_network(struct ada= pter *adapter) /* 1. Supported rates */ /* 2. IE */ =20 - /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->w= ireless_mode) ; will be called in rtw_generate_ie */ + /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->w= ireless_mode); + * will be called in rtw_generate_ie + */ sz =3D rtw_generate_ie(pregistrypriv); =20 pdev_network->ie_length =3D sz; =20 pdev_network->length =3D get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pd= ev_network); =20 - /* notes: translate ie_length & length after assign the length to cmdsz i= n createbss_cmd(); */ + /* notes: translate ie_length & length after assign the + * length to cmdsz in createbss_cmd(); + */ /* pdev_network->ie_length =3D cpu_to_le32(sz); */ } =20 @@ -2184,7 +2256,9 @@ void rtw_joinbss_reset(struct adapter *padapter) =20 struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; =20 - /* todo: if you want to do something io/reg/hw setting before join_bss, p= lease add code here */ + /* todo: if you want to do something io/reg/hw setting before + * join_bss, please add code here + */ =20 pmlmepriv->num_FortyMHzIntolerant =3D 0; =20 @@ -2274,7 +2348,8 @@ void rtw_build_wmm_ie_ht(struct adapter *padapter, u8= *out_ie, uint *pout_len) } =20 /* the function is >=3D passive_level */ -unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8= *out_ie, uint in_len, uint *pout_len, u8 channel) +unsigned int rtw_restructure_ht_ie(struct adapter *padapter, u8 *in_ie, u8= *out_ie, + uint in_len, uint *pout_len, u8 channel) { u32 ielen, out_len; enum ieee80211_max_ampdu_length_exp max_rx_ampdu_factor; @@ -2345,7 +2420,7 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ ht_capie.cap_info |=3D cpu_to_le16(IEEE80211_HT_CAP_SM_PS); =20 if (TEST_FLAG(phtpriv->stbc_cap, STBC_HT_ENABLE_RX)) { - if ((channel <=3D 14 && pregistrypriv->rx_stbc =3D=3D 0x1) || /* enable = for 2.4GHz */ + if ((channel <=3D 14 && pregistrypriv->rx_stbc =3D=3D 0x1) || /* enable = for 2.4GHz */ (pregistrypriv->wifi_spec =3D=3D 1)) stbc_rx_enable =3D 1; } @@ -2355,7 +2430,8 @@ unsigned int rtw_restructure_ht_ie(struct adapter *pa= dapter, u8 *in_ie, u8 *out_ =20 /* update default supported_mcs_set */ if (stbc_rx_enable) - ht_capie.cap_info |=3D cpu_to_le16(IEEE80211_HT_CAP_RX_STBC_1R);/* RX ST= BC One spatial stream */ + /* RX STBC One spatial stream */ + ht_capie.cap_info |=3D cpu_to_le16(IEEE80211_HT_CAP_RX_STBC_1R); =20 set_mcs_rate_by_mask(ht_capie.mcs.rx_mask, MCS_RATE_1R); =20 @@ -2421,7 +2497,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe =20 /* check Max Rx A-MPDU Size */ len =3D 0; - p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_CAP= ABILITY, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); + p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_CAP= ABILITY, + &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); if (p && len > 0) { pht_capie =3D (struct ieee80211_ht_cap *)(p + 2); max_ampdu_sz =3D (pht_capie->ampdu_params_info & IEEE80211_HT_CAP_AMPDU_= FACTOR); @@ -2431,7 +2508,8 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe } =20 len =3D 0; - p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPE= RATION, &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); + p =3D rtw_get_ie(pie + sizeof(struct ndis_802_11_fix_ie), WLAN_EID_HT_OPE= RATION, + &len, ie_len - sizeof(struct ndis_802_11_fix_ie)); if (p && len > 0) { /* todo: */ } @@ -2564,7 +2642,8 @@ void _rtw_roaming(struct adapter *padapter, struct wl= an_network *tgt_network) struct wlan_network *cur_network =3D &pmlmepriv->cur_network; =20 if (rtw_to_roam(padapter) > 0) { - memcpy(&pmlmepriv->assoc_ssid, &cur_network->network.ssid, sizeof(struct= ndis_802_11_ssid)); + memcpy(&pmlmepriv->assoc_ssid, &cur_network->network.ssid, + sizeof(struct ndis_802_11_ssid)); =20 pmlmepriv->assoc_by_bssid =3D false; =20 --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1698E41B36D for ; Tue, 28 Apr 2026 12:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378728; cv=none; b=RXiPl+omMIVij6fRNCn6C7t7P9YQWj7QdhldiSIi0tkDJ9RIEdMn1qjdt6xHsycYxLiBQbnSpnqRroJkSCH2FtSa9v9hgFZC8MVb344TVltPBgjfl0JPyog/1aaeU/+zfb/24s4+Oa7T1OM+CgvKa4x363ryNIeOREJVwI+UJHc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378728; c=relaxed/simple; bh=9HdIemgfR4VrPqTNiZHWFj+ptqaf+4Vv3NXR+2U51Wk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=to2hQBpy+rfINaFBM2C2twNyLbuM2+nYq9prPpzVQRVABwZCRG4UwVk8VmoKIxhXCo7xmZE7Uva/epmkmQNJhX+AVa3vTi9+iweNKSeTJPR3YcTptOHb8gkmOTZP619Yb5Htzn4T2Ln1MmlU8iXCjSmOjiZkqJWR2bVcauPL0LM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=Ut5dmycg; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="Ut5dmycg" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B83CB84F2F; Tue, 28 Apr 2026 15:18:35 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378716; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=3j1c5EDJo/k0wJE4iA56/aLTF1LlfKvBBoU57CDpPI0=; b=Ut5dmycgl0MTskgmiV0OweNxV2ksKVK1vIeXLeNgoQ7ECDiRAOLJ55VWPmckT2UEz21cDO KFPgfMS2jcb8v7URYl8TCHtwU638tUQSfYPN0zoqILQIZWhu0fiqAOBAdLj2FNVWZvb9Id et/ymDZEepTIM6KtTVIryYQzY2ooNTEIyFOAmNLL5gc/Ry5StzpwgmYSjRjpfAXysCxaL6 jtVDukgK1fugYH54R1HOBsAWdCZO8tZBOm/BIKHB+iGPCz21HdKBLqxZ1cVbM5rwEodYji oaz9i7qv23S9HdvnmO9r+Y54T5lbDslVjeBsDl+ZWdnLwM/gH/7BfefO8Q0SH8WonR814s pRYyH+uFxndovdB8rMjYg8DzDiLDoDlVtWLcvUuWYul9l04eH2RH6cVx8enpJXcXGB89wJ YAxWgLXtpYxsInuzCrtvB2YAiWqQV1bOcJSMRzWW3KfYqMPcNvg21fKyqOenfpXqKNzM9g 844jJobkL072Ia5Kp00gO5CKdv7OuAk3XcmDuNMMR6ymkq2DTgkG3hCsJ31iYydK6N7YbU jPu78Wb4a0WZtzmgsFN46VU2CpLKY0OsvF6Ds7bExUXPV5bhvEiOTzA+YkfPQou1gnLBok R6+zA3UWwvmQUn4R3xikUebZAWIHBzdYoB4K1mIpbXFs/H8jw3LHk= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 4/8] staging: rtl8723bs: rtw_mlme: wrap rtw_sitesurvey_cmd condition Date: Tue, 28 Apr 2026 15:15:47 +0300 Message-ID: <20260428121737.435248-5-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Inline rtw_sitesurvey_cmd() directly in the if condition to reduce line length. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index a35d726b803c..caaad38dd790 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -772,9 +772,9 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) rtw_indicate_connect(adapter); } else { if (rtw_to_roam(adapter) !=3D 0) { - if (rtw_dec_to_roam(adapter) =3D=3D 0 - || _SUCCESS !=3D rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid,= 1, NULL, 0) - ) { + if (rtw_dec_to_roam(adapter) =3D=3D 0 || + rtw_sitesurvey_cmd(adapter, &pmlmepriv->assoc_ssid, + 1, NULL, 0) !=3D _SUCCESS) { rtw_set_to_roam(adapter, 0); rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEF9B40FDA5 for ; Tue, 28 Apr 2026 12:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378726; cv=none; b=RWrdFrkrHrGu3AOZHXvXMPOs/XG8Zp4g5CeIli6h/100kOgvmCwz1Wmrr1HChaM4cBAO4Tnm9jSamsPuFrMegSJleY/ScTOqhRAtmyLw/MHtwShb1UeqNEkjuEndDZRPjERd6UldvDc0Tz5i8XvXPvP2kXZcPojXiXabzY4wpj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378726; c=relaxed/simple; bh=Jx4iZ/8PkdZK0lhQE9y4lhz7CbHXyh8Md20GdYFe2lo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SAfJil0KIfkUjuXRIakszS8N/lCcgMv55PXFNN9vwOzYFJRKmnI+3Glt82IBE/UeTQ+BXIbkQ9Uy8t3gEKmIscSG4gJb1hpCcoaDQIxCXC1zNkYqqIAMpsBDL5RaMJ6/UqmNl//m8hQD+buZ9j8lcE/EXLB585TXc7YcRbdTKtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=MGlOrLLS; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="MGlOrLLS" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 1533184E96; Tue, 28 Apr 2026 15:18:37 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378718; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=/9hZhd+L1lrNW0W/JPYcPQAcCjjih863/GC3B5PxJX4=; b=MGlOrLLScpW9fptJd0i+xtf1fEZe/I40+2r4KJIikWnG3Q/3JFkaZD0By/kTBxk/XtUnCh 2Ku4riEVqXyj4IUvsIe+ken2Dnd2o2DQzlSYe5DV/h/tdCizyiYwjxgL8xIQJRMzSwriLA Kts2Gr/M7Y5pviWxoH8JSW3kDIdiVTemQinfCCfEBjBZj7eRb5wJZgehmy85JSEqmwl1KN rF0LipxSrj69NPflA7oSlpUpuGo46QKdE2hg+TeKpI70Pej7cVWHP1+QoXj3bYKZnkXtpt 1G5mgfzfkDZAkLmotVBFXg+ScK0iGAElUGdkaT90tlxg5qbjNbLThiXKEuukQutjYxUW5g iiF9XR5F87G0b61IE7gldKuLoefLD64qdOSWL5cgYonYhZ1ErAiYdQuiL0rLGUrAu+ja9E EBr+3S0X5UX7+on0R2K3Ak4mzErETDFcPjjj3tyGiS5Ux02PSdfQEyKL1dA+KkDtDgXZJF CYbFV4HA0UWIewBhHSR/hgyvlVtK+LtSLImQ5/+jYGWxhnYVXr/SSA4jR1Mp8w9R4kVD+6 Uxq6iNlDzzDGIFPbRHm3oJCpCjQZPDMIrMjefIJavjS7MsJtfHGqJqHJ6AXZL6O/PnKw4W LAETSNHDDy8Iq0YzoJ7o92WAe9iJwFlTg/vARjfCZzQGylW8geyn8= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 5/8] staging: rtl8723bs: rtw_mlme: extract local variables for long expressions Date: Tue, 28 Apr 2026 15:15:48 +0300 Message-ID: <20260428121737.435248-6-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Extract local variables to shorten lines that cannot be wrapped cleanly. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 49 +++++++++++++++-------- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index caaad38dd790..c7609f1a90f6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -474,12 +474,16 @@ static void update_current_network(struct adapter *ad= apter, struct wlan_bssid_ex =20 if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->cur_network.network, pnetwork, 0))) { + u32 ie_len; + u8 *ie; + update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); - if (pmlmepriv->cur_network.network.ie_length < sizeof(struct ndis_802_11= _fix_ie)) + ie_len =3D pmlmepriv->cur_network.network.ie_length; + if (ie_len < sizeof(struct ndis_802_11_fix_ie)) return; =20 - rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), - pmlmepriv->cur_network.network.ie_length - sizeof(struct ndis_802_= 11_fix_ie)); + ie =3D pmlmepriv->cur_network.network.ies + sizeof(struct ndis_802_11_fi= x_ie); + rtw_update_protection(adapter, ie, ie_len - sizeof(struct ndis_802_11_fi= x_ie)); } } =20 @@ -650,7 +654,13 @@ static bool rtw_is_desired_network(struct adapter *ada= pter, struct wlan_network bselected =3D false; =20 if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { - if (pnetwork->network.infrastructure_mode !=3D pmlmepriv->cur_network.ne= twork.infrastructure_mode) + enum ndis_802_11_network_infrastructure inf_mode; + enum ndis_802_11_network_infrastructure cur_inf; + + inf_mode =3D pnetwork->network.infrastructure_mode; + cur_inf =3D pmlmepriv->cur_network.network.infrastructure_mode; + + if (inf_mode !=3D cur_inf) bselected =3D false; } =20 @@ -735,9 +745,10 @@ void rtw_surveydone_event_callback(struct adapter *ada= pter, u8 *pbuf) if (rtw_select_and_join_from_scanned_queue(pmlmepriv) =3D=3D _SUCCESS)= { _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { + struct wlan_bssid_ex *pdev_network =3D ®s->dev_network; + struct registry_priv *regs =3D &adapter->registrypriv; + u8 *pibss =3D regs->dev_network.mac_address; u8 ret =3D _SUCCESS; - struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_= network; - u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; =20 /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY; * because don't set assoc_timer @@ -792,8 +803,10 @@ void rtw_surveydone_event_callback(struct adapter *ada= pter, u8 *pbuf) if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && check_fwstate(pmlmepriv, _FW_LINKED)) { if (rtw_select_roaming_candidate(pmlmepriv) =3D=3D _SUCCESS) { - receive_disconnect(adapter, pmlmepriv->cur_network.network.mac_address - , WLAN_REASON_ACTIVE_ROAM); + u8 *mac_addr =3D pmlmepriv->cur_network.network.mac_address; + + receive_disconnect(adapter, mac_addr, + WLAN_REASON_ACTIVE_ROAM); } } } @@ -1069,8 +1082,9 @@ static void rtw_joinbss_update_network(struct adapter= *padapter, struct wlan_network *ptarget_wlan, struct wlan_network *pnetwork) { - struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + u8 signal_strength =3D ptarget_wlan->network.phy_info.signal_strength; struct wlan_network *cur_network =3D &pmlmepriv->cur_network; + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 /* why not use ptarget_wlan?? */ memcpy(&cur_network->network, &pnetwork->network, pnetwork->network.lengt= h); @@ -1082,12 +1096,12 @@ static void rtw_joinbss_update_network(struct adapt= er *padapter, =20 rtw_set_signal_stat_timer(&padapter->recvpriv); =20 - padapter->recvpriv.signal_strength =3D ptarget_wlan->network.phy_info.sig= nal_strength; + padapter->recvpriv.signal_strength =3D signal_strength; padapter->recvpriv.signal_qual =3D ptarget_wlan->network.phy_info.signal_= quality; /* the ptarget_wlan->network.rssi is raw data, we use * ptarget_wlan->network.phy_info.signal_strength instead (has scaled) */ - padapter->recvpriv.rssi =3D translate_percentage_to_dbm(ptarget_wlan->net= work.phy_info.signal_strength); + padapter->recvpriv.rssi =3D translate_percentage_to_dbm(signal_strength); =20 rtw_set_signal_stat_timer(&padapter->recvpriv); =20 @@ -1740,8 +1754,9 @@ void rtw_set_scan_deny(struct adapter *adapter, u32 m= s) static int rtw_check_roaming_candidate(struct mlme_priv *mlme , struct wlan_network **candidate, struct wlan_network *competitor) { - int updated =3D false; struct adapter *adapter =3D container_of(mlme, struct adapter, mlmepriv); + int updated =3D false; + long rssi_diff; =20 if (is_same_ess(&competitor->network, &mlme->cur_network.network) =3D=3D = false) goto exit; @@ -1759,7 +1774,8 @@ static int rtw_check_roaming_candidate(struct mlme_pr= iv *mlme if (jiffies_to_msecs(jiffies - competitor->last_scanned) >=3D mlme->roam_= scanr_exp_ms) goto exit; =20 - if (competitor->network.rssi - mlme->cur_network_scanned->network.rssi < = mlme->roam_rssi_diff_th) + rssi_diff =3D competitor->network.rssi - mlme->cur_network_scanned->netwo= rk.rssi; + if (rssi_diff < mlme->roam_rssi_diff_th) goto exit; =20 if (*candidate && (*candidate)->network.rssi >=3D competitor->network.rss= i) @@ -2133,7 +2149,7 @@ static void rtw_report_sec_ie(struct adapter *adapter= , u8 authmode, u8 *sec_ie) =20 wrqu.data.length =3D p - buff; =20 - wrqu.data.length =3D (wrqu.data.length < IW_CUSTOM_MAX) ? wrqu.data.leng= th : IW_CUSTOM_MAX; + wrqu.data.length =3D umin(wrqu.data.length, IW_CUSTOM_MAX); =20 kfree(buff); } @@ -2521,14 +2537,15 @@ void rtw_update_ht_cap(struct adapter *padapter, u8= *pie, uint ie_len, u8 channe if ((cbw40_enable) && (le16_to_cpu(pmlmeinfo->HT_caps.u.HT_cap_element.HT_caps_info) & BIT(1)) && (pmlmeinfo->HT_info.infos[0] & BIT(2))) { + u8 *mcs_rate =3D pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate; int i; =20 /* update the MCS set */ for (i =3D 0; i < 16; i++) - pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate[i] &=3D pmlmeext->default_= supported_mcs_set[i]; + mcs_rate[i] &=3D pmlmeext->default_supported_mcs_set[i]; =20 /* update the MCS rates */ - set_mcs_rate_by_mask(pmlmeinfo->HT_caps.u.HT_cap_element.MCS_rate, MCS_R= ATE_1R); + set_mcs_rate_by_mask(mcs_rate, MCS_RATE_1R); =20 /* switch to the 40M Hz mode according to the AP */ /* pmlmeext->cur_bwmode =3D CHANNEL_WIDTH_40; */ --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA499413224 for ; Tue, 28 Apr 2026 12:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378733; cv=none; b=KBMsmoCh+5U6y2h+YbPG0J+5iJni/cbhiZQs5uWaCdQFnNgPXDxx1+Z767X6PnVhgEG2Z8gKr2lVFhkYNcGYN5hnI//SrCgl0THmD2FDZimU790vA9gTl88AL/wFeMZLaqe2atK6l8iJYfx8VjP8Sv4S7Tf50klaB2gXvXxCTmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378733; c=relaxed/simple; bh=G6aKC3HcCwP+O2rG+xjqgcAYArlrkty+9SfYpXkkUpY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sylTdiXrwCM8Abcw+Be2Aj3RZKeEZgJcB+0UU48fYyXHMif/YSTp26PcxFWjpA68qKEI669rVR7mbDfrFnW2pGxOaYmSK8rF/fI4fgfgAP7byb2WU9qZ8ZfDFi/RjDgmxpSb+3ccETJqlvGJpFmDf+HFHHPrM+q0KO0rZwPTgCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=KvI9sVsY; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="KvI9sVsY" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id DA1ED84F92; Tue, 28 Apr 2026 15:18:39 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378720; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=kFvDTsN2MhkZtwxwVEdUWnBNobaewOC55DBgan3fkro=; b=KvI9sVsYxJ1d2bjiHeRKGTzjYL+nmFTlCYPzWBlD+B3YrponzTmaI4jk7qI3nH3ZFOK7ct nvviffQioAAV9VxgUVCHPaCldOJhBK4rq9IlaH3hBpTOD841yVO93knmnC+FusZrdOXa0W MGgPmnLzGp4olGuwfq+cVpjsYVrFdsEgi3ePjU3xGlBMvwf0MoDOTj/N8It2svVIikrqur IfjI3+83561XmTBNLagJwAMOXI2u1V22B5U/HV7DifVLiH+UrmZcZjlkXb6S/FLepkYo+1 1Brl/rit5F/+KdHrAekLvaGNMiGaIdt0C8ssJBkGbgzs/Av60jfBD9bJtxECHlWpftJO7L Xz+VedFZUI1fBjLdPW1EQjri+5cTYhsTjK0TdTXPYOG4UH4q86z+NAlm/M2fiVhJOCW0Rx 8VMDKATSkZltL7DQmU6qzOap3s4z+sLLh9QVlZ+hhdpqQjBG8rD2noKo+DNViVJOnWlIYk T5RUt5RekbVAViSwLLiV4/f12omrNdbN6irY5hmo0OPDyM40YnHWO6fj2BNQPOeX0NXSGn 2GQ406V8943P0PRfIb1KcYKr5J9K5kbCQZ/Cv7CVorlvhB3W/4GI9C2LIToMP9d3+4hg63 lP2KUyOMmrFxG2VZsP6zuRamgwdaGrSiwEQjNZCDlLUzX5VBY+YoE= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 6/8] staging: rtl8723bs: rtw_mlme: remove dead commented-out code Date: Tue, 28 Apr 2026 15:15:49 +0300 Message-ID: <20260428121737.435248-7-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Remove commented-out code and its associated orphaned comments. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index c7609f1a90f6..df3b31a7b2b2 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -750,9 +750,6 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) u8 *pibss =3D regs->dev_network.mac_address; u8 ret =3D _SUCCESS; =20 - /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY; - * because don't set assoc_timer - */ _clr_fwstate_(pmlmepriv, _FW_UNDER_SURVEY); =20 memcpy(&pdev_network->ssid, &pmlmepriv->assoc_ssid, @@ -1707,14 +1704,8 @@ void rtw_dynamic_check_timer_handler(struct adapter = *adapter) linked_status_chk(adapter); =20 should_enter_ps =3D traffic_status_watchdog(adapter, true); - if (should_enter_ps) { - /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */ + if (should_enter_ps) rtw_hal_dm_watchdog_in_lps(adapter); - } else { - /* call rtw_lps_ctrl_wk_cmd(padapter, LPS_CTRL_LEAVE, 1) - * in traffic_status_watchdog() - */ - } =20 } else { rtw_dynamic_chk_wk_cmd(adapter); @@ -2249,19 +2240,11 @@ void rtw_update_registrypriv_dev_network(struct ada= pter *adapter) /* 1. Supported rates */ /* 2. IE */ =20 - /* rtw_set_supported_rate(pdev_network->supported_rates, pregistrypriv->w= ireless_mode); - * will be called in rtw_generate_ie - */ sz =3D rtw_generate_ie(pregistrypriv); =20 pdev_network->ie_length =3D sz; =20 pdev_network->length =3D get_wlan_bssid_ex_sz((struct wlan_bssid_ex *)pd= ev_network); - - /* notes: translate ie_length & length after assign the - * length to cmdsz in createbss_cmd(); - */ - /* pdev_network->ie_length =3D cpu_to_le32(sz); */ } =20 /* the function is at passive_level */ --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03BCD41B379 for ; Tue, 28 Apr 2026 12:18:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378736; cv=none; b=KY1kJy/SA/GOeOw6nYxW9h/BUNiSLdkT++PX2/mhasRTuDKhuEWQlFDLRF6hyA/huNU5to7c31T805+Ki3UKmoUlSB7rYBOFmFuE2fpABduPAR/Xx6y3TuJqpwAwWRBP1D3Lycx8cGsmETicBx+aY7kHzAbEcEHD9fddM2GB7Xg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378736; c=relaxed/simple; bh=4oPRHlp1TA+xAu30VMJI2Ziz8BoJI60ei2Jl4UZOEQQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jOXuZsg2ZBOwKskkUwwEequYEq9DY+m8EsZ3PiplFlQB/CNrN3GAKX6xf/8Cl32fnx+WGmwCnZdBXrwxoY+G5A86jhr2zZ54h07oH1JF3pg4ghn5A8rvaD52kAbLQqFs+1kyT7ZaX4UJrFBEeS6FETy2D6joGRqxDCWZolxpJJ4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=YEK1zwvF; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="YEK1zwvF" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id E4BED84F26; Tue, 28 Apr 2026 15:18:41 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378722; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=xf24lWYS9QBox5ZzKTLZ8LhqQa88WCWB0CzK6FFDFEs=; b=YEK1zwvFEOX9YmA3xl2yiuWNLmdH158q25MqVnKkLTdyGBZjLC9/Ss+z0tVqxxVzh9enuS CqZeuaV9/TFsRCMjh6ldqT2EPnx40tlZekrJug46nm5UKKT3GgALKTt+HINutYAqEAyvPs 54tGM6GSGoOywToBBqlCVQUOC6Ggob8BjY8CStRiDpS9KUadnNBxqbaOaNUVohiOz39Swc ef9lcbhhzo6hkYZOINdQX3/Yq48SC9nl5Au16w19vGHKlJ04B67muo57HLwcN5t5NFaBZL EsLOp5/iqll2KjweLfFI8mYefCQAyUr5ZZS4LkQD9P4DdhKHY6QTUVYYiCx5UPbRZBJ0uF iVG2WgT91f/3sdeTW2C6chmv1o8ANwJVJN9Rse53KkRY0sdpbG/ZBuCmiG8eWiMaLQHijR f9KOhodLyfDNHxi/6g4lqifU7vXn/BM4iE5dp8wszTXls1Pfs93xNzG2q/ns5n7rurFvhm 9X2kVm2kGSmaDOk8Kx5Rs2WIlz8T0lOq8yna2tMyRoHItUFs2NLk0IwL6ODLXzqTCMVE7D eAwlqKehuGaOWpWX5sb/AsewyVZVIfOu73rlyQtwgA9ubatGy1yGBp6XtZ5oJiS/PloLVj tx3k7LjbAtJ44OkkrEkZcapstF2TCOHx9IIPSftP7o2Cgi+7m29Hc= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 7/8] staging: rtl8723bs: rtw_mlme: consolidate capability comparisons lines Date: Tue, 28 Apr 2026 15:15:50 +0300 Message-ID: <20260428121737.435248-8-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Place capability comparisons on single lines. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index df3b31a7b2b2..9ebaed8bd7e1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -367,10 +367,8 @@ int is_same_network(struct wlan_bssid_ex *src, struct = wlan_bssid_ex *dst, u8 fea return (src->ssid.ssid_length =3D=3D dst->ssid.ssid_length) && ((!memcmp(src->mac_address, dst->mac_address, ETH_ALEN))) && ((!memcmp(src->ssid.ssid, dst->ssid.ssid, src->ssid.ssid_length))) && - ((s_cap & WLAN_CAPABILITY_IBSS) =3D=3D - (d_cap & WLAN_CAPABILITY_IBSS)) && - ((s_cap & WLAN_CAPABILITY_ESS) =3D=3D - (d_cap & WLAN_CAPABILITY_ESS)); + ((s_cap & WLAN_CAPABILITY_IBSS) =3D=3D (d_cap & WLAN_CAPABILITY_IBSS)) = && + ((s_cap & WLAN_CAPABILITY_ESS) =3D=3D (d_cap & WLAN_CAPABILITY_ESS)); } =20 struct wlan_network *_rtw_find_same_network(struct __queue *scanned_queue, --=20 2.54.0 From nobody Wed Jun 17 02:50:07 2026 Received: from mail.cipherat.com (mail.cipherat.com [91.98.42.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B253FBEA6 for ; Tue, 28 Apr 2026 12:18:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.98.42.103 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378739; cv=none; b=unAkNK0Erk7SVacj0F8db8HSEm0TfkO9SARM6ZJWkZq6irdwLvYXTgQnbQuJmPBi5uFmKTbN7QFSbSBbLW7sbP5i7bmPPziHxH+ntJDSmQM1Kff2GGCi/dhruumtR9zpKFjYcZpCpFTKtgLkizE1hfEQ5gU3zRLKoujfl+AQAds= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378739; c=relaxed/simple; bh=gX5EVB9aJduPQXEjF34/u5ebEZMDxiDXBmFbNa8ezdY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dj85hsDPZaSpjOnKAjqe4d3H5Fgnm6w3h01EjfWBN5IAZgD1NA+NZmWwlZpbWxCeq70BmIDttmVzJEVxaezfgywWBMB5FH0jAKONuQLbQMDZhJ+Il03f+ChuqugKP2d+0Fk05S01UNyB9jeJmBcQkaiKoNznQ2pA0Hp96gZ7rIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com; spf=pass smtp.mailfrom=cipherat.com; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b=tpq+kqMz; arc=none smtp.client-ip=91.98.42.103 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cipherat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cipherat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=cipherat.com header.i=@cipherat.com header.b="tpq+kqMz" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C2EFE84F94; Tue, 28 Apr 2026 15:18:47 +0300 (+03) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cipherat.com; s=dkim; t=1777378728; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=JWbGjNQSz1N1X/fRbDPnaKjDxLta5ws0P6n36UQYDhU=; b=tpq+kqMzMhClBDqpWtIG4A6kGT5OuMq0ZOUeY5VMI7DqvpHuhGlILNyJQ/eepZG8/nPSiu DMfPCkwZgPo5SBaRjwk6cocne+WU2F8ARi3pFKZ+gnEsEVC2hFHf9SlONyU9qAIL5vVjNu LNU6K6eDAPbiWHkO7PxPjcxgjwW2Tza8RoyQV2acyV5ASLne6jlR2KU3muI0siwVSsVFYn UaFvtKMN0N7JOhqTGh3XhrSoY5kx9zTzw2LLxl5V//Njavu6PYBYfIJhLhR3BRlHblnsO/ 77+wQ/tjc1BS9xZv5PfulVuKZnKlIXFwHNYFfsY0GbkncU3LjaclJaf2fIut1th2UbjNZL poSAAChYNnVVmP9VZL6t8wOgo9rQV4uJxzmvdG7yt8O0xWZ37k+8yrZL5YzPqbeP8Y/011 VSKClUomXekzTfPv/7cvaf+f5ps7Ioiu1O8+kpq67Vzsz0B2FzBdPhsZ+8xRd1qmpnfZLO /GS1/D73PbX+BNgIFk76k5vt+S4teDhiB8MbnLfWNF2AigJqLsESsbsNIrx4r+VwL8BFyi zw5/BGbcINy5tHqYfsuom+zfSfWYBBvtcmSR+ZfRLnTEemyZ/z56P6Br72OICkCB0TUBJp K99LHN+vFho24Gx+d7eTMlyFWS92t3Qw9pBJtZRDWYJbt+gAFfey4= From: Salman Alghamdi To: gregkh@linuxfoundation.org Cc: luka.gejak@linux.dev, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 8/8] staging: rtl8723bs: rtw_mlme: add blank line for readability Date: Tue, 28 Apr 2026 15:15:51 +0300 Message-ID: <20260428121737.435248-9-me@cipherat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260428121737.435248-1-me@cipherat.com> References: <20260428121737.435248-1-me@cipherat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Add a blank line between the WIFI_UNDER_WPS block and the wifi_spec block to improve readability. Signed-off-by: Salman Alghamdi --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 9ebaed8bd7e1..8d20852c1afd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -626,6 +626,7 @@ static bool rtw_is_desired_network(struct adapter *adap= ter, struct wlan_network else return false; } + if (adapter->registrypriv.wifi_spec =3D=3D 1) { /* for correct flow of 8= 021X to do.... */ u8 *p =3D NULL; uint ie_len =3D 0; --=20 2.54.0