From nobody Wed Jun 17 02:58:20 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4578401A16 for ; Tue, 28 Apr 2026 12:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378369; cv=none; b=iYy/x0mIQA7uBWT3wP/uXRyQwH4jO50GtSD/hPVrPAFwtgKFwtX7aJPhEx2Ck3UcxIH0m7ls5q8K16kfH7cygFBr9D16JrzS9BMD7b5uoZ41IryEUpvul79/VZ9lgGHjfEoeLC1+h+fpkgJiCLFFoXaYrVesjzdRKPueclYIaQY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378369; c=relaxed/simple; bh=LfcsFKh/yMjIVUle7LYb3no4VKeh1Bayg+Vboakf8KE=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=QzjXI70YAiBFL6EWOy4r95+ZV9Z9NjG8iEuLei3yJt+/dd6n8wCXolA9hlHWZR7r1IaK3QkToRquv2SNeYZTEzB57SeYxn/aQ8AT+J7VDhJ4IolA0utCp/ozY7902ofXyTD4TH0gdDMhIu7O+MVmZ07bzTPsw7tFb0Q31gZT3g8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dijp4O6l; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dijp4O6l" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82f351ca23cso5801994b3a.2 for ; Tue, 28 Apr 2026 05:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777378365; x=1777983165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uOXUGxE/2PZw22xiOq1ZdUJVIRc77wK4Q0pq53UzmqI=; b=Dijp4O6lo2wHwdsZxw+93tsu4g5Wszf/TaCVnLW003UCwQa90ccVYeMeycGhQZjhhu VSp9fYbkaeV55r73bELzpGqk6BQaxhd1Ba+dM0jZQzbNfVoxy5MDvVITAWsv8+6Y7AV7 zqtl6KGdfkSn+No+4toClUucqemnKZT4/05dfETR0rOvEIqoUhXmGZpSfHUpKNUVbrff 2a5aobDct/E974vSyazHr2Gq8xhDcCvAvAHkGXAE32WcDaJ4CMR1CLW/imTCCmzi41ZR iZvoKdcNsi34qQl6jfOFxImip+yWc6k475ubaS97v1agM/GpbgXMfSXZi0PLbPwAUxhR DlYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777378365; x=1777983165; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uOXUGxE/2PZw22xiOq1ZdUJVIRc77wK4Q0pq53UzmqI=; b=CeseKLoMOIfhvqGlmIod4kbwMeNosn2qtifrwmxt7WkO3hlzFlJxlGnVHWOxdqFsCR Q0feDMIR7M8l+XlaWsELL2/EDaL+kdxD04CXaUwR4/JC9LiExEDZ4eGUhV/vn5i+U0aL 2C2t82slo/3FM+rSxvd5Xp+7RlK6Q5AKJ3x/6bxzy8zUzqn1gwpeLAulj42QPsz4q9Ch H8/hFTVSPH0VG+ZLQWZO2EuqPU1XZUYGovpBu7twfRJuaxI0JbfyttlDJxJkIgk+Nm7l uZn1SgoUEAXSmNWtpZcZ4Of6smnSq9ABlpi9ZD3KadxJqBNXaoke4zP97C5z9oEiyiWX 8xAg== X-Forwarded-Encrypted: i=1; AFNElJ/dQHphtdWpUwtLt6FW14eAJdMNB4enTHrRqSQo3nKPVSRDdWIXrQnuZfXp5d9LqjO0yIo6Ke0JTcW9czM=@vger.kernel.org X-Gm-Message-State: AOJu0YyHYB5wiSvm/qTYTMYuqSdZgnMi2qQMTJ3pB0NrI/TMVtGYAT72 3BpnsPX4WABwVXq3iOpkLVUK1jmSXQyp+kITx4337X0+mBKVN9fO6dHZ1lmUq2tSdpODpQ== X-Gm-Gg: AeBDietDvIXCmPMMPV14fKjWmKdXFLeSkLKs9XDnxorbPRgdMkpHZgtBo/IDbtz4kBs 8lnxkQYvasTclchSXOZCn8x2S29SQCqIfpCOzvngAfXE777A5jug1NXWpKD35hcefBzugHPDWK0 trDDj5PGLaUpP/w1IBrK8+3yMFb0xRAyNGdAzoaa7XUakGPMMk6i5aXubo8NMEpdjLrEYTBouwK XDn/M4VBHgn26yLno9xZFdh8Y5sWrqoNldwQSfXFAXHYOQJMRXj1fiCysjvbvNzDauHmYqOBk3j oqgS8ZFh7/z6CR7Ytfo63B+MemlgMmHAjJc7a8aEipb7VXyMIF45Pzm7bNVr0CPAoUYLmXaXRAF gQOPeScpbPeh/CUD8UQt/24tnQpogiAKbWunT7Z5zI8raJFhbUKptbM2Gra8OkrWZTTNmNClpgG VnDbBljjq372f63oDw5NAFT9Q= X-Received: by 2002:a05:6a20:3d12:b0:39f:aa3:5e56 with SMTP id adf61e73a8af0-3a39c0c8c97mr3370487637.14.1777378364800; Tue, 28 Apr 2026 05:12:44 -0700 (PDT) Received: from lgs.. ([101.36.106.88]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7fc33d82dfsm2424640a12.25.2026.04.28.05.12.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 05:12:44 -0700 (PDT) From: Guangshuo Li To: Guangshuo Li , Kees Cook , Mike Waychison , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH] firmware: dmi-sysfs: fix error handling in dmi_system_event_log() Date: Tue, 28 Apr 2026 20:12:30 +0800 Message-ID: <20260428121230.366235-1-lgs201920130244@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Once kobject_init_and_add() has been called, the error path should call kobject_put() to decrement the reference count for cleanup. Freeing the object directly with kfree() bypasses the kobject cleanup path. If sysfs_create_bin_file() fails, kobject_del() removes the kobject from sysfs, but kobject_put() is still needed to drop the reference count and release the object. Fix this by replacing kfree() with kobject_put(). Then the object can be freed by the release callback through kobject_cleanup(). This issue was found by a static analysis tool I am developing. Fixes: 925a1da7477f ("firmware: Break out system_event_log in dmi-sysfs") Signed-off-by: Guangshuo Li --- drivers/firmware/dmi-sysfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/dmi-sysfs.c b/drivers/firmware/dmi-sysfs.c index cda53d037715..adef7e379cbb 100644 --- a/drivers/firmware/dmi-sysfs.c +++ b/drivers/firmware/dmi-sysfs.c @@ -459,7 +459,7 @@ static int dmi_system_event_log(struct dmi_sysfs_entry = *entry) &entry->kobj, "system_event_log"); if (ret) - goto out_free; + goto out_put; =20 ret =3D sysfs_create_bin_file(entry->child, &bin_attr_raw_event_log); if (ret) @@ -469,8 +469,8 @@ static int dmi_system_event_log(struct dmi_sysfs_entry = *entry) =20 out_del: kobject_del(entry->child); -out_free: - kfree(entry->child); +out_put: + kobject_put(entry->child); return ret; } =20 --=20 2.43.0